)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bc22ab8690d530f264a0f86fc206391b62f321d4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"tagged in 2.32 and network interfaces between 2.32 and 2.36"},{"line_number":14,"context_line":"inclusively. This spec introduces a new API microversion that re-adds"},{"line_number":15,"context_line":"the tag attribute to both block_device_mapping_v2 and networks."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I37cec158c6f998143842ad44f739fe2031d75eef"},{"line_number":18,"context_line":"Implements: blueprint fix-tag-attribute-disappearing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a461143_d5a8c022","line":16,"updated":"2017-01-30 17:19:50.000000000","message":"nit: should have the APIImpact tag in here.","commit_id":"f79fdc749bc2952e68ce6191954caa2d3c1fafe0"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"cbc861ec1357565a99b88758cc2ce77521fd5184","unresolved":false,"context_lines":[{"line_number":13,"context_line":"tagged in 2.32 and network interfaces between 2.32 and 2.36"},{"line_number":14,"context_line":"inclusively. This spec introduces a new API microversion that re-adds"},{"line_number":15,"context_line":"the tag attribute to both block_device_mapping_v2 and networks."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I37cec158c6f998143842ad44f739fe2031d75eef"},{"line_number":18,"context_line":"Implements: blueprint fix-tag-attribute-disappearing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a461143_d82d57a9","line":16,"in_reply_to":"3a461143_d5a8c022","updated":"2017-01-30 17:33:05.000000000","message":"Done","commit_id":"f79fdc749bc2952e68ce6191954caa2d3c1fafe0"}],"specs/ocata/approved/fix-tag-attribute-disappearing.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bc22ab8690d530f264a0f86fc206391b62f321d4","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Fix tag attribute disappearing"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/nova/+spec/fix-tag-attribute-disappearing"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a461143_356ae4ee","line":11,"updated":"2017-01-30 17:19:50.000000000","message":"nit: you could remove this line","commit_id":"f79fdc749bc2952e68ce6191954caa2d3c1fafe0"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"cbc861ec1357565a99b88758cc2ce77521fd5184","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Fix tag attribute disappearing"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/nova/+spec/fix-tag-attribute-disappearing"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a461143_d81e37ba","line":11,"in_reply_to":"3a461143_356ae4ee","updated":"2017-01-30 17:33:05.000000000","message":"Done","commit_id":"f79fdc749bc2952e68ce6191954caa2d3c1fafe0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bc22ab8690d530f264a0f86fc206391b62f321d4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"comparison in [2]_. It causes the Nova API to accept the tag attribute only in"},{"line_number":28,"context_line":"microversion 2.32. The intent was of course to support tags in all versions"},{"line_number":29,"context_line":"greater than or equal to 2.32, but the implementation mistake was missed both"},{"line_number":30,"context_line":"by the author and the reviewers."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"In the case of networks, microversion 2.37 introduced a new choice for the"},{"line_number":33,"context_line":"network item in the instance boot request body [3]_. In addition to the"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a461143_753e2cdb","line":30,"updated":"2017-01-30 17:19:50.000000000","message":"and tests :)","commit_id":"f79fdc749bc2952e68ce6191954caa2d3c1fafe0"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"cbc861ec1357565a99b88758cc2ce77521fd5184","unresolved":false,"context_lines":[{"line_number":27,"context_line":"comparison in [2]_. It causes the Nova API to accept the tag attribute only in"},{"line_number":28,"context_line":"microversion 2.32. The intent was of course to support tags in all versions"},{"line_number":29,"context_line":"greater than or equal to 2.32, but the implementation mistake was missed both"},{"line_number":30,"context_line":"by the author and the reviewers."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"In the case of networks, microversion 2.37 introduced a new choice for the"},{"line_number":33,"context_line":"network item in the instance boot request body [3]_. In addition to the"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a461143_187b5ff6","line":30,"in_reply_to":"3a461143_753e2cdb","updated":"2017-01-30 17:33:05.000000000","message":"Reviewers, Author and Tests - the RAT trifecta ;)\nDone.","commit_id":"f79fdc749bc2952e68ce6191954caa2d3c1fafe0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bc22ab8690d530f264a0f86fc206391b62f321d4","unresolved":false,"context_lines":[{"line_number":181,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"A functional test will be added for the new API microversion. The existing"},{"line_number":184,"context_line":"Tempest test will be modified to test all microverions that support device"},{"line_number":185,"context_line":"tagging at instance boot time."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a461143_7844631a","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":12},"updated":"2017-01-30 17:19:50.000000000","message":"Do you mean this guy?\n\nhttps://github.com/openstack/tempest/blob/248b74561b7abb2284855cf4e41314ccf308ec0f/tempest/api/compute/servers/test_device_tagging.py\n\nI\u0027m not really sure how you\u0027re going to handle that one. At a minimum I\u0027d think you\u0027d be testing 2.32 and 2.42 (assuming 2.42 is the new microversion for this spec).","commit_id":"f79fdc749bc2952e68ce6191954caa2d3c1fafe0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bc22ab8690d530f264a0f86fc206391b62f321d4","unresolved":false,"context_lines":[{"line_number":181,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"A functional test will be added for the new API microversion. The existing"},{"line_number":184,"context_line":"Tempest test will be modified to test all microverions that support device"},{"line_number":185,"context_line":"tagging at instance boot time."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a461143_f8b4d335","line":184,"range":{"start_line":184,"start_character":42,"end_line":184,"end_character":54},"updated":"2017-01-30 17:19:50.000000000","message":"microversions","commit_id":"f79fdc749bc2952e68ce6191954caa2d3c1fafe0"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"cbc861ec1357565a99b88758cc2ce77521fd5184","unresolved":false,"context_lines":[{"line_number":181,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"A functional test will be added for the new API microversion. The existing"},{"line_number":184,"context_line":"Tempest test will be modified to test all microverions that support device"},{"line_number":185,"context_line":"tagging at instance boot time."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a461143_98602f03","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":12},"in_reply_to":"3a461143_7844631a","updated":"2017-01-30 17:33:05.000000000","message":"Yeah, him. I\u0027ve linked to the review instead of the github blob - more permanent in case stuff changes with time.\n\nGood point, there\u0027s no mechanism to have it cover all microversions short of running it once for each. At a minimum 2.32 and 2.42 should be covered, as you said.","commit_id":"f79fdc749bc2952e68ce6191954caa2d3c1fafe0"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"cbc861ec1357565a99b88758cc2ce77521fd5184","unresolved":false,"context_lines":[{"line_number":181,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"A functional test will be added for the new API microversion. The existing"},{"line_number":184,"context_line":"Tempest test will be modified to test all microverions that support device"},{"line_number":185,"context_line":"tagging at instance boot time."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a461143_f853f336","line":184,"range":{"start_line":184,"start_character":42,"end_line":184,"end_character":54},"in_reply_to":"3a461143_f8b4d335","updated":"2017-01-30 17:33:05.000000000","message":"Done","commit_id":"f79fdc749bc2952e68ce6191954caa2d3c1fafe0"}]}