)]}'
{"specs/pike/approved/support-vgamem.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fadd8a2273eb914b02858bebef2cf0ff73645db8","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/support-vgamem"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This will allow user to set vgamem by setting hw_video_vgamem via the image"},{"line_number":14,"context_line":"properties in Glance in the same way as hw_video_ram."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_eb5bcd2c","line":13,"range":{"start_line":13,"start_character":46,"end_line":13,"end_character":61},"updated":"2017-02-28 13:37:14.000000000","message":"Format as ``code``","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5873d9d1fa3d03854818aea1efc79bcdd8fdb99a","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/support-vgamem"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This will allow user to set vgamem by setting hw_video_vgamem via the image"},{"line_number":14,"context_line":"properties in Glance in the same way as hw_video_ram."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_4bc6474a","line":13,"range":{"start_line":13,"start_character":46,"end_line":13,"end_character":61},"in_reply_to":"ba2be162_eb5bcd2c","updated":"2017-03-02 02:30:10.000000000","message":"Done","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fadd8a2273eb914b02858bebef2cf0ff73645db8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/support-vgamem"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This will allow user to set vgamem by setting hw_video_vgamem via the image"},{"line_number":14,"context_line":"properties in Glance in the same way as hw_video_ram."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_4b4bf959","line":14,"range":{"start_line":14,"start_character":40,"end_line":14,"end_character":52},"updated":"2017-02-28 13:37:14.000000000","message":"``code``","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5873d9d1fa3d03854818aea1efc79bcdd8fdb99a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/support-vgamem"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This will allow user to set vgamem by setting hw_video_vgamem via the image"},{"line_number":14,"context_line":"properties in Glance in the same way as hw_video_ram."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_6bc5cb3a","line":14,"range":{"start_line":14,"start_character":40,"end_line":14,"end_character":52},"in_reply_to":"ba2be162_4b4bf959","updated":"2017-03-02 02:30:10.000000000","message":"Done","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fadd8a2273eb914b02858bebef2cf0ff73645db8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We can set video.vram by setting hw_video_ram in image properties currently"},{"line_number":20,"context_line":"[1]_, but can\u0027t set vgamem. The default vgamem is 16MiB, it\u0027s not enough for"},{"line_number":21,"context_line":"4k resolutions in some cases [2]_."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_2b65e5e0","line":19,"range":{"start_line":19,"start_character":33,"end_line":19,"end_character":45},"updated":"2017-02-28 13:37:14.000000000","message":"``code``","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fadd8a2273eb914b02858bebef2cf0ff73645db8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We can set video.vram by setting hw_video_ram in image properties currently"},{"line_number":20,"context_line":"[1]_, but can\u0027t set vgamem. The default vgamem is 16MiB, it\u0027s not enough for"},{"line_number":21,"context_line":"4k resolutions in some cases [2]_."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_cb6d29ce","line":19,"range":{"start_line":19,"start_character":11,"end_line":19,"end_character":21},"updated":"2017-02-28 13:37:14.000000000","message":"``code``","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fadd8a2273eb914b02858bebef2cf0ff73645db8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We can set video.vram by setting hw_video_ram in image properties currently"},{"line_number":20,"context_line":"[1]_, but can\u0027t set vgamem. The default vgamem is 16MiB, it\u0027s not enough for"},{"line_number":21,"context_line":"4k resolutions in some cases [2]_."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_0b6821ba","line":19,"range":{"start_line":19,"start_character":66,"end_line":19,"end_character":75},"updated":"2017-02-28 13:37:14.000000000","message":"remove this word","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5873d9d1fa3d03854818aea1efc79bcdd8fdb99a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We can set video.vram by setting hw_video_ram in image properties currently"},{"line_number":20,"context_line":"[1]_, but can\u0027t set vgamem. The default vgamem is 16MiB, it\u0027s not enough for"},{"line_number":21,"context_line":"4k resolutions in some cases [2]_."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_4bf48786","line":19,"range":{"start_line":19,"start_character":66,"end_line":19,"end_character":75},"in_reply_to":"ba2be162_0b6821ba","updated":"2017-03-02 02:30:10.000000000","message":"Done","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5873d9d1fa3d03854818aea1efc79bcdd8fdb99a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We can set video.vram by setting hw_video_ram in image properties currently"},{"line_number":20,"context_line":"[1]_, but can\u0027t set vgamem. The default vgamem is 16MiB, it\u0027s not enough for"},{"line_number":21,"context_line":"4k resolutions in some cases [2]_."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_6bf30b9f","line":19,"range":{"start_line":19,"start_character":33,"end_line":19,"end_character":45},"in_reply_to":"ba2be162_2b65e5e0","updated":"2017-03-02 02:30:10.000000000","message":"Done","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5873d9d1fa3d03854818aea1efc79bcdd8fdb99a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We can set video.vram by setting hw_video_ram in image properties currently"},{"line_number":20,"context_line":"[1]_, but can\u0027t set vgamem. The default vgamem is 16MiB, it\u0027s not enough for"},{"line_number":21,"context_line":"4k resolutions in some cases [2]_."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_8bee7fb2","line":19,"range":{"start_line":19,"start_character":11,"end_line":19,"end_character":21},"in_reply_to":"ba2be162_cb6d29ce","updated":"2017-03-02 02:30:10.000000000","message":"Done","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fadd8a2273eb914b02858bebef2cf0ff73645db8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We can set video.vram by setting hw_video_ram in image properties currently"},{"line_number":20,"context_line":"[1]_, but can\u0027t set vgamem. The default vgamem is 16MiB, it\u0027s not enough for"},{"line_number":21,"context_line":"4k resolutions in some cases [2]_."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_2bac05ed","line":20,"range":{"start_line":20,"start_character":57,"end_line":20,"end_character":65},"updated":"2017-02-28 13:37:14.000000000","message":"but this is not always","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fadd8a2273eb914b02858bebef2cf0ff73645db8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We can set video.vram by setting hw_video_ram in image properties currently"},{"line_number":20,"context_line":"[1]_, but can\u0027t set vgamem. The default vgamem is 16MiB, it\u0027s not enough for"},{"line_number":21,"context_line":"4k resolutions in some cases [2]_."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_cba4490a","line":20,"range":{"start_line":20,"start_character":20,"end_line":20,"end_character":26},"updated":"2017-02-28 13:37:14.000000000","message":"what is vgamem? A little intro for the uninitiated would help (even a link)","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5873d9d1fa3d03854818aea1efc79bcdd8fdb99a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We can set video.vram by setting hw_video_ram in image properties currently"},{"line_number":20,"context_line":"[1]_, but can\u0027t set vgamem. The default vgamem is 16MiB, it\u0027s not enough for"},{"line_number":21,"context_line":"4k resolutions in some cases [2]_."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_16cb9254","line":20,"range":{"start_line":20,"start_character":57,"end_line":20,"end_character":65},"in_reply_to":"ba2be162_2bac05ed","updated":"2017-03-02 02:30:10.000000000","message":"Hmm, right","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5873d9d1fa3d03854818aea1efc79bcdd8fdb99a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We can set video.vram by setting hw_video_ram in image properties currently"},{"line_number":20,"context_line":"[1]_, but can\u0027t set vgamem. The default vgamem is 16MiB, it\u0027s not enough for"},{"line_number":21,"context_line":"4k resolutions in some cases [2]_."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_56c50a3a","line":20,"range":{"start_line":20,"start_character":20,"end_line":20,"end_character":26},"in_reply_to":"ba2be162_cba4490a","updated":"2017-03-02 02:30:10.000000000","message":"Done","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fadd8a2273eb914b02858bebef2cf0ff73645db8","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We can set video.vram by setting hw_video_ram in image properties currently"},{"line_number":20,"context_line":"[1]_, but can\u0027t set vgamem. The default vgamem is 16MiB, it\u0027s not enough for"},{"line_number":21,"context_line":"4k resolutions in some cases [2]_."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_4bb9392e","line":21,"range":{"start_line":21,"start_character":15,"end_line":21,"end_character":28},"updated":"2017-02-28 13:37:14.000000000","message":"drop this","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5873d9d1fa3d03854818aea1efc79bcdd8fdb99a","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We can set video.vram by setting hw_video_ram in image properties currently"},{"line_number":20,"context_line":"[1]_, but can\u0027t set vgamem. The default vgamem is 16MiB, it\u0027s not enough for"},{"line_number":21,"context_line":"4k resolutions in some cases [2]_."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_76c04e2b","line":21,"range":{"start_line":21,"start_character":15,"end_line":21,"end_character":28},"in_reply_to":"ba2be162_4bb9392e","updated":"2017-03-02 02:30:10.000000000","message":"Done","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fadd8a2273eb914b02858bebef2cf0ff73645db8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"----------"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The user needs to set vgamem for instance for 4k resolutions display."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_cb7b697a","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":69},"updated":"2017-02-28 13:37:14.000000000","message":"Why?","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5873d9d1fa3d03854818aea1efc79bcdd8fdb99a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"----------"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The user needs to set vgamem for instance for 4k resolutions display."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_367336e9","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":69},"in_reply_to":"ba2be162_cb7b697a","updated":"2017-03-02 02:30:10.000000000","message":"Changed a little.","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fadd8a2273eb914b02858bebef2cf0ff73645db8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"hw_video_vgamem will be provided via the image properties in Glance same as"},{"line_number":32,"context_line":"hw_video_ram. The value will be provided in MB."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_2b9325a5","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":15},"updated":"2017-02-28 13:37:14.000000000","message":"``code``","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5873d9d1fa3d03854818aea1efc79bcdd8fdb99a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"hw_video_vgamem will be provided via the image properties in Glance same as"},{"line_number":32,"context_line":"hw_video_ram. The value will be provided in MB."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_b64d669b","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":15},"in_reply_to":"ba2be162_2b9325a5","updated":"2017-03-02 02:30:10.000000000","message":"Done","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fadd8a2273eb914b02858bebef2cf0ff73645db8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"hw_video_vgamem will be provided via the image properties in Glance same as"},{"line_number":32,"context_line":"hw_video_ram. The value will be provided in MB."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. code-block:: console"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_4b905996","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":12},"updated":"2017-02-28 13:37:14.000000000","message":"``code``","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5873d9d1fa3d03854818aea1efc79bcdd8fdb99a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"hw_video_vgamem will be provided via the image properties in Glance same as"},{"line_number":32,"context_line":"hw_video_ram. The value will be provided in MB."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. code-block:: console"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_d6449a75","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":12},"in_reply_to":"ba2be162_4b905996","updated":"2017-03-02 02:30:10.000000000","message":"Done","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fadd8a2273eb914b02858bebef2cf0ff73645db8","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. code-block:: console"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"   glance image-update \\"},{"line_number":37,"context_line":"     --property hw_video_model\u003dqxl \\"},{"line_number":38,"context_line":"     --property hw_video_vgamem\u003d64 \\"},{"line_number":39,"context_line":"     myimage"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Alternatives"},{"line_number":42,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_0bdd8170","line":39,"range":{"start_line":36,"start_character":3,"end_line":39,"end_character":12},"updated":"2017-02-28 13:37:14.000000000","message":"Can you give this as an openstack-client command instead? Also, prefix with \u0027$\u0027","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5873d9d1fa3d03854818aea1efc79bcdd8fdb99a","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. code-block:: console"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"   glance image-update \\"},{"line_number":37,"context_line":"     --property hw_video_model\u003dqxl \\"},{"line_number":38,"context_line":"     --property hw_video_vgamem\u003d64 \\"},{"line_number":39,"context_line":"     myimage"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Alternatives"},{"line_number":42,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_b63486fb","line":39,"range":{"start_line":36,"start_character":3,"end_line":39,"end_character":12},"in_reply_to":"ba2be162_0bdd8170","updated":"2017-03-02 02:30:10.000000000","message":"Done","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fadd8a2273eb914b02858bebef2cf0ff73645db8","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Data model impact"},{"line_number":47,"context_line":"-----------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"None"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"REST API impact"},{"line_number":52,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_cbc9a9ae","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":4},"updated":"2017-02-28 13:37:14.000000000","message":"Doesn\u0027t this mean adding a new property to objects? Should that be recorded here?","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5873d9d1fa3d03854818aea1efc79bcdd8fdb99a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Data model impact"},{"line_number":47,"context_line":"-----------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"None"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"REST API impact"},{"line_number":52,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_160d523e","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":4},"in_reply_to":"ba2be162_cbc9a9ae","updated":"2017-03-02 02:30:10.000000000","message":"Done","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fadd8a2273eb914b02858bebef2cf0ff73645db8","unresolved":false,"context_lines":[{"line_number":95,"context_line":"Work Items"},{"line_number":96,"context_line":"----------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Add hw_video_vgamem item to libvirt driver."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Dependencies"},{"line_number":101,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_6bbb5d0f","line":98,"range":{"start_line":98,"start_character":30,"end_line":98,"end_character":45},"updated":"2017-02-28 13:37:14.000000000","message":"Do the other drivers support the existing hw_video_* properties?","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fadd8a2273eb914b02858bebef2cf0ff73645db8","unresolved":false,"context_lines":[{"line_number":95,"context_line":"Work Items"},{"line_number":96,"context_line":"----------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Add hw_video_vgamem item to libvirt driver."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Dependencies"},{"line_number":101,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_ebce6db3","line":98,"range":{"start_line":98,"start_character":6,"end_line":98,"end_character":21},"updated":"2017-02-28 13:37:14.000000000","message":"``code``","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5873d9d1fa3d03854818aea1efc79bcdd8fdb99a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"Work Items"},{"line_number":96,"context_line":"----------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Add hw_video_vgamem item to libvirt driver."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Dependencies"},{"line_number":101,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_71193879","line":98,"range":{"start_line":98,"start_character":30,"end_line":98,"end_character":45},"in_reply_to":"ba2be162_6bbb5d0f","updated":"2017-03-02 02:30:10.000000000","message":"Yes","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5873d9d1fa3d03854818aea1efc79bcdd8fdb99a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"Work Items"},{"line_number":96,"context_line":"----------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Add hw_video_vgamem item to libvirt driver."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Dependencies"},{"line_number":101,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_511ef463","line":98,"range":{"start_line":98,"start_character":6,"end_line":98,"end_character":21},"in_reply_to":"ba2be162_ebce6db3","updated":"2017-03-02 02:30:10.000000000","message":"Done","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fadd8a2273eb914b02858bebef2cf0ff73645db8","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Testing"},{"line_number":106,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Unit tests for all changes."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Documentation Impact"},{"line_number":111,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_8b36d1b2","line":108,"updated":"2017-02-28 13:37:14.000000000","message":"This may need third party CI tests. I\u0027m not sure","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5873d9d1fa3d03854818aea1efc79bcdd8fdb99a","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Testing"},{"line_number":106,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Unit tests for all changes."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Documentation Impact"},{"line_number":111,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_f15a8829","line":108,"in_reply_to":"ba2be162_8b36d1b2","updated":"2017-03-02 02:30:10.000000000","message":"No idea either, only found unit test for other hw_video_* in nova\u0027s code base","commit_id":"33ca45d6603be7a8d3dab5ad1d8e589cbb93c36e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"66bd7090aae0b2f2d61fa7b99d85e5f739606e42","unresolved":false,"context_lines":[{"line_number":44,"context_line":"   $ openstack image set \\"},{"line_number":45,"context_line":"     --property hw_video_model\u003dqxl \\"},{"line_number":46,"context_line":"     --property hw_video_vgamem\u003d64 \\"},{"line_number":47,"context_line":"     myimage"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Alternatives"},{"line_number":50,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_ec03c3b6","line":47,"updated":"2017-03-07 14:23:42.000000000","message":"Does that mean we could schedule instances only on computes having the right libvirt version at least ? Or do you want to have computes accepting that specific property ? Or do you just want to pass that down to libvirt so we could correctly create the instance ?","commit_id":"a2590d99a1149090e0f27757c43719b40bdd008f"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"18c8db85ecbed04764350e22c10009fc679424bc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"   $ openstack image set \\"},{"line_number":45,"context_line":"     --property hw_video_model\u003dqxl \\"},{"line_number":46,"context_line":"     --property hw_video_vgamem\u003d64 \\"},{"line_number":47,"context_line":"     myimage"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Alternatives"},{"line_number":50,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_1521dc9f","line":47,"in_reply_to":"9a30ddce_ec03c3b6","updated":"2017-03-08 00:59:45.000000000","message":"I\u0027d prefer there is a min libvirt version check on compute node.","commit_id":"a2590d99a1149090e0f27757c43719b40bdd008f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"66bd7090aae0b2f2d61fa7b99d85e5f739606e42","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Alternatives"},{"line_number":50,"context_line":"------------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"None"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Data model impact"},{"line_number":55,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_4c3ccf93","line":52,"updated":"2017-03-07 14:23:42.000000000","message":"We could wait for having custom resource classes or traits, you know...","commit_id":"a2590d99a1149090e0f27757c43719b40bdd008f"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"18c8db85ecbed04764350e22c10009fc679424bc","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Alternatives"},{"line_number":50,"context_line":"------------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"None"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Data model impact"},{"line_number":55,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_156f1cc6","line":52,"in_reply_to":"9a30ddce_4c3ccf93","updated":"2017-03-08 00:59:45.000000000","message":"Hmm, that would be a choice.. is there any plan for that?","commit_id":"a2590d99a1149090e0f27757c43719b40bdd008f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"66bd7090aae0b2f2d61fa7b99d85e5f739606e42","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"* Add ``hw_video_vgamem`` item to libvirt driver which is the only driver"},{"line_number":107,"context_line":"  support ``hw_video_*`` properties."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Dependencies"},{"line_number":110,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_4cd84f54","line":108,"updated":"2017-03-07 14:23:42.000000000","message":"Here, I\u0027m missing more items to understand what you want to add.","commit_id":"a2590d99a1149090e0f27757c43719b40bdd008f"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"18c8db85ecbed04764350e22c10009fc679424bc","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"* Add ``hw_video_vgamem`` item to libvirt driver which is the only driver"},{"line_number":107,"context_line":"  support ``hw_video_*`` properties."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Dependencies"},{"line_number":110,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a30ddce_75c0587d","line":108,"in_reply_to":"9a30ddce_4cd84f54","updated":"2017-03-08 00:59:45.000000000","message":"Done","commit_id":"a2590d99a1149090e0f27757c43719b40bdd008f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d31b284cb75f5eda622e394a9d27f26159cf5cb8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"     myimage"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"There will be a minimum libvirt version check on compute node to ensure the"},{"line_number":50,"context_line":"image with this property is scheduled to the right compute node."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Alternatives"},{"line_number":53,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_36286186","line":50,"updated":"2017-03-09 15:36:56.000000000","message":"What would happen then if the scheduler picks a compute node that has the wrong libvirt version ? would it trigger a reschedule ? That looks suboptimal to me, hence the traits mention I made.","commit_id":"d14c43dcedf1b0f42605bf1b05cdb74d47a55ca2"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"4faa989c6cfcc9c14cd807a8d26cf9225fb030d6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"     myimage"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"There will be a minimum libvirt version check on compute node to ensure the"},{"line_number":50,"context_line":"image with this property is scheduled to the right compute node."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Alternatives"},{"line_number":53,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_3f957686","line":50,"in_reply_to":"9a30ddce_36286186","updated":"2017-03-10 05:51:14.000000000","message":"Yes, it\u0027ll trigger a reschedule. Or just log a warning that the libvirt version doesn\u0027t meet the required and ignore the property ?","commit_id":"d14c43dcedf1b0f42605bf1b05cdb74d47a55ca2"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"6c9d85f722ec88661e2bb81cb4e03d28f388eefd","unresolved":false,"context_lines":[{"line_number":47,"context_line":"     myimage"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"There will be a minimum libvirt version check on compute node to ensure the"},{"line_number":50,"context_line":"image with this property is scheduled to the right compute node."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Alternatives"},{"line_number":53,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_9f370c4c","line":50,"in_reply_to":"9a30ddce_3f71df44","updated":"2017-03-13 01:45:41.000000000","message":"Make sense, spec updated, thanks!","commit_id":"d14c43dcedf1b0f42605bf1b05cdb74d47a55ca2"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"38cd3f37aaed16fa7c8f5054e59d15e0256a3c2c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"     myimage"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"There will be a minimum libvirt version check on compute node to ensure the"},{"line_number":50,"context_line":"image with this property is scheduled to the right compute node."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Alternatives"},{"line_number":53,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_3f71df44","line":50,"in_reply_to":"9a30ddce_3f957686","updated":"2017-03-10 15:59:34.000000000","message":"Well, I\u0027m not sure operators would love that. Maybe a documentation explaining if that people want to use that new image property, they would mean to make sure to use some filters like AggregateImagePropertiesIsolation then.","commit_id":"d14c43dcedf1b0f42605bf1b05cdb74d47a55ca2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9408835c097e37913286039b04d3f8ea6bcecdc6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"``vgamem`` is an optional attribute to set the size of VGA framebuffer for"},{"line_number":20,"context_line":"fallback mode of QXL device. It\u0027s supported since libvirt 1.2.11[1]_."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"We can set ``video.vram`` by setting ``hw_video_ram`` in image properties"},{"line_number":23,"context_line":"[2]_, but can\u0027t set vgamem. If \u0027vgamem\u0027 is not configured by user, a default"},{"line_number":24,"context_line":"value with 16MiB will be assigned by libvirt, which is fine for most common"},{"line_number":25,"context_line":"uses, but the allocated video memory could be insufficient for high resolutions"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dfeb2761_f79688f0","line":22,"updated":"2017-04-04 12:58:42.000000000","message":"Why can\u0027t we just set vgamem with the value of hw_video_ram, for the cases where that needs to be set?\n\nWhy can\u0027t we re-use the existing property here, for the case where you are using the device that needs that setting?","commit_id":"dcd5bfe378c24224513d6f867da27b3f180c8fda"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"76ae8b0404174d345c6b2350b71aad0c23ada4dc","unresolved":false,"context_lines":[{"line_number":19,"context_line":"``vgamem`` is an optional attribute to set the size of VGA framebuffer for"},{"line_number":20,"context_line":"fallback mode of QXL device. It\u0027s supported since libvirt 1.2.11[1]_."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"We can set ``video.vram`` by setting ``hw_video_ram`` in image properties"},{"line_number":23,"context_line":"[2]_, but can\u0027t set vgamem. If \u0027vgamem\u0027 is not configured by user, a default"},{"line_number":24,"context_line":"value with 16MiB will be assigned by libvirt, which is fine for most common"},{"line_number":25,"context_line":"uses, but the allocated video memory could be insufficient for high resolutions"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dfeb2761_9a808148","line":22,"in_reply_to":"dfeb2761_1a30f1e7","updated":"2017-04-04 13:09:16.000000000","message":"Sure, what does that mean in a cross hypervisor sense. How will operation know what the setting should be. What checks should we do, or does libvirt do, to keep a self consistent set of those things.","commit_id":"dcd5bfe378c24224513d6f867da27b3f180c8fda"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bd57c611a7edb47b4c3a04d29e63f85343e11ea0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"``vgamem`` is an optional attribute to set the size of VGA framebuffer for"},{"line_number":20,"context_line":"fallback mode of QXL device. It\u0027s supported since libvirt 1.2.11[1]_."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"We can set ``video.vram`` by setting ``hw_video_ram`` in image properties"},{"line_number":23,"context_line":"[2]_, but can\u0027t set vgamem. If \u0027vgamem\u0027 is not configured by user, a default"},{"line_number":24,"context_line":"value with 16MiB will be assigned by libvirt, which is fine for most common"},{"line_number":25,"context_line":"uses, but the allocated video memory could be insufficient for high resolutions"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dfeb2761_1a30f1e7","line":22,"in_reply_to":"dfeb2761_f79688f0","updated":"2017-04-04 13:06:06.000000000","message":"Because that\u0027s two different libvirt attributes IIRC : \n\n\"Attribute ram ( since 1.0.2) specifies the size of the primary bar, while the attribute vram specifies the secondary bar size. If ram or vram are not supplied a default value is used. The ram should also be rounded to power of two as vram. There is also optional attribute vgamem (since 1.2.11) to set the size of VGA framebuffer for fallback mode of QXL device. Attribute vram64 (since 1.3.3) extends secondary bar and makes it addressable as 64bit memory.\"\nhttps://libvirt.org/formatdomain.html#elementsVideo","commit_id":"dcd5bfe378c24224513d6f867da27b3f180c8fda"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2f7dbd02b2267c5cf32645b26c17434fd18e4751","unresolved":false,"context_lines":[{"line_number":25,"context_line":"uses, but the allocated video memory could be insufficient for high resolutions"},{"line_number":26,"context_line":"and/or multihead setups[3]_."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"The value should be: screen_width * screen_height * 4 * number_of_displays"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dfeb2761_fa9c2dc1","line":28,"updated":"2017-04-04 13:07:14.000000000","message":"So I think we should have a discussion here of the difference between hw_video_ram and hw_video_vgaram, and the relationship between them, and all the other options here:\nhttps://www.ovirt.org/documentation/draft/video-ram\n\nThese image properties are meant to be hypervisor and driver agnostic. Can we describe \"vgaram\" in a better way somehow that would allow this to be used for other drivers?","commit_id":"dcd5bfe378c24224513d6f867da27b3f180c8fda"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"45161e3cbee2439674c601538f7f8aeb2c1c2104","unresolved":false,"context_lines":[{"line_number":25,"context_line":"uses, but the allocated video memory could be insufficient for high resolutions"},{"line_number":26,"context_line":"and/or multihead setups[3]_."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"The value should be: screen_width * screen_height * 4 * number_of_displays"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dfeb2761_7ad13d23","line":28,"in_reply_to":"dfeb2761_fa9c2dc1","updated":"2017-04-04 13:16:56.000000000","message":"Given the above, either we could be discussing about a very abstract image property not related to a specific virt driver (even a version), or discuss about how to use custom resource classes in the Placement API for that...","commit_id":"dcd5bfe378c24224513d6f867da27b3f180c8fda"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bd57c611a7edb47b4c3a04d29e63f85343e11ea0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"``hw_video_vgamem`` will be provided via the image properties in Glance same as"},{"line_number":40,"context_line":"``hw_video_ram``. The value will be provided in MB."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dfeb2761_7a425d40","line":39,"updated":"2017-04-04 13:06:06.000000000","message":"looks like yet another knob for a very specific virt driver... :(","commit_id":"dcd5bfe378c24224513d6f867da27b3f180c8fda"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9408835c097e37913286039b04d3f8ea6bcecdc6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"image with this property is scheduled to the right compute node."},{"line_number":51,"context_line":"If that people want to use this new image property, they would mean to make"},{"line_number":52,"context_line":"sure to use some filters like AggregateImagePropertiesIsolation then to avoid"},{"line_number":53,"context_line":"rescheduling because of failing with the libvirt version check."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Alternatives"},{"line_number":56,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dfeb2761_777838c3","line":53,"updated":"2017-04-04 12:58:42.000000000","message":"Please note the flavor property of hw_video:ram_max_mb that ensures you don\u0027t set more than the required amount. That seems to be overlooked here, although I don\u0027t know why these are different values.","commit_id":"dcd5bfe378c24224513d6f867da27b3f180c8fda"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bd57c611a7edb47b4c3a04d29e63f85343e11ea0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Data model impact"},{"line_number":61,"context_line":"-----------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"A new field ``hw_video_vgamem`` will be added to the ImageMetaProps object."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"REST API impact"},{"line_number":66,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dfeb2761_fa778d9f","line":63,"updated":"2017-04-04 13:06:06.000000000","message":"and see, because of that technical knob, we would need to upgrade an abstract model...","commit_id":"dcd5bfe378c24224513d6f867da27b3f180c8fda"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bd57c611a7edb47b4c3a04d29e63f85343e11ea0","unresolved":false,"context_lines":[{"line_number":112,"context_line":"* Add new field ``hw_video_vgamem`` to ImageMetaProps object."},{"line_number":113,"context_line":"* ``video.vgamem`` will be added to the instance\u0027s xml config in libvirt driver"},{"line_number":114,"context_line":"  if ``hw_video_vgamem`` is specified in image property."},{"line_number":115,"context_line":"* Add related tests."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Dependencies"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dfeb2761_ba6d85cd","line":115,"updated":"2017-04-04 13:06:06.000000000","message":"Given the above, honestly, couldn\u0027t we just wait for custom resource classes ?","commit_id":"dcd5bfe378c24224513d6f867da27b3f180c8fda"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"9623128344955e8824388aa0c4c48d44c55cc198","unresolved":false,"context_lines":[{"line_number":112,"context_line":"* Add new field ``hw_video_vgamem`` to ImageMetaProps object."},{"line_number":113,"context_line":"* ``video.vgamem`` will be added to the instance\u0027s xml config in libvirt driver"},{"line_number":114,"context_line":"  if ``hw_video_vgamem`` is specified in image property."},{"line_number":115,"context_line":"* Add related tests."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Dependencies"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dfeb2761_c13f27b2","line":115,"in_reply_to":"dfeb2761_ba6d85cd","updated":"2017-04-05 01:14:30.000000000","message":"I\u0027m fine with waiting the custom resource classes, is there any plan for this?","commit_id":"dcd5bfe378c24224513d6f867da27b3f180c8fda"}]}