)]}'
{"specs/pike/approved/service-create-destroy-notification.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9a976eb386bee14278d6d5b643e55dd33c0a2a5a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"id field will need be added to ServiceStatusPayload for external system to"},{"line_number":47,"context_line":"query the right service for updating or destroying, and make the data"},{"line_number":48,"context_line":"consistent with os-services API [3]."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. code-block:: python"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @base.NovaObjectRegistry.register"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_c3e2579f","line":49,"updated":"2017-03-17 11:13:46.000000000","message":"First I was hesitant about the id as this is the db id but it seems [3] also exposes this information already on the nova API. So let\u0027s add it for consistency","commit_id":"34a03dee7ac5cb8abd74016dfafaea7427557025"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"a685d5168f757c0304acb81a3669a6655b667ff3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"id field will need be added to ServiceStatusPayload for external system to"},{"line_number":47,"context_line":"query the right service for updating or destroying, and make the data"},{"line_number":48,"context_line":"consistent with os-services API [3]."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. code-block:: python"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @base.NovaObjectRegistry.register"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_071b7b1c","line":49,"in_reply_to":"1a1ced50_c3e2579f","updated":"2017-03-18 14:57:56.000000000","message":"Yeah, i\u0027m curious why there is no uuid for the service..","commit_id":"34a03dee7ac5cb8abd74016dfafaea7427557025"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9a976eb386bee14278d6d5b643e55dd33c0a2a5a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"New notifications service.create and service.delete will be introduced with"},{"line_number":99,"context_line":"INFO priority and the payload of the notification will be the serialized form"},{"line_number":100,"context_line":"of the already existing Service versioned object."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Other end user impact"},{"line_number":103,"context_line":"---------------------"},{"line_number":104,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_23b6cb8a","line":101,"updated":"2017-03-17 11:13:46.000000000","message":"So there won\u0027t be service.create.start and .end but just simply service.create (same for the delete). That is OK for me. I suggest to send service.create after the service is created (so the id is available) and also send the service.delete after the service is deleted.","commit_id":"34a03dee7ac5cb8abd74016dfafaea7427557025"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"a685d5168f757c0304acb81a3669a6655b667ff3","unresolved":false,"context_lines":[{"line_number":98,"context_line":"New notifications service.create and service.delete will be introduced with"},{"line_number":99,"context_line":"INFO priority and the payload of the notification will be the serialized form"},{"line_number":100,"context_line":"of the already existing Service versioned object."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Other end user impact"},{"line_number":103,"context_line":"---------------------"},{"line_number":104,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_2718771d","line":101,"in_reply_to":"1a1ced50_23b6cb8a","updated":"2017-03-18 14:57:56.000000000","message":"Okay","commit_id":"34a03dee7ac5cb8abd74016dfafaea7427557025"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9a976eb386bee14278d6d5b643e55dd33c0a2a5a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"Work Items"},{"line_number":129,"context_line":"----------"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"* Send version notifications for service.create and service.destroy."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_83adbf33","line":131,"range":{"start_line":131,"start_character":60,"end_line":131,"end_character":67},"updated":"2017-03-17 11:13:46.000000000","message":"Above you used service.delete. I think that is more aligned with the current naming","commit_id":"34a03dee7ac5cb8abd74016dfafaea7427557025"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"a685d5168f757c0304acb81a3669a6655b667ff3","unresolved":false,"context_lines":[{"line_number":128,"context_line":"Work Items"},{"line_number":129,"context_line":"----------"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"* Send version notifications for service.create and service.destroy."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_67d8af54","line":131,"range":{"start_line":131,"start_character":60,"end_line":131,"end_character":67},"in_reply_to":"1a1ced50_83adbf33","updated":"2017-03-18 14:57:56.000000000","message":"Done","commit_id":"34a03dee7ac5cb8abd74016dfafaea7427557025"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"48d676abd7db774bcec5ec5e38963e60d519c395","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Data model impact"},{"line_number":43,"context_line":"-----------------"},{"line_number":44,"context_line":"No database schema change is foreseen."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"id field will need be added to ServiceStatusPayload for external system to"},{"line_number":47,"context_line":"query the right service for updating or destroying, and make the data"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dfeb2761_c51f4a59","line":44,"updated":"2017-04-04 13:48:41.000000000","message":"Nit: We normally leave new lines after the titles, but I will not block on that.","commit_id":"701c65eb2e0798c86d44bf9300efe2abb1a41f73"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"b818b45b02e1d704eda9728d75a50a596e837f4c","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Data model impact"},{"line_number":43,"context_line":"-----------------"},{"line_number":44,"context_line":"No database schema change is foreseen."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"id field will need be added to ServiceStatusPayload for external system to"},{"line_number":47,"context_line":"query the right service for updating or destroying, and make the data"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dfeb2761_1ee8ce79","line":44,"in_reply_to":"dfeb2761_c51f4a59","updated":"2017-04-05 01:07:01.000000000","message":"Done","commit_id":"701c65eb2e0798c86d44bf9300efe2abb1a41f73"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"48d676abd7db774bcec5ec5e38963e60d519c395","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"id field will need be added to ServiceStatusPayload for external system to"},{"line_number":47,"context_line":"query the right service for updating or destroying, and make the data"},{"line_number":48,"context_line":"consistent with os-services API [3]."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. code-block:: python"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"dfeb2761_257b96be","line":48,"updated":"2017-04-04 13:48:41.000000000","message":"Ah, so this reminds me of this spec, we should link that here:\nhttp://specs.openstack.org/openstack/nova-specs/specs/pike/approved/service-hyper-uuid-in-api.html\n\nWe should be clear we only exposing the uuid in the notifications, to match the above API changes.","commit_id":"701c65eb2e0798c86d44bf9300efe2abb1a41f73"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"b818b45b02e1d704eda9728d75a50a596e837f4c","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"id field will need be added to ServiceStatusPayload for external system to"},{"line_number":47,"context_line":"query the right service for updating or destroying, and make the data"},{"line_number":48,"context_line":"consistent with os-services API [3]."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. code-block:: python"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"dfeb2761_be02023c","line":48,"in_reply_to":"dfeb2761_257b96be","updated":"2017-04-05 01:07:01.000000000","message":"great, thanks for the info","commit_id":"701c65eb2e0798c86d44bf9300efe2abb1a41f73"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"48d676abd7db774bcec5ec5e38963e60d519c395","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"[1] Versioned notification https://docs.openstack.org/developer/nova/notifications.html"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"[2] https://github.com/openstack/nova/blob/master/nova/objects/service.py#L318-L325"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"[3] https://developer.openstack.org/api-ref/compute/?expanded\u003dlist-compute-services-detail#list-compute-services"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"dfeb2761_a559e635","line":156,"updated":"2017-04-04 13:48:41.000000000","message":"Nit: these references drift, its good to select a specific git commit and line number. But as I think the reference is obvious without the line number, its not a blocker for me.","commit_id":"701c65eb2e0798c86d44bf9300efe2abb1a41f73"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"b818b45b02e1d704eda9728d75a50a596e837f4c","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"[1] Versioned notification https://docs.openstack.org/developer/nova/notifications.html"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"[2] https://github.com/openstack/nova/blob/master/nova/objects/service.py#L318-L325"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"[3] https://developer.openstack.org/api-ref/compute/?expanded\u003dlist-compute-services-detail#list-compute-services"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"dfeb2761_9e573e27","line":156,"in_reply_to":"dfeb2761_a559e635","updated":"2017-04-05 01:07:01.000000000","message":"Done","commit_id":"701c65eb2e0798c86d44bf9300efe2abb1a41f73"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3ff5fbb5a0d95c083f749844c62e5f079283b528","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"   * - Release Name"},{"line_number":169,"context_line":"     - Description"},{"line_number":170,"context_line":"   * - Pike"},{"line_number":171,"context_line":"     - Introduced"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f4b6375_0ce60246","line":170,"range":{"start_line":170,"start_character":7,"end_line":170,"end_character":11},"updated":"2017-10-19 01:30:19.000000000","message":"We\u0027re now in Queens so this has to be updated for Queens.","commit_id":"c3939774ed9337bcfbd29b15b945cc18be7a67fe"}]}