)]}'
{"specs/pike/approved/placement-put-resource-class.rst":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e0857e8b0b6e906f51ac696cbef869f6f7da8781","unresolved":false,"context_lines":[{"line_number":74,"context_line":"No ``GET`` or ``POST`` or body required and the undesirable rename behavior is"},{"line_number":75,"context_line":"removed."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"This functionality will be implemented in a new microversion that will provide "},{"line_number":78,"context_line":"new handler code for the ``PUT`` method. Support for the ``POST`` method will"},{"line_number":79,"context_line":"be kept around."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_20c53f8f","line":77,"updated":"2017-04-05 16:29:45.000000000","message":"testtools.matchers._impl.MismatchError: 1 !\u003d 0: Found trailing spaces on line 77 of specs/pike/approved/placement-put-resource-class.rst","commit_id":"5583c84013676768954feb0342e1c7af605f45f7"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"8942c9ceeef820d61b9d2b0643e7390c5abaa4bc","unresolved":false,"context_lines":[{"line_number":74,"context_line":"No ``GET`` or ``POST`` or body required and the undesirable rename behavior is"},{"line_number":75,"context_line":"removed."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"This functionality will be implemented in a new microversion that will provide "},{"line_number":78,"context_line":"new handler code for the ``PUT`` method. Support for the ``POST`` method will"},{"line_number":79,"context_line":"be kept around."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_80c08b52","line":77,"in_reply_to":"bff0334d_20c53f8f","updated":"2017-04-05 16:31:54.000000000","message":"oh the ignominy of trailing whitespace\n\norz","commit_id":"5583c84013676768954feb0342e1c7af605f45f7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"156ad512f2b0fdb2cdb0319354cbc3a6bc0ecaa4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"we can adjust ``PUT /resources_class/{name}`` to be an idempotent creator and"},{"line_number":62,"context_line":"validator of a single resource class. To create a new custom resource class::"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    PUT /resource_class/CUSTOM_FOOBAR"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    Status: 201 Created"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ff52f3f_2da2d49b","line":64,"updated":"2017-04-13 10:38:48.000000000","message":"Nit: maybe be explicit about there being no payload here. I kept thinking you just missed it off.","commit_id":"0082203247e536b178c39ba264f3e3729bb4bdfd"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"51fdf2a4333914325cc9158bd662e185d34cd764","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    Status: 204 No Content"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"No ``GET`` or ``POST`` or body required and the undesirable rename behavior is"},{"line_number":75,"context_line":"removed."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"This functionality will be implemented in a new microversion that will provide"},{"line_number":78,"context_line":"new handler code for the ``PUT`` method. Support for the ``POST`` method will"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ff52f3f_dc031c0f","line":75,"range":{"start_line":74,"start_character":40,"end_line":75,"end_character":8},"updated":"2017-04-13 09:33:19.000000000","message":"Could you clarify what you want to remove ? You\u0027re saying below that we would still accept a POST method.","commit_id":"0082203247e536b178c39ba264f3e3729bb4bdfd"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"9f37da63481c05de61824a4c6dee732869e117d7","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    Status: 204 No Content"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"No ``GET`` or ``POST`` or body required and the undesirable rename behavior is"},{"line_number":75,"context_line":"removed."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"This functionality will be implemented in a new microversion that will provide"},{"line_number":78,"context_line":"new handler code for the ``PUT`` method. Support for the ``POST`` method will"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ff52f3f_cd8ec8cf","line":75,"in_reply_to":"9ff52f3f_dc031c0f","updated":"2017-04-13 10:48:41.000000000","message":"Done","commit_id":"0082203247e536b178c39ba264f3e3729bb4bdfd"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"87e310856b1122d4ebabff898d36ab8762f2864e","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"This functionality will be implemented in a new microversion that will provide"},{"line_number":78,"context_line":"new handler code for the ``PUT`` method. Support for the ``POST`` method will"},{"line_number":79,"context_line":"be kept around."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"},{"line_number":82,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bff0334d_229db509","line":79,"updated":"2017-04-10 14:37:29.000000000","message":"What if we wanted to add more fields to the resource class? For instance, \"description\" or \"unit\" are two fields I\u0027ve been considering would add value to the definition of a resource class...","commit_id":"0082203247e536b178c39ba264f3e3729bb4bdfd"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"9f37da63481c05de61824a4c6dee732869e117d7","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"This functionality will be implemented in a new microversion that will provide"},{"line_number":78,"context_line":"new handler code for the ``PUT`` method. Support for the ``POST`` method will"},{"line_number":79,"context_line":"be kept around."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"},{"line_number":82,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ff52f3f_1135eada","line":79,"in_reply_to":"9ff52f3f_b7e87316","updated":"2017-04-13 10:48:41.000000000","message":"I\u0027ve added some discussion about how things might evolve in the future.","commit_id":"0082203247e536b178c39ba264f3e3729bb4bdfd"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"51fdf2a4333914325cc9158bd662e185d34cd764","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"This functionality will be implemented in a new microversion that will provide"},{"line_number":78,"context_line":"new handler code for the ``PUT`` method. Support for the ``POST`` method will"},{"line_number":79,"context_line":"be kept around."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"},{"line_number":82,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ff52f3f_b7e87316","line":79,"in_reply_to":"bff0334d_1242f83e","updated":"2017-04-13 09:33:19.000000000","message":"Without discussing *why* we should add more fields, I think this spec should explain that now PUT accepts no request body which would mean that if the created RC has more fields, those wouldn\u0027t be set, that\u0027s it (and if the datz model object accepts it).\n\nIf I want to create a specific RC having specific descriptions, then I\u0027d still use POST.","commit_id":"0082203247e536b178c39ba264f3e3729bb4bdfd"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"f208b63fd4512f57684ed19237682e13af8ea68e","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"This functionality will be implemented in a new microversion that will provide"},{"line_number":78,"context_line":"new handler code for the ``PUT`` method. Support for the ``POST`` method will"},{"line_number":79,"context_line":"be kept around."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"},{"line_number":82,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bff0334d_9d9062ef","line":79,"in_reply_to":"bff0334d_229db509","updated":"2017-04-10 14:59:10.000000000","message":"Presumably we would cross that bridge when we come to it? At the moment we don\u0027t have those fields, so a microversion which is bodiless is fine. Later if we realize we want description or unit, we add a body with those fields. Doing so doesn\u0027t change the mechanism of an idempotent PUT if we enforce that the PUT is a full representation PUT, not a partial. I\u0027ll hold off discussing the merit of the proposed fields until such a time as we want them (as doing so now would probably be a distraction).","commit_id":"0082203247e536b178c39ba264f3e3729bb4bdfd"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"450a3929741681030847b21db91fefde92f81188","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"This functionality will be implemented in a new microversion that will provide"},{"line_number":78,"context_line":"new handler code for the ``PUT`` method. Support for the ``POST`` method will"},{"line_number":79,"context_line":"be kept around."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"},{"line_number":82,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bff0334d_f8b41cd3","line":79,"in_reply_to":"bff0334d_229db509","updated":"2017-04-10 15:15:57.000000000","message":"What\u0027s the benefit of adding these things to a ResourceClass? Standard RCs don\u0027t need them, and custom RCs should be known entities to their creators.\n\nIn any case, unless that\u0027s a proposal that has been discussed and agreed to, I don\u0027t think it should stand in the way of this spec.","commit_id":"0082203247e536b178c39ba264f3e3729bb4bdfd"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"2bf8d65f9ba62cdcfc369d1971565884aa2704fb","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"This functionality will be implemented in a new microversion that will provide"},{"line_number":78,"context_line":"new handler code for the ``PUT`` method. Support for the ``POST`` method will"},{"line_number":79,"context_line":"be kept around."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"},{"line_number":82,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bff0334d_1242f83e","line":79,"in_reply_to":"bff0334d_f3431d12","updated":"2017-04-10 17:11:43.000000000","message":"It\u0027s not that the spec has to focus on the body, but that it is doing so because in the absence of a need for a body (the only information we care about, for now, is in the URI) the spec needs to be complete and say \"no body required\".","commit_id":"0082203247e536b178c39ba264f3e3729bb4bdfd"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"4236d56fabf3eb97a554192dee418548c651a853","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"This functionality will be implemented in a new microversion that will provide"},{"line_number":78,"context_line":"new handler code for the ``PUT`` method. Support for the ``POST`` method will"},{"line_number":79,"context_line":"be kept around."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"},{"line_number":82,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bff0334d_f3431d12","line":79,"in_reply_to":"bff0334d_f8b41cd3","updated":"2017-04-10 15:31:47.000000000","message":"It\u0027s not about whether the *creator* of the custom resource class knows what the RC is. It\u0027s about the end user...\n\nIn any case, I don\u0027t see why this spec needs to focus on the absence of a request/response body instead of just focusing on being able to return a 201/204. I don\u0027t see the reasoning behind coupling this spec to the whole \"has a body or not\" thing.","commit_id":"0082203247e536b178c39ba264f3e3729bb4bdfd"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"06b98a1072fdbdce15cf751c99081bd7acb5ce76","unresolved":false,"context_lines":[{"line_number":151,"context_line":"Assignee(s)"},{"line_number":152,"context_line":"-----------"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Who is leading the writing of the code? Or is this a blueprint where you\u0027re"},{"line_number":155,"context_line":"throwing it out there to see who picks it up?"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"If more than one person is working on the implementation, please designate the"},{"line_number":158,"context_line":"primary author and contact."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Primary assignee:"},{"line_number":161,"context_line":"  cdent"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bff0334d_600d878f","line":158,"range":{"start_line":154,"start_character":0,"end_line":158,"end_character":27},"updated":"2017-04-05 16:36:40.000000000","message":"Should be removed","commit_id":"0082203247e536b178c39ba264f3e3729bb4bdfd"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"156ad512f2b0fdb2cdb0319354cbc3a6bc0ecaa4","unresolved":false,"context_lines":[{"line_number":151,"context_line":"Assignee(s)"},{"line_number":152,"context_line":"-----------"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Who is leading the writing of the code? Or is this a blueprint where you\u0027re"},{"line_number":155,"context_line":"throwing it out there to see who picks it up?"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"If more than one person is working on the implementation, please designate the"},{"line_number":158,"context_line":"primary author and contact."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Primary assignee:"},{"line_number":161,"context_line":"  cdent"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ff52f3f_cd4b68ae","line":158,"range":{"start_line":154,"start_character":0,"end_line":158,"end_character":27},"in_reply_to":"bff0334d_600d878f","updated":"2017-04-13 10:38:48.000000000","message":"+1","commit_id":"0082203247e536b178c39ba264f3e3729bb4bdfd"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"9f37da63481c05de61824a4c6dee732869e117d7","unresolved":false,"context_lines":[{"line_number":155,"context_line":"throwing it out there to see who picks it up?"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"If more than one person is working on the implementation, please designate the"},{"line_number":158,"context_line":"primary author and contact."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Primary assignee:"},{"line_number":161,"context_line":"  cdent"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ff52f3f_f13166ee","line":158,"in_reply_to":"bff0334d_600d878f","updated":"2017-04-13 10:48:41.000000000","message":"Done","commit_id":"0082203247e536b178c39ba264f3e3729bb4bdfd"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"156ad512f2b0fdb2cdb0319354cbc3a6bc0ecaa4","unresolved":false,"context_lines":[{"line_number":203,"context_line":"History"},{"line_number":204,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Optional section intended to be used each time the spec is updated to describe"},{"line_number":207,"context_line":"new design, API or any database schema updated. Useful to let reader understand"},{"line_number":208,"context_line":"what\u0027s happened along the time."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":".. list-table:: Revisions"},{"line_number":211,"context_line":"   :header-rows: 1"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ff52f3f_4dd518b9","line":208,"range":{"start_line":206,"start_character":0,"end_line":208,"end_character":31},"updated":"2017-04-13 10:38:48.000000000","message":"Nit: should be removed.","commit_id":"0082203247e536b178c39ba264f3e3729bb4bdfd"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f876819d99a9aa4c2d23bcc31b61010377207cec","unresolved":false,"context_lines":[{"line_number":61,"context_line":"we can adjust ``PUT /resources_class/{name}`` to be an idempotent creator and"},{"line_number":62,"context_line":"validator of a single resource class. To create a new custom resource class::"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    PUT /resource_class/CUSTOM_FOOBAR"},{"line_number":65,"context_line":"    \u003cempty body\u003e"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    Status: 201 Created"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ff52f3f_ba661351","line":64,"updated":"2017-04-13 12:14:38.000000000","message":"Thinking of we may need an interface to validate a set of CUSTOM RC in the future. Just like the traits API, it will be \"GET /resource_class?name\u003din:CUSTOM_FOOBAR,CUSTOM_BARFOO\". But that can be added when that use-case come up.","commit_id":"9771892612be1f22f7ec81b68e81d42add202c8e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"83762fa59a132f5f322bf4e393c8a51527dc1110","unresolved":false,"context_lines":[{"line_number":61,"context_line":"we can adjust ``PUT /resources_class/{name}`` to be an idempotent creator and"},{"line_number":62,"context_line":"validator of a single resource class. To create a new custom resource class::"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    PUT /resource_class/CUSTOM_FOOBAR"},{"line_number":65,"context_line":"    \u003cempty body\u003e"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    Status: 201 Created"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ff52f3f_8b82e3c7","line":64,"in_reply_to":"9ff52f3f_ba661351","updated":"2017-04-13 13:39:48.000000000","message":"+1 thats a new microversion, either way. I see thats discussed on line 86 anyways.","commit_id":"9771892612be1f22f7ec81b68e81d42add202c8e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"83762fa59a132f5f322bf4e393c8a51527dc1110","unresolved":false,"context_lines":[{"line_number":90,"context_line":"the desired idempotent behavior with ``PUT`` requests and will still prevent"},{"line_number":91,"context_line":"the rename confusion (described above). Until such a time that we need those"},{"line_number":92,"context_line":"additional fields, including a body on the PUT request is redundant so we may"},{"line_number":93,"context_line":"as well not allow it."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Alternatives"},{"line_number":96,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ff52f3f_0b4ff3bd","line":93,"updated":"2017-04-13 13:39:48.000000000","message":"Lets delay worrying about that, makes sense.","commit_id":"9771892612be1f22f7ec81b68e81d42add202c8e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3f13669eaa36dd5746afaeebdfb075cfcd05127d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"the desired idempotent behavior with ``PUT`` requests and will still prevent"},{"line_number":91,"context_line":"the rename confusion (described above). Until such a time that we need those"},{"line_number":92,"context_line":"additional fields, including a body on the PUT request is redundant so we may"},{"line_number":93,"context_line":"as well not allow it."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Alternatives"},{"line_number":96,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7ffa3b31_610910dc","line":93,"in_reply_to":"9ff52f3f_0b4ff3bd","updated":"2017-04-13 20:28:57.000000000","message":"Honestly, I think it\u0027s okay to use POST in case you want to create a RC with more fields than just the name and leave PUT for just creating a RC with only a name.\n\nAnyway, given it\u0027s not related to the spec, fine by me to leave the above.","commit_id":"9771892612be1f22f7ec81b68e81d42add202c8e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"83762fa59a132f5f322bf4e393c8a51527dc1110","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"There\u0027s a very minor performance impact via the current scheduler report client"},{"line_number":148,"context_line":"because we are now doing a maximum of one instead of two requests when handling"},{"line_number":149,"context_line":"custom resource classes."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Other deployer impact"},{"line_number":152,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ff52f3f_8be9c381","line":149,"updated":"2017-04-13 13:39:48.000000000","message":"\"every little helps\" my TV tells me.","commit_id":"9771892612be1f22f7ec81b68e81d42add202c8e"}]}