)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4dc27bb009fb1325e342e0df4aa94cd308bb3bb7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the spec to indicate that default service_type values should be used in"},{"line_number":12,"context_line":"the absence of an override (although against my better judgement leave"},{"line_number":13,"context_line":"the option to configure one as a get-out-of-jail card) In order to do"},{"line_number":14,"context_line":"that cleanly, also ditch the concept of a single value that is a colon"},{"line_number":15,"context_line":"separated tuple, since that form is not used to indicate an OpenStack"},{"line_number":16,"context_line":"service pretty much anywhere else. Remove the service_name completely,"},{"line_number":17,"context_line":"as it\u0027s completely pointless in a Nova config."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7ffa3b31_23428c11","line":15,"range":{"start_line":14,"start_character":13,"end_line":15,"end_character":15},"updated":"2017-04-18 18:09:39.000000000","message":"Heh you\u0027d be surprised. This was copied into cinder and from cinder into manila.","commit_id":"8323bfd260ddcf633b1f72dd036c91d75d3a57c4"}],"specs/pike/approved/use-service-catalog-for-endpoints.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9b65b52ca9ac3b8e424f7f45c6e0ac8792d9c04b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Keystoneauth provides a simple and consistent way to get API endpoints from"},{"line_number":61,"context_line":"the Keystone service catalog instead of configuring it in a conf file."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Add two config settings for each service called ``service_type`` and"},{"line_number":64,"context_line":"``interface``. For instance::"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    [glance]"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7ffa3b31_032670b8","line":63,"updated":"2017-04-18 18:01:53.000000000","message":"FWIW, this was actually part of the original spec:\n\nhttps://review.openstack.org/#/c/454983/4..7/specs/pike/approved/use-service-catalog-for-endpoints.rst@a76\n\nBut in one of the updates we lost that. I agree we need something to override service_type and interface, but what about region_name? For [placement] in Nova we also allow overriding the region_name, and I think we actually key off that as required config to know you\u0027re using placement.","commit_id":"8323bfd260ddcf633b1f72dd036c91d75d3a57c4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"463367c68e20eb0c630c0a81dfeddc6955ad134a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    interface \u003d public"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"If ``service_type`` is not given, it should default to the well-known key"},{"line_number":71,"context_line":"in the `Service Type Authority`_. If ``interface`` is not given, it should"},{"line_number":72,"context_line":"default to ``internal``."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"To make retrieving API endpoint consistent, we can add a new method"},{"line_number":75,"context_line":"``get_service_url()`` in Nova. To establish communication with any other"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7ffa3b31_a36e9c92","line":72,"range":{"start_line":71,"start_character":34,"end_line":72,"end_character":24},"updated":"2017-04-18 18:12:08.000000000","message":"ksa has a default right? Why don\u0027t we just let ksa pick the default?","commit_id":"8323bfd260ddcf633b1f72dd036c91d75d3a57c4"}]}