)]}'
{"specs/queens/approved/sriov_bond.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d8b5f7924932e987df1bdabb0b83fbc75ff82256","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"9f436f4f_bb1cd2c1","updated":"2017-08-17 18:28:06.000000000","message":"this need to be discussed with neutron also.","commit_id":"87e43fb381c1d0639d1feec358a85c81402d5868"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"7fddefc726c669ae5044b13b5a0cc9e9d0c2a90a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"9f5c4f37_dc4bffad","in_reply_to":"9f436f4f_bb1cd2c1","updated":"2017-09-21 10:42:29.000000000","message":"OK,thanks,a similar patch has been committed in neutron too.","commit_id":"87e43fb381c1d0639d1feec358a85c81402d5868"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"f25df45da24f230b0af14c361c3a88dabf4a807a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"9f5c4f37_1c8517ae","in_reply_to":"9f5c4f37_dc4bffad","updated":"2017-09-21 10:44:20.000000000","message":"https://review.openstack.org/#/c/506066/","commit_id":"87e43fb381c1d0639d1feec358a85c81402d5868"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d8b5f7924932e987df1bdabb0b83fbc75ff82256","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    on the bond computer nodeto tell neutron server this computer node"},{"line_number":82,"context_line":"    need bonding."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":"    phynic_mappings \u003d physnet1:bond1(active-backup;off;eth1-eth2)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"2.  Port should add a segment of port\u0027s \"binding:vif_details\" to show"},{"line_number":87,"context_line":"    VM using SR-IOV in this computer node should bond or not when port"}],"source_content_type":"text/x-rst","patch_set":31,"id":"9f436f4f_5b6e06ca","line":84,"range":{"start_line":84,"start_character":4,"end_line":84,"end_character":65},"updated":"2017-08-17 18:28:06.000000000","message":"i really dont think this should be a agent config options.\n\ni would prefer to see bonding modeled as a neutron port property instead. i would suggest adding values to the neutron_binding profile and standardising them as part of the port binding extention or introducing a port binding bond extntion. This would allow bonds to be created with non sriov backend.","commit_id":"87e43fb381c1d0639d1feec358a85c81402d5868"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"7fddefc726c669ae5044b13b5a0cc9e9d0c2a90a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    on the bond computer nodeto tell neutron server this computer node"},{"line_number":82,"context_line":"    need bonding."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":"    phynic_mappings \u003d physnet1:bond1(active-backup;off;eth1-eth2)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"2.  Port should add a segment of port\u0027s \"binding:vif_details\" to show"},{"line_number":87,"context_line":"    VM using SR-IOV in this computer node should bond or not when port"}],"source_content_type":"text/x-rst","patch_set":31,"id":"9f5c4f37_dc1d3fbe","line":84,"range":{"start_line":84,"start_character":4,"end_line":84,"end_character":65},"in_reply_to":"9f436f4f_5b6e06ca","updated":"2017-09-21 10:42:29.000000000","message":"Good suggestion, thanks.","commit_id":"87e43fb381c1d0639d1feec358a85c81402d5868"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"50e1bc4f73d4a4772ac06fd35e5bb64e8b4d6885","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    on the bond computer nodeto tell neutron server this computer node"},{"line_number":82,"context_line":"    need bonding."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":"    phynic_mappings \u003d physnet1:bond1(active-backup;off;eth1-eth2)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"2.  Port should add a segment of port\u0027s \"binding:vif_details\" to show"},{"line_number":87,"context_line":"    VM using SR-IOV in this computer node should bond or not when port"}],"source_content_type":"text/x-rst","patch_set":31,"id":"7f515b1d_62d7a1ef","line":84,"range":{"start_line":84,"start_character":4,"end_line":84,"end_character":65},"in_reply_to":"9f5c4f37_dc1d3fbe","updated":"2017-09-25 08:12:35.000000000","message":"Hi,mooney,after more consideration,maybe it\u0027s better to use the agent config options than neutron port property in the following scenarios.\nfor example,when you want to change a non-bond virtual machine to a bond virtual machine,\n\nif you use neutron port property options,maybe you should:\n1. delete or detach port\n2. Upgrade port properties information\n3. add or attach port\nChanging the port properties may affect the normal business of virtual machine.\n\nif you use the agent config options,maybe you can:\n1. Migration the virtual machine to other node\n2. Upgrade the SR-IOV configuration for this node\n3. Migration the virtual machine back\nand these operations do not affect the normal business.\nWhat do you think about it? thanks ~","commit_id":"87e43fb381c1d0639d1feec358a85c81402d5868"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d8b5f7924932e987df1bdabb0b83fbc75ff82256","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    VM using SR-IOV in this computer node should bond or not when port"},{"line_number":88,"context_line":"    bonding according to the physnet in SR-IOV agent."},{"line_number":89,"context_line":"    For example::"},{"line_number":90,"context_line":"    \"{\"port_filter\": true, \"ovs_hybrid_plug\": true, \"physnet\":eth1-eth2}\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"3.  Creat neutron bond port with neutron API::"},{"line_number":93,"context_line":"    neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"}],"source_content_type":"text/x-rst","patch_set":31,"id":"9f436f4f_1bad1eea","line":90,"range":{"start_line":90,"start_character":27,"end_line":90,"end_character":50},"updated":"2017-08-17 18:28:06.000000000","message":"i think this is not needed with sriov :)","commit_id":"87e43fb381c1d0639d1feec358a85c81402d5868"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d8b5f7924932e987df1bdabb0b83fbc75ff82256","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    VM using SR-IOV in this computer node should bond or not when port"},{"line_number":88,"context_line":"    bonding according to the physnet in SR-IOV agent."},{"line_number":89,"context_line":"    For example::"},{"line_number":90,"context_line":"    \"{\"port_filter\": true, \"ovs_hybrid_plug\": true, \"physnet\":eth1-eth2}\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"3.  Creat neutron bond port with neutron API::"},{"line_number":93,"context_line":"    neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"}],"source_content_type":"text/x-rst","patch_set":31,"id":"9f436f4f_fb925a9f","line":90,"range":{"start_line":90,"start_character":52,"end_line":90,"end_character":71},"updated":"2017-08-17 18:28:06.000000000","message":"im not conviced that is a good approce to take. as you mentioned in the introduction when using hyeracrical port binding to do vxlan termination in the tor you cant reply on the physnet. \n\nthis also does not model your actull requirement which is two VFs allocated form seperate PFs it models 2 VFs allocated form two seperate phyical networks that are not meant to be connected.","commit_id":"87e43fb381c1d0639d1feec358a85c81402d5868"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"7fddefc726c669ae5044b13b5a0cc9e9d0c2a90a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    VM using SR-IOV in this computer node should bond or not when port"},{"line_number":88,"context_line":"    bonding according to the physnet in SR-IOV agent."},{"line_number":89,"context_line":"    For example::"},{"line_number":90,"context_line":"    \"{\"port_filter\": true, \"ovs_hybrid_plug\": true, \"physnet\":eth1-eth2}\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"3.  Creat neutron bond port with neutron API::"},{"line_number":93,"context_line":"    neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"}],"source_content_type":"text/x-rst","patch_set":31,"id":"9f5c4f37_fce363a3","line":90,"range":{"start_line":90,"start_character":27,"end_line":90,"end_character":50},"in_reply_to":"9f436f4f_1bad1eea","updated":"2017-09-21 10:42:29.000000000","message":"ok,i\u0027ll delete this part.","commit_id":"87e43fb381c1d0639d1feec358a85c81402d5868"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d8b5f7924932e987df1bdabb0b83fbc75ff82256","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    \"{\"port_filter\": true, \"ovs_hybrid_plug\": true, \"physnet\":eth1-eth2}\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"3.  Creat neutron bond port with neutron API::"},{"line_number":93,"context_line":"    neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"4.  Creat SR-IOV VM with nova API::"},{"line_number":96,"context_line":"    nova boot --nic port-id\u003dbond1"}],"source_content_type":"text/x-rst","patch_set":31,"id":"9f436f4f_fb6eda94","line":93,"range":{"start_line":93,"start_character":4,"end_line":93,"end_character":71},"updated":"2017-08-17 18:28:06.000000000","message":"i would suggest the following instead\nneutron port-create --binding:vnic_type\u003ddirect --binding:profile\u003d{bond\u003dtrue, bond_mode\u003dactive-backup,bound_count\u003d2,bond_antiafinity\u003dpf} --name bond1 private\n\nthis can then be combined with the nic feature based schduling in the future to be more granular about the requirements for selecting the VFs based on traits.","commit_id":"87e43fb381c1d0639d1feec358a85c81402d5868"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d8b5f7924932e987df1bdabb0b83fbc75ff82256","unresolved":false,"context_lines":[{"line_number":98,"context_line":"5.  When nova get vif_details bonding info from neutron. It will plug"},{"line_number":99,"context_line":"    one or more VFs to VM according to the port bonding info."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"6.  Add a OVS/LINUX bond of PFs manually in VM."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Alternatives"},{"line_number":104,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":31,"id":"9f436f4f_1b7cfe1e","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":47},"updated":"2017-08-17 18:28:06.000000000","message":"there is a separate proposal to automatically create vlan inside a vm via cloud init\nhttps://review.openstack.org/#/c/471815/\n\nit may be better to also support auto configuration of the bond via cloud init or at least the exposure the bound info via the metadata service.\n\nwe could use a addtional keypair in the binding:profile to conntrol if configuration of the bound shoudl be done via cloud init or not.\n\nif you are running dpdk in the guest you will not want to create a bound in the kernel for example but it is still usefull to retrive the bond info from the metadata service.","commit_id":"87e43fb381c1d0639d1feec358a85c81402d5868"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d8b5f7924932e987df1bdabb0b83fbc75ff82256","unresolved":false,"context_lines":[{"line_number":103,"context_line":"Alternatives"},{"line_number":104,"context_line":"------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  * There are no alternatives that directly satisfy SR-IOV bonding using"},{"line_number":107,"context_line":"    just one port in software level."},{"line_number":108,"context_line":"  * Some physical NICs cards support one VF for two PFs. That will satisfy"},{"line_number":109,"context_line":"    this need in hardware level ,but it depends on the physical NIC card"},{"line_number":110,"context_line":"    itself.And when we need more than two physical NICs to be bond, that"}],"source_content_type":"text/x-rst","patch_set":31,"id":"9f436f4f_bb43b2af","line":107,"range":{"start_line":106,"start_character":4,"end_line":107,"end_character":36},"updated":"2017-08-17 18:28:06.000000000","message":"actully there have been several proposed over the last few cycles.\n\none option is to have the hyperviors create a boud in the host and passthrough a bound to the gust using the kernel bond dirver.\n\nhttps://review.openstack.org/#/c/182242/ also discribes an alternitive to this proposal in some lenght.","commit_id":"87e43fb381c1d0639d1feec358a85c81402d5868"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d8b5f7924932e987df1bdabb0b83fbc75ff82256","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  * There are no alternatives that directly satisfy SR-IOV bonding using"},{"line_number":107,"context_line":"    just one port in software level."},{"line_number":108,"context_line":"  * Some physical NICs cards support one VF for two PFs. That will satisfy"},{"line_number":109,"context_line":"    this need in hardware level ,but it depends on the physical NIC card"},{"line_number":110,"context_line":"    itself.And when we need more than two physical NICs to be bond, that"},{"line_number":111,"context_line":"    won\u0027t work."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":31,"id":"9f436f4f_fb781a2c","line":111,"range":{"start_line":108,"start_character":3,"end_line":111,"end_character":15},"updated":"2017-08-17 18:28:06.000000000","message":"intel\u0027s bolder rapid can do this for two pfs on the same physical card but that is not available for general customers and requires additional configuration of a bound in the nic which is then exposed as a vf. \n\nis there a generally available nic at present that support a hardware bound of queues from 2 pfs that you can reference.","commit_id":"87e43fb381c1d0639d1feec358a85c81402d5868"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9f887e6ea89b24d7a2efdcdf973a0e40811fda71","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Proposed change"},{"line_number":79,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":80,"context_line":"1.  Creat neutron bond port with neutron API::"},{"line_number":81,"context_line":"    neutron port-create --binding:vnic_type\u003ddirect --binding:profile\u003d{bond\u003dtrue, \\"},{"line_number":82,"context_line":"    bond_mode\u003dactive-backup,bound_count\u003d2,bond_antiafinity\u003dpf} --name bond1 private"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":32,"id":"7f515b1d_8e708674","line":80,"updated":"2017-09-25 10:25:05.000000000","message":"What is going to configuring the bonding on the guest?","commit_id":"9c96c5c1513e62ec2165a93940d81a0bb07f21a3"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"441b56057e01cb3ed2d3e8a328991df8e84f907b","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Proposed change"},{"line_number":79,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":80,"context_line":"1.  Creat neutron bond port with neutron API::"},{"line_number":81,"context_line":"    neutron port-create --binding:vnic_type\u003ddirect --binding:profile\u003d{bond\u003dtrue, \\"},{"line_number":82,"context_line":"    bond_mode\u003dactive-backup,bound_count\u003d2,bond_antiafinity\u003dpf} --name bond1 private"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":32,"id":"3f4b6375_22c85420","line":80,"in_reply_to":"7f515b1d_8e708674","updated":"2017-10-23 09:57:10.000000000","message":"Done,I have added the configuring of bonding on the guest,please review it again,thanks","commit_id":"9c96c5c1513e62ec2165a93940d81a0bb07f21a3"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9f887e6ea89b24d7a2efdcdf973a0e40811fda71","unresolved":false,"context_lines":[{"line_number":92,"context_line":"Alternatives"},{"line_number":93,"context_line":"------------"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  * There are no alternatives that directly satisfy SR-IOV bonding using"},{"line_number":96,"context_line":"    just one port in software level."},{"line_number":97,"context_line":"  * Some physical NICs cards support one VF for two PFs. That will satisfy"},{"line_number":98,"context_line":"    this need in hardware level ,but it depends on the physical NIC card"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7f515b1d_ee0edae3","line":95,"updated":"2017-09-25 10:25:05.000000000","message":"What about to create configure two aliases for a flavor, one on physset1/physnet2, but the users will still have to configure the guest os to do the bonding.","commit_id":"9c96c5c1513e62ec2165a93940d81a0bb07f21a3"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"adfa6acbf3f97e0da16a0d91c562197ddcd25ed0","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Two SR-IOV NICs(NIC1 and NIC2)"},{"line_number":55,"context_line":"When create VM using one logic port which is bond port include two VFs"},{"line_number":56,"context_line":"from two different NICs.In HostOS bond this tow NICs together and"},{"line_number":57,"context_line":"deliver the bond mode to the GuestOS through metadata,in GuestOS dpdk"},{"line_number":58,"context_line":"bond the two VFs together."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":34,"id":"ff82abbf_6e49d489","line":56,"range":{"start_line":56,"start_character":23,"end_line":56,"end_character":25},"updated":"2017-11-30 19:35:14.000000000","message":"Nit: a space in between","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"adfa6acbf3f97e0da16a0d91c562197ddcd25ed0","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Two SR-IOV NICs(NIC1 and NIC2)"},{"line_number":55,"context_line":"When create VM using one logic port which is bond port include two VFs"},{"line_number":56,"context_line":"from two different NICs.In HostOS bond this tow NICs together and"},{"line_number":57,"context_line":"deliver the bond mode to the GuestOS through metadata,in GuestOS dpdk"},{"line_number":58,"context_line":"bond the two VFs together."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":34,"id":"ff82abbf_2e20acb0","line":56,"range":{"start_line":56,"start_character":44,"end_line":56,"end_character":47},"updated":"2017-11-30 19:35:14.000000000","message":"two","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"f0acc399ad47b620604ab1352f69ab9a5dcedda9","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Two SR-IOV NICs(NIC1 and NIC2)"},{"line_number":55,"context_line":"When create VM using one logic port which is bond port include two VFs"},{"line_number":56,"context_line":"from two different NICs.In HostOS bond this tow NICs together and"},{"line_number":57,"context_line":"deliver the bond mode to the GuestOS through metadata,in GuestOS dpdk"},{"line_number":58,"context_line":"bond the two VFs together."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":34,"id":"df87a7cf_0ae8dbb1","line":56,"range":{"start_line":56,"start_character":23,"end_line":56,"end_character":25},"in_reply_to":"ff82abbf_6e49d489","updated":"2017-12-06 08:55:21.000000000","message":"Done","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"adfa6acbf3f97e0da16a0d91c562197ddcd25ed0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Two SR-IOV NICs(NIC1 and NIC2)"},{"line_number":55,"context_line":"When create VM using one logic port which is bond port include two VFs"},{"line_number":56,"context_line":"from two different NICs.In HostOS bond this tow NICs together and"},{"line_number":57,"context_line":"deliver the bond mode to the GuestOS through metadata,in GuestOS dpdk"},{"line_number":58,"context_line":"bond the two VFs together."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":34,"id":"ff82abbf_8e2f78a6","line":57,"range":{"start_line":57,"start_character":53,"end_line":57,"end_character":55},"updated":"2017-11-30 19:35:14.000000000","message":"A space in between","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"f0acc399ad47b620604ab1352f69ab9a5dcedda9","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Two SR-IOV NICs(NIC1 and NIC2)"},{"line_number":55,"context_line":"When create VM using one logic port which is bond port include two VFs"},{"line_number":56,"context_line":"from two different NICs.In HostOS bond this tow NICs together and"},{"line_number":57,"context_line":"deliver the bond mode to the GuestOS through metadata,in GuestOS dpdk"},{"line_number":58,"context_line":"bond the two VFs together."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":34,"id":"df87a7cf_cad193fd","line":57,"range":{"start_line":57,"start_character":53,"end_line":57,"end_character":55},"in_reply_to":"ff82abbf_8e2f78a6","updated":"2017-12-06 08:55:21.000000000","message":"Done","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"adfa6acbf3f97e0da16a0d91c562197ddcd25ed0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"   +---------------------------------------------+"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Proposed change"},{"line_number":79,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":80,"context_line":"1.  Neutron adding configure option in the SR-IOV_nic_switch_agent.ini"},{"line_number":81,"context_line":"    on the bond computer nodeto tell neutron server this computer node"}],"source_content_type":"text/x-rst","patch_set":34,"id":"ff82abbf_d092fe4b","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":15},"updated":"2017-11-30 19:35:14.000000000","message":"Two questions:\n\n* I am not sure how to do the scheduling of SR-IOV boud port. I assume the scheduling of SR-IOV bond port would be different from a normal SR-IOV port?\n* Could we define a flavor to represent SR-IOV bond port? As a result, users can boot instance from the flavor and Nova will handle the creation of neutron port.","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"f0acc399ad47b620604ab1352f69ab9a5dcedda9","unresolved":false,"context_lines":[{"line_number":75,"context_line":"   +---------------------------------------------+"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Proposed change"},{"line_number":79,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":80,"context_line":"1.  Neutron adding configure option in the SR-IOV_nic_switch_agent.ini"},{"line_number":81,"context_line":"    on the bond computer nodeto tell neutron server this computer node"}],"source_content_type":"text/x-rst","patch_set":34,"id":"df87a7cf_8a22abff","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":15},"in_reply_to":"ff82abbf_d092fe4b","updated":"2017-12-06 08:55:21.000000000","message":"Hi hongbin:\nthanks for the comments:\n(1)Just a little different, the SR-IOV bond port have many member ports, they should share the same mac address.\n(2)Maybe that will take some confusions","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"adfa6acbf3f97e0da16a0d91c562197ddcd25ed0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Proposed change"},{"line_number":79,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":80,"context_line":"1.  Neutron adding configure option in the SR-IOV_nic_switch_agent.ini"},{"line_number":81,"context_line":"    on the bond computer nodeto tell neutron server this computer node"},{"line_number":82,"context_line":"    need bonding."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":"    phynic_mappings \u003d physnet1:bond1(active-backup;off;eth1-eth2)"}],"source_content_type":"text/x-rst","patch_set":34,"id":"ff82abbf_ae1d9c74","line":81,"range":{"start_line":81,"start_character":25,"end_line":81,"end_character":31},"updated":"2017-11-30 19:35:14.000000000","message":"node to","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"f0acc399ad47b620604ab1352f69ab9a5dcedda9","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Proposed change"},{"line_number":79,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":80,"context_line":"1.  Neutron adding configure option in the SR-IOV_nic_switch_agent.ini"},{"line_number":81,"context_line":"    on the bond computer nodeto tell neutron server this computer node"},{"line_number":82,"context_line":"    need bonding."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":"    phynic_mappings \u003d physnet1:bond1(active-backup;off;eth1-eth2)"}],"source_content_type":"text/x-rst","patch_set":34,"id":"df87a7cf_eacc9762","line":81,"range":{"start_line":81,"start_character":25,"end_line":81,"end_character":31},"in_reply_to":"ff82abbf_ae1d9c74","updated":"2017-12-06 08:55:21.000000000","message":"Done","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"adfa6acbf3f97e0da16a0d91c562197ddcd25ed0","unresolved":false,"context_lines":[{"line_number":80,"context_line":"1.  Neutron adding configure option in the SR-IOV_nic_switch_agent.ini"},{"line_number":81,"context_line":"    on the bond computer nodeto tell neutron server this computer node"},{"line_number":82,"context_line":"    need bonding."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":"    phynic_mappings \u003d physnet1:bond1(active-backup;off;eth1-eth2)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"2.  Port should add a segment of port\u0027s \"binding:vif_details\" to show"}],"source_content_type":"text/x-rst","patch_set":34,"id":"ff82abbf_1069468a","line":83,"range":{"start_line":83,"start_character":15,"end_line":83,"end_character":17},"updated":"2017-11-30 19:35:14.000000000","message":"An empty line after \u0027::\u0027, otherwise, the markup won\u0027t be correctly rendered.","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"f0acc399ad47b620604ab1352f69ab9a5dcedda9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"1.  Neutron adding configure option in the SR-IOV_nic_switch_agent.ini"},{"line_number":81,"context_line":"    on the bond computer nodeto tell neutron server this computer node"},{"line_number":82,"context_line":"    need bonding."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":"    phynic_mappings \u003d physnet1:bond1(active-backup;off;eth1-eth2)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"2.  Port should add a segment of port\u0027s \"binding:vif_details\" to show"}],"source_content_type":"text/x-rst","patch_set":34,"id":"df87a7cf_8adb8b19","line":83,"range":{"start_line":83,"start_character":15,"end_line":83,"end_character":17},"in_reply_to":"ff82abbf_1069468a","updated":"2017-12-06 08:55:21.000000000","message":"Done","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"adfa6acbf3f97e0da16a0d91c562197ddcd25ed0","unresolved":false,"context_lines":[{"line_number":86,"context_line":"2.  Port should add a segment of port\u0027s \"binding:vif_details\" to show"},{"line_number":87,"context_line":"    VM using SR-IOV in this computer node should bond or not when port"},{"line_number":88,"context_line":"    bonding according to the physnet in SR-IOV agent."},{"line_number":89,"context_line":"    For example::"},{"line_number":90,"context_line":"    \"{\"port_filter\": true, \"ovs_hybrid_plug\": true, \"physnet\":eth1-eth2}\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"3.  Creat bond port with neutron API::"}],"source_content_type":"text/x-rst","patch_set":34,"id":"ff82abbf_700d32e7","line":89,"range":{"start_line":89,"start_character":15,"end_line":89,"end_character":17},"updated":"2017-11-30 19:35:14.000000000","message":"An empty line after \u0027::\u0027","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"f0acc399ad47b620604ab1352f69ab9a5dcedda9","unresolved":false,"context_lines":[{"line_number":86,"context_line":"2.  Port should add a segment of port\u0027s \"binding:vif_details\" to show"},{"line_number":87,"context_line":"    VM using SR-IOV in this computer node should bond or not when port"},{"line_number":88,"context_line":"    bonding according to the physnet in SR-IOV agent."},{"line_number":89,"context_line":"    For example::"},{"line_number":90,"context_line":"    \"{\"port_filter\": true, \"ovs_hybrid_plug\": true, \"physnet\":eth1-eth2}\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"3.  Creat bond port with neutron API::"}],"source_content_type":"text/x-rst","patch_set":34,"id":"df87a7cf_4a07c383","line":89,"range":{"start_line":89,"start_character":15,"end_line":89,"end_character":17},"in_reply_to":"ff82abbf_700d32e7","updated":"2017-12-06 08:55:21.000000000","message":"Done","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"adfa6acbf3f97e0da16a0d91c562197ddcd25ed0","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    For example::"},{"line_number":90,"context_line":"    \"{\"port_filter\": true, \"ovs_hybrid_plug\": true, \"physnet\":eth1-eth2}\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"3.  Creat bond port with neutron API::"},{"line_number":93,"context_line":"    neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"4.  Creat SR-IOV VM with nova API::"}],"source_content_type":"text/x-rst","patch_set":34,"id":"ff82abbf_90123609","line":92,"range":{"start_line":92,"start_character":36,"end_line":92,"end_character":38},"updated":"2017-11-30 19:35:14.000000000","message":"Ditto","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"f0acc399ad47b620604ab1352f69ab9a5dcedda9","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    For example::"},{"line_number":90,"context_line":"    \"{\"port_filter\": true, \"ovs_hybrid_plug\": true, \"physnet\":eth1-eth2}\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"3.  Creat bond port with neutron API::"},{"line_number":93,"context_line":"    neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"4.  Creat SR-IOV VM with nova API::"}],"source_content_type":"text/x-rst","patch_set":34,"id":"df87a7cf_6a0ac78a","line":92,"range":{"start_line":92,"start_character":36,"end_line":92,"end_character":38},"in_reply_to":"ff82abbf_90123609","updated":"2017-12-06 08:55:21.000000000","message":"Done","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"adfa6acbf3f97e0da16a0d91c562197ddcd25ed0","unresolved":false,"context_lines":[{"line_number":92,"context_line":"3.  Creat bond port with neutron API::"},{"line_number":93,"context_line":"    neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"4.  Creat SR-IOV VM with nova API::"},{"line_number":96,"context_line":"    nova boot --nic port-id\u003dbond1"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"5.  When nova get vif_details bonding info from neutron. It will plug"}],"source_content_type":"text/x-rst","patch_set":34,"id":"ff82abbf_50f4aecf","line":95,"range":{"start_line":95,"start_character":33,"end_line":95,"end_character":35},"updated":"2017-11-30 19:35:14.000000000","message":"Ditto","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"f0acc399ad47b620604ab1352f69ab9a5dcedda9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"3.  Creat bond port with neutron API::"},{"line_number":93,"context_line":"    neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"4.  Creat SR-IOV VM with nova API::"},{"line_number":96,"context_line":"    nova boot --nic port-id\u003dbond1"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"5.  When nova get vif_details bonding info from neutron. It will plug"}],"source_content_type":"text/x-rst","patch_set":34,"id":"df87a7cf_0a01bb6b","line":95,"range":{"start_line":95,"start_character":33,"end_line":95,"end_character":35},"in_reply_to":"ff82abbf_50f4aecf","updated":"2017-12-06 08:55:21.000000000","message":"Done","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"adfa6acbf3f97e0da16a0d91c562197ddcd25ed0","unresolved":false,"context_lines":[{"line_number":98,"context_line":"5.  When nova get vif_details bonding info from neutron. It will plug"},{"line_number":99,"context_line":"    one or more VFs to VM according to the port bonding info."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"6.  Add LINUX bond of PFs manually in VM::"},{"line_number":102,"context_line":"    root@driver4 network-scripts]# cat ifcfg-bond1"},{"line_number":103,"context_line":"    DEVICE\u003dbond1"},{"line_number":104,"context_line":"    BONDING_OPTS\u003d\"mode\u003d0 miimon\u003d100\""}],"source_content_type":"text/x-rst","patch_set":34,"id":"ff82abbf_10fe26ae","line":101,"range":{"start_line":101,"start_character":40,"end_line":101,"end_character":42},"updated":"2017-11-30 19:35:14.000000000","message":"Ditto","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"f0acc399ad47b620604ab1352f69ab9a5dcedda9","unresolved":false,"context_lines":[{"line_number":98,"context_line":"5.  When nova get vif_details bonding info from neutron. It will plug"},{"line_number":99,"context_line":"    one or more VFs to VM according to the port bonding info."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"6.  Add LINUX bond of PFs manually in VM::"},{"line_number":102,"context_line":"    root@driver4 network-scripts]# cat ifcfg-bond1"},{"line_number":103,"context_line":"    DEVICE\u003dbond1"},{"line_number":104,"context_line":"    BONDING_OPTS\u003d\"mode\u003d0 miimon\u003d100\""}],"source_content_type":"text/x-rst","patch_set":34,"id":"df87a7cf_2a04bf7a","line":101,"range":{"start_line":101,"start_character":40,"end_line":101,"end_character":42},"in_reply_to":"ff82abbf_10fe26ae","updated":"2017-12-06 08:55:21.000000000","message":"Done","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"adfa6acbf3f97e0da16a0d91c562197ddcd25ed0","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  * There are no alternatives that directly satisfy SR-IOV bonding using"},{"line_number":128,"context_line":"    just one port in software level."},{"line_number":129,"context_line":"  * Some physical NICs cards support one VF for two PFs. That will satisfy"},{"line_number":130,"context_line":"    this need in hardware level ,but it depends on the physical NIC card"},{"line_number":131,"context_line":"    itself.And when we need more than two physical NICs to be bond, that"},{"line_number":132,"context_line":"    won\u0027t work."},{"line_number":133,"context_line":"  * It\u0027s better to use the agent config options than neutron port property."}],"source_content_type":"text/x-rst","patch_set":34,"id":"ff82abbf_503caebe","line":130,"range":{"start_line":130,"start_character":26,"end_line":130,"end_character":36},"updated":"2017-11-30 19:35:14.000000000","message":"level, but","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"f0acc399ad47b620604ab1352f69ab9a5dcedda9","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  * There are no alternatives that directly satisfy SR-IOV bonding using"},{"line_number":128,"context_line":"    just one port in software level."},{"line_number":129,"context_line":"  * Some physical NICs cards support one VF for two PFs. That will satisfy"},{"line_number":130,"context_line":"    this need in hardware level ,but it depends on the physical NIC card"},{"line_number":131,"context_line":"    itself.And when we need more than two physical NICs to be bond, that"},{"line_number":132,"context_line":"    won\u0027t work."},{"line_number":133,"context_line":"  * It\u0027s better to use the agent config options than neutron port property."}],"source_content_type":"text/x-rst","patch_set":34,"id":"df87a7cf_eaf57784","line":130,"range":{"start_line":130,"start_character":26,"end_line":130,"end_character":36},"in_reply_to":"ff82abbf_503caebe","updated":"2017-12-06 08:55:21.000000000","message":"Done","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"adfa6acbf3f97e0da16a0d91c562197ddcd25ed0","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    just one port in software level."},{"line_number":129,"context_line":"  * Some physical NICs cards support one VF for two PFs. That will satisfy"},{"line_number":130,"context_line":"    this need in hardware level ,but it depends on the physical NIC card"},{"line_number":131,"context_line":"    itself.And when we need more than two physical NICs to be bond, that"},{"line_number":132,"context_line":"    won\u0027t work."},{"line_number":133,"context_line":"  * It\u0027s better to use the agent config options than neutron port property."},{"line_number":134,"context_line":"    when you want to change a non-bond virtual machine to a bond virtual machine,"}],"source_content_type":"text/x-rst","patch_set":34,"id":"ff82abbf_10462651","line":131,"range":{"start_line":131,"start_character":10,"end_line":131,"end_character":12},"updated":"2017-11-30 19:35:14.000000000","message":"A space in between","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"f0acc399ad47b620604ab1352f69ab9a5dcedda9","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    just one port in software level."},{"line_number":129,"context_line":"  * Some physical NICs cards support one VF for two PFs. That will satisfy"},{"line_number":130,"context_line":"    this need in hardware level ,but it depends on the physical NIC card"},{"line_number":131,"context_line":"    itself.And when we need more than two physical NICs to be bond, that"},{"line_number":132,"context_line":"    won\u0027t work."},{"line_number":133,"context_line":"  * It\u0027s better to use the agent config options than neutron port property."},{"line_number":134,"context_line":"    when you want to change a non-bond virtual machine to a bond virtual machine,"}],"source_content_type":"text/x-rst","patch_set":34,"id":"df87a7cf_8af4eb87","line":131,"range":{"start_line":131,"start_character":10,"end_line":131,"end_character":12},"in_reply_to":"ff82abbf_10462651","updated":"2017-12-06 08:55:21.000000000","message":"Done","commit_id":"700239d0fbfd2281ef5689a65e164d5299fa1d60"},{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"3aaeff6b628408306fd61f20064b7ec4dec011f1","unresolved":false,"context_lines":[{"line_number":3,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":4,"context_line":" License."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":"SR-IOV-bond"}],"source_content_type":"text/x-rst","patch_set":39,"id":"df87a7cf_40fd48af","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":53},"updated":"2017-12-07 06:28:53.000000000","message":"Although it will be redirect to the https , but we should follow the exact link for the file .\nOne space  should get removed  , Thanks in advance","commit_id":"2cdbddf90741496905d62a93360341dcf60e6cd2"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"58588095d7e4666129d871547d3fc39fb8a10214","unresolved":false,"context_lines":[{"line_number":3,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":4,"context_line":" License."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":"SR-IOV-bond"}],"source_content_type":"text/x-rst","patch_set":39,"id":"df87a7cf_8b6b711c","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":53},"in_reply_to":"df87a7cf_40fd48af","updated":"2017-12-07 07:51:53.000000000","message":"Done, thanks","commit_id":"2cdbddf90741496905d62a93360341dcf60e6cd2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":9,"context_line":"SR-IOV-bond"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"https://blueprints.launchpad.net/nova/+spec/SR-IOV-bond"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The ability for OpenStack with a bond nic of Single root I/O"},{"line_number":15,"context_line":"virtualization(SR-IOV) for L2 redundant is really useful in NFV scenario,"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_a5c15e56","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":55},"updated":"2018-08-16 01:48:02.000000000","message":"This link doesn\u0027t exist, it should be:\n\nhttps://blueprints.launchpad.net/nova/+spec/sriov-bond","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"2500e819ebbaa4746a178e8b2c8cb998d72061c1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"SR-IOV-bond"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"https://blueprints.launchpad.net/nova/+spec/SR-IOV-bond"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The ability for OpenStack with a bond nic of Single root I/O"},{"line_number":15,"context_line":"virtualization(SR-IOV) for L2 redundant is really useful in NFV scenario,"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_e256615c","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":55},"in_reply_to":"3f79a3b5_a5c15e56","updated":"2018-08-28 09:43:04.000000000","message":"Done","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":12,"context_line":"https://blueprints.launchpad.net/nova/+spec/SR-IOV-bond"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The ability for OpenStack with a bond nic of Single root I/O"},{"line_number":15,"context_line":"virtualization(SR-IOV) for L2 redundant is really useful in NFV scenario,"},{"line_number":16,"context_line":"it needs to add a bond port(with mode \"active-backup\") using SR-IOV NICs."},{"line_number":17,"context_line":"It\u0027s just **one port** logically."},{"line_number":18,"context_line":"When create a VM with the bond logic port,we use two SR-IOV"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_45b40af2","line":15,"range":{"start_line":15,"start_character":30,"end_line":15,"end_character":39},"updated":"2018-08-16 01:48:02.000000000","message":"redundancy? (HA)","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"2500e819ebbaa4746a178e8b2c8cb998d72061c1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"https://blueprints.launchpad.net/nova/+spec/SR-IOV-bond"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The ability for OpenStack with a bond nic of Single root I/O"},{"line_number":15,"context_line":"virtualization(SR-IOV) for L2 redundant is really useful in NFV scenario,"},{"line_number":16,"context_line":"it needs to add a bond port(with mode \"active-backup\") using SR-IOV NICs."},{"line_number":17,"context_line":"It\u0027s just **one port** logically."},{"line_number":18,"context_line":"When create a VM with the bond logic port,we use two SR-IOV"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_02527d67","line":15,"range":{"start_line":15,"start_character":30,"end_line":15,"end_character":39},"in_reply_to":"3f79a3b5_45b40af2","updated":"2018-08-28 09:43:04.000000000","message":"Done","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":15,"context_line":"virtualization(SR-IOV) for L2 redundant is really useful in NFV scenario,"},{"line_number":16,"context_line":"it needs to add a bond port(with mode \"active-backup\") using SR-IOV NICs."},{"line_number":17,"context_line":"It\u0027s just **one port** logically."},{"line_number":18,"context_line":"When create a VM with the bond logic port,we use two SR-IOV"},{"line_number":19,"context_line":"Virtual Functions (VFs) in two different Physical Functions (PFs)."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_25cd4e84","line":18,"range":{"start_line":18,"start_character":41,"end_line":18,"end_character":44},"updated":"2018-08-16 01:48:02.000000000","message":"space: \", we\"","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"2500e819ebbaa4746a178e8b2c8cb998d72061c1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"virtualization(SR-IOV) for L2 redundant is really useful in NFV scenario,"},{"line_number":16,"context_line":"it needs to add a bond port(with mode \"active-backup\") using SR-IOV NICs."},{"line_number":17,"context_line":"It\u0027s just **one port** logically."},{"line_number":18,"context_line":"When create a VM with the bond logic port,we use two SR-IOV"},{"line_number":19,"context_line":"Virtual Functions (VFs) in two different Physical Functions (PFs)."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_a24ce9c7","line":18,"range":{"start_line":18,"start_character":41,"end_line":18,"end_character":44},"in_reply_to":"3f79a3b5_25cd4e84","updated":"2018-08-28 09:43:04.000000000","message":"Done","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"In the NFV field,many scenes need L2 redundant for SR-IOV. But currently"},{"line_number":24,"context_line":"nova or neutron solution for L2 bond is usually configured multiple"},{"line_number":25,"context_line":"neutron ports and allocate different VFs on different physical network"},{"line_number":26,"context_line":"adapters to implement this."}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_65aca69e","line":23,"range":{"start_line":23,"start_character":37,"end_line":23,"end_character":46},"updated":"2018-08-16 01:48:02.000000000","message":"redundancy","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"In the NFV field,many scenes need L2 redundant for SR-IOV. But currently"},{"line_number":24,"context_line":"nova or neutron solution for L2 bond is usually configured multiple"},{"line_number":25,"context_line":"neutron ports and allocate different VFs on different physical network"},{"line_number":26,"context_line":"adapters to implement this."}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_a5a63ec0","line":23,"range":{"start_line":23,"start_character":22,"end_line":23,"end_character":28},"updated":"2018-08-16 01:48:02.000000000","message":"scenarios","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"In the NFV field,many scenes need L2 redundant for SR-IOV. But currently"},{"line_number":24,"context_line":"nova or neutron solution for L2 bond is usually configured multiple"},{"line_number":25,"context_line":"neutron ports and allocate different VFs on different physical network"},{"line_number":26,"context_line":"adapters to implement this."}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_c5c7ba63","line":23,"range":{"start_line":23,"start_character":16,"end_line":23,"end_character":17},"updated":"2018-08-16 01:48:02.000000000","message":"space","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"2500e819ebbaa4746a178e8b2c8cb998d72061c1","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"In the NFV field,many scenes need L2 redundant for SR-IOV. But currently"},{"line_number":24,"context_line":"nova or neutron solution for L2 bond is usually configured multiple"},{"line_number":25,"context_line":"neutron ports and allocate different VFs on different physical network"},{"line_number":26,"context_line":"adapters to implement this."}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_62c81121","line":23,"range":{"start_line":23,"start_character":37,"end_line":23,"end_character":46},"in_reply_to":"3f79a3b5_65aca69e","updated":"2018-08-28 09:43:04.000000000","message":"Done","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"2500e819ebbaa4746a178e8b2c8cb998d72061c1","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"In the NFV field,many scenes need L2 redundant for SR-IOV. But currently"},{"line_number":24,"context_line":"nova or neutron solution for L2 bond is usually configured multiple"},{"line_number":25,"context_line":"neutron ports and allocate different VFs on different physical network"},{"line_number":26,"context_line":"adapters to implement this."}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_22ce992c","line":23,"range":{"start_line":23,"start_character":22,"end_line":23,"end_character":28},"in_reply_to":"3f79a3b5_a5a63ec0","updated":"2018-08-28 09:43:04.000000000","message":"Done","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"In the NFV field,many scenes need L2 redundant for SR-IOV. But currently"},{"line_number":24,"context_line":"nova or neutron solution for L2 bond is usually configured multiple"},{"line_number":25,"context_line":"neutron ports and allocate different VFs on different physical network"},{"line_number":26,"context_line":"adapters to implement this."},{"line_number":27,"context_line":"For example:"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_0597f249","line":24,"range":{"start_line":24,"start_character":48,"end_line":24,"end_character":58},"updated":"2018-08-16 01:48:02.000000000","message":"achieved by configuring","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":31,"context_line":"But this BP have some limits in the following areas:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"1.  In the Vxlan network scenario, when using SR-IOV, we must use ToR"},{"line_number":34,"context_line":"    switch as a vtep.So, it cannot specify a physical network and you"},{"line_number":35,"context_line":"    cannot select which of the VF belongs to a particular PF."},{"line_number":36,"context_line":"2.  As a SR-IOV bond port, we need two or more VFs which have the"},{"line_number":37,"context_line":"    same mac to avoid the problem of spoof because mostly linux bond"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_e5975644","line":34,"range":{"start_line":34,"start_character":16,"end_line":34,"end_character":20},"updated":"2018-08-16 01:48:02.000000000","message":"What is a vtep? I\u0027m mostly ignorant on NFV terminology (and I\u0027m assuming others that read this will be too) so it would be good to explain these things a bit.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":31,"context_line":"But this BP have some limits in the following areas:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"1.  In the Vxlan network scenario, when using SR-IOV, we must use ToR"},{"line_number":34,"context_line":"    switch as a vtep.So, it cannot specify a physical network and you"},{"line_number":35,"context_line":"    cannot select which of the VF belongs to a particular PF."},{"line_number":36,"context_line":"2.  As a SR-IOV bond port, we need two or more VFs which have the"},{"line_number":37,"context_line":"    same mac to avoid the problem of spoof because mostly linux bond"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_4582ca01","line":34,"range":{"start_line":34,"start_character":21,"end_line":34,"end_character":23},"updated":"2018-08-16 01:48:02.000000000","message":"space","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"2500e819ebbaa4746a178e8b2c8cb998d72061c1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"But this BP have some limits in the following areas:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"1.  In the Vxlan network scenario, when using SR-IOV, we must use ToR"},{"line_number":34,"context_line":"    switch as a vtep.So, it cannot specify a physical network and you"},{"line_number":35,"context_line":"    cannot select which of the VF belongs to a particular PF."},{"line_number":36,"context_line":"2.  As a SR-IOV bond port, we need two or more VFs which have the"},{"line_number":37,"context_line":"    same mac to avoid the problem of spoof because mostly linux bond"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_e2dbc1e9","line":34,"range":{"start_line":34,"start_character":21,"end_line":34,"end_character":23},"in_reply_to":"3f79a3b5_4582ca01","updated":"2018-08-28 09:43:04.000000000","message":"Done","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    bond port."},{"line_number":40,"context_line":"3.  When OpenStack integrates SDN technology through the Neutron module,"},{"line_number":41,"context_line":"    SDN controller needs to see **one logic neutron port** for the"},{"line_number":42,"context_line":"    bond port. If neutron have two ports with the same mac, that will"},{"line_number":43,"context_line":"    make the SDN controller confuse."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"So there should be a plan to use just one neutron port for two or more"},{"line_number":46,"context_line":"VFs on different PFs if we need bond sriov port."}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_257b0e28","line":43,"range":{"start_line":42,"start_character":60,"end_line":43,"end_character":36},"updated":"2018-08-16 01:48:02.000000000","message":"\"that will confuse the SDN controller.\"\n\nCan you expand on what the SDN controller might do in this scenario?","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Use Cases"},{"line_number":49,"context_line":"---------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"To take advantage of L2 redundant links for bonding with multiple"},{"line_number":52,"context_line":"SR-IOV PF ports needing spreading a port allocate two different VFs pci"},{"line_number":53,"context_line":"with two different SR-IOV PFs with SDN controller."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Two SR-IOV NICs(NIC1 and NIC2)"},{"line_number":56,"context_line":"When create VM using one logic port which is bond port include two VFs"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_659a6662","line":53,"range":{"start_line":51,"start_character":0,"end_line":53,"end_character":50},"updated":"2018-08-16 01:48:02.000000000","message":"This is hard to parse. I\u0027m not sure what it\u0027s trying to say.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8ff4f6816d4c003d935c92dbb2972507ce826187","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Use Cases"},{"line_number":49,"context_line":"---------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"To take advantage of L2 redundant links for bonding with multiple"},{"line_number":52,"context_line":"SR-IOV PF ports needing spreading a port allocate two different VFs pci"},{"line_number":53,"context_line":"with two different SR-IOV PFs with SDN controller."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Two SR-IOV NICs(NIC1 and NIC2)"},{"line_number":56,"context_line":"When create VM using one logic port which is bond port include two VFs"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_98ef8086","line":53,"range":{"start_line":51,"start_character":0,"end_line":53,"end_character":50},"in_reply_to":"3f79a3b5_659a6662","updated":"2018-08-21 10:43:41.000000000","message":"I think what they\u0027re trying to say is we want to allocate VFs from different PFs, e.g. we would have a bond with VF1 from PF1 and VF1 from PF2. This is for redundancy reasons.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":52,"context_line":"SR-IOV PF ports needing spreading a port allocate two different VFs pci"},{"line_number":53,"context_line":"with two different SR-IOV PFs with SDN controller."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Two SR-IOV NICs(NIC1 and NIC2)"},{"line_number":56,"context_line":"When create VM using one logic port which is bond port include two VFs"},{"line_number":57,"context_line":"from two different NICs. In HostOS bond this two NICs together and"},{"line_number":58,"context_line":"deliver the bond mode to the GuestOS through metadata, in GuestOS dpdk"},{"line_number":59,"context_line":"bond the two VFs together."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"::"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_e5a516a0","line":59,"range":{"start_line":55,"start_character":0,"end_line":59,"end_character":26},"updated":"2018-08-16 01:48:02.000000000","message":"This is describing the proposed change (solution) correct? If so, move to that section. The Use Case section should be a simple statement about why we need this - what benefit does it provide and to whom.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6ed2fcef9e41c8bc69137df8867025468b299995","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Proposed change"},{"line_number":80,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":81,"context_line":"1.  Neutron adds configure option in the sriov_agent.ini on the compute node."},{"line_number":82,"context_line":"    The configure will be used to add ports for the bridge."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        physical_device_mappings \u003d physnet1:bond1(active-backup;off;ens1-ens2)"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_16eb54dc","line":82,"range":{"start_line":82,"start_character":52,"end_line":82,"end_character":58},"updated":"2018-08-20 17:27:58.000000000","message":"do you mean bond?","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"0ab792e5c787f1606fe3752e06fa8067747ef13a","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    The configure will be used to add ports for the bridge."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        physical_device_mappings \u003d physnet1:bond1(active-backup;off;ens1-ens2)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"2.  Nova adds configure option in the nova.conf on the bond compute node."},{"line_number":88,"context_line":"    Since the two SR-IOV ports are bonded together, they should share the same"}],"source_content_type":"text/x-rst","patch_set":43,"id":"bf8cb3f7_690ad98a","line":85,"updated":"2017-12-27 23:50:11.000000000","message":"This assumes you can\u0027t program the switch.  There are plenty of examples of controllers that do program the switch.  If you can program the switch, you don\u0027t necessarily want to specify this up front.\n\nAside from that, there\u0027s the question of who would do LACP here (or any other bonding protocol).  Would we do that on the host? If so, then how does the VM work out there\u0027s a problem with an interface?  If the VM does it, based on the way switches work, I think you\u0027d need to use a flat network.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6ed2fcef9e41c8bc69137df8867025468b299995","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    The configure will be used to add ports for the bridge."},{"line_number":83,"context_line":"    For example::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        physical_device_mappings \u003d physnet1:bond1(active-backup;off;ens1-ens2)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"2.  Nova adds configure option in the nova.conf on the bond compute node."},{"line_number":88,"context_line":"    Since the two SR-IOV ports are bonded together, they should share the same"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_76b5e8ed","line":85,"in_reply_to":"bf8cb3f7_690ad98a","updated":"2018-08-20 17:27:58.000000000","message":"how is the sriov nic agant ment to be configuing the bond mode?\n\ncan you give examples of what command you expect it to execute.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        physical_device_mappings \u003d physnet1:bond1(active-backup;off;ens1-ens2)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"2.  Nova adds configure option in the nova.conf on the bond compute node."},{"line_number":88,"context_line":"    Since the two SR-IOV ports are bonded together, they should share the same"},{"line_number":89,"context_line":"    mac address."},{"line_number":90,"context_line":"    The configure will be used to set the same mac address for the two ports."}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_65b346ea","line":87,"updated":"2018-08-16 01:48:02.000000000","message":"Is there any way to avoid configuration options needed in nova-compute for this? Is there some way the information that nova needs can be provided via the port binding:profile or something similar? vif_details maybe?\n\nIf we do need nova configuration, I would suggest trying to work it into the new physnets config options added in Rocky:\n\nhttps://docs.openstack.org/nova/latest/configuration/config.html#neutron.physnets","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6ed2fcef9e41c8bc69137df8867025468b299995","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        physical_device_mappings \u003d physnet1:bond1(active-backup;off;ens1-ens2)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"2.  Nova adds configure option in the nova.conf on the bond compute node."},{"line_number":88,"context_line":"    Since the two SR-IOV ports are bonded together, they should share the same"},{"line_number":89,"context_line":"    mac address."},{"line_number":90,"context_line":"    The configure will be used to set the same mac address for the two ports."}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_96df6439","line":87,"in_reply_to":"3f79a3b5_65b346ea","updated":"2018-08-20 17:27:58.000000000","message":"i dont think a configuration option in nova would be valid.\nwhich of the of the mac adresses from the different neuton ports would you use? how do you tell neutron what mac to use for security goups when using heracical port binding(e.g. there is a second ml2 driver that is configuring the switch with acls.)","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8ff4f6816d4c003d935c92dbb2972507ce826187","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        physical_device_mappings \u003d physnet1:bond1(active-backup;off;ens1-ens2)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"2.  Nova adds configure option in the nova.conf on the bond compute node."},{"line_number":88,"context_line":"    Since the two SR-IOV ports are bonded together, they should share the same"},{"line_number":89,"context_line":"    mac address."},{"line_number":90,"context_line":"    The configure will be used to set the same mac address for the two ports."}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_d89178f3","line":87,"in_reply_to":"3f79a3b5_96df6439","updated":"2018-08-21 10:43:41.000000000","message":"Yeah, this is different to the physnets option as neutron should know all this information and be able to provide it to us (unlike NUMA affinity info)","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6ed2fcef9e41c8bc69137df8867025468b299995","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"2.  Nova adds configure option in the nova.conf on the bond compute node."},{"line_number":88,"context_line":"    Since the two SR-IOV ports are bonded together, they should share the same"},{"line_number":89,"context_line":"    mac address."},{"line_number":90,"context_line":"    The configure will be used to set the same mac address for the two ports."},{"line_number":91,"context_line":"    For example::"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_9611a407","line":89,"range":{"start_line":89,"start_character":3,"end_line":89,"end_character":16},"updated":"2018-08-20 17:27:58.000000000","message":"the mac adress of the interfaces is specified by neutron.\nnova just  uses whatever value is provded by neutron so you would have to change neutron to enforce this constratin not nova.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"0ab792e5c787f1606fe3752e06fa8067747ef13a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    The configure will be used to set the same mac address for the two ports."},{"line_number":91,"context_line":"    For example::"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        physical_device_mappings \u003d physnet1:bond1(active-backup;off;ens1-ens2)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"3.  Create bond port with neutron API::"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":43,"id":"bf8cb3f7_e9f58984","line":93,"updated":"2017-12-27 23:50:11.000000000","message":"Unclear why this isn\u0027t done by the Neutron SRIOV driver if VFs are involved.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6ed2fcef9e41c8bc69137df8867025468b299995","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    The configure will be used to set the same mac address for the two ports."},{"line_number":91,"context_line":"    For example::"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        physical_device_mappings \u003d physnet1:bond1(active-backup;off;ens1-ens2)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"3.  Create bond port with neutron API::"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_d6a39cb0","line":93,"in_reply_to":"bf8cb3f7_e9f58984","updated":"2018-08-20 17:27:58.000000000","message":"this does not make sense to me either. i cant see how providing this info to neutron will help in the libvirt case as the vf configuration will be done by libvirt and this info will never be passed to it. the sriov nic agent cant alter the vf configuration without introducing a multi writer problem.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6ed2fcef9e41c8bc69137df8867025468b299995","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"3.  Create bond port with neutron API::"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"4.  Create SR-IOV VM with nova API::"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_965e8474","line":97,"range":{"start_line":97,"start_character":8,"end_line":97,"end_character":75},"updated":"2018-08-20 17:27:58.000000000","message":"should you not be createing two port here?\n\na better approch might be do emulate what was done for trunk ports and have a new api resouce. a bond port which\nhas a parent port that is attached to a vm and child ports that are the bond peers.\n\nthe workflow would be somthign like this\n\nopenstack port create  --vnic-type\u003ddirect --name\u003dbond-peer1 private\n\nopenstack port create  --vnic-type\u003ddirect --name\u003dbond-peer2 private\n\nopenstack port create  --vnic-type\u003dbond --name\u003dbond1 private\n\nopenstack bond create --parent-port bond1 --subport bond-peer1 --subport bond-peer2 --bond-mode\u003dactive-backup\n\nthen you would boot the vm with \nopenstack server create --port bond1 ...","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8ff4f6816d4c003d935c92dbb2972507ce826187","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"3.  Create bond port with neutron API::"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        neutron port-create --binding:vnic_type\u003ddirect --name bond1 private"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"4.  Create SR-IOV VM with nova API::"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_38ac2c34","line":97,"range":{"start_line":97,"start_character":8,"end_line":97,"end_character":75},"in_reply_to":"3f79a3b5_965e8474","updated":"2018-08-21 10:43:41.000000000","message":"+1 If this bonding configuration is meant to be dynamic and user configurable, I imagine we\u0027d need something like this. Otherwise, why bother getting neutron/nova involved at all?","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        nova boot --nic port-id\u003dbond1"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"5.  When nova get vif_details bonding info from neutron. It will plug"},{"line_number":104,"context_line":"    one or more VFs to VM according to the port bonding informations."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"6.  Add LINUX bond of VFs in VM."}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_e5be76ac","line":103,"range":{"start_line":103,"start_character":18,"end_line":103,"end_character":29},"updated":"2018-08-16 01:48:02.000000000","message":"Yeah this - can\u0027t we avoid nova configuration by providing the necessary information from neutron via the port?","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"0ab792e5c787f1606fe3752e06fa8067747ef13a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"5.  When nova get vif_details bonding info from neutron. It will plug"},{"line_number":104,"context_line":"    one or more VFs to VM according to the port bonding informations."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"6.  Add LINUX bond of VFs in VM."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":43,"id":"bf8cb3f7_492cb501","line":106,"updated":"2017-12-27 23:50:11.000000000","message":"This needs expressing to the VM somehow in its config data that the ports are bonded.  This spec doesn\u0027t address that.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":109,"context_line":"Alternatives"},{"line_number":110,"context_line":"------------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"  * There are no alternatives that directly satisfy SR-IOV bonding using"},{"line_number":113,"context_line":"    just one port in software level."},{"line_number":114,"context_line":"  * Some physical NICs cards support one VF for two PFs. That will satisfy"},{"line_number":115,"context_line":"    this need in hardware level, but it depends on the physical NIC card"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_45e5eada","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":2},"updated":"2018-08-16 01:48:02.000000000","message":"remove the spaces for the bullet list otherwise this does not render properly","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6ed2fcef9e41c8bc69137df8867025468b299995","unresolved":false,"context_lines":[{"line_number":109,"context_line":"Alternatives"},{"line_number":110,"context_line":"------------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"  * There are no alternatives that directly satisfy SR-IOV bonding using"},{"line_number":113,"context_line":"    just one port in software level."},{"line_number":114,"context_line":"  * Some physical NICs cards support one VF for two PFs. That will satisfy"},{"line_number":115,"context_line":"    this need in hardware level, but it depends on the physical NIC card"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_71a41209","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":2},"in_reply_to":"3f79a3b5_45e5eada","updated":"2018-08-20 17:27:58.000000000","message":"actully i can think of several ways but i think trying to have one port at the software level is actul not a good thing.\n\n\none way would be to embed granular resouce request in the neutron port.\ne.g.\nopenstack port create --binding-profile\u003d{ resources1:SRIOV_NET_VF\u003d1, resources2:SRIOV_NET_VF\u003d1,\ngroup_policy \u003d \"isolate\",bond_mode\u003d\"active-backup\"} --name bond0 private\n\nif we were to go that route haveing a first class attribute on the port would be nice but the point is we could eaily use placement resouce classes and the granular request sysntax to model the need for multiple VFs.\n\nanother approch would be to add something like the following in the binding profile.\n\n--binding-profile\u003d{bond_port\u003dtrue,bond_peers\u003d2,bond_mode\u003dactive-backup,bond_type\u003dlacp...}","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"0ab792e5c787f1606fe3752e06fa8067747ef13a","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    itself. And when we need more than two physical NICs to be bond, that"},{"line_number":117,"context_line":"    won\u0027t work."},{"line_number":118,"context_line":"  * It\u0027s better to use the agent config options than neutron port property."},{"line_number":119,"context_line":"    when you want to change a non-bond virtual machine to a bond one"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    if you use neutron port property options, maybe you should:"},{"line_number":122,"context_line":"    [1] delete or detach port"}],"source_content_type":"text/x-rst","patch_set":43,"id":"bf8cb3f7_29393140","line":119,"updated":"2017-12-27 23:50:11.000000000","message":"Actually, it would make more sense to have a port property to express that you\u0027re looking for a bonded vs unbonded port so that you can offer both in the same system.\n\nI don\u0027t see the use case for changing an unbonded VM to a bonded one *while it\u0027s running*, not to mention that live migration (which appears to be what you have in mind) generally isn\u0027t supported with SRIOV VMs (Intel\u0027s hardware can do it, in theory, but I\u0027ve never seen it done).  You appear to be solving for low-value parts of the problem, here.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6ed2fcef9e41c8bc69137df8867025468b299995","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    itself. And when we need more than two physical NICs to be bond, that"},{"line_number":117,"context_line":"    won\u0027t work."},{"line_number":118,"context_line":"  * It\u0027s better to use the agent config options than neutron port property."},{"line_number":119,"context_line":"    when you want to change a non-bond virtual machine to a bond one"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    if you use neutron port property options, maybe you should:"},{"line_number":122,"context_line":"    [1] delete or detach port"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_91f52ef0","line":119,"in_reply_to":"3f79a3b5_a50b9e8b","updated":"2018-08-20 17:27:58.000000000","message":"i also agree. hiding the fact that something is bonded in a config option will complicate resource advertisement in placement and make scheduling and live migration harder long term. i would stongly prefer to have this be a port option rather then a config option. making it a config option will effectively force operators to use availability zone or host aggregates to partion a part of there cloud for bonding as there would be no other way to guarantee that a vm lands on a bonded host with this proposal as it stands.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    itself. And when we need more than two physical NICs to be bond, that"},{"line_number":117,"context_line":"    won\u0027t work."},{"line_number":118,"context_line":"  * It\u0027s better to use the agent config options than neutron port property."},{"line_number":119,"context_line":"    when you want to change a non-bond virtual machine to a bond one"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    if you use neutron port property options, maybe you should:"},{"line_number":122,"context_line":"    [1] delete or detach port"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_a50b9e8b","line":119,"in_reply_to":"bf8cb3f7_29393140","updated":"2018-08-16 01:48:02.000000000","message":"Agree with Ian. Changing the configuration of the port while it\u0027s attached to a VM is a bad idea, but also note that you can\u0027t currently attach/detach SRIOV ports in nova:\n\nhttps://review.openstack.org/#/c/591898/","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    if you use neutron port property options, maybe you should:"},{"line_number":122,"context_line":"    [1] delete or detach port"},{"line_number":123,"context_line":"    [2] Upgrade port properties information"},{"line_number":124,"context_line":"    [3] add or attach port"},{"line_number":125,"context_line":"    Changing the port properties may affect the business of virtual machine."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    if you use the agent config options,maybe you can:"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_6501066a","line":124,"range":{"start_line":124,"start_character":4,"end_line":124,"end_character":26},"updated":"2018-08-16 01:48:02.000000000","message":"as noted above, you can\u0027t attach an sriov port to an instance - if we wanted that, it would be a dependent blueprint: https://review.openstack.org/#/c/139910/\n\nYou\u0027re likely better off in the short-term saying re-configuring an attached sriov port is not supported and would be a known documented limitation.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"0ab792e5c787f1606fe3752e06fa8067747ef13a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    Changing the port properties may affect the business of virtual machine."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    if you use the agent config options,maybe you can:"},{"line_number":128,"context_line":"    [1] Migration the virtual machine to other node"},{"line_number":129,"context_line":"    [2] Upgrade the SR-IOV configuration for this node"},{"line_number":130,"context_line":"    [3] Migration the virtual machine back"},{"line_number":131,"context_line":"    and these operations do not affect the normal business."}],"source_content_type":"text/x-rst","patch_set":43,"id":"bf8cb3f7_c93f6523","line":128,"updated":"2017-12-27 23:50:11.000000000","message":"Which wouldn\u0027t work while live, since you\u0027re changing the number of interfaces on the VM.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6ed2fcef9e41c8bc69137df8867025468b299995","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    Changing the port properties may affect the business of virtual machine."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    if you use the agent config options,maybe you can:"},{"line_number":128,"context_line":"    [1] Migration the virtual machine to other node"},{"line_number":129,"context_line":"    [2] Upgrade the SR-IOV configuration for this node"},{"line_number":130,"context_line":"    [3] Migration the virtual machine back"},{"line_number":131,"context_line":"    and these operations do not affect the normal business."}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_71273266","line":128,"in_reply_to":"bf8cb3f7_c93f6523","updated":"2018-08-20 17:27:58.000000000","message":"well for dirct sriov you cant livemigrate the vm.\ncold migrate would work but if the schduler did not pick a host with an identical config(which would be hard since it cant see these config options) the cold migrate could result in the vm haveing different number of intefaces as ian mentioned. that will likely break you workload as it would have to be reconfigured to account for the change in network topology.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6ed2fcef9e41c8bc69137df8867025468b299995","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    if you use the agent config options,maybe you can:"},{"line_number":128,"context_line":"    [1] Migration the virtual machine to other node"},{"line_number":129,"context_line":"    [2] Upgrade the SR-IOV configuration for this node"},{"line_number":130,"context_line":"    [3] Migration the virtual machine back"},{"line_number":131,"context_line":"    and these operations do not affect the normal business."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_91df6e39","line":131,"range":{"start_line":130,"start_character":8,"end_line":131,"end_character":58},"updated":"2018-08-20 17:27:58.000000000","message":"as noted above you cannont migrate with vnic_type direct\nyou would have to use vnic_type macvtap which severely limits the performance of sriov to the point wher a vswitch like vpp or ovs-dpdk would be a better choice.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":139,"context_line":"REST API impact"},{"line_number":140,"context_line":"---------------"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"None"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Security impact"},{"line_number":145,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_857b02f3","line":142,"updated":"2018-08-16 01:48:02.000000000","message":"We would need to discuss if we should add a microversion for this as a way to indicate that as of version 2.x nova supports bonded sriov ports, otherwise it\u0027s not interoperable (although I imagine interop isn\u0027t a major concern for an NFV MANO private cloud system that wants to use this). Are there any public cloud use cases for this feature?","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":144,"context_line":"Security impact"},{"line_number":145,"context_line":"---------------"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"None"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Notifications impact"},{"line_number":150,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_45816ac2","line":147,"updated":"2018-08-16 01:48:02.000000000","message":"Really? I\u0027d think anything related to HA/bonding and information from the host (including configuration) would have potential security exposures.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6ed2fcef9e41c8bc69137df8867025468b299995","unresolved":false,"context_lines":[{"line_number":144,"context_line":"Security impact"},{"line_number":145,"context_line":"---------------"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"None"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Notifications impact"},{"line_number":150,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_51f47687","line":147,"in_reply_to":"3f79a3b5_45816ac2","updated":"2018-08-20 17:27:58.000000000","message":"well in some respect None is correct as there is no security groups support by default with sriov and the bond info could be convayed using the device taging info via the metadata service without exposing the host info.\n\nthat said in a neutron heriacical mechdriver case i think this proposal would break acl enforcement at the TOR since the bond configuration is not express in the neuton api but rather in agent sepcific configs so it cannont correctly configre the top of rack switch.\n\nso i think this does have a security impact and i think which could be resolved by having first class support for bonds in neutron the same way we have first class support for trunk ports via the vlan aware vm spec.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":154,"context_line":"Other end user impact"},{"line_number":155,"context_line":"---------------------"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  * Users will be able to use SR-IOV bonding port to achieve HA."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Performance Impact"},{"line_number":160,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_6584a6d3","line":157,"range":{"start_line":157,"start_character":0,"end_line":157,"end_character":2},"updated":"2018-08-16 01:48:02.000000000","message":"remove space","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"2500e819ebbaa4746a178e8b2c8cb998d72061c1","unresolved":false,"context_lines":[{"line_number":154,"context_line":"Other end user impact"},{"line_number":155,"context_line":"---------------------"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  * Users will be able to use SR-IOV bonding port to achieve HA."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Performance Impact"},{"line_number":160,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_e204214c","line":157,"range":{"start_line":157,"start_character":0,"end_line":157,"end_character":2},"in_reply_to":"3f79a3b5_6584a6d3","updated":"2018-08-28 09:43:04.000000000","message":"Done","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":165,"context_line":"Other deployer impact"},{"line_number":166,"context_line":"---------------------"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"  * Cloud deployer will need to set the ``physical_device_mappings`` to"},{"line_number":169,"context_line":"    allow bonding for PCI devices."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_256a2e19","line":168,"range":{"start_line":168,"start_character":0,"end_line":168,"end_character":2},"updated":"2018-08-16 01:48:02.000000000","message":"remove space","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"2500e819ebbaa4746a178e8b2c8cb998d72061c1","unresolved":false,"context_lines":[{"line_number":165,"context_line":"Other deployer impact"},{"line_number":166,"context_line":"---------------------"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"  * Cloud deployer will need to set the ``physical_device_mappings`` to"},{"line_number":169,"context_line":"    allow bonding for PCI devices."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_c2f56552","line":168,"range":{"start_line":168,"start_character":0,"end_line":168,"end_character":2},"in_reply_to":"3f79a3b5_256a2e19","updated":"2018-08-28 09:43:04.000000000","message":"Done","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":187,"context_line":"Work Items"},{"line_number":188,"context_line":"----------"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"  * Reflactor existing codes to make it compatible with new port bonding info."},{"line_number":191,"context_line":"  * Implement new physnet configuration."},{"line_number":192,"context_line":"  * Add UnitTests for the new feature."},{"line_number":193,"context_line":""}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_e56f5625","line":190,"range":{"start_line":190,"start_character":0,"end_line":190,"end_character":1},"updated":"2018-08-16 01:48:02.000000000","message":"remove spaces","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":194,"context_line":"Dependencies"},{"line_number":195,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"None"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Testing"},{"line_number":200,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_85c9c226","line":197,"updated":"2018-08-16 01:48:02.000000000","message":"I thought there were dependencies on the neutron side for configuration and potentially exposing information from neutron to nova via the port\u0027s vif_details?","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":199,"context_line":"Testing"},{"line_number":200,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"  * The changes are testable through standart unit testing."},{"line_number":203,"context_line":"  * The changes are testable through compatibility testing."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_455aca82","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":2},"updated":"2018-08-16 01:48:02.000000000","message":"remove spaces","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"2500e819ebbaa4746a178e8b2c8cb998d72061c1","unresolved":false,"context_lines":[{"line_number":199,"context_line":"Testing"},{"line_number":200,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"  * The changes are testable through standart unit testing."},{"line_number":203,"context_line":"  * The changes are testable through compatibility testing."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_82c20de8","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":2},"in_reply_to":"3f79a3b5_455aca82","updated":"2018-08-28 09:43:04.000000000","message":"Done","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":208,"context_line":"The config-sriov.rst in the networking-guide should be updated with"},{"line_number":209,"context_line":"information on how this feature should be used."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"References"},{"line_number":212,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"..[1] https://blueprints.launchpad.net/nova/+spec/distribute-pci-allocation"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_e5e996e2","line":211,"updated":"2018-08-16 01:48:02.000000000","message":"I think it would be good to reference this older spec from Mirantis which also involved SR-IOV bonding:\n\nhttps://review.openstack.org/#/c/182242/\n\nAnd compare/contrast this proposal to that one - what are the major differences? Maybe that would be good information for the Alternatives section in this spec.","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":211,"context_line":"References"},{"line_number":212,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"..[1] https://blueprints.launchpad.net/nova/+spec/distribute-pci-allocation"},{"line_number":215,"context_line":"..[2] https://review.openstack.org/#/c/463526/"},{"line_number":216,"context_line":"..[3] https://etherpad.openstack.org/p/sriov-bond"},{"line_number":217,"context_line":"..[4] https://docs.openstack.org/ocata/networking-guide/config-sriov.html"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_25d8eeec","line":214,"range":{"start_line":214,"start_character":0,"end_line":214,"end_character":5},"updated":"2018-08-16 01:48:02.000000000","message":"Are these actual footnotes because they aren\u0027t rendered properly? See:\n\nhttp://docutils.sourceforge.net/docs/user/rst/quickref.html#footnotes","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8ff4f6816d4c003d935c92dbb2972507ce826187","unresolved":false,"context_lines":[{"line_number":211,"context_line":"References"},{"line_number":212,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"..[1] https://blueprints.launchpad.net/nova/+spec/distribute-pci-allocation"},{"line_number":215,"context_line":"..[2] https://review.openstack.org/#/c/463526/"},{"line_number":216,"context_line":"..[3] https://etherpad.openstack.org/p/sriov-bond"},{"line_number":217,"context_line":"..[4] https://docs.openstack.org/ocata/networking-guide/config-sriov.html"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_cbb7643a","line":214,"range":{"start_line":214,"start_character":0,"end_line":214,"end_character":5},"in_reply_to":"3f79a3b5_25d8eeec","updated":"2018-08-21 10:43:41.000000000","message":"You need spaces\n\n  .. [1] https://...","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"2500e819ebbaa4746a178e8b2c8cb998d72061c1","unresolved":false,"context_lines":[{"line_number":211,"context_line":"References"},{"line_number":212,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"..[1] https://blueprints.launchpad.net/nova/+spec/distribute-pci-allocation"},{"line_number":215,"context_line":"..[2] https://review.openstack.org/#/c/463526/"},{"line_number":216,"context_line":"..[3] https://etherpad.openstack.org/p/sriov-bond"},{"line_number":217,"context_line":"..[4] https://docs.openstack.org/ocata/networking-guide/config-sriov.html"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_429f1501","line":214,"range":{"start_line":214,"start_character":0,"end_line":214,"end_character":5},"in_reply_to":"3f79a3b5_cbb7643a","updated":"2018-08-28 09:43:04.000000000","message":"Done","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":212,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"..[1] https://blueprints.launchpad.net/nova/+spec/distribute-pci-allocation"},{"line_number":215,"context_line":"..[2] https://review.openstack.org/#/c/463526/"},{"line_number":216,"context_line":"..[3] https://etherpad.openstack.org/p/sriov-bond"},{"line_number":217,"context_line":"..[4] https://docs.openstack.org/ocata/networking-guide/config-sriov.html"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_45cf2a28","line":215,"range":{"start_line":215,"start_character":6,"end_line":215,"end_character":46},"updated":"2018-08-16 01:48:02.000000000","message":"Why are you referencing back to this same spec?","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c71e1b7a6e38bc2d57464710be21d2a9179b1566","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"   * - Release Name"},{"line_number":226,"context_line":"     - Description"},{"line_number":227,"context_line":"   * - Queen"},{"line_number":228,"context_line":"     - Introduced"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_85bea2d2","line":227,"range":{"start_line":227,"start_character":7,"end_line":227,"end_character":12},"updated":"2018-08-16 01:48:02.000000000","message":"Rocky","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"889ab77d5a76677fdf44eaef9c21473a7827dd05","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"   * - Release Name"},{"line_number":226,"context_line":"     - Description"},{"line_number":227,"context_line":"   * - Queen"},{"line_number":228,"context_line":"     - Introduced"}],"source_content_type":"text/x-rst","patch_set":43,"id":"3f79a3b5_63d00c55","line":227,"range":{"start_line":227,"start_character":7,"end_line":227,"end_character":12},"in_reply_to":"3f79a3b5_85bea2d2","updated":"2018-08-16 18:12:03.000000000","message":"I think you mean Stein","commit_id":"464580c5eb62edf07ad5a8f3679d0021aa6b99e0"}],"specs/stein/approved/sriov_bond.rst":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f6edacb016e1004c871398586139698de36c18cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"3f79a3b5_b12bdc92","updated":"2018-08-28 04:35:59.000000000","message":"The file name should be sriov-bond.rst instead of sriov_bond.rst .","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"158c489df7c039e79079a3baa78616dcede8a8a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"3f79a3b5_822f6df4","in_reply_to":"3f79a3b5_b12bdc92","updated":"2018-08-28 09:39:15.000000000","message":"Done","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f6edacb016e1004c871398586139698de36c18cf","unresolved":false,"context_lines":[{"line_number":34,"context_line":"network adapters to implement this."},{"line_number":35,"context_line":"For example:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"https://blueprints.launchpad.net/nova/+spec/distribute-pci-allocation"},{"line_number":38,"context_line":"https://blueprints.launchpad.net/nova/+spec/user-controlled-sriov-ports-allocation"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The two BP above all mention the demand about L2 redundancy for SR-IOV. Both of"},{"line_number":41,"context_line":"them give a solution how to allocate VFs in different PFs to meet the demand of"}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_7ceafb0e","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":82},"updated":"2018-08-28 04:35:59.000000000","message":"* https://blueprints.launchpad.net/nova/+spec/distribute-pci-allocation\n* https://blueprints.launchpad.net/nova/+spec/user-controlled-sriov-ports-allocation","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"158c489df7c039e79079a3baa78616dcede8a8a3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"network adapters to implement this."},{"line_number":35,"context_line":"For example:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"https://blueprints.launchpad.net/nova/+spec/distribute-pci-allocation"},{"line_number":38,"context_line":"https://blueprints.launchpad.net/nova/+spec/user-controlled-sriov-ports-allocation"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The two BP above all mention the demand about L2 redundancy for SR-IOV. Both of"},{"line_number":41,"context_line":"them give a solution how to allocate VFs in different PFs to meet the demand of"}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_2232195f","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":82},"in_reply_to":"3f79a3b5_7ceafb0e","updated":"2018-08-28 09:39:15.000000000","message":"Done","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f6edacb016e1004c871398586139698de36c18cf","unresolved":false,"context_lines":[{"line_number":41,"context_line":"them give a solution how to allocate VFs in different PFs to meet the demand of"},{"line_number":42,"context_line":"L2 redundancy."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"But these BPs have some limits in the following areas:"},{"line_number":45,"context_line":"1.  The bond port is one logic port, but both BP need to create two or more"},{"line_number":46,"context_line":"    neutron ports in a VM. These member ports can not have same mac under"},{"line_number":47,"context_line":"    neutron mac conflict check. So we must turn off VF spoof checking,"}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_dc89cf6e","line":44,"updated":"2018-08-28 04:35:59.000000000","message":"Add a blank line.","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"158c489df7c039e79079a3baa78616dcede8a8a3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"them give a solution how to allocate VFs in different PFs to meet the demand of"},{"line_number":42,"context_line":"L2 redundancy."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"But these BPs have some limits in the following areas:"},{"line_number":45,"context_line":"1.  The bond port is one logic port, but both BP need to create two or more"},{"line_number":46,"context_line":"    neutron ports in a VM. These member ports can not have same mac under"},{"line_number":47,"context_line":"    neutron mac conflict check. So we must turn off VF spoof checking,"}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_e23f4122","line":44,"in_reply_to":"3f79a3b5_dc89cf6e","updated":"2018-08-28 09:39:15.000000000","message":"Done","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f6edacb016e1004c871398586139698de36c18cf","unresolved":false,"context_lines":[{"line_number":167,"context_line":"Alternatives"},{"line_number":168,"context_line":"------------"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"  * There are no alternatives that directly satisfy SR-IOV bonding using"},{"line_number":171,"context_line":"    just one port in software level."},{"line_number":172,"context_line":"  * Some physical NICs cards support one VF for two PFs. That will satisfy"},{"line_number":173,"context_line":"    this need in hardware level, but it depends on the physical NIC card"}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_fcddab6f","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":2},"updated":"2018-08-28 04:35:59.000000000","message":"Indent. These two white spaces should be removed.","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"158c489df7c039e79079a3baa78616dcede8a8a3","unresolved":false,"context_lines":[{"line_number":167,"context_line":"Alternatives"},{"line_number":168,"context_line":"------------"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"  * There are no alternatives that directly satisfy SR-IOV bonding using"},{"line_number":171,"context_line":"    just one port in software level."},{"line_number":172,"context_line":"  * Some physical NICs cards support one VF for two PFs. That will satisfy"},{"line_number":173,"context_line":"    this need in hardware level, but it depends on the physical NIC card"}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_827d2de8","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":2},"in_reply_to":"3f79a3b5_fcddab6f","updated":"2018-08-28 09:39:15.000000000","message":"Done","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f6edacb016e1004c871398586139698de36c18cf","unresolved":false,"context_lines":[{"line_number":216,"context_line":"Other end user impact"},{"line_number":217,"context_line":"---------------------"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"  * Users will be able to use SR-IOV bonding port to achieve HA."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Performance Impact"},{"line_number":222,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_9cd6f74e","line":219,"range":{"start_line":219,"start_character":0,"end_line":219,"end_character":2},"updated":"2018-08-28 04:35:59.000000000","message":"ditto","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"158c489df7c039e79079a3baa78616dcede8a8a3","unresolved":false,"context_lines":[{"line_number":216,"context_line":"Other end user impact"},{"line_number":217,"context_line":"---------------------"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"  * Users will be able to use SR-IOV bonding port to achieve HA."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Performance Impact"},{"line_number":222,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_a245c9b5","line":219,"range":{"start_line":219,"start_character":0,"end_line":219,"end_character":2},"in_reply_to":"3f79a3b5_9cd6f74e","updated":"2018-08-28 09:39:15.000000000","message":"Done","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f6edacb016e1004c871398586139698de36c18cf","unresolved":false,"context_lines":[{"line_number":227,"context_line":"Other deployer impact"},{"line_number":228,"context_line":"---------------------"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"  * Cloud deployer will need to set the ``physical_device_mappings``"},{"line_number":231,"context_line":"    to allow bonding for PCI devices."},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_5cccdfb9","line":230,"range":{"start_line":230,"start_character":0,"end_line":230,"end_character":2},"updated":"2018-08-28 04:35:59.000000000","message":"ditto","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"158c489df7c039e79079a3baa78616dcede8a8a3","unresolved":false,"context_lines":[{"line_number":227,"context_line":"Other deployer impact"},{"line_number":228,"context_line":"---------------------"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"  * Cloud deployer will need to set the ``physical_device_mappings``"},{"line_number":231,"context_line":"    to allow bonding for PCI devices."},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_6215719b","line":230,"range":{"start_line":230,"start_character":0,"end_line":230,"end_character":2},"in_reply_to":"3f79a3b5_5cccdfb9","updated":"2018-08-28 09:39:15.000000000","message":"Done","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f6edacb016e1004c871398586139698de36c18cf","unresolved":false,"context_lines":[{"line_number":251,"context_line":"Work Items"},{"line_number":252,"context_line":"----------"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"  * Reflactor existing codes to make it compatible with new port bonding info."},{"line_number":255,"context_line":"  * Implement new physnet configuration."},{"line_number":256,"context_line":"  * Add UnitTests for the new feature."},{"line_number":257,"context_line":""}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_fcc60b9a","line":254,"range":{"start_line":254,"start_character":0,"end_line":254,"end_character":2},"updated":"2018-08-28 04:35:59.000000000","message":"ditto","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"158c489df7c039e79079a3baa78616dcede8a8a3","unresolved":false,"context_lines":[{"line_number":251,"context_line":"Work Items"},{"line_number":252,"context_line":"----------"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"  * Reflactor existing codes to make it compatible with new port bonding info."},{"line_number":255,"context_line":"  * Implement new physnet configuration."},{"line_number":256,"context_line":"  * Add UnitTests for the new feature."},{"line_number":257,"context_line":""}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_8218cdd2","line":254,"range":{"start_line":254,"start_character":0,"end_line":254,"end_character":2},"in_reply_to":"3f79a3b5_fcc60b9a","updated":"2018-08-28 09:39:15.000000000","message":"Done","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f6edacb016e1004c871398586139698de36c18cf","unresolved":false,"context_lines":[{"line_number":263,"context_line":"Testing"},{"line_number":264,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"  * The changes are testable through standart unit testing."},{"line_number":267,"context_line":"  * The changes are testable through compatibility testing."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_dcb78f20","line":266,"range":{"start_line":266,"start_character":0,"end_line":266,"end_character":2},"updated":"2018-08-28 04:35:59.000000000","message":"ditto","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"158c489df7c039e79079a3baa78616dcede8a8a3","unresolved":false,"context_lines":[{"line_number":263,"context_line":"Testing"},{"line_number":264,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"  * The changes are testable through standart unit testing."},{"line_number":267,"context_line":"  * The changes are testable through compatibility testing."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_420e358c","line":266,"range":{"start_line":266,"start_character":0,"end_line":266,"end_character":2},"in_reply_to":"3f79a3b5_dcb78f20","updated":"2018-08-28 09:39:15.000000000","message":"Done","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f6edacb016e1004c871398586139698de36c18cf","unresolved":false,"context_lines":[{"line_number":275,"context_line":"References"},{"line_number":276,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"..[1] https://blueprints.launchpad.net/nova/+spec/user-controlled-sriov-ports-allocation"},{"line_number":279,"context_line":"..[2] https://blueprints.launchpad.net/neutron/+spec/enable-trust-mode-on-vf"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"History"}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_9c883771","line":278,"range":{"start_line":278,"start_character":2,"end_line":278,"end_character":3},"updated":"2018-08-28 04:35:59.000000000","message":"Add a white space between \u0027..\u0027 and \u0027[\u0027.\n\n.. [1] https://blueprints.launchpad.net/nova/+spec/user-controlled-sriov-ports-allocation","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"158c489df7c039e79079a3baa78616dcede8a8a3","unresolved":false,"context_lines":[{"line_number":275,"context_line":"References"},{"line_number":276,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"..[1] https://blueprints.launchpad.net/nova/+spec/user-controlled-sriov-ports-allocation"},{"line_number":279,"context_line":"..[2] https://blueprints.launchpad.net/neutron/+spec/enable-trust-mode-on-vf"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"History"}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_0224bd0b","line":278,"range":{"start_line":278,"start_character":2,"end_line":278,"end_character":3},"in_reply_to":"3f79a3b5_9c883771","updated":"2018-08-28 09:39:15.000000000","message":"Done","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f6edacb016e1004c871398586139698de36c18cf","unresolved":false,"context_lines":[{"line_number":276,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"..[1] https://blueprints.launchpad.net/nova/+spec/user-controlled-sriov-ports-allocation"},{"line_number":279,"context_line":"..[2] https://blueprints.launchpad.net/neutron/+spec/enable-trust-mode-on-vf"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"History"},{"line_number":282,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_fc984bc0","line":279,"range":{"start_line":279,"start_character":0,"end_line":279,"end_character":5},"updated":"2018-08-28 04:35:59.000000000","message":"ditto","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"158c489df7c039e79079a3baa78616dcede8a8a3","unresolved":false,"context_lines":[{"line_number":276,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"..[1] https://blueprints.launchpad.net/nova/+spec/user-controlled-sriov-ports-allocation"},{"line_number":279,"context_line":"..[2] https://blueprints.launchpad.net/neutron/+spec/enable-trust-mode-on-vf"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"History"},{"line_number":282,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_a21e29b8","line":279,"range":{"start_line":279,"start_character":0,"end_line":279,"end_character":5},"in_reply_to":"3f79a3b5_fc984bc0","updated":"2018-08-28 09:39:15.000000000","message":"Done","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f6edacb016e1004c871398586139698de36c18cf","unresolved":false,"context_lines":[{"line_number":289,"context_line":"   * - Queen"},{"line_number":290,"context_line":"     - Introduced"},{"line_number":291,"context_line":"   * - Rocky"},{"line_number":292,"context_line":"     - Resubmitted"}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_bc6093d0","line":292,"updated":"2018-08-28 04:35:59.000000000","message":"Add Stein description.","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"},{"author":{"_account_id":22104,"name":"zhangyanxian","email":"zhangyanxianmail@163.com","username":"zhangyanxian"},"change_message_id":"158c489df7c039e79079a3baa78616dcede8a8a3","unresolved":false,"context_lines":[{"line_number":289,"context_line":"   * - Queen"},{"line_number":290,"context_line":"     - Introduced"},{"line_number":291,"context_line":"   * - Rocky"},{"line_number":292,"context_line":"     - Resubmitted"}],"source_content_type":"text/x-rst","patch_set":45,"id":"3f79a3b5_c219e5d0","line":292,"in_reply_to":"3f79a3b5_bc6093d0","updated":"2018-08-28 09:39:15.000000000","message":"Done","commit_id":"d8c0d630f9fd4b530cf4753e34a4a49d885d827d"}]}