)]}'
{"specs/queens/approved/patrole-nova-gate.rst":[{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"f59a0b5ef67114f07efaf627e7ef9cb328a6e4fa","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Currently, the future of policy enforcement within OpenStack is an area of"},{"line_number":20,"context_line":"ongoing innovation and discussion. Just as policy changes should be carefully"},{"line_number":21,"context_line":"crafted an documented, so too so they be tested. Thus, Nova stands to benefit"},{"line_number":22,"context_line":"from an RBAC testing framework by using a Patrole non-voting gate to validate"},{"line_number":23,"context_line":"Nova\u0027s policy enforcement."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_ba0076ac","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":10},"updated":"2017-06-06 14:45:28.000000000","message":"and","commit_id":"56f76595c18ff8e64b8685ee6d6b6ed4d124d707"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"f59a0b5ef67114f07efaf627e7ef9cb328a6e4fa","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Currently, the future of policy enforcement within OpenStack is an area of"},{"line_number":20,"context_line":"ongoing innovation and discussion. Just as policy changes should be carefully"},{"line_number":21,"context_line":"crafted an documented, so too so they be tested. Thus, Nova stands to benefit"},{"line_number":22,"context_line":"from an RBAC testing framework by using a Patrole non-voting gate to validate"},{"line_number":23,"context_line":"Nova\u0027s policy enforcement."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_7a309e9f","line":21,"range":{"start_line":21,"start_character":30,"end_line":21,"end_character":32},"updated":"2017-06-06 14:45:28.000000000","message":"should","commit_id":"56f76595c18ff8e64b8685ee6d6b6ed4d124d707"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"f59a0b5ef67114f07efaf627e7ef9cb328a6e4fa","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Policy verification is performed by:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  1. Pooling together the default `in-code` policy rules."},{"line_number":84,"context_line":"  2. Overriding the defaults with custom policy rules located in a policy.json,"},{"line_number":85,"context_line":"     if the policy file exists and the custom policy definition is explicitly"},{"line_number":86,"context_line":"     defined therein."}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_baaab66d","line":83,"range":{"start_line":83,"start_character":5,"end_line":83,"end_character":21},"updated":"2017-06-06 14:45:28.000000000","message":"This phrasing is slightly confusing. I think replacing this with \u0027Reading\u0027 or \u0027Parsing\u0027 or something to that effect would be clearer.","commit_id":"56f76595c18ff8e64b8685ee6d6b6ed4d124d707"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7535095cd5443a7465477d7c37a025fb7cf5f70d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"There are two possible solutions, depending on the type of coverage desired"},{"line_number":116,"context_line":"by Nova: either Nova-specific Patrole tests can be run, or all Patrole tests"},{"line_number":117,"context_line":"can be run."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":".. note::"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_9de00799","line":117,"range":{"start_line":116,"start_character":9,"end_line":117,"end_character":11},"updated":"2017-06-29 07:13:41.000000000","message":"As those are just RBAC testing, i think nova only tests make sense on nova gate.","commit_id":"10269cd8f37e2c8a7f262f50d021a70c52929e54"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7535095cd5443a7465477d7c37a025fb7cf5f70d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  Keystone, Cinder and Glance. Swift is not yet covered."},{"line_number":123,"context_line":".."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"The solution is to add a Patrole non-voting gate in Nova, responsible"},{"line_number":126,"context_line":"for testing Nova-specific APIs or for testing all Big Tent APIs (minus Swift),"},{"line_number":127,"context_line":"for both of the currently supported roles across these services: admin and"},{"line_number":128,"context_line":"Member. The tests should be split into separate gates for each role to provide"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_fd025b3e","line":125,"range":{"start_line":125,"start_character":33,"end_line":125,"end_character":48},"updated":"2017-06-29 07:13:41.000000000","message":"+1 for n-v initially.","commit_id":"10269cd8f37e2c8a7f262f50d021a70c52929e54"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"ecaadaff1ab547b4a72be1860d7034e8ba477e6d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  Keystone, Cinder and Glance. Swift is not yet covered."},{"line_number":123,"context_line":".."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"The solution is to add a Patrole non-voting gate in Nova, responsible"},{"line_number":126,"context_line":"for testing Nova-specific APIs or for testing all Big Tent APIs (minus Swift),"},{"line_number":127,"context_line":"for both of the currently supported roles across these services: admin and"},{"line_number":128,"context_line":"Member. The tests should be split into separate gates for each role to provide"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_cc36c5b5","line":125,"range":{"start_line":125,"start_character":33,"end_line":125,"end_character":48},"in_reply_to":"3f1d235d_fd025b3e","updated":"2017-06-29 14:22:47.000000000","message":"Yeah, that\u0027s definitely the convention and best course.","commit_id":"10269cd8f37e2c8a7f262f50d021a70c52929e54"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e8276f65e574afe8b17f96d7a9141338aaa566eb","unresolved":false,"context_lines":[{"line_number":135,"context_line":"approach to doing RBAC testing within its own gate can be adopted, with only"},{"line_number":136,"context_line":"one modification required: altering the regex passed to Tempest runner."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Patrole currently executes more than 125 Mpva RBAC tests within its own"},{"line_number":139,"context_line":"project gate for each of the two primary OpenStack roles: admin and Member."},{"line_number":140,"context_line":"In addition, Patrole executes more than 470 RBAC tests currently, across"},{"line_number":141,"context_line":"all Big Tent services. Note that Patrole requires the Tempest client as a"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_4f2be581","line":138,"range":{"start_line":138,"start_character":41,"end_line":138,"end_character":45},"updated":"2017-10-03 14:49:37.000000000","message":"Could you explain this term acronym? Google doesn\u0027t come up with anything relevant in this context.","commit_id":"10269cd8f37e2c8a7f262f50d021a70c52929e54"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"87552d1617214a13e09101e3fa7300949cddf63f","unresolved":false,"context_lines":[{"line_number":135,"context_line":"approach to doing RBAC testing within its own gate can be adopted, with only"},{"line_number":136,"context_line":"one modification required: altering the regex passed to Tempest runner."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Patrole currently executes more than 125 Mpva RBAC tests within its own"},{"line_number":139,"context_line":"project gate for each of the two primary OpenStack roles: admin and Member."},{"line_number":140,"context_line":"In addition, Patrole executes more than 470 RBAC tests currently, across"},{"line_number":141,"context_line":"all Big Tent services. Note that Patrole requires the Tempest client as a"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_ce62f016","line":138,"range":{"start_line":138,"start_character":41,"end_line":138,"end_character":45},"in_reply_to":"7f515b1d_4f2be581","updated":"2017-10-05 15:54:34.000000000","message":"That\u0027s a typo, should be Nova.","commit_id":"10269cd8f37e2c8a7f262f50d021a70c52929e54"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7535095cd5443a7465477d7c37a025fb7cf5f70d","unresolved":false,"context_lines":[{"line_number":215,"context_line":"----------"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"* Implement a tox job for executing Patrole tests."},{"line_number":218,"context_line":"* Implement a non-voting admin gate for Patrole tests in Nova infra job and"},{"line_number":219,"context_line":"  run the tox job with the admin role."},{"line_number":220,"context_line":"* Implement a non-voting Member gate Patrole tests in Nova infra job infra"},{"line_number":221,"context_line":"  and run the tox job with the Member role."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Dependencies"},{"line_number":224,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_ddad5f32","line":221,"range":{"start_line":218,"start_character":0,"end_line":221,"end_character":43},"updated":"2017-06-29 07:13:41.000000000","message":"so it means 2 n-v jobs one with admin and other with member role right?","commit_id":"10269cd8f37e2c8a7f262f50d021a70c52929e54"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"ecaadaff1ab547b4a72be1860d7034e8ba477e6d","unresolved":false,"context_lines":[{"line_number":215,"context_line":"----------"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"* Implement a tox job for executing Patrole tests."},{"line_number":218,"context_line":"* Implement a non-voting admin gate for Patrole tests in Nova infra job and"},{"line_number":219,"context_line":"  run the tox job with the admin role."},{"line_number":220,"context_line":"* Implement a non-voting Member gate Patrole tests in Nova infra job infra"},{"line_number":221,"context_line":"  and run the tox job with the Member role."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Dependencies"},{"line_number":224,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_cce80518","line":221,"range":{"start_line":218,"start_character":0,"end_line":221,"end_character":43},"in_reply_to":"3f1d235d_ddad5f32","updated":"2017-06-29 14:22:47.000000000","message":"Yes, that would be the better solution because of 2 reasons:\n1) it will provide better test isolation for debugging (though currently we add the role as a test attribute so when the test fails in the log, it shows up as test.x.y.z [admin] for example).\n2) it is easier to implement\n\nIt is possible to run all the nova tests for Member and admin in one job, but that would require some enhancement to either Tempest or Patrole to allow the role to be changed using tox. So that way we could do something like: https://github.com/openstack/tempest/blob/1b786f1c6d4ed605be0f09647b44e97f8bd40664/tox.ini#L85","commit_id":"10269cd8f37e2c8a7f262f50d021a70c52929e54"}]}