)]}'
{"specs/queens/approved/libvirt-qemu-native-luks.rst":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"037510a53fa1eb0905ba97a94e2f0ea9db3e6732","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"A user should be able to boot from or attach an encrypted LUKS volume of any"},{"line_number":34,"context_line":"file or host block device volume type to an instance without the use of host"},{"line_number":35,"context_line":"command-line utilities such as `cryptsetup`."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_1046c87d","line":35,"updated":"2017-09-05 20:07:34.000000000","message":"ACK, good idea.","commit_id":"602b18c44d64b758f932e866530380368f824790"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"373f85559fea2501d5957b8032794720f21610e3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"---------"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"A user should be able to boot from or attach an encrypted LUKS volume of any"},{"line_number":34,"context_line":"file or host block device volume type to an instance without the use of host"},{"line_number":35,"context_line":"command-line utilities such as `cryptsetup`."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_4ed6532a","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":44},"updated":"2017-08-31 16:16:15.000000000","message":"IIUC this is in the interest of end to end encryption and not having a decrypted volume sitting on the compute host, potentially accessible by undesirables. I\u0027d add something to that effect to make the \u0027why\u0027 of this spec more obvious.","commit_id":"602b18c44d64b758f932e866530380368f824790"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"037510a53fa1eb0905ba97a94e2f0ea9db3e6732","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Unit tests."},{"line_number":156,"context_line":"* Existing tempest tests should trigger the use of this new functionality"},{"line_number":157,"context_line":"  assuming the required versions of Libvirt and QEMU are present."},{"line_number":158,"context_line":"* Continue testing the fallback path using jobs that do not use UCA and thus do"},{"line_number":159,"context_line":"  not provide the required QEMU and Libvirt versions."},{"line_number":160,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_f048dc87","line":157,"updated":"2017-09-05 20:07:34.000000000","message":"IMHO I think that\u0027s actually valid for both cases where we do and do not have the correct versions installed. We still need to test the old method until it\u0027s deprecated and removed in R so this is an obvious way to test that. I\u0027ll add it to the spec now.","commit_id":"602b18c44d64b758f932e866530380368f824790"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"373f85559fea2501d5957b8032794720f21610e3","unresolved":false,"context_lines":[{"line_number":153,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Unit tests."},{"line_number":156,"context_line":"* Existing tempest tests should trigger the use of this new functionality"},{"line_number":157,"context_line":"  assuming the required versions of Libvirt and QEMU are present."},{"line_number":158,"context_line":"* Continue testing the fallback path using jobs that do not use UCA and thus do"},{"line_number":159,"context_line":"  not provide the required QEMU and Libvirt versions."},{"line_number":160,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_0e116bad","line":157,"range":{"start_line":156,"start_character":2,"end_line":157,"end_character":65},"updated":"2017-08-31 16:16:15.000000000","message":"Tempest in an of itself has no idea what\u0027s actually going on behind the scenes. *We* will know that the new LUKS codepath got tested because we control the version of packages in the gate, but I feel like it would be too easy in this situation to make a mistake, have old versions of qemu and libvirt, and never notice that we\u0027re only testing the old cryptsetup codepath. I think a functional test where we can examine the XML would be very useful here.","commit_id":"602b18c44d64b758f932e866530380368f824790"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"32c7d0c050437afb155d9b9e254dabea5fb1e553","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Unit tests."},{"line_number":156,"context_line":"* Existing tempest tests should trigger the use of this new functionality"},{"line_number":157,"context_line":"  assuming the required versions of Libvirt and QEMU are present."},{"line_number":158,"context_line":"* Continue testing the fallback path using jobs that do not use UCA and thus do"},{"line_number":159,"context_line":"  not provide the required QEMU and Libvirt versions."},{"line_number":160,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_6ecf527f","line":157,"in_reply_to":"7f287b81_f048dc87","updated":"2017-09-06 15:35:29.000000000","message":"Yeah, I didn\u0027t consider that we still need to test the old code path. In an ideal world I would have liked a functional test that\u0027s skipped if we don\u0027t have the minimum qemu/libvirt versions, and only passes if the instance XML shows the new code path is being used. But with such a test we end up with a similar problem as Tempest: in the same way we\u0027d have to check the package versions to make sure a passing Tempest test tested the new code path, we\u0027d have to check that the functional test wasn\u0027t skipped to make sure it tested the new code path. Just Jenkins +1\u0027ing a patch passing isn\u0027t enough to know, in either case.","commit_id":"602b18c44d64b758f932e866530380368f824790"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"373f85559fea2501d5957b8032794720f21610e3","unresolved":false,"context_lines":[{"line_number":161,"context_line":"Documentation Impact"},{"line_number":162,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"None"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"References"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_ce224302","line":164,"range":{"start_line":164,"start_character":0,"end_line":164,"end_character":4},"updated":"2017-08-31 16:16:15.000000000","message":"I feel like either here or in Other Deployer Impact it should be mentioned that we have this new feature that depends on specific version of QEMU and libvirt, so that deployers know that they need to at least pay attention to the versions they have installed.","commit_id":"602b18c44d64b758f932e866530380368f824790"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"037510a53fa1eb0905ba97a94e2f0ea9db3e6732","unresolved":false,"context_lines":[{"line_number":161,"context_line":"Documentation Impact"},{"line_number":162,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"None"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"References"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_d05f203f","line":164,"updated":"2017-09-05 20:07:34.000000000","message":"Yeah I\u0027ll add that to deployer impact, thanks!","commit_id":"602b18c44d64b758f932e866530380368f824790"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6f0f68b096c336e2413d9f0accfb6dfa1828278a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Nova currently supports the use of `LUKS` and `plain` dm-crypt encrypted"},{"line_number":22,"context_line":"volumes using the encryptor classes under `nova/volume/encryptors`. These"},{"line_number":23,"context_line":"frontend encryptor classes use `cryptsetup` to decrypt the encrypted volumes on"},{"line_number":24,"context_line":"the compute host. This creates a decrypted block device on the host that is"},{"line_number":25,"context_line":"then symlinked over the original volume path and attached to an instance."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_6904617f","line":22,"range":{"start_line":22,"start_character":36,"end_line":22,"end_character":66},"updated":"2017-10-03 14:09:31.000000000","message":"They are actually in the os-brick library now.","commit_id":"71a1dc4728a3018c5d3ddffda5318b58afa4a65a"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1d77e7c258ae6b9461e2858e5cb3c2602a6ff54e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Nova currently supports the use of `LUKS` and `plain` dm-crypt encrypted"},{"line_number":22,"context_line":"volumes using the encryptor classes under `nova/volume/encryptors`. These"},{"line_number":23,"context_line":"frontend encryptor classes use `cryptsetup` to decrypt the encrypted volumes on"},{"line_number":24,"context_line":"the compute host. This creates a decrypted block device on the host that is"},{"line_number":25,"context_line":"then symlinked over the original volume path and attached to an instance."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_207316b4","line":22,"range":{"start_line":22,"start_character":36,"end_line":22,"end_character":66},"in_reply_to":"7f515b1d_6904617f","updated":"2017-10-03 17:19:21.000000000","message":"ACK, thanks.","commit_id":"71a1dc4728a3018c5d3ddffda5318b58afa4a65a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6f0f68b096c336e2413d9f0accfb6dfa1828278a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Security impact"},{"line_number":74,"context_line":"---------------"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* Decrypted block devices are no longer created on the host."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Notifications impact"},{"line_number":79,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_09384d3b","line":76,"range":{"start_line":76,"start_character":2,"end_line":76,"end_character":60},"updated":"2017-10-03 14:09:31.000000000","message":"So that\u0027s good, yes? It\u0027s unclear from this statement.","commit_id":"71a1dc4728a3018c5d3ddffda5318b58afa4a65a"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1d77e7c258ae6b9461e2858e5cb3c2602a6ff54e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Security impact"},{"line_number":74,"context_line":"---------------"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* Decrypted block devices are no longer created on the host."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Notifications impact"},{"line_number":79,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_80740a9e","line":76,"range":{"start_line":76,"start_character":2,"end_line":76,"end_character":60},"in_reply_to":"7f515b1d_09384d3b","updated":"2017-10-03 17:19:21.000000000","message":"Yeah, updated to call this out as a positive.","commit_id":"71a1dc4728a3018c5d3ddffda5318b58afa4a65a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6f0f68b096c336e2413d9f0accfb6dfa1828278a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"----------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"The Libvirt virt driver will have a unique encryptor implementation outside of"},{"line_number":107,"context_line":"those Nova currently provides under `nova/volume/encryptors` or that were"},{"line_number":108,"context_line":"recently copied to os-brick under `os_brick/encryptors`."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"While this does mean that this implementation is not available to other virt"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_49c1a5e4","line":107,"range":{"start_line":107,"start_character":11,"end_line":107,"end_character":60},"updated":"2017-10-03 14:09:31.000000000","message":"again, this is gone now, they are in os-brick","commit_id":"71a1dc4728a3018c5d3ddffda5318b58afa4a65a"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1d77e7c258ae6b9461e2858e5cb3c2602a6ff54e","unresolved":false,"context_lines":[{"line_number":104,"context_line":"----------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"The Libvirt virt driver will have a unique encryptor implementation outside of"},{"line_number":107,"context_line":"those Nova currently provides under `nova/volume/encryptors` or that were"},{"line_number":108,"context_line":"recently copied to os-brick under `os_brick/encryptors`."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"While this does mean that this implementation is not available to other virt"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_00681ab8","line":107,"range":{"start_line":107,"start_character":11,"end_line":107,"end_character":60},"in_reply_to":"7f515b1d_49c1a5e4","updated":"2017-10-03 17:19:21.000000000","message":"ACK, thanks.","commit_id":"71a1dc4728a3018c5d3ddffda5318b58afa4a65a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6f0f68b096c336e2413d9f0accfb6dfa1828278a","unresolved":false,"context_lines":[{"line_number":123,"context_line":"Work Items"},{"line_number":124,"context_line":"----------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"* Extend the `nova/virt/libvirt/volumes/` volume drivers to pass the encrypted"},{"line_number":127,"context_line":"  properties of a volume to `LibvirtConfigGuestDisk`."},{"line_number":128,"context_line":"* Extend the `LibvirtConfigGuestDisk` class to configure the encryption element"},{"line_number":129,"context_line":"  of a disk device [3]_ and to also create the required Libvirt secret for the"},{"line_number":130,"context_line":"  passphrase."},{"line_number":131,"context_line":"* Only attempt to use QEMU to natively decrypt a given LUKS volume if the"},{"line_number":132,"context_line":"  required QEMU and Libvirt versions are present on the compute host attaching"},{"line_number":133,"context_line":"  the volume."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_a905b916","line":130,"range":{"start_line":126,"start_character":1,"end_line":130,"end_character":13},"updated":"2017-10-03 14:09:31.000000000","message":"Will this also work for rbd-backed volumes? Just out of curiosity because I know IBM was trying to get encrypted rbd volume support into the libvirt driver several releases ago, but danpb always told them to wait for qemu native encryption.","commit_id":"71a1dc4728a3018c5d3ddffda5318b58afa4a65a"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1d77e7c258ae6b9461e2858e5cb3c2602a6ff54e","unresolved":false,"context_lines":[{"line_number":123,"context_line":"Work Items"},{"line_number":124,"context_line":"----------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"* Extend the `nova/virt/libvirt/volumes/` volume drivers to pass the encrypted"},{"line_number":127,"context_line":"  properties of a volume to `LibvirtConfigGuestDisk`."},{"line_number":128,"context_line":"* Extend the `LibvirtConfigGuestDisk` class to configure the encryption element"},{"line_number":129,"context_line":"  of a disk device [3]_ and to also create the required Libvirt secret for the"},{"line_number":130,"context_line":"  passphrase."},{"line_number":131,"context_line":"* Only attempt to use QEMU to natively decrypt a given LUKS volume if the"},{"line_number":132,"context_line":"  required QEMU and Libvirt versions are present on the compute host attaching"},{"line_number":133,"context_line":"  the volume."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_8099aad1","line":130,"range":{"start_line":126,"start_character":1,"end_line":130,"end_character":13},"in_reply_to":"7f515b1d_a905b916","updated":"2017-10-03 17:19:21.000000000","message":"Yeah, I had to double check this recently but rbd support is wired up with these versions.","commit_id":"71a1dc4728a3018c5d3ddffda5318b58afa4a65a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6f0f68b096c336e2413d9f0accfb6dfa1828278a","unresolved":false,"context_lines":[{"line_number":142,"context_line":"* QEMU 2.6 [1]_"},{"line_number":143,"context_line":"* Libvirt 2.2.0 [2]_"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Both are have already been released as part of the Ubuntu 17.04 [4]_ [5]_ [6]_"},{"line_number":146,"context_line":"and Fedora 25 releases [7]_ [8]_ ."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"The following devstack change now provides QEMU 2.8 and Libvirt 2.5.0 for"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_69b6a1df","line":145,"range":{"start_line":145,"start_character":5,"end_line":145,"end_character":13},"updated":"2017-10-03 14:09:31.000000000","message":"s/are have/have/","commit_id":"71a1dc4728a3018c5d3ddffda5318b58afa4a65a"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1d77e7c258ae6b9461e2858e5cb3c2602a6ff54e","unresolved":false,"context_lines":[{"line_number":142,"context_line":"* QEMU 2.6 [1]_"},{"line_number":143,"context_line":"* Libvirt 2.2.0 [2]_"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Both are have already been released as part of the Ubuntu 17.04 [4]_ [5]_ [6]_"},{"line_number":146,"context_line":"and Fedora 25 releases [7]_ [8]_ ."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"The following devstack change now provides QEMU 2.8 and Libvirt 2.5.0 for"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_609eaeb9","line":145,"range":{"start_line":145,"start_character":5,"end_line":145,"end_character":13},"in_reply_to":"7f515b1d_69b6a1df","updated":"2017-10-03 17:19:21.000000000","message":"Done","commit_id":"71a1dc4728a3018c5d3ddffda5318b58afa4a65a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6f0f68b096c336e2413d9f0accfb6dfa1828278a","unresolved":false,"context_lines":[{"line_number":158,"context_line":"* Unit tests."},{"line_number":159,"context_line":"* Existing tempest tests should trigger the use of this new functionality"},{"line_number":160,"context_line":"  assuming the required versions of Libvirt and QEMU are present."},{"line_number":161,"context_line":"* Continue testing the fallback path using jobs that do not use UCA and thus do"},{"line_number":162,"context_line":"  not provide the required QEMU and Libvirt versions."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Documentation Impact"},{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_8c17ab46","line":162,"range":{"start_line":161,"start_character":2,"end_line":162,"end_character":53},"updated":"2017-10-03 14:09:31.000000000","message":"I think all devstack uses UCA now, so I\u0027m not sure how we\u0027re going to test this really.\n\nYou could test the upgrade stuff from pike-\u003equeens but we don\u0027t have encrypted volume attached tests running in the grenade job, and I\u0027m not sure if we want to add those.","commit_id":"71a1dc4728a3018c5d3ddffda5318b58afa4a65a"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1d77e7c258ae6b9461e2858e5cb3c2602a6ff54e","unresolved":false,"context_lines":[{"line_number":158,"context_line":"* Unit tests."},{"line_number":159,"context_line":"* Existing tempest tests should trigger the use of this new functionality"},{"line_number":160,"context_line":"  assuming the required versions of Libvirt and QEMU are present."},{"line_number":161,"context_line":"* Continue testing the fallback path using jobs that do not use UCA and thus do"},{"line_number":162,"context_line":"  not provide the required QEMU and Libvirt versions."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Documentation Impact"},{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_60310ea3","line":162,"range":{"start_line":161,"start_character":2,"end_line":162,"end_character":53},"in_reply_to":"7f515b1d_8c17ab46","updated":"2017-10-03 17:19:21.000000000","message":"Yeah or we could defer testing to os-brick and cinder who will continue to use the encryptors in c-vol.","commit_id":"71a1dc4728a3018c5d3ddffda5318b58afa4a65a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6f0f68b096c336e2413d9f0accfb6dfa1828278a","unresolved":false,"context_lines":[{"line_number":164,"context_line":"Documentation Impact"},{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"None"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"References"},{"line_number":170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_4c50930b","line":167,"updated":"2017-10-03 14:09:31.000000000","message":"I\u0027m surprised there are no documentation changes to make for this, but then again I don\u0027t know if we document encrypted volumes at all.","commit_id":"71a1dc4728a3018c5d3ddffda5318b58afa4a65a"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1d77e7c258ae6b9461e2858e5cb3c2602a6ff54e","unresolved":false,"context_lines":[{"line_number":164,"context_line":"Documentation Impact"},{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"None"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"References"},{"line_number":170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_a099467a","line":167,"in_reply_to":"7f515b1d_4c50930b","updated":"2017-10-03 17:19:21.000000000","message":"Right, there would limited changes required to things like : https://docs.openstack.org/cinder/pike/configuration/block-storage/volume-encryption.html","commit_id":"71a1dc4728a3018c5d3ddffda5318b58afa4a65a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6f0f68b096c336e2413d9f0accfb6dfa1828278a","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"   * - Release Name"},{"line_number":188,"context_line":"     - Description"},{"line_number":189,"context_line":"   * - Pike"},{"line_number":190,"context_line":"     - Introduced"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_8c30cbea","line":190,"range":{"start_line":189,"start_character":2,"end_line":190,"end_character":17},"updated":"2017-10-03 14:09:31.000000000","message":"Add something about being re-proposed for Queens.","commit_id":"71a1dc4728a3018c5d3ddffda5318b58afa4a65a"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1d77e7c258ae6b9461e2858e5cb3c2602a6ff54e","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"   * - Release Name"},{"line_number":188,"context_line":"     - Description"},{"line_number":189,"context_line":"   * - Pike"},{"line_number":190,"context_line":"     - Introduced"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_80888a22","line":190,"range":{"start_line":189,"start_character":2,"end_line":190,"end_character":17},"in_reply_to":"7f515b1d_8c30cbea","updated":"2017-10-03 17:19:21.000000000","message":"Done","commit_id":"71a1dc4728a3018c5d3ddffda5318b58afa4a65a"}]}
