)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"fc9d8630977a9e2ccd46f9e733cc135e2fcf6485","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Intel Fortville Dynamic Device Personalization (DDP)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Within Intel Fortville version 6, a new feature was introduced: Fortville"},{"line_number":10,"context_line":"Dynamic Device Personalization (DDP) [1]_ to program analyzer/parser via"},{"line_number":11,"context_line":"AdminQ A profile can be used to update FVL configuration tables via MMIO"},{"line_number":12,"context_line":"configuration space, not microcode or firmware itself."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This spec proposes to add a new method to read from the livbirt driver the"},{"line_number":15,"context_line":"DDP loaded profile in a network device. This new parameter will be added"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f515b1d_5f5a8582","line":12,"range":{"start_line":9,"start_character":63,"end_line":12,"end_character":54},"updated":"2017-10-02 23:59:06.000000000","message":"umm, say what? That\u0027s not a sentence :)","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c779f9c48f4f1aace25a3a0429a08431dab0c903","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Intel Fortville Dynamic Device Personalization (DDP)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Within Intel Fortville version 6, a new feature was introduced: Fortville"},{"line_number":10,"context_line":"Dynamic Device Personalization (DDP) [1]_ to program analyzer/parser via"},{"line_number":11,"context_line":"AdminQ A profile can be used to update FVL configuration tables via MMIO"},{"line_number":12,"context_line":"configuration space, not microcode or firmware itself."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This spec proposes to add a new method to read from the livbirt driver the"},{"line_number":15,"context_line":"DDP loaded profile in a network device. This new parameter will be added"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f515b1d_26cd79b6","line":12,"range":{"start_line":9,"start_character":63,"end_line":12,"end_character":54},"in_reply_to":"7f515b1d_5f5a8582","updated":"2017-10-03 09:52:20.000000000","message":"Yes you are right... I\u0027ll rephrase it again.","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"fc9d8630977a9e2ccd46f9e733cc135e2fcf6485","unresolved":false,"context_lines":[{"line_number":11,"context_line":"AdminQ A profile can be used to update FVL configuration tables via MMIO"},{"line_number":12,"context_line":"configuration space, not microcode or firmware itself."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This spec proposes to add a new method to read from the livbirt driver the"},{"line_number":15,"context_line":"DDP loaded profile in a network device. This new parameter will be added"},{"line_number":16,"context_line":"to `LibvirtConfigNodeDevicePciCap` to extend the PCI NIC information."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f515b1d_3f5d8978","line":14,"range":{"start_line":14,"start_character":56,"end_line":14,"end_character":63},"updated":"2017-10-02 23:59:06.000000000","message":"libvirt","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c779f9c48f4f1aace25a3a0429a08431dab0c903","unresolved":false,"context_lines":[{"line_number":11,"context_line":"AdminQ A profile can be used to update FVL configuration tables via MMIO"},{"line_number":12,"context_line":"configuration space, not microcode or firmware itself."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This spec proposes to add a new method to read from the livbirt driver the"},{"line_number":15,"context_line":"DDP loaded profile in a network device. This new parameter will be added"},{"line_number":16,"context_line":"to `LibvirtConfigNodeDevicePciCap` to extend the PCI NIC information."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f515b1d_46cab5a0","line":14,"range":{"start_line":14,"start_character":56,"end_line":14,"end_character":63},"in_reply_to":"7f515b1d_3f5d8978","updated":"2017-10-03 09:52:20.000000000","message":"Done","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"}],"specs/queens/approved/intel-fortville-ddp.rst":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"fc9d8630977a9e2ccd46f9e733cc135e2fcf6485","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/intel-fortville-ddp"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Within Intel Fortville version 6, a new feature was introduced: Fortville"},{"line_number":14,"context_line":"Dynamic Device Personalization (DDP) [1]_ to program analyzer/parser via AdminQ"},{"line_number":15,"context_line":"A profile can be used to update FVL configuration tables via MMIO configuration"},{"line_number":16,"context_line":"space, not microcode or firmware itself."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This new hardware feature allows to offload certain type of workloads."},{"line_number":19,"context_line":"Currently only one profile is publicly available, MPLS (Multiprotocol Label"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_bf4859b2","line":16,"range":{"start_line":13,"start_character":0,"end_line":16,"end_character":40},"updated":"2017-10-02 23:59:06.000000000","message":"The above is not a sentence.","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c779f9c48f4f1aace25a3a0429a08431dab0c903","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/intel-fortville-ddp"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Within Intel Fortville version 6, a new feature was introduced: Fortville"},{"line_number":14,"context_line":"Dynamic Device Personalization (DDP) [1]_ to program analyzer/parser via AdminQ"},{"line_number":15,"context_line":"A profile can be used to update FVL configuration tables via MMIO configuration"},{"line_number":16,"context_line":"space, not microcode or firmware itself."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This new hardware feature allows to offload certain type of workloads."},{"line_number":19,"context_line":"Currently only one profile is publicly available, MPLS (Multiprotocol Label"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_06c83da3","line":16,"range":{"start_line":13,"start_character":0,"end_line":16,"end_character":40},"in_reply_to":"7f515b1d_bf4859b2","updated":"2017-10-03 09:52:20.000000000","message":"Done","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"fc9d8630977a9e2ccd46f9e733cc135e2fcf6485","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This new hardware feature allows to offload certain type of workloads."},{"line_number":19,"context_line":"Currently only one profile is publicly available, MPLS (Multiprotocol Label"},{"line_number":20,"context_line":"Switching), but new ones will become available in the closer future."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_5fcf2528","line":20,"range":{"start_line":20,"start_character":54,"end_line":20,"end_character":60},"updated":"2017-10-02 23:59:06.000000000","message":"near","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c779f9c48f4f1aace25a3a0429a08431dab0c903","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This new hardware feature allows to offload certain type of workloads."},{"line_number":19,"context_line":"Currently only one profile is publicly available, MPLS (Multiprotocol Label"},{"line_number":20,"context_line":"Switching), but new ones will become available in the closer future."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_e6c2c184","line":20,"range":{"start_line":20,"start_character":54,"end_line":20,"end_character":60},"in_reply_to":"7f515b1d_5fcf2528","updated":"2017-10-03 09:52:20.000000000","message":"Done","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"fc9d8630977a9e2ccd46f9e733cc135e2fcf6485","unresolved":false,"context_lines":[{"line_number":30,"context_line":"---------"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* A service, running in a virtual machine, is going to use intensively MPLS"},{"line_number":33,"context_line":"  tagged frames traffic. The user wants to spawn this virtual machine in a host"},{"line_number":34,"context_line":"  with MPLS traffic offload in order to save CPU resources"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_3fd229d2","line":34,"range":{"start_line":33,"start_character":25,"end_line":34,"end_character":58},"updated":"2017-10-02 23:59:06.000000000","message":"Make this second sentence the entire use case.","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c779f9c48f4f1aace25a3a0429a08431dab0c903","unresolved":false,"context_lines":[{"line_number":30,"context_line":"---------"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* A service, running in a virtual machine, is going to use intensively MPLS"},{"line_number":33,"context_line":"  tagged frames traffic. The user wants to spawn this virtual machine in a host"},{"line_number":34,"context_line":"  with MPLS traffic offload in order to save CPU resources"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_463f5586","line":34,"range":{"start_line":33,"start_character":25,"end_line":34,"end_character":58},"in_reply_to":"7f515b1d_3fd229d2","updated":"2017-10-03 09:52:20.000000000","message":"Done","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"fc9d8630977a9e2ccd46f9e733cc135e2fcf6485","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"This spec proposes to add a new method to read from the livbirt driver the DDP"},{"line_number":41,"context_line":"loaded profile in a network device (currently only supported by Intel"},{"line_number":42,"context_line":"Fortville [2]_ 6 network interface)."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_ffd7f1bd","line":40,"range":{"start_line":40,"start_character":56,"end_line":40,"end_character":63},"updated":"2017-10-02 23:59:06.000000000","message":"libvirt","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c779f9c48f4f1aace25a3a0429a08431dab0c903","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"This spec proposes to add a new method to read from the livbirt driver the DDP"},{"line_number":41,"context_line":"loaded profile in a network device (currently only supported by Intel"},{"line_number":42,"context_line":"Fortville [2]_ 6 network interface)."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_e647611c","line":40,"range":{"start_line":40,"start_character":56,"end_line":40,"end_character":63},"in_reply_to":"7f515b1d_ffd7f1bd","updated":"2017-10-03 09:52:20.000000000","message":"Done","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"fc9d8630977a9e2ccd46f9e733cc135e2fcf6485","unresolved":false,"context_lines":[{"line_number":44,"context_line":"A new parameter will be added to `LibvirtConfigNodeDevicePciCap` class, called"},{"line_number":45,"context_line":"`profile`. This parameter will contain a string with the name of the profile"},{"line_number":46,"context_line":"loaded in the network interface, the ID and the version. This information will"},{"line_number":47,"context_line":"be stored in a XML along with these attributes."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Every publicly available DDP profile name will be added to `os-traits` in order"},{"line_number":50,"context_line":"to track and offer them as standard traits. Each profile name is unique and"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_dfe2f59f","line":47,"range":{"start_line":47,"start_character":13,"end_line":47,"end_character":18},"updated":"2017-10-02 23:59:06.000000000","message":"s/a XML/XML/","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c779f9c48f4f1aace25a3a0429a08431dab0c903","unresolved":false,"context_lines":[{"line_number":44,"context_line":"A new parameter will be added to `LibvirtConfigNodeDevicePciCap` class, called"},{"line_number":45,"context_line":"`profile`. This parameter will contain a string with the name of the profile"},{"line_number":46,"context_line":"loaded in the network interface, the ID and the version. This information will"},{"line_number":47,"context_line":"be stored in a XML along with these attributes."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Every publicly available DDP profile name will be added to `os-traits` in order"},{"line_number":50,"context_line":"to track and offer them as standard traits. Each profile name is unique and"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_6665b1b4","line":47,"range":{"start_line":47,"start_character":13,"end_line":47,"end_character":18},"in_reply_to":"7f515b1d_dfe2f59f","updated":"2017-10-03 09:52:20.000000000","message":"Done","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"fc9d8630977a9e2ccd46f9e733cc135e2fcf6485","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Every publicly available DDP profile name will be added to `os-traits` in order"},{"line_number":50,"context_line":"to track and offer them as standard traits. Each profile name is unique and"},{"line_number":51,"context_line":"invariant, enough to describe a profile. The suggested place to locate these"},{"line_number":52,"context_line":"profile names is ``os_traits.hw.ni.offload``"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"In blueprint `Enable SR-IOV NIC offload feature discovery` [3]_ (feature still"},{"line_number":55,"context_line":"in progress), `Placement API` was upgraded to also filter by virtual functions"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_bfddf9dd","line":52,"range":{"start_line":52,"start_character":32,"end_line":52,"end_character":34},"updated":"2017-10-02 23:59:06.000000000","message":"nic","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c779f9c48f4f1aace25a3a0429a08431dab0c903","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Every publicly available DDP profile name will be added to `os-traits` in order"},{"line_number":50,"context_line":"to track and offer them as standard traits. Each profile name is unique and"},{"line_number":51,"context_line":"invariant, enough to describe a profile. The suggested place to locate these"},{"line_number":52,"context_line":"profile names is ``os_traits.hw.ni.offload``"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"In blueprint `Enable SR-IOV NIC offload feature discovery` [3]_ (feature still"},{"line_number":55,"context_line":"in progress), `Placement API` was upgraded to also filter by virtual functions"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_0676fd70","line":52,"range":{"start_line":52,"start_character":32,"end_line":52,"end_character":34},"in_reply_to":"7f515b1d_bfddf9dd","updated":"2017-10-03 09:52:20.000000000","message":"Done","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"fc9d8630977a9e2ccd46f9e733cc135e2fcf6485","unresolved":false,"context_lines":[{"line_number":54,"context_line":"In blueprint `Enable SR-IOV NIC offload feature discovery` [3]_ (feature still"},{"line_number":55,"context_line":"in progress), `Placement API` was upgraded to also filter by virtual functions"},{"line_number":56,"context_line":"(`nova.objects.fields.ResourceClass.SRIOV_NET_VF` type). Users can define"},{"line_number":57,"context_line":"specific hardware capabilities to a port by defining them in the port binding"},{"line_number":58,"context_line":"profile::"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    $ openstack port create --binding-profile"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_9ff23d6f","line":57,"range":{"start_line":57,"start_character":31,"end_line":57,"end_character":33},"updated":"2017-10-02 23:59:06.000000000","message":"\"that a port requires\"","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c779f9c48f4f1aace25a3a0429a08431dab0c903","unresolved":false,"context_lines":[{"line_number":54,"context_line":"In blueprint `Enable SR-IOV NIC offload feature discovery` [3]_ (feature still"},{"line_number":55,"context_line":"in progress), `Placement API` was upgraded to also filter by virtual functions"},{"line_number":56,"context_line":"(`nova.objects.fields.ResourceClass.SRIOV_NET_VF` type). Users can define"},{"line_number":57,"context_line":"specific hardware capabilities to a port by defining them in the port binding"},{"line_number":58,"context_line":"profile::"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    $ openstack port create --binding-profile"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_a6fba9bb","line":57,"range":{"start_line":57,"start_character":31,"end_line":57,"end_character":33},"in_reply_to":"7f515b1d_9ff23d6f","updated":"2017-10-03 09:52:20.000000000","message":"Done","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"fc9d8630977a9e2ccd46f9e733cc135e2fcf6485","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Because of the limited hardware support for this feature, if the virt driver"},{"line_number":77,"context_line":"doesn\u0027t support the NIC profile reading or the hardware doesn\u0027t provide this"},{"line_number":78,"context_line":"feature, the parameter `profile` stored in `LibvirtConfigNodeDevicePciCap`"},{"line_number":79,"context_line":"won\u0027t be populated."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_3feb4978","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":15},"updated":"2017-10-02 23:59:06.000000000","message":"\"doesn\u0027t support reading the NIC profile\"","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c779f9c48f4f1aace25a3a0429a08431dab0c903","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Because of the limited hardware support for this feature, if the virt driver"},{"line_number":77,"context_line":"doesn\u0027t support the NIC profile reading or the hardware doesn\u0027t provide this"},{"line_number":78,"context_line":"feature, the parameter `profile` stored in `LibvirtConfigNodeDevicePciCap`"},{"line_number":79,"context_line":"won\u0027t be populated."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_663371ac","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":15},"in_reply_to":"7f515b1d_3feb4978","updated":"2017-10-03 09:52:20.000000000","message":"Done","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"fc9d8630977a9e2ccd46f9e733cc135e2fcf6485","unresolved":false,"context_lines":[{"line_number":76,"context_line":"Because of the limited hardware support for this feature, if the virt driver"},{"line_number":77,"context_line":"doesn\u0027t support the NIC profile reading or the hardware doesn\u0027t provide this"},{"line_number":78,"context_line":"feature, the parameter `profile` stored in `LibvirtConfigNodeDevicePciCap`"},{"line_number":79,"context_line":"won\u0027t be populated."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"NIC feature information"},{"line_number":82,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_ff001136","line":79,"updated":"2017-10-02 23:59:06.000000000","message":"Please specify what version of libvirt is going to be needed in order for this feature to work.","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c779f9c48f4f1aace25a3a0429a08431dab0c903","unresolved":false,"context_lines":[{"line_number":76,"context_line":"Because of the limited hardware support for this feature, if the virt driver"},{"line_number":77,"context_line":"doesn\u0027t support the NIC profile reading or the hardware doesn\u0027t provide this"},{"line_number":78,"context_line":"feature, the parameter `profile` stored in `LibvirtConfigNodeDevicePciCap`"},{"line_number":79,"context_line":"won\u0027t be populated."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"NIC feature information"},{"line_number":82,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_26de993d","line":79,"in_reply_to":"7f515b1d_ff001136","updated":"2017-10-03 09:52:20.000000000","message":"Done","commit_id":"79135ea7a7bdc292cd87363534c0be5cd3b578cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/intel-fortville-ddp"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Within Intel Fortville version 6, a new feature was introduced: Fortville"},{"line_number":14,"context_line":"Dynamic Device Personalization (DDP) [1]_ to program an analyzer or parser"},{"line_number":15,"context_line":"via AdminQ. A profile can be used to update FVL configuration tables via"},{"line_number":16,"context_line":"MMIO configuration space; this profile is not microcode or firmware itself."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_1b907e95","line":13,"range":{"start_line":13,"start_character":62,"end_line":13,"end_character":63},"updated":"2017-10-04 08:56:55.000000000","message":",","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/intel-fortville-ddp"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Within Intel Fortville version 6, a new feature was introduced: Fortville"},{"line_number":14,"context_line":"Dynamic Device Personalization (DDP) [1]_ to program an analyzer or parser"},{"line_number":15,"context_line":"via AdminQ. A profile can be used to update FVL configuration tables via"},{"line_number":16,"context_line":"MMIO configuration space; this profile is not microcode or firmware itself."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_5b96f696","line":13,"range":{"start_line":13,"start_character":7,"end_line":13,"end_character":22},"updated":"2017-10-04 08:56:55.000000000","message":"Intel Fortville (FVL)","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d306c9622d0fae340b677544205a858852f8e7c3","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/intel-fortville-ddp"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Within Intel Fortville version 6, a new feature was introduced: Fortville"},{"line_number":14,"context_line":"Dynamic Device Personalization (DDP) [1]_ to program an analyzer or parser"},{"line_number":15,"context_line":"via AdminQ. A profile can be used to update FVL configuration tables via"},{"line_number":16,"context_line":"MMIO configuration space; this profile is not microcode or firmware itself."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_a4f81a7c","line":13,"range":{"start_line":13,"start_character":62,"end_line":13,"end_character":63},"in_reply_to":"7f515b1d_1b907e95","updated":"2017-10-04 17:29:05.000000000","message":"Done","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d306c9622d0fae340b677544205a858852f8e7c3","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/intel-fortville-ddp"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Within Intel Fortville version 6, a new feature was introduced: Fortville"},{"line_number":14,"context_line":"Dynamic Device Personalization (DDP) [1]_ to program an analyzer or parser"},{"line_number":15,"context_line":"via AdminQ. A profile can be used to update FVL configuration tables via"},{"line_number":16,"context_line":"MMIO configuration space; this profile is not microcode or firmware itself."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_c4031673","line":13,"range":{"start_line":13,"start_character":7,"end_line":13,"end_character":22},"in_reply_to":"7f515b1d_5b96f696","updated":"2017-10-04 17:29:05.000000000","message":"Done","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/intel-fortville-ddp"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Within Intel Fortville version 6, a new feature was introduced: Fortville"},{"line_number":14,"context_line":"Dynamic Device Personalization (DDP) [1]_ to program an analyzer or parser"},{"line_number":15,"context_line":"via AdminQ. A profile can be used to update FVL configuration tables via"},{"line_number":16,"context_line":"MMIO configuration space; this profile is not microcode or firmware itself."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_dbe78646","line":14,"range":{"start_line":14,"start_character":41,"end_line":14,"end_character":44},"updated":"2017-10-04 08:56:55.000000000","message":", which allows users to","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d306c9622d0fae340b677544205a858852f8e7c3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/intel-fortville-ddp"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Within Intel Fortville version 6, a new feature was introduced: Fortville"},{"line_number":14,"context_line":"Dynamic Device Personalization (DDP) [1]_ to program an analyzer or parser"},{"line_number":15,"context_line":"via AdminQ. A profile can be used to update FVL configuration tables via"},{"line_number":16,"context_line":"MMIO configuration space; this profile is not microcode or firmware itself."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_44ef26b0","line":14,"range":{"start_line":14,"start_character":41,"end_line":14,"end_character":44},"in_reply_to":"7f515b1d_dbe78646","updated":"2017-10-04 17:29:05.000000000","message":"Done","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Within Intel Fortville version 6, a new feature was introduced: Fortville"},{"line_number":14,"context_line":"Dynamic Device Personalization (DDP) [1]_ to program an analyzer or parser"},{"line_number":15,"context_line":"via AdminQ. A profile can be used to update FVL configuration tables via"},{"line_number":16,"context_line":"MMIO configuration space; this profile is not microcode or firmware itself."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This new hardware feature allows to offload certain type of workloads."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_7b81b24a","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":10},"updated":"2017-10-04 08:56:55.000000000","message":"link?","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d306c9622d0fae340b677544205a858852f8e7c3","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Within Intel Fortville version 6, a new feature was introduced: Fortville"},{"line_number":14,"context_line":"Dynamic Device Personalization (DDP) [1]_ to program an analyzer or parser"},{"line_number":15,"context_line":"via AdminQ. A profile can be used to update FVL configuration tables via"},{"line_number":16,"context_line":"MMIO configuration space; this profile is not microcode or firmware itself."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This new hardware feature allows to offload certain type of workloads."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_441de6bb","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":10},"in_reply_to":"7f515b1d_7b81b24a","updated":"2017-10-04 17:29:05.000000000","message":"It\u0027s the same link, [1]_.\n\n.. [1] http://dpdk-test-plans.readthedocs.io/en/latest/ddp_mpls_test_plan.html","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Within Intel Fortville version 6, a new feature was introduced: Fortville"},{"line_number":14,"context_line":"Dynamic Device Personalization (DDP) [1]_ to program an analyzer or parser"},{"line_number":15,"context_line":"via AdminQ. A profile can be used to update FVL configuration tables via"},{"line_number":16,"context_line":"MMIO configuration space; this profile is not microcode or firmware itself."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This new hardware feature allows to offload certain type of workloads."},{"line_number":19,"context_line":"Currently only one profile is publicly available, MPLS (Multiprotocol Label"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_9bf10e05","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":4},"updated":"2017-10-04 08:56:55.000000000","message":"link","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d306c9622d0fae340b677544205a858852f8e7c3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Within Intel Fortville version 6, a new feature was introduced: Fortville"},{"line_number":14,"context_line":"Dynamic Device Personalization (DDP) [1]_ to program an analyzer or parser"},{"line_number":15,"context_line":"via AdminQ. A profile can be used to update FVL configuration tables via"},{"line_number":16,"context_line":"MMIO configuration space; this profile is not microcode or firmware itself."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This new hardware feature allows to offload certain type of workloads."},{"line_number":19,"context_line":"Currently only one profile is publicly available, MPLS (Multiprotocol Label"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_047daee6","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":4},"in_reply_to":"7f515b1d_9bf10e05","updated":"2017-10-04 17:29:05.000000000","message":"ditto, is in the dpdk link [1]_","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"via AdminQ. A profile can be used to update FVL configuration tables via"},{"line_number":16,"context_line":"MMIO configuration space; this profile is not microcode or firmware itself."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This new hardware feature allows to offload certain type of workloads."},{"line_number":19,"context_line":"Currently only one profile is publicly available, MPLS (Multiprotocol Label"},{"line_number":20,"context_line":"Switching), but new ones will become available in the near future."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_3bd8da7d","line":18,"range":{"start_line":18,"start_character":26,"end_line":18,"end_character":32},"updated":"2017-10-04 08:56:55.000000000","message":"allows users","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d306c9622d0fae340b677544205a858852f8e7c3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"via AdminQ. A profile can be used to update FVL configuration tables via"},{"line_number":16,"context_line":"MMIO configuration space; this profile is not microcode or firmware itself."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This new hardware feature allows to offload certain type of workloads."},{"line_number":19,"context_line":"Currently only one profile is publicly available, MPLS (Multiprotocol Label"},{"line_number":20,"context_line":"Switching), but new ones will become available in the near future."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_2478aaf6","line":18,"range":{"start_line":18,"start_character":26,"end_line":18,"end_character":32},"in_reply_to":"7f515b1d_3bd8da7d","updated":"2017-10-04 17:29:05.000000000","message":"Done","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"MMIO configuration space; this profile is not microcode or firmware itself."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This new hardware feature allows to offload certain type of workloads."},{"line_number":19,"context_line":"Currently only one profile is publicly available, MPLS (Multiprotocol Label"},{"line_number":20,"context_line":"Switching), but new ones will become available in the near future."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_bbd5ea45","line":20,"range":{"start_line":19,"start_character":50,"end_line":20,"end_character":10},"updated":"2017-10-04 08:56:55.000000000","message":"Switch the order of these:\n\n  Multiprotocol Label Switching (MPLS)","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/intel-fortville-ddp"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Within Intel Fortville version 6, a new feature was introduced: Fortville"},{"line_number":14,"context_line":"Dynamic Device Personalization (DDP) [1]_ to program an analyzer or parser"},{"line_number":15,"context_line":"via AdminQ. A profile can be used to update FVL configuration tables via"},{"line_number":16,"context_line":"MMIO configuration space; this profile is not microcode or firmware itself."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This new hardware feature allows to offload certain type of workloads."},{"line_number":19,"context_line":"Currently only one profile is publicly available, MPLS (Multiprotocol Label"},{"line_number":20,"context_line":"Switching), but new ones will become available in the near future."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_bb3a8a95","line":20,"range":{"start_line":13,"start_character":0,"end_line":20,"end_character":66},"updated":"2017-10-04 08:56:55.000000000","message":"This whole thing belongs in the problem description: this section should tell we what we want to do (read and track Dynamic Device Personalization (DPP) profiles from modern Intel NICs?)","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d306c9622d0fae340b677544205a858852f8e7c3","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/intel-fortville-ddp"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Within Intel Fortville version 6, a new feature was introduced: Fortville"},{"line_number":14,"context_line":"Dynamic Device Personalization (DDP) [1]_ to program an analyzer or parser"},{"line_number":15,"context_line":"via AdminQ. A profile can be used to update FVL configuration tables via"},{"line_number":16,"context_line":"MMIO configuration space; this profile is not microcode or firmware itself."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This new hardware feature allows to offload certain type of workloads."},{"line_number":19,"context_line":"Currently only one profile is publicly available, MPLS (Multiprotocol Label"},{"line_number":20,"context_line":"Switching), but new ones will become available in the near future."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_04f48e5a","line":20,"range":{"start_line":13,"start_character":0,"end_line":20,"end_character":66},"in_reply_to":"7f515b1d_bb3a8a95","updated":"2017-10-04 17:29:05.000000000","message":"This section is the context of the spec. I\u0027m introducing something new, FVL DDP. Then, in the problem description, as usual, I\u0027ll cry because we can\u0027t use/read it in Nova and I want to fix it.","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d306c9622d0fae340b677544205a858852f8e7c3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"MMIO configuration space; this profile is not microcode or firmware itself."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This new hardware feature allows to offload certain type of workloads."},{"line_number":19,"context_line":"Currently only one profile is publicly available, MPLS (Multiprotocol Label"},{"line_number":20,"context_line":"Switching), but new ones will become available in the near future."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_2461ca3a","line":20,"range":{"start_line":19,"start_character":50,"end_line":20,"end_character":10},"in_reply_to":"7f515b1d_bbd5ea45","updated":"2017-10-04 17:29:05.000000000","message":"Done","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Currently Nova doesn\u0027t have the ability to track or read this specific"},{"line_number":27,"context_line":"network interface parameter."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Use Cases"},{"line_number":30,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_7b44121c","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":28},"updated":"2017-10-04 08:56:55.000000000","message":"What one? The DDP profile? Something else? I\u0027m a little confused :)","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f658aaabd879e5e568a59ab932911901d80c4bd6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Currently Nova doesn\u0027t have the ability to track or read this specific"},{"line_number":27,"context_line":"network interface parameter."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Use Cases"},{"line_number":30,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_6ed9ca20","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":28},"in_reply_to":"7f515b1d_7b44121c","updated":"2017-10-05 11:14:38.000000000","message":"This description is not accurate. I\u0027ll change it.","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"This spec proposes to add a new method to read from the libvirt driver the DDP"},{"line_number":40,"context_line":"loaded profile in a network device (currently only supported by Intel"},{"line_number":41,"context_line":"Fortville [2]_ 6 network interface)."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_fb4fe231","line":39,"range":{"start_line":39,"start_character":10,"end_line":39,"end_character":25},"updated":"2017-10-04 08:56:55.000000000","message":"proposes adding","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f658aaabd879e5e568a59ab932911901d80c4bd6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"This spec proposes to add a new method to read from the libvirt driver the DDP"},{"line_number":40,"context_line":"loaded profile in a network device (currently only supported by Intel"},{"line_number":41,"context_line":"Fortville [2]_ 6 network interface)."},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_4ed60ef4","line":39,"range":{"start_line":39,"start_character":10,"end_line":39,"end_character":25},"in_reply_to":"7f515b1d_fb4fe231","updated":"2017-10-05 11:14:38.000000000","message":"Done","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"This spec proposes to add a new method to read from the libvirt driver the DDP"},{"line_number":40,"context_line":"loaded profile in a network device (currently only supported by Intel"},{"line_number":41,"context_line":"Fortville [2]_ 6 network interface)."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"A new parameter will be added to `LibvirtConfigNodeDevicePciCap` class, called"},{"line_number":44,"context_line":"`profile`. This parameter will contain a string with the name of the profile"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_3b6fba93","line":41,"range":{"start_line":39,"start_character":47,"end_line":41,"end_character":36},"updated":"2017-10-04 08:56:55.000000000","message":"switch the order of these around:\n\n  read the DDP...from the libvirt driver","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f658aaabd879e5e568a59ab932911901d80c4bd6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"This spec proposes to add a new method to read from the libvirt driver the DDP"},{"line_number":40,"context_line":"loaded profile in a network device (currently only supported by Intel"},{"line_number":41,"context_line":"Fortville [2]_ 6 network interface)."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"A new parameter will be added to `LibvirtConfigNodeDevicePciCap` class, called"},{"line_number":44,"context_line":"`profile`. This parameter will contain a string with the name of the profile"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_ce031e73","line":41,"range":{"start_line":39,"start_character":47,"end_line":41,"end_character":36},"in_reply_to":"7f515b1d_3b6fba93","updated":"2017-10-05 11:14:38.000000000","message":"Done","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"loaded profile in a network device (currently only supported by Intel"},{"line_number":41,"context_line":"Fortville [2]_ 6 network interface)."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"A new parameter will be added to `LibvirtConfigNodeDevicePciCap` class, called"},{"line_number":44,"context_line":"`profile`. This parameter will contain a string with the name of the profile"},{"line_number":45,"context_line":"loaded in the network interface, the ID and the version. This information will"},{"line_number":46,"context_line":"be stored in XML along with these attributes."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_fb680288","line":43,"range":{"start_line":43,"start_character":34,"end_line":43,"end_character":63},"updated":"2017-10-04 08:56:55.000000000","message":"One more backtick each side","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"loaded profile in a network device (currently only supported by Intel"},{"line_number":41,"context_line":"Fortville [2]_ 6 network interface)."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"A new parameter will be added to `LibvirtConfigNodeDevicePciCap` class, called"},{"line_number":44,"context_line":"`profile`. This parameter will contain a string with the name of the profile"},{"line_number":45,"context_line":"loaded in the network interface, the ID and the version. This information will"},{"line_number":46,"context_line":"be stored in XML along with these attributes."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_db0306be","line":43,"range":{"start_line":43,"start_character":70,"end_line":43,"end_character":71},"updated":"2017-10-04 08:56:55.000000000","message":"drop this","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f658aaabd879e5e568a59ab932911901d80c4bd6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"loaded profile in a network device (currently only supported by Intel"},{"line_number":41,"context_line":"Fortville [2]_ 6 network interface)."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"A new parameter will be added to `LibvirtConfigNodeDevicePciCap` class, called"},{"line_number":44,"context_line":"`profile`. This parameter will contain a string with the name of the profile"},{"line_number":45,"context_line":"loaded in the network interface, the ID and the version. This information will"},{"line_number":46,"context_line":"be stored in XML along with these attributes."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_4eef2eb0","line":43,"range":{"start_line":43,"start_character":70,"end_line":43,"end_character":71},"in_reply_to":"7f515b1d_db0306be","updated":"2017-10-05 11:14:38.000000000","message":"Done","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f658aaabd879e5e568a59ab932911901d80c4bd6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"loaded profile in a network device (currently only supported by Intel"},{"line_number":41,"context_line":"Fortville [2]_ 6 network interface)."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"A new parameter will be added to `LibvirtConfigNodeDevicePciCap` class, called"},{"line_number":44,"context_line":"`profile`. This parameter will contain a string with the name of the profile"},{"line_number":45,"context_line":"loaded in the network interface, the ID and the version. This information will"},{"line_number":46,"context_line":"be stored in XML along with these attributes."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_6ef2ea9c","line":43,"range":{"start_line":43,"start_character":34,"end_line":43,"end_character":63},"in_reply_to":"7f515b1d_fb680288","updated":"2017-10-05 11:14:38.000000000","message":"Done","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"In blueprint `Enable SR-IOV NIC offload feature discovery` [3]_ (feature still"},{"line_number":54,"context_line":"in progress), `Placement API` was upgraded to also filter by virtual functions"},{"line_number":55,"context_line":"(`nova.objects.fields.ResourceClass.SRIOV_NET_VF` type). Users can define"},{"line_number":56,"context_line":"specific hardware capabilities that a port requires by defining them in the"},{"line_number":57,"context_line":"port binding profile::"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_7b12d20b","line":55,"range":{"start_line":55,"start_character":1,"end_line":55,"end_character":49},"updated":"2017-10-04 08:56:55.000000000","message":"``code``","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f658aaabd879e5e568a59ab932911901d80c4bd6","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"In blueprint `Enable SR-IOV NIC offload feature discovery` [3]_ (feature still"},{"line_number":54,"context_line":"in progress), `Placement API` was upgraded to also filter by virtual functions"},{"line_number":55,"context_line":"(`nova.objects.fields.ResourceClass.SRIOV_NET_VF` type). Users can define"},{"line_number":56,"context_line":"specific hardware capabilities that a port requires by defining them in the"},{"line_number":57,"context_line":"port binding profile::"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_0e2ff6f6","line":55,"range":{"start_line":55,"start_character":1,"end_line":55,"end_character":49},"in_reply_to":"7f515b1d_7b12d20b","updated":"2017-10-05 11:14:38.000000000","message":"Done","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"feature, the parameter `profile` stored in `LibvirtConfigNodeDevicePciCap`"},{"line_number":78,"context_line":"won\u0027t be populated."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"libvirt currently doesn\u0027t support this feature but is under development."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"NIC feature information"},{"line_number":83,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_bbd60a27","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":72},"updated":"2017-10-04 08:56:55.000000000","message":"So this alone makes this a non-starter for Queens. Could you link to the patches upstream (or a bug tracker somewhere) where we can read up on this?","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f658aaabd879e5e568a59ab932911901d80c4bd6","unresolved":false,"context_lines":[{"line_number":77,"context_line":"feature, the parameter `profile` stored in `LibvirtConfigNodeDevicePciCap`"},{"line_number":78,"context_line":"won\u0027t be populated."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"libvirt currently doesn\u0027t support this feature but is under development."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"NIC feature information"},{"line_number":83,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_eec49742","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":72},"in_reply_to":"7f515b1d_bbd60a27","updated":"2017-10-05 11:14:38.000000000","message":"Unfortunately no, I can\u0027t provide anything yet. I know this could be a stopper for this spec, but I think this feature could be enabled in Nova (once the libvirt XML definition is done), waiting for the livbirt code.","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"-----------------------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"With the modifications implemented, libvirt will provide an additional"},{"line_number":86,"context_line":"parameter in the list of capabilities for a NIC device. Using the"},{"line_number":87,"context_line":"command line utility we can retrieve the following information ::"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    $ virsh nodedev-dumpxml net_ens785_68_05_ca_34_83_60"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_5be5d609","line":86,"range":{"start_line":86,"start_character":62,"end_line":86,"end_character":65},"updated":"2017-10-04 08:56:55.000000000","message":"the `virsh`","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f658aaabd879e5e568a59ab932911901d80c4bd6","unresolved":false,"context_lines":[{"line_number":83,"context_line":"-----------------------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"With the modifications implemented, libvirt will provide an additional"},{"line_number":86,"context_line":"parameter in the list of capabilities for a NIC device. Using the"},{"line_number":87,"context_line":"command line utility we can retrieve the following information ::"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    $ virsh nodedev-dumpxml net_ens785_68_05_ca_34_83_60"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_ae26a215","line":86,"range":{"start_line":86,"start_character":62,"end_line":86,"end_character":65},"in_reply_to":"7f515b1d_5be5d609","updated":"2017-10-05 11:14:38.000000000","message":"Done","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"parameter in the list of capabilities for a NIC device. Using the"},{"line_number":87,"context_line":"command line utility we can retrieve the following information ::"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    $ virsh nodedev-dumpxml net_ens785_68_05_ca_34_83_60"},{"line_number":90,"context_line":"    \u003cdevice\u003e"},{"line_number":91,"context_line":"      \u003cname\u003enet_ens785_68_05_ca_34_83_60\u003c/name\u003e"},{"line_number":92,"context_line":"      \u003cpath\u003e/sys/devices/pci0000:00/0000:00:02.0/0000:02:00.0/net/ens785\u003c/path\u003e"},{"line_number":93,"context_line":"      \u003cparent\u003epci_0000_02_00_0\u003c/parent\u003e"},{"line_number":94,"context_line":"      \u003ccapability type\u003d\u0027net\u0027\u003e"},{"line_number":95,"context_line":"        \u003cinterface\u003eens785\u003c/interface\u003e"},{"line_number":96,"context_line":"        \u003caddress\u003e68:05:ca:34:83:60\u003c/address\u003e"},{"line_number":97,"context_line":"        \u003clink state\u003d\u0027down\u0027/\u003e"},{"line_number":98,"context_line":"        \u003cfeature name\u003d\u0027rx\u0027/\u003e"},{"line_number":99,"context_line":"        \u003cfeature name\u003d\u0027tx\u0027/\u003e"},{"line_number":100,"context_line":"        \u003cfeature name\u003d\u0027sg\u0027/\u003e"},{"line_number":101,"context_line":"        \u003cfeature name\u003d\u0027tso\u0027/\u003e"},{"line_number":102,"context_line":"        \u003cfeature name\u003d\u0027gso\u0027/\u003e"},{"line_number":103,"context_line":"        \u003cfeature name\u003d\u0027gro\u0027/\u003e"},{"line_number":104,"context_line":"        \u003cprofile name\u003d\u0027mpls\u0027 id\u003d\u0027123456760\u0027 version\u003d\u00271.23.22\u0027/\u003e"},{"line_number":105,"context_line":"                                 ^-- example of NIC profile"},{"line_number":106,"context_line":"        \u003ccapability type\u003d\u002780203\u0027/\u003e"},{"line_number":107,"context_line":"      \u003c/capability\u003e"},{"line_number":108,"context_line":"    \u003c/device\u003e"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_9bb46ef4","line":108,"range":{"start_line":89,"start_character":0,"end_line":108,"end_character":13},"updated":"2017-10-04 08:56:55.000000000","message":"I\u0027m assuming this is still under-development and therefore subject to change?","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f658aaabd879e5e568a59ab932911901d80c4bd6","unresolved":false,"context_lines":[{"line_number":86,"context_line":"parameter in the list of capabilities for a NIC device. Using the"},{"line_number":87,"context_line":"command line utility we can retrieve the following information ::"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    $ virsh nodedev-dumpxml net_ens785_68_05_ca_34_83_60"},{"line_number":90,"context_line":"    \u003cdevice\u003e"},{"line_number":91,"context_line":"      \u003cname\u003enet_ens785_68_05_ca_34_83_60\u003c/name\u003e"},{"line_number":92,"context_line":"      \u003cpath\u003e/sys/devices/pci0000:00/0000:00:02.0/0000:02:00.0/net/ens785\u003c/path\u003e"},{"line_number":93,"context_line":"      \u003cparent\u003epci_0000_02_00_0\u003c/parent\u003e"},{"line_number":94,"context_line":"      \u003ccapability type\u003d\u0027net\u0027\u003e"},{"line_number":95,"context_line":"        \u003cinterface\u003eens785\u003c/interface\u003e"},{"line_number":96,"context_line":"        \u003caddress\u003e68:05:ca:34:83:60\u003c/address\u003e"},{"line_number":97,"context_line":"        \u003clink state\u003d\u0027down\u0027/\u003e"},{"line_number":98,"context_line":"        \u003cfeature name\u003d\u0027rx\u0027/\u003e"},{"line_number":99,"context_line":"        \u003cfeature name\u003d\u0027tx\u0027/\u003e"},{"line_number":100,"context_line":"        \u003cfeature name\u003d\u0027sg\u0027/\u003e"},{"line_number":101,"context_line":"        \u003cfeature name\u003d\u0027tso\u0027/\u003e"},{"line_number":102,"context_line":"        \u003cfeature name\u003d\u0027gso\u0027/\u003e"},{"line_number":103,"context_line":"        \u003cfeature name\u003d\u0027gro\u0027/\u003e"},{"line_number":104,"context_line":"        \u003cprofile name\u003d\u0027mpls\u0027 id\u003d\u0027123456760\u0027 version\u003d\u00271.23.22\u0027/\u003e"},{"line_number":105,"context_line":"                                 ^-- example of NIC profile"},{"line_number":106,"context_line":"        \u003ccapability type\u003d\u002780203\u0027/\u003e"},{"line_number":107,"context_line":"      \u003c/capability\u003e"},{"line_number":108,"context_line":"    \u003c/device\u003e"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_ce11deae","line":108,"range":{"start_line":89,"start_character":0,"end_line":108,"end_character":13},"in_reply_to":"7f515b1d_9bb46ef4","updated":"2017-10-05 11:14:38.000000000","message":"You are right. The XML structure is not defined yet because the libvirt development is still ongoing. If the spec is merged and the structure changes, I\u0027ll amend the content of the spec (and, of course, the future manual and docs content).","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":116,"context_line":"`features` is a list of offload features already implemented [4]_ (patch from"},{"line_number":117,"context_line":"[3]_), containing a set of available hardware offload properties."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Adding the string value of the NIC profile to `features` can simplify the code"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Data model impact"},{"line_number":122,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_3bcb3a73","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":78},"updated":"2017-10-04 08:56:55.000000000","message":"So this is the pro, but what\u0027s the con? Why are we not taking this approach?","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f658aaabd879e5e568a59ab932911901d80c4bd6","unresolved":false,"context_lines":[{"line_number":116,"context_line":"`features` is a list of offload features already implemented [4]_ (patch from"},{"line_number":117,"context_line":"[3]_), containing a set of available hardware offload properties."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Adding the string value of the NIC profile to `features` can simplify the code"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Data model impact"},{"line_number":122,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_8e1643a7","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":78},"in_reply_to":"7f515b1d_3bcb3a73","updated":"2017-10-05 11:14:38.000000000","message":"Actually, although this alternative reduces the information stored in Nova (FVL DDP profile will be reduced to a string token):\n- It\u0027s enough to filter a NIC by its loaded profile.\n- It\u0027s aligned with Placement API: DDP profile \u003d\u003d os-trait\n- Code is easier and aligned with previous feature: https://review.openstack.org/#/q/topic:bp/enable-sriov-nic-features+(status:open+OR+status:merged)","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":141,"context_line":"Other end user impact"},{"line_number":142,"context_line":"---------------------"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"None"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Performance Impact"},{"line_number":147,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_bba4caba","line":144,"range":{"start_line":144,"start_character":0,"end_line":144,"end_character":4},"updated":"2017-10-04 08:56:55.000000000","message":"Um, improved performance? :)","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f658aaabd879e5e568a59ab932911901d80c4bd6","unresolved":false,"context_lines":[{"line_number":141,"context_line":"Other end user impact"},{"line_number":142,"context_line":"---------------------"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"None"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Performance Impact"},{"line_number":147,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_4e85ebce","line":144,"range":{"start_line":144,"start_character":0,"end_line":144,"end_character":4},"in_reply_to":"7f515b1d_bba4caba","updated":"2017-10-05 11:14:38.000000000","message":"Yes, but not by default.\n\nOf course, one of the goals of this feature is to optimize the networking performace.","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":174,"context_line":"Work Items"},{"line_number":175,"context_line":"----------"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"* Implement a libvirt plugin, based on DPDK library, to make it aware of this"},{"line_number":178,"context_line":"  new parameter in the network interface."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"* Add a new trait per DDP profile. Because currently there is only one"},{"line_number":181,"context_line":"  avaiable, a trait called MPLS (under os_traits.hw.nic.offload) will be"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_5b7cb61f","line":178,"range":{"start_line":177,"start_character":0,"end_line":178,"end_character":41},"updated":"2017-10-04 08:56:55.000000000","message":"This refers to the upstream libvirt work, yes? If so, this isn\u0027t relevant to this spec IMO","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f658aaabd879e5e568a59ab932911901d80c4bd6","unresolved":false,"context_lines":[{"line_number":174,"context_line":"Work Items"},{"line_number":175,"context_line":"----------"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"* Implement a libvirt plugin, based on DPDK library, to make it aware of this"},{"line_number":178,"context_line":"  new parameter in the network interface."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"* Add a new trait per DDP profile. Because currently there is only one"},{"line_number":181,"context_line":"  avaiable, a trait called MPLS (under os_traits.hw.nic.offload) will be"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_0e50135e","line":178,"range":{"start_line":177,"start_character":0,"end_line":178,"end_character":41},"in_reply_to":"7f515b1d_5b7cb61f","updated":"2017-10-05 11:14:38.000000000","message":"You are right. This a dependency for this project but not a work item related to Nova.","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":199,"context_line":"* Add unit tests to check libvirt XML parser accepts correctly this new"},{"line_number":200,"context_line":"  parameter if exists; in other case, should be omitted."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"* Once Intel FVL CI is up and running, add tempest test to check this feature."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_1bc4fe3f","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":78},"updated":"2017-10-04 08:56:55.000000000","message":"Could you not develop these tests in isolation and publish them anyway? Just because they\u0027re not running in a CI doesn\u0027t mean you wouldn\u0027t get benefit from using them, and other interested parties (cough me cough) could harness them for their own testing efforts","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":199,"context_line":"* Add unit tests to check libvirt XML parser accepts correctly this new"},{"line_number":200,"context_line":"  parameter if exists; in other case, should be omitted."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"* Once Intel FVL CI is up and running, add tempest test to check this feature."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_fb724249","line":202,"range":{"start_line":202,"start_character":43,"end_line":202,"end_character":50},"updated":"2017-10-04 08:56:55.000000000","message":"Tempest","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f658aaabd879e5e568a59ab932911901d80c4bd6","unresolved":false,"context_lines":[{"line_number":199,"context_line":"* Add unit tests to check libvirt XML parser accepts correctly this new"},{"line_number":200,"context_line":"  parameter if exists; in other case, should be omitted."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"* Once Intel FVL CI is up and running, add tempest test to check this feature."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_4eba8b6e","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":78},"in_reply_to":"7f515b1d_1bc4fe3f","updated":"2017-10-05 11:14:38.000000000","message":"You are right. Test development shouldn\u0027t depend on a CI deployment.","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f658aaabd879e5e568a59ab932911901d80c4bd6","unresolved":false,"context_lines":[{"line_number":199,"context_line":"* Add unit tests to check libvirt XML parser accepts correctly this new"},{"line_number":200,"context_line":"  parameter if exists; in other case, should be omitted."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"* Once Intel FVL CI is up and running, add tempest test to check this feature."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_6ed0a7ca","line":202,"range":{"start_line":202,"start_character":43,"end_line":202,"end_character":50},"in_reply_to":"7f515b1d_fb724249","updated":"2017-10-05 11:14:38.000000000","message":"Done","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e341b0c4d2a7c39d69c4bcbb10d6e8ad08819a5a","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"   * - Release Name"},{"line_number":233,"context_line":"     - Description"},{"line_number":234,"context_line":"   * - Queens"},{"line_number":235,"context_line":"     - Introduced"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_bbe04ace","line":234,"range":{"start_line":234,"start_character":7,"end_line":234,"end_character":13},"updated":"2017-10-04 08:56:55.000000000","message":"Rocky, IMO","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f658aaabd879e5e568a59ab932911901d80c4bd6","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"   * - Release Name"},{"line_number":233,"context_line":"     - Description"},{"line_number":234,"context_line":"   * - Queens"},{"line_number":235,"context_line":"     - Introduced"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7f515b1d_71aaca85","line":234,"range":{"start_line":234,"start_character":7,"end_line":234,"end_character":13},"in_reply_to":"7f515b1d_bbe04ace","updated":"2017-10-05 11:14:38.000000000","message":"My aim is to present this spec now, to have it reviewed and start the development now.\n\nFor example, L119 comment is very interesting and can change the definition of how this feature can be implemented.","commit_id":"084a0c10bcd15e3b764a20ceb1594cfd94e14036"}]}