)]}'
{"specs/queens/approved/enable-sriov-nic-features.rst":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"a330a7b2720201d0155f397c3fbcb057543a42f0","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    extra_info: {\u0027capabilities\u0027:"},{"line_number":108,"context_line":"                    {\u0027network\u0027: [\u0027gso\u0027, \u0027sg\u0027, \u0027tso\u0027, \u0027tx\u0027]}"},{"line_number":109,"context_line":"                }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Neutron port ``binding:profile``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_1facb432","line":109,"updated":"2017-09-25 19:06:44.000000000","message":"When the pike version of this was merged there was discussion of making sure the os-traits library was used for this stuff (see comments on https://review.openstack.org/#/c/435954/ ). Perhaps this version can be updated to make that explicit, and use the \"traits\" term to ease the eventually migration to placement traits?","commit_id":"0af115f73c0bf8e88b63196b16e7b004e6d2c820"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b8c6078ff326f4d4586b303bbb55b327472a3297","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    extra_info: {\u0027capabilities\u0027:"},{"line_number":108,"context_line":"                    {\u0027network\u0027: [\u0027gso\u0027, \u0027sg\u0027, \u0027tso\u0027, \u0027tx\u0027]}"},{"line_number":109,"context_line":"                }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Neutron port ``binding:profile``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_18cdd9b7","line":109,"in_reply_to":"7f515b1d_1facb432","updated":"2017-09-26 08:45:06.000000000","message":"You are right! There is also a patch formating NIC features to os-traits (https://review.openstack.org/#/c/466051/)","commit_id":"0af115f73c0bf8e88b63196b16e7b004e6d2c820"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7b328d1fe5809bb544b9c973f9e6aa80b11b424d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"NIC features, in particular features around various hardware offload, are"},{"line_number":25,"context_line":"useful for network-intensive applications. Unfortunately, Nova doesn\u0027t yet"},{"line_number":26,"context_line":"retrieve physical NIC information from the system, which means the scheduler"},{"line_number":27,"context_line":"cannot filter out compute hosts that contain certain NIC features."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This information could be useful to determine, during the scheduling process,"},{"line_number":30,"context_line":"which host should contain a virtual machine. If a virtual machine, during the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_181b0e73","line":27,"range":{"start_line":27,"start_character":37,"end_line":27,"end_character":44},"updated":"2017-10-02 15:26:10.000000000","message":"do *not* contain :) if you\u0027re filtering *out*, then you want to exclude those hosts that don\u0027t have a set of traits :)","commit_id":"d9882182ca0b71b791fa37716165e84d057f4e10"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"30dc2d784b5b832496fed810a70d9487cc098f39","unresolved":false,"context_lines":[{"line_number":24,"context_line":"NIC features, in particular features around various hardware offload, are"},{"line_number":25,"context_line":"useful for network-intensive applications. Unfortunately, Nova doesn\u0027t yet"},{"line_number":26,"context_line":"retrieve physical NIC information from the system, which means the scheduler"},{"line_number":27,"context_line":"cannot filter out compute hosts that contain certain NIC features."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This information could be useful to determine, during the scheduling process,"},{"line_number":30,"context_line":"which host should contain a virtual machine. If a virtual machine, during the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_e6f6418f","line":27,"range":{"start_line":27,"start_character":37,"end_line":27,"end_character":44},"in_reply_to":"7f515b1d_181b0e73","updated":"2017-10-03 10:19:43.000000000","message":"Oh yes. I needed to read your comment twice hehehe","commit_id":"d9882182ca0b71b791fa37716165e84d057f4e10"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7b328d1fe5809bb544b9c973f9e6aa80b11b424d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"retrieve physical NIC information from the system, which means the scheduler"},{"line_number":27,"context_line":"cannot filter out compute hosts that contain certain NIC features."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This information could be useful to determine, during the scheduling process,"},{"line_number":30,"context_line":"which host should contain a virtual machine. If a virtual machine, during the"},{"line_number":31,"context_line":"booting step, request a specific NIC offload feature, Nova Scheduler will"},{"line_number":32,"context_line":"filter those hosts with PCI devices having this feature."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_d82a167d","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":45},"updated":"2017-10-02 15:26:10.000000000","message":"Remove this sentence; it\u0027s not necessary.","commit_id":"d9882182ca0b71b791fa37716165e84d057f4e10"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"30dc2d784b5b832496fed810a70d9487cc098f39","unresolved":false,"context_lines":[{"line_number":26,"context_line":"retrieve physical NIC information from the system, which means the scheduler"},{"line_number":27,"context_line":"cannot filter out compute hosts that contain certain NIC features."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This information could be useful to determine, during the scheduling process,"},{"line_number":30,"context_line":"which host should contain a virtual machine. If a virtual machine, during the"},{"line_number":31,"context_line":"booting step, request a specific NIC offload feature, Nova Scheduler will"},{"line_number":32,"context_line":"filter those hosts with PCI devices having this feature."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_c6f10597","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":45},"in_reply_to":"7f515b1d_d82a167d","updated":"2017-10-03 10:19:43.000000000","message":"Done","commit_id":"d9882182ca0b71b791fa37716165e84d057f4e10"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7b328d1fe5809bb544b9c973f9e6aa80b11b424d","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This information could be useful to determine, during the scheduling process,"},{"line_number":30,"context_line":"which host should contain a virtual machine. If a virtual machine, during the"},{"line_number":31,"context_line":"booting step, request a specific NIC offload feature, Nova Scheduler will"},{"line_number":32,"context_line":"filter those hosts with PCI devices having this feature."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The aim of this spec is to fill this gap by proposing a method to read this"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_98201e9d","line":31,"range":{"start_line":31,"start_character":14,"end_line":31,"end_character":33},"updated":"2017-10-02 15:26:10.000000000","message":"s/request a specific/discovers a/","commit_id":"d9882182ca0b71b791fa37716165e84d057f4e10"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"30dc2d784b5b832496fed810a70d9487cc098f39","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This information could be useful to determine, during the scheduling process,"},{"line_number":30,"context_line":"which host should contain a virtual machine. If a virtual machine, during the"},{"line_number":31,"context_line":"booting step, request a specific NIC offload feature, Nova Scheduler will"},{"line_number":32,"context_line":"filter those hosts with PCI devices having this feature."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The aim of this spec is to fill this gap by proposing a method to read this"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_c646a5c0","line":31,"range":{"start_line":31,"start_character":14,"end_line":31,"end_character":33},"in_reply_to":"7f515b1d_98201e9d","updated":"2017-10-03 10:19:43.000000000","message":"Done","commit_id":"d9882182ca0b71b791fa37716165e84d057f4e10"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7b328d1fe5809bb544b9c973f9e6aa80b11b424d","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This information could be useful to determine, during the scheduling process,"},{"line_number":30,"context_line":"which host should contain a virtual machine. If a virtual machine, during the"},{"line_number":31,"context_line":"booting step, request a specific NIC offload feature, Nova Scheduler will"},{"line_number":32,"context_line":"filter those hosts with PCI devices having this feature."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The aim of this spec is to fill this gap by proposing a method to read this"},{"line_number":35,"context_line":"information, store it, use it during the scheduling process and provide a way"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_9855befc","line":32,"range":{"start_line":31,"start_character":54,"end_line":32,"end_character":56},"updated":"2017-10-02 15:26:10.000000000","message":"s/Nova Scheduler will filter those host5s with/nova scheduler can select those hosts that have/\n\ns/PCI devices having this feature/PCI devices with that/","commit_id":"d9882182ca0b71b791fa37716165e84d057f4e10"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"30dc2d784b5b832496fed810a70d9487cc098f39","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This information could be useful to determine, during the scheduling process,"},{"line_number":30,"context_line":"which host should contain a virtual machine. If a virtual machine, during the"},{"line_number":31,"context_line":"booting step, request a specific NIC offload feature, Nova Scheduler will"},{"line_number":32,"context_line":"filter those hosts with PCI devices having this feature."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The aim of this spec is to fill this gap by proposing a method to read this"},{"line_number":35,"context_line":"information, store it, use it during the scheduling process and provide a way"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_e63be134","line":32,"range":{"start_line":31,"start_character":54,"end_line":32,"end_character":56},"in_reply_to":"7f515b1d_9855befc","updated":"2017-10-03 10:19:43.000000000","message":"Done","commit_id":"d9882182ca0b71b791fa37716165e84d057f4e10"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"cf91177b1d1d70a2ed18bf88bb3e5a51de85ade5","unresolved":false,"context_lines":[{"line_number":92,"context_line":"``nova.virt.libvirt.config.LibvirtConfigNodeDevicePciCap`` class, called"},{"line_number":93,"context_line":"\u0027net_features\u0027. This member will be a list of strings, e.g.,"},{"line_number":94,"context_line":"\u0027HW_NIC_OFFLOAD_RX\u0027, \u0027HW_NIC_OFFLOAD_TSO\u0027 or \u0027HW_NIC_OFFLOAD_RSHASH\u0027. This list"},{"line_number":95,"context_line":"is empty by default. If a PCI device is not a NIC interface doesn\u0027t have any"},{"line_number":96,"context_line":"feature, the list will remain empty."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Store the NIC features information"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_a204c715","line":95,"range":{"start_line":95,"start_character":60,"end_line":95,"end_character":67},"updated":"2017-10-02 13:23:35.000000000","message":"or doesn\u0027t","commit_id":"d9882182ca0b71b791fa37716165e84d057f4e10"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"30dc2d784b5b832496fed810a70d9487cc098f39","unresolved":false,"context_lines":[{"line_number":92,"context_line":"``nova.virt.libvirt.config.LibvirtConfigNodeDevicePciCap`` class, called"},{"line_number":93,"context_line":"\u0027net_features\u0027. This member will be a list of strings, e.g.,"},{"line_number":94,"context_line":"\u0027HW_NIC_OFFLOAD_RX\u0027, \u0027HW_NIC_OFFLOAD_TSO\u0027 or \u0027HW_NIC_OFFLOAD_RSHASH\u0027. This list"},{"line_number":95,"context_line":"is empty by default. If a PCI device is not a NIC interface doesn\u0027t have any"},{"line_number":96,"context_line":"feature, the list will remain empty."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Store the NIC features information"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_86166da7","line":95,"range":{"start_line":95,"start_character":60,"end_line":95,"end_character":67},"in_reply_to":"7f515b1d_a204c715","updated":"2017-10-03 10:19:43.000000000","message":"Done","commit_id":"d9882182ca0b71b791fa37716165e84d057f4e10"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"cf91177b1d1d70a2ed18bf88bb3e5a51de85ade5","unresolved":false,"context_lines":[{"line_number":114,"context_line":"As seen in the example above, the strings representing network capabilities are"},{"line_number":115,"context_line":"traits belonging to ``os-traits`` project. Those traits are located under"},{"line_number":116,"context_line":"``os_traits.hw.nic`` directory [2]_. Any other string not found in"},{"line_number":117,"context_line":"``os-traits`` will be discarded."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Neutron port ``binding:profile``"},{"line_number":120,"context_line":"--------------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_62236fa8","line":117,"updated":"2017-10-02 13:23:35.000000000","message":"Unclear if a bad trait should be logged or not. What\u0027s the expectation there?","commit_id":"d9882182ca0b71b791fa37716165e84d057f4e10"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"30dc2d784b5b832496fed810a70d9487cc098f39","unresolved":false,"context_lines":[{"line_number":114,"context_line":"As seen in the example above, the strings representing network capabilities are"},{"line_number":115,"context_line":"traits belonging to ``os-traits`` project. Those traits are located under"},{"line_number":116,"context_line":"``os_traits.hw.nic`` directory [2]_. Any other string not found in"},{"line_number":117,"context_line":"``os-traits`` will be discarded."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Neutron port ``binding:profile``"},{"line_number":120,"context_line":"--------------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_669a5114","line":117,"in_reply_to":"7f515b1d_62236fa8","updated":"2017-10-03 10:19:43.000000000","message":"If a bad trait is found:\n- A warning message will be written in the log.\n- This trait will be removed from the capabilities:network list.\n- No exception will be risen.\n\nI\u0027ll write this in the spec.","commit_id":"d9882182ca0b71b791fa37716165e84d057f4e10"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7b328d1fe5809bb544b9c973f9e6aa80b11b424d","unresolved":false,"context_lines":[{"line_number":125,"context_line":"E.g.: how to define a Neutron port with NIC features information ::"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    $ openstack port create --binding-profile"},{"line_number":128,"context_line":"        \u0027{\"capabilities\": [\"HW_NIC_OFFLOAD_RX\", \"HW_NIC_OFFLOAD_TSO\"]}\u0027"},{"line_number":129,"context_line":"        --network private port1"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_98581efa","line":128,"range":{"start_line":128,"start_character":8,"end_line":128,"end_character":71},"updated":"2017-10-02 15:26:10.000000000","message":"These represent the capabilities that the port is *requesting*, right?","commit_id":"d9882182ca0b71b791fa37716165e84d057f4e10"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"30dc2d784b5b832496fed810a70d9487cc098f39","unresolved":false,"context_lines":[{"line_number":125,"context_line":"E.g.: how to define a Neutron port with NIC features information ::"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    $ openstack port create --binding-profile"},{"line_number":128,"context_line":"        \u0027{\"capabilities\": [\"HW_NIC_OFFLOAD_RX\", \"HW_NIC_OFFLOAD_TSO\"]}\u0027"},{"line_number":129,"context_line":"        --network private port1"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_c657c525","line":128,"range":{"start_line":128,"start_character":8,"end_line":128,"end_character":71},"in_reply_to":"7f515b1d_98581efa","updated":"2017-10-03 10:19:43.000000000","message":"Yes, I\u0027ll change the phare above.","commit_id":"d9882182ca0b71b791fa37716165e84d057f4e10"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fa069506b1db7a53a9edcc795803e08bb1e45e6","unresolved":false,"context_lines":[{"line_number":254,"context_line":"* How to define the new parameters in the Nova Flavor extra specs fields."},{"line_number":255,"context_line":"* How to define a new Neutron port with these new parameters."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"openstack-manuals SR-IOV section must also contain this information."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"References"},{"line_number":260,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f515b1d_c05ca61a","line":257,"range":{"start_line":257,"start_character":0,"end_line":257,"end_character":68},"updated":"2017-10-09 14:38:48.000000000","message":"This is now part of the nova/neutron docs","commit_id":"c64cc35c12cff49aa9d0b03182bea7923430b3bd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b0b4f867b85692c79198cee66c9045035ea3a523","unresolved":false,"context_lines":[{"line_number":254,"context_line":"* How to define the new parameters in the Nova Flavor extra specs fields."},{"line_number":255,"context_line":"* How to define a new Neutron port with these new parameters."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"openstack-manuals SR-IOV section must also contain this information."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"References"},{"line_number":260,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f4e5783_447d036d","line":257,"range":{"start_line":257,"start_character":0,"end_line":257,"end_character":68},"in_reply_to":"7f515b1d_c05ca61a","updated":"2017-10-10 08:35:44.000000000","message":"You are right. I didn\u0027t pay attention to this section when I proposed this spec again.\n\nI\u0027ll change it.","commit_id":"c64cc35c12cff49aa9d0b03182bea7923430b3bd"}]}