)]}'
{"specs/queens/approved/deprecate-file-injection.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7565663676abcca30e501587012d1aa491781ea7","unresolved":false,"context_lines":[{"line_number":85,"context_line":"   Specifying the ``personality`` parameter in the request body to either API"},{"line_number":86,"context_line":"   will result in a `400 Bad Request` error response."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"   .. note:: We will *not* add support to pass ``user_data`` to the rebuild"},{"line_number":89,"context_line":"      server API as a result of this change. Passing ``personality`` files"},{"line_number":90,"context_line":"      when rebuilding a server was a workaround due to the lack of persistence"},{"line_number":91,"context_line":"      of those files. With rebuild, the new guest would be created with the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_ba75f934","line":88,"updated":"2017-10-03 16:08:04.000000000","message":"I\u0027m not really sure about this, so wanted to start a discussion in the mailing list:\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2017-October/123043.html","commit_id":"bace86d9f497c25599d595f43f9a7e46b163691c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ad29f720bc5310ff8bd203970ce25cb980ef6fc0","unresolved":false,"context_lines":[{"line_number":85,"context_line":"   Specifying the ``personality`` parameter in the request body to either API"},{"line_number":86,"context_line":"   will result in a `400 Bad Request` error response."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"   .. note:: We will *not* add support to pass ``user_data`` to the rebuild"},{"line_number":89,"context_line":"      server API as a result of this change. Passing ``personality`` files"},{"line_number":90,"context_line":"      when rebuilding a server was a workaround due to the lack of persistence"},{"line_number":91,"context_line":"      of those files. With rebuild, the new guest would be created with the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_b5a11849","line":88,"in_reply_to":"7f515b1d_ba75f934","updated":"2017-10-06 21:47:19.000000000","message":"Based on the operator and user feedback here:\n\nhttp://lists.openstack.org/pipermail/openstack-operators/2017-October/014309.html\n\nI think we might as well allow passing user_data to rebuild in place of personality files in this same microversion change. I tracked down the commit that added personality files to the rebuild API and there was no explanation why it was done, so my assumption in here is unfounded.","commit_id":"bace86d9f497c25599d595f43f9a7e46b163691c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8241a72bc006bf6441bae7eb8230872140c197ab","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"   Personality files are not persisted in the database which means they cannot"},{"line_number":48,"context_line":"   be retrieved via the metadata service API nor are they available during"},{"line_number":49,"context_line":"   operations like evacuate where the server instance is rebuilt on a different"},{"line_number":50,"context_line":"   compute host because the source host failed."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"#. There are better alternatives available"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f4e5783_d0d3435f","line":49,"range":{"start_line":49,"start_character":19,"end_line":49,"end_character":27},"updated":"2017-10-16 16:37:59.000000000","message":"or unshelve","commit_id":"5d7bc7bd79207b39078fd9d5950e98128af6f244"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"859b990c21833c87391c2f196c192004c97c0d17","unresolved":false,"context_lines":[{"line_number":107,"context_line":"   storing in ``user_data`` what otherwise would have been specified with"},{"line_number":108,"context_line":"   personality files."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Since personality file injection will still be supported with older"},{"line_number":111,"context_line":"microversions, there will be nothing removed from the backend compute code"},{"line_number":112,"context_line":"related to file injection (except for the insecure VFSLocalFS code as noted"},{"line_number":113,"context_line":"already). Nor will there be any deprecation of related configuration options"},{"line_number":114,"context_line":"for file injection. The point of this microversion is really to signal that"},{"line_number":115,"context_line":"users should not be using this legacy part of the compute API, and to set a"},{"line_number":116,"context_line":"timer on when it could be removed if nova ever starts requiring a higher"},{"line_number":117,"context_line":"minimum supported microversion in the distant future."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Alternatives"},{"line_number":120,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f4e5783_6e79912d","line":117,"range":{"start_line":110,"start_character":0,"end_line":117,"end_character":53},"updated":"2017-10-13 06:10:52.000000000","message":"From the API contract, we can ignore the `personality` field in the request with old microversion, that is part of the behavior of the current API, as the line 23 said. If we consider that some of user still depend on this feature, then we can keep it, otherwise, I think we can ignore it in the old microversion, and that doesn\u0027t break the API rule.","commit_id":"5d7bc7bd79207b39078fd9d5950e98128af6f244"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"60404de10922cd3c678080048c24e8a69cc62294","unresolved":false,"context_lines":[{"line_number":107,"context_line":"   storing in ``user_data`` what otherwise would have been specified with"},{"line_number":108,"context_line":"   personality files."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Since personality file injection will still be supported with older"},{"line_number":111,"context_line":"microversions, there will be nothing removed from the backend compute code"},{"line_number":112,"context_line":"related to file injection (except for the insecure VFSLocalFS code as noted"},{"line_number":113,"context_line":"already). Nor will there be any deprecation of related configuration options"},{"line_number":114,"context_line":"for file injection. The point of this microversion is really to signal that"},{"line_number":115,"context_line":"users should not be using this legacy part of the compute API, and to set a"},{"line_number":116,"context_line":"timer on when it could be removed if nova ever starts requiring a higher"},{"line_number":117,"context_line":"minimum supported microversion in the distant future."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Alternatives"},{"line_number":120,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f4e5783_e40c74a6","line":117,"range":{"start_line":110,"start_character":0,"end_line":117,"end_character":53},"in_reply_to":"5f4e5783_6e79912d","updated":"2017-10-13 15:32:11.000000000","message":"I don\u0027t think we can ignore personality files in the request for older microversions, regardless of discoverability. If a deployment has documented that they support it in their product or cloud API reference, we can\u0027t just break them.","commit_id":"5d7bc7bd79207b39078fd9d5950e98128af6f244"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"860d78107fcaa3e72369626e8e71b1085f78651c","unresolved":false,"context_lines":[{"line_number":107,"context_line":"   storing in ``user_data`` what otherwise would have been specified with"},{"line_number":108,"context_line":"   personality files."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Since personality file injection will still be supported with older"},{"line_number":111,"context_line":"microversions, there will be nothing removed from the backend compute code"},{"line_number":112,"context_line":"related to file injection (except for the insecure VFSLocalFS code as noted"},{"line_number":113,"context_line":"already). Nor will there be any deprecation of related configuration options"},{"line_number":114,"context_line":"for file injection. The point of this microversion is really to signal that"},{"line_number":115,"context_line":"users should not be using this legacy part of the compute API, and to set a"},{"line_number":116,"context_line":"timer on when it could be removed if nova ever starts requiring a higher"},{"line_number":117,"context_line":"minimum supported microversion in the distant future."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Alternatives"},{"line_number":120,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f4e5783_8ee911e7","line":117,"range":{"start_line":110,"start_character":0,"end_line":117,"end_character":53},"in_reply_to":"5f4e5783_e40c74a6","updated":"2017-10-17 13:23:56.000000000","message":"+1 mriedem","commit_id":"5d7bc7bd79207b39078fd9d5950e98128af6f244"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"8f23c6ddb53af5b49aa7720ec952c02496b15570","unresolved":false,"context_lines":[{"line_number":241,"context_line":"- The `Manage Compute service quotas`_ doc will need to be updated."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":".. _Manage Compute service quotas: https://docs.openstack.org/nova/pike/admin/quotas.html"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"References"},{"line_number":246,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f4e5783_af07a71c","line":244,"updated":"2017-10-12 07:25:09.000000000","message":"support matrix seems also need update\nhttps://github.com/openstack/nova/blob/master/doc/source/user/support-matrix.ini#L853\nthough I am not sure why we need say injection in support matrix at all..","commit_id":"5d7bc7bd79207b39078fd9d5950e98128af6f244"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"5a3eac1b55dc3fb49fab20b2cff69a2533d8d654","unresolved":false,"context_lines":[{"line_number":241,"context_line":"- The `Manage Compute service quotas`_ doc will need to be updated."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":".. _Manage Compute service quotas: https://docs.openstack.org/nova/pike/admin/quotas.html"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"References"},{"line_number":246,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f4e5783_3fb4ed34","line":244,"in_reply_to":"5f4e5783_71318cec","updated":"2017-10-13 01:32:32.000000000","message":"ok, that make sense, thanks for the explanation","commit_id":"5d7bc7bd79207b39078fd9d5950e98128af6f244"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2c4bc6e0f203700226aa63a3e720a6ac7e93f4d7","unresolved":false,"context_lines":[{"line_number":241,"context_line":"- The `Manage Compute service quotas`_ doc will need to be updated."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":".. _Manage Compute service quotas: https://docs.openstack.org/nova/pike/admin/quotas.html"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"References"},{"line_number":246,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f4e5783_71318cec","line":244,"in_reply_to":"5f4e5783_af07a71c","updated":"2017-10-12 14:11:06.000000000","message":"I\u0027m not sure what I\u0027d update in here. The drivers that support file injection will continue to support it for older microversions.\n\nAnd it is OK to list it in the support matrix because there are certain drivers that don\u0027t support file injection outside of the config drive, like vmware and hyperv - the files to inject are only used in those drivers when building a config drive.","commit_id":"5d7bc7bd79207b39078fd9d5950e98128af6f244"}]}