)]}'
{"specs/queens/approved/virt-rescue-stable-disk-devices.rst":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"230e89de1e9a61fb4b8e1d048ce27fb267141e15","unresolved":false,"context_lines":[{"line_number":223,"context_line":"Add a microversion for stable rescue."},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Extend the compute manager rescue code to handle the full block device mapping"},{"line_number":226,"context_line":"including cinder volume attachment."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"Extend the ImageMetaProps object to add the two new properties described."},{"line_number":229,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f4e5783_664c5ac7","line":226,"updated":"2017-10-11 10:10:31.000000000","message":"s","commit_id":"631ddc94501bc07cdf3fb3fc78e281692d73af49"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"8695e5b6f7e9c49fa68e6e999b03d63ad8e07c43","unresolved":false,"context_lines":[{"line_number":223,"context_line":"Add a microversion for stable rescue."},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Extend the compute manager rescue code to handle the full block device mapping"},{"line_number":226,"context_line":"including cinder volume attachment."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"Extend the ImageMetaProps object to add the two new properties described."},{"line_number":229,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f4e5783_60731d17","line":226,"in_reply_to":"5f4e5783_664c5ac7","updated":"2017-10-11 11:35:53.000000000","message":"As I\u0027m updating anyway... Done.","commit_id":"631ddc94501bc07cdf3fb3fc78e281692d73af49"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"230e89de1e9a61fb4b8e1d048ce27fb267141e15","unresolved":false,"context_lines":[{"line_number":225,"context_line":"Extend the compute manager rescue code to handle the full block device mapping"},{"line_number":226,"context_line":"including cinder volume attachment."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"Extend the ImageMetaProps object to add the two new properties described."},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"Extend the nova libvirt driver to setup all disks when running in rescue"},{"line_number":231,"context_line":"mode."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f4e5783_66e1fa9a","line":228,"range":{"start_line":228,"start_character":0,"end_line":228,"end_character":73},"updated":"2017-10-11 10:10:31.000000000","message":"These landed a while ago FYI I92cc4fd5337fb7a7d55bdff4cfee62bdf3ecf8a1","commit_id":"631ddc94501bc07cdf3fb3fc78e281692d73af49"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"8695e5b6f7e9c49fa68e6e999b03d63ad8e07c43","unresolved":false,"context_lines":[{"line_number":225,"context_line":"Extend the compute manager rescue code to handle the full block device mapping"},{"line_number":226,"context_line":"including cinder volume attachment."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"Extend the ImageMetaProps object to add the two new properties described."},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"Extend the nova libvirt driver to setup all disks when running in rescue"},{"line_number":231,"context_line":"mode."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f4e5783_e004ad7d","line":228,"range":{"start_line":228,"start_character":0,"end_line":228,"end_character":73},"in_reply_to":"5f4e5783_66e1fa9a","updated":"2017-10-11 11:35:53.000000000","message":"Ah, yes. I did spot that but hadn\u0027t updated the spec.","commit_id":"631ddc94501bc07cdf3fb3fc78e281692d73af49"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"48d54921e6e12ec7b802068ad039bf9955308e96","unresolved":false,"context_lines":[{"line_number":57,"context_line":"undesirable learning burden for the admin."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"When disks change what address they appear at, this can cause upset"},{"line_number":60,"context_line":"licensing checks of some guests OS too. For example, if hardware"},{"line_number":61,"context_line":"devices change their address too frequently, Windows may decide to"},{"line_number":62,"context_line":"ask for license re-activation. This is again an undesirable thing"},{"line_number":63,"context_line":"for admins in general."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_4585e1ac","line":60,"updated":"2017-10-19 11:42:52.000000000","message":"nit: \"to\" or \"for\" licensing","commit_id":"56310b0f5e83358a2f312655dee16e4a240b80b9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5e7ec219b928039502e33ad3d1b99ad5f7583ae9","unresolved":false,"context_lines":[{"line_number":89,"context_line":"* The rescue behaviour will be as requested, or the request will fail."},{"line_number":90,"context_line":"* Where possible the request will fail synchronously with no action taken if"},{"line_number":91,"context_line":"  stable rescue is not supported."},{"line_number":92,"context_line":"* Where not possible the request will fail asynchronously, but the instance"},{"line_number":93,"context_line":"  will not be placed into an ERROR state if the only reason for the failure was"},{"line_number":94,"context_line":"  that stable rescue is not supported."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The latter is a wart. The api service knows whether the compute host is new"},{"line_number":97,"context_line":"enough to support stable rescue, but it doesn\u0027t know without making an"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_0384815d","line":94,"range":{"start_line":92,"start_character":0,"end_line":94,"end_character":38},"updated":"2017-10-19 12:51:32.000000000","message":"I assume that in this case the state of the instance will be the same as before the rescue was initiated. How the admin will know that the rescue failed due to the not supported option? Only via the compute service logs?","commit_id":"56310b0f5e83358a2f312655dee16e4a240b80b9"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"c5c5b60521d88ff4fb1bff679e4d12b2fff2d7de","unresolved":false,"context_lines":[{"line_number":89,"context_line":"* The rescue behaviour will be as requested, or the request will fail."},{"line_number":90,"context_line":"* Where possible the request will fail synchronously with no action taken if"},{"line_number":91,"context_line":"  stable rescue is not supported."},{"line_number":92,"context_line":"* Where not possible the request will fail asynchronously, but the instance"},{"line_number":93,"context_line":"  will not be placed into an ERROR state if the only reason for the failure was"},{"line_number":94,"context_line":"  that stable rescue is not supported."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The latter is a wart. The api service knows whether the compute host is new"},{"line_number":97,"context_line":"enough to support stable rescue, but it doesn\u0027t know without making an"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_e0271412","line":94,"range":{"start_line":92,"start_character":0,"end_line":94,"end_character":38},"in_reply_to":"3f4b6375_0384815d","updated":"2017-10-19 16:48:07.000000000","message":"Yes. The user will see that they requested rescue and... literally nothing happened. The admin will see it in the logs.\n\nAs described below this is undesirable. I don\u0027t see a better way for now, though.","commit_id":"56310b0f5e83358a2f312655dee16e4a240b80b9"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"21b131287b2ef8b343e6d162bdb8d17f592c998b","unresolved":false,"context_lines":[{"line_number":113,"context_line":" - hw_rescue_bus\u003dvirtio|ide|usb|scsi"},{"line_number":114,"context_line":" - hw_rescue_device\u003ddisk|floppy|cdrom"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Together, these 2 changes form the user-facing API. If a user requests a rescue"},{"line_number":117,"context_line":"using the new microversion and specifies a rescue image with either"},{"line_number":118,"context_line":"\u0027hw_rescue_bus\u0027 or \u0027hw_rescue_device\u0027, the request is for stable rescue. If the"},{"line_number":119,"context_line":"request uses an older microversion, or the rescue image does not have either of"},{"line_number":120,"context_line":"these properties, we will use the old behaviour."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"If either of these 2 properties are omitted, they will use driver-specific"},{"line_number":123,"context_line":"defaults. For the libvirt driver, this means the default bus would"},{"line_number":124,"context_line":"match the hw_disk_bus, or the device type would be \"disk\"."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Internally, we will also bump the RPC version of the compute host, and add a"},{"line_number":127,"context_line":"\u0027stable\u0027 argument to ComputeManager.rescue_instance(). This will indicate to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f4e5783_44c3ec89","line":124,"range":{"start_line":116,"start_character":0,"end_line":124,"end_character":58},"updated":"2017-10-17 21:13:29.000000000","message":"What if someone is cool with both of the driver-specific defaults? They still get old behavior with the new microversion? It seems odd that they can omit one or the other to fall back on defaults, but not both.","commit_id":"56310b0f5e83358a2f312655dee16e4a240b80b9"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"2e0c5e861a71a4dd074368193f183c891e8fc0bb","unresolved":false,"context_lines":[{"line_number":113,"context_line":" - hw_rescue_bus\u003dvirtio|ide|usb|scsi"},{"line_number":114,"context_line":" - hw_rescue_device\u003ddisk|floppy|cdrom"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Together, these 2 changes form the user-facing API. If a user requests a rescue"},{"line_number":117,"context_line":"using the new microversion and specifies a rescue image with either"},{"line_number":118,"context_line":"\u0027hw_rescue_bus\u0027 or \u0027hw_rescue_device\u0027, the request is for stable rescue. If the"},{"line_number":119,"context_line":"request uses an older microversion, or the rescue image does not have either of"},{"line_number":120,"context_line":"these properties, we will use the old behaviour."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"If either of these 2 properties are omitted, they will use driver-specific"},{"line_number":123,"context_line":"defaults. For the libvirt driver, this means the default bus would"},{"line_number":124,"context_line":"match the hw_disk_bus, or the device type would be \"disk\"."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Internally, we will also bump the RPC version of the compute host, and add a"},{"line_number":127,"context_line":"\u0027stable\u0027 argument to ComputeManager.rescue_instance(). This will indicate to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_8f71bae3","line":124,"range":{"start_line":116,"start_character":0,"end_line":124,"end_character":58},"in_reply_to":"3f4b6375_2e2bef94","updated":"2017-10-19 10:12:30.000000000","message":"The code defining these properties has actually already merged. This spec was previously approved, and partially landed. Practically speaking, this means that without a really good reason we\u0027re not going to change them (and please, especially not on deadline day!).\n\nTo address your point directly these properties are only defined in terms of stable rescue. This is a documentation thing. Also they don\u0027t make sense for legacy rescue, as it doesn\u0027t boot that way: legacy rescue is always first disk on the default bus, replacing the root disk.","commit_id":"56310b0f5e83358a2f312655dee16e4a240b80b9"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b1220741d82deeeaea1e55ecab2f138bbe54d6f3","unresolved":false,"context_lines":[{"line_number":113,"context_line":" - hw_rescue_bus\u003dvirtio|ide|usb|scsi"},{"line_number":114,"context_line":" - hw_rescue_device\u003ddisk|floppy|cdrom"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Together, these 2 changes form the user-facing API. If a user requests a rescue"},{"line_number":117,"context_line":"using the new microversion and specifies a rescue image with either"},{"line_number":118,"context_line":"\u0027hw_rescue_bus\u0027 or \u0027hw_rescue_device\u0027, the request is for stable rescue. If the"},{"line_number":119,"context_line":"request uses an older microversion, or the rescue image does not have either of"},{"line_number":120,"context_line":"these properties, we will use the old behaviour."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"If either of these 2 properties are omitted, they will use driver-specific"},{"line_number":123,"context_line":"defaults. For the libvirt driver, this means the default bus would"},{"line_number":124,"context_line":"match the hw_disk_bus, or the device type would be \"disk\"."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Internally, we will also bump the RPC version of the compute host, and add a"},{"line_number":127,"context_line":"\u0027stable\u0027 argument to ComputeManager.rescue_instance(). This will indicate to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_2e2bef94","line":124,"range":{"start_line":116,"start_character":0,"end_line":124,"end_character":58},"in_reply_to":"3f4b6375_cebeb4fe","updated":"2017-10-19 06:37:41.000000000","message":"From the name of hw_rescue_bus and hw_rescue_device two properties, there isn\u0027t any hint it is about stable rescue. And sounds like two properties unrelated to the stable or not?","commit_id":"56310b0f5e83358a2f312655dee16e4a240b80b9"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"2b28533ffddd3abad447614a04868316e1c6c6e7","unresolved":false,"context_lines":[{"line_number":113,"context_line":" - hw_rescue_bus\u003dvirtio|ide|usb|scsi"},{"line_number":114,"context_line":" - hw_rescue_device\u003ddisk|floppy|cdrom"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Together, these 2 changes form the user-facing API. If a user requests a rescue"},{"line_number":117,"context_line":"using the new microversion and specifies a rescue image with either"},{"line_number":118,"context_line":"\u0027hw_rescue_bus\u0027 or \u0027hw_rescue_device\u0027, the request is for stable rescue. If the"},{"line_number":119,"context_line":"request uses an older microversion, or the rescue image does not have either of"},{"line_number":120,"context_line":"these properties, we will use the old behaviour."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"If either of these 2 properties are omitted, they will use driver-specific"},{"line_number":123,"context_line":"defaults. For the libvirt driver, this means the default bus would"},{"line_number":124,"context_line":"match the hw_disk_bus, or the device type would be \"disk\"."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Internally, we will also bump the RPC version of the compute host, and add a"},{"line_number":127,"context_line":"\u0027stable\u0027 argument to ComputeManager.rescue_instance(). This will indicate to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_cebeb4fe","line":124,"range":{"start_line":116,"start_character":0,"end_line":124,"end_character":58},"in_reply_to":"5f4e5783_44c3ec89","updated":"2017-10-18 11:49:18.000000000","message":"I\u0027ve ended up keeping the spec essentially as written by lyarwood with changes suggest by mriedem. However, my first thought when taking this over was exactly what you\u0027ve just said, and in fact that\u0027s how I wrote the first draft of this spec.\n\nMy first draft added a \u0027stable\u0027 flag to the rest call, which would default to false. In order to get stable rescue, the user would have to do \u0027rescue --stable ...\u0027, and they wouldn\u0027t have to specify any image properties (but they could if they wanted to). I went back to the original because I couldn\u0027t decide if operators were more likely to have specific rescue images or not.\n\nIf users tend to have specific rescue images, then setting these parameters on them is no hassle and the stable flag is superfluous.\n\nHowever, if users tend to use stock images as rescue images, then the requirement to have these additional flags would be superfluous.\n\nIn the end I reverted to this as the image parameters have already landed, and it doesn\u0027t preclude a later feature to allow stable rescue with un-annotated images. As long as I can get it approved by Thursday, though, I\u0027m genuinely ambivalent.","commit_id":"56310b0f5e83358a2f312655dee16e4a240b80b9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5e7ec219b928039502e33ad3d1b99ad5f7583ae9","unresolved":false,"context_lines":[{"line_number":137,"context_line":"image with hw_rescue_bus\u003dide and hw_rescue_device\u003dcdrom to cause a new CDROM"},{"line_number":138,"context_line":"device to be exposed with the rescue media."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"The libvirt driver will be changed so that when booting in rescue mode, all the"},{"line_number":141,"context_line":"cinder volumes, local ephemeral non-root disks and swap disks are present in"},{"line_number":142,"context_line":"rescue mode. The rescue root device will be added as the *last* device in the"},{"line_number":143,"context_line":"configuration, but will be marked as bootable for the BIOS, so it takes"},{"line_number":144,"context_line":"priority over the existing root device. This relies on KVM/QEMU supporting the"},{"line_number":145,"context_line":"\"bootindex\" parameter, which all supported versions do. This new rescue mode"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_c3dc2948","line":142,"range":{"start_line":140,"start_character":0,"end_line":142,"end_character":12},"updated":"2017-10-19 12:51:32.000000000","message":"Is this change only happen if the rescue requested with the new microversion?","commit_id":"56310b0f5e83358a2f312655dee16e4a240b80b9"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"c5c5b60521d88ff4fb1bff679e4d12b2fff2d7de","unresolved":false,"context_lines":[{"line_number":137,"context_line":"image with hw_rescue_bus\u003dide and hw_rescue_device\u003dcdrom to cause a new CDROM"},{"line_number":138,"context_line":"device to be exposed with the rescue media."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"The libvirt driver will be changed so that when booting in rescue mode, all the"},{"line_number":141,"context_line":"cinder volumes, local ephemeral non-root disks and swap disks are present in"},{"line_number":142,"context_line":"rescue mode. The rescue root device will be added as the *last* device in the"},{"line_number":143,"context_line":"configuration, but will be marked as bootable for the BIOS, so it takes"},{"line_number":144,"context_line":"priority over the existing root device. This relies on KVM/QEMU supporting the"},{"line_number":145,"context_line":"\"bootindex\" parameter, which all supported versions do. This new rescue mode"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_a0f35c9e","line":142,"range":{"start_line":140,"start_character":0,"end_line":142,"end_character":12},"in_reply_to":"3f4b6375_c3dc2948","updated":"2017-10-19 16:48:07.000000000","message":"Yes. In fact, that\u0027s the only purpose of the new microversion.","commit_id":"56310b0f5e83358a2f312655dee16e4a240b80b9"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"21b131287b2ef8b343e6d162bdb8d17f592c998b","unresolved":false,"context_lines":[{"line_number":230,"context_line":"mode."},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"Extend the nova libvirt driver to honour the new image meta properties in"},{"line_number":233,"context_line":"rescue mode disk config"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"Dependencies"},{"line_number":236,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f4e5783_c4d8fc53","line":233,"updated":"2017-10-17 21:13:29.000000000","message":"It seems like the compute RPC API version bump is missing here.","commit_id":"56310b0f5e83358a2f312655dee16e4a240b80b9"}]}
