)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23942,"name":"Matt Kucia","email":"maciej@kucia.net","username":"maciejkucia"},"change_message_id":"5d0a5437b925cb4c6117fda99d06c1fe50aa4af3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Report correct server IP information when multiple networks with the same name"},{"line_number":10,"context_line":"are used in VM. This spec proposes to group VM networks using their IDs rater"},{"line_number":11,"context_line":"than names in Server IPs API resource."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1b13ed3bfc647b1b85e1535bc17c06bde0fe0d24"},{"line_number":14,"context_line":"Signed-off-by: Maciej Kucia \u003cmaciej@kucia.net\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f485f77_f3a3bcb0","line":12,"updated":"2017-11-20 01:19:56.000000000","message":"Missing partial-bug","commit_id":"ee4337a1266eb878cda05a9d8fc7cad90254609e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ca0fabe8338759823fadc1e0bc0f4733c1c83bb0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Report correct server IP information when multiple networks with the same name"},{"line_number":10,"context_line":"are used in VM. This spec proposes to group VM networks using their IDs rater"},{"line_number":11,"context_line":"than names in Server IPs API resource."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-Bug: #1708316"},{"line_number":14,"context_line":"Change-Id: I1b13ed3bfc647b1b85e1535bc17c06bde0fe0d24"},{"line_number":15,"context_line":"Signed-off-by: Maciej Kucia \u003cmaciej@kucia.net\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bf659307_ed4fd831","line":12,"updated":"2018-03-27 18:59:04.000000000","message":"Add the following on separate lines:\n\nAPIImpact\n\nSpec for blueprint servers-ips-non-unique-network-names","commit_id":"89ea1fcf2bea99c17e6733187ec1d1c1dfbd581a"}],"specs/queens/approved/servers-ips-non-unique-network-names.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ca0fabe8338759823fadc1e0bc0f4733c1c83bb0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Neutron allows multiple networks with the same name. Nova allows adding"},{"line_number":21,"context_line":"multiple networks to a VM."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"When two networks with the same name are added to a VM and Servers IPs API"},{"line_number":24,"context_line":"request is made then incorrect information is returned. Response is the same"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf659307_0df9ecc6","line":21,"range":{"start_line":20,"start_character":53,"end_line":21,"end_character":26},"updated":"2018-03-27 18:59:04.000000000","message":"Right, so as seen here:\n\nhttps://github.com/openstack/nova/blob/97042c0253be345beff3b99d08988cf95f60e759/nova/api/openstack/compute/servers.py#L348\n\nWhen you create a server (or attach an interface to a server) you can specify network id (uuid, not name), port id, or fixed IP. You can specify the same network ID multiple times to get multiple ports attached to the server on the same network, and you can specify different networks to get ports on different networks for the same instance.\n\nThis problem is also similar to security groups, where the names for security groups in nova must be unique, but in neutron they don\u0027t have to be.","commit_id":"89ea1fcf2bea99c17e6733187ec1d1c1dfbd581a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ca0fabe8338759823fadc1e0bc0f4733c1c83bb0","unresolved":false,"context_lines":[{"line_number":92,"context_line":"Use Cases"},{"line_number":93,"context_line":"---------"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"* As an API user, querying server IP information."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Proposed change"},{"line_number":98,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf659307_eda7d8a6","line":95,"range":{"start_line":95,"start_character":2,"end_line":95,"end_character":49},"updated":"2018-03-27 18:59:04.000000000","message":"This isn\u0027t really a use case. Would be better as:\n\n\"As an API user with a server attached to multiple networks with the same name, I want to be able to uniquely identify with which networks the server IP addresses are associated.","commit_id":"89ea1fcf2bea99c17e6733187ec1d1c1dfbd581a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ca0fabe8338759823fadc1e0bc0f4733c1c83bb0","unresolved":false,"context_lines":[{"line_number":115,"context_line":"REST API impact"},{"line_number":116,"context_line":"---------------"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"2 changes to API by new microversion in v2.55 API."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Change resource path from::"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf659307_edc0382d","line":118,"range":{"start_line":118,"start_character":40,"end_line":118,"end_character":45},"updated":"2018-03-27 18:59:04.000000000","message":"This is already used, and likely whatever you specify might not be what you end up getting, so don\u0027t be specific about the version, just say it\u0027s in a new microversion.","commit_id":"89ea1fcf2bea99c17e6733187ec1d1c1dfbd581a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ca0fabe8338759823fadc1e0bc0f4733c1c83bb0","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    /servers/{server_id}/ips/{network_id}"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Change schema of ``/servers/{server_id}/ips`` resource to:"},{"line_number":129,"context_line":"* group networks by IDs"},{"line_number":130,"context_line":"* preserve network name in the network group"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":".. code-block:: javascript"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf659307_4de7e4e5","line":129,"updated":"2018-03-27 18:59:04.000000000","message":"Need to have a blank line above the bullet list for it to format properly.","commit_id":"89ea1fcf2bea99c17e6733187ec1d1c1dfbd581a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ca0fabe8338759823fadc1e0bc0f4733c1c83bb0","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"   * - Release Name"},{"line_number":227,"context_line":"     - Description"},{"line_number":228,"context_line":"   * - Queens"},{"line_number":229,"context_line":"     - Introduced"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf659307_edd598e6","line":229,"range":{"start_line":228,"start_character":3,"end_line":229,"end_character":17},"updated":"2018-03-27 18:59:04.000000000","message":"This needs to be re-proposed for Rocky (and move the spec to the rocky directory structure in nova-specs).","commit_id":"89ea1fcf2bea99c17e6733187ec1d1c1dfbd581a"}],"specs/rocky/approved/servers-ips-non-unique-network-names.rst":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d329db8576fcab6f07af0117172e93bbd35794ec","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                  \"OS-EXT-IPS-MAC:mac_addr\":\"fa:16:3e:65:83:12\","},{"line_number":144,"context_line":"                  \"version\":4,"},{"line_number":145,"context_line":"                  \"addr\":\"192.168.0.12\","},{"line_number":146,"context_line":"                  \"OS-EXT-IPS:type\":\"fixed\""},{"line_number":147,"context_line":"               }"},{"line_number":148,"context_line":"            ]"},{"line_number":149,"context_line":"         }"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf659307_a8d54e45","line":146,"updated":"2018-03-27 19:23:28.000000000","message":"This is more change than we really need to just scope things down. It makes more work for anyone that has an existing client that just needs to plow through another layer of uuid scoping. But, I guess it\u0027s not a huge deal.","commit_id":"253e0acafe7024e1869745b98e270f30cbc32d48"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"328177fa29311cc9a2ae208fed61c8008f4effb8","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                  \"OS-EXT-IPS-MAC:mac_addr\":\"fa:16:3e:65:83:12\","},{"line_number":144,"context_line":"                  \"version\":4,"},{"line_number":145,"context_line":"                  \"addr\":\"192.168.0.12\","},{"line_number":146,"context_line":"                  \"OS-EXT-IPS:type\":\"fixed\""},{"line_number":147,"context_line":"               }"},{"line_number":148,"context_line":"            ]"},{"line_number":149,"context_line":"         }"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf659307_f09ec452","line":146,"in_reply_to":"bf659307_50d45020","updated":"2018-03-28 00:34:53.000000000","message":"See the note here:\n\nhttps://github.com/openstack/nova/blob/3f08521d33c60e4bfe04bc236bb8761f654004df/nova/api/openstack/compute/ips.py#L28\n\nSame idea.","commit_id":"253e0acafe7024e1869745b98e270f30cbc32d48"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8268c28f7196ceff44a306798345c27aeda78d76","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                  \"OS-EXT-IPS-MAC:mac_addr\":\"fa:16:3e:65:83:12\","},{"line_number":144,"context_line":"                  \"version\":4,"},{"line_number":145,"context_line":"                  \"addr\":\"192.168.0.12\","},{"line_number":146,"context_line":"                  \"OS-EXT-IPS:type\":\"fixed\""},{"line_number":147,"context_line":"               }"},{"line_number":148,"context_line":"            ]"},{"line_number":149,"context_line":"         }"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf659307_50d45020","line":146,"in_reply_to":"bf659307_a8d54e45","updated":"2018-03-28 00:30:48.000000000","message":"I didn\u0027t even realize the new fields added to the response payload here...that should be called out specifically, and we should drop the OS-EXT-IPS prefix stuff in the new microversion if we\u0027re going to add this.\n\nI guess the point of adding the mac and type is to match what\u0027s in the GET /servers/detail response? And if we renamed the keys, then we\u0027d likely need to think about renaming the keys in that response as well, which I\u0027d be OK with if we\u0027re doing this.\n\nAnd now that you mention this, if we\u0027re going to fix GET /servers/{server_id}/ips we should probably also fix GET /servers/detail right?\n\nhttps://github.com/openstack/nova/blob/3f08521d33c60e4bfe04bc236bb8761f654004df/nova/api/openstack/compute/views/addresses.py#L27\n\nOtherwise you have the same problem there.\n\nSo can you please update the spec to mention that both APIs need to be fixed for this, along with changing the mac_addr and type keys in the response in the new microversion to drop the OS-EXT-IPS prefix.","commit_id":"253e0acafe7024e1869745b98e270f30cbc32d48"}]}