)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"94ef760155827fd2b350092f9d7fa4887b237b3a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-01-08 19:45:17 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Back up volume-backed-instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id4da210c4d1de9cb7051231d833ef6d296b7c721"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa0c359_21d56144","line":8,"updated":"2018-02-12 19:40:49.000000000","message":"Per the spec template, you should have the APIImpact tag in here.\n\nAlso link to the blueprint, e.g.:\n\nSpec for blueprint volume-backed-instance-support-backup","commit_id":"747e333ff7260c0d7d5a490f4d69fca5f8bb6e8b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae900645f934940ee7c38a3b86c4fbd05a2125ba","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-03-29 10:59:58 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Back up volume-backed-instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id4da210c4d1de9cb7051231d833ef6d296b7c721"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3f79a3b5_473c80bf","line":8,"updated":"2018-10-23 16:11:31.000000000","message":"As mentioned in PS5, this should have the APIImpact tag.","commit_id":"149f7f4a157f4ee997f33577c15aecc30f64c55c"}],"specs/queens/approved/volume-backed-instance-support-backup.rst":[{"author":{"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},"change_message_id":"9b66a11656d33c9ea6b9ba494a795914dab81d10","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"#Create snapshot: In the current code, when the instance is volume-backed, it"},{"line_number":51,"context_line":"will raise BadRequest directly. And if the instance is booted from a image , it"},{"line_number":52,"context_line":"will  create image of  the instance. So what should do is just same thing as"},{"line_number":53,"context_line":"create backup of the image-backed instance, to create a image of the volume-"},{"line_number":54,"context_line":"backed instance. And before changing it,the raise exception code should be"},{"line_number":55,"context_line":"delete."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f91af0f_84566d06","line":52,"range":{"start_line":52,"start_character":22,"end_line":52,"end_character":23},"updated":"2018-01-01 08:08:15.000000000","message":"nit: space","commit_id":"25572eca5cdfdd8a500648ef8ea817e7e29a021b"},{"author":{"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},"change_message_id":"9b66a11656d33c9ea6b9ba494a795914dab81d10","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"#Create snapshot: In the current code, when the instance is volume-backed, it"},{"line_number":51,"context_line":"will raise BadRequest directly. And if the instance is booted from a image , it"},{"line_number":52,"context_line":"will  create image of  the instance. So what should do is just same thing as"},{"line_number":53,"context_line":"create backup of the image-backed instance, to create a image of the volume-"},{"line_number":54,"context_line":"backed instance. And before changing it,the raise exception code should be"},{"line_number":55,"context_line":"delete."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f91af0f_e4517910","line":52,"range":{"start_line":52,"start_character":5,"end_line":52,"end_character":6},"updated":"2018-01-01 08:08:15.000000000","message":"nit: space","commit_id":"25572eca5cdfdd8a500648ef8ea817e7e29a021b"},{"author":{"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},"change_message_id":"9b66a11656d33c9ea6b9ba494a795914dab81d10","unresolved":false,"context_lines":[{"line_number":54,"context_line":"backed instance. And before changing it,the raise exception code should be"},{"line_number":55,"context_line":"delete."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"#Rotation: To keep specified number backups, roation is to delete the excess"},{"line_number":58,"context_line":"number backups. For image-backed instance it\u0027s just  needed to  delete the"},{"line_number":59,"context_line":"excess number images, but for volume-backed instance it is also be nessary to"},{"line_number":60,"context_line":"delete the excess snapshot."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f91af0f_44406536","line":57,"range":{"start_line":57,"start_character":45,"end_line":57,"end_character":52},"updated":"2018-01-01 08:08:15.000000000","message":"typo:  roation --\u003e  rotation","commit_id":"25572eca5cdfdd8a500648ef8ea817e7e29a021b"}],"specs/rocky/approved/volume-backed-instance-support-backup.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db8bdc03cc365d305934ff730446e543cf6f5778","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Nova backup is only support instances which are booted from images. The volume-"},{"line_number":18,"context_line":"backed instance cannot be backup.Trying to create a volume-backed instance\u0027s"},{"line_number":19,"context_line":"backup will raise a invalidrequest exception.The following are examples for"},{"line_number":20,"context_line":"create backup of image_backed instance and volume-backed instance:"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa0c359_3f31f8a3","line":18,"range":{"start_line":18,"start_character":33,"end_line":18,"end_character":34},"updated":"2018-02-12 21:30:20.000000000","message":"Need a space between sentences here and throughout the doc.","commit_id":"747e333ff7260c0d7d5a490f4d69fca5f8bb6e8b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db8bdc03cc365d305934ff730446e543cf6f5778","unresolved":false,"context_lines":[{"line_number":20,"context_line":"create backup of image_backed instance and volume-backed instance:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#create backup of image-backed instance"},{"line_number":23,"context_line":"Throw command \" nova backup boot-from-image-1 backup-1 daily 2\", a backup named"},{"line_number":24,"context_line":"\"backup-1\" was created.The instance was boot from image .There will be no"},{"line_number":25,"context_line":"output.But throw commond \"openstack image list\", we will see \"backup-1\" just"},{"line_number":26,"context_line":"like thefollowing format:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa0c359_7f1a2017","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":5},"updated":"2018-02-12 21:30:20.000000000","message":"s/Throw/Issue/","commit_id":"747e333ff7260c0d7d5a490f4d69fca5f8bb6e8b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db8bdc03cc365d305934ff730446e543cf6f5778","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Use Cases"},{"line_number":43,"context_line":"---------"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Creating backups of volume-backed instances."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Proposed change"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa0c359_7fef80e8","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":44},"updated":"2018-02-12 21:30:20.000000000","message":"This isn\u0027t really a use case. A use case would be something more like, \"As a user, I want to be able to schedule backups with a rotation for my volume-backed instances.\"","commit_id":"747e333ff7260c0d7d5a490f4d69fca5f8bb6e8b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db8bdc03cc365d305934ff730446e543cf6f5778","unresolved":false,"context_lines":[{"line_number":51,"context_line":"will raise BadRequest directly. And if the instance is booted from a image , it"},{"line_number":52,"context_line":"will create image of the instance. So what should do is just same thing as"},{"line_number":53,"context_line":"create backup of the image-backed instance, to create a image of the volume-"},{"line_number":54,"context_line":"backed instance. And before changing it,the raise exception code should be"},{"line_number":55,"context_line":"delete."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"#Rotation: To keep specified number backups, rotation is to delete the excess"},{"line_number":58,"context_line":"number backups. For image-backed instance it\u0027s just  needed to  delete the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa0c359_dfcd7485","line":55,"range":{"start_line":54,"start_character":17,"end_line":55,"end_character":7},"updated":"2018-02-12 21:30:20.000000000","message":"This is an API behavior change, so we would need to add a new microversion and if the request is made with \u003e\u003d the new microversion, a volume-backed instance backup could be attempted, otherwise we still fail as before.","commit_id":"747e333ff7260c0d7d5a490f4d69fca5f8bb6e8b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db8bdc03cc365d305934ff730446e543cf6f5778","unresolved":false,"context_lines":[{"line_number":57,"context_line":"#Rotation: To keep specified number backups, rotation is to delete the excess"},{"line_number":58,"context_line":"number backups. For image-backed instance it\u0027s just  needed to  delete the"},{"line_number":59,"context_line":"excess number images, but for volume-backed instance it is also be nessary to"},{"line_number":60,"context_line":"delete the excess snapshot."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa0c359_bf974848","line":60,"updated":"2018-02-12 21:30:20.000000000","message":"So nova will call https://developer.openstack.org/api-ref/block-storage/v3/#delete-a-snapshot ?\n\nWe could hit issues if the snapshot was created by someone else, e.g. if an admin user backs up a volume-backed instance and then the user (regular owner of the instance) tries to backup again, hits the rotation threshold, and Cinder fails because the snapshot the user is trying to delete is not owned by that user (it\u0027s owned by the admin that created the snapshot). We\u0027d need to be clear about ownership of the volume snapshot that gets created so the instance owner can also delete the snapshot.","commit_id":"747e333ff7260c0d7d5a490f4d69fca5f8bb6e8b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db8bdc03cc365d305934ff730446e543cf6f5778","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Use cinder API \"Create a backup\" to create a backup of volume. But this method"},{"line_number":66,"context_line":"is just a operation of volume rather than a instance. And rotation is also a"},{"line_number":67,"context_line":"question that should be considered."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa0c359_5f95e431","line":65,"updated":"2018-02-12 21:30:20.000000000","message":"Hmm, yeah:\n\nhttps://developer.openstack.org/api-ref/block-storage/v3/#create-a-backup\n\nWhy wouldn\u0027t we use that rather than create a snapshot of the volume? Isn\u0027t that what the cinder backup API is for?","commit_id":"747e333ff7260c0d7d5a490f4d69fca5f8bb6e8b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9faed86e524c7ad2ffc3fddc692ef8da06abf31e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Use cinder API \"Create a backup\" to create a backup of volume. But this method"},{"line_number":66,"context_line":"is just a operation of volume rather than a instance. And rotation is also a"},{"line_number":67,"context_line":"question that should be considered."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa0c359_9a161a49","line":65,"in_reply_to":"3fa0c359_5f95e431","updated":"2018-02-12 21:48:20.000000000","message":"The Cinder API could also be used to just create a snapshot, then volumes can be created from that snapshot for other purposes. But a snapshot is not an actual backup or data protection of a volume, so yeah, cinder backup might be what is needed for the desired outcome here.","commit_id":"747e333ff7260c0d7d5a490f4d69fca5f8bb6e8b"},{"author":{"_account_id":27487,"name":"Jianle He","email":"961264049@qq.com","username":"hejianle"},"change_message_id":"24461cad842acc9f8e4dd5efe22dd699f5432db1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Use cinder API \"Create a backup\" to create a backup of volume. But this method"},{"line_number":66,"context_line":"is just a operation of volume rather than a instance. And rotation is also a"},{"line_number":67,"context_line":"question that should be considered."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa0c359_193d18c3","line":65,"in_reply_to":"3fa0c359_9a161a49","updated":"2018-03-01 09:30:50.000000000","message":"Yeah，I will think about it.","commit_id":"747e333ff7260c0d7d5a490f4d69fca5f8bb6e8b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db8bdc03cc365d305934ff730446e543cf6f5778","unresolved":false,"context_lines":[{"line_number":63,"context_line":"------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Use cinder API \"Create a backup\" to create a backup of volume. But this method"},{"line_number":66,"context_line":"is just a operation of volume rather than a instance. And rotation is also a"},{"line_number":67,"context_line":"question that should be considered."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Data model impact"},{"line_number":70,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa0c359_bfa508a4","line":67,"range":{"start_line":66,"start_character":54,"end_line":67,"end_character":35},"updated":"2018-02-12 21:30:20.000000000","message":"If nova used cinder\u0027s backup API, then for rotating, wouldn\u0027t nova just delete the backup?\n\nhttps://developer.openstack.org/api-ref/block-storage/v3/#delete-a-backup\n\nI don\u0027t really know what the difference is between volume snapshots and volume backups.","commit_id":"747e333ff7260c0d7d5a490f4d69fca5f8bb6e8b"},{"author":{"_account_id":27487,"name":"Jianle He","email":"961264049@qq.com","username":"hejianle"},"change_message_id":"24461cad842acc9f8e4dd5efe22dd699f5432db1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Use cinder API \"Create a backup\" to create a backup of volume. But this method"},{"line_number":66,"context_line":"is just a operation of volume rather than a instance. And rotation is also a"},{"line_number":67,"context_line":"question that should be considered."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Data model impact"},{"line_number":70,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa0c359_d93250f2","line":67,"range":{"start_line":66,"start_character":54,"end_line":67,"end_character":35},"in_reply_to":"3fa0c359_bfa508a4","updated":"2018-03-01 09:30:50.000000000","message":"It\u0027s really important question should be considered.","commit_id":"747e333ff7260c0d7d5a490f4d69fca5f8bb6e8b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db8bdc03cc365d305934ff730446e543cf6f5778","unresolved":false,"context_lines":[{"line_number":74,"context_line":"REST API impact"},{"line_number":75,"context_line":"---------------"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Security impact"},{"line_number":80,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa0c359_5fbe44b4","line":77,"updated":"2018-02-12 21:30:20.000000000","message":"There would need to be a new microversion to indicate the ability to create backups for volume-backed instances.","commit_id":"747e333ff7260c0d7d5a490f4d69fca5f8bb6e8b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db8bdc03cc365d305934ff730446e543cf6f5778","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Security impact"},{"line_number":80,"context_line":"---------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"None"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Notifications impact"},{"line_number":85,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa0c359_1fb43cd0","line":82,"updated":"2018-02-12 21:30:20.000000000","message":"We might need to consider a new policy rule for volume-backed instance snapshot. It would default to admin_or_owner.","commit_id":"747e333ff7260c0d7d5a490f4d69fca5f8bb6e8b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db8bdc03cc365d305934ff730446e543cf6f5778","unresolved":false,"context_lines":[{"line_number":126,"context_line":"Work Items"},{"line_number":127,"context_line":"----------"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"None"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Dependencies"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa0c359_bfce6860","line":129,"updated":"2018-02-12 21:30:20.000000000","message":"There are no work items for this?","commit_id":"747e333ff7260c0d7d5a490f4d69fca5f8bb6e8b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db8bdc03cc365d305934ff730446e543cf6f5778","unresolved":false,"context_lines":[{"line_number":137,"context_line":"Testing"},{"line_number":138,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"New unit tests will be added to cover the new scenarios."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Documentation Impact"},{"line_number":143,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa0c359_dfc9f458","line":140,"updated":"2018-02-12 21:30:20.000000000","message":"Given this requires cross-project interaction with Cinder, I think we also need a Tempest test for this.","commit_id":"747e333ff7260c0d7d5a490f4d69fca5f8bb6e8b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db8bdc03cc365d305934ff730446e543cf6f5778","unresolved":false,"context_lines":[{"line_number":142,"context_line":"Documentation Impact"},{"line_number":143,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"None"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"References"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa0c359_7fc46040","line":145,"updated":"2018-02-12 21:30:20.000000000","message":"Clearly we would need to update the API reference for the createBackup action:\n\nhttps://developer.openstack.org/api-ref/compute/#create-server-back-up-createbackup-action","commit_id":"747e333ff7260c0d7d5a490f4d69fca5f8bb6e8b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db8bdc03cc365d305934ff730446e543cf6f5778","unresolved":false,"context_lines":[{"line_number":147,"context_line":"References"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":".. [1]https://review.openstack.org/#/c/529458/"},{"line_number":151,"context_line":".. [2]https://bugs.launchpad.net/nova/+bug/1739542"},{"line_number":152,"context_line":".. [3]https://blueprints.launchpad.net/nova/+spec/volume-backed-instance-"},{"line_number":153,"context_line":"      support-backup"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa0c359_9fbfeca8","line":150,"range":{"start_line":150,"start_character":0,"end_line":150,"end_character":2},"updated":"2018-02-12 21:30:20.000000000","message":"These don\u0027t need to be footnotes, nothing is referencing them.","commit_id":"747e333ff7260c0d7d5a490f4d69fca5f8bb6e8b"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"0867e7c05459952a886127cd4bc78846265338db","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Nova backup is only support instances which are booted from images. The volume-"},{"line_number":18,"context_line":"backed instance cannot be backup. Trying to create a volume-backed instance\u0027s"},{"line_number":19,"context_line":"backup will raise a invalid request exception. The following are examples for"},{"line_number":20,"context_line":"create backup of image_backed instance and volume-backed instance:"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"df7087c5_9529258b","line":18,"range":{"start_line":18,"start_character":26,"end_line":18,"end_character":32},"updated":"2018-03-14 17:10:52.000000000","message":"nit: \"backed up\"","commit_id":"b429dbaa3c155b313dacbd35f7634996ffc58c6c"},{"author":{"_account_id":27487,"name":"Jianle He","email":"961264049@qq.com","username":"hejianle"},"change_message_id":"ea708e3c73f1b190a24edd191989331653dd8b31","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Nova backup is only support instances which are booted from images. The volume-"},{"line_number":18,"context_line":"backed instance cannot be backup. Trying to create a volume-backed instance\u0027s"},{"line_number":19,"context_line":"backup will raise a invalid request exception. The following are examples for"},{"line_number":20,"context_line":"create backup of image_backed instance and volume-backed instance:"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf659307_363f54d7","line":18,"range":{"start_line":18,"start_character":26,"end_line":18,"end_character":32},"in_reply_to":"df7087c5_9529258b","updated":"2018-03-29 02:18:06.000000000","message":"Yeah, I will change it.","commit_id":"b429dbaa3c155b313dacbd35f7634996ffc58c6c"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"0867e7c05459952a886127cd4bc78846265338db","unresolved":false,"context_lines":[{"line_number":31,"context_line":"+--------------------------------------+----------+--------+"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"#create backup of volume-backed instance"},{"line_number":34,"context_line":"When a backup tried to be created for a instance boot from volume a BadRequest"},{"line_number":35,"context_line":"exception was raised with a status code 400. The following is the output:"},{"line_number":36,"context_line":"ERROR (BadRequest): The request is invalid. (HTTP 400) (Request-ID:"},{"line_number":37,"context_line":"req-6e2023a4-055f-4788-89d3-8b302a34c924)"}],"source_content_type":"text/x-rst","patch_set":9,"id":"df7087c5_954e056d","line":34,"range":{"start_line":34,"start_character":5,"end_line":34,"end_character":53},"updated":"2018-03-14 17:10:52.000000000","message":"grammar nit, should be \"When we tried to create a backup for an instance booted from volume...\"","commit_id":"b429dbaa3c155b313dacbd35f7634996ffc58c6c"},{"author":{"_account_id":27487,"name":"Jianle He","email":"961264049@qq.com","username":"hejianle"},"change_message_id":"ea708e3c73f1b190a24edd191989331653dd8b31","unresolved":false,"context_lines":[{"line_number":31,"context_line":"+--------------------------------------+----------+--------+"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"#create backup of volume-backed instance"},{"line_number":34,"context_line":"When a backup tried to be created for a instance boot from volume a BadRequest"},{"line_number":35,"context_line":"exception was raised with a status code 400. The following is the output:"},{"line_number":36,"context_line":"ERROR (BadRequest): The request is invalid. (HTTP 400) (Request-ID:"},{"line_number":37,"context_line":"req-6e2023a4-055f-4788-89d3-8b302a34c924)"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf659307_f19ec652","line":34,"range":{"start_line":34,"start_character":5,"end_line":34,"end_character":53},"in_reply_to":"df7087c5_954e056d","updated":"2018-03-29 02:18:06.000000000","message":"Yeah, I will change it.","commit_id":"b429dbaa3c155b313dacbd35f7634996ffc58c6c"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"0867e7c05459952a886127cd4bc78846265338db","unresolved":false,"context_lines":[{"line_number":36,"context_line":"ERROR (BadRequest): The request is invalid. (HTTP 400) (Request-ID:"},{"line_number":37,"context_line":"req-6e2023a4-055f-4788-89d3-8b302a34c924)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"In this spec, we will fix it, so that it canbe worked to create backups of"},{"line_number":40,"context_line":"instance."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Use Cases"},{"line_number":43,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"df7087c5_55f06dfd","line":40,"range":{"start_line":39,"start_character":41,"end_line":40,"end_character":9},"updated":"2018-03-14 17:10:52.000000000","message":"grammar nit, should be \"will be possible to create backups of boot-from-volume instances\"","commit_id":"b429dbaa3c155b313dacbd35f7634996ffc58c6c"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"0867e7c05459952a886127cd4bc78846265338db","unresolved":false,"context_lines":[{"line_number":52,"context_line":"will raise BadRequest directly. And if the instance is booted from a image, it"},{"line_number":53,"context_line":"will create image of the instance. So what should do is just same thing as"},{"line_number":54,"context_line":"create backup of the image-backed instance, to create a image of the volume-"},{"line_number":55,"context_line":"backed instance,it will return a 0 size image and backups of the volumes"},{"line_number":56,"context_line":"attached to the instances."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"#Rotation: To keep specified number backups, rotation is to delete the excess"}],"source_content_type":"text/x-rst","patch_set":9,"id":"df7087c5_755c91ec","line":55,"range":{"start_line":55,"start_character":50,"end_line":55,"end_character":72},"updated":"2018-03-14 17:10:52.000000000","message":"what API do you plan to use when backing up the cinder volumes?  will this depend on having the cinder-backup service running?  Will the volume backups be stored in cinder?","commit_id":"b429dbaa3c155b313dacbd35f7634996ffc58c6c"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"0867e7c05459952a886127cd4bc78846265338db","unresolved":false,"context_lines":[{"line_number":52,"context_line":"will raise BadRequest directly. And if the instance is booted from a image, it"},{"line_number":53,"context_line":"will create image of the instance. So what should do is just same thing as"},{"line_number":54,"context_line":"create backup of the image-backed instance, to create a image of the volume-"},{"line_number":55,"context_line":"backed instance,it will return a 0 size image and backups of the volumes"},{"line_number":56,"context_line":"attached to the instances."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"#Rotation: To keep specified number backups, rotation is to delete the excess"}],"source_content_type":"text/x-rst","patch_set":9,"id":"df7087c5_75ced1b4","line":55,"range":{"start_line":55,"start_character":31,"end_line":55,"end_character":45},"updated":"2018-03-14 17:10:52.000000000","message":"why do we need to return an image at all?","commit_id":"b429dbaa3c155b313dacbd35f7634996ffc58c6c"},{"author":{"_account_id":27487,"name":"Jianle He","email":"961264049@qq.com","username":"hejianle"},"change_message_id":"ea708e3c73f1b190a24edd191989331653dd8b31","unresolved":false,"context_lines":[{"line_number":52,"context_line":"will raise BadRequest directly. And if the instance is booted from a image, it"},{"line_number":53,"context_line":"will create image of the instance. So what should do is just same thing as"},{"line_number":54,"context_line":"create backup of the image-backed instance, to create a image of the volume-"},{"line_number":55,"context_line":"backed instance,it will return a 0 size image and backups of the volumes"},{"line_number":56,"context_line":"attached to the instances."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"#Rotation: To keep specified number backups, rotation is to delete the excess"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf659307_31a99ede","line":55,"range":{"start_line":55,"start_character":50,"end_line":55,"end_character":72},"in_reply_to":"df7087c5_755c91ec","updated":"2018-03-29 02:18:06.000000000","message":"At the begining, I want to use snapshot API to do this. But someone advise that cinder backup more suitable.","commit_id":"b429dbaa3c155b313dacbd35f7634996ffc58c6c"},{"author":{"_account_id":27487,"name":"Jianle He","email":"961264049@qq.com","username":"hejianle"},"change_message_id":"ea708e3c73f1b190a24edd191989331653dd8b31","unresolved":false,"context_lines":[{"line_number":52,"context_line":"will raise BadRequest directly. And if the instance is booted from a image, it"},{"line_number":53,"context_line":"will create image of the instance. So what should do is just same thing as"},{"line_number":54,"context_line":"create backup of the image-backed instance, to create a image of the volume-"},{"line_number":55,"context_line":"backed instance,it will return a 0 size image and backups of the volumes"},{"line_number":56,"context_line":"attached to the instances."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"#Rotation: To keep specified number backups, rotation is to delete the excess"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf659307_11ac9a9e","line":55,"range":{"start_line":55,"start_character":31,"end_line":55,"end_character":45},"in_reply_to":"df7087c5_75ced1b4","updated":"2018-03-29 02:18:06.000000000","message":"Beacause I notice that creating image of volume-baked servers return a 0 size image. And this image is related to\nthe volume\u0027s snapshots. And It\u0027s easy to rebuild or create a  vm with that image. I plan to do the same thing that return a image. We can use nova boot/rebuild to restore the backups of a volume-baked servers with that image.","commit_id":"b429dbaa3c155b313dacbd35f7634996ffc58c6c"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"0867e7c05459952a886127cd4bc78846265338db","unresolved":false,"context_lines":[{"line_number":58,"context_line":"#Rotation: To keep specified number backups, rotation is to delete the excess"},{"line_number":59,"context_line":"number backups. For image-backed instance it\u0027s just needed to  delete the"},{"line_number":60,"context_line":"excess number images, but for volume-backed instance it is also be nessary to"},{"line_number":61,"context_line":"delete the excess backups."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Alternatives"},{"line_number":64,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"df7087c5_d551ddda","line":61,"range":{"start_line":61,"start_character":18,"end_line":61,"end_character":25},"updated":"2018-03-14 17:10:52.000000000","message":"should be \"volume backups\" I think.","commit_id":"b429dbaa3c155b313dacbd35f7634996ffc58c6c"},{"author":{"_account_id":27487,"name":"Jianle He","email":"961264049@qq.com","username":"hejianle"},"change_message_id":"ea708e3c73f1b190a24edd191989331653dd8b31","unresolved":false,"context_lines":[{"line_number":58,"context_line":"#Rotation: To keep specified number backups, rotation is to delete the excess"},{"line_number":59,"context_line":"number backups. For image-backed instance it\u0027s just needed to  delete the"},{"line_number":60,"context_line":"excess number images, but for volume-backed instance it is also be nessary to"},{"line_number":61,"context_line":"delete the excess backups."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Alternatives"},{"line_number":64,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf659307_5115329b","line":61,"range":{"start_line":61,"start_character":18,"end_line":61,"end_character":25},"in_reply_to":"df7087c5_d551ddda","updated":"2018-03-29 02:18:06.000000000","message":"Yeah, I will change it.","commit_id":"b429dbaa3c155b313dacbd35f7634996ffc58c6c"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"0867e7c05459952a886127cd4bc78846265338db","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Use cinder API \"Create a backup\" to create a backup of volume. But this method"},{"line_number":67,"context_line":"is just a operation of volume rather than a instance. But rotation is a"},{"line_number":68,"context_line":"question that should be considered. It\u0027s can backup a volume with cinder backup"},{"line_number":69,"context_line":"API but cannot do the rotating operation."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"df7087c5_952fe53d","line":68,"range":{"start_line":68,"start_character":36,"end_line":68,"end_character":40},"updated":"2018-03-14 17:10:52.000000000","message":"just \"It\" I think.","commit_id":"b429dbaa3c155b313dacbd35f7634996ffc58c6c"},{"author":{"_account_id":27594,"name":"Jie Li","email":"lijie@unitedstack.com","username":"ramboman"},"change_message_id":"98cdb07e19e18d42c0dd53d4ebbe38c13691dfdb","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"None"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"REST API impact"},{"line_number":77,"context_line":"---------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"The propose change will impact the response of the createBackup"}],"source_content_type":"text/x-rst","patch_set":9,"id":"df7087c5_5a021f0d","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":15},"updated":"2018-03-22 03:51:37.000000000","message":"Should notice this will need to raise the microversion\nand RPC API version.","commit_id":"b429dbaa3c155b313dacbd35f7634996ffc58c6c"},{"author":{"_account_id":27594,"name":"Jie Li","email":"lijie@unitedstack.com","username":"ramboman"},"change_message_id":"3e10a7f1e0e4493726a035e605ec7a244dd77435","unresolved":false,"context_lines":[{"line_number":76,"context_line":"REST API impact"},{"line_number":77,"context_line":"---------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"The propose change will impact the response of the createBackup"},{"line_number":80,"context_line":"API when the instance is volume-backed. It will not raise a BadRequest with a"},{"line_number":81,"context_line":"http status code 400, instead the same response as backup for image-backed"},{"line_number":82,"context_line":"instances will be returned. For examples:"}],"source_content_type":"text/x-rst","patch_set":9,"id":"df7087c5_a53b1cc6","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":3},"updated":"2018-03-22 03:59:46.000000000","message":"This is more information about microversion.\nhttps://docs.openstack.org/nova/latest/contributor/microversions.html#f1","commit_id":"b429dbaa3c155b313dacbd35f7634996ffc58c6c"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"c48ffbdb5af072e97c52f86d67862280b0673854","unresolved":false,"context_lines":[{"line_number":52,"context_line":"will raise BadRequest directly. And if the instance is booted from a image, it"},{"line_number":53,"context_line":"will create image of the instance. So what should do is just same thing as"},{"line_number":54,"context_line":"create backup of the image-backed instance, to create a image of the volume-"},{"line_number":55,"context_line":"backed instance,it will return a 0 size image and backups of the volumes"},{"line_number":56,"context_line":"attached to the instances."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"#Rotation: To keep specified number backups, rotation is to delete the excess"}],"source_content_type":"text/x-rst","patch_set":10,"id":"bf659307_cea8aedc","line":55,"range":{"start_line":55,"start_character":16,"end_line":55,"end_character":72},"updated":"2018-03-28 15:41:38.000000000","message":"My earlier questions here haven\u0027t been answered yet.","commit_id":"9b92f6af32b3103e0318da58735320c3e003be6c"},{"author":{"_account_id":27487,"name":"Jianle He","email":"961264049@qq.com","username":"hejianle"},"change_message_id":"ea708e3c73f1b190a24edd191989331653dd8b31","unresolved":false,"context_lines":[{"line_number":52,"context_line":"will raise BadRequest directly. And if the instance is booted from a image, it"},{"line_number":53,"context_line":"will create image of the instance. So what should do is just same thing as"},{"line_number":54,"context_line":"create backup of the image-backed instance, to create a image of the volume-"},{"line_number":55,"context_line":"backed instance,it will return a 0 size image and backups of the volumes"},{"line_number":56,"context_line":"attached to the instances."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"#Rotation: To keep specified number backups, rotation is to delete the excess"}],"source_content_type":"text/x-rst","patch_set":10,"id":"bf659307_b2590d8f","line":55,"range":{"start_line":55,"start_character":16,"end_line":55,"end_character":72},"in_reply_to":"bf659307_cea8aedc","updated":"2018-03-29 02:18:06.000000000","message":"Firstly, a vm may have more than one volumes, if we back up this vm, it\u0027ll return a few volume backups or snapshots, I think we should use an image to  represent them. \nSecondly, if we have a image which represents the backups we can easily to use nova boot/rebuid API to restore a vm that have same number volumes as the source vm have.\nThirdly, to keep nova backup API to have same response result with the image-baked vm.","commit_id":"9b92f6af32b3103e0318da58735320c3e003be6c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae900645f934940ee7c38a3b86c4fbd05a2125ba","unresolved":false,"context_lines":[{"line_number":51,"context_line":"#Create backup: In the current code, when the instance is volume-backed, it"},{"line_number":52,"context_line":"will raise BadRequest directly. And if the instance is booted from a image, it"},{"line_number":53,"context_line":"will create image of the instance. So what should do is just same thing as"},{"line_number":54,"context_line":"create backup of the image-backed instance, to create a image of the volume-"},{"line_number":55,"context_line":"backed instance,it will return a 0 size image and backups of the volumes"},{"line_number":56,"context_line":"attached to the instances."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_27db847a","line":54,"range":{"start_line":54,"start_character":47,"end_line":54,"end_character":61},"updated":"2018-10-23 16:11:31.000000000","message":"So is the proposal to create a volume snapshot or a volume backup? It seems that would be what the server createBackup API would logically do, leverage the volume backup API.\n\nIf the createBackup API is meant to just be the same as the createImage API for volume-backed instances except for the rotation, then that should probably be mentioned explicitly, but I\u0027m not sure it would logically be what users would expect for backups of volumes.","commit_id":"149f7f4a157f4ee997f33577c15aecc30f64c55c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae900645f934940ee7c38a3b86c4fbd05a2125ba","unresolved":false,"context_lines":[{"line_number":52,"context_line":"will raise BadRequest directly. And if the instance is booted from a image, it"},{"line_number":53,"context_line":"will create image of the instance. So what should do is just same thing as"},{"line_number":54,"context_line":"create backup of the image-backed instance, to create a image of the volume-"},{"line_number":55,"context_line":"backed instance,it will return a 0 size image and backups of the volumes"},{"line_number":56,"context_line":"attached to the instances."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"#Rotation: To keep specified number backups, rotation is to delete the excess"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_67909c97","line":55,"range":{"start_line":55,"start_character":33,"end_line":55,"end_character":45},"updated":"2018-10-23 16:11:31.000000000","message":"I guess the 0-size image is based on how createImage works today with a volume-backed server:\n\nhttps://github.com/openstack/nova/blob/297de7fb9fbabe74b5305ef0aa82e196d5f48d5e/nova/compute/api.py#L2968","commit_id":"149f7f4a157f4ee997f33577c15aecc30f64c55c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae900645f934940ee7c38a3b86c4fbd05a2125ba","unresolved":false,"context_lines":[{"line_number":52,"context_line":"will raise BadRequest directly. And if the instance is booted from a image, it"},{"line_number":53,"context_line":"will create image of the instance. So what should do is just same thing as"},{"line_number":54,"context_line":"create backup of the image-backed instance, to create a image of the volume-"},{"line_number":55,"context_line":"backed instance,it will return a 0 size image and backups of the volumes"},{"line_number":56,"context_line":"attached to the instances."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"#Rotation: To keep specified number backups, rotation is to delete the excess"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_6762dcdb","line":55,"range":{"start_line":55,"start_character":15,"end_line":55,"end_character":16},"updated":"2018-10-23 16:11:31.000000000","message":"need a space","commit_id":"149f7f4a157f4ee997f33577c15aecc30f64c55c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b72d1248234032da6b0b7a25f04524acca01c53a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"will create image of the instance. So what should do is just same thing as"},{"line_number":54,"context_line":"create backup of the image-backed instance, to create a image of the volume-"},{"line_number":55,"context_line":"backed instance,it will return a 0 size image and backups of the volumes"},{"line_number":56,"context_line":"attached to the instances."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"#Rotation: To keep specified number backups, rotation is to delete the excess"},{"line_number":59,"context_line":"number backups. For image-backed instance it\u0027s just needed to  delete the"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_aa051b11","line":56,"updated":"2018-10-23 16:18:23.000000000","message":"Another thing with this is the createImage API for a volume-backed server will record the volume snapshot metadata in the image \"block_device_mapping\" property, so that the image snapshot can be used to create a new instance from that image snapshot but that will actually result in a new volume-backed server based on the volume snapshots.\n\nHow would that work with createBackup and the image-defined BDMs? Would the source_type be \u0027snapshot\u0027 in the BDM or \u0027backup\u0027 because the latter is not something the API or compute service understands today (the compute service would have to understand that source_type\u003d\u0027backup\u0027 means creating a new volume from the backup using the restore API:\n\nhttps://developer.openstack.org/api-ref/block-storage/v3/?expanded\u003drestore-a-backup-detail#restore-a-backup).","commit_id":"149f7f4a157f4ee997f33577c15aecc30f64c55c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae900645f934940ee7c38a3b86c4fbd05a2125ba","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Use cinder API \"Create a backup\" to create a backup of volume. But this method"},{"line_number":67,"context_line":"is just a operation of volume rather than a instance. But rotation is a"},{"line_number":68,"context_line":"question that should be considered. It can back up a volume with cinder backup"},{"line_number":69,"context_line":"API but cannot do the rotating operation."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Data model impact"},{"line_number":72,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_676c1c9d","line":69,"range":{"start_line":68,"start_character":35,"end_line":69,"end_character":41},"updated":"2018-10-23 16:11:31.000000000","message":"Well, nova doesn\u0027t need to be used for this either, right? Certainly an external service/script could do this as well. There is nothing really special about the createBackup API in nova, and we\u0027ve discussed deprecating it before:\n\nhttps://review.openstack.org/#/c/511825/\n\nAll it does is orchestrate the rotation but that could be done by anything else since the backup rotation is just stored as image metadata and then a cron is used to rotate the backups. The same could be done with volume-backed instances.","commit_id":"149f7f4a157f4ee997f33577c15aecc30f64c55c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"13e200447b644146be5f9dbe2a73a8f5082837de","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Use cinder API \"Create a backup\" to create a backup of volume. But this method"},{"line_number":67,"context_line":"is just a operation of volume rather than a instance. But rotation is a"},{"line_number":68,"context_line":"question that should be considered. It can back up a volume with cinder backup"},{"line_number":69,"context_line":"API but cannot do the rotating operation."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Data model impact"},{"line_number":72,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_6ad5c346","line":69,"range":{"start_line":68,"start_character":35,"end_line":69,"end_character":41},"in_reply_to":"3f79a3b5_676c1c9d","updated":"2018-10-23 16:26:08.000000000","message":"An example of an external service that could orchestrate this is Karbor:\n\nhttps://docs.openstack.org/karbor/latest/","commit_id":"149f7f4a157f4ee997f33577c15aecc30f64c55c"},{"author":{"_account_id":27594,"name":"Jie Li","email":"lijie@unitedstack.com","username":"ramboman"},"change_message_id":"dff5e4d89ea51113f45dcc96d1f77fabc1cf94a7","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Use cinder API \"Create a backup\" to create a backup of volume. But this method"},{"line_number":67,"context_line":"is just a operation of volume rather than a instance. But rotation is a"},{"line_number":68,"context_line":"question that should be considered. It can back up a volume with cinder backup"},{"line_number":69,"context_line":"API but cannot do the rotating operation."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Data model impact"},{"line_number":72,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_f571a7ac","line":69,"range":{"start_line":68,"start_character":35,"end_line":69,"end_character":41},"in_reply_to":"3f79a3b5_6ad5c346","updated":"2018-10-24 03:05:56.000000000","message":"yeah, so  we may should abandon the create backup API soon.","commit_id":"149f7f4a157f4ee997f33577c15aecc30f64c55c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"13e200447b644146be5f9dbe2a73a8f5082837de","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Other end user impact"},{"line_number":114,"context_line":"---------------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"None"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Performance Impact"},{"line_number":119,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_6a906397","line":116,"updated":"2018-10-23 16:26:08.000000000","message":"There would also be quota restrictions in cinder if using either volume snapshots or volume backups.","commit_id":"149f7f4a157f4ee997f33577c15aecc30f64c55c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae900645f934940ee7c38a3b86c4fbd05a2125ba","unresolved":false,"context_lines":[{"line_number":123,"context_line":"Other deployer impact"},{"line_number":124,"context_line":"---------------------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"None"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Developer impact"},{"line_number":129,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_a70b14d2","line":126,"updated":"2018-10-23 16:11:31.000000000","message":"If the proposal relies on volume backups (and not snapshots), then the cinder-backup service must be configured and running. But it is not clear to me if volume backups are what is being proposed.","commit_id":"149f7f4a157f4ee997f33577c15aecc30f64c55c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae900645f934940ee7c38a3b86c4fbd05a2125ba","unresolved":false,"context_lines":[{"line_number":133,"context_line":"Upgrade impact"},{"line_number":134,"context_line":"--------------"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"None"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Implementation"},{"line_number":139,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_27f2a46a","line":136,"updated":"2018-10-23 16:11:31.000000000","message":"Would there be any required changes to the nova-compute service, or is everything orchestrated from the API like for the volume-backed createImage API?","commit_id":"149f7f4a157f4ee997f33577c15aecc30f64c55c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae900645f934940ee7c38a3b86c4fbd05a2125ba","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"   * - Release Name"},{"line_number":191,"context_line":"     - Description"},{"line_number":192,"context_line":"   * - Rocky"},{"line_number":193,"context_line":"     - Introduced"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_478480b2","line":193,"range":{"start_line":192,"start_character":3,"end_line":193,"end_character":17},"updated":"2018-10-23 16:11:31.000000000","message":"The spec needs to be updated for Stein and moved to the specs/stein/approved directory.","commit_id":"149f7f4a157f4ee997f33577c15aecc30f64c55c"}]}
