)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a97a0d8e49ab1f25091f1188fe0732f6cce5d6c4","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* GET /flavors/details"},{"line_number":21,"context_line":"* GET /flavors/{flavor_id}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Implements: blueprint add-extra-specs-to-flavor-list"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I0a80ce5f8327bf62766e9d47442c013c0f253737"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff6b8bd7_795bca86","line":22,"updated":"2018-03-06 14:50:03.000000000","message":"Should have the APIImpact tag in here.","commit_id":"b5345f5d9a1d18432b44997b6252a7cb8794ca06"}],"specs/queens/approved/include-extra-specs.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"50681b5870aa41117551bb8e835b5919ac4adbee","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Add extra-specs to the flavor show and detail API calls"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/add-extra-specs-to-flavor-list"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add a new microversion to the following APIs to return also"},{"line_number":14,"context_line":"``extra-specs`` of the flavor."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa0c359_9dd2a65b","line":11,"updated":"2018-02-22 17:20:27.000000000","message":"The spec filename needs to be add-extra-specs-to-flavor-list.rst to match the blueprint name.","commit_id":"20e70e4e494d29d2f0334a316c0a00fb23ac659c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"50681b5870aa41117551bb8e835b5919ac4adbee","unresolved":false,"context_lines":[{"line_number":33,"context_line":"UIs and SDKs can avoid doing a separate call to get ``extra_specs`` for"},{"line_number":34,"context_line":"each flavor, also avoiding timeout when doing this."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Add a new microversion to the following APIs to return also"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa0c359_fd4dea3a","line":36,"updated":"2018-02-22 17:20:27.000000000","message":"Somewhere in the spec, maybe this section is OK, I would make a note that the 2.47 microversion does this also, when returning the embedded instance flavor in the server details response, so there is precedent.\n\nhttps://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id42","commit_id":"20e70e4e494d29d2f0334a316c0a00fb23ac659c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"26d362a82ccb37f3112c27d096c3391f9c5aa6ff","unresolved":false,"context_lines":[{"line_number":33,"context_line":"UIs and SDKs can avoid doing a separate call to get ``extra_specs`` for"},{"line_number":34,"context_line":"each flavor, also avoiding timeout when doing this."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Add a new microversion to the following APIs to return also"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff6b8bd7_17dce072","line":36,"in_reply_to":"3fa0c359_fd4dea3a","updated":"2018-03-06 06:40:06.000000000","message":"Done","commit_id":"20e70e4e494d29d2f0334a316c0a00fb23ac659c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"50681b5870aa41117551bb8e835b5919ac4adbee","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Security impact"},{"line_number":139,"context_line":"---------------"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"None"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Notifications impact"},{"line_number":144,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa0c359_1d4bf62a","line":141,"updated":"2018-02-22 17:20:27.000000000","message":"There is a separate policy for showing extra specs, and that needed to be taken into account in the microversion where we started returning the embedded flavor with the server details, so you should note that here and also note that we\u0027ll check that policy rule before exposing extra specs:\n\nhttps://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/instance-flavor-api.html#proposed-change\n\n\"The visibility of the flavor data within the server resource will be controlled by the same policy rules as are used for displaying the flavor extra_specs when displaying flavor details.\"","commit_id":"20e70e4e494d29d2f0334a316c0a00fb23ac659c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"26d362a82ccb37f3112c27d096c3391f9c5aa6ff","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Security impact"},{"line_number":139,"context_line":"---------------"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"None"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Notifications impact"},{"line_number":144,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff6b8bd7_d7e5083a","line":141,"in_reply_to":"3fa0c359_1d4bf62a","updated":"2018-03-06 06:40:06.000000000","message":"Done","commit_id":"20e70e4e494d29d2f0334a316c0a00fb23ac659c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"50681b5870aa41117551bb8e835b5919ac4adbee","unresolved":false,"context_lines":[{"line_number":154,"context_line":"Performance Impact"},{"line_number":155,"context_line":"------------------"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"None"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Other deployer impact"},{"line_number":160,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa0c359_7d5b1af5","line":157,"updated":"2018-02-22 17:20:27.000000000","message":"You likely should point out that there is no performance impact because when we get the flavor from the database, we always join on extra specs so we\u0027re not going to be lazy-loading the information, it\u0027s already available to us, we just aren\u0027t exposing it out of the API yet.\n\nhttps://github.com/openstack/nova/blob/ef4000a0d326deb004843ee51d18030224c5630f/nova/objects/flavor.py#L277","commit_id":"20e70e4e494d29d2f0334a316c0a00fb23ac659c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"26d362a82ccb37f3112c27d096c3391f9c5aa6ff","unresolved":false,"context_lines":[{"line_number":154,"context_line":"Performance Impact"},{"line_number":155,"context_line":"------------------"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"None"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Other deployer impact"},{"line_number":160,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff6b8bd7_b7d6544f","line":157,"in_reply_to":"3fa0c359_7d5b1af5","updated":"2018-03-06 06:40:06.000000000","message":"Done","commit_id":"20e70e4e494d29d2f0334a316c0a00fb23ac659c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"50681b5870aa41117551bb8e835b5919ac4adbee","unresolved":false,"context_lines":[{"line_number":197,"context_line":"Add the following tests."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"* functional tests"},{"line_number":200,"context_line":"* tempest test"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Documentation Impact"},{"line_number":203,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa0c359_3d711277","line":200,"updated":"2018-02-22 17:20:27.000000000","message":"We don\u0027t need tempest tests for this. API sample functional tests in-tree will be sufficient.\n\nYou\u0027ll want unit tests for negative scenarios.","commit_id":"20e70e4e494d29d2f0334a316c0a00fb23ac659c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"26d362a82ccb37f3112c27d096c3391f9c5aa6ff","unresolved":false,"context_lines":[{"line_number":197,"context_line":"Add the following tests."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"* functional tests"},{"line_number":200,"context_line":"* tempest test"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Documentation Impact"},{"line_number":203,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff6b8bd7_77d0bc51","line":200,"in_reply_to":"3fa0c359_3d711277","updated":"2018-03-06 06:40:06.000000000","message":"Done","commit_id":"20e70e4e494d29d2f0334a316c0a00fb23ac659c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"50681b5870aa41117551bb8e835b5919ac4adbee","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"References"},{"line_number":209,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"History"},{"line_number":213,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa0c359_fd664abb","line":210,"updated":"2018-02-22 17:20:27.000000000","message":"None.","commit_id":"20e70e4e494d29d2f0334a316c0a00fb23ac659c"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"26d362a82ccb37f3112c27d096c3391f9c5aa6ff","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"References"},{"line_number":209,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"History"},{"line_number":213,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff6b8bd7_37c24487","line":210,"in_reply_to":"3fa0c359_fd664abb","updated":"2018-03-06 06:40:06.000000000","message":"Done","commit_id":"20e70e4e494d29d2f0334a316c0a00fb23ac659c"}],"specs/rocky/approved/add-extra-specs-to-flavor-list.rst":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f950ba74c773e116f753d2c935db50cb3bb88ba0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Currently the response of ``GET /flavors/details`` and"},{"line_number":23,"context_line":"``GET /flavors/{flavor_id}`` does not include ``extra_spces`` field,"},{"line_number":24,"context_line":"The users have to call ``GET /flavors/{flavor_id}/extra_specs`` again"},{"line_number":25,"context_line":"to get the extra_specs field."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_41ef2fe8","line":23,"range":{"start_line":23,"start_character":48,"end_line":23,"end_character":59},"updated":"2018-03-15 15:44:26.000000000","message":"extra_specs","commit_id":"e9892ce8e83e0994679864d82cf48a5ba2debd5a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6ca6e5692997eb57b033defb6a7565298f492d46","unresolved":false,"context_lines":[{"line_number":185,"context_line":"Assignee(s)"},{"line_number":186,"context_line":"-----------"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Primary assignee:"},{"line_number":189,"context_line":"  Kevin Zheng"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"Other contributors:"},{"line_number":192,"context_line":"  None"}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_21cd5b30","line":189,"range":{"start_line":188,"start_character":0,"end_line":189,"end_character":13},"updated":"2018-03-15 15:52:39.000000000","message":"Yikun is taking this over but that could be updated later.","commit_id":"e9892ce8e83e0994679864d82cf48a5ba2debd5a"}]}
