)]}'
{"specs/rocky/approved/enable-sriov-nic-features.rst":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3a45ee988d2056943662f967254ea764391eb80a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"* A method to store this information in the Nova DB."},{"line_number":52,"context_line":"* How Nova Scheduler PCI filter will match this new information."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Also in this spec will be described how a Neutron port must be defined to"},{"line_number":55,"context_line":"include these NIC features. This information will be added to the OpenStack"},{"line_number":56,"context_line":"manuals and devref."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa0c359_6d5cc518","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":35},"updated":"2018-02-22 22:27:08.000000000","message":"\"The spec also describes\"","commit_id":"787ac69eb5be288d678ae5a89df153ff9665d269"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"768b095c07e58ec29bf2d4eb082181a724e89eb1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"* A method to store this information in the Nova DB."},{"line_number":52,"context_line":"* How Nova Scheduler PCI filter will match this new information."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Also in this spec will be described how a Neutron port must be defined to"},{"line_number":55,"context_line":"include these NIC features. This information will be added to the OpenStack"},{"line_number":56,"context_line":"manuals and devref."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f9dbf25_fcfef3ac","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":35},"in_reply_to":"3fa0c359_6d5cc518","updated":"2018-02-28 11:39:01.000000000","message":"Done","commit_id":"787ac69eb5be288d678ae5a89df153ff9665d269"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3a45ee988d2056943662f967254ea764391eb80a","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The parent of a NIC device is always a unique PCI device and the only child of"},{"line_number":90,"context_line":"this PCI devide is the NIC device. This spec proposes to add a new member to"},{"line_number":91,"context_line":"``nova.virt.libvirt.config.LibvirtConfigNodeDevicePciCap`` class, called"},{"line_number":92,"context_line":"\u0027net_features\u0027. This member will be a list of strings, e.g.,"},{"line_number":93,"context_line":"\u0027HW_NIC_OFFLOAD_RX\u0027, \u0027HW_NIC_OFFLOAD_TSO\u0027 or \u0027HW_NIC_OFFLOAD_RSHASH\u0027. This list"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa0c359_eddd3541","line":90,"range":{"start_line":90,"start_character":9,"end_line":90,"end_character":15},"updated":"2018-02-22 22:27:08.000000000","message":"device","commit_id":"787ac69eb5be288d678ae5a89df153ff9665d269"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"768b095c07e58ec29bf2d4eb082181a724e89eb1","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The parent of a NIC device is always a unique PCI device and the only child of"},{"line_number":90,"context_line":"this PCI devide is the NIC device. This spec proposes to add a new member to"},{"line_number":91,"context_line":"``nova.virt.libvirt.config.LibvirtConfigNodeDevicePciCap`` class, called"},{"line_number":92,"context_line":"\u0027net_features\u0027. This member will be a list of strings, e.g.,"},{"line_number":93,"context_line":"\u0027HW_NIC_OFFLOAD_RX\u0027, \u0027HW_NIC_OFFLOAD_TSO\u0027 or \u0027HW_NIC_OFFLOAD_RSHASH\u0027. This list"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f9dbf25_dcef77e7","line":90,"range":{"start_line":90,"start_character":9,"end_line":90,"end_character":15},"in_reply_to":"3fa0c359_eddd3541","updated":"2018-02-28 11:39:01.000000000","message":"Done","commit_id":"787ac69eb5be288d678ae5a89df153ff9665d269"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3a45ee988d2056943662f967254ea764391eb80a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"this PCI devide is the NIC device. This spec proposes to add a new member to"},{"line_number":91,"context_line":"``nova.virt.libvirt.config.LibvirtConfigNodeDevicePciCap`` class, called"},{"line_number":92,"context_line":"\u0027net_features\u0027. This member will be a list of strings, e.g.,"},{"line_number":93,"context_line":"\u0027HW_NIC_OFFLOAD_RX\u0027, \u0027HW_NIC_OFFLOAD_TSO\u0027 or \u0027HW_NIC_OFFLOAD_RSHASH\u0027. This list"},{"line_number":94,"context_line":"is empty by default. If a PCI device is not a NIC interface or doesn\u0027t have any"},{"line_number":95,"context_line":"feature, the list will remain empty."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa0c359_edb695f9","line":93,"range":{"start_line":93,"start_character":62,"end_line":93,"end_character":63},"updated":"2018-02-22 22:27:08.000000000","message":"X\n\nhttps://github.com/openstack/os-traits/blob/master/os_traits/hw/nic/offload.py#L35","commit_id":"787ac69eb5be288d678ae5a89df153ff9665d269"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"768b095c07e58ec29bf2d4eb082181a724e89eb1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"this PCI devide is the NIC device. This spec proposes to add a new member to"},{"line_number":91,"context_line":"``nova.virt.libvirt.config.LibvirtConfigNodeDevicePciCap`` class, called"},{"line_number":92,"context_line":"\u0027net_features\u0027. This member will be a list of strings, e.g.,"},{"line_number":93,"context_line":"\u0027HW_NIC_OFFLOAD_RX\u0027, \u0027HW_NIC_OFFLOAD_TSO\u0027 or \u0027HW_NIC_OFFLOAD_RSHASH\u0027. This list"},{"line_number":94,"context_line":"is empty by default. If a PCI device is not a NIC interface or doesn\u0027t have any"},{"line_number":95,"context_line":"feature, the list will remain empty."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f9dbf25_3ce3fb07","line":93,"range":{"start_line":93,"start_character":62,"end_line":93,"end_character":63},"in_reply_to":"3fa0c359_edb695f9","updated":"2018-02-28 11:39:01.000000000","message":"Done","commit_id":"787ac69eb5be288d678ae5a89df153ff9665d269"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3a45ee988d2056943662f967254ea764391eb80a","unresolved":false,"context_lines":[{"line_number":143,"context_line":"function in the pool belongs to the same PCI device, all of them have the same"},{"line_number":144,"context_line":"NIC features."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"If the PCI request spec from a Neutron port has a ``capabilities_network``"},{"line_number":147,"context_line":"parameter, the filter will try to match this value with the one stored in the"},{"line_number":148,"context_line":"PCI device pools."},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa0c359_4d9c6969","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":43},"updated":"2018-02-22 22:27:08.000000000","message":"might be good to detail where specifically the \"capabilities_network\" key is expected in the port dict (in the port:binding:profile I presume?).","commit_id":"787ac69eb5be288d678ae5a89df153ff9665d269"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"768b095c07e58ec29bf2d4eb082181a724e89eb1","unresolved":false,"context_lines":[{"line_number":143,"context_line":"function in the pool belongs to the same PCI device, all of them have the same"},{"line_number":144,"context_line":"NIC features."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"If the PCI request spec from a Neutron port has a ``capabilities_network``"},{"line_number":147,"context_line":"parameter, the filter will try to match this value with the one stored in the"},{"line_number":148,"context_line":"PCI device pools."},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f9dbf25_bca5cbb7","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":43},"in_reply_to":"3fa0c359_4d9c6969","updated":"2018-02-28 11:39:01.000000000","message":"yes ill add.\ni just rebased this form last cycle but happy to fix any nits.","commit_id":"787ac69eb5be288d678ae5a89df153ff9665d269"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3a45ee988d2056943662f967254ea764391eb80a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"parameter, the filter will try to match this value with the one stored in the"},{"line_number":148,"context_line":"PCI device pools."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"``capabilities_network`` parameter in both the request spec and the PCI device"},{"line_number":151,"context_line":"stats are lists. Currently the PCI passthrough filter only matches string"},{"line_number":152,"context_line":"parameters [3]_. This spec proposes to change this matching function to accept"},{"line_number":153,"context_line":"both strings and lists:"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* If a string is passed, the function will pass if both strings are equal."},{"line_number":156,"context_line":"* If a list is passed, the function will pass if all elements in the request"},{"line_number":157,"context_line":"  spec list are contained in the PCI device pool list."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa0c359_2d8f9d2a","line":157,"range":{"start_line":150,"start_character":0,"end_line":157,"end_character":54},"updated":"2018-02-22 22:27:08.000000000","message":"fun :(","commit_id":"787ac69eb5be288d678ae5a89df153ff9665d269"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"768b095c07e58ec29bf2d4eb082181a724e89eb1","unresolved":false,"context_lines":[{"line_number":147,"context_line":"parameter, the filter will try to match this value with the one stored in the"},{"line_number":148,"context_line":"PCI device pools."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"``capabilities_network`` parameter in both the request spec and the PCI device"},{"line_number":151,"context_line":"stats are lists. Currently the PCI passthrough filter only matches string"},{"line_number":152,"context_line":"parameters [3]_. This spec proposes to change this matching function to accept"},{"line_number":153,"context_line":"both strings and lists:"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* If a string is passed, the function will pass if both strings are equal."},{"line_number":156,"context_line":"* If a list is passed, the function will pass if all elements in the request"},{"line_number":157,"context_line":"  spec list are contained in the PCI device pool list."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f9dbf25_1c55df50","line":157,"range":{"start_line":150,"start_character":0,"end_line":157,"end_character":54},"in_reply_to":"3fa0c359_2d8f9d2a","updated":"2018-02-28 11:39:01.000000000","message":"if it makes you fell beter this is like 10 lines of code + tests and we also converted these datastruction from unversioned dictionaries to OVOs","commit_id":"787ac69eb5be288d678ae5a89df153ff9665d269"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3a45ee988d2056943662f967254ea764391eb80a","unresolved":false,"context_lines":[{"line_number":201,"context_line":"Other deployer impact"},{"line_number":202,"context_line":"---------------------"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"``libvirt`` implemented the SR-IOV NIC offload feature discovery on version"},{"line_number":205,"context_line":"1.2.14 [1]."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa0c359_6d704541","line":204,"range":{"start_line":204,"start_character":65,"end_line":204,"end_character":67},"updated":"2018-02-22 22:27:08.000000000","message":"in","commit_id":"787ac69eb5be288d678ae5a89df153ff9665d269"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3a45ee988d2056943662f967254ea764391eb80a","unresolved":false,"context_lines":[{"line_number":207,"context_line":"Developer impact"},{"line_number":208,"context_line":"----------------"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"None"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"Implementation"},{"line_number":213,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa0c359_9d8aa618","line":210,"updated":"2018-02-22 22:27:08.000000000","message":"Section \u0027Proposed change\u0027 is missing subsections: [u\u0027Upgrade impact\u0027]","commit_id":"787ac69eb5be288d678ae5a89df153ff9665d269"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"768b095c07e58ec29bf2d4eb082181a724e89eb1","unresolved":false,"context_lines":[{"line_number":207,"context_line":"Developer impact"},{"line_number":208,"context_line":"----------------"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"None"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"Implementation"},{"line_number":213,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f9dbf25_9c948fea","line":210,"in_reply_to":"3fa0c359_9d8aa618","updated":"2018-02-28 11:39:01.000000000","message":"yep there should be none but ill add it now.","commit_id":"787ac69eb5be288d678ae5a89df153ff9665d269"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"591b0bc345e075dc08f6a808bcea5770622700a5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"retrieve physical NIC information from the system, which means the scheduler"},{"line_number":27,"context_line":"cannot filter out compute hosts that do not contain certain NIC features."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"If a virtual machine, during the booting step, discovers a NIC offload"},{"line_number":30,"context_line":"feature, Nova Scheduler can select those hosts that have PCI devices with that"},{"line_number":31,"context_line":"feature."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The aim of this spec is to fill this gap by proposing a method to read this"},{"line_number":34,"context_line":"information, store it, use it during the scheduling process and provide a way"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_b5fdb23b","line":31,"range":{"start_line":29,"start_character":0,"end_line":31,"end_character":8},"updated":"2018-03-09 23:24:04.000000000","message":"this doesn\u0027t really make sense to me. On booting a virtual machine, the nova scheduler has already selected a host for the VM...","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"780062806c71629b242ddc67dcb0f64c5e731291","unresolved":false,"context_lines":[{"line_number":26,"context_line":"retrieve physical NIC information from the system, which means the scheduler"},{"line_number":27,"context_line":"cannot filter out compute hosts that do not contain certain NIC features."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"If a virtual machine, during the booting step, discovers a NIC offload"},{"line_number":30,"context_line":"feature, Nova Scheduler can select those hosts that have PCI devices with that"},{"line_number":31,"context_line":"feature."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The aim of this spec is to fill this gap by proposing a method to read this"},{"line_number":34,"context_line":"information, store it, use it during the scheduling process and provide a way"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_5b193786","line":31,"range":{"start_line":29,"start_character":0,"end_line":31,"end_character":8},"in_reply_to":"df7087c5_54494a5d","updated":"2018-03-23 16:58:07.000000000","message":"Even so, the scheduler has already selected the destination host by the time the boot step occurs...","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5f869e21be8810bcfbacc803fe6d2e73c0271f1b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"retrieve physical NIC information from the system, which means the scheduler"},{"line_number":27,"context_line":"cannot filter out compute hosts that do not contain certain NIC features."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"If a virtual machine, during the booting step, discovers a NIC offload"},{"line_number":30,"context_line":"feature, Nova Scheduler can select those hosts that have PCI devices with that"},{"line_number":31,"context_line":"feature."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The aim of this spec is to fill this gap by proposing a method to read this"},{"line_number":34,"context_line":"information, store it, use it during the scheduling process and provide a way"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_54494a5d","line":31,"range":{"start_line":29,"start_character":0,"end_line":31,"end_character":8},"in_reply_to":"df7087c5_b5fdb23b","updated":"2018-03-14 21:21:06.000000000","message":"discovers should be requests.","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"508c4e068d13c39f33cea2fb6b0e077854d22be2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"feature, Nova Scheduler can select those hosts that have PCI devices with that"},{"line_number":31,"context_line":"feature."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The aim of this spec is to fill this gap by proposing a method to read this"},{"line_number":34,"context_line":"information, store it, use it during the scheduling process and provide a way"},{"line_number":35,"context_line":"to share this information with Neutron."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_3f3102a4","line":33,"range":{"start_line":33,"start_character":27,"end_line":33,"end_character":31},"updated":"2018-03-15 09:33:10.000000000","message":"close?","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"591b0bc345e075dc08f6a808bcea5770622700a5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"feature."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The aim of this spec is to fill this gap by proposing a method to read this"},{"line_number":34,"context_line":"information, store it, use it during the scheduling process and provide a way"},{"line_number":35,"context_line":"to share this information with Neutron."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Use Cases"},{"line_number":38,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_55a2164d","line":35,"range":{"start_line":34,"start_character":59,"end_line":35,"end_character":39},"updated":"2018-03-09 23:24:04.000000000","message":"I\u0027m not entirely sure this last part should be in scope of this particular spec, but ok...","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5f869e21be8810bcfbacc803fe6d2e73c0271f1b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"feature."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The aim of this spec is to fill this gap by proposing a method to read this"},{"line_number":34,"context_line":"information, store it, use it during the scheduling process and provide a way"},{"line_number":35,"context_line":"to share this information with Neutron."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Use Cases"},{"line_number":38,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_d4a31aff","line":35,"range":{"start_line":34,"start_character":59,"end_line":35,"end_character":39},"in_reply_to":"df7087c5_55a2164d","updated":"2018-03-14 21:21:06.000000000","message":"\"a method to read this information, store it\" that part was actully merged in pike.\n\nwhats left is use it during the scheduling.\n\nthe provide a way to share it with neutron was eluding to the fact we wanted to model these capablities as traits on the pf/vf in placement eventually and neutron could get it from there.","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"9051b4f89d836a7cacf3d44f3eb4a7a2a95f5ea3","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This spec proposes to implement the following changes in Nova:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* A method to read the NIC feature information."},{"line_number":51,"context_line":"* A method to store this information in the Nova DB."},{"line_number":52,"context_line":"* How Nova Scheduler PCI filter will match this new information."},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f9dbf25_52f01991","line":50,"updated":"2018-03-01 14:29:46.000000000","message":"I assume this is going to be in the compute drivers, right? This could probably be reported via the new get_inventory driver method (or whatever the name is)?\n\nAnyways. For the Hyper-V Driver, something like can easily be done, we\u0027d only have to call this os-win method we\u0027ve already added.\n\nhttps://review.openstack.org/#/c/531383/9/","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"36499606df55b042bd326895b8a53c93a1649415","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This spec proposes to implement the following changes in Nova:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* A method to read the NIC feature information."},{"line_number":51,"context_line":"* A method to store this information in the Nova DB."},{"line_number":52,"context_line":"* How Nova Scheduler PCI filter will match this new information."},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_42e148fe","line":50,"in_reply_to":"1f9dbf25_52f01991","updated":"2018-03-07 02:17:10.000000000","message":"One of the responsibilities of the virtdriver is to transform the nic features as reported by the hypervisor into the canonical traits for that feature. So yes you can likely delegate to that function but will need to normalise the nic features to the os-traits trsits before they leave the virt driver.","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"591b0bc345e075dc08f6a808bcea5770622700a5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"This spec proposes to implement the following changes in Nova:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* A method to read the NIC feature information."},{"line_number":51,"context_line":"* A method to store this information in the Nova DB."},{"line_number":52,"context_line":"* How Nova Scheduler PCI filter will match this new information."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The spec also describes how a Neutron port must be defined to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_75be3a66","line":51,"updated":"2018-03-09 23:24:04.000000000","message":"why? won\u0027t this just duplicate the storage of these capabilities with what will be in placement?","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5f869e21be8810bcfbacc803fe6d2e73c0271f1b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"This spec proposes to implement the following changes in Nova:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* A method to read the NIC feature information."},{"line_number":51,"context_line":"* A method to store this information in the Nova DB."},{"line_number":52,"context_line":"* How Nova Scheduler PCI filter will match this new information."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The spec also describes how a Neutron port must be defined to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_f47f3e63","line":51,"in_reply_to":"df7087c5_75be3a66","updated":"2018-03-14 21:21:06.000000000","message":"because that bit merged in pike and we have not ported the info from the pci_device table into traits in placement yet.","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3c1e0b861c4949b1ad3860e2b63c40ca0a834f8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"This spec proposes to implement the following changes in Nova:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* A method to read the NIC feature information."},{"line_number":51,"context_line":"* A method to store this information in the Nova DB."},{"line_number":52,"context_line":"* How Nova Scheduler PCI filter will match this new information."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The spec also describes how a Neutron port must be defined to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_34650446","line":51,"in_reply_to":"df7087c5_e7d94e22","updated":"2018-03-22 01:41:49.000000000","message":"well we dont if we use tratis but we have been storing this in the nova db since pike so that ship has kindo of sailed unless we want to delete the existing info form the db.","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8dae5cf8631eea86c2066b7de37276b2d89de82d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"This spec proposes to implement the following changes in Nova:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* A method to read the NIC feature information."},{"line_number":51,"context_line":"* A method to store this information in the Nova DB."},{"line_number":52,"context_line":"* How Nova Scheduler PCI filter will match this new information."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The spec also describes how a Neutron port must be defined to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_e7d94e22","line":51,"in_reply_to":"df7087c5_f47f3e63","updated":"2018-03-20 14:42:10.000000000","message":"I\u0027m still not sure why we need to persist the information into the PCI tables.","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"591b0bc345e075dc08f6a808bcea5770622700a5","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* A method to read the NIC feature information."},{"line_number":51,"context_line":"* A method to store this information in the Nova DB."},{"line_number":52,"context_line":"* How Nova Scheduler PCI filter will match this new information."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The spec also describes how a Neutron port must be defined to"},{"line_number":55,"context_line":"include these NIC features. This information will be added to the OpenStack"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_35b8c274","line":52,"updated":"2018-03-09 23:24:04.000000000","message":"It wouldn\u0027t have to if the placement service was used to begin with instead of the cell DB...","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3c1e0b861c4949b1ad3860e2b63c40ca0a834f8","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* A method to read the NIC feature information."},{"line_number":51,"context_line":"* A method to store this information in the Nova DB."},{"line_number":52,"context_line":"* How Nova Scheduler PCI filter will match this new information."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The spec also describes how a Neutron port must be defined to"},{"line_number":55,"context_line":"include these NIC features. This information will be added to the OpenStack"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_d4d048cc","line":52,"in_reply_to":"df7087c5_07eec2b3","updated":"2018-03-22 01:41:49.000000000","message":"well we can but this has been code complete since pike it missed the pike code freeze by like  3 days and we have been rebasing the code for 2 cycles.\n\ni can abandon all the existing patches\nhttps://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/enable-sriov-nic-features\n\nbut if i do im not sure i will be able to contiue working on this feature in any form.\n\nif i can get it merged i might be able to start converting to placement but i have an internal deadline to wrap this work up by milestone 1","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5f869e21be8810bcfbacc803fe6d2e73c0271f1b","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* A method to read the NIC feature information."},{"line_number":51,"context_line":"* A method to store this information in the Nova DB."},{"line_number":52,"context_line":"* How Nova Scheduler PCI filter will match this new information."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The spec also describes how a Neutron port must be defined to"},{"line_number":55,"context_line":"include these NIC features. This information will be added to the OpenStack"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_94c842a6","line":52,"in_reply_to":"df7087c5_35b8c274","updated":"2018-03-14 21:21:06.000000000","message":"true. can we do that as a step 2? if we can complete that also in rocky then im in favour of that. i would just like to merge the current code first then move do pci device in placement second.","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8dae5cf8631eea86c2066b7de37276b2d89de82d","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* A method to read the NIC feature information."},{"line_number":51,"context_line":"* A method to store this information in the Nova DB."},{"line_number":52,"context_line":"* How Nova Scheduler PCI filter will match this new information."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The spec also describes how a Neutron port must be defined to"},{"line_number":55,"context_line":"include these NIC features. This information will be added to the OpenStack"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_07eec2b3","line":52,"in_reply_to":"df7087c5_94c842a6","updated":"2018-03-20 14:42:10.000000000","message":"Why couldn\u0027t we just use the Placement API for that (and not modify the PCI filter) ?","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"591b0bc345e075dc08f6a808bcea5770622700a5","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \u003c/device\u003e"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The parent of a NIC device is always a unique PCI device and the only child of"},{"line_number":90,"context_line":"this PCI device is the NIC device. This spec proposes to add a new member to"},{"line_number":91,"context_line":"``nova.virt.libvirt.config.LibvirtConfigNodeDevicePciCap`` class, called"},{"line_number":92,"context_line":"\u0027net_features\u0027. This member will be a list of strings, e.g.,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_75639a1b","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":56},"updated":"2018-03-09 23:24:04.000000000","message":"this is not always true in non-x86 platforms.","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5f869e21be8810bcfbacc803fe6d2e73c0271f1b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \u003c/device\u003e"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The parent of a NIC device is always a unique PCI device and the only child of"},{"line_number":90,"context_line":"this PCI device is the NIC device. This spec proposes to add a new member to"},{"line_number":91,"context_line":"``nova.virt.libvirt.config.LibvirtConfigNodeDevicePciCap`` class, called"},{"line_number":92,"context_line":"\u0027net_features\u0027. This member will be a list of strings, e.g.,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_1463d2b3","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":56},"in_reply_to":"df7087c5_75639a1b","updated":"2018-03-14 21:21:06.000000000","message":"actully its not true for melonox connectx-3 nics on x86 also but ya i can remove that if i respin.","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8dae5cf8631eea86c2066b7de37276b2d89de82d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"\u0027net_features\u0027. This member will be a list of strings, e.g.,"},{"line_number":93,"context_line":"\u0027HW_NIC_OFFLOAD_RX\u0027, \u0027HW_NIC_OFFLOAD_TSO\u0027 or \u0027HW_NIC_OFFLOAD_RXHASH\u0027. This list"},{"line_number":94,"context_line":"is empty by default. If a PCI device is not a NIC interface or doesn\u0027t have any"},{"line_number":95,"context_line":"feature, the list will remain empty."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Store the NIC features information"},{"line_number":98,"context_line":"----------------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_c72d2afe","line":95,"updated":"2018-03-20 14:42:10.000000000","message":"okay with that.","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"591b0bc345e075dc08f6a808bcea5770622700a5","unresolved":false,"context_lines":[{"line_number":114,"context_line":"traits belonging to ``os-traits`` project. Those traits are located under"},{"line_number":115,"context_line":"``os_traits.hw.nic`` directory [2]_. Any other string not found in"},{"line_number":116,"context_line":"``os-traits`` will be discarded from ``capabilities:network`` list and a"},{"line_number":117,"context_line":"warning message will be logged, but no exception will be risen."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Neutron port ``binding:profile``"},{"line_number":120,"context_line":"--------------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_3546827e","line":117,"updated":"2018-03-09 23:24:04.000000000","message":"this is fine, but of course just means duplicated work/storage since we need to track devices in placement eventually... we just keep putting off doing this for some reason and add more cruft into the pci module.","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8dae5cf8631eea86c2066b7de37276b2d89de82d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"traits belonging to ``os-traits`` project. Those traits are located under"},{"line_number":115,"context_line":"``os_traits.hw.nic`` directory [2]_. Any other string not found in"},{"line_number":116,"context_line":"``os-traits`` will be discarded from ``capabilities:network`` list and a"},{"line_number":117,"context_line":"warning message will be logged, but no exception will be risen."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Neutron port ``binding:profile``"},{"line_number":120,"context_line":"--------------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_a71356b8","line":117,"in_reply_to":"df7087c5_3546827e","updated":"2018-03-20 14:42:10.000000000","message":"Why couldn\u0027t we just have the virt driver passing the traits to the compute service, so the RP would have those traits ?","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"9051b4f89d836a7cacf3d44f3eb4a7a2a95f5ea3","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    $ openstack port create --binding-profile"},{"line_number":129,"context_line":"        \u0027{\"capabilities\": [\"HW_NIC_OFFLOAD_RX\", \"HW_NIC_OFFLOAD_TSO\"]}\u0027"},{"line_number":130,"context_line":"        --network private port1"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Nova Scheduler filter ``PciPassthroughFilter``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f9dbf25_52733916","line":130,"updated":"2018-03-01 14:29:46.000000000","message":"So basically those are traits, right? The scheduler will only have to pick out hosts which have these NIC offload traits / capabilities.\n\nIn the Hyper-V case, we mostly have consumable NIC offloading resources, which should be tracked in order to properly create instances which can consume those offloading capabilities properly.","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"36499606df55b042bd326895b8a53c93a1649415","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    $ openstack port create --binding-profile"},{"line_number":129,"context_line":"        \u0027{\"capabilities\": [\"HW_NIC_OFFLOAD_RX\", \"HW_NIC_OFFLOAD_TSO\"]}\u0027"},{"line_number":130,"context_line":"        --network private port1"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Nova Scheduler filter ``PciPassthroughFilter``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_a2e5c43a","line":130,"in_reply_to":"","updated":"2018-03-07 02:17:10.000000000","message":"Yes these are os-traits traits. Presently the pci manager in the nova compute agent need to compre the network capability to the traits on the pci devices. This could be easily extended to non pci devices but the initial implications is for sriov devices. The intent is when PFs and VFs are tracked in placement then it will evaluate the traits before hitting the pci pass through filter however currently the filtering is not done in placement as this was intended for pike.","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8dae5cf8631eea86c2066b7de37276b2d89de82d","unresolved":false,"context_lines":[{"line_number":138,"context_line":"and the Neutron port definition passed in the boot command. With this feature,"},{"line_number":139,"context_line":"the Neutron port would be able to contain a list of NIC features."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"To add this new parameter to the filter, ``PciDeviceStats`` PCI device pools"},{"line_number":142,"context_line":"will contain a new tag key (\u0027capabilities.network\u0027). Because every virtual"},{"line_number":143,"context_line":"function in the pool belongs to the same PCI device, all of them have the same"},{"line_number":144,"context_line":"NIC features."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"If the binding profile from a Neutron port has a ``capabilities_network``"},{"line_number":147,"context_line":"parameter, this will be extracted from the neutron port and added to the"},{"line_number":148,"context_line":"PCI request spec, the PCI passthrough filter will try to match this value"},{"line_number":149,"context_line":"with the one stored in the PCI device pools."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"``capabilities_network`` parameter in both the request spec and the PCI device"},{"line_number":152,"context_line":"stats are lists. Currently the PCI passthrough filter only matches string"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_4767da52","line":149,"range":{"start_line":141,"start_character":0,"end_line":149,"end_character":44},"updated":"2018-03-20 14:42:10.000000000","message":"that\u0027s where I disagree. Why couldn\u0027t we just modify the conductor to look at the port (meaning that we need to get the port *before* the compute service call) and passing the traits into the scheduler, so it would ask for the traits ?","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3c1e0b861c4949b1ad3860e2b63c40ca0a834f8","unresolved":false,"context_lines":[{"line_number":138,"context_line":"and the Neutron port definition passed in the boot command. With this feature,"},{"line_number":139,"context_line":"the Neutron port would be able to contain a list of NIC features."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"To add this new parameter to the filter, ``PciDeviceStats`` PCI device pools"},{"line_number":142,"context_line":"will contain a new tag key (\u0027capabilities.network\u0027). Because every virtual"},{"line_number":143,"context_line":"function in the pool belongs to the same PCI device, all of them have the same"},{"line_number":144,"context_line":"NIC features."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"If the binding profile from a Neutron port has a ``capabilities_network``"},{"line_number":147,"context_line":"parameter, this will be extracted from the neutron port and added to the"},{"line_number":148,"context_line":"PCI request spec, the PCI passthrough filter will try to match this value"},{"line_number":149,"context_line":"with the one stored in the PCI device pools."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"``capabilities_network`` parameter in both the request spec and the PCI device"},{"line_number":152,"context_line":"stats are lists. Currently the PCI passthrough filter only matches string"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_b48354a9","line":149,"range":{"start_line":141,"start_character":0,"end_line":149,"end_character":44},"in_reply_to":"df7087c5_4767da52","updated":"2018-03-22 01:41:49.000000000","message":"yes yes we could. the point is that this was approve for pike and queens and was code complete and this was just a repoposal of the original spec not changeing any of the design that was previously approved.\n\nthis is why this spec does not use placement or traits as we would if we were starting from scratch today.","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ed6619b1da68d7d51ca63fef1ef05ace3c511062","unresolved":false,"context_lines":[{"line_number":138,"context_line":"and the Neutron port definition passed in the boot command. With this feature,"},{"line_number":139,"context_line":"the Neutron port would be able to contain a list of NIC features."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"To add this new parameter to the filter, ``PciDeviceStats`` PCI device pools"},{"line_number":142,"context_line":"will contain a new tag key (\u0027capabilities.network\u0027). Because every virtual"},{"line_number":143,"context_line":"function in the pool belongs to the same PCI device, all of them have the same"},{"line_number":144,"context_line":"NIC features."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"If the binding profile from a Neutron port has a ``capabilities_network``"},{"line_number":147,"context_line":"parameter, this will be extracted from the neutron port and added to the"},{"line_number":148,"context_line":"PCI request spec, the PCI passthrough filter will try to match this value"},{"line_number":149,"context_line":"with the one stored in the PCI device pools."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"``capabilities_network`` parameter in both the request spec and the PCI device"},{"line_number":152,"context_line":"stats are lists. Currently the PCI passthrough filter only matches string"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_9834b5e0","line":149,"range":{"start_line":141,"start_character":0,"end_line":149,"end_character":44},"in_reply_to":"df7087c5_b48354a9","updated":"2018-03-23 15:59:40.000000000","message":"So, we discussed in IRC about that. Sean explained why he would like to just be possible to accept the existing spec and I understand his opinion. He\u0027s also okay with trying to see in the next cycles how to modify that feature to use traits when he have time.\n\nGiven the situation, and given Jay already accepted that spec, I\u0027m fine with accepting it too.","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8dae5cf8631eea86c2066b7de37276b2d89de82d","unresolved":false,"context_lines":[{"line_number":164,"context_line":"* To create a new member in Neutron ``port``, containing the feature"},{"line_number":165,"context_line":"  information as a list of strings. However, this change doesn\u0027t add any value"},{"line_number":166,"context_line":"  because currently there is a place, ``binding:profile``, to define and"},{"line_number":167,"context_line":"  store this information."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"Data model impact"},{"line_number":170,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_c7c9aa25","line":167,"updated":"2018-03-20 14:42:10.000000000","message":"here, you need to explain why we can\u0027t just take the port traits from Neutron before calling the scheduler so that the scheduler will then call the Placement API for those traits ?\n\nI know we discussed that at the PTG, but IIRC we haven\u0027t said why it wasn\u0027t possible to just use the conductor for getting the port and then doing the above...","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3c1e0b861c4949b1ad3860e2b63c40ca0a834f8","unresolved":false,"context_lines":[{"line_number":164,"context_line":"* To create a new member in Neutron ``port``, containing the feature"},{"line_number":165,"context_line":"  information as a list of strings. However, this change doesn\u0027t add any value"},{"line_number":166,"context_line":"  because currently there is a place, ``binding:profile``, to define and"},{"line_number":167,"context_line":"  store this information."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"Data model impact"},{"line_number":170,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_b4acb435","line":167,"in_reply_to":"df7087c5_c7c9aa25","updated":"2018-03-22 01:41:49.000000000","message":"lets discuss on irc tomorow as if plamcent ant traiats is a requirement for this i need to abandon all of the existing code and start reverting some of the code the merged in pike.","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"508c4e068d13c39f33cea2fb6b0e077854d22be2","unresolved":false,"context_lines":[{"line_number":248,"context_line":"Few unittest needs to be adjusted to work correctly. All the unittest and"},{"line_number":249,"context_line":"functional should be passed after the change."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Once the third-party CI with specific hardware is added to Jenkins, new tests"},{"line_number":252,"context_line":"will be added."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"Documentation Impact"},{"line_number":255,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_ff970a39","line":252,"range":{"start_line":251,"start_character":0,"end_line":252,"end_character":14},"updated":"2018-03-15 09:33:10.000000000","message":"Not sure if this will happen now. Are there third-party CIs run by Intel nowadays?","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e6fd89577ac6fce2f945c8fb0d212d111e8b6cad","unresolved":false,"context_lines":[{"line_number":248,"context_line":"Few unittest needs to be adjusted to work correctly. All the unittest and"},{"line_number":249,"context_line":"functional should be passed after the change."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Once the third-party CI with specific hardware is added to Jenkins, new tests"},{"line_number":252,"context_line":"will be added."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"Documentation Impact"},{"line_number":255,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_53b14e46","line":252,"range":{"start_line":251,"start_character":0,"end_line":252,"end_character":14},"in_reply_to":"df7087c5_ff970a39","updated":"2018-03-15 12:15:28.000000000","message":"yes there are but good point i dont own the backlog for them anymore so i may not be able to get this added.\n\nwe may have to rely on functional test / the fake libvirt driver to do testing beyond unit tests.","commit_id":"ea10806ace9b237afdb5acc4c93693f3a17813f4"}]}