)]}'
{"specs/rocky/approved/update-provider-tree.rst":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c7e25492cb00a73139300aa10c5b04ca598e4c24","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"* ``name_or_uuid``: Either the name or the UUID of the resource provider whose"},{"line_number":241,"context_line":"  traits are to be merged."},{"line_number":242,"context_line":"* ``traits_add``: A set of string names of traits to ensure are set."},{"line_number":243,"context_line":"* ``traits_rem``: A set of string names of traits to ensure are unset."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"When the method completes, the following are guaranteed::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_eaf0fc69","line":242,"updated":"2018-03-12 19:24:11.000000000","message":"For these, the nicest syntactic sugar, IMHO, would be:\n\n def traits_add(self, provider, **traits)\n\nso you can just provide arguments of traits to this instead of constructing a set or list in a single argument.","commit_id":"776cb1debdf69ae09f35e8056ef2fb09da3abd1a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"522d6622ae88f21447d357019d834121fe1edea5","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"* ``name_or_uuid``: Either the name or the UUID of the resource provider whose"},{"line_number":241,"context_line":"  traits are to be merged."},{"line_number":242,"context_line":"* ``traits_add``: A set of string names of traits to ensure are set."},{"line_number":243,"context_line":"* ``traits_rem``: A set of string names of traits to ensure are unset."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"When the method completes, the following are guaranteed::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_ca49788b","line":242,"in_reply_to":"df7087c5_aa6d2405","updated":"2018-03-12 19:34:58.000000000","message":"I assume you meant *traits.\n\nMeh.  Realistically I bet impls end up invoking it with *my_traits anyway.\n\nBut okay.  So you want two separate methods.","commit_id":"776cb1debdf69ae09f35e8056ef2fb09da3abd1a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"219472b53c77fb50f6ededc0a4fab09dc3e15817","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"* ``name_or_uuid``: Either the name or the UUID of the resource provider whose"},{"line_number":241,"context_line":"  traits are to be merged."},{"line_number":242,"context_line":"* ``traits_add``: A set of string names of traits to ensure are set."},{"line_number":243,"context_line":"* ``traits_rem``: A set of string names of traits to ensure are unset."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"When the method completes, the following are guaranteed::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_aa6d2405","line":242,"in_reply_to":"df7087c5_eaf0fc69","updated":"2018-03-12 19:31:01.000000000","message":"Agreed with Dan here.","commit_id":"776cb1debdf69ae09f35e8056ef2fb09da3abd1a"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"5e9f15519377e07fc5196984950805c3cd1cde65","unresolved":false,"context_lines":[{"line_number":240,"context_line":"* ``name_or_uuid``: Either the name or the UUID of the resource provider whose"},{"line_number":241,"context_line":"  traits are to be merged."},{"line_number":242,"context_line":"* ``traits_add``: A set of string names of traits to ensure are set."},{"line_number":243,"context_line":"* ``traits_rem``: A set of string names of traits to ensure are unset."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"When the method completes, the following are guaranteed::"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_2afef436","line":243,"range":{"start_line":243,"start_character":4,"end_line":243,"end_character":14},"updated":"2018-03-12 19:25:39.000000000","message":"Please spell out \"remove\". I thought this looked like it was short for \"remember\".","commit_id":"776cb1debdf69ae09f35e8056ef2fb09da3abd1a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"219472b53c77fb50f6ededc0a4fab09dc3e15817","unresolved":false,"context_lines":[{"line_number":240,"context_line":"* ``name_or_uuid``: Either the name or the UUID of the resource provider whose"},{"line_number":241,"context_line":"  traits are to be merged."},{"line_number":242,"context_line":"* ``traits_add``: A set of string names of traits to ensure are set."},{"line_number":243,"context_line":"* ``traits_rem``: A set of string names of traits to ensure are unset."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"When the method completes, the following are guaranteed::"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_ea631c19","line":243,"range":{"start_line":243,"start_character":4,"end_line":243,"end_character":14},"in_reply_to":"df7087c5_2afef436","updated":"2018-03-12 19:31:01.000000000","message":"Agree with Ed. No need to save 3 chars space.","commit_id":"776cb1debdf69ae09f35e8056ef2fb09da3abd1a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"522d6622ae88f21447d357019d834121fe1edea5","unresolved":false,"context_lines":[{"line_number":240,"context_line":"* ``name_or_uuid``: Either the name or the UUID of the resource provider whose"},{"line_number":241,"context_line":"  traits are to be merged."},{"line_number":242,"context_line":"* ``traits_add``: A set of string names of traits to ensure are set."},{"line_number":243,"context_line":"* ``traits_rem``: A set of string names of traits to ensure are unset."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"When the method completes, the following are guaranteed::"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_4a55681c","line":243,"range":{"start_line":243,"start_character":4,"end_line":243,"end_character":14},"in_reply_to":"df7087c5_ea631c19","updated":"2018-03-12 19:34:58.000000000","message":"Ack.  Was following naming in Dan\u0027s sample code [1].\n\n[1] https://pastebin.com/mM6NMzQ4","commit_id":"776cb1debdf69ae09f35e8056ef2fb09da3abd1a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"be25b0921efe0cf3473552587b7dca42e7d0876a","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"* ``name_or_uuid``: Either the name or the UUID of the resource provider whose"},{"line_number":269,"context_line":"  aggregates are to be affected."},{"line_number":270,"context_line":"* ``aggregates``: String names of aggregates to add or remove.  Any other"},{"line_number":271,"context_line":"  aggregates associated with the provider are untouched."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df7087c5_f72c5303","line":270,"range":{"start_line":270,"start_character":25,"end_line":270,"end_character":30},"updated":"2018-03-13 10:19:23.000000000","message":"nit: I think those are UUIDs today.","commit_id":"c36149a42e52112eb6929787cd04bfe53b387d70"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"fec285f574c116e59f8ededeac4c1b631ad1e0f3","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"* ``name_or_uuid``: Either the name or the UUID of the resource provider whose"},{"line_number":269,"context_line":"  aggregates are to be affected."},{"line_number":270,"context_line":"* ``aggregates``: String names of aggregates to add or remove.  Any other"},{"line_number":271,"context_line":"  aggregates associated with the provider are untouched."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df7087c5_ccb3b909","line":270,"range":{"start_line":270,"start_character":25,"end_line":270,"end_character":30},"in_reply_to":"df7087c5_f72c5303","updated":"2018-03-13 14:31:37.000000000","message":"You\u0027re right; copy/paste miss.","commit_id":"c36149a42e52112eb6929787cd04bfe53b387d70"}]}