)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"fa9c05361d9ba36425c42661642bc9de046d68da","unresolved":false,"context_lines":[{"line_number":10,"context_line":"also needs to add the ``extra-specs`` in response to keep consist."},{"line_number":11,"context_line":"2. Fix typo in bp."},{"line_number":12,"context_line":"3. Change primary assignee and other contributors."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2d2523da038e5f4e5547eb74180786429e817912"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df7087c5_936ec1c7","line":13,"updated":"2018-03-19 08:57:40.000000000","message":"Blueprint tag?","commit_id":"569f7924bf985e81637f371e62c19380df252865"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"a261d80707318b03372da88175e5dbc7ce22da8c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"also needs to add the ``extra-specs`` in response to keep consist."},{"line_number":11,"context_line":"2. Fix typo in bp."},{"line_number":12,"context_line":"3. Change primary assignee and other contributors."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2d2523da038e5f4e5547eb74180786429e817912"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df7087c5_46db857c","line":13,"in_reply_to":"df7087c5_936ec1c7","updated":"2018-03-19 09:31:57.000000000","message":"Thanks, done. : )","commit_id":"569f7924bf985e81637f371e62c19380df252865"}],"specs/rocky/approved/add-extra-specs-to-flavor-list.rst":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"34cb279eef1307ba9210026ebff925f0aa66d431","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/add-extra-specs-to-flavor-list"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add a new microversion to the following APIs to return also"},{"line_number":14,"context_line":"``extra-specs`` of the flavor."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"* GET /flavors/details"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_d9f3ba9d","line":13,"range":{"start_line":13,"start_character":45,"end_line":13,"end_character":59},"updated":"2018-03-27 16:57:00.000000000","message":"actually, that\u0027s a separate feature, right?\nYou ask to be accepting to pass extra specs when creating flavors. I think that needs to be discussed in a separate spec.","commit_id":"a1a4a6c13e22d5ffe0e59e91d8f3727ae24a7c03"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"20c1451f2f84a9b40bb36f9c5ef5d34519525046","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/add-extra-specs-to-flavor-list"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add a new microversion to the following APIs to return also"},{"line_number":14,"context_line":"``extra-specs`` of the flavor."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"* GET /flavors/details"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_1956125e","line":13,"range":{"start_line":13,"start_character":45,"end_line":13,"end_character":59},"in_reply_to":"bf659307_d9f3ba9d","updated":"2018-03-27 17:01:08.000000000","message":"Nevermind that comment.","commit_id":"a1a4a6c13e22d5ffe0e59e91d8f3727ae24a7c03"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bd432f3629dfdb05688c19820bf4d9641bcc5bc2","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/add-extra-specs-to-flavor-list"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add a new microversion to the following APIs to return also"},{"line_number":14,"context_line":"``extra-specs`` of the flavor."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"* GET /flavors/details"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_599faa02","line":13,"range":{"start_line":13,"start_character":45,"end_line":13,"end_character":59},"in_reply_to":"bf659307_d9f3ba9d","updated":"2018-03-27 17:03:18.000000000","message":"No I don\u0027t think it is, it\u0027s just saying, return the same thing in the POST response, and since you can\u0027t create a flavor with extra specs in the POST /flavors API today, we\u0027d just return an empty extra_specs in the response (or whatever we do for GET if there are no extra specs).","commit_id":"a1a4a6c13e22d5ffe0e59e91d8f3727ae24a7c03"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"971b8ad1e769c0a9f24b295836797c5b2beb488d","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/add-extra-specs-to-flavor-list"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add a new microversion to the following APIs to return also"},{"line_number":14,"context_line":"``extra-specs`` of the flavor."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"* GET /flavors/details"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_99bea263","line":13,"range":{"start_line":13,"start_character":45,"end_line":13,"end_character":59},"in_reply_to":"bf659307_d9f3ba9d","updated":"2018-03-27 17:00:56.000000000","message":"No, this is just about the return of those calls, not asking to let the client pass those values on PUT/POST.","commit_id":"a1a4a6c13e22d5ffe0e59e91d8f3727ae24a7c03"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e293e8ffb440de945241cdb1b3a7bcb4f6a8ac1e","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            \"rxtx_factor\": 2.0,"},{"line_number":175,"context_line":"            \"vcpus\": 2,"},{"line_number":176,"context_line":"            \"description\": \"test description\","},{"line_number":177,"context_line":"            \"extra_specs\": {}"},{"line_number":178,"context_line":"        }"},{"line_number":179,"context_line":"    }"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_ddb67bda","line":177,"range":{"start_line":177,"start_character":12,"end_line":177,"end_character":29},"updated":"2018-03-26 06:59:46.000000000","message":"better to add key1/key to consistent to others","commit_id":"a1a4a6c13e22d5ffe0e59e91d8f3727ae24a7c03"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"20c1451f2f84a9b40bb36f9c5ef5d34519525046","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            \"rxtx_factor\": 2.0,"},{"line_number":175,"context_line":"            \"vcpus\": 2,"},{"line_number":176,"context_line":"            \"description\": \"test description\","},{"line_number":177,"context_line":"            \"extra_specs\": {}"},{"line_number":178,"context_line":"        }"},{"line_number":179,"context_line":"    }"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_f98d5ed3","line":177,"range":{"start_line":177,"start_character":12,"end_line":177,"end_character":29},"in_reply_to":"bf659307_ce456372","updated":"2018-03-27 17:01:08.000000000","message":"So, adding a new microversion for just returning an always empty field would look bizarre, but given you\u0027d use the same microversion for both POST and GET verbs, I\u0027m fine.","commit_id":"a1a4a6c13e22d5ffe0e59e91d8f3727ae24a7c03"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"80c12425124e9a0537dce3dfb2e658197f65f21a","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            \"rxtx_factor\": 2.0,"},{"line_number":175,"context_line":"            \"vcpus\": 2,"},{"line_number":176,"context_line":"            \"description\": \"test description\","},{"line_number":177,"context_line":"            \"extra_specs\": {}"},{"line_number":178,"context_line":"        }"},{"line_number":179,"context_line":"    }"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_ce456372","line":177,"range":{"start_line":177,"start_character":12,"end_line":177,"end_character":29},"in_reply_to":"bf659307_ddb67bda","updated":"2018-03-26 09:04:20.000000000","message":"emm, this a specific response of only for creating, because current, we can\u0027t create flavor with a actual extra_spec[1], so, I leave it empty.\n\nAnd this empty extra_spec only for keeping consistent with other flavor api.\n\n[1] https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/flavor_manage.py#L100-L111","commit_id":"a1a4a6c13e22d5ffe0e59e91d8f3727ae24a7c03"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bd432f3629dfdb05688c19820bf4d9641bcc5bc2","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            \"rxtx_factor\": 1.0,"},{"line_number":210,"context_line":"            \"description\": \"updated description\","},{"line_number":211,"context_line":"            \"extra_specs\": {"},{"line_number":212,"context_line":"                    \"key1\": \"value1\","},{"line_number":213,"context_line":"                    \"key2\": \"value2\""},{"line_number":214,"context_line":"            }"},{"line_number":215,"context_line":"        }"},{"line_number":216,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_5946ca7e","line":213,"range":{"start_line":212,"start_character":20,"end_line":213,"end_character":36},"updated":"2018-03-27 17:03:18.000000000","message":"nit: fix the indentation here.","commit_id":"a1a4a6c13e22d5ffe0e59e91d8f3727ae24a7c03"}]}