)]}'
{"specs/rocky/approved/servers-ips-non-unique-network-names.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"69a448aa475ef1cf9580b3629f0ec73bca54480b","unresolved":false,"context_lines":[{"line_number":146,"context_line":"      }"},{"line_number":147,"context_line":"   }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Change schema in ``/servers/detail`` and ``servers/{server_id}`` to match"},{"line_number":150,"context_line":"ID-identified adresses response as in ``/servers/{server_id}/ips``."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":".. code-block:: javascript"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf659307_70ed78b5","line":149,"updated":"2018-04-01 22:24:30.000000000","message":"I think this is slightly backward, the mac_addr and type show up in the servers details today, but not in the /ips API response, so we should make that all consistent, which means making the /ips response match the /servers response.\n\nAlso, let\u0027s drop the OS-EXT-IPS prefix on the response body key while we\u0027re at it, we don\u0027t need those anymore as they are a carryover from the legacy v2.0 API extension days.","commit_id":"750a6b37655b2e806348c88c37590584a844c1f5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"43aa5ceb8a2dc4a142a034f1b35d761443339b22","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"   /servers/detail"},{"line_number":97,"context_line":"   /servers/{server_id}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Use Cases"},{"line_number":100,"context_line":"---------"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_e95f0170","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":0},"updated":"2018-04-06 05:35:42.000000000","message":"as we are doing these change, can we add  \"mac_addr\" and \"type\" fields for PUT and Rebuild server response also?\n\nCurrently these 2 APIs does not show these fields (not sure the reason why) but it is good if server representation in GET , PUT and Rebuild APIs is same.\n\n- https://github.com/openstack/nova/blob/107ad403d46c9d6961c5b15c68df0fa24014a832/nova/api/openstack/compute/servers.py#L717\n\n-https://github.com/openstack/nova/blob/107ad403d46c9d6961c5b15c68df0fa24014a832/nova/api/openstack/compute/servers.py#L966\n \n\u0027extend_address\u0027 arg adds the \"mac_addr\" and \"type\" in response. It is by true default(for GET, Details server APIs) and false explicitly for PUT and Rebuild server APIs.\n\n- https://github.com/openstack/nova/blob/107ad403d46c9d6961c5b15c68df0fa24014a832/nova/api/openstack/compute/views/addresses.py#L33","commit_id":"8c93ec9c60d97862f4125acf72be8a921ead14c3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e3ec5680ec98b3bb7a6bd089c0c1e5542829142","unresolved":false,"context_lines":[{"line_number":93,"context_line":"Server detail responses shall be updated acordingly as those contain"},{"line_number":94,"context_line":"similar adresses sections::"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"   /servers/detail"},{"line_number":97,"context_line":"   /servers/{server_id}"},{"line_number":98,"context_line":"   /servers/{server_id/action"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_9c356dde","line":96,"range":{"start_line":96,"start_character":3,"end_line":96,"end_character":18},"updated":"2018-06-15 20:53:51.000000000","message":"GET /servers/detail","commit_id":"f7be355e12acc1f6781024574e0f12564ab95a3a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e3ec5680ec98b3bb7a6bd089c0c1e5542829142","unresolved":false,"context_lines":[{"line_number":94,"context_line":"similar adresses sections::"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"   /servers/detail"},{"line_number":97,"context_line":"   /servers/{server_id}"},{"line_number":98,"context_line":"   /servers/{server_id/action"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_3c3219f4","line":97,"range":{"start_line":97,"start_character":3,"end_line":97,"end_character":23},"updated":"2018-06-15 20:53:51.000000000","message":"GET /servers/{server_id}\nPUT /servers/{server_id}","commit_id":"f7be355e12acc1f6781024574e0f12564ab95a3a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e3ec5680ec98b3bb7a6bd089c0c1e5542829142","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"   /servers/detail"},{"line_number":97,"context_line":"   /servers/{server_id}"},{"line_number":98,"context_line":"   /servers/{server_id/action"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Use Cases"},{"line_number":101,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_dc58c532","line":98,"range":{"start_line":98,"start_character":3,"end_line":98,"end_character":29},"updated":"2018-06-15 20:53:51.000000000","message":"POST /servers/{server_id}/action (rebuild)","commit_id":"f7be355e12acc1f6781024574e0f12564ab95a3a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e3ec5680ec98b3bb7a6bd089c0c1e5542829142","unresolved":false,"context_lines":[{"line_number":125,"context_line":"REST API impact"},{"line_number":126,"context_line":"---------------"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Four changes to API by new microversion:"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Change resource path from::"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_3c47794f","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":4},"updated":"2018-06-15 20:53:51.000000000","message":"Really 5 since you forgot PUT /servers/{server_id}","commit_id":"f7be355e12acc1f6781024574e0f12564ab95a3a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e3ec5680ec98b3bb7a6bd089c0c1e5542829142","unresolved":false,"context_lines":[{"line_number":159,"context_line":"      }"},{"line_number":160,"context_line":"   }"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Change schema in ``/servers/detail``,  ``servers/{server_id}`` and"},{"line_number":163,"context_line":"``/server/{server_id}/action`` to match ID-identified adresses"},{"line_number":164,"context_line":"response as in ``/servers/{server_id}/ips``."},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_fc7261b0","line":162,"updated":"2018-06-15 20:53:51.000000000","message":"This should be:\n\nGET /servers/detail\nGET /servers/{server_id}\nPUT /servers/{server_id}\nPOST /servers/{server_id}/action (rebuild)","commit_id":"f7be355e12acc1f6781024574e0f12564ab95a3a"}]}