)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8d60bc88b4831725507160f7785152ab7e07e852","unresolved":false,"context_lines":[{"line_number":9,"context_line":"It\u0027s important to note that, there are some differents between the"},{"line_number":10,"context_line":"blueprint proposed and the spec accepted:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- It has been indicated in the approved spec that the option"},{"line_number":13,"context_line":"  introduced will not be \u0027CONF.overhead_pin_set\u0027 but"},{"line_number":14,"context_line":"  \u0027CONF.cpu_share_set\u0027."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- Also instead of introducing a new policy HOST for"},{"line_number":17,"context_line":"  hw:emulator_threads_policy it has been indicated in the approved"},{"line_number":18,"context_line":"  spec that, the already defined policy SHARE in conjuncture with"},{"line_number":19,"context_line":"  CONF.cpu_share_set will make the guests emulator threads to float on"},{"line_number":20,"context_line":"  the whole set of pCPUs defined by CONF.cpu_share_set."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Related-to: bp overhead-pin-set"},{"line_number":23,"context_line":"Change-Id: Ia6a7be7e3abb0cd27752fdef3721a748848b3747"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f6a8fd7_a18178c5","line":20,"range":{"start_line":12,"start_character":0,"end_line":20,"end_character":55},"updated":"2018-04-24 14:25:04.000000000","message":"I was expecting to see some changes in the spec related to these notes. I\u0027ve pointed out the places in the spec that look like they should change for the first bullet, but does anything need to change for the second? Otherwise it looks like this is just renaming the spec and title to match the rocky blueprint.","commit_id":"828b70cd8f09d00e0fcfd38619dc23bd558cde53"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"18249b3a5e9a8c98c1428f6d528b613802fd1a7f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"It\u0027s important to note that, there are some differents between the"},{"line_number":10,"context_line":"blueprint proposed and the spec accepted:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- It has been indicated in the approved spec that the option"},{"line_number":13,"context_line":"  introduced will not be \u0027CONF.overhead_pin_set\u0027 but"},{"line_number":14,"context_line":"  \u0027CONF.cpu_share_set\u0027."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- Also instead of introducing a new policy HOST for"},{"line_number":17,"context_line":"  hw:emulator_threads_policy it has been indicated in the approved"},{"line_number":18,"context_line":"  spec that, the already defined policy SHARE in conjuncture with"},{"line_number":19,"context_line":"  CONF.cpu_share_set will make the guests emulator threads to float on"},{"line_number":20,"context_line":"  the whole set of pCPUs defined by CONF.cpu_share_set."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Related-to: bp overhead-pin-set"},{"line_number":23,"context_line":"Change-Id: Ia6a7be7e3abb0cd27752fdef3721a748848b3747"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f6a8fd7_28dd2edf","line":20,"range":{"start_line":12,"start_character":0,"end_line":20,"end_character":55},"in_reply_to":"9f6a8fd7_a18178c5","updated":"2018-04-25 15:16:52.000000000","message":"There is nothing to change in the spec. I just wanted to indicate the differences there are between the description in launchpad blueprint and the current spec.\n\nI fixed the commit message, the option is well cpu_shared_set.","commit_id":"828b70cd8f09d00e0fcfd38619dc23bd558cde53"}],"specs/rocky/approved/libvirt-emulator-threads-policy.rst":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e672fa16220eb79f64b3b746b970839b1b353f5f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Libvirt driver emulator threads placement policy"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"https://blueprints.launchpad.net/nova/+spec/overhead-pin-set"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f6a8fd7_9ef99d4e","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":48},"updated":"2018-04-19 02:43:08.000000000","message":"It should also be modified.\n\n  Overhead option to differ hypervisor process on a global set of pCPUs","commit_id":"841ca8a42a1ac75c2ad23d9286dd26c2b2a0fa62"}],"specs/rocky/approved/overhead-pin-set.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8d60bc88b4831725507160f7785152ab7e07e852","unresolved":false,"context_lines":[{"line_number":42,"context_line":"configuration of a compute node with regards to CPU resource inventory"},{"line_number":43,"context_line":"as well as make the quantitative tracking of dedicated CPU resources"},{"line_number":44,"context_line":"consistent with the tracking of shared CPU resources via the placement"},{"line_number":45,"context_line":"API, introduces a CONF option ``cpu_shared_set`` which stores a pinset"},{"line_number":46,"context_line":"string that indicates the physical processors that should be used for"},{"line_number":47,"context_line":"the ``VCPU`` resource requests."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f6a8fd7_0131445a","line":45,"range":{"start_line":45,"start_character":32,"end_line":45,"end_character":46},"updated":"2018-04-24 14:25:04.000000000","message":"cpu_share_set?","commit_id":"828b70cd8f09d00e0fcfd38619dc23bd558cde53"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8d60bc88b4831725507160f7785152ab7e07e852","unresolved":false,"context_lines":[{"line_number":52,"context_line":"extra-specs ``hw:emulator_threads_policy\u003dshare``."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"It is has noted that, the ``hw:emulator_threads_policy\u003dshare`` already"},{"line_number":55,"context_line":"exists but its default behavior where ``CONF.cpu_shared_set`` is not"},{"line_number":56,"context_line":"configured on host will remain the same, meaning that the emulator"},{"line_number":57,"context_line":"threads will float on the set of pCPUs dedicated for the guest. As for"},{"line_number":58,"context_line":"``hw:emulator_threads_policy\u003disolate`` its behavior will remain the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f6a8fd7_614120a9","line":55,"range":{"start_line":55,"start_character":45,"end_line":55,"end_character":59},"updated":"2018-04-24 14:25:04.000000000","message":"cpu_share_set","commit_id":"828b70cd8f09d00e0fcfd38619dc23bd558cde53"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8d60bc88b4831725507160f7785152ab7e07e852","unresolved":false,"context_lines":[{"line_number":66,"context_line":"------------"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"An alternative would be to always pin emulator threads on"},{"line_number":69,"context_line":"``CONF.cpu_shared_set``. It has been noted that, removing the actual"},{"line_number":70,"context_line":"flexibility provided to users to isolate guest emulator threads on an"},{"line_number":71,"context_line":"dedicated pCPU or let the guest emulator threads floating across the"},{"line_number":72,"context_line":"whole set of pCPUs dedicated for guest are still valid option and we"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f6a8fd7_4142dcac","line":69,"range":{"start_line":69,"start_character":7,"end_line":69,"end_character":21},"updated":"2018-04-24 14:25:04.000000000","message":"cpu_share_set","commit_id":"828b70cd8f09d00e0fcfd38619dc23bd558cde53"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8d60bc88b4831725507160f7785152ab7e07e852","unresolved":false,"context_lines":[{"line_number":97,"context_line":"---------------------"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"For end users, using option ``emulator_threads_policy\u003dshare`` with"},{"line_number":100,"context_line":"hosts have ``CONF.cpu_shared_set`` configured is going to improve the"},{"line_number":101,"context_line":"latency of guests running sensitive workloads."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f6a8fd7_a10c1894","line":100,"range":{"start_line":100,"start_character":18,"end_line":100,"end_character":32},"updated":"2018-04-24 14:25:04.000000000","message":"cpu_share_set","commit_id":"828b70cd8f09d00e0fcfd38619dc23bd558cde53"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8d60bc88b4831725507160f7785152ab7e07e852","unresolved":false,"context_lines":[{"line_number":138,"context_line":"Work Items"},{"line_number":139,"context_line":"----------"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"* Introducing ``CONF.compute.cpu_shared_set`` option for compute nodes"},{"line_number":142,"context_line":"* Configuring guest to pin its emulator threads on the"},{"line_number":143,"context_line":"  ``CONF.compute.cpu_shared_set`` when"},{"line_number":144,"context_line":"  ``emulator_threads_policy\u003dshare``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f6a8fd7_c10fcc85","line":141,"range":{"start_line":141,"start_character":29,"end_line":141,"end_character":43},"updated":"2018-04-24 14:25:04.000000000","message":"cpu_share_set","commit_id":"828b70cd8f09d00e0fcfd38619dc23bd558cde53"}]}