)]}'
{"specs/stein/approved/local-disk-serial-numbers.rst":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7cd976b8c9359c745c6eb62fce9c3f9e4567f666","unresolved":false,"context_lines":[{"line_number":67,"context_line":"driver, which may also be of use to other virt drivers."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"All disks attached to an instance, except config disks, have a block device"},{"line_number":70,"context_line":"mapping, which has a persistent uuid. We will present this uuid to the"},{"line_number":71,"context_line":"guest as the serial number of local disks. For volumes we will continue to"},{"line_number":72,"context_line":"present volume id as we do currently."},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_8a8c542f","line":70,"range":{"start_line":70,"start_character":32,"end_line":70,"end_character":36},"updated":"2018-08-28 22:09:43.000000000","message":"This is the first mention of \"uuid\". Everything preceding this says \"serial number\". It should be made clear up front (if it is in fact the case) that we\u0027re using a UUID as a serial number; and I\u0027m sort of curious how we\u0027re expecting that to work every time. Because, like, lots of disks might have serial numbers that *aren\u0027t* UUIDs, right?","commit_id":"1c0d165e13e5b8c99ea46b95d14bf1d508f2ddd7"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ff8a16bf2ec6cc916e20626dd1a29b508444ed86","unresolved":false,"context_lines":[{"line_number":67,"context_line":"driver, which may also be of use to other virt drivers."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"All disks attached to an instance, except config disks, have a block device"},{"line_number":70,"context_line":"mapping, which has a persistent uuid. We will present this uuid to the"},{"line_number":71,"context_line":"guest as the serial number of local disks. For volumes we will continue to"},{"line_number":72,"context_line":"present volume id as we do currently."},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_382fd63f","line":70,"range":{"start_line":70,"start_character":32,"end_line":70,"end_character":36},"in_reply_to":"3f79a3b5_51154c48","updated":"2018-09-06 20:52:53.000000000","message":"Yah, cool, it\u0027s just reading this out of nowhere made it sound like I was now gonna be allowed/required to push my disk\u0027s actual serial number (which isn\u0027t necessarily a UUID) into nova\u0027s awareness. Until I got to the bdm.uuid bit, where now I\u0027m like, okay, this has nothing to do with the disk\u0027s actual serial number.\n\nThanks for the clarification.","commit_id":"1c0d165e13e5b8c99ea46b95d14bf1d508f2ddd7"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"83ff25292fa29f7a6262065df10702a407f3a1e8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"driver, which may also be of use to other virt drivers."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"All disks attached to an instance, except config disks, have a block device"},{"line_number":70,"context_line":"mapping, which has a persistent uuid. We will present this uuid to the"},{"line_number":71,"context_line":"guest as the serial number of local disks. For volumes we will continue to"},{"line_number":72,"context_line":"present volume id as we do currently."},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_51154c48","line":70,"range":{"start_line":70,"start_character":32,"end_line":70,"end_character":36},"in_reply_to":"3f79a3b5_5e8d89d1","updated":"2018-08-31 10:32:21.000000000","message":"This is the current state of affairs:\n\n\"All disks attached to an instance, except config disks, have a block device mapping, which has a persistent uuid.\"\n\nThis is the proposed change:\n\n\"We will present this uuid to the guest as the serial number of local disks.\"\n\nSo this proposes to use the existing bdm.uuid as a serial number, because bdm.uuid meets the criteria for a serial number described on lines 52-57. It\u0027s not mentioned prior to this because it\u0027s part of the implementation. It\u0027s not fundamental to the design that it must be bdm.uuid, but it\u0027s a good choice.","commit_id":"1c0d165e13e5b8c99ea46b95d14bf1d508f2ddd7"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"2bee1aa97c842b3c96fb0a13f133b14f53e23457","unresolved":false,"context_lines":[{"line_number":67,"context_line":"driver, which may also be of use to other virt drivers."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"All disks attached to an instance, except config disks, have a block device"},{"line_number":70,"context_line":"mapping, which has a persistent uuid. We will present this uuid to the"},{"line_number":71,"context_line":"guest as the serial number of local disks. For volumes we will continue to"},{"line_number":72,"context_line":"present volume id as we do currently."},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_5e8d89d1","line":70,"range":{"start_line":70,"start_character":32,"end_line":70,"end_character":36},"in_reply_to":"3f79a3b5_8a8c542f","updated":"2018-08-29 17:56:02.000000000","message":"So this is the uuid of the disk BDM and not some uuid of the local disk itself ... and that uuid doesn\u0027t change if the local disk is detached and reattached to the guest?","commit_id":"1c0d165e13e5b8c99ea46b95d14bf1d508f2ddd7"}]}