)]}'
{"specs/stein/approved/disallow-isolcpus-with-overcommit-vcpus.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"eb8589e4b6cbcd126fdc52160d80adf6b1b5bd28","unresolved":false,"context_lines":[{"line_number":68,"context_line":"In addition, we should be ensure the range of cores used for"},{"line_number":69,"context_line":":doc:`emulator thread pools"},{"line_number":70,"context_line":"\u003c../../pike/implemented/libvirt-emulator-threads-policy\u003e`,"},{"line_number":71,"context_line":"defined with nova\u0027s ``cpu_shared_set`` config,"},{"line_number":72,"context_line":"do not overlap with those defined ``isolcpus``"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"We should also extend this to include all non-realtime instances."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_9e5dd617","line":71,"range":{"start_line":71,"start_character":22,"end_line":71,"end_character":36},"updated":"2018-09-18 16:38:38.000000000","message":"this is not currecnlty a thing right. this will be introduced with the standardise cpu tacking in placment spec.","commit_id":"6113391ec4da88044e3385f68af24ee6597efeb8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ea8171068919a58f3212de279e798342dd5e3edb","unresolved":false,"context_lines":[{"line_number":68,"context_line":"In addition, we should be ensure the range of cores used for"},{"line_number":69,"context_line":":doc:`emulator thread pools"},{"line_number":70,"context_line":"\u003c../../pike/implemented/libvirt-emulator-threads-policy\u003e`,"},{"line_number":71,"context_line":"defined with nova\u0027s ``cpu_shared_set`` config,"},{"line_number":72,"context_line":"do not overlap with those defined ``isolcpus``"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"We should also extend this to include all non-realtime instances."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_70081726","line":71,"range":{"start_line":71,"start_character":22,"end_line":71,"end_character":36},"in_reply_to":"3f79a3b5_9e5dd617","updated":"2018-09-19 08:54:32.000000000","message":"Nope, it\u0027s a thing that Sahid introduce in [1]\n\n[1] http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/libvirt-emulator-threads-policy.html","commit_id":"6113391ec4da88044e3385f68af24ee6597efeb8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"eb8589e4b6cbcd126fdc52160d80adf6b1b5bd28","unresolved":false,"context_lines":[{"line_number":96,"context_line":"will be modified to add ``isolcpus`` awareness."},{"line_number":97,"context_line":"Where ``cpu_shared_set`` overlaps with ``isolcpus``,"},{"line_number":98,"context_line":"nova should refuse to start."},{"line_number":99,"context_line":"In addition, where an instance with overcommitted CPUs is requested"},{"line_number":100,"context_line":"against a host where ``vcpu_pin_set`` overlaps with ``isolcpus``"},{"line_number":101,"context_line":"the request will be rejected."},{"line_number":102,"context_line":"Finally, where an instance with dedicated CPUs is requested"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_9e8b9667","line":99,"range":{"start_line":99,"start_character":22,"end_line":99,"end_character":54},"updated":"2018-09-18 16:38:38.000000000","message":"an instance cannot over commit against itself as such this phasing is a little imprecises as the cpus are not over commited beacuse the instance requirested it.  \n\ni would replace the with \"instance with hw:cpu_policy\u003dshared\"","commit_id":"6113391ec4da88044e3385f68af24ee6597efeb8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ea8171068919a58f3212de279e798342dd5e3edb","unresolved":false,"context_lines":[{"line_number":96,"context_line":"will be modified to add ``isolcpus`` awareness."},{"line_number":97,"context_line":"Where ``cpu_shared_set`` overlaps with ``isolcpus``,"},{"line_number":98,"context_line":"nova should refuse to start."},{"line_number":99,"context_line":"In addition, where an instance with overcommitted CPUs is requested"},{"line_number":100,"context_line":"against a host where ``vcpu_pin_set`` overlaps with ``isolcpus``"},{"line_number":101,"context_line":"the request will be rejected."},{"line_number":102,"context_line":"Finally, where an instance with dedicated CPUs is requested"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_f013c757","line":99,"range":{"start_line":99,"start_character":22,"end_line":99,"end_character":54},"in_reply_to":"3f79a3b5_9e8b9667","updated":"2018-09-19 08:54:32.000000000","message":"Ack, I\u0027ll say non-dedicated cores (which is what I wanted to say the first day)","commit_id":"6113391ec4da88044e3385f68af24ee6597efeb8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"eb8589e4b6cbcd126fdc52160d80adf6b1b5bd28","unresolved":false,"context_lines":[{"line_number":110,"context_line":"Alternatives"},{"line_number":111,"context_line":"------------"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"- Nova could simply refuse to start"},{"line_number":114,"context_line":"  if ``vcpu_pin_set`` overlaps with ``isolcpus``."},{"line_number":115,"context_line":"  However, ``isolcpus`` is actually useful for realtime instances."},{"line_number":116,"context_line":"  As such, this is not a viable option."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"- As always, doing nothing is an option."},{"line_number":119,"context_line":"  This requires no work from the nova side,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_fed72a4e","line":116,"range":{"start_line":113,"start_character":2,"end_line":116,"end_character":39},"updated":"2018-09-18 16:38:38.000000000","message":"if the standarised cpu spec is merged then this would be more viable it we allowed the pcpu pin set to over lap but not the shared pinset","commit_id":"6113391ec4da88044e3385f68af24ee6597efeb8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ea8171068919a58f3212de279e798342dd5e3edb","unresolved":false,"context_lines":[{"line_number":110,"context_line":"Alternatives"},{"line_number":111,"context_line":"------------"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"- Nova could simply refuse to start"},{"line_number":114,"context_line":"  if ``vcpu_pin_set`` overlaps with ``isolcpus``."},{"line_number":115,"context_line":"  However, ``isolcpus`` is actually useful for realtime instances."},{"line_number":116,"context_line":"  As such, this is not a viable option."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"- As always, doing nothing is an option."},{"line_number":119,"context_line":"  This requires no work from the nova side,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_904b735d","line":116,"range":{"start_line":113,"start_character":2,"end_line":116,"end_character":39},"in_reply_to":"3f79a3b5_fed72a4e","updated":"2018-09-19 08:54:32.000000000","message":"Very good point. I\u0027ll stick that in. Personally, I would like to deny any overlap and request people use the \u0027no_balance_cores\u0027 option above. However, I\u0027m not bold enough to force people to validate this when they haven\u0027t done so already :)","commit_id":"6113391ec4da88044e3385f68af24ee6597efeb8"}]}