)]}'
{"specs/stein/approved/alloc-candidates-in-tree.rst":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1fbbf1bca63ca07fec42e93ad6ce1ba2445c41c4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"However, ``GET /allocation_candidates`` doesn\u0027t support the ``in_tree`` query"},{"line_number":26,"context_line":"parameter to filter the allocation candidates by resource tree. This results"},{"line_number":27,"context_line":"in inefficient post-processing in some cases where the caller has already"},{"line_number":28,"context_line":"selected the resource provider candidates before calling that API."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_75c0024b","line":28,"range":{"start_line":28,"start_character":31,"end_line":28,"end_character":41},"updated":"2018-09-19 13:57:57.000000000","message":"tree","commit_id":"d6cb313f4560674eaa981a7b87b9c4bf83f84ad8"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"0213f3aa191c25dbd59feb08ac4e9ed31902db51","unresolved":false,"context_lines":[{"line_number":25,"context_line":"However, ``GET /allocation_candidates`` doesn\u0027t support the ``in_tree`` query"},{"line_number":26,"context_line":"parameter to filter the allocation candidates by resource tree. This results"},{"line_number":27,"context_line":"in inefficient post-processing in some cases where the caller has already"},{"line_number":28,"context_line":"selected the resource provider candidates before calling that API."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_be82effd","line":28,"range":{"start_line":28,"start_character":31,"end_line":28,"end_character":41},"in_reply_to":"3f79a3b5_75c0024b","updated":"2018-09-20 01:07:50.000000000","message":"Done","commit_id":"d6cb313f4560674eaa981a7b87b9c4bf83f84ad8"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1fbbf1bca63ca07fec42e93ad6ce1ba2445c41c4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"``GET /allocation_candidates`` API."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"We would solve the same problem for cases of live migration to a specified"},{"line_number":48,"context_line":"host and rebuilding an instance on the same host."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Proposed change"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_b578da2a","line":48,"updated":"2018-09-19 13:57:57.000000000","message":"++","commit_id":"d6cb313f4560674eaa981a7b87b9c4bf83f84ad8"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1fbbf1bca63ca07fec42e93ad6ce1ba2445c41c4","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    GET /allocation_candidates?resources\u003dVCPU:1,DISK_GB:50\u0026in_tree\u003d{numa1_1_uuid}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"would return the same result."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Alternatives"},{"line_number":103,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_75a3229c","line":100,"updated":"2018-09-19 13:57:57.000000000","message":"++","commit_id":"d6cb313f4560674eaa981a7b87b9c4bf83f84ad8"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1fbbf1bca63ca07fec42e93ad6ce1ba2445c41c4","unresolved":false,"context_lines":[{"line_number":136,"context_line":"------------------"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Queries to the database will see a moderate increase in complexity but existing"},{"line_number":139,"context_line":"table indexes should handle this with aplomb."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Other deployer impact"},{"line_number":142,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_5572a613","line":139,"updated":"2018-09-19 13:57:57.000000000","message":"I think we\u0027ll probably see a performance *improvement* with this. The database queries will be basically equivalent speed-wise (perhaps even faster actually) but we\u0027ll have a lot less data to process \u0026 package on the server side, less to send across the wire, less to unpack \u0026 process on the client side.","commit_id":"d6cb313f4560674eaa981a7b87b9c4bf83f84ad8"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"0213f3aa191c25dbd59feb08ac4e9ed31902db51","unresolved":false,"context_lines":[{"line_number":136,"context_line":"------------------"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Queries to the database will see a moderate increase in complexity but existing"},{"line_number":139,"context_line":"table indexes should handle this with aplomb."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Other deployer impact"},{"line_number":142,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_fe086791","line":139,"in_reply_to":"3f79a3b5_5572a613","updated":"2018-09-20 01:07:50.000000000","message":"Good point. Updated this part.","commit_id":"d6cb313f4560674eaa981a7b87b9c4bf83f84ad8"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1fbbf1bca63ca07fec42e93ad6ce1ba2445c41c4","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Work Items"},{"line_number":167,"context_line":"----------"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"* Update the ``ResourceProviderList.get_all_by_filters`` and"},{"line_number":170,"context_line":"  ``AllocationCandidates.get_by_requests`` methods to change the database"},{"line_number":171,"context_line":"  queries to filter on the specified provider tree."},{"line_number":172,"context_line":"* Update the placement API handlers for ``GET /allocation_candidates`` in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_95559e52","line":169,"range":{"start_line":169,"start_character":13,"end_line":169,"end_character":56},"updated":"2018-09-19 13:57:57.000000000","message":"Why this one? in_tree is already implemented here.","commit_id":"d6cb313f4560674eaa981a7b87b9c4bf83f84ad8"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"0213f3aa191c25dbd59feb08ac4e9ed31902db51","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Work Items"},{"line_number":167,"context_line":"----------"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"* Update the ``ResourceProviderList.get_all_by_filters`` and"},{"line_number":170,"context_line":"  ``AllocationCandidates.get_by_requests`` methods to change the database"},{"line_number":171,"context_line":"  queries to filter on the specified provider tree."},{"line_number":172,"context_line":"* Update the placement API handlers for ``GET /allocation_candidates`` in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_fe8ce735","line":169,"range":{"start_line":169,"start_character":13,"end_line":169,"end_character":56},"in_reply_to":"3f79a3b5_95559e52","updated":"2018-09-20 01:07:50.000000000","message":"Removed.","commit_id":"d6cb313f4560674eaa981a7b87b9c4bf83f84ad8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b9a9e1d32806c6a0f66a551a61862593e86769b3","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    GET /allocation_candidates?resources\u003dVCPU:1,DISK_GB:50\u0026in_tree\u003d{numa1_1_uuid}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"would return the same result."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Alternatives"},{"line_number":103,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_eed80025","line":100,"updated":"2018-10-23 21:56:36.000000000","message":"nit: well, except for numa1_2 (so it would result in candidates 1 and 3 above)","commit_id":"8ba67f69660651e2da38c86f4632e803ce7b4b00"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d69cadc16f7e86431d5c1fc7772ac24414780123","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    GET /allocation_candidates?resources\u003dVCPU:1,DISK_GB:50\u0026in_tree\u003d{numa1_1_uuid}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"would return the same result."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Alternatives"},{"line_number":103,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_90c3178d","line":100,"in_reply_to":"3f79a3b5_eed80025","updated":"2018-11-14 08:17:18.000000000","message":"right 2 and 4 would be elinated as they are not subtrees of numa1_1\n\nbuti get the point that was trying to be made is that the in_tree paramater can be appled to the root node or a subtree and the filtering works the same way. so ya its a nit but i would be fine with not carlifing this but if it is re proposed then it woudl be a nice nit to adress","commit_id":"8ba67f69660651e2da38c86f4632e803ce7b4b00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b9a9e1d32806c6a0f66a551a61862593e86769b3","unresolved":false,"context_lines":[{"line_number":130,"context_line":"Other end user impact"},{"line_number":131,"context_line":"---------------------"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"None."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Performance Impact"},{"line_number":136,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_ae05286a","line":133,"updated":"2018-10-23 21:56:36.000000000","message":"Similar to https://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-list, the osc-placement CLI for allocation candidates could include an --in-tree option:\n\nhttps://docs.openstack.org/osc-placement/latest/cli/index.html#allocation-candidate-list","commit_id":"8ba67f69660651e2da38c86f4632e803ce7b4b00"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d69cadc16f7e86431d5c1fc7772ac24414780123","unresolved":false,"context_lines":[{"line_number":130,"context_line":"Other end user impact"},{"line_number":131,"context_line":"---------------------"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"None."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Performance Impact"},{"line_number":136,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_50425f10","line":133,"in_reply_to":"3f79a3b5_ae05286a","updated":"2018-11-14 08:17:18.000000000","message":"yes that makes sense thogh i assume this is also a nit given your +2","commit_id":"8ba67f69660651e2da38c86f4632e803ce7b4b00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b9a9e1d32806c6a0f66a551a61862593e86769b3","unresolved":false,"context_lines":[{"line_number":165,"context_line":"Primary assignee:"},{"line_number":166,"context_line":"    Tetsuro Nakamura (nakamura.tetsuro@lab.ntt.co.jp)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Work Items"},{"line_number":169,"context_line":"----------"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"* Update the ``AllocationCandidates.get_by_requests`` method to change the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_ae53e86d","line":168,"updated":"2018-10-23 21:56:36.000000000","message":"OK so this is just the placement API change, nothing to do with leveraging this in nova. I guess that could be done later as follow ups to the aforementioned bug 1777591 and bug 1750623.","commit_id":"8ba67f69660651e2da38c86f4632e803ce7b4b00"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"42e1d33f8084a74b5ff53f58040f493e6446d4be","unresolved":false,"context_lines":[{"line_number":172,"context_line":"  database queries to filter on the specified provider tree."},{"line_number":173,"context_line":"* Update the placement API handlers for ``GET /allocation_candidates`` in"},{"line_number":174,"context_line":"  a new microversion to pass the new ``in_tree`` parameter to the methods"},{"line_number":175,"context_line":"  changed in the steps above, including input validation adjustments."},{"line_number":176,"context_line":"* Add functional tests of the modified database queries."},{"line_number":177,"context_line":"* Add gabbi tests that express the new queries, both successful queries and"},{"line_number":178,"context_line":"  those that should cause a 400 response."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_50bd7f02","line":175,"updated":"2018-11-14 08:16:23.000000000","message":"So is the plan to apply this only to extracted placement since the in-tree placement is frozen? If so, that would mean we can\u0027t test this until we have a way to do functional testing in nova against the new placement code.","commit_id":"8ba67f69660651e2da38c86f4632e803ce7b4b00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bae805506d886da6bd3d9b9fcc1117922eca4b73","unresolved":false,"context_lines":[{"line_number":172,"context_line":"  database queries to filter on the specified provider tree."},{"line_number":173,"context_line":"* Update the placement API handlers for ``GET /allocation_candidates`` in"},{"line_number":174,"context_line":"  a new microversion to pass the new ``in_tree`` parameter to the methods"},{"line_number":175,"context_line":"  changed in the steps above, including input validation adjustments."},{"line_number":176,"context_line":"* Add functional tests of the modified database queries."},{"line_number":177,"context_line":"* Add gabbi tests that express the new queries, both successful queries and"},{"line_number":178,"context_line":"  those that should cause a 400 response."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_506b3f86","line":175,"in_reply_to":"3f79a3b5_50bd7f02","updated":"2018-11-14 08:20:31.000000000","message":"\u003e So is the plan to apply this only to extracted placement since the in-tree placement is frozen?\n\nI assume so yes.\n\n\u003e If so, that would mean we can\u0027t test this until we have a way to do functional testing in nova against the new placement code.\n\nThat\u0027s being worked on by gibi here:\n\nhttps://review.openstack.org/#/c/599551/\n\nand here:\n\nhttps://review.openstack.org/#/c/601458/\n\nLooks like the latter has stalled out a bit though, and I\u0027m not sure if the former will require changes after the alembic support is added to placement.","commit_id":"8ba67f69660651e2da38c86f4632e803ce7b4b00"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b9a9e1d32806c6a0f66a551a61862593e86769b3","unresolved":false,"context_lines":[{"line_number":199,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"* `Nested Resource Providers`_ spec"},{"line_number":202,"context_line":"* `Bug#1777591`_ reported in the launchpad"},{"line_number":203,"context_line":"* `Limiting Allocation Candidates`_ spec"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":".. _`Nested Resource Providers`: https://specs.openstack.org/openstack/nova-specs/specs/queens/approved/nested-resource-providers.html"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_8e4e2cc0","line":202,"updated":"2018-10-23 21:56:36.000000000","message":"Bug 1750623 is also related to this.","commit_id":"8ba67f69660651e2da38c86f4632e803ce7b4b00"}]}