)]}'
{"specs/stein/approved/device-discovery-policy-lib.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1cc59f6d2bfd0770cf6e954d5c751a65487ffaca","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    - pmem (persitent memory devices)"},{"line_number":42,"context_line":"    - vgpus (sriov and mdev based)"},{"line_number":43,"context_line":"    - pci/sriov devices (in a hypervior independnt way)"},{"line_number":44,"context_line":"    - usb (hyperviors have supported usb passhtrough for a long time)"},{"line_number":45,"context_line":"    - blk storage (local block storage can be useful for srach/cacheing workloads)"},{"line_number":46,"context_line":"    - fpgas (may not always be pcie based)"},{"line_number":47,"context_line":"        - should be extensible to whitelist device or slot but may be out of inital scope."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_21bc8cda","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":69},"updated":"2018-09-19 16:30:17.000000000","message":"Not entirely related, would wonder if this is something we seriously want to consider. I\u0027m trying to figure out who\u0027d possibly use this in a cloud environment","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c913de932834ceef232756f674d5c6d64af9d30b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    - pmem (persitent memory devices)"},{"line_number":42,"context_line":"    - vgpus (sriov and mdev based)"},{"line_number":43,"context_line":"    - pci/sriov devices (in a hypervior independnt way)"},{"line_number":44,"context_line":"    - usb (hyperviors have supported usb passhtrough for a long time)"},{"line_number":45,"context_line":"    - blk storage (local block storage can be useful for srach/cacheing workloads)"},{"line_number":46,"context_line":"    - fpgas (may not always be pcie based)"},{"line_number":47,"context_line":"        - should be extensible to whitelist device or slot but may be out of inital scope."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_8150002e","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":69},"in_reply_to":"3f79a3b5_21bc8cda","updated":"2018-09-19 16:57:28.000000000","message":"some fpgas are programed via usb jtag adapters.\nalso people have hacked around this in the past via pci passthouhgh of usb contolers so there are usecases.\neven if we dont support it in the libvirt driver i want\nthe schema to be able to handel them or have a way to describe usb devices even if we dont implement it.\n\nif we find we cant model usb devices then that likely means we have made a bad modeling choice in its design.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8ca9fa4438f863043f95ee00964669c57acc56af","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    - pmem (persitent memory devices)"},{"line_number":42,"context_line":"    - vgpus (sriov and mdev based)"},{"line_number":43,"context_line":"    - pci/sriov devices (in a hypervior independnt way)"},{"line_number":44,"context_line":"    - usb (hyperviors have supported usb passhtrough for a long time)"},{"line_number":45,"context_line":"    - blk storage (local block storage can be useful for srach/cacheing workloads)"},{"line_number":46,"context_line":"    - fpgas (may not always be pcie based)"},{"line_number":47,"context_line":"        - should be extensible to whitelist device or slot but may be out of inital scope."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_883ed226","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":69},"in_reply_to":"3f79a3b5_8150002e","updated":"2018-09-20 10:36:50.000000000","message":"\u003e if we find we cant model usb devices then that likely means we have\n \u003e made a bad modeling choice in its design.\n\nIf can\u0027t model it then that\u0027s bad design, yes, but that doesn\u0027t mean we _should_ model it :) That\u0027s the point I\u0027m trying to make.\n\n \u003e some fpgas are programed via usb jtag adapters.\n \u003e also people have hacked around this in the past via pci passthouhgh\n \u003e of usb contolers so there are usecases.\n \u003e even if we dont support it in the libvirt driver i want\n \u003e the schema to be able to handel them or have a way to describe usb\n \u003e devices even if we dont implement it.\n\nUm, yuck? I get this may be a use case but it really sounds like something we shouldn\u0027t actively pursue/highlight as a goal. Again, no problem with saying it\u0027s theoretically possible but it shouldn\u0027t be an active goal.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2020b786715e414eff46de5c97f4fdb3969db307","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    - blk storage (local block storage can be useful for srach/cacheing workloads)"},{"line_number":46,"context_line":"    - fpgas (may not always be pcie based)"},{"line_number":47,"context_line":"        - should be extensible to whitelist device or slot but may be out of inital scope."},{"line_number":48,"context_line":"    - cpu whitelisting."},{"line_number":49,"context_line":"        - pinned cpus set."},{"line_number":50,"context_line":"\t- shared/floating cpu set."},{"line_number":51,"context_line":"    - ... add comments for other device types i have missed."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"other usecases"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_1a7f3d18","line":50,"range":{"start_line":48,"start_character":0,"end_line":50,"end_character":27},"updated":"2018-09-21 23:02:16.000000000","message":"Yeah, if we\u0027re going here, we may as well talk about including the ability to tweak options (things like allocation_ratio, max_unit, etc.) for otherwise-automatically-reported inventories. Today we\u0027re dealing with a horrible mess wrt cpu/mem/disk allocation ratios on the compute rp, and still nothing we\u0027re doing to solve that is going to be useful when those resources are moved to nested or sharing providers. The need to be able to configure max_unit also came up recently [1] and is going to be subject to the same difficulties.\n\nSo if we could figure out a generic way to identify *any* resource, we could use the file to twiddle (almost) any aspect of it.\n\n[1] http://eavesdrop.openstack.org/irclogs/%23openstack-placement/%23openstack-placement.2018-09-20.log.html#t2018-09-20T14:11:59","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63584d2bd1c764c5fe5122b37b0ed53e2bbc5c2a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    - blk storage (local block storage can be useful for srach/cacheing workloads)"},{"line_number":46,"context_line":"    - fpgas (may not always be pcie based)"},{"line_number":47,"context_line":"        - should be extensible to whitelist device or slot but may be out of inital scope."},{"line_number":48,"context_line":"    - cpu whitelisting."},{"line_number":49,"context_line":"        - pinned cpus set."},{"line_number":50,"context_line":"\t- shared/floating cpu set."},{"line_number":51,"context_line":"    - ... add comments for other device types i have missed."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"other usecases"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_efee33b4","line":50,"range":{"start_line":48,"start_character":0,"end_line":50,"end_character":27},"in_reply_to":"3f79a3b5_1a7f3d18","updated":"2018-09-24 11:14:02.000000000","message":"yes i mentioned this in one of my comments to stephen\ni plan to allow setting the reseved values allocation ratios step seze ectra on the device pools","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1cc59f6d2bfd0770cf6e954d5c751a65487ffaca","unresolved":false,"context_lines":[{"line_number":54,"context_line":"--------------"},{"line_number":55,"context_line":"    - numa aware vSwitches."},{"line_number":56,"context_line":"    - bandwith based schduling."},{"line_number":57,"context_line":"    - numa afinity policy."},{"line_number":58,"context_line":"    - physnet associations."},{"line_number":59,"context_line":"    - trusted vf policy."},{"line_number":60,"context_line":"    - ... add comments here if there are others"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_a1cf3c7d","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":26},"updated":"2018-09-19 16:30:17.000000000","message":"I\u0027m guessing this won\u0027t be necessary as placement and its group_policy (+ future, even more granular options) could control this?","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2020b786715e414eff46de5c97f4fdb3969db307","unresolved":false,"context_lines":[{"line_number":54,"context_line":"--------------"},{"line_number":55,"context_line":"    - numa aware vSwitches."},{"line_number":56,"context_line":"    - bandwith based schduling."},{"line_number":57,"context_line":"    - numa afinity policy."},{"line_number":58,"context_line":"    - physnet associations."},{"line_number":59,"context_line":"    - trusted vf policy."},{"line_number":60,"context_line":"    - ... add comments here if there are others"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_dacb0549","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":26},"in_reply_to":"3f79a3b5_8827b212","updated":"2018-09-21 23:02:16.000000000","message":"I agree with Stephen, things like affinity policies should be the purview of flavors. We shouldn\u0027t try to overload this file this way, beyond allowing the operator to e.g. set up traits that may allow them to control affinities and similar aspects at the flavor level.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c913de932834ceef232756f674d5c6d64af9d30b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"--------------"},{"line_number":55,"context_line":"    - numa aware vSwitches."},{"line_number":56,"context_line":"    - bandwith based schduling."},{"line_number":57,"context_line":"    - numa afinity policy."},{"line_number":58,"context_line":"    - physnet associations."},{"line_number":59,"context_line":"    - trusted vf policy."},{"line_number":60,"context_line":"    - ... add comments here if there are others"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_e1369402","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":26},"in_reply_to":"3f79a3b5_a1cf3c7d","updated":"2018-09-19 16:57:28.000000000","message":"no this is need to allow expressing the numa affintiy policy for sriov devices which we have in the pci whitelist today.\nwe may be able to drop this in the future but for now its needed for parity.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63584d2bd1c764c5fe5122b37b0ed53e2bbc5c2a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"--------------"},{"line_number":55,"context_line":"    - numa aware vSwitches."},{"line_number":56,"context_line":"    - bandwith based schduling."},{"line_number":57,"context_line":"    - numa afinity policy."},{"line_number":58,"context_line":"    - physnet associations."},{"line_number":59,"context_line":"    - trusted vf policy."},{"line_number":60,"context_line":"    - ... add comments here if there are others"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_8f00df68","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":26},"in_reply_to":"3f79a3b5_dacb0549","updated":"2018-09-24 11:14:02.000000000","message":"i would agree that requesting numa affintiy should be done via flavor or image but it was added to the whitelist so again for parity we need to able to say this device pool or device allows strict/prefered/legacy affinity.\n\nif we are going to remove the current options i think we need to provide a migration path without parity lose.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8ca9fa4438f863043f95ee00964669c57acc56af","unresolved":false,"context_lines":[{"line_number":54,"context_line":"--------------"},{"line_number":55,"context_line":"    - numa aware vSwitches."},{"line_number":56,"context_line":"    - bandwith based schduling."},{"line_number":57,"context_line":"    - numa afinity policy."},{"line_number":58,"context_line":"    - physnet associations."},{"line_number":59,"context_line":"    - trusted vf policy."},{"line_number":60,"context_line":"    - ... add comments here if there are others"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_8827b212","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":26},"in_reply_to":"3f79a3b5_e1369402","updated":"2018-09-20 10:36:50.000000000","message":"Double no :) The reason we have the policy is because we want to say whether the PCI devices must be allocated from the same NUMA node as the CPUs. In the future work where we\u0027re tracking PCPUs (jaypipes\u0027 spec) and NUMA topologies (sylvainb\u0027s spec) in placement, I don\u0027t see why request groups wouldn\u0027t provide the exact same thing (e.g. parity)","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1cc59f6d2bfd0770cf6e954d5c751a65487ffaca","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    - config file format independent"},{"line_number":65,"context_line":"        - yaml (prefered)"},{"line_number":66,"context_line":"        - json (optional)"},{"line_number":67,"context_line":"        - toml (optional)"},{"line_number":68,"context_line":"        - config (optional)"},{"line_number":69,"context_line":"    - schema validation (one of)"},{"line_number":70,"context_line":"        - jsonschema (prefered)"},{"line_number":71,"context_line":"        - oslo.config (requires ini format)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_218fac23","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":27},"updated":"2018-09-19 16:30:17.000000000","message":"Um, can we stick with subsets of JSON, please? As seen with numa-aware vSwitches and things like the existing PCI whitelists, INI (and variants like TOML) break down for this stuff as you need some manner of nesting","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2020b786715e414eff46de5c97f4fdb3969db307","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    - config file format independent"},{"line_number":65,"context_line":"        - yaml (prefered)"},{"line_number":66,"context_line":"        - json (optional)"},{"line_number":67,"context_line":"        - toml (optional)"},{"line_number":68,"context_line":"        - config (optional)"},{"line_number":69,"context_line":"    - schema validation (one of)"},{"line_number":70,"context_line":"        - jsonschema (prefered)"},{"line_number":71,"context_line":"        - oslo.config (requires ini format)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_fafb6145","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":27},"in_reply_to":"3f79a3b5_0862c23e","updated":"2018-09-21 23:02:16.000000000","message":"I\u0027ll take the hard line on this one. We should pick *one and only one* format and stick to it. Remember, we\u0027re trying to specify a file that can be shared among all openstack (and possibly external?) services. So if we support four formats, each service needs to know how to parse four formats. Multiply by different programming languages the services could be written in. That\u0027s a big support matrix with all kinds of room for weird corner cases and bugs.\n\nWe should pick a format that gracefully handles arbitrary levels of nesting. That nixes oslo.config (the horribleness of attempting to describe dicts in [pci]passthrough_whitelist is one of the original motivators for this work) and INI.\n\nWe should pick a format that\u0027s universally understood by most languages, preferably one for which most languages already have a parser in their standard library.\n\nSo far JSON and XML both qualify, being the linguae francae of modern distributed services. I have a dislike for XML for bloat reasons, and JSON is what we\u0027re using throughout most of the rest of OpenStack anyway.\n\nAll of this to agree with Stephen that we should choose a subset of JSON. I have a strong preference for yaml because it does JSON cleanly in a human-readable way without the profusion of confusing punctuation.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c913de932834ceef232756f674d5c6d64af9d30b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    - config file format independent"},{"line_number":65,"context_line":"        - yaml (prefered)"},{"line_number":66,"context_line":"        - json (optional)"},{"line_number":67,"context_line":"        - toml (optional)"},{"line_number":68,"context_line":"        - config (optional)"},{"line_number":69,"context_line":"    - schema validation (one of)"},{"line_number":70,"context_line":"        - jsonschema (prefered)"},{"line_number":71,"context_line":"        - oslo.config (requires ini format)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_f352e711","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":27},"in_reply_to":"3f79a3b5_218fac23","updated":"2018-09-19 16:57:28.000000000","message":"nope.\n\nyaml text format will be used by default and as a reference but as long as it passes validation after its deserialsed then the file serialisation format is irrelevent. \n\nmy intent is to completly decople the serialisation used to represent the file on disk from the schema for the in memory representation.\n\nyaml will be the default but if i read in the config using pyyaml and then validate it and then serialise it with pytoml the toml file is a equally valid config.\n\nthe important point is we are standardising the scema which validates the in memory representation and on disk formt is left to the serialisers.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"a5ef9088f3e1da7441cf9e0ce05c22f4d66b98d7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    - config file format independent"},{"line_number":65,"context_line":"        - yaml (prefered)"},{"line_number":66,"context_line":"        - json (optional)"},{"line_number":67,"context_line":"        - toml (optional)"},{"line_number":68,"context_line":"        - config (optional)"},{"line_number":69,"context_line":"    - schema validation (one of)"},{"line_number":70,"context_line":"        - jsonschema (prefered)"},{"line_number":71,"context_line":"        - oslo.config (requires ini format)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_922186b8","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":27},"in_reply_to":"3f79a3b5_8fe77fe4","updated":"2018-09-27 19:52:24.000000000","message":"\u003e eric ok ill just reduce this to yaml\n \u003e \n \u003e but i think ye have both missed the point i was trying to make. the\n \u003e format on disk does not matter, i set yaml as perfered as it was\n \u003e the only format i planned to add support for. the reason the format\n \u003e on disk does not matter is that no validation will be prefromed\n \u003e against it.\n\nAnd I think that\u0027s what Eric was against. If other projects are going to be using the file, the validation should be done *on the file*, not on however Nova decides to represent its contents for itself. The file becomes the interface, and it needs to be bulletproof.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b00af29ad72c3707b2fd281d04728ea397528a05","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    - config file format independent"},{"line_number":65,"context_line":"        - yaml (prefered)"},{"line_number":66,"context_line":"        - json (optional)"},{"line_number":67,"context_line":"        - toml (optional)"},{"line_number":68,"context_line":"        - config (optional)"},{"line_number":69,"context_line":"    - schema validation (one of)"},{"line_number":70,"context_line":"        - jsonschema (prefered)"},{"line_number":71,"context_line":"        - oslo.config (requires ini format)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_fa8ad362","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":27},"in_reply_to":"3f79a3b5_922186b8","updated":"2018-10-01 16:05:44.000000000","message":"that would be the exact opisite of my design goal for this.\n\nthe intent was that in adtion to providing the schema validation this change would introduce common code that could be used to read the file into python object so no other project would need need to write that code.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8ca9fa4438f863043f95ee00964669c57acc56af","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    - config file format independent"},{"line_number":65,"context_line":"        - yaml (prefered)"},{"line_number":66,"context_line":"        - json (optional)"},{"line_number":67,"context_line":"        - toml (optional)"},{"line_number":68,"context_line":"        - config (optional)"},{"line_number":69,"context_line":"    - schema validation (one of)"},{"line_number":70,"context_line":"        - jsonschema (prefered)"},{"line_number":71,"context_line":"        - oslo.config (requires ini format)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_0862c23e","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":27},"in_reply_to":"3f79a3b5_f352e711","updated":"2018-09-20 10:36:50.000000000","message":"You need to deserialize to a particular format. INI supports only 2 levels by default. TOML supports more but it gets more and more convoluted as you go down. By suggesting we using a JSON subset, we don\u0027t have to worry about this issue and still allow some flexibility in how users configure this stuff [*].\n\n[*] Personally, I think OpenStack in general could do with less, not more, flexibility in how it can be configured, but that\u0027s neither here nor there.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"2b2a450fcd46ec55a9a89754535dfd337da9adfe","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    - config file format independent"},{"line_number":65,"context_line":"        - yaml (prefered)"},{"line_number":66,"context_line":"        - json (optional)"},{"line_number":67,"context_line":"        - toml (optional)"},{"line_number":68,"context_line":"        - config (optional)"},{"line_number":69,"context_line":"    - schema validation (one of)"},{"line_number":70,"context_line":"        - jsonschema (prefered)"},{"line_number":71,"context_line":"        - oslo.config (requires ini format)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_fafbb3bb","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":27},"in_reply_to":"3f79a3b5_fa8ad362","updated":"2018-10-01 16:09:20.000000000","message":"\u003e the intent was that in adtion to providing the schema validation\n \u003e this change would introduce common code that could be used to read\n \u003e the file into python object so no other project would need need to\n \u003e write that code.\n\nAh, if the API is at the code level and we expect/force other project to use this new library you\u0027re proposing, then yeah, it makes sense to not care about the file format. Though I still don\u0027t see a point in expending effort to support more than a single particular format.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63584d2bd1c764c5fe5122b37b0ed53e2bbc5c2a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    - config file format independent"},{"line_number":65,"context_line":"        - yaml (prefered)"},{"line_number":66,"context_line":"        - json (optional)"},{"line_number":67,"context_line":"        - toml (optional)"},{"line_number":68,"context_line":"        - config (optional)"},{"line_number":69,"context_line":"    - schema validation (one of)"},{"line_number":70,"context_line":"        - jsonschema (prefered)"},{"line_number":71,"context_line":"        - oslo.config (requires ini format)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_8fe77fe4","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":27},"in_reply_to":"3f79a3b5_fafb6145","updated":"2018-09-24 11:14:02.000000000","message":"eric ok ill just reduce this to yaml\n\nbut i think ye have both missed the point i was trying to make. the format on disk does not matter, i set yaml as perfered as it was the only format i planned to add support for. the reason the format on disk does not matter is that no validation will be prefromed against it. the file will be deserialsed into python objects/dicts and then that resulting datastructure will be validated using the scema.\n\njson, yaml and xml are all valid options.\ni intally plan on using pyyamml by the files created\nby using the default xml and json serilaser would be equally correct on disk formats.\n\nto the point of each service needing to parse multiple configs at least for the python based ones it is intended that that tooling will be provided as part of this spec so they dont have to implement it.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2020b786715e414eff46de5c97f4fdb3969db307","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        - toml (optional)"},{"line_number":68,"context_line":"        - config (optional)"},{"line_number":69,"context_line":"    - schema validation (one of)"},{"line_number":70,"context_line":"        - jsonschema (prefered)"},{"line_number":71,"context_line":"        - oslo.config (requires ini format)"},{"line_number":72,"context_line":"        - ovo (very verbose but automatically versioned)"},{"line_number":73,"context_line":"    - versioned"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_9af82d4b","line":70,"range":{"start_line":70,"start_character":10,"end_line":70,"end_character":31},"updated":"2018-09-21 23:02:16.000000000","message":"++","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1cc59f6d2bfd0770cf6e954d5c751a65487ffaca","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        - config (optional)"},{"line_number":69,"context_line":"    - schema validation (one of)"},{"line_number":70,"context_line":"        - jsonschema (prefered)"},{"line_number":71,"context_line":"        - oslo.config (requires ini format)"},{"line_number":72,"context_line":"        - ovo (very verbose but automatically versioned)"},{"line_number":73,"context_line":"    - versioned"},{"line_number":74,"context_line":"    - supports defaults."},{"line_number":75,"context_line":"    - supports field validation."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_41bbc8c2","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":56},"updated":"2018-09-19 16:30:17.000000000","message":"Not sure how ovo would fit into this? Something like os-acc or an newfangled os-dev library (if that\u0027s not already a thing)?","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c913de932834ceef232756f674d5c6d64af9d30b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        - config (optional)"},{"line_number":69,"context_line":"    - schema validation (one of)"},{"line_number":70,"context_line":"        - jsonschema (prefered)"},{"line_number":71,"context_line":"        - oslo.config (requires ini format)"},{"line_number":72,"context_line":"        - ovo (very verbose but automatically versioned)"},{"line_number":73,"context_line":"    - versioned"},{"line_number":74,"context_line":"    - supports defaults."},{"line_number":75,"context_line":"    - supports field validation."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_935a931b","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":56},"in_reply_to":"3f79a3b5_41bbc8c2","updated":"2018-09-19 16:57:28.000000000","message":"ovo would provide a way to model the schema as versioned python object and the serialised form of obj_to_primitve would provide the text representation.\n\novos are very verbose in this form however so json schema is proably the way to go. ovo would allow for native version migration which is why it is listed.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1cc59f6d2bfd0770cf6e954d5c751a65487ffaca","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    - versioned"},{"line_number":74,"context_line":"    - supports defaults."},{"line_number":75,"context_line":"    - supports field validation."},{"line_number":76,"context_line":"    - support config generation."},{"line_number":77,"context_line":"    - support code generation. (optional but desired)"},{"line_number":78,"context_line":"      support declareing ownership of the resouce. (e.g. which service owns this device nova vs cyborg vs ...)"},{"line_number":79,"context_line":"    - allow modling of placement providers."},{"line_number":80,"context_line":"    - allow declartion of resouce provider traits."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_01e630e8","line":77,"range":{"start_line":76,"start_character":0,"end_line":77,"end_character":53},"updated":"2018-09-19 16:30:17.000000000","message":"Are these necessary goals? I think generating a sample config file is going to be an arduous and likely unnecessary endevour. Also, what would code generation involve?","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"88ea7882d7ea143715b5751cc4b4f298aa961586","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    - supports defaults."},{"line_number":75,"context_line":"    - supports field validation."},{"line_number":76,"context_line":"    - support config generation."},{"line_number":77,"context_line":"    - support code generation. (optional but desired)"},{"line_number":78,"context_line":"      support declareing ownership of the resouce. (e.g. which service owns this device nova vs cyborg vs ...)"},{"line_number":79,"context_line":"    - allow modling of placement providers."},{"line_number":80,"context_line":"    - allow declartion of resouce provider traits."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_dee80b17","line":77,"updated":"2018-09-20 00:38:03.000000000","message":"sorry miss read this partly.\nsupport code generation is a sideffect of chosing json schema. both ovo and oslo.config\nwould require use to descibe the schema via python objects already. in the jsonschema case you can code gen the classes that are modeled by the schema automatically.\n\nsupporting config generation in my my mind was more of a cli thing.\nwe can easily stub out a \"empty\" config with just the version in and an empty set for devices and device pools. give a set of existing configs we can also relitivly easilly read them in useing the existing config parsing code and then output new representation e.g. convert the exsiting pci whitelist to the new form.\n\nwhat i would like to get to eventrually is a crudini style cli where by you can do the following workflow\n\nopenstack dev config create [--from-file]+ [--to-file] [--input-format\u003dini] [--output-format\u003dyaml]\nopenstack dev config add device --file --name --bus [--address-type] [--address] ...\nopenstack dev config add device-pool --file ...\nopenstack dev config validate --file\n\nthe standard crud ops to add, delete, list and show would be supported\nfor devices and device pools and the create and validate comands can be\nused when migrating. we might also want to have an openstack dev config upgrade\nto support a schema upgrade by reading in an old config and writing the new form\nor a status command to see if there is some manual operation that needs to be done.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c913de932834ceef232756f674d5c6d64af9d30b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    - versioned"},{"line_number":74,"context_line":"    - supports defaults."},{"line_number":75,"context_line":"    - supports field validation."},{"line_number":76,"context_line":"    - support config generation."},{"line_number":77,"context_line":"    - support code generation. (optional but desired)"},{"line_number":78,"context_line":"      support declareing ownership of the resouce. (e.g. which service owns this device nova vs cyborg vs ...)"},{"line_number":79,"context_line":"    - allow modling of placement providers."},{"line_number":80,"context_line":"    - allow declartion of resouce provider traits."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_9388536b","line":77,"range":{"start_line":76,"start_character":0,"end_line":77,"end_character":53},"in_reply_to":"3f79a3b5_01e630e8","updated":"2018-09-19 16:57:28.000000000","message":"it would be trival with both ovo and oslo.config as it just invovles creating a default config in memory and serialsing it.\n\njson schema also has a way to do this but it takes one more step to explcitly set the defaults.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1cc59f6d2bfd0770cf6e954d5c751a65487ffaca","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    - allow modling of placement providers."},{"line_number":80,"context_line":"    - allow declartion of resouce provider traits."},{"line_number":81,"context_line":"    - allow declartion of resouce classes."},{"line_number":82,"context_line":"    - allow policy to expressed decoupled form device whitelisting or pooling."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"outputs"},{"line_number":85,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_41098892","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":78},"updated":"2018-09-19 16:30:17.000000000","message":"Not sure what this means :)","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"88ea7882d7ea143715b5751cc4b4f298aa961586","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    - allow modling of placement providers."},{"line_number":80,"context_line":"    - allow declartion of resouce provider traits."},{"line_number":81,"context_line":"    - allow declartion of resouce classes."},{"line_number":82,"context_line":"    - allow policy to expressed decoupled form device whitelisting or pooling."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"outputs"},{"line_number":85,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_feeb870e","line":82,"updated":"2018-09-20 00:38:03.000000000","message":"the trusted vf policy may become a trait as we are indicating that this vf pool supports trused vf but things like the numa policy of the vf i.e. the numa_policy element of the pci whitelist added by https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/share-pci-between-numa-nodes.html may want to be moddeled seperatly from the device pool in a sperate section and then associated with the pool. if we model the numa affinitiy policies as traits then we may not need a seperate policy section but i did not wnat to commit to that up front so as a design goal i am stating i would like to be able to think about this a logically seperate thing but we may choose to remove this when we implement the spec if we dont have a usecase that does not map to a trait.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c913de932834ceef232756f674d5c6d64af9d30b","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    - allow modling of placement providers."},{"line_number":80,"context_line":"    - allow declartion of resouce provider traits."},{"line_number":81,"context_line":"    - allow declartion of resouce classes."},{"line_number":82,"context_line":"    - allow policy to expressed decoupled form device whitelisting or pooling."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"outputs"},{"line_number":85,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_93b61325","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":78},"in_reply_to":"3f79a3b5_41098892","updated":"2018-09-19 16:57:28.000000000","message":"i would prefer not to mix things like trusted vf in the the current device or device pool section and have a seperate policy section that can reference either a deivce or a pool.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1cc59f6d2bfd0770cf6e954d5c751a65487ffaca","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- deprecate in Stein and remove in T the following config options"},{"line_number":99,"context_line":"    - nova:"},{"line_number":100,"context_line":"        - vcpu_pin_set"},{"line_number":101,"context_line":"        - cpu_shared_set"},{"line_number":102,"context_line":"\t- pci_passthrough_whitelist"},{"line_number":103,"context_line":"\t- neutron numa awere vswithc options"},{"line_number":104,"context_line":"\t- vgpu config options"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_412e68fa","line":101,"range":{"start_line":100,"start_character":0,"end_line":101,"end_character":24},"updated":"2018-09-19 16:30:17.000000000","message":"I understand the removal of the below, but why these? CPUs aren\u0027t \"passthrough devices\"","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"88ea7882d7ea143715b5751cc4b4f298aa961586","unresolved":false,"context_lines":[{"line_number":98,"context_line":"- deprecate in Stein and remove in T the following config options"},{"line_number":99,"context_line":"    - nova:"},{"line_number":100,"context_line":"        - vcpu_pin_set"},{"line_number":101,"context_line":"        - cpu_shared_set"},{"line_number":102,"context_line":"\t- pci_passthrough_whitelist"},{"line_number":103,"context_line":"\t- neutron numa awere vswithc options"},{"line_number":104,"context_line":"\t- vgpu config options"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_9eee131f","line":101,"updated":"2018-09-20 00:38:03.000000000","message":"i was being a little obtuse intntionally but just to renforce the point that initally i dont want to declare modeling cpu recouses that can be assigned to the vm if not passed through as out of scope. cpus should be trival to model in this schema the consume code in nova e.g. the virt drivers will be minimally impacted but moving the config options to this unified file and from a operators perspcitve having a single config to mange this in will simplfy there life. \n\ni dont want to block https://review.openstack.org/#/c/555081/ in anyway but i think i can actully provide a very nice way to enable that usecase as well as allow spcifying how it will be reported in placement in a clean way. e.g. if you a host with two numa nodes and  want to create 4 device pool 2 of type VCPU 2 of resouce class PCPU you should be able to do that trivail with this proposal. \n\ni plan to take some of the usecases form jays spec and use it to demonstrate how you can model reserved amounts, allocation ratios, step_size and max/min units for device pools which will get mapped to the placement rp values. i also hope to supprot the inital allocation values concept also for those  who want to mange such things via the api.\n\ni will be added a sperate  section for each of mempages, cpu, vgpus, pci/sriov, block devices, usb, fpgas, bandwith based schduing, numa aware vswitchs and pmem to show how each could be modeled then prenst a unified example config for what would be a very expencsive server if you ever built it :) if we do this correctly we may also be able to modify the fake libvirt driver to interperat this device file and mockout/fake the devices it declares to allow us to do better functional testing too but that is out of scope for now but a definate streach goal in my mind.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c913de932834ceef232756f674d5c6d64af9d30b","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- deprecate in Stein and remove in T the following config options"},{"line_number":99,"context_line":"    - nova:"},{"line_number":100,"context_line":"        - vcpu_pin_set"},{"line_number":101,"context_line":"        - cpu_shared_set"},{"line_number":102,"context_line":"\t- pci_passthrough_whitelist"},{"line_number":103,"context_line":"\t- neutron numa awere vswithc options"},{"line_number":104,"context_line":"\t- vgpu config options"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_130e83e3","line":101,"range":{"start_line":100,"start_character":0,"end_line":101,"end_character":24},"in_reply_to":"3f79a3b5_412e68fa","updated":"2018-09-19 16:57:28.000000000","message":"why not they could be hot plugged as such in the future.\n\n\ni would like to be able to model all devices/resouce owned by nova on a compute node generically.\n\ni should proably add memory here also in some form.\n\ne.g. allow management of reserved memory and whitelisting of hugepages.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"88ea7882d7ea143715b5751cc4b4f298aa961586","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  continue to do this an force operators to understand how configure each services"},{"line_number":123,"context_line":"  whitelist and policy config options indepently"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"- implement this proposal and only use it for nova to unify cpu, pci, vgpus and numa"},{"line_number":126,"context_line":"  affintiy policies. in this case the code could live in the nova tree and not be a seperate"},{"line_number":127,"context_line":"  lib so it can be easily reused by other services."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_bef18f02","line":125,"updated":"2018-09-20 00:38:03.000000000","message":"i should add pmem and mempages to this list","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"88ea7882d7ea143715b5751cc4b4f298aa961586","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"- define a common schema but dont provide any tooling and allow all services to figure out"},{"line_number":130,"context_line":"  how to use it on there own. this means no osc plugin or common lib but atleast we have"},{"line_number":131,"context_line":"  one device policy to rule them all."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"SCHEMA"},{"line_number":134,"context_line":"------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_5edcfb72","line":131,"updated":"2018-09-20 00:38:03.000000000","message":"this is really just reducing the scope of this spec another way to do this is to split into multiple specs and push the tooling and common lib into seperarte specs for later work. for now i dont want to do this but might do that eventurlly.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2020b786715e414eff46de5c97f4fdb3969db307","unresolved":false,"context_lines":[{"line_number":134,"context_line":"------"},{"line_number":135,"context_line":"Note this is an informal schema and a formal schema will be added after initall feedback."},{"line_number":136,"context_line":"This will be replaced in later revions."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"devices:// a set of allowed devices"},{"line_number":139,"context_line":"    \u003cdeice name\u003e: // a human readable name used latter to associate device within a pool"},{"line_number":140,"context_line":"        bus: // the pysical bus the device is attached too e.g.: pcie,usb,nvme,sata..."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_1a9add12","line":137,"updated":"2018-09-21 23:02:16.000000000","message":"Need a meta section to describe e.g. schema version","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63584d2bd1c764c5fe5122b37b0ed53e2bbc5c2a","unresolved":false,"context_lines":[{"line_number":134,"context_line":"------"},{"line_number":135,"context_line":"Note this is an informal schema and a formal schema will be added after initall feedback."},{"line_number":136,"context_line":"This will be replaced in later revions."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"devices:// a set of allowed devices"},{"line_number":139,"context_line":"    \u003cdeice name\u003e: // a human readable name used latter to associate device within a pool"},{"line_number":140,"context_line":"        bus: // the pysical bus the device is attached too e.g.: pcie,usb,nvme,sata..."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_efe1532d","line":137,"in_reply_to":"3f79a3b5_1a9add12","updated":"2018-09-24 11:14:02.000000000","message":"yes this scema is verry incomplete\n\ni will be addint an info section as a header with a\nversion, description filed .","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1cc59f6d2bfd0770cf6e954d5c751a65487ffaca","unresolved":false,"context_lines":[{"line_number":161,"context_line":"``"},{"line_number":162,"context_line":"---"},{"line_number":163,"context_line":"devices:"},{"line_number":164,"context_line":"    nic1: // mathces a specific nic by bus slot function address"},{"line_number":165,"context_line":"        type: nic // bus specifc type"},{"line_number":166,"context_line":"        bus: pcie"},{"line_number":167,"context_line":"        address_type: DBDF"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_c1227801","line":164,"range":{"start_line":164,"start_character":10,"end_line":164,"end_character":12},"updated":"2018-09-19 16:30:17.000000000","message":"Looks like yaml, so use #","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c913de932834ceef232756f674d5c6d64af9d30b","unresolved":false,"context_lines":[{"line_number":161,"context_line":"``"},{"line_number":162,"context_line":"---"},{"line_number":163,"context_line":"devices:"},{"line_number":164,"context_line":"    nic1: // mathces a specific nic by bus slot function address"},{"line_number":165,"context_line":"        type: nic // bus specifc type"},{"line_number":166,"context_line":"        bus: pcie"},{"line_number":167,"context_line":"        address_type: DBDF"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_332e1f43","line":164,"range":{"start_line":164,"start_character":10,"end_line":164,"end_character":12},"in_reply_to":"3f79a3b5_c1227801","updated":"2018-09-19 16:57:28.000000000","message":"good to know i could not find any references to the comment syntaks when i quickly googled\ni saw some reference to support c style comments but i can update.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2020b786715e414eff46de5c97f4fdb3969db307","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        type: nic // bus specifc type"},{"line_number":166,"context_line":"        bus: pcie"},{"line_number":167,"context_line":"        address_type: DBDF"},{"line_number":168,"context_line":"        address: 0000:07:02.0 // should support same regex as current pcie whitelist"},{"line_number":169,"context_line":"    nic2: // match a singel nic by hyperviors specific uuid"},{"line_number":170,"context_line":"        type: nic"},{"line_number":171,"context_line":"        bus: pcie"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_3a6d5903","line":168,"range":{"start_line":168,"start_character":53,"end_line":168,"end_character":58},"updated":"2018-09-21 23:02:16.000000000","message":"Can we not?","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63584d2bd1c764c5fe5122b37b0ed53e2bbc5c2a","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        type: nic // bus specifc type"},{"line_number":166,"context_line":"        bus: pcie"},{"line_number":167,"context_line":"        address_type: DBDF"},{"line_number":168,"context_line":"        address: 0000:07:02.0 // should support same regex as current pcie whitelist"},{"line_number":169,"context_line":"    nic2: // match a singel nic by hyperviors specific uuid"},{"line_number":170,"context_line":"        type: nic"},{"line_number":171,"context_line":"        bus: pcie"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_2fe2eb03","line":168,"range":{"start_line":168,"start_character":53,"end_line":168,"end_character":58},"in_reply_to":"3f79a3b5_3a6d5903","updated":"2018-09-24 11:14:02.000000000","message":"if we dont we wont have parity with the exisiting pci whitelist. as a result the automatic conversion will\nbe siginficantly more difficult.\n\nif we dont have either regex or list support then i would say that effectivly makes the conversion impossible as the file will be needlessly verbose. so for now unless there is a very stong objection i want to leave both regex support and lists as options for this filed.\n\nit will be an eiter or. no list of regexes you cant do that today so im not adding it.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2020b786715e414eff46de5c97f4fdb3969db307","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        type: nic"},{"line_number":171,"context_line":"        bus: pcie"},{"line_number":172,"context_line":"        address_type: uuid"},{"line_number":173,"context_line":"        address: 18ad2597-3bb8-48ea-adaa-e0453a40e7f9 // i dont know how to wildcard this maybe allow a list instead?"},{"line_number":174,"context_line":"    niantics: // match all intel x520 niantic nics / note niantic is used as the name of a set of device"},{"line_number":175,"context_line":"        type: nic"},{"line_number":176,"context_line":"        bus: pcie"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_ba7889c1","line":173,"range":{"start_line":173,"start_character":104,"end_line":173,"end_character":108},"updated":"2018-09-21 23:02:16.000000000","message":"Regex, list, vendor/prod ID - these mechanisms will allow a single \"device\" section to actually represent multiple devices. Then we collate them further via device pools. IMO that kind of double-nesting is going to be pretty confusing.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63584d2bd1c764c5fe5122b37b0ed53e2bbc5c2a","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        type: nic"},{"line_number":171,"context_line":"        bus: pcie"},{"line_number":172,"context_line":"        address_type: uuid"},{"line_number":173,"context_line":"        address: 18ad2597-3bb8-48ea-adaa-e0453a40e7f9 // i dont know how to wildcard this maybe allow a list instead?"},{"line_number":174,"context_line":"    niantics: // match all intel x520 niantic nics / note niantic is used as the name of a set of device"},{"line_number":175,"context_line":"        type: nic"},{"line_number":176,"context_line":"        bus: pcie"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_ef687389","line":173,"range":{"start_line":173,"start_character":104,"end_line":173,"end_character":108},"in_reply_to":"3f79a3b5_ba7889c1","updated":"2018-09-24 11:14:02.000000000","message":"this is partly for party with the existing whitelist and also by design.\n\neach entry in the devices section is not ment to represent a single device. it is intended to model a template against which a deivce can be compared to see if it should be allowed.\n\nif you want to create a pool of intel nics it shoudl be\npossible to use vendor id and product_id to whitelist all intel niantics as is shown in the next example. but if you have a mix of the optical niantics x520 and the copper niantic x540 or a mix of dual and singel port variants of the same the product id will change. as a result i will need the higher level mechanisum of the device pools to aggregate them\n\npart of the core of this design is that the whitelisting(devices section) and aggreation/metadata (device pools section) are kept seperate.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2020b786715e414eff46de5c97f4fdb3969db307","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    niantics: // match all intel x520 niantic nics / note niantic is used as the name of a set of device"},{"line_number":175,"context_line":"        type: nic"},{"line_number":176,"context_line":"        bus: pcie"},{"line_number":177,"context_line":"        vendor_id: \"8086\""},{"line_number":178,"context_line":"        product_id: \"10ed\""},{"line_number":179,"context_line":"    hdd1: // an example of a non pcie device"},{"line_number":180,"context_line":"        type: block_storage"},{"line_number":181,"context_line":"        bus: sata"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_baa3a943","line":178,"range":{"start_line":177,"start_character":1,"end_line":178,"end_character":26},"updated":"2018-09-21 23:02:16.000000000","message":"Where\u0027s the address_type/address here?\n\nI think this illustrates a limitation of the proposed syntax. Because you do want to be able to identify devices by multiple fields (like vendor + product ID). And I really don\u0027t want to see e.g.\n\n address_type: vendor_id, product_id\n address: \"8086\", \"10ed\"\n\nbecause ew.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63584d2bd1c764c5fe5122b37b0ed53e2bbc5c2a","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    niantics: // match all intel x520 niantic nics / note niantic is used as the name of a set of device"},{"line_number":175,"context_line":"        type: nic"},{"line_number":176,"context_line":"        bus: pcie"},{"line_number":177,"context_line":"        vendor_id: \"8086\""},{"line_number":178,"context_line":"        product_id: \"10ed\""},{"line_number":179,"context_line":"    hdd1: // an example of a non pcie device"},{"line_number":180,"context_line":"        type: block_storage"},{"line_number":181,"context_line":"        bus: sata"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_8f221fa3","line":178,"range":{"start_line":177,"start_character":1,"end_line":178,"end_character":26},"in_reply_to":"3f79a3b5_baa3a943","updated":"2018-09-24 11:14:02.000000000","message":"address type is optional.\ni should have made that clear sorry.\nthe current pci whitelist allow 3 ways\nto whitelist pci deivces\n\nvendorid+productid, or pciaddress with regex or \ndevice name (linux netdev name for a pci nic)\n\nso really for pci bus there will be a one of constriant on the following fields\n\none_of:{ {address_type,address}, {vendor_id, product_id} {devicename}} \n\nthat said i had considered dropping device name\n\nthis section should also have numa node as a filter","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1cc59f6d2bfd0770cf6e954d5c751a65487ffaca","unresolved":false,"context_lines":[{"line_number":216,"context_line":"---------------"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"None this is a spec for config file format."},{"line_number":219,"context_line":"if it impacts the rest api we are doing it wrong."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Security impact"},{"line_number":222,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_417c28ea","line":219,"range":{"start_line":219,"start_character":0,"end_line":219,"end_character":49},"updated":"2018-09-19 16:30:17.000000000","message":":)","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1cc59f6d2bfd0770cf6e954d5c751a65487ffaca","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Security impact"},{"line_number":222,"context_line":"---------------"},{"line_number":223,"context_line":"By sharing a common codebase for generating"},{"line_number":224,"context_line":"validating and consuming the device policy config"},{"line_number":225,"context_line":"file across multiple services any security vulnerablity"},{"line_number":226,"context_line":"will effect multiple services."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_e1577459","line":223,"range":{"start_line":223,"start_character":33,"end_line":223,"end_character":43},"updated":"2018-09-19 16:30:17.000000000","message":"This is the real issue and I don\u0027t think this is necessary (it\u0027s a stretch goal, at best). Drop this and you have the exact same security issue as with the existing PCI passthrough whitelist (namely: don\u0027t whitelist devices you don\u0027t want your users using)","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c913de932834ceef232756f674d5c6d64af9d30b","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Security impact"},{"line_number":222,"context_line":"---------------"},{"line_number":223,"context_line":"By sharing a common codebase for generating"},{"line_number":224,"context_line":"validating and consuming the device policy config"},{"line_number":225,"context_line":"file across multiple services any security vulnerablity"},{"line_number":226,"context_line":"will effect multiple services."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_d3e1ebfd","line":223,"range":{"start_line":223,"start_character":33,"end_line":223,"end_character":43},"in_reply_to":"3f79a3b5_e1577459","updated":"2018-09-19 16:57:28.000000000","message":"well i was more thinking of the fact we dont support unicode in the current whitelist and crash with an uncaut exception.\n\nif we cenratised it we sould have one palce to fixt that but\nas it stands we would have to fix it in nova + maybe cyborg and neutron sice they have there own whitelisting code.","commit_id":"0d9b11fa003ae47911ebe35a6d33dc5568734e73"}]}
