)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"93c540b08426db7c40bcb94f120853619a0a2e2f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"add \u0027show-server-group\u0027 spec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec present server group info to user in server show API."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I9dceba013f643925aac8e09d95b1306bcb3c4434"},{"line_number":12,"context_line":"bp: show-server-group"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_9dc8c04e","line":10,"updated":"2018-12-04 17:09:05.000000000","message":"Add the APIImpact tag to the commit message on its own line.","commit_id":"d90a6e6782921899614349294a40d585ede96fd8"}],"specs/stein/approved/list-server-group.rst":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b303fb444a543943ff314d98a982602252d56ee1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"There is no easy way to know the server group which the server belong to."},{"line_number":19,"context_line":"This Spec proposal showing the server group information when do nova show."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_7484995d","line":18,"updated":"2018-10-25 09:48:40.000000000","message":"That\u0027s not really true, you can lookup server groups to get members information https://developer.openstack.org/api-ref/compute/?expanded\u003dshow-server-group-details-detail\n\nThat said, it\u0027s per group, not per member, so I guess your concern.","commit_id":"c50a94789c93a7c4c64f2855667f1057d6f40f6e"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"3df0222a72c400eab5a42fb909db0f95f70955d2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"There is no easy way to know the server group which the server belong to."},{"line_number":19,"context_line":"This Spec proposal showing the server group information when do nova show."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_570b952b","line":18,"in_reply_to":"3f79a3b5_7484995d","updated":"2018-10-25 17:19:43.000000000","message":"Yeah, you need to loop over all the groups looking for your server.","commit_id":"c50a94789c93a7c4c64f2855667f1057d6f40f6e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b303fb444a543943ff314d98a982602252d56ee1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"There is no easy way to know the server group which the server belong to."},{"line_number":19,"context_line":"This Spec proposal showing the server group information when do nova show."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Use Cases"},{"line_number":22,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_d4c00d80","line":19,"updated":"2018-10-25 09:48:40.000000000","message":"I\u0027m pretty against inflating the detailed information we get for a single server just for this, while we could use the already existing os-server-groups API endpoint for it.\n\nRemember, some clients are doing some list details (/servers/detail) for a list of instances, so we would increase the footprint we return, and for most of the cases where people wouldn\u0027t care about server groups.\n\nIf you *really* want to query a membership information based on a single instance, I just feel it should be done on the os-server-groups API endpoint.","commit_id":"c50a94789c93a7c4c64f2855667f1057d6f40f6e"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"3df0222a72c400eab5a42fb909db0f95f70955d2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"There is no easy way to know the server group which the server belong to."},{"line_number":19,"context_line":"This Spec proposal showing the server group information when do nova show."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Use Cases"},{"line_number":22,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_fa10884e","line":19,"in_reply_to":"3f79a3b5_d4c00d80","updated":"2018-10-25 17:19:43.000000000","message":"So you\u0027re thinking something like this?\n\nGET /os-server-groups?server\u003d\u003cuuid\u003e","commit_id":"c50a94789c93a7c4c64f2855667f1057d6f40f6e"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"f96b66ad1ad3de606c55e7bdf3974d5ecdf8fea3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"There is no easy way to know the server group which the server belong to."},{"line_number":19,"context_line":"This Spec proposal showing the server group information when do nova show."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Use Cases"},{"line_number":22,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_35628a3e","line":19,"in_reply_to":"3f79a3b5_fa10884e","updated":"2018-10-26 02:11:46.000000000","message":"I add this as an alternative.","commit_id":"c50a94789c93a7c4c64f2855667f1057d6f40f6e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b303fb444a543943ff314d98a982602252d56ee1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Use Cases"},{"line_number":22,"context_line":"---------"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"* Admin/Tenants want know the server group it belong to while do \"nova show\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_1438c59b","line":24,"range":{"start_line":24,"start_character":62,"end_line":24,"end_character":76},"updated":"2018-10-25 09:48:40.000000000","message":"No, users *could* want to know their group membership, but they don\u0027t really care about which specific API endpoint they use.\nAfter all, most of our users are using clients...","commit_id":"c50a94789c93a7c4c64f2855667f1057d6f40f6e"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"5daf91b7fa0b04a21500333320d5a34e5db5efd8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Use Cases"},{"line_number":22,"context_line":"---------"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"* Admin/Tenants want know the server group it belong to while do \"nova show\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_e88f7f2c","line":24,"range":{"start_line":24,"start_character":2,"end_line":24,"end_character":15},"updated":"2018-10-24 18:27:11.000000000","message":"Users","commit_id":"c50a94789c93a7c4c64f2855667f1057d6f40f6e"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"f96b66ad1ad3de606c55e7bdf3974d5ecdf8fea3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Use Cases"},{"line_number":22,"context_line":"---------"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"* Admin/Tenants want know the server group it belong to while do \"nova show\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_7586c2b9","line":24,"range":{"start_line":24,"start_character":62,"end_line":24,"end_character":76},"in_reply_to":"3f79a3b5_1438c59b","updated":"2018-10-26 02:11:46.000000000","message":"thanks. the real use case is that the user wants to know that by a simple /direct way.","commit_id":"c50a94789c93a7c4c64f2855667f1057d6f40f6e"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"5daf91b7fa0b04a21500333320d5a34e5db5efd8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Proposed change"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposes to add \"server-group\" info to \"GET /servers/{id}\" APIs.the server"},{"line_number":31,"context_line":"group\u0027s name and ID been returned. [open: why not use the name/ID only? ]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_48aeb380","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":34},"updated":"2018-10-24 18:27:11.000000000","message":"This would be clearer as something like: \"Add the server group name and UUID to \"GET /servers/{server_id}\" and \"GET /servers/detailed\".","commit_id":"c50a94789c93a7c4c64f2855667f1057d6f40f6e"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"5daf91b7fa0b04a21500333320d5a34e5db5efd8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposes to add \"server-group\" info to \"GET /servers/{id}\" APIs.the server"},{"line_number":31,"context_line":"group\u0027s name and ID been returned. [open: why not use the name/ID only? ]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_e8c69f4a","line":31,"range":{"start_line":31,"start_character":42,"end_line":31,"end_character":71},"updated":"2018-10-24 18:27:11.000000000","message":"We can\u0027t use name only, as it\u0027s not guaranteed to be unique.  We could use UUID only, but then you\u0027d have to go look it up.  It\u0027s more user-friendly to show both.","commit_id":"c50a94789c93a7c4c64f2855667f1057d6f40f6e"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"f96b66ad1ad3de606c55e7bdf3974d5ecdf8fea3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposes to add \"server-group\" info to \"GET /servers/{id}\" APIs.the server"},{"line_number":31,"context_line":"group\u0027s name and ID been returned. [open: why not use the name/ID only? ]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_d5e2369c","line":31,"range":{"start_line":31,"start_character":42,"end_line":31,"end_character":71},"in_reply_to":"3f79a3b5_e8c69f4a","updated":"2018-10-26 02:11:46.000000000","message":"Done","commit_id":"c50a94789c93a7c4c64f2855667f1057d6f40f6e"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"695789c9dcbc048b40d79e64503938b633524c91","unresolved":false,"context_lines":[{"line_number":46,"context_line":"---------------"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Allows the `/servers/{server_id}` API to show server group information."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. highlight:: javascript"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_db22b954","line":49,"range":{"start_line":49,"start_character":10,"end_line":49,"end_character":32},"updated":"2018-10-23 05:27:23.000000000","message":"same for detail API?","commit_id":"c50a94789c93a7c4c64f2855667f1057d6f40f6e"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"f96b66ad1ad3de606c55e7bdf3974d5ecdf8fea3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"---------------"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Allows the `/servers/{server_id}` API to show server group information."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. highlight:: javascript"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_55df0666","line":49,"range":{"start_line":49,"start_character":10,"end_line":49,"end_character":32},"in_reply_to":"3f79a3b5_db22b954","updated":"2018-10-26 02:11:46.000000000","message":"Done","commit_id":"c50a94789c93a7c4c64f2855667f1057d6f40f6e"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"5daf91b7fa0b04a21500333320d5a34e5db5efd8","unresolved":false,"context_lines":[{"line_number":46,"context_line":"---------------"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Allows the `/servers/{server_id}` API to show server group information."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. highlight:: javascript"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_888a8b17","line":49,"range":{"start_line":49,"start_character":10,"end_line":49,"end_character":32},"in_reply_to":"3f79a3b5_db22b954","updated":"2018-10-24 18:27:11.000000000","message":"Yes.  By default it uses the same code path as \"show\" and should be mentioned here.","commit_id":"c50a94789c93a7c4c64f2855667f1057d6f40f6e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a52121acad2553627835af54195ad0fc57d4cf6b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Alternatives"},{"line_number":36,"context_line":"------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Another alternative is use API like \"GET /os-server-groups?server\u003d\u003cUUID\u003e\"."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Data model impact"},{"line_number":41,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_9f98df7c","line":38,"range":{"start_line":38,"start_character":30,"end_line":38,"end_character":74},"updated":"2018-12-03 09:35:56.000000000","message":"this also is not supported so you can say \n- Another alternative is support the server groups filter by server UUID. Like \"GET /os-server-groups?server\u003d\u003cUUID\u003e\".","commit_id":"9dfe3738e532224f600d416b5edadb8a8f2b9149"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"f1bf1c57e8c361a9a9f72d4197e95bb9213699d2","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Alternatives"},{"line_number":36,"context_line":"------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Another alternative is use API like \"GET /os-server-groups?server\u003d\u003cUUID\u003e\"."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Data model impact"},{"line_number":41,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_98fd4072","line":38,"range":{"start_line":38,"start_character":30,"end_line":38,"end_character":74},"in_reply_to":"3f79a3b5_9f98df7c","updated":"2018-12-04 06:58:01.000000000","message":"Done","commit_id":"9dfe3738e532224f600d416b5edadb8a8f2b9149"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a52121acad2553627835af54195ad0fc57d4cf6b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"---------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Allows the `/servers/{server_id}` and \"GET /servers/detail\" API to show server"},{"line_number":51,"context_line":"group\u0027s Name and UUID."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. highlight:: javascript"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_5f7b272a","line":51,"range":{"start_line":50,"start_character":12,"end_line":51,"end_character":22},"updated":"2018-12-03 09:35:56.000000000","message":"along with GET, we should maintain the consistent server representation among PUT and REBUILD API also. If we are adding the server_group in server response then, it should be added in PUT and REBUILD server API also","commit_id":"9dfe3738e532224f600d416b5edadb8a8f2b9149"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"f1bf1c57e8c361a9a9f72d4197e95bb9213699d2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"---------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Allows the `/servers/{server_id}` and \"GET /servers/detail\" API to show server"},{"line_number":51,"context_line":"group\u0027s Name and UUID."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. highlight:: javascript"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_f8cc7460","line":51,"range":{"start_line":50,"start_character":12,"end_line":51,"end_character":22},"in_reply_to":"3f79a3b5_5f7b272a","updated":"2018-12-04 06:58:01.000000000","message":"Done","commit_id":"9dfe3738e532224f600d416b5edadb8a8f2b9149"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a52121acad2553627835af54195ad0fc57d4cf6b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        \"server\": {"},{"line_number":59,"context_line":"            \"server_group\": {"},{"line_number":60,"context_line":"                \"name\": \"groupA\","},{"line_number":61,"context_line":"                \"id\": \"0b5d2c72-12cc-4ba6-a8d7-3ff5cc1d8cb8\""},{"line_number":62,"context_line":"            }"},{"line_number":63,"context_line":"        }"},{"line_number":64,"context_line":"    }"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_0228f67c","line":62,"range":{"start_line":61,"start_character":0,"end_line":62,"end_character":13},"updated":"2018-12-03 09:35:56.000000000","message":"what all information of server groups are enough here.\nproblem of returning the server-group id is it can be stale id if we delete that serve group.\n\nWe had the same issue for returning the flavor id also. We should return the required info here instead of id.","commit_id":"9dfe3738e532224f600d416b5edadb8a8f2b9149"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"dff985355b877f491538ab3a26ffe6f335638a59","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        \"server\": {"},{"line_number":59,"context_line":"            \"server_group\": {"},{"line_number":60,"context_line":"                \"name\": \"groupA\","},{"line_number":61,"context_line":"                \"id\": \"0b5d2c72-12cc-4ba6-a8d7-3ff5cc1d8cb8\""},{"line_number":62,"context_line":"            }"},{"line_number":63,"context_line":"        }"},{"line_number":64,"context_line":"    }"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_15c48a93","line":62,"range":{"start_line":61,"start_character":0,"end_line":62,"end_character":13},"in_reply_to":"3f79a3b5_0228f67c","updated":"2018-12-04 15:30:52.000000000","message":"Server groups behave differently than flavors.  The group policy is stored with the group itself, and when you delete a group it deletes the group policy.  While instances still know what group they\u0027re \"supposed to be in\", they\u0027re no longer subject to the group policy because the group (and the policy) no longer exists.\n\nGiven this, I think the group name and UUID are sufficient.","commit_id":"9dfe3738e532224f600d416b5edadb8a8f2b9149"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"f1bf1c57e8c361a9a9f72d4197e95bb9213699d2","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        \"server\": {"},{"line_number":59,"context_line":"            \"server_group\": {"},{"line_number":60,"context_line":"                \"name\": \"groupA\","},{"line_number":61,"context_line":"                \"id\": \"0b5d2c72-12cc-4ba6-a8d7-3ff5cc1d8cb8\""},{"line_number":62,"context_line":"            }"},{"line_number":63,"context_line":"        }"},{"line_number":64,"context_line":"    }"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_f83a3430","line":62,"range":{"start_line":61,"start_character":0,"end_line":62,"end_character":13},"in_reply_to":"3f79a3b5_0228f67c","updated":"2018-12-04 06:58:01.000000000","message":"query the server_group info use another db call, this id isn\u0027t supposed to be cached anywhere. I guess there is no problem here?","commit_id":"9dfe3738e532224f600d416b5edadb8a8f2b9149"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a52121acad2553627835af54195ad0fc57d4cf6b","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Other end user impact"},{"line_number":79,"context_line":"---------------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"N/A"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Performance Impact"},{"line_number":84,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_ffb793d0","line":81,"range":{"start_line":80,"start_character":0,"end_line":81,"end_character":3},"updated":"2018-12-03 09:35:56.000000000","message":"you can add update required in python novaclient here.","commit_id":"9dfe3738e532224f600d416b5edadb8a8f2b9149"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"f1bf1c57e8c361a9a9f72d4197e95bb9213699d2","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Other end user impact"},{"line_number":79,"context_line":"---------------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"N/A"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Performance Impact"},{"line_number":84,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_181ff0b9","line":81,"range":{"start_line":80,"start_character":0,"end_line":81,"end_character":3},"in_reply_to":"3f79a3b5_ffb793d0","updated":"2018-12-04 06:58:01.000000000","message":"Done","commit_id":"9dfe3738e532224f600d416b5edadb8a8f2b9149"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a52121acad2553627835af54195ad0fc57d4cf6b","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Testing"},{"line_number":125,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"N/A"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Documentation Impact"},{"line_number":130,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_9faf7f7e","line":127,"range":{"start_line":126,"start_character":0,"end_line":127,"end_character":3},"updated":"2018-12-03 09:35:56.000000000","message":"you can add functional and tempest test to cover this change. Tempest test will be just schema verification.","commit_id":"9dfe3738e532224f600d416b5edadb8a8f2b9149"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"f1bf1c57e8c361a9a9f72d4197e95bb9213699d2","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Testing"},{"line_number":125,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"N/A"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Documentation Impact"},{"line_number":130,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_381aecc7","line":127,"range":{"start_line":126,"start_character":0,"end_line":127,"end_character":3},"in_reply_to":"3f79a3b5_9faf7f7e","updated":"2018-12-04 06:58:01.000000000","message":"Done","commit_id":"9dfe3738e532224f600d416b5edadb8a8f2b9149"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"93c540b08426db7c40bcb94f120853619a0a2e2f","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"bp link:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/nova/+spec/show-server-group"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_bdc33c31","line":13,"range":{"start_line":13,"start_character":44,"end_line":13,"end_character":61},"updated":"2018-12-04 17:09:05.000000000","message":"The spec filename needs to match the bp.","commit_id":"d90a6e6782921899614349294a40d585ede96fd8"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"2827b6a7f9e1f8ad572ca77147059908cbd97479","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"bp link:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/nova/+spec/show-server-group"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_4de6e8dd","line":13,"range":{"start_line":13,"start_character":44,"end_line":13,"end_character":61},"in_reply_to":"3f79a3b5_bdc33c31","updated":"2018-12-05 07:13:37.000000000","message":"Done","commit_id":"d90a6e6782921899614349294a40d585ede96fd8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"93c540b08426db7c40bcb94f120853619a0a2e2f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposes to add the server-group name and UUID to \"GET /servers/{id}\" and"},{"line_number":32,"context_line":"\"GET /servers/detail\" APIs."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_1d5a7084","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":27},"updated":"2018-12-04 17:09:05.000000000","message":"At the PTG we said we would not do this for listing servers with details because it would be inefficient given the server group information is in the API DB and the instances information is in the cell DB(s), so you can\u0027t do an easy join for this. See L900:\n\nhttps://etherpad.openstack.org/p/nova-ptg-stein","commit_id":"d90a6e6782921899614349294a40d585ede96fd8"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"2827b6a7f9e1f8ad572ca77147059908cbd97479","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposes to add the server-group name and UUID to \"GET /servers/{id}\" and"},{"line_number":32,"context_line":"\"GET /servers/detail\" APIs."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_0d0f908a","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":27},"in_reply_to":"3f79a3b5_1d5a7084","updated":"2018-12-05 07:13:37.000000000","message":"Done","commit_id":"d90a6e6782921899614349294a40d585ede96fd8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"93c540b08426db7c40bcb94f120853619a0a2e2f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Alternatives"},{"line_number":36,"context_line":"------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* Another alternative is support the server groups filter by server UUID. Like"},{"line_number":39,"context_line":"  \"GET /os-server-groups?server\u003d\u003cUUID\u003e?server\u003d\u003cUUID\u003e\"."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_7d85a4aa","line":38,"updated":"2018-12-04 17:09:05.000000000","message":"I like this alternative better, and aligns more with listing ports/volumes attached to a server:\n\nhttps://developer.openstack.org/api-ref/compute/?expanded\u003d#list-port-interfaces\n\nhttps://developer.openstack.org/api-ref/compute/?expanded\u003d#list-volume-attachments-for-an-instance\n\nThe difference being ^ only works on a single server. If we want to list server groups with a list of members, that\u0027s a different filtering semantic, but it\u0027s doable. I would suggest we do something closer to what placement has with \"in\" filtering, like:\n\nhttps://developer.openstack.org/api-ref/placement/?expanded\u003dlist-resource-providers-detail#list-resource-providers\n\nGET /os-server-groups?members\u003din:server1,server2\n\nAlternatively we could just ignore the \"in\" part and do:\n\nGET /os-server-groups?members\u003dserver1,server2\n\nSo that \"members\" is a list filter parameter. I\u0027m not exactly sure I remember the history behind the \"in:\" filtering semantics in the placement API, so we should ask cdent about that - I\u0027m guessing it was done to be explicit in the request, either you\u0027re passing a single member or a list of members.","commit_id":"d90a6e6782921899614349294a40d585ede96fd8"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"2827b6a7f9e1f8ad572ca77147059908cbd97479","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Alternatives"},{"line_number":36,"context_line":"------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* Another alternative is support the server groups filter by server UUID. Like"},{"line_number":39,"context_line":"  \"GET /os-server-groups?server\u003d\u003cUUID\u003e?server\u003d\u003cUUID\u003e\"."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_4d426895","line":38,"in_reply_to":"3f79a3b5_7d85a4aa","updated":"2018-12-05 07:13:37.000000000","message":"Done","commit_id":"d90a6e6782921899614349294a40d585ede96fd8"}],"specs/stein/approved/show-server-group.rst":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a3cd16ae6d9653123f78aa09636739d108f74dbf","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently You had to loop over all groups to looking the group you belong to."},{"line_number":19,"context_line":"This Spec try to address this by proposal showing the server group information"},{"line_number":20,"context_line":"when do nova show."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_452f7156","line":19,"range":{"start_line":19,"start_character":10,"end_line":19,"end_character":13},"updated":"2018-12-07 00:11:33.000000000","message":"nit: s/try/tries/","commit_id":"e73cffa7bcadf7b285d7605101446cb93414b7bb"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"96728b23edcb981510fcbd1adcfe0c53df11e80e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently You had to loop over all groups to looking the group you belong to."},{"line_number":19,"context_line":"This Spec try to address this by proposal showing the server group information"},{"line_number":20,"context_line":"when do nova show."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_c5f396a1","line":19,"range":{"start_line":19,"start_character":10,"end_line":19,"end_character":13},"in_reply_to":"3f79a3b5_452f7156","updated":"2018-12-19 08:05:20.000000000","message":"Done","commit_id":"e73cffa7bcadf7b285d7605101446cb93414b7bb"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a3cd16ae6d9653123f78aa09636739d108f74dbf","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    {"},{"line_number":64,"context_line":"        \"server\": {"},{"line_number":65,"context_line":"            \"server_group\": {"},{"line_number":66,"context_line":"                \"name\": \"groupA\","},{"line_number":67,"context_line":"                \"id\": \"0b5d2c72-12cc-4ba6-a8d7-3ff5cc1d8cb8\""},{"line_number":68,"context_line":"            }"},{"line_number":69,"context_line":"        }"},{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_0503b9bd","line":68,"range":{"start_line":65,"start_character":0,"end_line":68,"end_character":13},"updated":"2018-12-07 00:11:33.000000000","message":"I guess\n\n \"server_group\": \"0b5d2c72-12cc-4ba6-a8d7-3ff5cc1d8cb8\"\n\ncould be enough and simple which is the same as the parameter of \"create a server\" API.","commit_id":"e73cffa7bcadf7b285d7605101446cb93414b7bb"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"96728b23edcb981510fcbd1adcfe0c53df11e80e","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    {"},{"line_number":64,"context_line":"        \"server\": {"},{"line_number":65,"context_line":"            \"server_group\": {"},{"line_number":66,"context_line":"                \"name\": \"groupA\","},{"line_number":67,"context_line":"                \"id\": \"0b5d2c72-12cc-4ba6-a8d7-3ff5cc1d8cb8\""},{"line_number":68,"context_line":"            }"},{"line_number":69,"context_line":"        }"},{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_25036a77","line":68,"range":{"start_line":65,"start_character":0,"end_line":68,"end_character":13},"in_reply_to":"3f79a3b5_0503b9bd","updated":"2018-12-19 08:05:20.000000000","message":"Done","commit_id":"e73cffa7bcadf7b285d7605101446cb93414b7bb"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"dbdd51ed619b32e0f5cc35a770f2cecebebb19de","unresolved":false,"context_lines":[{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Allows the `/servers/{server_id}` and \"GET /servers/detail\" API to show server"},{"line_number":57,"context_line":"group\u0027s Name and UUID. PUT and REBUILD API also return same information."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":".. highlight:: javascript"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_8cc91f53","line":56,"range":{"start_line":56,"start_character":12,"end_line":56,"end_character":32},"updated":"2018-12-20 23:25:58.000000000","message":"nit:\n\nGET /servers/{server_id}","commit_id":"d0808e518ae931a8bc6aee0e917b4799cb74f432"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"791f142b5db46557a21724016e5e89905969bc2b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Allows the `/servers/{server_id}` and \"GET /servers/detail\" API to show server"},{"line_number":57,"context_line":"group\u0027s Name and UUID. PUT and REBUILD API also return same information."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":".. highlight:: javascript"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_b5c3fa58","line":56,"range":{"start_line":56,"start_character":12,"end_line":56,"end_character":32},"in_reply_to":"3f79a3b5_8cc91f53","updated":"2018-12-21 03:21:27.000000000","message":"Done","commit_id":"d0808e518ae931a8bc6aee0e917b4799cb74f432"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"dbdd51ed619b32e0f5cc35a770f2cecebebb19de","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Allows the `/servers/{server_id}` and \"GET /servers/detail\" API to show server"},{"line_number":57,"context_line":"group\u0027s Name and UUID. PUT and REBUILD API also return same information."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":".. highlight:: javascript"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_4ccf8754","line":57,"range":{"start_line":57,"start_character":23,"end_line":57,"end_character":26},"updated":"2018-12-20 23:25:58.000000000","message":"nit: PUT /servers/{server_id}","commit_id":"d0808e518ae931a8bc6aee0e917b4799cb74f432"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"791f142b5db46557a21724016e5e89905969bc2b","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Allows the `/servers/{server_id}` and \"GET /servers/detail\" API to show server"},{"line_number":57,"context_line":"group\u0027s Name and UUID. PUT and REBUILD API also return same information."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":".. highlight:: javascript"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_159aee73","line":57,"range":{"start_line":57,"start_character":23,"end_line":57,"end_character":26},"in_reply_to":"3f79a3b5_4ccf8754","updated":"2018-12-21 03:21:27.000000000","message":"Done","commit_id":"d0808e518ae931a8bc6aee0e917b4799cb74f432"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"dbdd51ed619b32e0f5cc35a770f2cecebebb19de","unresolved":false,"context_lines":[{"line_number":127,"context_line":"Testing"},{"line_number":128,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"* Add functional api_sample tests."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Documentation Impact"},{"line_number":133,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_ecf7738c","line":130,"updated":"2018-12-20 23:25:58.000000000","message":"Tempest tests are required for this change because the responses are changed.\n\nThe following document says:\n\n\u003e If the microversion changes the response schema, a new schema and test for the microversion must be added to Tempest.\n\nhttps://docs.openstack.org/nova/latest/contributor/code-review.html#microversion-api","commit_id":"d0808e518ae931a8bc6aee0e917b4799cb74f432"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"791f142b5db46557a21724016e5e89905969bc2b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"Testing"},{"line_number":128,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"* Add functional api_sample tests."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Documentation Impact"},{"line_number":133,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_f52c1200","line":130,"in_reply_to":"3f79a3b5_ecf7738c","updated":"2018-12-21 03:21:27.000000000","message":"Done","commit_id":"d0808e518ae931a8bc6aee0e917b4799cb74f432"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"33978e3866f5debbc71a7a3c0f3f53cef8a0b22f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"show which server group a server is in \"nova show\""},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"bp link:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/nova/+spec/show-server-group"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f769fc5_fcca784d","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":61},"updated":"2018-12-24 03:53:34.000000000","message":"maybe briefly introduce what this spec is about rather than just a bp link?","commit_id":"719f526c2c7e3bab461384d242e6adcdd1b503b3"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"510b15aa46db7b886fa871d1dac66640ec659acb","unresolved":false,"context_lines":[{"line_number":8,"context_line":"show which server group a server is in \"nova show\""},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"bp link:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/nova/+spec/show-server-group"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f769fc5_09702fa5","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":61},"in_reply_to":"1f769fc5_fcca784d","updated":"2018-12-29 07:40:23.000000000","message":"I think the title is pretty clear. that seems enough. thanks.","commit_id":"719f526c2c7e3bab461384d242e6adcdd1b503b3"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"33978e3866f5debbc71a7a3c0f3f53cef8a0b22f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently You had to loop over all groups to looking the group you belong to."},{"line_number":19,"context_line":"This Spec tries to address this by proposal showing the server group"},{"line_number":20,"context_line":"information when do nova show."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f769fc5_1cc89453","line":18,"range":{"start_line":18,"start_character":62,"end_line":18,"end_character":76},"updated":"2018-12-24 03:53:34.000000000","message":"Who? I suppose the server.","commit_id":"719f526c2c7e3bab461384d242e6adcdd1b503b3"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"510b15aa46db7b886fa871d1dac66640ec659acb","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently You had to loop over all groups to looking the group you belong to."},{"line_number":19,"context_line":"This Spec tries to address this by proposal showing the server group"},{"line_number":20,"context_line":"information when do nova show."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f769fc5_e96613ee","line":18,"range":{"start_line":18,"start_character":62,"end_line":18,"end_character":76},"in_reply_to":"1f769fc5_1cc89453","updated":"2018-12-29 07:40:23.000000000","message":"Done","commit_id":"719f526c2c7e3bab461384d242e6adcdd1b503b3"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"33978e3866f5debbc71a7a3c0f3f53cef8a0b22f","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently You had to loop over all groups to looking the group you belong to."},{"line_number":19,"context_line":"This Spec tries to address this by proposal showing the server group"},{"line_number":20,"context_line":"information when do nova show."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Use Cases"},{"line_number":23,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f769fc5_dcc1bc30","line":20,"range":{"start_line":20,"start_character":20,"end_line":20,"end_character":29},"updated":"2018-12-24 03:53:34.000000000","message":"probably better to use the API here.","commit_id":"719f526c2c7e3bab461384d242e6adcdd1b503b3"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"510b15aa46db7b886fa871d1dac66640ec659acb","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently You had to loop over all groups to looking the group you belong to."},{"line_number":19,"context_line":"This Spec tries to address this by proposal showing the server group"},{"line_number":20,"context_line":"information when do nova show."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Use Cases"},{"line_number":23,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f769fc5_8963dfdc","line":20,"range":{"start_line":20,"start_character":20,"end_line":20,"end_character":29},"in_reply_to":"1f769fc5_dcc1bc30","updated":"2018-12-29 07:40:23.000000000","message":"Done","commit_id":"719f526c2c7e3bab461384d242e6adcdd1b503b3"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"33978e3866f5debbc71a7a3c0f3f53cef8a0b22f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Use Cases"},{"line_number":23,"context_line":"---------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* Admin/End user want to know the server group it belong to by a direct way."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f769fc5_7cdc2818","line":25,"range":{"start_line":25,"start_character":2,"end_line":25,"end_character":76},"updated":"2018-12-24 03:53:34.000000000","message":"Users want to know the server group the given server belongs to by a direct way.","commit_id":"719f526c2c7e3bab461384d242e6adcdd1b503b3"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"510b15aa46db7b886fa871d1dac66640ec659acb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Use Cases"},{"line_number":23,"context_line":"---------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* Admin/End user want to know the server group it belong to by a direct way."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f769fc5_09a58f04","line":25,"range":{"start_line":25,"start_character":2,"end_line":25,"end_character":76},"in_reply_to":"1f769fc5_7cdc2818","updated":"2018-12-29 07:40:23.000000000","message":"Done","commit_id":"719f526c2c7e3bab461384d242e6adcdd1b503b3"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"33978e3866f5debbc71a7a3c0f3f53cef8a0b22f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposes to add the server-group name and UUID to \"GET /servers/{id}\". The"},{"line_number":32,"context_line":"server-group info not include in\"GET /servers/detail\" APIs because we need get"},{"line_number":33,"context_line":"the server-group information via another DB query."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f769fc5_3ce6b0ea","line":32,"range":{"start_line":32,"start_character":54,"end_line":32,"end_character":58},"updated":"2018-12-24 03:53:34.000000000","message":"API","commit_id":"719f526c2c7e3bab461384d242e6adcdd1b503b3"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"33978e3866f5debbc71a7a3c0f3f53cef8a0b22f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposes to add the server-group name and UUID to \"GET /servers/{id}\". The"},{"line_number":32,"context_line":"server-group info not include in\"GET /servers/detail\" APIs because we need get"},{"line_number":33,"context_line":"the server-group information via another DB query."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f769fc5_9ce104d4","line":32,"range":{"start_line":32,"start_character":18,"end_line":32,"end_character":29},"updated":"2018-12-24 03:53:34.000000000","message":"will not be included","commit_id":"719f526c2c7e3bab461384d242e6adcdd1b503b3"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"510b15aa46db7b886fa871d1dac66640ec659acb","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposes to add the server-group name and UUID to \"GET /servers/{id}\". The"},{"line_number":32,"context_line":"server-group info not include in\"GET /servers/detail\" APIs because we need get"},{"line_number":33,"context_line":"the server-group information via another DB query."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f769fc5_29aacbd3","line":32,"range":{"start_line":32,"start_character":54,"end_line":32,"end_character":58},"in_reply_to":"1f769fc5_3ce6b0ea","updated":"2018-12-29 07:40:23.000000000","message":"Done","commit_id":"719f526c2c7e3bab461384d242e6adcdd1b503b3"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"510b15aa46db7b886fa871d1dac66640ec659acb","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposes to add the server-group name and UUID to \"GET /servers/{id}\". The"},{"line_number":32,"context_line":"server-group info not include in\"GET /servers/detail\" APIs because we need get"},{"line_number":33,"context_line":"the server-group information via another DB query."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f769fc5_c9aeb7e6","line":32,"range":{"start_line":32,"start_character":18,"end_line":32,"end_character":29},"in_reply_to":"1f769fc5_9ce104d4","updated":"2018-12-29 07:40:23.000000000","message":"Done","commit_id":"719f526c2c7e3bab461384d242e6adcdd1b503b3"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"33978e3866f5debbc71a7a3c0f3f53cef8a0b22f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Allows the `GET /servers/{server_id}` and \"GET /servers/detail\" API to show"},{"line_number":57,"context_line":"server group\u0027s Name and UUID. \"PUT /servers/{server_id}\" and REBUILD API"},{"line_number":58,"context_line":"\"POST /servers/{server_id}/action\" also return same information."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f769fc5_1ccdf45c","line":56,"range":{"start_line":56,"start_character":42,"end_line":56,"end_character":63},"updated":"2018-12-24 03:53:34.000000000","message":"you just said that it will not be included in this API","commit_id":"719f526c2c7e3bab461384d242e6adcdd1b503b3"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"510b15aa46db7b886fa871d1dac66640ec659acb","unresolved":false,"context_lines":[{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Allows the `GET /servers/{server_id}` and \"GET /servers/detail\" API to show"},{"line_number":57,"context_line":"server group\u0027s Name and UUID. \"PUT /servers/{server_id}\" and REBUILD API"},{"line_number":58,"context_line":"\"POST /servers/{server_id}/action\" also return same information."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f769fc5_e9ab73d3","line":56,"range":{"start_line":56,"start_character":42,"end_line":56,"end_character":63},"in_reply_to":"1f769fc5_1ccdf45c","updated":"2018-12-29 07:40:23.000000000","message":"Done","commit_id":"719f526c2c7e3bab461384d242e6adcdd1b503b3"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"33978e3866f5debbc71a7a3c0f3f53cef8a0b22f","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Allows the `GET /servers/{server_id}` and \"GET /servers/detail\" API to show"},{"line_number":57,"context_line":"server group\u0027s Name and UUID. \"PUT /servers/{server_id}\" and REBUILD API"},{"line_number":58,"context_line":"\"POST /servers/{server_id}/action\" also return same information."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":".. highlight:: javascript"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f769fc5_bcd96023","line":58,"updated":"2018-12-24 03:53:34.000000000","message":"response","commit_id":"719f526c2c7e3bab461384d242e6adcdd1b503b3"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"510b15aa46db7b886fa871d1dac66640ec659acb","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Allows the `GET /servers/{server_id}` and \"GET /servers/detail\" API to show"},{"line_number":57,"context_line":"server group\u0027s Name and UUID. \"PUT /servers/{server_id}\" and REBUILD API"},{"line_number":58,"context_line":"\"POST /servers/{server_id}/action\" also return same information."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":".. highlight:: javascript"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f769fc5_89b8bf2a","line":58,"in_reply_to":"1f769fc5_bcd96023","updated":"2018-12-29 07:40:23.000000000","message":"Done","commit_id":"719f526c2c7e3bab461384d242e6adcdd1b503b3"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f088236f80c89206b97d78d1d2abaadfa43346b1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently You had to loop over all groups to looking the group server belong"},{"line_number":19,"context_line":"to. This Spec tries to address this by proposal showing the server group"},{"line_number":20,"context_line":"information in API `GET /servers/{server_id}`."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_921afa7a","line":18,"range":{"start_line":18,"start_character":10,"end_line":18,"end_character":13},"updated":"2019-01-09 12:30:18.000000000","message":"s/You/you","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"02744af8994e6980bafa2557bf97175243b02563","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently You had to loop over all groups to looking the group server belong"},{"line_number":19,"context_line":"to. This Spec tries to address this by proposal showing the server group"},{"line_number":20,"context_line":"information in API `GET /servers/{server_id}`."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_e34ff6ba","line":18,"range":{"start_line":18,"start_character":70,"end_line":18,"end_character":76},"updated":"2019-01-09 14:40:24.000000000","message":"s/belong/belongs/","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"02744af8994e6980bafa2557bf97175243b02563","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently You had to loop over all groups to looking the group server belong"},{"line_number":19,"context_line":"to. This Spec tries to address this by proposal showing the server group"},{"line_number":20,"context_line":"information in API `GET /servers/{server_id}`."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_43512262","line":18,"range":{"start_line":18,"start_character":45,"end_line":18,"end_character":62},"updated":"2019-01-09 14:40:24.000000000","message":"s/looking the group/find a group the/","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"cd97ac3ef270f296131eae0e975a2c11458749f2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently You had to loop over all groups to looking the group server belong"},{"line_number":19,"context_line":"to. This Spec tries to address this by proposal showing the server group"},{"line_number":20,"context_line":"information in API `GET /servers/{server_id}`."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_3e467523","line":18,"range":{"start_line":18,"start_character":45,"end_line":18,"end_character":62},"in_reply_to":"dfd5e7cf_43512262","updated":"2019-01-09 14:59:33.000000000","message":"Done","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"cd97ac3ef270f296131eae0e975a2c11458749f2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently You had to loop over all groups to looking the group server belong"},{"line_number":19,"context_line":"to. This Spec tries to address this by proposal showing the server group"},{"line_number":20,"context_line":"information in API `GET /servers/{server_id}`."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_9e3761b1","line":18,"range":{"start_line":18,"start_character":10,"end_line":18,"end_character":13},"in_reply_to":"dfd5e7cf_921afa7a","updated":"2019-01-09 14:59:33.000000000","message":"Done","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"cd97ac3ef270f296131eae0e975a2c11458749f2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently You had to loop over all groups to looking the group server belong"},{"line_number":19,"context_line":"to. This Spec tries to address this by proposal showing the server group"},{"line_number":20,"context_line":"information in API `GET /servers/{server_id}`."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_fe4f8d31","line":18,"range":{"start_line":18,"start_character":70,"end_line":18,"end_character":76},"in_reply_to":"dfd5e7cf_e34ff6ba","updated":"2019-01-09 14:59:33.000000000","message":"Done","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"02744af8994e6980bafa2557bf97175243b02563","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently You had to loop over all groups to looking the group server belong"},{"line_number":19,"context_line":"to. This Spec tries to address this by proposal showing the server group"},{"line_number":20,"context_line":"information in API `GET /servers/{server_id}`."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_43684220","line":19,"range":{"start_line":19,"start_character":9,"end_line":19,"end_character":13},"updated":"2019-01-09 14:40:24.000000000","message":"s/Spec/spec/g","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"02744af8994e6980bafa2557bf97175243b02563","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently You had to loop over all groups to looking the group server belong"},{"line_number":19,"context_line":"to. This Spec tries to address this by proposal showing the server group"},{"line_number":20,"context_line":"information in API `GET /servers/{server_id}`."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_c3651247","line":19,"range":{"start_line":19,"start_character":39,"end_line":19,"end_character":47},"updated":"2019-01-09 14:40:24.000000000","message":"s/proposal/proposing/","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"cd97ac3ef270f296131eae0e975a2c11458749f2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently You had to loop over all groups to looking the group server belong"},{"line_number":19,"context_line":"to. This Spec tries to address this by proposal showing the server group"},{"line_number":20,"context_line":"information in API `GET /servers/{server_id}`."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_7e5ddde7","line":19,"range":{"start_line":19,"start_character":9,"end_line":19,"end_character":13},"in_reply_to":"dfd5e7cf_43684220","updated":"2019-01-09 14:59:33.000000000","message":"Done","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"cd97ac3ef270f296131eae0e975a2c11458749f2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently You had to loop over all groups to looking the group server belong"},{"line_number":19,"context_line":"to. This Spec tries to address this by proposal showing the server group"},{"line_number":20,"context_line":"information in API `GET /servers/{server_id}`."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_3e6f5593","line":19,"range":{"start_line":19,"start_character":39,"end_line":19,"end_character":47},"in_reply_to":"dfd5e7cf_c3651247","updated":"2019-01-09 14:59:33.000000000","message":"Done","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"02744af8994e6980bafa2557bf97175243b02563","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Use Cases"},{"line_number":23,"context_line":"---------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* Admin/End user want to know the server group that the server belong to"},{"line_number":26,"context_line":"  by a direct way."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_03e0fa95","line":25,"range":{"start_line":25,"start_character":63,"end_line":25,"end_character":69},"updated":"2019-01-09 14:40:24.000000000","message":"s/belong/belongs/","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"cd97ac3ef270f296131eae0e975a2c11458749f2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Use Cases"},{"line_number":23,"context_line":"---------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* Admin/End user want to know the server group that the server belong to"},{"line_number":26,"context_line":"  by a direct way."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_7e12bd0b","line":25,"range":{"start_line":25,"start_character":63,"end_line":25,"end_character":69},"in_reply_to":"dfd5e7cf_03e0fa95","updated":"2019-01-09 14:59:33.000000000","message":"Done","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"02744af8994e6980bafa2557bf97175243b02563","unresolved":false,"context_lines":[{"line_number":23,"context_line":"---------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* Admin/End user want to know the server group that the server belong to"},{"line_number":26,"context_line":"  by a direct way."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_c3f3d272","line":26,"range":{"start_line":26,"start_character":2,"end_line":26,"end_character":4},"updated":"2019-01-09 14:40:24.000000000","message":"s/by/in/","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"cd97ac3ef270f296131eae0e975a2c11458749f2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"---------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* Admin/End user want to know the server group that the server belong to"},{"line_number":26,"context_line":"  by a direct way."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_3ef435cf","line":26,"range":{"start_line":26,"start_character":2,"end_line":26,"end_character":4},"in_reply_to":"dfd5e7cf_c3f3d272","updated":"2019-01-09 14:59:33.000000000","message":"Done","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"02744af8994e6980bafa2557bf97175243b02563","unresolved":false,"context_lines":[{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposes to add the server-group name and UUID to \"GET /servers/{id}\". The"},{"line_number":33,"context_line":"server-group information does not be included in\"GET /servers/detail\" API,"},{"line_number":34,"context_line":"because the server-group information needs antoher DB query."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_e3fdb63a","line":33,"range":{"start_line":33,"start_character":25,"end_line":33,"end_character":45},"updated":"2019-01-09 14:40:24.000000000","message":"s/does not be included/will not be included/","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"cd97ac3ef270f296131eae0e975a2c11458749f2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposes to add the server-group name and UUID to \"GET /servers/{id}\". The"},{"line_number":33,"context_line":"server-group information does not be included in\"GET /servers/detail\" API,"},{"line_number":34,"context_line":"because the server-group information needs antoher DB query."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_def089cc","line":33,"range":{"start_line":33,"start_character":25,"end_line":33,"end_character":45},"in_reply_to":"dfd5e7cf_e3fdb63a","updated":"2019-01-09 14:59:33.000000000","message":"Done","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f088236f80c89206b97d78d1d2abaadfa43346b1","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposes to add the server-group name and UUID to \"GET /servers/{id}\". The"},{"line_number":33,"context_line":"server-group information does not be included in\"GET /servers/detail\" API,"},{"line_number":34,"context_line":"because the server-group information needs antoher DB query."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_120e0a3b","line":34,"range":{"start_line":34,"start_character":43,"end_line":34,"end_character":50},"updated":"2019-01-09 12:30:18.000000000","message":"another","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"cd97ac3ef270f296131eae0e975a2c11458749f2","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposes to add the server-group name and UUID to \"GET /servers/{id}\". The"},{"line_number":33,"context_line":"server-group information does not be included in\"GET /servers/detail\" API,"},{"line_number":34,"context_line":"because the server-group information needs antoher DB query."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_7eb95de7","line":34,"range":{"start_line":34,"start_character":43,"end_line":34,"end_character":50},"in_reply_to":"dfd5e7cf_120e0a3b","updated":"2019-01-09 14:59:33.000000000","message":"Done","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"02744af8994e6980bafa2557bf97175243b02563","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  \"GET /os-server-groups?server\u003d\u003cUUID\u003e\"."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Another alternative to support the server groups filter by server UUID more"},{"line_number":44,"context_line":"  flexable. Like"},{"line_number":45,"context_line":"  \"GET /os-server-groups?member_of\u003din:\u003cserver-uuid1\u003e,\u003cserver-uuid2\u003e\"."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_639f8603","line":44,"range":{"start_line":44,"start_character":2,"end_line":44,"end_character":10},"updated":"2019-01-09 14:40:24.000000000","message":"flexible","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"cd97ac3ef270f296131eae0e975a2c11458749f2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  \"GET /os-server-groups?server\u003d\u003cUUID\u003e\"."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Another alternative to support the server groups filter by server UUID more"},{"line_number":44,"context_line":"  flexable. Like"},{"line_number":45,"context_line":"  \"GET /os-server-groups?member_of\u003din:\u003cserver-uuid1\u003e,\u003cserver-uuid2\u003e\"."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_5eab3988","line":44,"range":{"start_line":44,"start_character":2,"end_line":44,"end_character":10},"in_reply_to":"dfd5e7cf_639f8603","updated":"2019-01-09 14:59:33.000000000","message":"Done","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"02744af8994e6980bafa2557bf97175243b02563","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Another alternative to support the server groups filter by server UUID more"},{"line_number":44,"context_line":"  flexable. Like"},{"line_number":45,"context_line":"  \"GET /os-server-groups?member_of\u003din:\u003cserver-uuid1\u003e,\u003cserver-uuid2\u003e\"."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Data model impact"},{"line_number":48,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_83706ade","line":45,"range":{"start_line":45,"start_character":25,"end_line":45,"end_character":34},"updated":"2019-01-09 14:40:24.000000000","message":"this is backwards actually :) member_of (at least how this is used in the placement service) indicates that the resource being queried is a member of the entity listed in the query parameter.\n\nFor instance, GET /resource_providers?member_of\u003din:\u003caggregate_uuid\u003e\n\nthere is no corresponding GET /aggregates?containing\u003d\u003cprovider_uuid\u003e which is what I think you\u0027re looking for here. Instead, the GET /resource_providers/{provider_uuid}/aggregates returns the aggregates that the provider is a member of.","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"cd97ac3ef270f296131eae0e975a2c11458749f2","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Another alternative to support the server groups filter by server UUID more"},{"line_number":44,"context_line":"  flexable. Like"},{"line_number":45,"context_line":"  \"GET /os-server-groups?member_of\u003din:\u003cserver-uuid1\u003e,\u003cserver-uuid2\u003e\"."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Data model impact"},{"line_number":48,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_5e001968","line":45,"range":{"start_line":45,"start_character":25,"end_line":45,"end_character":34},"in_reply_to":"dfd5e7cf_83706ade","updated":"2019-01-09 14:59:33.000000000","message":"Done. thanks make it clearer.","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"02744af8994e6980bafa2557bf97175243b02563","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    {"},{"line_number":66,"context_line":"        \"server\": {"},{"line_number":67,"context_line":"            \"server_group\": \"0b5d2c72-12cc-4ba6-a8d7-3ff5cc1d8cb8\""},{"line_number":68,"context_line":"        }"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_3e3755e6","line":67,"range":{"start_line":67,"start_character":11,"end_line":67,"end_character":66},"updated":"2019-01-09 14:40:24.000000000","message":"this is coupling the current (bad) implementation of server groups into the public API, which I\u0027m not really in favor of. There\u0027s really no reason why a server instance must only be in a single server group, other than our poor implementation of affinity/anti-affinity manifested as the \"server groups\" functionality.\n\nI think a more future-proof HTTP response would use a list, not a scalar string:\n\n \"server_groups\": [\n   \"0b5d2c72-12cc-4ba6-a8d7-3ff5cc1d8cb8\",\n ]\n\nand @alex_xu\u0027s comment would be solved with an empty list not a null.","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f088236f80c89206b97d78d1d2abaadfa43346b1","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    {"},{"line_number":66,"context_line":"        \"server\": {"},{"line_number":67,"context_line":"            \"server_group\": \"0b5d2c72-12cc-4ba6-a8d7-3ff5cc1d8cb8\""},{"line_number":68,"context_line":"        }"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_5d57c303","line":67,"range":{"start_line":67,"start_character":29,"end_line":67,"end_character":65},"updated":"2019-01-09 12:30:18.000000000","message":"when the server isn\u0027t in any server group, I think it should be null","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"cd97ac3ef270f296131eae0e975a2c11458749f2","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    {"},{"line_number":66,"context_line":"        \"server\": {"},{"line_number":67,"context_line":"            \"server_group\": \"0b5d2c72-12cc-4ba6-a8d7-3ff5cc1d8cb8\""},{"line_number":68,"context_line":"        }"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_fe1c6dc2","line":67,"range":{"start_line":67,"start_character":11,"end_line":67,"end_character":66},"in_reply_to":"dfd5e7cf_3e3755e6","updated":"2019-01-09 14:59:33.000000000","message":"Done","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"6cc096e11a82564647a2f1d66a9a9338940c1308","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    {"},{"line_number":66,"context_line":"        \"server\": {"},{"line_number":67,"context_line":"            \"server_group\": \"0b5d2c72-12cc-4ba6-a8d7-3ff5cc1d8cb8\""},{"line_number":68,"context_line":"        }"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_4bf04b68","line":67,"range":{"start_line":67,"start_character":11,"end_line":67,"end_character":66},"in_reply_to":"dfd5e7cf_3e3755e6","updated":"2019-01-10 03:20:35.000000000","message":"I would say when we enable multiple server groups, we will have a microversion anyway. But yes, both way is ok.","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"77a5b8a279cc45833e15b980fa5ff0609d6cee4c","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    {"},{"line_number":66,"context_line":"        \"server\": {"},{"line_number":67,"context_line":"            \"server_group\": \"0b5d2c72-12cc-4ba6-a8d7-3ff5cc1d8cb8\""},{"line_number":68,"context_line":"        }"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"dfd5e7cf_b976ec05","line":67,"range":{"start_line":67,"start_character":11,"end_line":67,"end_character":66},"in_reply_to":"dfd5e7cf_4bf04b68","updated":"2019-01-10 12:26:20.000000000","message":"Sure, I understand we can use microversions. I was just thinking that if we used a microversion, we\u0027d have *both* a \"server_group\" -\u003e scalar string *and* a \"server_groups\" -\u003e list of strings attribute which would be, well, yuck ;)","commit_id":"3195cb6422be73866e55f6d4328ed8ccc666b541"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0bb88428b9cf84ad12d571ac002f434286d70625","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposes to add the server-group name and UUID to \"GET /servers/{id}\". The"},{"line_number":33,"context_line":"server-group information will not be included in\"GET /servers/detail\" API,"},{"line_number":34,"context_line":"because the server-group information needs another DB query."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"dfd5e7cf_e03039eb","line":32,"range":{"start_line":32,"start_character":33,"end_line":32,"end_character":37},"updated":"2019-01-10 10:22:23.000000000","message":"REST API section proposes to return only UUID not name. Can you remove the name field here.","commit_id":"baea09430af579671d3741d912accb1dd537dd14"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0bb88428b9cf84ad12d571ac002f434286d70625","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposes to add the server-group name and UUID to \"GET /servers/{id}\". The"},{"line_number":33,"context_line":"server-group information will not be included in\"GET /servers/detail\" API,"},{"line_number":34,"context_line":"because the server-group information needs another DB query."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"dfd5e7cf_a3e0fbcd","line":32,"range":{"start_line":32,"start_character":51,"end_line":32,"end_character":54},"updated":"2019-01-10 10:22:23.000000000","message":"you can list PUT and Rebuild API also here for clear view about what all API will return server grp info","commit_id":"baea09430af579671d3741d912accb1dd537dd14"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"f531ce6f210b46c274018490dbb2d1cc40db0191","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposes to add the server-group name and UUID to \"GET /servers/{id}\". The"},{"line_number":33,"context_line":"server-group information will not be included in\"GET /servers/detail\" API,"},{"line_number":34,"context_line":"because the server-group information needs another DB query."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"dfd5e7cf_74be4b66","line":32,"range":{"start_line":32,"start_character":51,"end_line":32,"end_character":54},"in_reply_to":"dfd5e7cf_a3e0fbcd","updated":"2019-01-10 13:58:11.000000000","message":"Done","commit_id":"baea09430af579671d3741d912accb1dd537dd14"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"6c9fe35a447527534ef7fd1397458ab9cf474d15","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposes to add the server-group name and UUID to \"GET /servers/{id}\". The"},{"line_number":33,"context_line":"server-group information will not be included in\"GET /servers/detail\" API,"},{"line_number":34,"context_line":"because the server-group information needs another DB query."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"dfd5e7cf_19513863","line":32,"range":{"start_line":32,"start_character":33,"end_line":32,"end_character":37},"in_reply_to":"dfd5e7cf_e03039eb","updated":"2019-01-10 12:28:35.000000000","message":"+1 to @gmann\u0027s suggestions above.","commit_id":"baea09430af579671d3741d912accb1dd537dd14"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"f531ce6f210b46c274018490dbb2d1cc40db0191","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposes to add the server-group name and UUID to \"GET /servers/{id}\". The"},{"line_number":33,"context_line":"server-group information will not be included in\"GET /servers/detail\" API,"},{"line_number":34,"context_line":"because the server-group information needs another DB query."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"dfd5e7cf_343be3eb","line":32,"range":{"start_line":32,"start_character":33,"end_line":32,"end_character":37},"in_reply_to":"dfd5e7cf_e03039eb","updated":"2019-01-10 13:58:11.000000000","message":"Done","commit_id":"baea09430af579671d3741d912accb1dd537dd14"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0bb88428b9cf84ad12d571ac002f434286d70625","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    {"},{"line_number":65,"context_line":"        \"server\": {"},{"line_number":66,"context_line":"            \"server_groups\": ["},{"line_number":67,"context_line":"                   \"0b5d2c72-12cc-4ba6-a8d7-3ff5cc1d8cb8\""},{"line_number":68,"context_line":"            ]"},{"line_number":69,"context_line":"        }"},{"line_number":70,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":12,"id":"dfd5e7cf_00f9bdc6","line":67,"range":{"start_line":67,"start_character":14,"end_line":67,"end_character":57},"updated":"2019-01-10 10:22:23.000000000","message":"We can boot a server with server group and then we can delete that server group. I that case, UUID in server group response will be updated to null (as it would be able to find the server group where queried server is member of)? or it will keep showing the stale UUID to know that what grp server belonged to (I am not sure if that is useful in any case)?\n\nIt will be good to add that info in spec.","commit_id":"baea09430af579671d3741d912accb1dd537dd14"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"6c9fe35a447527534ef7fd1397458ab9cf474d15","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    {"},{"line_number":65,"context_line":"        \"server\": {"},{"line_number":66,"context_line":"            \"server_groups\": ["},{"line_number":67,"context_line":"                   \"0b5d2c72-12cc-4ba6-a8d7-3ff5cc1d8cb8\""},{"line_number":68,"context_line":"            ]"},{"line_number":69,"context_line":"        }"},{"line_number":70,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":12,"id":"dfd5e7cf_39d19cce","line":67,"range":{"start_line":67,"start_character":14,"end_line":67,"end_character":57},"in_reply_to":"dfd5e7cf_00f9bdc6","updated":"2019-01-10 12:28:35.000000000","message":"This information is not cached, so \"server_groups\" would be an empty list [] after the server group was deleted.","commit_id":"baea09430af579671d3741d912accb1dd537dd14"}]}