)]}'
{"specs/stein/approved/per-instance-libvirt-sysinfo-serial.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fbd4b433628cf41ff4e9315cf7f2ed3e33b5be24","unresolved":false,"context_lines":[{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"A new flavor extra spec ``hw:unique_serial`` and corresponding image property"},{"line_number":42,"context_line":"``hw_unique_serial`` will be introduced which when either is set to ``True``"},{"line_number":43,"context_line":"will result in the guest serial number being set to the instance UUID."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"If not set, the serial number in the guest will be based on the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_273f04b3","line":42,"range":{"start_line":42,"start_character":2,"end_line":42,"end_character":18},"updated":"2018-10-26 13:43:00.000000000","message":"Do we need the image metadata property? I know we typically add this stuff but...why?","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"77a05f4a7e299ab135ce60508d3ea799946f33b0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"A new flavor extra spec ``hw:unique_serial`` and corresponding image property"},{"line_number":42,"context_line":"``hw_unique_serial`` will be introduced which when either is set to ``True``"},{"line_number":43,"context_line":"will result in the guest serial number being set to the instance UUID."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"If not set, the serial number in the guest will be based on the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_e401b8b6","line":42,"range":{"start_line":42,"start_character":2,"end_line":42,"end_character":18},"in_reply_to":"3f79a3b5_273f04b3","updated":"2018-10-26 16:09:45.000000000","message":"Because the admin controls flavors but non-admins can upload their own images (in some clouds) and thus control the behavior.","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b2d89c67578afb75edd204935ba7f5f3799a34e4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"A new flavor extra spec ``hw:unique_serial`` and corresponding image property"},{"line_number":42,"context_line":"``hw_unique_serial`` will be introduced which when either is set to ``True``"},{"line_number":43,"context_line":"will result in the guest serial number being set to the instance UUID."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"If not set, the serial number in the guest will be based on the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_ebd472f2","line":42,"range":{"start_line":42,"start_character":2,"end_line":42,"end_character":18},"in_reply_to":"3f79a3b5_e401b8b6","updated":"2018-12-18 18:58:49.000000000","message":"also its posibly that the teant may be providing an image/licened software  and the licence for the software themselves rather then the cloud operator so in that case \nwe woudl want to allow them to activate this behavior via image metadata.","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"93f72aaea3ab7fc330798efb5211942cc480be8d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"A new flavor extra spec ``hw:unique_serial`` and corresponding image property"},{"line_number":42,"context_line":"``hw_unique_serial`` will be introduced which when either is set to ``True``"},{"line_number":43,"context_line":"will result in the guest serial number being set to the instance UUID."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"If not set, the serial number in the guest will be based on the"},{"line_number":46,"context_line":"``[libvirt]/sysinfo_serial`` configuration like it is currently."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_a5308855","line":46,"range":{"start_line":41,"start_character":0,"end_line":46,"end_character":64},"updated":"2018-10-29 08:21:27.000000000","message":"what kind of behavior do we want if we got conflicated extra_spec and image_property for this param?","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"45d778d8b254ddd21106e7bec7c007387b034839","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"A new flavor extra spec ``hw:unique_serial`` and corresponding image property"},{"line_number":42,"context_line":"``hw_unique_serial`` will be introduced which when either is set to ``True``"},{"line_number":43,"context_line":"will result in the guest serial number being set to the instance UUID."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"If not set, the serial number in the guest will be based on the"},{"line_number":46,"context_line":"``[libvirt]/sysinfo_serial`` configuration like it is currently."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_c64ca776","line":46,"range":{"start_line":41,"start_character":0,"end_line":46,"end_character":64},"in_reply_to":"3f79a3b5_a5308855","updated":"2018-10-29 14:01:10.000000000","message":"See the discussion on L103. I was planning on just relying on it being a boolean value and if either the image property value or flavor extra spec are True, then we set the per-instance serial.","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3930da7ecc4a1c469a1e0d4c68cbf91543035d6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"A new flavor extra spec ``hw:unique_serial`` and corresponding image property"},{"line_number":42,"context_line":"``hw_unique_serial`` will be introduced which when either is set to ``True``"},{"line_number":43,"context_line":"will result in the guest serial number being set to the instance UUID."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"If not set, the serial number in the guest will be based on the"},{"line_number":46,"context_line":"``[libvirt]/sysinfo_serial`` configuration like it is currently."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_5fee7c84","line":46,"range":{"start_line":41,"start_character":0,"end_line":46,"end_character":64},"in_reply_to":"3f79a3b5_bfbf90fd","updated":"2018-12-18 22:03:28.000000000","message":"i meant in the case wehre the value is not set maybe we should act as if it was set to true but i also accept the backwards compatibility argument. i dont really have a stong feeling one way or another i just feel more people may want to enable this behavior then disable it.","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"cb140d61f079094e02e73fc569801b2dc4853ade","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"A new flavor extra spec ``hw:unique_serial`` and corresponding image property"},{"line_number":42,"context_line":"``hw_unique_serial`` will be introduced which when either is set to ``True``"},{"line_number":43,"context_line":"will result in the guest serial number being set to the instance UUID."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"If not set, the serial number in the guest will be based on the"},{"line_number":46,"context_line":"``[libvirt]/sysinfo_serial`` configuration like it is currently."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_c99ef0f8","line":46,"range":{"start_line":41,"start_character":0,"end_line":46,"end_character":64},"in_reply_to":"3f79a3b5_c64ca776","updated":"2018-10-30 02:03:45.000000000","message":"Thinking agian, yes, this makes sense, and also, I guess nobody will set this param to false on popurse","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b2d89c67578afb75edd204935ba7f5f3799a34e4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"A new flavor extra spec ``hw:unique_serial`` and corresponding image property"},{"line_number":42,"context_line":"``hw_unique_serial`` will be introduced which when either is set to ``True``"},{"line_number":43,"context_line":"will result in the guest serial number being set to the instance UUID."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"If not set, the serial number in the guest will be based on the"},{"line_number":46,"context_line":"``[libvirt]/sysinfo_serial`` configuration like it is currently."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_cb0736c7","line":46,"range":{"start_line":41,"start_character":0,"end_line":46,"end_character":64},"in_reply_to":"3f79a3b5_c99ef0f8","updated":"2018-12-18 18:58:49.000000000","message":"out of interest is there a motivating counter usecase where we would want to have all vms on a host share a serial number? im wondering if we should default to true as it seams like that is more likely to be the behavior people would want.","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"443d7f2a90cb4d888b5754ce52fcb75bdcf86ad0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"A new flavor extra spec ``hw:unique_serial`` and corresponding image property"},{"line_number":42,"context_line":"``hw_unique_serial`` will be introduced which when either is set to ``True``"},{"line_number":43,"context_line":"will result in the guest serial number being set to the instance UUID."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"If not set, the serial number in the guest will be based on the"},{"line_number":46,"context_line":"``[libvirt]/sysinfo_serial`` configuration like it is currently."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_bfbf90fd","line":46,"range":{"start_line":41,"start_character":0,"end_line":46,"end_character":64},"in_reply_to":"3f79a3b5_cb0736c7","updated":"2018-12-18 21:33:28.000000000","message":"\u003e im wondering if we should default to true as it seams like that is more likely to be the behavior people would want.\n\nDefault to True where? The image property / flavor extra spec and/or config option? I guess Sam is the one that got me thinking about the default:\n\n\u003e LGTM it makes sense that this would be the default if it was backwards compatible?\n\nI\u0027m not sure what use case there is for all VMs on the same host having the same serial number. It might be a decent question for danpb if he remembers anything about this when he was working on the libvirt driver. At the same time I\u0027m a bit cautious about making that big a change, which is why I suggested below that we could add an choice to the existing config option so deployers that want unique serial numbers globally can do that, and for those that leave the defaults (per-host, auto) can have it overridden in flavors/images if needed by users.","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fbd4b433628cf41ff4e9315cf7f2ed3e33b5be24","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"A new choice could be added to the ``[libvirt]/sysinfo_serial`` option but"},{"line_number":52,"context_line":"then the behavior remains per-host rather than per-instance which could cause"},{"line_number":53,"context_line":"complications with scheduling or when upgrading the host if the host serial"},{"line_number":54,"context_line":"number changes."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We could also allow users to pass through a serial number UUID when creating"},{"line_number":57,"context_line":"a server and then pass that down through to the hypervisor, but that seems"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_07144841","line":54,"range":{"start_line":51,"start_character":0,"end_line":54,"end_character":15},"updated":"2018-10-26 13:43:00.000000000","message":"This was going to be my first question","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4006f396059686f5377a846daee88cc736a53b4c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"A new choice could be added to the ``[libvirt]/sysinfo_serial`` option but"},{"line_number":52,"context_line":"then the behavior remains per-host rather than per-instance which could cause"},{"line_number":53,"context_line":"complications with scheduling or when upgrading the host if the host serial"},{"line_number":54,"context_line":"number changes."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We could also allow users to pass through a serial number UUID when creating"},{"line_number":57,"context_line":"a server and then pass that down through to the hypervisor, but that seems"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_b3cb521a","line":54,"range":{"start_line":51,"start_character":0,"end_line":54,"end_character":15},"in_reply_to":"3f79a3b5_07144841","updated":"2018-11-21 14:09:08.000000000","message":"An argument could be made that we would still want an option in nova.conf for doing this per-instance serial number using the instance UUID so a deployment could set it globally and forget it, rather than have to set the flavor extra spec and/or image property in all of their flavors/images.","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"443d7f2a90cb4d888b5754ce52fcb75bdcf86ad0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"A new choice could be added to the ``[libvirt]/sysinfo_serial`` option but"},{"line_number":52,"context_line":"then the behavior remains per-host rather than per-instance which could cause"},{"line_number":53,"context_line":"complications with scheduling or when upgrading the host if the host serial"},{"line_number":54,"context_line":"number changes."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We could also allow users to pass through a serial number UUID when creating"},{"line_number":57,"context_line":"a server and then pass that down through to the hypervisor, but that seems"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_bf0230b7","line":54,"range":{"start_line":51,"start_character":0,"end_line":54,"end_character":15},"in_reply_to":"3f79a3b5_0ed0dc29","updated":"2018-12-18 21:33:28.000000000","message":"I\u0027m not sure what you\u0027re saying Sean. I\u0027m -1 on config that is only used in the compute service being read in the API (like how reclaim_instance_interval works). [libvirt]/sysinfo_serial is already the config option we have, which already defaults to \u0027auto\u0027 which is per-host serial (all VMs on the host have the same serial number, but it will change as VMs get migrated across hosts). The image property/flavor extra spec option is a way for users to override that behavior.","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2a03a0d6403e18cdfeaee345aaeef82f1be90bd2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"A new choice could be added to the ``[libvirt]/sysinfo_serial`` option but"},{"line_number":52,"context_line":"then the behavior remains per-host rather than per-instance which could cause"},{"line_number":53,"context_line":"complications with scheduling or when upgrading the host if the host serial"},{"line_number":54,"context_line":"number changes."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We could also allow users to pass through a serial number UUID when creating"},{"line_number":57,"context_line":"a server and then pass that down through to the hypervisor, but that seems"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffd0ebdf_fbe58a39","line":54,"range":{"start_line":51,"start_character":0,"end_line":54,"end_character":15},"in_reply_to":"3f79a3b5_3f9f00f8","updated":"2019-01-04 08:33:32.000000000","message":"I\u0027m not sure I understand this sentence: \"could cause complications with scheduling or when upgrading the host if the host serial number changes.\"\n\nIf a new choice sysinfo_serial\u003d\u0027instance\u0027 were to be added, it would use each instance\u0027s UUID as the instance serial, so how is that related to the host serial number changing? I\u0027m confused.","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cc4262494bc41b0cc578a2f3c8e3b43f2f48557a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"A new choice could be added to the ``[libvirt]/sysinfo_serial`` option but"},{"line_number":52,"context_line":"then the behavior remains per-host rather than per-instance which could cause"},{"line_number":53,"context_line":"complications with scheduling or when upgrading the host if the host serial"},{"line_number":54,"context_line":"number changes."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We could also allow users to pass through a serial number UUID when creating"},{"line_number":57,"context_line":"a server and then pass that down through to the hypervisor, but that seems"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_0b4a0e59","line":54,"range":{"start_line":51,"start_character":0,"end_line":54,"end_character":15},"in_reply_to":"3f79a3b5_b3cb521a","updated":"2018-12-18 17:50:05.000000000","message":"I think if we add it as a choice to the config option, I would not make it the default, at least not in Stein, and leave the current default (auto) but allow admins to set it globally for new installs (or new AZs).","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b2d89c67578afb75edd204935ba7f5f3799a34e4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"A new choice could be added to the ``[libvirt]/sysinfo_serial`` option but"},{"line_number":52,"context_line":"then the behavior remains per-host rather than per-instance which could cause"},{"line_number":53,"context_line":"complications with scheduling or when upgrading the host if the host serial"},{"line_number":54,"context_line":"number changes."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We could also allow users to pass through a serial number UUID when creating"},{"line_number":57,"context_line":"a server and then pass that down through to the hypervisor, but that seems"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_0ed0dc29","line":54,"range":{"start_line":51,"start_character":0,"end_line":54,"end_character":15},"in_reply_to":"3f79a3b5_b3cb521a","updated":"2018-12-18 18:58:49.000000000","message":"that argument would not be unresonable\ni think that would be equally viable but\nit does limit flexablity somewhat.\n\nperhaps a nova.conf value to specify the cloud default in addition to the extra specs/image meta would be good to consider?\n\npresumably the value could be read by the api nodes and then set on the request spec if and only if not set in the flavor or image.\n\nthat said i think im fine with the current propsal too.","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3930da7ecc4a1c469a1e0d4c68cbf91543035d6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"A new choice could be added to the ``[libvirt]/sysinfo_serial`` option but"},{"line_number":52,"context_line":"then the behavior remains per-host rather than per-instance which could cause"},{"line_number":53,"context_line":"complications with scheduling or when upgrading the host if the host serial"},{"line_number":54,"context_line":"number changes."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We could also allow users to pass through a serial number UUID when creating"},{"line_number":57,"context_line":"a server and then pass that down through to the hypervisor, but that seems"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_3f9f00f8","line":54,"range":{"start_line":51,"start_character":0,"end_line":54,"end_character":15},"in_reply_to":"3f79a3b5_bf0230b7","updated":"2018-12-18 22:03:28.000000000","message":"sorry i misread this\n\nfor some reason  i read [libvirt]/sysinfo_serial \nas refing to a file on the host e.g.\n/etc/libvirt/sysinfo_serial so it did not click that\nthere was alread a config on the compute host that contols this behavior.\n\nyou were refering to https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.sysinfo_serial\n\nwhen you said \"leave the current default (auto) but allow admins to set it globally\" i take it you ment use there config management tool to set it on each compute node to the new value.  \n\nbecause it did not register with me that the config option already was available i parsed it as introduce a new config option in one location that would change the default for the entire cloud. the only place i could think of where you would do that is the nova api which could set a value in the  requst spec but you are right that is dumb. ignoring everything else the api cannot know that the compute node will be using libvirt so it should not set driver specific options in the requst spec.\n\nadding a new option \"instance\" to sysinfo_serial dose seam like a good option however it does not cover the teanat use case where they are providing the licensed software not the operator.\n\nthere are pros and cons to both is it worth considering doing both? the nova.conf would allow operator to not have to modify there flavors to get this behavior.\n\nas i said in my initial review however i think the current spec as written is fine so this is just an open question rather then even a nit.\n\nhopefully this is a little more coherent i was slight distracted earlier.","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c348c9dea679a931b0b7ed636cf23db53d95246b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"A new choice could be added to the ``[libvirt]/sysinfo_serial`` option but"},{"line_number":52,"context_line":"then the behavior remains per-host rather than per-instance which could cause"},{"line_number":53,"context_line":"complications with scheduling or when upgrading the host if the host serial"},{"line_number":54,"context_line":"number changes."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We could also allow users to pass through a serial number UUID when creating"},{"line_number":57,"context_line":"a server and then pass that down through to the hypervisor, but that seems"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffd0ebdf_18bf26fc","line":54,"range":{"start_line":51,"start_character":0,"end_line":54,"end_character":15},"in_reply_to":"ffd0ebdf_fbe58a39","updated":"2019-01-04 19:35:04.000000000","message":"\u003e I\u0027m not sure I understand this sentence: \"could cause complications\n \u003e with scheduling or when upgrading the host if the host serial\n \u003e number changes.\"\n \u003e \n \u003e If a new choice sysinfo_serial\u003d\u0027instance\u0027 were to be added, it\n \u003e would use each instance\u0027s UUID as the instance serial, so how is\n \u003e that related to the host serial number changing? I\u0027m confused.\n\nReading that back I\u0027m not sure what I was saying wrt host upgrades and the serial number changing. I think the scheduling concern is more just about having one behavior on one host (maybe the serial on that host comes from the hardware or OS) and on another host it is the instance UUID, but that\u0027s not worse than what we have today where you\u0027re guaranteed to get a different serial number when the VM moves to another host.","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fbd4b433628cf41ff4e9315cf7f2ed3e33b5be24","unresolved":false,"context_lines":[{"line_number":62,"context_line":"for pirating software unless a unique constraint was put in place, but even"},{"line_number":63,"context_line":"then it would have to span an entire deployment (per-cell DB restrictions would"},{"line_number":64,"context_line":"not be good enough)."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Data model impact"},{"line_number":67,"context_line":"-----------------"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_072d288f","line":65,"updated":"2018-10-26 13:43:00.000000000","message":"Is there any reason to keep the host-level config opt around? Could we just move that whole thing into flavor extra specs, assuming a default value of \u0027none\u0027?","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"77a05f4a7e299ab135ce60508d3ea799946f33b0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"for pirating software unless a unique constraint was put in place, but even"},{"line_number":63,"context_line":"then it would have to span an entire deployment (per-cell DB restrictions would"},{"line_number":64,"context_line":"not be good enough)."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Data model impact"},{"line_number":67,"context_line":"-----------------"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_64f5a8cb","line":65,"in_reply_to":"3f79a3b5_072d288f","updated":"2018-10-26 16:09:45.000000000","message":"Well, the default on the config option is \u0027auto\u0027, not \u0027none\u0027. And that\u0027s going to be a massive upgrade change for any cloud that has non-default config of that option, right? That doesn\u0027t seem worth it. If you want host level config, you can do it. If you want per-instance config, you can provide that override via flavors/image meta.","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fbd4b433628cf41ff4e9315cf7f2ed3e33b5be24","unresolved":false,"context_lines":[{"line_number":100,"context_line":"---------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Operators that wish to expose this functionality can do so by adding the"},{"line_number":103,"context_line":"extra spec to their flavors and/or images. If they want to restrict the"},{"line_number":104,"context_line":"functionality to a set of compute hosts, that can also be done by restricting"},{"line_number":105,"context_line":"enabled flavors/images to host aggregates."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_479320a5","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":41},"updated":"2018-10-26 13:43:00.000000000","message":"Users are often allowed upload their own images, right? If so, are there any potentially harmful side effects to doing so? We raise exceptions if there are conflicts for other extra spec/image metadata properties, which also provides a way for operators to prevent users settings these attributes (the operator can simply configure the desired behavior in their flavor to ensure an exception is raised if the user tries to configure it)","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"745113435033e156af8bb4efdf790fce4c717816","unresolved":false,"context_lines":[{"line_number":100,"context_line":"---------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Operators that wish to expose this functionality can do so by adding the"},{"line_number":103,"context_line":"extra spec to their flavors and/or images. If they want to restrict the"},{"line_number":104,"context_line":"functionality to a set of compute hosts, that can also be done by restricting"},{"line_number":105,"context_line":"enabled flavors/images to host aggregates."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_669d93b8","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":41},"in_reply_to":"3f79a3b5_1215123e","updated":"2018-10-29 14:02:47.000000000","message":"I also don\u0027t know why an admin would explicitly set the flag to False in a flavor or an image. I would think the vast majority of usage for this would be simply setting the flag to True in images and for everything else leaving it unset so you get whatever is configured per host.","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"08468b00bb1e6045fed97ebd28f20d0e4fece11c","unresolved":false,"context_lines":[{"line_number":100,"context_line":"---------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Operators that wish to expose this functionality can do so by adding the"},{"line_number":103,"context_line":"extra spec to their flavors and/or images. If they want to restrict the"},{"line_number":104,"context_line":"functionality to a set of compute hosts, that can also be done by restricting"},{"line_number":105,"context_line":"enabled flavors/images to host aggregates."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_1215123e","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":41},"in_reply_to":"3f79a3b5_241490e9","updated":"2018-10-26 17:24:15.000000000","message":"\u003e Maybe an argument could be made that if the flag is set in the\n \u003e image property, that takes precedence over the flavor. I think\n \u003e that\u0027s usually what we do, although I always have to think about\n \u003e this because we\u0027ve never documented it in our contributor docs.\n\nWe do the opposite for things like \u0027hw_cpu_policy\u0027 because we don\u0027t want users requested dedicated cores that they\u0027re not paying for. However, there are definitely inconsistencies here (I had a spec about it at one point). We can debate this in the code.","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"77a05f4a7e299ab135ce60508d3ea799946f33b0","unresolved":false,"context_lines":[{"line_number":100,"context_line":"---------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Operators that wish to expose this functionality can do so by adding the"},{"line_number":103,"context_line":"extra spec to their flavors and/or images. If they want to restrict the"},{"line_number":104,"context_line":"functionality to a set of compute hosts, that can also be done by restricting"},{"line_number":105,"context_line":"enabled flavors/images to host aggregates."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_241490e9","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":41},"in_reply_to":"3f79a3b5_479320a5","updated":"2018-10-26 16:09:45.000000000","message":"\u003e Users are often allowed upload their own images, right?\n\nDepends on the cloud but yes.\n\n\u003e If so, are there any potentially harmful side effects to doing so?\n\nI can\u0027t really think of any...this is really more about the application in the guest, which the operator shouldn\u0027t really have any knowledge of, or care about.\n\nWe do, at times, have code that needs to check for inconsistencies between values to the same key in image meta and flavor extra specs, but since this is a boolean, I think the logic is pretty simple:\n\nunique_serial \u003d image.properties.hw_unique_serial or flavor.extra_specs.get(\u0027hw:unique_serial\u0027, False)\n\nMaybe an argument could be made that if the flag is set in the image property, that takes precedence over the flavor. I think that\u0027s usually what we do, although I always have to think about this because we\u0027ve never documented it in our contributor docs.","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b2d89c67578afb75edd204935ba7f5f3799a34e4","unresolved":false,"context_lines":[{"line_number":100,"context_line":"---------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Operators that wish to expose this functionality can do so by adding the"},{"line_number":103,"context_line":"extra spec to their flavors and/or images. If they want to restrict the"},{"line_number":104,"context_line":"functionality to a set of compute hosts, that can also be done by restricting"},{"line_number":105,"context_line":"enabled flavors/images to host aggregates."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_8bc4de62","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":41},"in_reply_to":"3f79a3b5_669d93b8","updated":"2018-12-18 18:58:49.000000000","message":"are there licensing models that we are aware of that are host based. e.g. you can have unlimited vms on a host share the hosts liciense. i think this is how windows licnese work for hyperv where you pay per core on the hyperv host and can run unlimited windows guest on that host as the guest license are included in the windows server licene for the host.\n\nthat is the only case i can think of where they might want to share host serial number but even then im not sure that is how that works.\n\nthe main question i have when revieing this is is there a case where we woudl want this to ever be false?","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"443d7f2a90cb4d888b5754ce52fcb75bdcf86ad0","unresolved":false,"context_lines":[{"line_number":100,"context_line":"---------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Operators that wish to expose this functionality can do so by adding the"},{"line_number":103,"context_line":"extra spec to their flavors and/or images. If they want to restrict the"},{"line_number":104,"context_line":"functionality to a set of compute hosts, that can also be done by restricting"},{"line_number":105,"context_line":"enabled flavors/images to host aggregates."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_7f19f821","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":41},"in_reply_to":"3f79a3b5_8bc4de62","updated":"2018-12-18 21:33:28.000000000","message":"\u003e are there licensing models that we are aware of that are host based. e.g. you can have unlimited vms on a host share the hosts liciense. i think this is how windows licnese work for hyperv where you pay per core on the hyperv host and can run unlimited windows guest on that host as the guest license are included in the windows server licene for the host.\n\nI\u0027m not sure, but that sounds reasonable. Might be good to ask Claudiu if he knows how licensing works with hyperv, or maybe operators that restrict windows VMs to certain host aggregates because of the licenses.","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fbd4b433628cf41ff4e9315cf7f2ed3e33b5be24","unresolved":false,"context_lines":[{"line_number":118,"context_line":"if a user was requesting a server with the property, but the serial in the"},{"line_number":119,"context_line":"guest did not match the instance UUID, they could be confused about why it"},{"line_number":120,"context_line":"does not work. Again, operators can control this by deciding when to enable"},{"line_number":121,"context_line":"the feature or by restricting it to certain host aggregates."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_07de886a","line":121,"range":{"start_line":121,"start_character":15,"end_line":121,"end_character":60},"updated":"2018-10-26 13:43:00.000000000","message":"How does one restrict this stuff? The image/flavor conflict I noted above or by some other means?","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"77a05f4a7e299ab135ce60508d3ea799946f33b0","unresolved":false,"context_lines":[{"line_number":118,"context_line":"if a user was requesting a server with the property, but the serial in the"},{"line_number":119,"context_line":"guest did not match the instance UUID, they could be confused about why it"},{"line_number":120,"context_line":"does not work. Again, operators can control this by deciding when to enable"},{"line_number":121,"context_line":"the feature or by restricting it to certain host aggregates."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_24c25055","line":121,"range":{"start_line":121,"start_character":15,"end_line":121,"end_character":60},"in_reply_to":"3f79a3b5_07de886a","updated":"2018-10-26 16:09:45.000000000","message":"https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#aggregateimagepropertiesisolation\n\nhttps://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#aggregateinstanceextraspecsfilter\n\nYou restrict images/flavors to host aggregates based on matching metadata keys on the aggregate. For example, this is a common pattern for restricting baremetal flavors to baremetal-managing ironic driver hosts, or windows images to hyper-v hosts.","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"08468b00bb1e6045fed97ebd28f20d0e4fece11c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"if a user was requesting a server with the property, but the serial in the"},{"line_number":119,"context_line":"guest did not match the instance UUID, they could be confused about why it"},{"line_number":120,"context_line":"does not work. Again, operators can control this by deciding when to enable"},{"line_number":121,"context_line":"the feature or by restricting it to certain host aggregates."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_d2247ab4","line":121,"range":{"start_line":121,"start_character":15,"end_line":121,"end_character":60},"in_reply_to":"3f79a3b5_24c25055","updated":"2018-10-26 17:24:15.000000000","message":"The more you know","commit_id":"3462e0de1f3237dce5f1f63202a38a770d741752"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"fb250fe4474b45f17126f4173d121dbbd9e55fc3","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"To allow users to control this behavior (if the cloud provides it), a new"},{"line_number":42,"context_line":"flavor extra spec ``hw:unique_serial`` and corresponding image property"},{"line_number":43,"context_line":"``hw_unique_serial`` will be introduced which when either is set to ``True``"},{"line_number":44,"context_line":"will result in the guest serial number being set to the instance UUID."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"For operators that just want per-instance serial numbers either globally"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_26bbbe72","line":43,"range":{"start_line":43,"start_character":68,"end_line":43,"end_character":76},"updated":"2019-01-10 05:41:02.000000000","message":"The only available value is True? Is it False vaild? What happened when the value is False, and the configuration option is unique?\n\nI think the \u0027True\u0027 should be only value. And the extra spec always override the config option.\n\nI guess if both set the extra spec and image metadata, we should reject the request.","commit_id":"f445d49a4bf6b0cd6c2d916dc2750f685d716e09"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d9dce4ec205c099ca90eb4d65beda816feeceb4c","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"To allow users to control this behavior (if the cloud provides it), a new"},{"line_number":42,"context_line":"flavor extra spec ``hw:unique_serial`` and corresponding image property"},{"line_number":43,"context_line":"``hw_unique_serial`` will be introduced which when either is set to ``True``"},{"line_number":44,"context_line":"will result in the guest serial number being set to the instance UUID."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"For operators that just want per-instance serial numbers either globally"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfdaf3ff_a83eba26","line":43,"range":{"start_line":43,"start_character":68,"end_line":43,"end_character":76},"in_reply_to":"bfdaf3ff_ea114b55","updated":"2019-01-14 15:55:54.000000000","message":"Yeah I think of this more like a tag than flavor extra spec/image property I guess...where its presence equates to True.","commit_id":"f445d49a4bf6b0cd6c2d916dc2750f685d716e09"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"a5032b9f9bd55facdf65d81a8348e6961a3c154b","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"To allow users to control this behavior (if the cloud provides it), a new"},{"line_number":42,"context_line":"flavor extra spec ``hw:unique_serial`` and corresponding image property"},{"line_number":43,"context_line":"``hw_unique_serial`` will be introduced which when either is set to ``True``"},{"line_number":44,"context_line":"will result in the guest serial number being set to the instance UUID."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"For operators that just want per-instance serial numbers either globally"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfdaf3ff_ea114b55","line":43,"range":{"start_line":43,"start_character":68,"end_line":43,"end_character":76},"in_reply_to":"dfd5e7cf_26bbbe72","updated":"2019-01-11 01:31:20.000000000","message":"I asked this few patchsets ago, for the extra spec + image metadata case, we will use ``or`` so if one of them is set then we will treat it as True and dont need to reject the request.","commit_id":"f445d49a4bf6b0cd6c2d916dc2750f685d716e09"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"405e7b56390b8c0905db644d54724168f5c7aa1e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"existing ``[libvirt]/sysinfo_serial`` configuration which if set will result"},{"line_number":49,"context_line":"in the guest serial number being set to the instance UUID. Note that the"},{"line_number":50,"context_line":"default value for the option will not change as part of this blueprint."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"The flavor/image value, if set, supersedes the host configuration."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_f93119ee","line":51,"updated":"2019-01-07 14:57:46.000000000","message":"for other drivers but libvirtd, is it possible to pass a specific serial number ?","commit_id":"f445d49a4bf6b0cd6c2d916dc2750f685d716e09"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"405e7b56390b8c0905db644d54724168f5c7aa1e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Allowing the user to specify a serial number could also potentially be abused"},{"line_number":63,"context_line":"for pirating software unless a unique constraint was put in place, but even"},{"line_number":64,"context_line":"then it would have to span an entire deployment (per-cell DB restrictions would"},{"line_number":65,"context_line":"not be good enough)."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Data model impact"},{"line_number":68,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_193bbdd1","line":65,"updated":"2019-01-07 14:57:46.000000000","message":"There could be many ways to do this, but I\u0027m fine with a flavor extra spec.","commit_id":"f445d49a4bf6b0cd6c2d916dc2750f685d716e09"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d7a714e98ae7885b51d38314896ba5f57a573705","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Allowing the user to specify a serial number could also potentially be abused"},{"line_number":63,"context_line":"for pirating software unless a unique constraint was put in place, but even"},{"line_number":64,"context_line":"then it would have to span an entire deployment (per-cell DB restrictions would"},{"line_number":65,"context_line":"not be good enough)."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Data model impact"},{"line_number":68,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fdfeff1_8aaa8dcf","line":65,"in_reply_to":"9fdfeff1_a4ea2a72","updated":"2019-01-25 16:20:45.000000000","message":"\u003e I don\u0027t really understand why this is even a metadata/extra-spec at\n \u003e all. What is the issue with just always setting the libvirt\n \u003e sysinfo_serial value to the instance\u0027s UUID? What precisely would\n \u003e break if we did that? :(\n\nWhy the sysinfo_serial code in the libvirt driver was never guest specific is a question for danpb, I don\u0027t have the history there and couldn\u0027t find it from the original code changes.\n\nThe issue with just always doing unique *now* is backward compatibility, although it\u0027s hard to argue this is something that was a hard contract to begin with depending on the hypervisor your VM lands on and the fact that moving the VM to another host would change the serial anyway.","commit_id":"f445d49a4bf6b0cd6c2d916dc2750f685d716e09"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"cf15243e9cd22172a0930a5030950b5e8e1881a4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Allowing the user to specify a serial number could also potentially be abused"},{"line_number":63,"context_line":"for pirating software unless a unique constraint was put in place, but even"},{"line_number":64,"context_line":"then it would have to span an entire deployment (per-cell DB restrictions would"},{"line_number":65,"context_line":"not be good enough)."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Data model impact"},{"line_number":68,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fdfeff1_a4ea2a72","line":65,"in_reply_to":"dfd5e7cf_193bbdd1","updated":"2019-01-25 15:13:43.000000000","message":"I don\u0027t really understand why this is even a metadata/extra-spec at all. What is the issue with just always setting the libvirt sysinfo_serial value to the instance\u0027s UUID? What precisely would break if we did that? :(","commit_id":"f445d49a4bf6b0cd6c2d916dc2750f685d716e09"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"fb250fe4474b45f17126f4173d121dbbd9e55fc3","unresolved":false,"context_lines":[{"line_number":101,"context_line":"---------------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Operators that wish to expose this functionality can do so by adding the"},{"line_number":104,"context_line":"extra spec to their flavors and/or images or setting"},{"line_number":105,"context_line":"``[libvirt]/sysinfo_serial\u003dunique`` in nova configuration. If they want to"},{"line_number":106,"context_line":"restrict the functionality to a set of compute hosts, that can also be done by"},{"line_number":107,"context_line":"restricting enabled flavors/images to host aggregates."},{"line_number":108,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_a6f80e49","line":105,"range":{"start_line":104,"start_character":46,"end_line":105,"end_character":34},"updated":"2019-01-10 05:41:02.000000000","message":"If there already have some instance running on the host. Then we change the will of this option after instance did a stop and start, the serial number will be changed. Then we break the software license again.\n\nWe should notice deployer that they should be careful the value change for this option when there are instances running on the host.","commit_id":"f445d49a4bf6b0cd6c2d916dc2750f685d716e09"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae86fabac07f115fef7c792148912180c23cb0dc","unresolved":false,"context_lines":[{"line_number":101,"context_line":"---------------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Operators that wish to expose this functionality can do so by adding the"},{"line_number":104,"context_line":"extra spec to their flavors and/or images or setting"},{"line_number":105,"context_line":"``[libvirt]/sysinfo_serial\u003dunique`` in nova configuration. If they want to"},{"line_number":106,"context_line":"restrict the functionality to a set of compute hosts, that can also be done by"},{"line_number":107,"context_line":"restricting enabled flavors/images to host aggregates."},{"line_number":108,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfdaf3ff_282baaeb","line":105,"range":{"start_line":104,"start_character":46,"end_line":105,"end_character":34},"in_reply_to":"dfd5e7cf_a6f80e49","updated":"2019-01-14 15:54:58.000000000","message":"That could go into the documentation of the option/choice itself.","commit_id":"f445d49a4bf6b0cd6c2d916dc2750f685d716e09"}]}
