)]}'
{"id":"openstack%2Fnova-specs~612949","triplet_id":"openstack%2Fnova-specs~master~I6a9d0a2f2b918c82b6f56e601f821362a50ff7ce","project":"openstack/nova-specs","branch":"master","topic":"bp/support-delete-on-termination-in-server-attach-volume","hashtags":[],"change_id":"I6a9d0a2f2b918c82b6f56e601f821362a50ff7ce","subject":"Support delete_on_termination in volume attach api","status":"MERGED","created":"2018-10-24 08:44:29.000000000","updated":"2019-07-26 02:13:10.000000000","submitted":"2019-07-25 20:09:41.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":23,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"612949-1564085381633-c3a5ce02","meta_rev_id":"f9f6a531da6cdd5558c91fd0ab7a03864ccf44e9","_number":612949,"virtual_id_number":612949,"owner":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-07-25 20:09:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22378,"name":"Kaiyuan Qi","email":"qiky@inspur.com","username":"qiky"},{"value":0,"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},{"value":0,"_account_id":30200,"name":"qinhaizhong","email":"qinhaizhong01@inspur.com","username":"qinhaizhong01"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":30395,"name":"Arthur Dayne","display_name":"Arthur Dayne","email":"palagend@foxmail.com","username":"acewit"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":30384,"name":"zhangboye","email":"zhangby09@chinatelecom.cn","username":"zhangboye"},{"value":0,"_account_id":23312,"name":"kangyufei","email":"kangyf@inspur.com","username":"kangyufei"},{"value":0,"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22378,"name":"Kaiyuan Qi","email":"qiky@inspur.com","username":"qiky"},{"value":0,"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},{"value":0,"_account_id":30200,"name":"qinhaizhong","email":"qinhaizhong01@inspur.com","username":"qinhaizhong01"},{"value":2,"date":"2019-07-25 19:47:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":30395,"name":"Arthur Dayne","display_name":"Arthur Dayne","email":"palagend@foxmail.com","username":"acewit"},{"value":2,"date":"2019-07-25 20:01:20.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":30384,"name":"zhangboye","email":"zhangby09@chinatelecom.cn","username":"zhangboye"},{"value":0,"_account_id":23312,"name":"kangyufei","email":"kangyf@inspur.com","username":"kangyufei"},{"value":0,"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22378,"name":"Kaiyuan Qi","email":"qiky@inspur.com","username":"qiky"},{"value":0,"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},{"value":0,"_account_id":30200,"name":"qinhaizhong","email":"qinhaizhong01@inspur.com","username":"qinhaizhong01"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":30395,"name":"Arthur Dayne","display_name":"Arthur Dayne","email":"palagend@foxmail.com","username":"acewit"},{"value":1,"date":"2019-07-25 20:01:20.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":30384,"name":"zhangboye","email":"zhangby09@chinatelecom.cn","username":"zhangboye"},{"value":0,"_account_id":23312,"name":"kangyufei","email":"kangyf@inspur.com","username":"kangyufei"},{"value":0,"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22378,"name":"Kaiyuan Qi","email":"qiky@inspur.com","username":"qiky"},{"value":0,"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},{"value":0,"_account_id":30200,"name":"qinhaizhong","email":"qinhaizhong01@inspur.com","username":"qinhaizhong01"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":30395,"name":"Arthur Dayne","display_name":"Arthur Dayne","email":"palagend@foxmail.com","username":"acewit"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":30384,"name":"zhangboye","email":"zhangby09@chinatelecom.cn","username":"zhangboye"},{"value":0,"_account_id":23312,"name":"kangyufei","email":"kangyf@inspur.com","username":"kangyufei"},{"value":0,"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22378,"name":"Kaiyuan Qi","email":"qiky@inspur.com","username":"qiky"},{"_account_id":23312,"name":"kangyufei","email":"kangyf@inspur.com","username":"kangyufei"},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},{"_account_id":30200,"name":"qinhaizhong","email":"qinhaizhong01@inspur.com","username":"qinhaizhong01"},{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},{"_account_id":30384,"name":"zhangboye","email":"zhangby09@chinatelecom.cn","username":"zhangboye"},{"_account_id":30395,"name":"Arthur Dayne","display_name":"Arthur Dayne","email":"palagend@foxmail.com","username":"acewit"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-10-29 10:15:50.000000000","updated_by":{"_account_id":22378,"name":"Kaiyuan Qi","email":"qiky@inspur.com","username":"qiky"},"reviewer":{"_account_id":22378,"name":"Kaiyuan Qi","email":"qiky@inspur.com","username":"qiky"},"state":"REVIEWER"},{"updated":"2018-11-06 08:13:41.000000000","updated_by":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"reviewer":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"state":"REVIEWER"},{"updated":"2019-07-25 05:59:47.000000000","updated_by":{"_account_id":30384,"name":"zhangboye","email":"zhangby09@chinatelecom.cn","username":"zhangboye"},"reviewer":{"_account_id":30384,"name":"zhangboye","email":"zhangby09@chinatelecom.cn","username":"zhangboye"},"state":"REVIEWER"},{"updated":"2019-07-25 06:00:47.000000000","updated_by":{"_account_id":30200,"name":"qinhaizhong","email":"qinhaizhong01@inspur.com","username":"qinhaizhong01"},"reviewer":{"_account_id":30200,"name":"qinhaizhong","email":"qinhaizhong01@inspur.com","username":"qinhaizhong01"},"state":"REVIEWER"},{"updated":"2019-07-25 06:00:49.000000000","updated_by":{"_account_id":23312,"name":"kangyufei","email":"kangyf@inspur.com","username":"kangyufei"},"reviewer":{"_account_id":23312,"name":"kangyufei","email":"kangyf@inspur.com","username":"kangyufei"},"state":"REVIEWER"},{"updated":"2019-07-25 06:01:32.000000000","updated_by":{"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},"reviewer":{"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},"state":"REVIEWER"},{"updated":"2019-07-25 06:04:47.000000000","updated_by":{"_account_id":30395,"name":"Arthur Dayne","display_name":"Arthur Dayne","email":"palagend@foxmail.com","username":"acewit"},"reviewer":{"_account_id":30395,"name":"Arthur Dayne","display_name":"Arthur Dayne","email":"palagend@foxmail.com","username":"acewit"},"state":"REVIEWER"},{"updated":"2019-07-25 06:16:32.000000000","updated_by":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"reviewer":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"state":"REVIEWER"},{"updated":"2019-07-25 09:11:19.000000000","updated_by":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"reviewer":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"state":"REVIEWER"},{"updated":"2019-07-25 12:25:22.000000000","updated_by":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"reviewer":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"state":"REVIEWER"},{"updated":"2019-07-25 12:25:24.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2019-07-25 12:25:27.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-07-25 19:47:43.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-07-25 20:01:20.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-07-25 20:09:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9c6abbb543e359e73eb68531eefa80d44dae863c","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2018-10-24 08:44:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"313aa8b4bf3522de695865ead9921106e209b379","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2018-10-24 08:53:51.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"30bda0262f138340232cc4953f8a2dfc73c62a3c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-24 09:55:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/49/612949/1/check/openstack-tox-docs/5c6a0ab/html/ : SUCCESS in 5m 10s\n- openstack-tox-pep8 http://logs.openstack.org/49/612949/1/check/openstack-tox-pep8/684ff80/ : SUCCESS in 6m 47s","accounts_in_message":[],"_revision_number":1},{"id":"82b3269394e9ceb28e9f007a9613cb238f0c2946","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-11-01 15:05:22.000000000","message":"Patch Set 1:\n\nWhat is the difference between this spec and https://review.openstack.org/#/c/580336/ ? I\u0027m confused as to why we need two specs.","accounts_in_message":[],"_revision_number":1},{"id":"76a7f6d04ccb6cf2dac1dba4529461428f04c4f3","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-11-01 15:28:26.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nI think this could/should be combined with the other spec, we don\u0027t really need two separate specs for essentially the same end goal - being able to control the delete_on_termination flag for volume attachments, either that being updating existing attachments from server create or when attaching new data volumes to an existing server.","accounts_in_message":[],"_revision_number":1},{"id":"a166762c3661b6625b826ffce180c4569dbbfd1f","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2018-11-02 08:02:05.000000000","message":"Patch Set 1:\n\n(1 comment)\n\n\u003e What is the difference between this spec and https://review.openstack.org/#/c/580336/\n \u003e ? I\u0027m confused as to why we need two specs.\n\nThanks Matt for your reveiw.\nThis spec implements the configuration of delete_on_termination when attaching a volume to the server. The other is the delete_on_termination of the volume attached to the server, you can update its value True or False.\nHmm...This can be combined with *that* spec, but I don\u0027t recommend it.\nBecause I think this spec is relatively simple to implement, the requirements are clear, and easier to understand. Another API interface to the implementation of the choice is controversial.\nIf I put them together, the application should look bad and misleading. But these two specs can be done at the same time.\nIf you insist your opinion, I can combine them :P","accounts_in_message":[],"_revision_number":1},{"id":"9c79a39518a16ffbbdac2d17c372b31965d8686d","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2018-11-02 08:23:42.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e488b34438d2f67066a78c063b1b2f86cdf12941","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-02 08:33:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/49/612949/2/check/openstack-tox-docs/6f95f5a/html/ : SUCCESS in 6m 24s\n- openstack-tox-pep8 http://logs.openstack.org/49/612949/2/check/openstack-tox-pep8/4f8079e/ : SUCCESS in 4m 27s","accounts_in_message":[],"_revision_number":2},{"id":"97f148794f7bd73038aa66c7989183bfe1cb1160","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2018-11-06 08:13:41.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0080d29761bcb8f1a65cdc3c55c623dd22e41db8","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2018-11-06 08:23:43.000000000","message":"Patch Set 2:\n\nLatter, thinking again, this seems OK as data on the volume belongs to users too, it could be safer to delete them too. But you should combine this one to the other patch, since they are actully similar operation, and lets not add two microversion for this.","accounts_in_message":[],"_revision_number":2},{"id":"f3c1a9e2ea8c049e7bdef81bc30e5a6d3adfd158","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2018-11-06 08:31:50.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"84151a971c7c2c3d0dec137c6883d5e09406760b","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2018-11-06 08:55:07.000000000","message":"Patch Set 2:\n\n\u003e Latter, thinking again, this seems OK as data on the volume belongs\n \u003e to users too, it could be safer to delete them too. But you should\n \u003e combine this one to the other patch, since they are actully similar\n \u003e operation, and lets not add two microversion for this.\n\nOk, I will combine this patch with https://review.openstack.org/#/c/580336/.","accounts_in_message":[],"_revision_number":2},{"id":"1a9f65427156d460c9d0f0fa38221dd7bfbbb3a7","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2018-11-06 11:53:12.000000000","message":"Abandoned\n\nThis is combined into [1].\n\n[1] https://review.openstack.org/#/c/580336/","accounts_in_message":[],"_revision_number":2},{"id":"b0d1aa0213641d2f3f6590573f6cb50122197ee8","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2018-11-30 03:05:22.000000000","message":"Restored","accounts_in_message":[],"_revision_number":2},{"id":"af742c65b7bce69662e3d6549966a8725e6b5482","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-30 03:28:23.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/49/612949/2/check/openstack-tox-docs/43eb873/html/ : SUCCESS in 7m 08s\n- openstack-tox-pep8 http://logs.openstack.org/49/612949/2/check/openstack-tox-pep8/469ed8c/ : SUCCESS in 5m 47s","accounts_in_message":[],"_revision_number":2},{"id":"084ca8162698745d451657f3c2ac5bb02a70cd65","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-03-05 00:54:57.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"2d5fa2df1e0d0552c04189750a7c59846ac42677","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-05 01:01:21.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/49/612949/3/check/openstack-tox-docs/ff98cca/html/ : SUCCESS in 5m 27s\n- openstack-tox-pep8 http://logs.openstack.org/49/612949/3/check/openstack-tox-pep8/5b6c628/ : SUCCESS in 4m 36s","accounts_in_message":[],"_revision_number":3},{"id":"3b9804561ae2dbc29225475e71f2a6234dd46465","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-03-05 01:05:45.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"11fc73d8e18384c3c8dce3eb9f5d7a64e800a307","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-05 01:16:41.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/49/612949/4/check/openstack-tox-docs/7a541d4/html/ : SUCCESS in 9m 00s\n- openstack-tox-pep8 http://logs.openstack.org/49/612949/4/check/openstack-tox-pep8/f4bbe22/ : SUCCESS in 6m 10s","accounts_in_message":[],"_revision_number":4},{"id":"a618b45dc33c09eb049c3309164e8e050c98148b","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-03-06 00:40:55.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"b6a974c93c83f94182e974480a580c7be68543f1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-06 00:53:53.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/49/612949/5/check/openstack-tox-docs/7fb4d9f/html/ : SUCCESS in 5m 55s\n- openstack-tox-pep8 http://logs.openstack.org/49/612949/5/check/openstack-tox-pep8/26e72fb/ : SUCCESS in 4m 42s","accounts_in_message":[],"_revision_number":5},{"id":"0e06aa5dcfb5ade18ea3e9e6de7a21f155bf597c","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-05-20 10:57:54.000000000","message":"Patch Set 6: Patch Set 5 was rebased","accounts_in_message":[],"_revision_number":6},{"id":"294bc3cf8b55c53d5c1453cd03d7122c79af2d26","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-20 11:30:02.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/49/612949/6/check/openstack-tox-docs/68a9c6b/html/ : SUCCESS in 8m 13s\n- openstack-tox-pep8 http://logs.openstack.org/49/612949/6/check/openstack-tox-pep8/6ee3083/ : SUCCESS in 5m 29s","accounts_in_message":[],"_revision_number":6},{"id":"2625fdd3e586735c735065713da62e52857542c7","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-06-12 07:05:32.000000000","message":"Patch Set 7: Patch Set 6 was rebased","accounts_in_message":[],"_revision_number":7},{"id":"9e84ca3203fd5796be224b61079d8ef930ec2a77","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-12 07:33:35.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/49/612949/7/check/openstack-tox-docs/735de9d/html/ : SUCCESS in 6m 54s\n- openstack-tox-pep8 http://logs.openstack.org/49/612949/7/check/openstack-tox-pep8/4c02674/ : SUCCESS in 4m 40s","accounts_in_message":[],"_revision_number":7},{"id":"bbda500900d2c45faba8af9ece1bcc253440feaf","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-06-25 00:08:07.000000000","message":"Patch Set 8: Patch Set 7 was rebased","accounts_in_message":[],"_revision_number":8},{"id":"14e4326c64dca879395027a344b15725091835ea","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-25 00:37:33.000000000","message":"Patch Set 8: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/49/612949/8/check/openstack-tox-docs/ffbb5e2/html/ : SUCCESS in 5m 49s\n- openstack-tox-pep8 http://logs.openstack.org/49/612949/8/check/openstack-tox-pep8/2907d32/ : SUCCESS in 2m 52s","accounts_in_message":[],"_revision_number":8},{"id":"a41b222e2202e38d75cead871da05ea2d3fea595","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-07-04 10:41:38.000000000","message":"Patch Set 9: Patch Set 8 was rebased","accounts_in_message":[],"_revision_number":9},{"id":"826897469d47a94fd104a1f395e2a5c41a87d74c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-04 10:51:57.000000000","message":"Patch Set 9: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/49/612949/9/check/openstack-tox-docs/2a1e289/html/ : SUCCESS in 6m 08s\n- openstack-tox-pep8 http://logs.openstack.org/49/612949/9/check/openstack-tox-pep8/c5b7c5a/ : SUCCESS in 3m 20s","accounts_in_message":[],"_revision_number":9},{"id":"c1d78b9583eff9aff64196b6bff3381023876e3b","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-07-24 06:59:46.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"f561c6f57f8895844926e8cf7c6b9488c378299b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-24 07:09:05.000000000","message":"Patch Set 10: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/49/612949/10/check/openstack-tox-docs/eaa6d17/html/ : SUCCESS in 6m 57s\n- openstack-tox-pep8 http://logs.openstack.org/49/612949/10/check/openstack-tox-pep8/d215da2/ : SUCCESS in 3m 18s","accounts_in_message":[],"_revision_number":10},{"id":"e2d85af233aa67243ba3d95a8af31412bf968aec","author":{"_account_id":30384,"name":"zhangboye","email":"zhangby09@chinatelecom.cn","username":"zhangboye"},"date":"2019-07-25 05:59:47.000000000","message":"Patch Set 10: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":10},{"id":"85d8c7752ad7f7e341488165aa45630c1be86d80","author":{"_account_id":30200,"name":"qinhaizhong","email":"qinhaizhong01@inspur.com","username":"qinhaizhong01"},"date":"2019-07-25 06:00:47.000000000","message":"Patch Set 10: Code-Review+1","accounts_in_message":[],"_revision_number":10},{"id":"ea81a4150922bc891ade3cfc20c1c9ade7c00a4d","author":{"_account_id":23312,"name":"kangyufei","email":"kangyf@inspur.com","username":"kangyufei"},"date":"2019-07-25 06:00:49.000000000","message":"Patch Set 10: Code-Review+1","accounts_in_message":[],"_revision_number":10},{"id":"8de938ba3737da3fe90c9ed350ca26d9afe268c6","author":{"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},"date":"2019-07-25 06:01:32.000000000","message":"Patch Set 10: Code-Review+1","accounts_in_message":[],"_revision_number":10},{"id":"38ec16622b3d5f2af2cded36736d0b089daa565e","author":{"_account_id":30395,"name":"Arthur Dayne","display_name":"Arthur Dayne","email":"palagend@foxmail.com","username":"acewit"},"date":"2019-07-25 06:04:47.000000000","message":"Patch Set 10: Code-Review+1","accounts_in_message":[],"_revision_number":10},{"id":"a64114640207e1d5336fa1f848f28fa1d2f6a725","author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"date":"2019-07-25 06:16:32.000000000","message":"Patch Set 10: Code-Review+1","accounts_in_message":[],"_revision_number":10},{"id":"f248de58bf90596d271c80fdecdf9b3239097569","author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"date":"2019-07-25 09:11:19.000000000","message":"Patch Set 10: Code-Review+1","accounts_in_message":[],"_revision_number":10},{"id":"9c0a000f9d92c23884356208637991e0202d9d7a","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 12:23:10.000000000","message":"Patch Set 10: Code-Review-1\n\n(11 comments)\n\nThe spec is a bit confusing since the proposed change doesn\u0027t really match other parts of the spec. It also seems, in parts, to be conflating this with https://review.opendev.org/#/c/580336/ which is a different spec and more complicated change.\n\nIf this were simply, allow a user to specify delete_on_termination when attaching a volume, and return that value in GET APIs, then this is a pretty straight-forward spec and I think I\u0027d be in favor of it, but as it stands the spec is a bit too confusing for what the actual proposed change is for me to be comfortable with it as written.","accounts_in_message":[],"_revision_number":10},{"id":"7367fd94be2fdd08563aa427c8c2aebee3674e2e","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-07-25 13:08:52.000000000","message":"Patch Set 10:\n\n(5 comments)\n\nThanks Matt, I am sorry, this spec and https://review.opendev.org/#/c/580336/ are somewhat repetitive, because the reason for the splitting and dismantling has led to many places not being accurate enough. If you have time you can update, and you can add \u0027Co-Authored-By\u0027 if you are willing :)","accounts_in_message":[],"_revision_number":10},{"id":"104bdf9f615e05939ceecf548ea4b38db07a2745","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 13:36:21.000000000","message":"Patch Set 10: Workflow-1\n\nThanks Brin, I\u0027ll update this today.","accounts_in_message":[],"_revision_number":10},{"id":"c32aae2f24017953d265c953a079adaf4d42f3a6","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 19:45:30.000000000","message":"Uploaded patch set 11.","accounts_in_message":[],"_revision_number":11},{"id":"0a65b8b940e9f8d1607f934cce0c9577eb3f0785","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 19:47:43.000000000","message":"Patch Set 11: Code-Review+2\n\nI cleaned this up and think it\u0027s pretty straight-forward and simple, nothing involving changes to the compute service. Given today is Train spec freeze and Brin is probably asleep right now I took the liberty of addressing my comments so we can try to get this approved. I don\u0027t really consider my edits as something which bars me from +2ing this.","accounts_in_message":[],"_revision_number":11},{"id":"af65470370ecb2dd88270cdd38e74911cc17b83f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 19:59:49.000000000","message":"Patch Set 11: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/49/612949/11/check/openstack-tox-docs/1d482de/html/ : SUCCESS in 7m 14s\n- openstack-tox-pep8 http://logs.openstack.org/49/612949/11/check/openstack-tox-pep8/e1a42ba/ : SUCCESS in 4m 28s","accounts_in_message":[],"_revision_number":11},{"id":"768e3b7a3a5c6db2474cbc8475266acfd0439dad","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-25 20:01:20.000000000","message":"Patch Set 11: Code-Review+2 Workflow+1\n\n(2 comments)\n\nStraightforward, useful, clean. Agree with omitting update-a-volume-attachment, as noted in the spec and per warning in the API reference.","accounts_in_message":[],"_revision_number":11},{"id":"484f3f8342101007d80de7c1a0d077c9f25e374c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 20:01:32.000000000","message":"Patch Set 11: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":11},{"id":"2fd2ba9a0e84d4f0598c2700a3d0465073c776ec","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 20:09:41.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":11},{"id":"419c35a207c1ad8f04e789b99cd6eab4ec7cabcb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 20:09:41.000000000","message":"Patch Set 11: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/49/612949/11/gate/openstack-tox-docs/90af1f8/html/ : SUCCESS in 7m 06s\n- openstack-tox-pep8 http://logs.openstack.org/49/612949/11/gate/openstack-tox-pep8/7fd62a7/ : SUCCESS in 6m 21s","accounts_in_message":[],"_revision_number":11},{"id":"ea5e836938fb4a3c3fe4302716e1878f7bbdb6ed","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-07-26 02:13:10.000000000","message":"Patch Set 11:\n\n\u003e I cleaned this up and think it\u0027s pretty straight-forward and\n \u003e simple, nothing involving changes to the compute service. Given\n \u003e today is Train spec freeze and Brin is probably asleep right now I\n \u003e took the liberty of addressing my comments so we can try to get\n \u003e this approved. I don\u0027t really consider my edits as something which\n \u003e bars me from +2ing this.\n\nThanks Matt for working for this, I agree with the changes made to this spec, and I will add the implementation code later.","accounts_in_message":[],"_revision_number":11}],"current_revision_number":11,"current_revision":"2a84e13a04620c95cfc8b0eef0b88d0947902023","revisions":{"bc7ae52afb5288c8dbdd96cc325cb45c3b1d1152":{"kind":"REWORK","_number":1,"created":"2018-10-24 08:44:29.000000000","uploader":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"ref":"refs/changes/49/612949/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/49/612949/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/1"}}},"commit":{"parents":[{"commit":"786543cca732657ea806e4c0a484dad2a25bbff9","subject":"Merge \"fix tox python3 overrides\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/786543cca732657ea806e4c0a484dad2a25bbff9"}]}],"author":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2018-10-24 08:43:39.000000000","tz":-240},"committer":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2018-10-24 08:43:43.000000000","tz":-240},"subject":"Support delete_on_termination in volume attach api","message":"Support delete_on_termination in volume attach api\n\nAdd the ``delete_on_termination`` field to the attached volume, the\nidentifier of the data volumes can be deleted when the instance is\ndestroyed, and this field can also be set after the attached.\n\nbp:support-delete-on-termination-in-server-attach-volume\n\nChange-Id: I6a9d0a2f2b918c82b6f56e601f821362a50ff7ce\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/bc7ae52afb5288c8dbdd96cc325cb45c3b1d1152"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/bc7ae52afb5288c8dbdd96cc325cb45c3b1d1152"}]},"branch":"refs/heads/master"},"d453f21999a72b154f8314917b03a973d4f7a7f7":{"kind":"REWORK","_number":2,"created":"2018-11-02 08:23:42.000000000","uploader":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"ref":"refs/changes/49/612949/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/49/612949/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/2"}}},"commit":{"parents":[{"commit":"786543cca732657ea806e4c0a484dad2a25bbff9","subject":"Merge \"fix tox python3 overrides\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/786543cca732657ea806e4c0a484dad2a25bbff9"}]}],"author":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2018-10-24 08:43:39.000000000","tz":-240},"committer":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2018-11-02 08:22:09.000000000","tz":-240},"subject":"Support delete_on_termination in volume attach api","message":"Support delete_on_termination in volume attach api\n\nAdd the ``delete_on_termination`` field to the attached volume, the\nidentifier of the data volumes can be deleted when the instance is\ndestroyed, and this field can also be set after the attached.\n\nAPIImpact\n\nbp:support-delete-on-termination-in-server-attach-volume\nChange-Id: I6a9d0a2f2b918c82b6f56e601f821362a50ff7ce\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/d453f21999a72b154f8314917b03a973d4f7a7f7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/d453f21999a72b154f8314917b03a973d4f7a7f7"}]},"branch":"refs/heads/master"},"ba9fcf0c55443583857501f0dfac0aba6f0a27c1":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2019-03-05 00:54:57.000000000","uploader":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"ref":"refs/changes/49/612949/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/49/612949/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/3"}}},"commit":{"parents":[{"commit":"d796b33774cc4e21c663885a57141e93052e5546","subject":"Merge \"Amend the detach-boot-volume design\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/d796b33774cc4e21c663885a57141e93052e5546"}]}],"author":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2018-10-24 08:43:39.000000000","tz":-240},"committer":{"name":"Brin Zhang","email":"zhangbailin@inspur.com","date":"2019-03-05 00:54:57.000000000","tz":0},"subject":"Support delete_on_termination in volume attach api","message":"Support delete_on_termination in volume attach api\n\nAdd the ``delete_on_termination`` field to the attached volume, the\nidentifier of the data volumes can be deleted when the instance is\ndestroyed, and this field can also be set after the attached.\n\nAPIImpact\n\nbp:support-delete-on-termination-in-server-attach-volume\nChange-Id: I6a9d0a2f2b918c82b6f56e601f821362a50ff7ce\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/ba9fcf0c55443583857501f0dfac0aba6f0a27c1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/ba9fcf0c55443583857501f0dfac0aba6f0a27c1"}]},"branch":"refs/heads/master"},"a14ee1d54f9f606a176910f2accb2eb31689808b":{"kind":"REWORK","_number":4,"created":"2019-03-05 01:05:45.000000000","uploader":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"ref":"refs/changes/49/612949/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/49/612949/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/4"}}},"commit":{"parents":[{"commit":"d796b33774cc4e21c663885a57141e93052e5546","subject":"Merge \"Amend the detach-boot-volume design\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/d796b33774cc4e21c663885a57141e93052e5546"}]}],"author":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2018-10-24 08:43:39.000000000","tz":-240},"committer":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2019-03-05 01:02:17.000000000","tz":480},"subject":"Support delete_on_termination in volume attach api","message":"Support delete_on_termination in volume attach api\n\nAdd the ``delete_on_termination`` field to the attached volume, the\nidentifier of the data volumes can be deleted when the instance is\ndestroyed, and this field can also be set after the attached.\n\nAPIImpact\n\nbp:support-delete-on-termination-in-server-attach-volume\nChange-Id: I6a9d0a2f2b918c82b6f56e601f821362a50ff7ce\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/a14ee1d54f9f606a176910f2accb2eb31689808b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/a14ee1d54f9f606a176910f2accb2eb31689808b"}]},"branch":"refs/heads/master"},"8022b48c997815b79635416df0acb94f60fa98be":{"kind":"REWORK","_number":5,"created":"2019-03-06 00:40:55.000000000","uploader":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"ref":"refs/changes/49/612949/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/49/612949/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/5"}}},"commit":{"parents":[{"commit":"d796b33774cc4e21c663885a57141e93052e5546","subject":"Merge \"Amend the detach-boot-volume design\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/d796b33774cc4e21c663885a57141e93052e5546"}]}],"author":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2018-10-24 08:43:39.000000000","tz":-240},"committer":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2019-03-06 00:40:57.000000000","tz":480},"subject":"Support delete_on_termination in volume attach api","message":"Support delete_on_termination in volume attach api\n\nAdd the ``delete_on_termination`` field to the attached volume, the\nidentifier of the data volumes can be deleted when the instance is\ndestroyed, and this field can also be set after the attached.\n\nAPIImpact\n\nbp:support-delete-on-termination-in-server-attach-volume\nChange-Id: I6a9d0a2f2b918c82b6f56e601f821362a50ff7ce\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/8022b48c997815b79635416df0acb94f60fa98be"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/8022b48c997815b79635416df0acb94f60fa98be"}]},"branch":"refs/heads/master"},"ded2a3356cd8f28779b9d60f031c3786feb9b303":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2019-05-20 10:57:54.000000000","uploader":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"ref":"refs/changes/49/612949/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/49/612949/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/6"}}},"commit":{"parents":[{"commit":"2b2bdfd49fa84b3c05364a09fa8dac9ec8060ce9","subject":"Merge \"Follow up for I9200c2b18369da8b9194a8ccbbf6f1baf6a9613c\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/2b2bdfd49fa84b3c05364a09fa8dac9ec8060ce9"}]}],"author":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2018-10-24 08:43:39.000000000","tz":-240},"committer":{"name":"Brin Zhang","email":"zhangbailin@inspur.com","date":"2019-05-20 10:57:54.000000000","tz":0},"subject":"Support delete_on_termination in volume attach api","message":"Support delete_on_termination in volume attach api\n\nAdd the ``delete_on_termination`` field to the attached volume, the\nidentifier of the data volumes can be deleted when the instance is\ndestroyed, and this field can also be set after the attached.\n\nAPIImpact\n\nbp:support-delete-on-termination-in-server-attach-volume\nChange-Id: I6a9d0a2f2b918c82b6f56e601f821362a50ff7ce\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/ded2a3356cd8f28779b9d60f031c3786feb9b303"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/ded2a3356cd8f28779b9d60f031c3786feb9b303"}]},"branch":"refs/heads/master"},"88886d087c86fcfa46736f089a70bc3251d85075":{"kind":"TRIVIAL_REBASE","_number":7,"created":"2019-06-12 07:05:32.000000000","uploader":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"ref":"refs/changes/49/612949/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/49/612949/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/7"}}},"commit":{"parents":[{"commit":"93904799878bef37eb26db463767da0cb657bbc6","subject":"Clarify the error response in proposed change","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/93904799878bef37eb26db463767da0cb657bbc6"}]}],"author":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2018-10-24 08:43:39.000000000","tz":-240},"committer":{"name":"Brin Zhang","email":"zhangbailin@inspur.com","date":"2019-06-12 07:05:32.000000000","tz":0},"subject":"Support delete_on_termination in volume attach api","message":"Support delete_on_termination in volume attach api\n\nAdd the ``delete_on_termination`` field to the attached volume, the\nidentifier of the data volumes can be deleted when the instance is\ndestroyed, and this field can also be set after the attached.\n\nAPIImpact\n\nbp:support-delete-on-termination-in-server-attach-volume\nChange-Id: I6a9d0a2f2b918c82b6f56e601f821362a50ff7ce\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/88886d087c86fcfa46736f089a70bc3251d85075"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/88886d087c86fcfa46736f089a70bc3251d85075"}]},"branch":"refs/heads/master"},"b12844889123d7c7cdde28f325ee52e6d6ecbf1a":{"kind":"TRIVIAL_REBASE","_number":8,"created":"2019-06-25 00:08:07.000000000","uploader":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"ref":"refs/changes/49/612949/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/49/612949/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/8"}}},"commit":{"parents":[{"commit":"84cf12416bfb8009bc73cbfb4f13c4586f86599a","subject":"Merge \"Change new image property to hw_mem_encryption\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/84cf12416bfb8009bc73cbfb4f13c4586f86599a"}]}],"author":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2018-10-24 08:43:39.000000000","tz":-240},"committer":{"name":"Brin Zhang","email":"zhangbailin@inspur.com","date":"2019-06-25 00:08:07.000000000","tz":0},"subject":"Support delete_on_termination in volume attach api","message":"Support delete_on_termination in volume attach api\n\nAdd the ``delete_on_termination`` field to the attached volume, the\nidentifier of the data volumes can be deleted when the instance is\ndestroyed, and this field can also be set after the attached.\n\nAPIImpact\n\nbp:support-delete-on-termination-in-server-attach-volume\nChange-Id: I6a9d0a2f2b918c82b6f56e601f821362a50ff7ce\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/b12844889123d7c7cdde28f325ee52e6d6ecbf1a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/b12844889123d7c7cdde28f325ee52e6d6ecbf1a"}]},"branch":"refs/heads/master"},"0a2e98fc1f6c6c4559b54bdf0e8cb6ad9c59c569":{"kind":"TRIVIAL_REBASE","_number":9,"created":"2019-07-04 10:41:38.000000000","uploader":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"ref":"refs/changes/49/612949/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/49/612949/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/9"}}},"commit":{"parents":[{"commit":"d74e8586a73d669f614cc9a1184e8056a12a7e7d","subject":"Merge \"Add \"Secure Boot support for KVM \u0026 QEMU guests\" spec\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/d74e8586a73d669f614cc9a1184e8056a12a7e7d"}]}],"author":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2018-10-24 08:43:39.000000000","tz":-240},"committer":{"name":"Brin Zhang","email":"zhangbailin@inspur.com","date":"2019-07-04 10:41:38.000000000","tz":0},"subject":"Support delete_on_termination in volume attach api","message":"Support delete_on_termination in volume attach api\n\nAdd the ``delete_on_termination`` field to the attached volume, the\nidentifier of the data volumes can be deleted when the instance is\ndestroyed, and this field can also be set after the attached.\n\nAPIImpact\n\nbp:support-delete-on-termination-in-server-attach-volume\nChange-Id: I6a9d0a2f2b918c82b6f56e601f821362a50ff7ce\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/0a2e98fc1f6c6c4559b54bdf0e8cb6ad9c59c569"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/0a2e98fc1f6c6c4559b54bdf0e8cb6ad9c59c569"}]},"branch":"refs/heads/master"},"87c985b2359844fe0b9bd7c3680e4057adbbb9fc":{"kind":"REWORK","_number":10,"created":"2019-07-24 06:59:46.000000000","uploader":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"ref":"refs/changes/49/612949/10","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/49/612949/10","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/10"}}},"commit":{"parents":[{"commit":"1a8e0c431f370a4d6179a27e241bce40bbc21f68","subject":"Merge \"Boot a VM with an unaddressed port\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/1a8e0c431f370a4d6179a27e241bce40bbc21f68"}]}],"author":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2018-10-24 08:43:39.000000000","tz":-240},"committer":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2019-07-24 06:58:39.000000000","tz":480},"subject":"Support delete_on_termination in volume attach api","message":"Support delete_on_termination in volume attach api\n\nAdd the ``delete_on_termination`` field to the attached volume, the\nidentifier of the data volumes can be deleted when the instance is\ndestroyed, and this field can also be set after the attached.\n\nAPIImpact\n\nbp:support-delete-on-termination-in-server-attach-volume\nChange-Id: I6a9d0a2f2b918c82b6f56e601f821362a50ff7ce\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/87c985b2359844fe0b9bd7c3680e4057adbbb9fc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/87c985b2359844fe0b9bd7c3680e4057adbbb9fc"}]},"branch":"refs/heads/master"},"2a84e13a04620c95cfc8b0eef0b88d0947902023":{"kind":"REWORK","_number":11,"created":"2019-07-25 19:45:30.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/49/612949/11","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/49/612949/11","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/49/612949/11"}}},"commit":{"parents":[{"commit":"1a8e0c431f370a4d6179a27e241bce40bbc21f68","subject":"Merge \"Boot a VM with an unaddressed port\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/1a8e0c431f370a4d6179a27e241bce40bbc21f68"}]}],"author":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2018-10-24 08:43:39.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-25 19:45:03.000000000","tz":-240},"subject":"Support delete_on_termination in volume attach api","message":"Support delete_on_termination in volume attach api\n\nThis blueprint proposes to support passing delete_on_termination during\nvolume attach so the attached volume can be deleted when the server is\ndeleted.\n\nAPIImpact\n\nbp:support-delete-on-termination-in-server-attach-volume\nChange-Id: I6a9d0a2f2b918c82b6f56e601f821362a50ff7ce\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/2a84e13a04620c95cfc8b0eef0b88d0947902023"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/2a84e13a04620c95cfc8b0eef0b88d0947902023"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}