)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"194ad607211801779a02edfdfe9530efb80be61b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As discussed in Berlin Summit, there are some"},{"line_number":10,"context_line":"considerations should be added to the design:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"1. We are also be able to detach volumes for"},{"line_number":13,"context_line":"soft_deleted and resized instances, we may also"},{"line_number":14,"context_line":"consider it."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"2. Expose ``boot_index`` in this feature could"},{"line_number":17,"context_line":"make it easier for users to detach and attach"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_61d8967c","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":12},"updated":"2018-12-18 03:08:46.000000000","message":"Technically you can also detach volumes from a paused server:\n\nhttps://github.com/openstack/nova/blob/66e44c64297e77395195d77104017fb6fcea58d2/nova/compute/api.py#L4335\n\nDo we care about that scenario? I don\u0027t know what we really want to try and cover all of those states for detaching a root volume, particularly paused and soft_deleted - what reason would a user have to detach the root volume on a soft_deleted instance? If they want to use the server, they should restore it first IMO.","commit_id":"cabbee5d70a1d80115442659beb17ff5983bb24a"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"e08488f806ff4fa991020f765998ff0d39afcfff","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As discussed in Berlin Summit, there are some"},{"line_number":10,"context_line":"considerations should be added to the design:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"1. We are also be able to detach volumes for"},{"line_number":13,"context_line":"soft_deleted and resized instances, we may also"},{"line_number":14,"context_line":"consider it."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"2. Expose ``boot_index`` in this feature could"},{"line_number":17,"context_line":"make it easier for users to detach and attach"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_95c83e76","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":12},"in_reply_to":"3f79a3b5_61d8967c","updated":"2018-12-21 03:04:34.000000000","message":"Yes, me too, I also don\u0027t get why we allow detach root volume for resized instance, it will make the revert process pretty complex as you mentioned in your cross-cell BP, could we just limit the root volume detach to stopped and shelved instances? this seems to be most useful cases","commit_id":"cabbee5d70a1d80115442659beb17ff5983bb24a"}],"specs/stein/approved/detach-boot-volume.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"194ad607211801779a02edfdfe9530efb80be61b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"There are use cases that require a boot volume to be detached when an"},{"line_number":33,"context_line":"instance is not running, so we propose relaxing the inherent assumption to"},{"line_number":34,"context_line":"say that a boot volume attachment can be changed when an instance is powered"},{"line_number":35,"context_line":"off or shelved. To ensure safety we can prevent it being started, restored,"},{"line_number":36,"context_line":"unshelved, confirm resized or revert resized without a boot volume."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Use Cases"},{"line_number":39,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_012e825a","line":36,"range":{"start_line":35,"start_character":16,"end_line":36,"end_character":67},"updated":"2018-12-18 03:08:46.000000000","message":"Should probably also have unpaused in this list as well since you can detach a volume from a paused server.","commit_id":"cabbee5d70a1d80115442659beb17ff5983bb24a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"194ad607211801779a02edfdfe9530efb80be61b","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The usual detach volume API call will be used to detach the boot volume."},{"line_number":100,"context_line":"The guard on this call will be changed to allow the detach if the instance"},{"line_number":101,"context_line":"is powered off, shelved_offloaded, resized, soft_deleted."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"When a boot volume is detached, we will set the root block device"},{"line_number":104,"context_line":"mapping(boot_index\u003d0) with ``volume_id\u003dNone``, meaning that it\u0027s not"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_a1654eb3","line":101,"range":{"start_line":101,"start_character":35,"end_line":101,"end_character":57},"updated":"2018-12-18 03:08:46.000000000","message":"What about paused? I also don\u0027t really understand why we allow users to attach/detach volumes on a resized instance, but Dan mentioned a use case for that recently in my cross-cell resize spec:\n\nhttps://review.openstack.org/#/c/616037/1/specs/stein/approved/cross-cell-resize.rst@338\n\nSo there might be legitimate reasons for that with resize.\n\nI don\u0027t really know why we\u0027d support soft_deleted since it seems weird to delete a server and then want to do things to it. If you wanted to detach the root volume on a soft_deleted server with the intention of attaching another root volume later, why not just restore the server first?\n\nI also don\u0027t really know how safe it is to detach the root volume on a paused instance:\n\nhttps://docs.openstack.org/nova/latest/user/support-matrix.html#operation_pause\n\nSeems unsafe to me but I don\u0027t know much about pause either, or if anyone even uses it.","commit_id":"cabbee5d70a1d80115442659beb17ff5983bb24a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"194ad607211801779a02edfdfe9530efb80be61b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"mapping(boot_index\u003d0) with ``volume_id\u003dNone``, meaning that it\u0027s not"},{"line_number":105,"context_line":"attached to any volume."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"A new microversion will be added to the show volume attachments API. We"},{"line_number":108,"context_line":"will expose the BDM ``boot_index`` field for requests with the new"},{"line_number":109,"context_line":"microversion or greater, so that users can use this information when they"},{"line_number":110,"context_line":"detach volumes. This new microversion will also affect volume attach API,"},{"line_number":111,"context_line":"A new ``is_root``  parameter will be allowed for requests with the new"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_c1d3aa35","line":108,"range":{"start_line":107,"start_character":0,"end_line":108,"end_character":66},"updated":"2018-12-18 03:08:46.000000000","message":"This is confusing. So GET /servers/{server_id}/os-volume_attachments* APIs will expose the boot_index of each BDM, that makes sense, but are you also changing this such that POST /servers/{server_id}/os-volume_attachments (attach) changes to take a boot_index parameter in the request rather than an \"is_root\" parameter as previously written?\n\nI assume we\u0027ll still show the root BDM with boot_index\u003d0 even if it\u0027s detached and we just have a placeholder for it, right? Because on L132 that\u0027s the BDM with boot_index\u003d0 and its attachment_id and volume_id fields will be None.","commit_id":"cabbee5d70a1d80115442659beb17ff5983bb24a"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"61a85cd3964a4e2242f9fbfa05236114eaf37e9b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"mapping(boot_index\u003d0) with ``volume_id\u003dNone``, meaning that it\u0027s not"},{"line_number":105,"context_line":"attached to any volume."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"A new microversion will be added to the show volume attachments API. We"},{"line_number":108,"context_line":"will expose the BDM ``boot_index`` field for requests with the new"},{"line_number":109,"context_line":"microversion or greater, so that users can use this information when they"},{"line_number":110,"context_line":"detach volumes. This new microversion will also affect volume attach API,"},{"line_number":111,"context_line":"A new ``is_root``  parameter will be allowed for requests with the new"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_531b3d1a","line":108,"range":{"start_line":107,"start_character":0,"end_line":108,"end_character":66},"in_reply_to":"3f79a3b5_c1d3aa35","updated":"2019-01-09 07:22:40.000000000","message":"Done","commit_id":"cabbee5d70a1d80115442659beb17ff5983bb24a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"194ad607211801779a02edfdfe9530efb80be61b","unresolved":false,"context_lines":[{"line_number":108,"context_line":"will expose the BDM ``boot_index`` field for requests with the new"},{"line_number":109,"context_line":"microversion or greater, so that users can use this information when they"},{"line_number":110,"context_line":"detach volumes. This new microversion will also affect volume attach API,"},{"line_number":111,"context_line":"A new ``is_root``  parameter will be allowed for requests with the new"},{"line_number":112,"context_line":"microversion or greater, indicating that the user is trying to attach a"},{"line_number":113,"context_line":"root volume. The attachment with this parameter will only be allowed if"},{"line_number":114,"context_line":"the instance is powered off, shelved_offloaded or resized status and it"},{"line_number":115,"context_line":"has a \"no volume\" block device mapping for the root device."},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_01b3e20d","line":113,"range":{"start_line":111,"start_character":0,"end_line":113,"end_character":12},"updated":"2018-12-18 03:08:46.000000000","message":"OK so we\u0027re still doing the is_root parameter on attach? And boot_index is just in the GET responses? I was confused because you said \"requests\" on L108 when I think you mean responses.","commit_id":"cabbee5d70a1d80115442659beb17ff5983bb24a"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"61a85cd3964a4e2242f9fbfa05236114eaf37e9b","unresolved":false,"context_lines":[{"line_number":108,"context_line":"will expose the BDM ``boot_index`` field for requests with the new"},{"line_number":109,"context_line":"microversion or greater, so that users can use this information when they"},{"line_number":110,"context_line":"detach volumes. This new microversion will also affect volume attach API,"},{"line_number":111,"context_line":"A new ``is_root``  parameter will be allowed for requests with the new"},{"line_number":112,"context_line":"microversion or greater, indicating that the user is trying to attach a"},{"line_number":113,"context_line":"root volume. The attachment with this parameter will only be allowed if"},{"line_number":114,"context_line":"the instance is powered off, shelved_offloaded or resized status and it"},{"line_number":115,"context_line":"has a \"no volume\" block device mapping for the root device."},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_7318c11c","line":113,"range":{"start_line":111,"start_character":0,"end_line":113,"end_character":12},"in_reply_to":"3f79a3b5_01b3e20d","updated":"2019-01-09 07:22:40.000000000","message":"Done","commit_id":"cabbee5d70a1d80115442659beb17ff5983bb24a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"194ad607211801779a02edfdfe9530efb80be61b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"A new ``is_root``  parameter will be allowed for requests with the new"},{"line_number":112,"context_line":"microversion or greater, indicating that the user is trying to attach a"},{"line_number":113,"context_line":"root volume. The attachment with this parameter will only be allowed if"},{"line_number":114,"context_line":"the instance is powered off, shelved_offloaded or resized status and it"},{"line_number":115,"context_line":"has a \"no volume\" block device mapping for the root device."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"There are some specific considerations for detaching/attaching a root volume"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_a1c1ce52","line":114,"updated":"2018-12-18 03:08:46.000000000","message":"What about soft deleted and paused?","commit_id":"cabbee5d70a1d80115442659beb17ff5983bb24a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"194ad607211801779a02edfdfe9530efb80be61b","unresolved":false,"context_lines":[{"line_number":140,"context_line":"   i.e. you can\u0027t attach a volume that is already in-use unless"},{"line_number":141,"context_line":"   it\u0027s a multiattach volume."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"The start, restore, unshelve, revert resize and confirm resize operation"},{"line_number":144,"context_line":"will be guarded with a check for the \"no volume\" block device mapping. An"},{"line_number":145,"context_line":"instance will not be allowed to start, restore, unshelve, revert resize or"},{"line_number":146,"context_line":"confirm resieze when its boot volume has been detached unless another has"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_a186ae18","line":143,"updated":"2018-12-18 03:08:46.000000000","message":"What about unpause?","commit_id":"cabbee5d70a1d80115442659beb17ff5983bb24a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"194ad607211801779a02edfdfe9530efb80be61b","unresolved":false,"context_lines":[{"line_number":180,"context_line":"volume (besides the replica) for each instance that is not being used. This"},{"line_number":181,"context_line":"is wasteful of resources."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Another alternative is to only allow detach boot volume for instances in"},{"line_number":184,"context_line":"``stopped`` and ``shelve_offloaded`` status."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_416eba65","line":183,"updated":"2018-12-18 03:08:46.000000000","message":"We might want to ask this in the mailing list because this didn\u0027t really come up at the PTG, only the boot_index thing. The question about supporting this for resized/paused/soft_deleted instances came from me when I was working on the cross-cell resize stuff and noticed we allowed attach/detach volumes on a resized server. Dan\u0027s use case might arguably be OK for resize but I\u0027m not sure we should support detaching the root volume on a paused or soft deleted server (I don\u0027t know if that is safe or useful).","commit_id":"cabbee5d70a1d80115442659beb17ff5983bb24a"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"501e897bafe7aaec2a17edbbf560d79f6f6faaa4","unresolved":false,"context_lines":[{"line_number":180,"context_line":"volume (besides the replica) for each instance that is not being used. This"},{"line_number":181,"context_line":"is wasteful of resources."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Another alternative is to only allow detach boot volume for instances in"},{"line_number":184,"context_line":"``stopped`` and ``shelve_offloaded`` status."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_d578f62e","line":183,"in_reply_to":"3f79a3b5_416eba65","updated":"2018-12-21 03:08:02.000000000","message":"Yeah, I will do it, probably after the holiday, as people are now out of office and it might be in the botom of the list when people came back.","commit_id":"cabbee5d70a1d80115442659beb17ff5983bb24a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ad68898ca6894ae87bc1c59ac2b30f5f7bef2522","unresolved":false,"context_lines":[{"line_number":180,"context_line":"volume (besides the replica) for each instance that is not being used. This"},{"line_number":181,"context_line":"is wasteful of resources."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Another alternative is to only allow detach boot volume for instances in"},{"line_number":184,"context_line":"``stopped`` and ``shelve_offloaded`` status."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_41bc7ab5","line":183,"in_reply_to":"3f79a3b5_416eba65","updated":"2018-12-18 03:09:16.000000000","message":"s/PTG/Summit/","commit_id":"cabbee5d70a1d80115442659beb17ff5983bb24a"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"61a85cd3964a4e2242f9fbfa05236114eaf37e9b","unresolved":false,"context_lines":[{"line_number":180,"context_line":"volume (besides the replica) for each instance that is not being used. This"},{"line_number":181,"context_line":"is wasteful of resources."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Another alternative is to only allow detach boot volume for instances in"},{"line_number":184,"context_line":"``stopped`` and ``shelve_offloaded`` status."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_b31e290a","line":183,"in_reply_to":"3f79a3b5_d578f62e","updated":"2019-01-09 07:22:40.000000000","message":"Done","commit_id":"cabbee5d70a1d80115442659beb17ff5983bb24a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"194ad607211801779a02edfdfe9530efb80be61b","unresolved":false,"context_lines":[{"line_number":191,"context_line":"REST API impact"},{"line_number":192,"context_line":"---------------"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Add a new microversion for show volume attachments REST API to allow exposing"},{"line_number":195,"context_line":"the ``boot_index`` field."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Add a new microversion for attach volume REST API to allow passing"},{"line_number":198,"context_line":"``is_root`` as a parameter."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"An attempt to detach a boot volume currently always returns the error:"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_41a31a9d","line":198,"range":{"start_line":194,"start_character":0,"end_line":198,"end_character":27},"updated":"2018-12-18 03:08:46.000000000","message":"Are you proposing two separate microversions? I think the changes should go under a single microversion, no need to over complicate this as they are very distinct changes under the same version: one adds boot_index to GET responses and the other adds is_root to the POST attach volume request.","commit_id":"cabbee5d70a1d80115442659beb17ff5983bb24a"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"61a85cd3964a4e2242f9fbfa05236114eaf37e9b","unresolved":false,"context_lines":[{"line_number":191,"context_line":"REST API impact"},{"line_number":192,"context_line":"---------------"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Add a new microversion for show volume attachments REST API to allow exposing"},{"line_number":195,"context_line":"the ``boot_index`` field."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Add a new microversion for attach volume REST API to allow passing"},{"line_number":198,"context_line":"``is_root`` as a parameter."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"An attempt to detach a boot volume currently always returns the error:"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_9321a550","line":198,"range":{"start_line":194,"start_character":0,"end_line":198,"end_character":27},"in_reply_to":"3f79a3b5_41a31a9d","updated":"2019-01-09 07:22:40.000000000","message":"Done","commit_id":"cabbee5d70a1d80115442659beb17ff5983bb24a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"194ad607211801779a02edfdfe9530efb80be61b","unresolved":false,"context_lines":[{"line_number":277,"context_line":"  volume is a root volume."},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"- Add guard in API for \"no volume\" mapping before start, unshelving,"},{"line_number":280,"context_line":"  revert resize and confirm resize an instance."},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"- Change conditional guard on compute api to allow detach of boot device"},{"line_number":283,"context_line":"  when instance is stopped, shelved_offloaded and resized."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_01af627f","line":280,"updated":"2018-12-18 03:08:46.000000000","message":"...and restore and unpause...if we do those.","commit_id":"cabbee5d70a1d80115442659beb17ff5983bb24a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e8af2bdda62852c67a8d9816560c617b8373b626","unresolved":false,"context_lines":[{"line_number":107,"context_line":"A new microversion will be added to the show volume attachments API. We"},{"line_number":108,"context_line":"will expose the BDM ``boot_index`` field for GET request with the new"},{"line_number":109,"context_line":"microversion or greater, so that users can use this information when they"},{"line_number":110,"context_line":"detach volumes. This new microversion will also affect volume attach API,"},{"line_number":111,"context_line":"A new ``is_root``  parameter will be allowed for requests with the new"},{"line_number":112,"context_line":"microversion or greater, indicating that the user is trying to attach a"},{"line_number":113,"context_line":"root volume. The attachment with this parameter will only be allowed if"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fdfeff1_a8fd0f6f","line":110,"range":{"start_line":110,"start_character":72,"end_line":110,"end_character":73},"updated":"2019-01-26 22:56:31.000000000","message":".","commit_id":"7999e547fc01ad7cf4534d613e95f8f917ff6a25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e8af2bdda62852c67a8d9816560c617b8373b626","unresolved":false,"context_lines":[{"line_number":145,"context_line":"   i.e. you can\u0027t attach a volume that is already in-use unless"},{"line_number":146,"context_line":"   it\u0027s a multiattach volume."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"The start, and unshelve operation will be guarded with a check for the"},{"line_number":149,"context_line":"\"no volume\" block device mapping. An instance will not be allowed to start,"},{"line_number":150,"context_line":"or unshelve  when its boot volume has been detached unless another has"},{"line_number":151,"context_line":"been attached in its place."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fdfeff1_88f84b7b","line":148,"range":{"start_line":148,"start_character":9,"end_line":148,"end_character":10},"updated":"2019-01-26 22:56:31.000000000","message":"Don\u0027t need this comma.","commit_id":"7999e547fc01ad7cf4534d613e95f8f917ff6a25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e8af2bdda62852c67a8d9816560c617b8373b626","unresolved":false,"context_lines":[{"line_number":146,"context_line":"   it\u0027s a multiattach volume."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"The start, and unshelve operation will be guarded with a check for the"},{"line_number":149,"context_line":"\"no volume\" block device mapping. An instance will not be allowed to start,"},{"line_number":150,"context_line":"or unshelve  when its boot volume has been detached unless another has"},{"line_number":151,"context_line":"been attached in its place."},{"line_number":152,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fdfeff1_28f11f96","line":149,"range":{"start_line":149,"start_character":74,"end_line":149,"end_character":75},"updated":"2019-01-26 22:56:31.000000000","message":"Nor here.","commit_id":"7999e547fc01ad7cf4534d613e95f8f917ff6a25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e8af2bdda62852c67a8d9816560c617b8373b626","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"The start, and unshelve operation will be guarded with a check for the"},{"line_number":149,"context_line":"\"no volume\" block device mapping. An instance will not be allowed to start,"},{"line_number":150,"context_line":"or unshelve  when its boot volume has been detached unless another has"},{"line_number":151,"context_line":"been attached in its place."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"For dettach/attach volume for powered off instances, This would involve"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fdfeff1_48eee3b4","line":150,"range":{"start_line":150,"start_character":11,"end_line":150,"end_character":13},"updated":"2019-01-26 22:56:31.000000000","message":"too many spaces - this entire paragraph could have remained unchanged","commit_id":"7999e547fc01ad7cf4534d613e95f8f917ff6a25"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"b8c046ac558536b9675c6e5d88bcc3c4eb7d0e53","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"The start, and unshelve operation will be guarded with a check for the"},{"line_number":149,"context_line":"\"no volume\" block device mapping. An instance will not be allowed to start,"},{"line_number":150,"context_line":"or unshelve  when its boot volume has been detached unless another has"},{"line_number":151,"context_line":"been attached in its place."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"For dettach/attach volume for powered off instances, This would involve"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fdfeff1_61ebbddb","line":150,"range":{"start_line":150,"start_character":11,"end_line":150,"end_character":13},"in_reply_to":"9fdfeff1_48eee3b4","updated":"2019-01-28 08:27:08.000000000","message":"Yeah, I think it is because I added something before and then just deleted, did not revert properly :)","commit_id":"7999e547fc01ad7cf4534d613e95f8f917ff6a25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e8af2bdda62852c67a8d9816560c617b8373b626","unresolved":false,"context_lines":[{"line_number":277,"context_line":"  Add a new microversion to attach volume API to indicate that the specified"},{"line_number":278,"context_line":"  volume is a root volume."},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"- Add guard in API for \"no volume\" mapping before start and unshelving"},{"line_number":281,"context_line":"  an instance."},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"- Change conditional guard on compute api to allow detach of boot device"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fdfeff1_08321b60","line":280,"updated":"2019-01-26 22:56:31.000000000","message":"Unrelated change.","commit_id":"7999e547fc01ad7cf4534d613e95f8f917ff6a25"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"b8c046ac558536b9675c6e5d88bcc3c4eb7d0e53","unresolved":false,"context_lines":[{"line_number":277,"context_line":"  Add a new microversion to attach volume API to indicate that the specified"},{"line_number":278,"context_line":"  volume is a root volume."},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"- Add guard in API for \"no volume\" mapping before start and unshelving"},{"line_number":281,"context_line":"  an instance."},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"- Change conditional guard on compute api to allow detach of boot device"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fdfeff1_81d10126","line":280,"in_reply_to":"9fdfeff1_08321b60","updated":"2019-01-28 08:27:08.000000000","message":"Yeah, could be samething as above comment","commit_id":"7999e547fc01ad7cf4534d613e95f8f917ff6a25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e8af2bdda62852c67a8d9816560c617b8373b626","unresolved":false,"context_lines":[{"line_number":320,"context_line":"[3] shelved_offload_time config option"},{"line_number":321,"context_line":"    https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.shelved_poll_interval"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"[4] Mailist discussion about instance vm_state to allow detach/attach root"},{"line_number":324,"context_line":"    volume. http://lists.openstack.org/pipermail/openstack-discuss/2019-January/001344.html"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"[5] Cinder attachment create"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fdfeff1_c837334d","line":323,"range":{"start_line":323,"start_character":4,"end_line":323,"end_character":11},"updated":"2019-01-26 22:56:31.000000000","message":"Mailing list","commit_id":"7999e547fc01ad7cf4534d613e95f8f917ff6a25"}]}