)]}'
{"id":"openstack%2Fnova-specs~642030","triplet_id":"openstack%2Fnova-specs~master~I4cf9ebb61bc7613f8b55127b4c6cd13591fe4948","project":"openstack/nova-specs","branch":"master","topic":"bp/cpu-model-selection","hashtags":[],"change_id":"I4cf9ebb61bc7613f8b55127b4c6cd13591fe4948","subject":"Re-propose the spec to allow specifying a list of CPU models","status":"MERGED","created":"2019-03-08 14:24:10.000000000","updated":"2019-07-02 17:29:16.000000000","submitted":"2019-07-02 16:47:49.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":79,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"642030-1562086069711-0e8fd139","meta_rev_id":"50c83c46eabbf0acb059c2131255fe8b51b53538","_number":642030,"virtual_id_number":642030,"owner":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":2,"date":"2019-07-02 16:47:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":28433,"name":"Jack Ding","email":"jackding@gmail.com","username":"jackding"},{"value":0,"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},{"value":2,"date":"2019-07-02 14:45:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":28433,"name":"Jack Ding","email":"jackding@gmail.com","username":"jackding"},{"value":1,"date":"2019-07-02 14:43:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"value":1,"date":"2019-07-02 15:43:19.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":2,"date":"2019-07-02 13:30:57.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":1,"date":"2019-07-02 13:34:43.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":0,"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":28433,"name":"Jack Ding","email":"jackding@gmail.com","username":"jackding"},{"value":0,"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":1,"date":"2019-07-02 16:33:01.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":28433,"name":"Jack Ding","email":"jackding@gmail.com","username":"jackding"},{"value":0,"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},{"_account_id":28433,"name":"Jack Ding","email":"jackding@gmail.com","username":"jackding"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-03-08 14:25:54.000000000","updated_by":{"_account_id":28433,"name":"Jack Ding","email":"jackding@gmail.com","username":"jackding"},"reviewer":{"_account_id":28433,"name":"Jack Ding","email":"jackding@gmail.com","username":"jackding"},"state":"REVIEWER"},{"updated":"2019-04-09 09:53:11.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"},{"updated":"2019-04-09 15:17:32.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2019-04-09 15:23:56.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2019-04-12 07:22:45.000000000","updated_by":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"reviewer":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"state":"REVIEWER"},{"updated":"2019-04-12 14:42:09.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-05-02 06:00:41.000000000","updated_by":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"reviewer":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"state":"REVIEWER"},{"updated":"2019-06-05 16:03:32.000000000","updated_by":{"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},"reviewer":{"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},"state":"REVIEWER"},{"updated":"2019-07-02 13:27:46.000000000","updated_by":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"reviewer":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"state":"REVIEWER"},{"updated":"2019-07-02 13:34:43.000000000","updated_by":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"reviewer":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"state":"REVIEWER"},{"updated":"2019-07-02 14:45:32.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2019-07-02 15:43:19.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2019-07-02 16:33:01.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-07-02 16:47:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"bfab5ad52cf6b68284f9dc89a4f868fb680f2459","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-03-08 14:24:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b9704ceedc77a54bf47c6892defbd5c35ea3bf4d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-08 14:32:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/30/642030/1/check/openstack-tox-docs/6ee517a/html/ : SUCCESS in 5m 57s\n- openstack-tox-pep8 http://logs.openstack.org/30/642030/1/check/openstack-tox-pep8/8fc390c/ : SUCCESS in 6m 37s","accounts_in_message":[],"_revision_number":1},{"id":"b963a2b81e187068ea3c808199d7d2da2df5bc28","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-08 14:52:16.000000000","message":"Patch Set 1:\n\n(1 comment)\n\n:P","accounts_in_message":[],"_revision_number":1},{"id":"e1dbdc67d93e6b8ea91fade84d91449874a96ba0","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-08 15:14:23.000000000","message":"Patch Set 1: Code-Review+1\n\n(3 comments)\n\nGood. Changes from previous [0] are \"cosmetic\" [1] except for s/cpu_models/cpu_model_list/, about which I\u0027m meh, but certainly not against. The code [2] already (mostly) reflects this change, and it reads well.\n\n[0] https://raw.githubusercontent.com/openstack/nova-specs/master/specs/stein/approved/cpu-model-selection.rst\n[1] Nit: to make reviewing easier, in the future please copy the previous spec verbatim, publish it as PS1, and then make your edits in subsequent patch set(s).\n[2] https://review.openstack.org/#/c/637834/","accounts_in_message":[],"_revision_number":1},{"id":"5c802f2c311f546fa664a780417714c3436fc16e","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-03-08 16:32:52.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"29a2b37c81e78277cd7a7de617bda69ad53b40b9","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-03-08 16:34:43.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"3c35508d8c960d23a7551204f4b92d4a2bba7aa3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-08 16:45:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/30/642030/2/check/openstack-tox-docs/b49a889/html/ : SUCCESS in 8m 34s\n- openstack-tox-pep8 http://logs.openstack.org/30/642030/2/check/openstack-tox-pep8/78d1c07/ : SUCCESS in 8m 25s","accounts_in_message":[],"_revision_number":2},{"id":"a27ee55a9ddd2b4d24ad69b40dbaaffceea9699f","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-08 19:55:32.000000000","message":"Patch Set 2: Code-Review+1\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"cca52c4ff3795be92d8b1a2d49d989623605ebfa","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2019-03-13 06:29:40.000000000","message":"Patch Set 2: Code-Review+2\n\nLGTM, also hope wang ya can take a look at.","accounts_in_message":[],"_revision_number":2},{"id":"2706503fa7be2d80cecabc85e0742ecca9a9eced","author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"date":"2019-03-13 11:27:09.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"6c2a8d2c3ff3afaa6a121bb6f1ee1e21dd74d645","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-03-26 22:46:59.000000000","message":"Patch Set 2:\n\n@kashyap, do you want to address ya.wang\u0027s issues? You could maybe argue that those are implementation details and tweak the spec after the code lands.\n\nI\u0027m ready to approve this once I have your response.","accounts_in_message":[],"_revision_number":2},{"id":"27dc9b012edb8367df45bb168501af57b5750008","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-04-01 10:24:11.000000000","message":"Patch Set 2:\n\n(1 comment)\n\n\u003e @kashyap, do you want to address ya.wang\u0027s issues? You could maybe\n \u003e argue that those are implementation details and tweak the spec\n \u003e after the code lands.\n \u003e \n \u003e I\u0027m ready to approve this once I have your response.\n\nHi, Eric, sorry for delay; I was on PTO last week, and just catching up.  \n\nOn your question, although they\u0027re implementation details, would be nice to address them.  I\u0027ll do it this week.","accounts_in_message":[],"_revision_number":2},{"id":"b964a3e49cbae08cf741fd87366edae6ede32b87","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-04-02 08:56:31.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"b120da4605c8b863bb29d0d5c12b4b3deae2a92e","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-04-02 09:36:40.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"95a5baefea43b73b575e82f848afe73e3fd50f7d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-02 09:51:44.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/30/642030/3/check/openstack-tox-docs/d48e3af/ : FAILURE in 13m 35s\n- openstack-tox-pep8 http://logs.openstack.org/30/642030/3/check/openstack-tox-pep8/6a3ffa0/ : SUCCESS in 6m 07s","accounts_in_message":[],"_revision_number":3},{"id":"9085da6f73e43de7dd3bcfa06c566de2b3d005f0","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-04-03 08:11:01.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"bb9f8abae064e2d6bf73ed30be0a362efb0bf4e8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-03 08:20:55.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/30/642030/4/check/openstack-tox-docs/81027b3/ : FAILURE in 4m 51s\n- openstack-tox-pep8 http://logs.openstack.org/30/642030/4/check/openstack-tox-pep8/bd02a7a/ : SUCCESS in 4m 20s","accounts_in_message":[],"_revision_number":4},{"id":"a936af9ee4be504cde35cae195cc69b59b61dd40","author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"date":"2019-04-08 02:01:06.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"5b460dbbc09588c786de1b48dc923c7787b06b32","author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"date":"2019-04-08 02:12:14.000000000","message":"Patch Set 4:\n\nNow nova will not check if the CPU model is compatible with the host.\nThis can cause libvirt to report errors when using KVM, which can cause performance degradation when using QEMU(This is already explained in the spec).\nI am going to add the relevant check in the code, do these need to be added to spec?","accounts_in_message":[],"_revision_number":4},{"id":"78e038b2df3c3c029af43a2be21484c67da6b54a","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-04-08 16:05:55.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"71e976fb34e27c615ca621d0619fd37d580fcb8a","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-04-08 16:08:19.000000000","message":"Patch Set 4:\n\n\u003e Now nova will not check if the CPU model is compatible with the\n \u003e host.\n \u003e This can cause libvirt to report errors when using KVM, which can\n \u003e cause performance degradation when using QEMU(This is already\n \u003e explained in the spec).\n \u003e I am going to add the relevant check in the code, do these need to\n \u003e be added to spec?\n\nI think that is already taken care by the paragraph:\n\n+If ``cpu_model_extra_flags`` is specified, it should be checked against\n+each CPU model specified in``cpu_model_list`` to make sure it is\n+compatible with *all* the listed CPU models. Any incompatibility should\n+prevent the compute service from starting and user needs to correct the\n+configuration.","accounts_in_message":[],"_revision_number":4},{"id":"02861555636682a94e67af8cd3496908c8295072","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-04-08 16:09:02.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"e4d21b515412078f9edec47400083fb3c7bfeed7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-08 16:35:17.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/30/642030/5/check/openstack-tox-docs/4a4c5cf/ : FAILURE in 6m 24s\n- openstack-tox-pep8 http://logs.openstack.org/30/642030/5/check/openstack-tox-pep8/4825bae/ : SUCCESS in 5m 58s","accounts_in_message":[],"_revision_number":5},{"id":"6abb8f278620c2a0dfe06b2988e15ed2a2ce237e","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-04-08 20:12:05.000000000","message":"Patch Set 5:\n\n\u003e \u003e Now nova will not check if the CPU model is compatible with the\n \u003e \u003e host.\n \u003e \u003e This can cause libvirt to report errors when using KVM, which can\n \u003e \u003e cause performance degradation when using QEMU(This is already\n \u003e \u003e explained in the spec).\n \u003e \u003e I am going to add the relevant check in the code, do these need\n \u003e to\n \u003e \u003e be added to spec?\n \u003e \n \u003e I think that is already taken care by the paragraph:\n \u003e \n \u003e +If ``cpu_model_extra_flags`` is specified, it should be checked\n \u003e against\n \u003e +each CPU model specified in``cpu_model_list`` to make sure it is\n \u003e +compatible with *all* the listed CPU models. Any incompatibility\n \u003e should\n \u003e +prevent the compute service from starting and user needs to\n \u003e correct the\n \u003e +configuration.\n\nErr, the above doesn\u0027t talk anything about if the given CPU model is compatible with the host.\n\nThe \"whether a given CPU description is compatible with the host hypervisor or not\" problem will be tackled by this other in-progress spec:\n\n    https://review.openstack.org/#/c/645814/ -- \n    Add \"CPU selection with hypervisor consideration\" spec","accounts_in_message":[],"_revision_number":5},{"id":"a6da0b6d9d2b2352296dd57c4e4a5ab35430fbc1","author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"date":"2019-04-09 02:03:50.000000000","message":"Patch Set 5:\n\n\u003e \u003e \u003e Now nova will not check if the CPU model is compatible with the\n \u003e \u003e \u003e host.\n \u003e \u003e \u003e This can cause libvirt to report errors when using KVM, which\n \u003e can\n \u003e \u003e \u003e cause performance degradation when using QEMU(This is already\n \u003e \u003e \u003e explained in the spec).\n \u003e \u003e \u003e I am going to add the relevant check in the code, do these need\n \u003e \u003e to\n \u003e \u003e \u003e be added to spec?\n \u003e \u003e\n \u003e \u003e I think that is already taken care by the paragraph:\n \u003e \u003e\n \u003e \u003e +If ``cpu_model_extra_flags`` is specified, it should be checked\n \u003e \u003e against\n \u003e \u003e +each CPU model specified in``cpu_model_list`` to make sure it is\n \u003e \u003e +compatible with *all* the listed CPU models. Any incompatibility\n \u003e \u003e should\n \u003e \u003e +prevent the compute service from starting and user needs to\n \u003e \u003e correct the\n \u003e \u003e +configuration.\n \u003e \n \u003e Err, the above doesn\u0027t talk anything about if the given CPU model\n \u003e is compatible with the host.\n \u003e \n \u003e The \"whether a given CPU description is compatible with the host\n \u003e hypervisor or not\" problem will be tackled by this other\n \u003e in-progress spec:\n \u003e \n \u003e https://review.openstack.org/#/c/645814/ --\n \u003e Add \"CPU selection with hypervisor consideration\" spec\n\nYes, will you do a check when service start in that spec? To check if all models in `cpu_model_list` are compatible with the host. I didn\u0027t see the relevant instructions in that spec :)","accounts_in_message":[],"_revision_number":5},{"id":"54ebb98283db4b29241b113fa3e123c84e14ea93","author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"date":"2019-04-09 02:20:55.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"34ce3f4b301b9aa1f5db3e62082e337a5e5374af","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2019-04-09 09:53:11.000000000","message":"Patch Set 5: Code-Review-1\n\n(4 comments)\n\nI have bad feelings about how it could be error-prone for operators to set an ordered list of CPU models based on some assertions about their capabilities.","accounts_in_message":[],"_revision_number":5},{"id":"68ba84e9ff6d58a85b1ff29399bebd0e5c991101","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-04-09 11:12:42.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"52c18ebb959bb14a056f027fe9d09c05e7723719","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-04-09 11:32:49.000000000","message":"Patch Set 5:\n\n(4 comments)","accounts_in_message":[],"_revision_number":5},{"id":"f3b00aa7511da7dcac9a6c1274c0c506f1dcd302","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-04-09 11:33:16.000000000","message":"Patch Set 5: Code-Review-1\n\n(5 comments)\n\nthis is a fairly soft -1\n\nin general i think the direction is valid","accounts_in_message":[],"_revision_number":5},{"id":"b0df8ee81fd76ea973543fd539b68eee74cb6b81","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-04-09 11:37:02.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"23e67ae4a8761eec9085a80d35a3a333d47e3352","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-04-09 11:54:34.000000000","message":"Patch Set 5:\n\n(4 comments)","accounts_in_message":[],"_revision_number":5},{"id":"93ff027512e3f6e730ab75b5145d550d45c2d43d","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-04-09 12:08:09.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"729c801899f7d9b6ddc2ff7eed5786824c5b60a7","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-04-09 12:14:47.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"9387d66c5820ceac0dd44ff8109dc2bd6377c3f7","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-04-09 12:37:11.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"d40af123a13f394fa56d2cb4bb911e5c992ff7d0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-09 12:57:48.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/30/642030/6/check/openstack-tox-docs/237720d/ : FAILURE in 4m 34s\n- openstack-tox-pep8 http://logs.openstack.org/30/642030/6/check/openstack-tox-pep8/05c75c6/ : SUCCESS in 8m 41s","accounts_in_message":[],"_revision_number":6},{"id":"9b09f58370bcfe7700ad10b7cb2c1b6d335636e6","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2019-04-09 13:44:16.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"eb4841b076387a522db7dc90641eb1373ee86dba","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-04-09 15:17:32.000000000","message":"Patch Set 6:\n\n(3 comments)","accounts_in_message":[],"_revision_number":6},{"id":"92bd136f97bc24b3d5bd942eceda91a0148eb72f","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-04-09 15:23:56.000000000","message":"Patch Set 6: Code-Review+1\n\nReads fine, makes sense, given the constraints of the environment.\n\nFor the uninitiated it appears insane:\n\n* In order to boot a particular set of hw requirements I have to have a flavor with some special properties.\n* In order to select the right compute node, I have to manually (?) list the model names of some CPUs this compute node supports, in config.\n* Those names seem to have zero correspondence to the traits that are in the flavor.\n\nIt\u0027s not clear to me why anyone would want to care about these things. I suppose the operator cares about exposing useful stuff, but damn they have to try hard to make it so.","accounts_in_message":[],"_revision_number":6},{"id":"efce594c41d0805d0d2e5e603c87ce6fade34d95","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-04-10 12:15:43.000000000","message":"Patch Set 6:\n\n(3 comments)","accounts_in_message":[],"_revision_number":6},{"id":"d616cc10d3a90cdcd97b4789aa95b9d6f7b68195","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2019-04-10 12:49:18.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"5f50b34795be10c7f6368c2c224e761dc57ad1df","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2019-04-10 12:51:02.000000000","message":"Patch Set 6: Code-Review-1\n\nThere is one point I want to get the clarify","accounts_in_message":[],"_revision_number":6},{"id":"ce4fab58817a02764ea7714f6ce715626189753c","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-04-10 14:31:06.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"2fe9caf87e6a92c73756ab686ce739c55f629a40","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2019-04-12 06:00:43.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"cd2fdc8a2b57715d76d008c8ea0c7e023909909b","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-04-17 13:07:59.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"d86578fa1035c4aa5259a8fb02a0e98f4cce21c6","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2019-04-18 03:13:53.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"256854715ae55d63b937c4554e3c3fc1d8619859","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-04-18 10:22:16.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"070d813f1e704ad1f91feccb8776c4ae654735a4","author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"date":"2019-05-02 06:00:41.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"9de7bb044096b22850b4676480af638fed07164b","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-05-10 07:36:09.000000000","message":"Patch Set 6:\n\nAfter further discussions with QEMU and libvirt folks, I came to the conclusion that allowing a list of CPU models via a new config attribute is not a robust idea.\n\nTo the extent it is possible, upstream Nova strongly recommends touse the libvirt driver\u0027s default CPU mode \u0027host-model\u0027, which has the double-advantage in that it ensures live migration compatibility plus, more importantly, auto-adds the correct CPU flags that are required for for Meltdown/Spectre mitigation.\n\nGiven the above, I\u0027d like to abandon this spec.  (We can always revisit and re-open it if a strong case emerges for the idea.)","accounts_in_message":[],"_revision_number":6},{"id":"a73e338bdf336fc2fc93926df74fd8fc5f0fd858","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-05-10 07:36:48.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":6},{"id":"abd7df3ec61156e5ce861d7fb03a1a365007d9a3","author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"date":"2019-05-28 10:20:51.000000000","message":"Patch Set 6:\n\n\u003e After further discussions with QEMU and libvirt folks, I came to\n \u003e the conclusion that allowing a list of CPU models via a new config\n \u003e attribute is not a robust idea.\n \u003e \n \u003e To the extent it is possible, upstream Nova strongly recommends\n \u003e touse the libvirt driver\u0027s default CPU mode \u0027host-model\u0027, which has\n \u003e the double-advantage in that it ensures live migration\n \u003e compatibility plus, more importantly, auto-adds the correct CPU\n \u003e flags that are required for for Meltdown/Spectre mitigation.\n \u003e \n \u003e Given the above, I\u0027d like to abandon this spec.  (We can always\n \u003e revisit and re-open it if a strong case emerges for the idea.)\n\nUsing \u0027host-model\u0027 may cause problems in live-migrate. If the cluster have different CPU models among compute nodes, nova may raise an error during live-migration.\nFor example:\nThe cluster has three compute nodes, every compute node has different CPU model: SandyBridge/Haswell/Broadwell.\nIf \u0027host-model\u0027 is used, the vm on the Broadwell node can not be live-migrated to the SandyBridge node, because SandyBridge does not support some of Broadwell\u0027s flags.\nIf \u0027custom\u0027 is used, the cpu model shall be set to SandyBridge in order to live-migrate between each node, but some advanced flags will not be available, such as \u0027avx2\u0027.\nThis spec can take into account of live-migration range and the usage of flags. Of course, the configuration will be troublesome for the cluster administrator and deployer, but I think it can be solved by a detailed documentation.","accounts_in_message":[],"_revision_number":6},{"id":"03d63d6157b76018eff101a935da3a13114daa78","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-06-03 09:39:51.000000000","message":"Patch Set 6:\n\n[...]\n\n \u003e Using \u0027host-model\u0027 may cause problems in live-migrate. If the\n \u003e cluster have different CPU models among compute nodes, nova may\n \u003e raise an error during live-migration.\n \u003e For example:\n \u003e The cluster has three compute nodes, every compute node has\n \u003e different CPU model: SandyBridge/Haswell/Broadwell.\n \u003e If \u0027host-model\u0027 is used, the vm on the Broadwell node can not be\n \u003e live-migrated to the SandyBridge node, because SandyBridge does not\n \u003e support some of Broadwell\u0027s flags.\n\nTo refresh our memory, \u0027host-model\u0027 creates the guest CPU config based on the Compute node, on which the instance was first started.  So, logically, if you start the guest on a node with _newer_ CPU, then migrating to the older node can fail.  That\u0027s expected, if you have a variety of host CPUs.  This is where you use the baselineCPU() / baselineHypervisorCPU() API to run among the Compute hosts and arrive at a common baseline that allows migration across hosts.\n\n \u003e If \u0027custom\u0027 is used, the cpu model shall be set to SandyBridge in\n \u003e order to live-migrate between each node, but some advanced flags\n \u003e will not be available, such as \u0027avx2\u0027.\n\nI think the trade-off here is: pick one, between live-migration compatibility across all hosts and having the \"advanced flags\" from newer CPUs.\n\n \u003e This spec can take into account of live-migration range and the\n \u003e usage of flags. Of course, the configuration will be troublesome\n \u003e for the cluster administrator and deployer, but I think it can be\n \u003e solved by a detailed documentation.\n\nI still think it\u0027s complicated to go the route of allowing a list of CPU models.  Unless someone comes up with a very strong case and a robust design for it.","accounts_in_message":[],"_revision_number":6},{"id":"aec5e23c099ca90e353fbdc1e89732fcb438bd00","author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"date":"2019-06-04 02:10:33.000000000","message":"Patch Set 6:\n\n\u003e [...]\n \u003e \n \u003e \u003e Using \u0027host-model\u0027 may cause problems in live-migrate. If the\n \u003e \u003e cluster have different CPU models among compute nodes, nova may\n \u003e \u003e raise an error during live-migration.\n \u003e \u003e For example:\n \u003e \u003e The cluster has three compute nodes, every compute node has\n \u003e \u003e different CPU model: SandyBridge/Haswell/Broadwell.\n \u003e \u003e If \u0027host-model\u0027 is used, the vm on the Broadwell node can not be\n \u003e \u003e live-migrated to the SandyBridge node, because SandyBridge does\n \u003e not\n \u003e \u003e support some of Broadwell\u0027s flags.\n \u003e \n \u003e To refresh our memory, \u0027host-model\u0027 creates the guest CPU config\n \u003e based on the Compute node, on which the instance was first started.\n \u003e  So, logically, if you start the guest on a node with _newer_ CPU,\n \u003e then migrating to the older node can fail.  That\u0027s expected, if you\n \u003e have a variety of host CPUs.  This is where you use the\n \u003e baselineCPU() / baselineHypervisorCPU() API to run among the\n \u003e Compute hosts and arrive at a common baseline that allows migration\n \u003e across hosts.\n\n Yes, this is describing using \u0027host-model\u0027 is not a good choice when\n using different CPU models in the cluster.\n\n\n \u003e \u003e If \u0027custom\u0027 is used, the cpu model shall be set to SandyBridge in\n \u003e \u003e order to live-migrate between each node, but some advanced flags\n \u003e \u003e will not be available, such as \u0027avx2\u0027.\n \u003e \n \u003e I think the trade-off here is: pick one, between live-migration\n \u003e compatibility across all hosts and having the \"advanced flags\" from\n \u003e newer CPUs.\n\n Yes, so what we want to solve is that we can still guarantee live migration\n compatibility when vm has the \"advanced flags\". The compatible hosts can be\n part of compute hosts.\n \n\n \u003e \u003e This spec can take into account of live-migration range and the\n \u003e \u003e usage of flags. Of course, the configuration will be troublesome\n \u003e \u003e for the cluster administrator and deployer, but I think it can be\n \u003e \u003e solved by a detailed documentation.\n \u003e \n \u003e I still think it\u0027s complicated to go the route of allowing a list\n \u003e of CPU models.  Unless someone comes up with a very strong case and\n \u003e a robust design for it.\n\nCan you explain where is the complexity? Is it in the code implementation,\nor the configuration at deployment, or the use of the admin?","accounts_in_message":[],"_revision_number":6},{"id":"9ce410e02ada26b6c67438d419ef2d377787d885","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-06 13:07:55.000000000","message":"Restored\n\nYa is going to take this over.","accounts_in_message":[],"_revision_number":6},{"id":"d5069586cb3d3ac98513b4b32916f5f7e3d037e1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-06 13:18:40.000000000","message":"Patch Set 6:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/30/642030/6/check/openstack-tox-docs/a63f96a/ : FAILURE in 4m 38s\n- openstack-tox-pep8 http://logs.openstack.org/30/642030/6/check/openstack-tox-pep8/5cdac65/ : SUCCESS in 5m 02s","accounts_in_message":[],"_revision_number":6},{"id":"3791c98d1cee86f95fc5034dc622ac0868896056","author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"date":"2019-06-13 08:26:09.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"3cd0b2a8c668b6a51b9a629bd03edb007a573993","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-13 08:47:35.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/30/642030/7/check/openstack-tox-docs/5a67493/html/ : SUCCESS in 9m 02s\n- openstack-tox-pep8 http://logs.openstack.org/30/642030/7/check/openstack-tox-pep8/b6c4df1/ : SUCCESS in 6m 01s","accounts_in_message":[],"_revision_number":7},{"id":"b52c11a2363acac6326f404f11fd4ee1debbeaca","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-25 20:25:52.000000000","message":"Patch Set 7:\n\nSince there are no votes or comments on PS7, I\u0027m going to spin a rev to fix typos while I review.","accounts_in_message":[],"_revision_number":7},{"id":"250637b5179525a2b012b6574ebf15d979879952","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-25 20:40:12.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"74f832f5963ec710e9667c780d44e8c587634911","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-25 20:51:23.000000000","message":"Patch Set 8: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/30/642030/8/check/openstack-tox-docs/a649ece/html/ : SUCCESS in 5m 52s\n- openstack-tox-pep8 http://logs.openstack.org/30/642030/8/check/openstack-tox-pep8/e20baa9/ : SUCCESS in 3m 37s","accounts_in_message":[],"_revision_number":8},{"id":"a857c6b947a3c8cc792a7336225b4ae25ae98c05","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-25 21:11:10.000000000","message":"Patch Set 8: Code-Review+1\n\n(2 comments)\n\nThere seems to be a use case for this now.\n\nThe opt naming issue is nonblocking IMO, and could be sorted out in the implementation if necessary.\n\nI\u0027m going to hold off approving until folks like Sean and Kashyap have at least agreed not to -1 on the basic idea.","accounts_in_message":[],"_revision_number":8},{"id":"27b16d6d1df880d68f6773219d91de573749d429","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2019-06-27 07:22:26.000000000","message":"Patch Set 8: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"ddbb4089bc50f6bf428213fac9e4917f4f587f74","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-27 12:42:08.000000000","message":"Removed Code-Review+1 by Eric Fried \u003copenstack@fried.cc\u003e\n","accounts_in_message":[],"_revision_number":8},{"id":"3642762d93d848a6b0301b471f33ad4862d02ffc","author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"date":"2019-07-01 13:21:03.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"1894d6666ba034ce6aecf33c2f02c47c0bdd2406","author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"date":"2019-07-01 13:22:48.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"ace942c5523fe95e79d0bf691da50d16d3eb767d","author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"date":"2019-07-01 13:23:11.000000000","message":"Patch Set 8:\n\n(2 comments)","accounts_in_message":[],"_revision_number":8},{"id":"909146ef867581fda72427c897244dc658d76f9f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-01 13:35:45.000000000","message":"Patch Set 10: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/30/642030/10/check/openstack-tox-docs/395b01d/html/ : SUCCESS in 6m 21s\n- openstack-tox-pep8 http://logs.openstack.org/30/642030/10/check/openstack-tox-pep8/142fde6/ : SUCCESS in 3m 18s","accounts_in_message":[],"_revision_number":10},{"id":"7d5996a29c366e2b1212f905bd717d6ff9e5c54f","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-01 15:10:21.000000000","message":"Patch Set 10: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":10},{"id":"f0b4ca20c52c070951a6df63949f0183fbf0b8bc","author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"date":"2019-07-02 02:09:13.000000000","message":"Uploaded patch set 11.","accounts_in_message":[],"_revision_number":11},{"id":"b90abdf23bdd24ca35678d285c91bfac1a74b981","author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"date":"2019-07-02 02:10:00.000000000","message":"Patch Set 10:\n\n(1 comment)","accounts_in_message":[],"_revision_number":10},{"id":"523e566241903d9a16c14f2d78dd39681dbf2e9c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-02 02:17:54.000000000","message":"Patch Set 11: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/30/642030/11/check/openstack-tox-docs/1c482c8/ : FAILURE in 3m 23s\n- openstack-tox-pep8 http://logs.openstack.org/30/642030/11/check/openstack-tox-pep8/e1ff336/ : SUCCESS in 3m 25s","accounts_in_message":[],"_revision_number":11},{"id":"98bd4c963a245f98be55f8734cc95644c693bfbf","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2019-07-02 04:31:36.000000000","message":"Patch Set 11:\n\n(1 comment)","accounts_in_message":[],"_revision_number":11},{"id":"888b0ec85996c41aae78efd51a8f4e533b409a13","author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"date":"2019-07-02 05:16:15.000000000","message":"Uploaded patch set 12.","accounts_in_message":[],"_revision_number":12},{"id":"8433c67c3e1e45a8edb32459d97495271db96cbc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-02 05:25:44.000000000","message":"Patch Set 12: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/30/642030/12/check/openstack-tox-docs/9d23271/html/ : SUCCESS in 5m 06s\n- openstack-tox-pep8 http://logs.openstack.org/30/642030/12/check/openstack-tox-pep8/2942e71/ : SUCCESS in 3m 04s","accounts_in_message":[],"_revision_number":12},{"id":"d17e0e8fa8b091832a991b88aea4aa7e88974361","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-07-02 08:00:02.000000000","message":"Patch Set 12: Code-Review+1\n\n(2 comments)\n\nLooks good.","accounts_in_message":[],"_revision_number":12},{"id":"24c19b5d1b77f25d5e3ce3251d91db37298d0da7","author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"date":"2019-07-02 08:09:33.000000000","message":"Patch Set 12:\n\n(1 comment)","accounts_in_message":[],"_revision_number":12},{"id":"a5f559d59ee01ddb95533cb0442695a4cd0fdbd8","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-02 10:37:15.000000000","message":"Patch Set 12: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":12},{"id":"50985500bba7b8cfd7397ad59bab80a106ab467a","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2019-07-02 11:18:45.000000000","message":"Patch Set 12:\n\n(1 comment)","accounts_in_message":[],"_revision_number":12},{"id":"eca409d7eb848ded816aacaa893853115ab0dd95","author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"date":"2019-07-02 13:27:26.000000000","message":"Uploaded patch set 13.","accounts_in_message":[],"_revision_number":13},{"id":"d6d1da98f66cf7a67eef89bc42fe7e77736aba21","author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"date":"2019-07-02 13:27:46.000000000","message":"Patch Set 12:\n\n(3 comments)","accounts_in_message":[],"_revision_number":12},{"id":"c08f5e34a6bec6baafbd60f3c117cbf274ff6300","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-02 13:30:57.000000000","message":"Patch Set 13: Code-Review+2\n\nThanks for the updates. There are still a couple of typos, but the intent is clear. Let\u0027s make this go.","accounts_in_message":[],"_revision_number":13},{"id":"f999057f43007fab35d5c3979a42f27f9a8c86e2","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-07-02 13:33:43.000000000","message":"Patch Set 13: Code-Review+1\n\nLGTM. I can upgrade my +1 to +2 if Kashyap agrees","accounts_in_message":[],"_revision_number":13},{"id":"484dfb5c1c5cab8ec847c79aa3a080d588b10e15","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2019-07-02 13:34:43.000000000","message":"Patch Set 13: Code-Review+1\n\nLGTM, waiting for few more peple take a look at it","accounts_in_message":[],"_revision_number":13},{"id":"6a991eb5602a37bd9cd17b70494bd1dd8cc33932","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-02 13:41:59.000000000","message":"Patch Set 13: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/30/642030/13/check/openstack-tox-docs/15caf3e/html/ : SUCCESS in 6m 26s\n- openstack-tox-pep8 http://logs.openstack.org/30/642030/13/check/openstack-tox-pep8/28d646e/ : SUCCESS in 3m 46s","accounts_in_message":[],"_revision_number":13},{"id":"e615fb226875e3f9386218302e63e825fd3b03fd","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-07-02 14:43:02.000000000","message":"Patch Set 13:\n\n(1 comment)\n\nConsider this a \"semi-strong +1\" (or: +0.8, if you will), as I see the valid live migration use case, and don\u0027t want to block this re-proposal any further.  We can hash out the rest of the discussion in the implementation.\n\nPS: I\u0027m of course with the plural `cpu_models`, given Eric\u0027s reasoning elsewhere.","accounts_in_message":[],"_revision_number":13},{"id":"0cd9154a4cc6bf49c0d85f5eca55e64fd658983d","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2019-07-02 14:43:09.000000000","message":"Patch Set 13: Code-Review+1","accounts_in_message":[],"_revision_number":13},{"id":"f801e44453889e559d2fcfa1d9d6e32125cd6fd7","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-07-02 14:45:32.000000000","message":"Patch Set 13: Code-Review+2\n\nKashyap\u0027s +0.8 is now included in my vote :)","accounts_in_message":[],"_revision_number":13},{"id":"04672e8f95c71c3617b008c264b8dcb8ad0c2b17","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-07-02 15:43:19.000000000","message":"Patch Set 13: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":13},{"id":"71548cbd5aa9f75972d7f42ed9b08be9be1bd7fc","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-02 16:33:01.000000000","message":"Patch Set 13: Workflow+1","accounts_in_message":[],"_revision_number":13},{"id":"81f21e53778c8408911037b8cf4114dc293990c3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-02 16:33:14.000000000","message":"Patch Set 13: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":13},{"id":"8f4e444eee589f39f33d44b9c34cdf5548e43c95","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-02 16:47:49.000000000","message":"Patch Set 13: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/30/642030/13/gate/openstack-tox-docs/46d01ad/html/ : SUCCESS in 6m 21s\n- openstack-tox-pep8 http://logs.openstack.org/30/642030/13/gate/openstack-tox-pep8/ad7fb21/ : SUCCESS in 3m 17s","accounts_in_message":[],"_revision_number":13},{"id":"a9e2ba423be089c4b6b06566932158a51c036f0e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-02 16:47:49.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":13},{"id":"ebc28b28f5bc449dd99b0186a2fd9c842de04a0c","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-07-02 17:29:16.000000000","message":"Patch Set 13:\n\nI\u0027m late to this party but this looks good. Feel free to ping me if you want help managing the config opt migration since I sadly know too much about these things, heh","accounts_in_message":[],"_revision_number":13}],"current_revision_number":13,"current_revision":"045eec5e460fc062fa4f824543fa1fd5e8b3dc27","revisions":{"8c380c9be9f009171ee991e1e8a9be40ed27b7a2":{"kind":"REWORK","_number":1,"created":"2019-03-08 14:24:10.000000000","uploader":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"ref":"refs/changes/30/642030/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/30/642030/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/1"}}},"commit":{"parents":[{"commit":"d796b33774cc4e21c663885a57141e93052e5546","subject":"Merge \"Amend the detach-boot-volume design\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/d796b33774cc4e21c663885a57141e93052e5546"}]}],"author":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2019-03-08 14:12:55.000000000","tz":60},"committer":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2019-03-08 14:23:46.000000000","tz":60},"subject":"Re-propose the spec to allow specifying a list of CPU models","message":"Re-propose the spec to allow specifying a list of CPU models\n\n[The spec was originally proposed for Stein, by Jack Ding\n\u003cjack.ding@windriver.com\u003e, here:\nhttps://review.openstack.org/#/c/620959/]\n\nA \u0027cometic\u0027 change in this re-proposal: For clarity and sanity, propose\n`cpu_model_list` instead of the plural variant, `cpu_models`, of the\npre-existing `cpu_model`.  Otherwise, supporting both the singular and\nplural variants at the _same_ time can be hard to distinguish and may\nresult in easy screw-ups.  Avoid them.\n\nWhile at it, touch up a couple of ultra minor things: use correct\ncapitalization for acroynyms like CPU, QEMU; use the rST inline literals\nconsistently; and a grammar fix here and there.\n\nblueprint: cpu-model-selection\n\nChange-Id: I4cf9ebb61bc7613f8b55127b4c6cd13591fe4948\nSigned-off-by: Kashyap Chamarthy \u003ckchamart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/8c380c9be9f009171ee991e1e8a9be40ed27b7a2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/8c380c9be9f009171ee991e1e8a9be40ed27b7a2"}]},"branch":"refs/heads/master"},"a748a53a9e4f6ca07585cb4a1aa4bb777ca88b52":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-03-08 16:34:43.000000000","uploader":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"ref":"refs/changes/30/642030/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/30/642030/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/2"}}},"commit":{"parents":[{"commit":"d796b33774cc4e21c663885a57141e93052e5546","subject":"Merge \"Amend the detach-boot-volume design\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/d796b33774cc4e21c663885a57141e93052e5546"}]}],"author":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2019-03-08 14:12:55.000000000","tz":60},"committer":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2019-03-08 16:34:07.000000000","tz":60},"subject":"Re-propose the spec to allow specifying a list of CPU models","message":"Re-propose the spec to allow specifying a list of CPU models\n\n[The spec was originally proposed for Stein, by Jack Ding\n\u003cjack.ding@windriver.com\u003e, here:\nhttps://review.openstack.org/#/c/620959/]\n\nA cosmetic change in this re-proposal: For clarity and sanity, propose\n`cpu_model_list` instead of the plural variant, `cpu_models`, of the\npre-existing `cpu_model`.  Otherwise, supporting both the singular and\nplural variants at the _same_ time can be hard to distinguish and may\nresult in easy screw-ups.  Avoid them.\n\nWhile at it, touch up a couple of ultra minor things: use correct\ncapitalization for acroynyms like CPU, QEMU; use the rST inline literals\nconsistently; and a grammar fix here and there.\n\nPreviously-approved: Stein\n\nblueprint: cpu-model-selection\n\nChange-Id: I4cf9ebb61bc7613f8b55127b4c6cd13591fe4948\nSigned-off-by: Kashyap Chamarthy \u003ckchamart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/a748a53a9e4f6ca07585cb4a1aa4bb777ca88b52"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/a748a53a9e4f6ca07585cb4a1aa4bb777ca88b52"}]},"branch":"refs/heads/master"},"4a12869a91f24ba8644566e58872783a80094503":{"kind":"REWORK","_number":3,"created":"2019-04-02 09:36:40.000000000","uploader":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"ref":"refs/changes/30/642030/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/30/642030/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/3"}}},"commit":{"parents":[{"commit":"d796b33774cc4e21c663885a57141e93052e5546","subject":"Merge \"Amend the detach-boot-volume design\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/d796b33774cc4e21c663885a57141e93052e5546"}]}],"author":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2019-03-08 14:12:55.000000000","tz":60},"committer":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2019-04-02 09:35:22.000000000","tz":120},"subject":"Re-propose the spec to allow specifying a list of CPU models","message":"Re-propose the spec to allow specifying a list of CPU models\n\n[The spec was originally proposed for Stein, by Jack Ding\n\u003cjack.ding@windriver.com\u003e, here:\nhttps://review.openstack.org/#/c/620959/]\n\nChanges in this re-proposal:\n\n  - For clarity and sanity, propose `cpu_model_list` instead of the\n    plural variant, `cpu_models`, of the pre-existing `cpu_model`.\n    Otherwise, supporting both the singular and plural variants at the\n    _same_ time can be hard to distinguish and may result in easy\n    screw-ups.  Avoid them.\n\n  - Touch up a couple of ultra minor things: use correct capitalization\n    for acroynyms like CPU, QEMU; use the rST inline literals\n    consistently; and a grammar fix here and there.\n\n  - Elide incorrect claim about host.compare_cpu().\n\nPreviously-approved: Stein\n\nblueprint: cpu-model-selection\n\nChange-Id: I4cf9ebb61bc7613f8b55127b4c6cd13591fe4948\nSigned-off-by: Kashyap Chamarthy \u003ckchamart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/4a12869a91f24ba8644566e58872783a80094503"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/4a12869a91f24ba8644566e58872783a80094503"}]},"branch":"refs/heads/master"},"c6d8c1dd4a740fbb461ab8c4ea26370f41db5838":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2019-04-03 08:11:01.000000000","uploader":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"ref":"refs/changes/30/642030/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/30/642030/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/4"}}},"commit":{"parents":[{"commit":"a2a3d7203489b85cf519259d9a4eca5ed439aa71","subject":"Re-propose emulated virtual TPM spec to train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/a2a3d7203489b85cf519259d9a4eca5ed439aa71"}]}],"author":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2019-03-08 14:12:55.000000000","tz":60},"committer":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2019-04-03 08:07:23.000000000","tz":120},"subject":"Re-propose the spec to allow specifying a list of CPU models","message":"Re-propose the spec to allow specifying a list of CPU models\n\n[The spec was originally proposed for Stein, by Jack Ding\n\u003cjack.ding@windriver.com\u003e, here:\nhttps://review.openstack.org/#/c/620959/]\n\nChanges in this re-proposal:\n\n  - For clarity and sanity, propose `cpu_model_list` instead of the\n    plural variant, `cpu_models` (of the pre-existing `cpu_model`).\n    Otherwise, supporting both the singular and plural variants at the\n    _same_ time can result in easy screw-ups.  Avoid them.\n\n  - Touch up a couple of ultra minor things: use correct capitalization\n    for acroynyms like CPU and QEMU; use the rST inline literals\n    consistently; a grammar fix and a sentence rephrasing here and\n    there.\n\n  - Elide incorrect claim about host.compare_cpu().\n\nPreviously-approved: Stein\n\nblueprint: cpu-model-selection\n\nChange-Id: I4cf9ebb61bc7613f8b55127b4c6cd13591fe4948\nSigned-off-by: Kashyap Chamarthy \u003ckchamart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/c6d8c1dd4a740fbb461ab8c4ea26370f41db5838"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/c6d8c1dd4a740fbb461ab8c4ea26370f41db5838"}]},"branch":"refs/heads/master"},"4d49c9b79659ad88d682fba5f94e1c09b351c92b":{"kind":"REWORK","_number":5,"created":"2019-04-08 16:09:02.000000000","uploader":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"ref":"refs/changes/30/642030/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/30/642030/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/5"}}},"commit":{"parents":[{"commit":"a2a3d7203489b85cf519259d9a4eca5ed439aa71","subject":"Re-propose emulated virtual TPM spec to train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/a2a3d7203489b85cf519259d9a4eca5ed439aa71"}]}],"author":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2019-03-08 14:12:55.000000000","tz":60},"committer":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2019-04-08 16:08:35.000000000","tz":120},"subject":"Re-propose the spec to allow specifying a list of CPU models","message":"Re-propose the spec to allow specifying a list of CPU models\n\n[The spec was originally proposed for Stein, by Jack Ding\n\u003cjack.ding@windriver.com\u003e, here:\nhttps://review.openstack.org/#/c/620959/]\n\nChanges in this re-proposal:\n\n  - For clarity and sanity, propose `cpu_model_list` instead of the\n    plural variant, `cpu_models` (of the pre-existing `cpu_model`).\n    Otherwise, supporting both the singular and plural variants at the\n    _same_ time can result in easy screw-ups.  Avoid them.\n\n  - Touch up a couple of ultra minor things: use correct capitalization\n    for acronyms like CPU and QEMU; use the rST inline literals\n    consistently; a grammar fix and a sentence rephrasing here and\n    there.\n\n  - Elide incorrect claim about host.compare_cpu().\n\nPreviously-approved: Stein\n\nblueprint: cpu-model-selection\n\nChange-Id: I4cf9ebb61bc7613f8b55127b4c6cd13591fe4948\nSigned-off-by: Kashyap Chamarthy \u003ckchamart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/4d49c9b79659ad88d682fba5f94e1c09b351c92b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/4d49c9b79659ad88d682fba5f94e1c09b351c92b"}]},"branch":"refs/heads/master"},"a12ecb72ccdbdb84f14f9e7c5638c6de000e4d14":{"kind":"REWORK","_number":6,"created":"2019-04-09 12:37:11.000000000","uploader":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"ref":"refs/changes/30/642030/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/30/642030/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/6"}}},"commit":{"parents":[{"commit":"a2a3d7203489b85cf519259d9a4eca5ed439aa71","subject":"Re-propose emulated virtual TPM spec to train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/a2a3d7203489b85cf519259d9a4eca5ed439aa71"}]}],"author":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2019-03-08 14:12:55.000000000","tz":60},"committer":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2019-04-09 12:36:30.000000000","tz":120},"subject":"Re-propose the spec to allow specifying a list of CPU models","message":"Re-propose the spec to allow specifying a list of CPU models\n\n[The spec was originally proposed for Stein, by Jack Ding\n\u003cjack.ding@windriver.com\u003e, here:\nhttps://review.openstack.org/#/c/620959/]\n\nChanges in this re-proposal:\n\n  - For clarity and sanity, propose `cpu_model_list` instead of the\n    plural variant, `cpu_models` (of the existing `cpu_model`).\n    Otherwise, supporting both the singular and plural variants at the\n    _same_ time can result in easy screw-ups.  Avoid them.\n\n  - Write additional context based on further thinking and feedback from\n    reviewers.\n\n  - Touch up a couple of ultra minor things: use correct capitalization\n    for acronyms like CPU and QEMU; use the rST inline literals\n    consistently; a grammar fix and a sentence rephrasing here and\n    there.\n\n  - Elide incorrect claim about host.compare_cpu().\n\n  - Add missing references (e.g. the work to add more\n    \"hypervisor-literate\" CPU APIs to Nova).\n\nPreviously-approved: Stein\n\nblueprint: cpu-model-selection\n\nChange-Id: I4cf9ebb61bc7613f8b55127b4c6cd13591fe4948\nSigned-off-by: Kashyap Chamarthy \u003ckchamart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/a12ecb72ccdbdb84f14f9e7c5638c6de000e4d14"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/a12ecb72ccdbdb84f14f9e7c5638c6de000e4d14"}]},"branch":"refs/heads/master"},"755ec602b52b85c23571f3c86c160e03434c8a7d":{"kind":"REWORK","_number":7,"created":"2019-06-13 08:26:09.000000000","uploader":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"ref":"refs/changes/30/642030/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/30/642030/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/7"}}},"commit":{"parents":[{"commit":"2b2bdfd49fa84b3c05364a09fa8dac9ec8060ce9","subject":"Merge \"Follow up for I9200c2b18369da8b9194a8ccbbf6f1baf6a9613c\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/2b2bdfd49fa84b3c05364a09fa8dac9ec8060ce9"}]}],"author":{"name":"ya.wang","email":"wang.ya@99cloud.net","date":"2019-05-21 07:51:55.000000000","tz":480},"committer":{"name":"ya.wang","email":"wang.ya@99cloud.net","date":"2019-06-13 08:24:35.000000000","tz":480},"subject":"Re-propose the spec to allow specifying a list of CPU models","message":"Re-propose the spec to allow specifying a list of CPU models\n\n[The spec was originally proposed for Stein, by Jack Ding\n\u003cjack.ding@windriver.com\u003e, here:\nhttps://review.openstack.org/#/c/620959/\nThe spec was abandoned by Kashyap Chamarthy, and Ya Wang\ntake over it]\n\nChanges in this re-proposal:\n\n  - For clarity and sanity, propose `cpu_model_list` instead of the\n    plural variant, `cpu_models` (of the existing `cpu_model`).\n    Otherwise, supporting both the singular and plural variants at the\n    _same_ time can result in easy screw-ups.  Avoid them.\n\n  - Write additional context based on further thinking and feedback from\n    reviewers.\n\n  - Touch up a couple of ultra minor things: use correct capitalization\n    for acronyms like CPU and QEMU; use the rST inline literals\n    consistently; a grammar fix and a sentence rephrasing here and\n    there.\n\n  - Elide incorrect claim about host.compare_cpu().\n\n  - Add missing references (e.g. the work to add more\n    \"hypervisor-literate\" CPU APIs to Nova).\n\nPreviously-approved: Stein\n\nblueprint: cpu-model-selection\n\nChange-Id: I4cf9ebb61bc7613f8b55127b4c6cd13591fe4948\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/755ec602b52b85c23571f3c86c160e03434c8a7d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/755ec602b52b85c23571f3c86c160e03434c8a7d"}]},"branch":"refs/heads/master"},"b234ab64c888af8fb32168d2d51ccd5e8e8cad60":{"kind":"REWORK","_number":8,"created":"2019-06-25 20:40:12.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/30/642030/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/30/642030/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/8"}}},"commit":{"parents":[{"commit":"2b2bdfd49fa84b3c05364a09fa8dac9ec8060ce9","subject":"Merge \"Follow up for I9200c2b18369da8b9194a8ccbbf6f1baf6a9613c\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/2b2bdfd49fa84b3c05364a09fa8dac9ec8060ce9"}]}],"author":{"name":"ya.wang","email":"wang.ya@99cloud.net","date":"2019-05-21 07:51:55.000000000","tz":480},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-25 20:36:06.000000000","tz":-300},"subject":"Re-propose the spec to allow specifying a list of CPU models","message":"Re-propose the spec to allow specifying a list of CPU models\n\n[The spec was originally proposed for Stein, by Jack Ding\n\u003cjack.ding@windriver.com\u003e, here:\nhttps://review.openstack.org/#/c/620959/\nThe spec was abandoned by Kashyap Chamarthy, and Ya Wang\ntook it over.]\n\nChanges in this re-proposal:\n\n  - For clarity and sanity, propose `cpu_model_list` instead of the\n    plural variant, `cpu_models` (to replace the existing `cpu_model`).\n    Otherwise, supporting both the singular and plural variants at the\n    _same_ time could result in easy screw-ups.  Avoid them.\n\n  - Write additional context based on further thinking and feedback from\n    reviewers.\n\n  - Touch up a couple of ultra minor things: use correct capitalization\n    for acronyms like CPU and QEMU; use the rST inline literals\n    consistently; a grammar fix and a sentence rephrasing here and\n    there.\n\n  - Elide incorrect claim about host.compare_cpu().\n\n  - Add missing references (e.g. the work to add more\n    \"hypervisor-literate\" CPU APIs to Nova).\n\nPreviously-approved: Stein\nCo-Authored-By: Jack Ding \u003cjack.ding@windriver.com\u003e\nblueprint: cpu-model-selection\n\nChange-Id: I4cf9ebb61bc7613f8b55127b4c6cd13591fe4948\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/b234ab64c888af8fb32168d2d51ccd5e8e8cad60"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/b234ab64c888af8fb32168d2d51ccd5e8e8cad60"}]},"branch":"refs/heads/master"},"b3a5adbc75b5dec280b456095e75d737bd561ae1":{"kind":"REWORK","_number":9,"created":"2019-07-01 13:21:03.000000000","uploader":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"ref":"refs/changes/30/642030/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/30/642030/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/9"}}},"commit":{"parents":[{"commit":"2b2bdfd49fa84b3c05364a09fa8dac9ec8060ce9","subject":"Merge \"Follow up for I9200c2b18369da8b9194a8ccbbf6f1baf6a9613c\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/2b2bdfd49fa84b3c05364a09fa8dac9ec8060ce9"}]}],"author":{"name":"ya.wang","email":"wang.ya@99cloud.net","date":"2019-05-21 07:51:55.000000000","tz":480},"committer":{"name":"ya.wang","email":"wang.ya@99cloud.net","date":"2019-07-01 13:20:02.000000000","tz":480},"subject":"Re-propose the spec to allow specifying a list of CPU models","message":"Re-propose the spec to allow specifying a list of CPU models\n\n[The spec was originally proposed for Stein, by Jack Ding\n\u003cjack.ding@windriver.com\u003e, here:\nhttps://review.openstack.org/#/c/620959/\nThe spec was abandoned by Kashyap Chamarthy, and Ya Wang\ntook it over.]\n\nChanges in this re-proposal:\n\n  - For clarity and sanity, propose `cpu_model_list` instead of the\n    plural variant, `cpu_models` (to replace the existing `cpu_model`).\n    Otherwise, supporting both the singular and plural variants at the\n    _same_ time could result in easy screw-ups.  Avoid them.\n\n  - Write additional context based on further thinking and feedback from\n    reviewers.\n\n  - Touch up a couple of ultra minor things: use correct capitalization\n    for acronyms like CPU and QEMU; use the rST inline literals\n    consistently; a grammar fix and a sentence rephrasing here and\n    there.\n\n  - Elide incorrect claim about host.compare_cpu().\n\n  - Add missing references (e.g. the work to add more\n    \"hypervisor-literate\" CPU APIs to Nova).\n\nPreviously-approved: Stein\nCo-Authored-By: Jack Ding \u003cjack.ding@windriver.com\u003e\nblueprint: cpu-model-selection\n\nChange-Id: I4cf9ebb61bc7613f8b55127b4c6cd13591fe4948\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/b3a5adbc75b5dec280b456095e75d737bd561ae1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/b3a5adbc75b5dec280b456095e75d737bd561ae1"}]},"branch":"refs/heads/master"},"f240c550ef2d37f696fdfa484fc59eb949bfd094":{"kind":"REWORK","_number":10,"created":"2019-07-01 13:22:48.000000000","uploader":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"ref":"refs/changes/30/642030/10","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/30/642030/10","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/10"}}},"commit":{"parents":[{"commit":"2b2bdfd49fa84b3c05364a09fa8dac9ec8060ce9","subject":"Merge \"Follow up for I9200c2b18369da8b9194a8ccbbf6f1baf6a9613c\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/2b2bdfd49fa84b3c05364a09fa8dac9ec8060ce9"}]}],"author":{"name":"ya.wang","email":"wang.ya@99cloud.net","date":"2019-05-21 07:51:55.000000000","tz":480},"committer":{"name":"ya.wang","email":"wang.ya@99cloud.net","date":"2019-07-01 13:22:29.000000000","tz":480},"subject":"Re-propose the spec to allow specifying a list of CPU models","message":"Re-propose the spec to allow specifying a list of CPU models\n\n[The spec was originally proposed for Stein, by Jack Ding\n\u003cjack.ding@windriver.com\u003e, here:\nhttps://review.openstack.org/#/c/620959/\nThe spec was abandoned by Kashyap Chamarthy, and Ya Wang\ntook it over.]\n\nChanges in this re-proposal:\n\n  - For clarity and sanity, propose `cpu_model_list` instead of the\n    plural variant, `cpu_models` (to replace the existing `cpu_model`).\n    Otherwise, supporting both the singular and plural variants at the\n    _same_ time could result in easy screw-ups.  Avoid them.\n\n  - Write additional context based on further thinking and feedback from\n    reviewers.\n\n  - Touch up a couple of ultra minor things: use correct capitalization\n    for acronyms like CPU and QEMU; use the rST inline literals\n    consistently; a grammar fix and a sentence rephrasing here and\n    there.\n\n  - Elide incorrect claim about host.compare_cpu().\n\n  - Add missing references (e.g. the work to add more\n    \"hypervisor-literate\" CPU APIs to Nova).\n\nPreviously-approved: Stein\nCo-Authored-By: Jack Ding \u003cjack.ding@windriver.com\u003e\nblueprint: cpu-model-selection\n\nChange-Id: I4cf9ebb61bc7613f8b55127b4c6cd13591fe4948\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/f240c550ef2d37f696fdfa484fc59eb949bfd094"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/f240c550ef2d37f696fdfa484fc59eb949bfd094"}]},"branch":"refs/heads/master"},"b420357024c6a491edc48c6db437068feca0997c":{"kind":"REWORK","_number":11,"created":"2019-07-02 02:09:13.000000000","uploader":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"ref":"refs/changes/30/642030/11","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/30/642030/11","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/11"}}},"commit":{"parents":[{"commit":"2b2bdfd49fa84b3c05364a09fa8dac9ec8060ce9","subject":"Merge \"Follow up for I9200c2b18369da8b9194a8ccbbf6f1baf6a9613c\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/2b2bdfd49fa84b3c05364a09fa8dac9ec8060ce9"}]}],"author":{"name":"ya.wang","email":"wang.ya@99cloud.net","date":"2019-05-21 07:51:55.000000000","tz":480},"committer":{"name":"ya.wang","email":"wang.ya@99cloud.net","date":"2019-07-02 02:08:27.000000000","tz":480},"subject":"Re-propose the spec to allow specifying a list of CPU models","message":"Re-propose the spec to allow specifying a list of CPU models\n\n[The spec was originally proposed for Stein, by Jack Ding\n\u003cjack.ding@windriver.com\u003e, here:\nhttps://review.openstack.org/#/c/620959/\nThe spec was abandoned by Kashyap Chamarthy, and Ya Wang\ntook it over.]\n\nChanges in this re-proposal:\n\n  - Write additional context based on further thinking and feedback from\n    reviewers.\n\n  - Touch up a couple of ultra minor things: use correct capitalization\n    for acronyms like CPU and QEMU; use the rST inline literals\n    consistently; a grammar fix and a sentence rephrasing here and\n    there.\n\n  - Elide incorrect claim about host.compare_cpu().\n\n  - Add missing references (e.g. the work to add more\n    \"hypervisor-literate\" CPU APIs to Nova).\n\nPreviously-approved: Stein\nCo-Authored-By: Jack Ding \u003cjack.ding@windriver.com\u003e\nblueprint: cpu-model-selection\n\nChange-Id: I4cf9ebb61bc7613f8b55127b4c6cd13591fe4948\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/b420357024c6a491edc48c6db437068feca0997c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/b420357024c6a491edc48c6db437068feca0997c"}]},"branch":"refs/heads/master"},"02fb02f0bac0e596bfd02cf89f2639adbf5e33d1":{"kind":"REWORK","_number":12,"created":"2019-07-02 05:16:15.000000000","uploader":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"ref":"refs/changes/30/642030/12","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/30/642030/12","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/12"}}},"commit":{"parents":[{"commit":"2b2bdfd49fa84b3c05364a09fa8dac9ec8060ce9","subject":"Merge \"Follow up for I9200c2b18369da8b9194a8ccbbf6f1baf6a9613c\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/2b2bdfd49fa84b3c05364a09fa8dac9ec8060ce9"}]}],"author":{"name":"ya.wang","email":"wang.ya@99cloud.net","date":"2019-05-21 07:51:55.000000000","tz":480},"committer":{"name":"ya.wang","email":"wang.ya@99cloud.net","date":"2019-07-02 05:15:23.000000000","tz":480},"subject":"Re-propose the spec to allow specifying a list of CPU models","message":"Re-propose the spec to allow specifying a list of CPU models\n\n[The spec was originally proposed for Stein, by Jack Ding\n\u003cjack.ding@windriver.com\u003e, here:\nhttps://review.openstack.org/#/c/620959/\nThe spec was abandoned by Kashyap Chamarthy, and Ya Wang\ntook it over.]\n\nChanges in this re-proposal:\n\n  - Write additional context based on further thinking and feedback from\n    reviewers.\n\n  - Touch up a couple of ultra minor things: use correct capitalization\n    for acronyms like CPU and QEMU; use the rST inline literals\n    consistently; a grammar fix and a sentence rephrasing here and\n    there.\n\n  - Elide incorrect claim about host.compare_cpu().\n\n  - Add missing references (e.g. the work to add more\n    \"hypervisor-literate\" CPU APIs to Nova).\n\nPreviously-approved: Stein\nCo-Authored-By: Jack Ding \u003cjack.ding@windriver.com\u003e\nblueprint: cpu-model-selection\n\nChange-Id: I4cf9ebb61bc7613f8b55127b4c6cd13591fe4948\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/02fb02f0bac0e596bfd02cf89f2639adbf5e33d1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/02fb02f0bac0e596bfd02cf89f2639adbf5e33d1"}]},"branch":"refs/heads/master"},"045eec5e460fc062fa4f824543fa1fd5e8b3dc27":{"kind":"REWORK","_number":13,"created":"2019-07-02 13:27:26.000000000","uploader":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"ref":"refs/changes/30/642030/13","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/30/642030/13","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/13 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/13 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/13 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/30/642030/13"}}},"commit":{"parents":[{"commit":"2b2bdfd49fa84b3c05364a09fa8dac9ec8060ce9","subject":"Merge \"Follow up for I9200c2b18369da8b9194a8ccbbf6f1baf6a9613c\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/2b2bdfd49fa84b3c05364a09fa8dac9ec8060ce9"}]}],"author":{"name":"ya.wang","email":"wang.ya@99cloud.net","date":"2019-05-21 07:51:55.000000000","tz":480},"committer":{"name":"ya.wang","email":"wang.ya@99cloud.net","date":"2019-07-02 13:27:05.000000000","tz":480},"subject":"Re-propose the spec to allow specifying a list of CPU models","message":"Re-propose the spec to allow specifying a list of CPU models\n\n[The spec was originally proposed for Stein, by Jack Ding\n\u003cjack.ding@windriver.com\u003e, here:\nhttps://review.openstack.org/#/c/620959/\nThe spec was abandoned by Kashyap Chamarthy, and Ya Wang\ntook it over.]\n\nChanges in this re-proposal:\n\n  - Write additional context based on further thinking and feedback from\n    reviewers.\n\n  - Touch up a couple of ultra minor things: use correct capitalization\n    for acronyms like CPU and QEMU; use the rST inline literals\n    consistently; a grammar fix and a sentence rephrasing here and\n    there.\n\n  - Elide incorrect claim about host.compare_cpu().\n\n  - Add missing references (e.g. the work to add more\n    \"hypervisor-literate\" CPU APIs to Nova).\n\nPreviously-approved: Stein\nCo-Authored-By: Jack Ding \u003cjack.ding@windriver.com\u003e\nblueprint: cpu-model-selection\n\nChange-Id: I4cf9ebb61bc7613f8b55127b4c6cd13591fe4948\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/045eec5e460fc062fa4f824543fa1fd5e8b3dc27"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/045eec5e460fc062fa4f824543fa1fd5e8b3dc27"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}