)]}'
{"specs/train/approved/expose-auto-converge-in-rest-api.rst":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"11f612301006bc1bd7b4ed4cb04dca8d0bd5e7b4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"the configuration file, nova will automatically check whether the live"},{"line_number":19,"context_line":"migration supports auto converge."},{"line_number":20,"context_line":"The problem is that end user can\u0027t use auto converge on a specify instance"},{"line_number":21,"context_line":"which the host didn\u0027t configured it."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_7d0ec88c","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":36},"updated":"2019-04-09 15:42:13.000000000","message":"when the host wasn\u0027t configured for it","commit_id":"c4137a0af26c9b1c640a170b7a219de10eb6bf86"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"11f612301006bc1bd7b4ed4cb04dca8d0bd5e7b4","unresolved":false,"context_lines":[{"line_number":26,"context_line":"* The guest is writing to memory faster than libvirt can transfer the memory"},{"line_number":27,"context_line":"  changes to the destination host, and the auto converge didn\u0027t configured in"},{"line_number":28,"context_line":"  nova. As an end user, i\u0027d like to use auto converge to make migration work"},{"line_number":29,"context_line":"  well."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* The guest is writing to memory faster than libvirt can transfer the memory"},{"line_number":32,"context_line":"  changes to the destination host, and the auto converge was enabled. But the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_bd99901f","line":29,"updated":"2019-04-09 15:42:13.000000000","message":"Technically, from an operator\u0027s perspective, you could provide an aggregate with auto_converge\u003dtrue metadata and just use flavors having an auto_converge\u003dtrue spec (with a specific filter too).\n\nOh, you would then leak your hypervisor to your users, but then you could tell them to just use flavors having this spec.\nThat\u0027s what you actually want, nope ?\n\nYou could even ask users to tag their own images with a metadata key to be auto_converge\u003dtrue and then some other filter would do the job.","commit_id":"c4137a0af26c9b1c640a170b7a219de10eb6bf86"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"aca51819dc7a584ed73799c04fbee845dec43437","unresolved":false,"context_lines":[{"line_number":26,"context_line":"* The guest is writing to memory faster than libvirt can transfer the memory"},{"line_number":27,"context_line":"  changes to the destination host, and the auto converge didn\u0027t configured in"},{"line_number":28,"context_line":"  nova. As an end user, i\u0027d like to use auto converge to make migration work"},{"line_number":29,"context_line":"  well."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* The guest is writing to memory faster than libvirt can transfer the memory"},{"line_number":32,"context_line":"  changes to the destination host, and the auto converge was enabled. But the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_37dccadf","line":29,"in_reply_to":"5fc1f717_bd99901f","updated":"2019-04-10 11:04:20.000000000","message":"Thanks for your review:\nYes, using flavor extra specs and image metadata is a more better way. But do we need to introduce aggregate?\nI guess you mean to schedule these instance to the aggregate that supports auto converge, this may cause some hosts in the cluster to be heavily loaded. I think it is better to use flavor extra flags and image metadata to make live migration meet user expectations.\nAlso, could we add \u0027post copy\u0027 to here?","commit_id":"c4137a0af26c9b1c640a170b7a219de10eb6bf86"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"11f612301006bc1bd7b4ed4cb04dca8d0bd5e7b4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* Add ``auto_converge`` to the REST API ``POST /servers/{server_id}/action``,"},{"line_number":40,"context_line":"  for what the action is ``os-migrateLive``."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"::"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_9d7854f8","line":40,"updated":"2019-04-09 15:42:13.000000000","message":"no, because it\u0027s libvirt specific. Users don\u0027t know which hypervisor is running behind compute API.","commit_id":"c4137a0af26c9b1c640a170b7a219de10eb6bf86"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c3d2dd5b76a819679802006dc8b1a9bd4eabf5bc","unresolved":false,"context_lines":[{"line_number":53,"context_line":"* Libvirt driver: recalculate ``_live_migration_flags`` before doing"},{"line_number":54,"context_line":"  ``_live_migration``."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"If the configuration conflicts with the API sent, we use the value of api to"},{"line_number":57,"context_line":"datermine whether to use auto converge."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_9b3ffb23","line":56,"updated":"2019-04-09 17:06:47.000000000","message":"Based on https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.live_migration_permit_auto_converge auto-converge only happens if post-copy is disabled or not available (but I think it\u0027s available in the minimum required libvirt version now: https://review.openstack.org/#/c/649671/), anyway, are you saying here that even if post-copy is enabled and available, if the API says auto_converge\u003dTrue we\u0027d start the live migration with auto-converge rather than do any post-copy?\n\nAlso, what would happen if the live migration is started with auto-converge and then the force complete API is called which tries to trigger post-copy? Will that blow up the live migration or just fail the post-copy request?","commit_id":"c4137a0af26c9b1c640a170b7a219de10eb6bf86"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"aca51819dc7a584ed73799c04fbee845dec43437","unresolved":false,"context_lines":[{"line_number":53,"context_line":"* Libvirt driver: recalculate ``_live_migration_flags`` before doing"},{"line_number":54,"context_line":"  ``_live_migration``."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"If the configuration conflicts with the API sent, we use the value of api to"},{"line_number":57,"context_line":"datermine whether to use auto converge."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5fc1f717_17c66e69","line":56,"in_reply_to":"5fc1f717_9b3ffb23","updated":"2019-04-10 11:04:20.000000000","message":"Thanks for your review:\n1. No, according to this page, if auto_converge and post_copy are both True, then libvirt will use post_copy.\n\n2. If libvirt uses auto converge during live migration, it means that post-copy is disabled, so it will not trigger post-copy when call force complete API.","commit_id":"c4137a0af26c9b1c640a170b7a219de10eb6bf86"}]}