)]}'
{"specs/train/approved/introduce-pending-vm-state.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a60a43c0455afb65c0bdc1116a735a65027ea7eb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":"https://blueprints.launchpad.net/nova/+spec/introduce-pending-vm-state"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This feature adds support for the PENDING server state. When the scheduler"},{"line_number":13,"context_line":"determines there is no capacity available for the given request, and so the"},{"line_number":14,"context_line":"instance is about to be routed into cell0, the server should be set into the"},{"line_number":15,"context_line":"PENDING state instead of ERROR if the operator wishes so. This will allow the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_3dcda05c","line":12,"range":{"start_line":12,"start_character":34,"end_line":12,"end_character":41},"updated":"2019-04-09 15:37:25.000000000","message":"``PENDING`` (here and elsewhere)","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"78f960410348ea34b00ee278e0c467a11a61a9f1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":"https://blueprints.launchpad.net/nova/+spec/introduce-pending-vm-state"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This feature adds support for the PENDING server state. When the scheduler"},{"line_number":13,"context_line":"determines there is no capacity available for the given request, and so the"},{"line_number":14,"context_line":"instance is about to be routed into cell0, the server should be set into the"},{"line_number":15,"context_line":"PENDING state instead of ERROR if the operator wishes so. This will allow the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fce034c_c98d767c","line":12,"range":{"start_line":12,"start_character":34,"end_line":12,"end_character":41},"in_reply_to":"5fc1f717_3dcda05c","updated":"2019-04-11 09:02:56.000000000","message":"Done","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a60a43c0455afb65c0bdc1116a735a65027ea7eb","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This feature adds support for the PENDING server state. When the scheduler"},{"line_number":13,"context_line":"determines there is no capacity available for the given request, and so the"},{"line_number":14,"context_line":"instance is about to be routed into cell0, the server should be set into the"},{"line_number":15,"context_line":"PENDING state instead of ERROR if the operator wishes so. This will allow the"},{"line_number":16,"context_line":"execution of subsequent actions transparently to the end user."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_9d05b47c","line":15,"range":{"start_line":15,"start_character":25,"end_line":15,"end_character":30},"updated":"2019-04-09 15:37:25.000000000","message":"``ERROR`` (here and elsewhere)","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"78f960410348ea34b00ee278e0c467a11a61a9f1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This feature adds support for the PENDING server state. When the scheduler"},{"line_number":13,"context_line":"determines there is no capacity available for the given request, and so the"},{"line_number":14,"context_line":"instance is about to be routed into cell0, the server should be set into the"},{"line_number":15,"context_line":"PENDING state instead of ERROR if the operator wishes so. This will allow the"},{"line_number":16,"context_line":"execution of subsequent actions transparently to the end user."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fce034c_69e80216","line":15,"range":{"start_line":15,"start_character":25,"end_line":15,"end_character":30},"in_reply_to":"5fc1f717_9d05b47c","updated":"2019-04-11 09:02:56.000000000","message":"Done","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c2edc8ea086c37aa3033b3df258ea3ddc7f963a5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            }"},{"line_number":38,"context_line":"        }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        NOTE::"},{"line_number":41,"context_line":"        The rebuild api needs to be adapted to take care of instances that fail"},{"line_number":42,"context_line":"        while building and are mapped to cell0. This change is considered out"},{"line_number":43,"context_line":"        of scope for this spec and is being addressed by another spec [1]"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_5d0aecd0","line":40,"updated":"2019-04-09 15:31:34.000000000","message":"please s/NOTE::/note::/ and also see the output which is wrong (because of a wrong column) :\nhttp://logs.openstack.org/87/648687/1/check/openstack-tox-docs/d7b6e70/html/specs/train/approved/introduce-pending-vm-state.html","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"78f960410348ea34b00ee278e0c467a11a61a9f1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            }"},{"line_number":38,"context_line":"        }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        NOTE::"},{"line_number":41,"context_line":"        The rebuild api needs to be adapted to take care of instances that fail"},{"line_number":42,"context_line":"        while building and are mapped to cell0. This change is considered out"},{"line_number":43,"context_line":"        of scope for this spec and is being addressed by another spec [1]"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fce034c_29f2fa07","line":40,"in_reply_to":"5fc1f717_5d0aecd0","updated":"2019-04-11 09:02:56.000000000","message":"Done","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c2edc8ea086c37aa3033b3df258ea3ddc7f963a5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        NOTE::"},{"line_number":41,"context_line":"        The rebuild api needs to be adapted to take care of instances that fail"},{"line_number":42,"context_line":"        while building and are mapped to cell0. This change is considered out"},{"line_number":43,"context_line":"        of scope for this spec and is being addressed by another spec [1]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"#. failure, the external service will set the state of the instance to ERROR"},{"line_number":46,"context_line":"   (using reset-state)::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_bdc0b051","line":43,"range":{"start_line":43,"start_character":70,"end_line":43,"end_character":73},"updated":"2019-04-09 15:31:34.000000000","message":"nit: [1]_","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a60a43c0455afb65c0bdc1116a735a65027ea7eb","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            }"},{"line_number":38,"context_line":"        }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        NOTE::"},{"line_number":41,"context_line":"        The rebuild api needs to be adapted to take care of instances that fail"},{"line_number":42,"context_line":"        while building and are mapped to cell0. This change is considered out"},{"line_number":43,"context_line":"        of scope for this spec and is being addressed by another spec [1]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"#. failure, the external service will set the state of the instance to ERROR"},{"line_number":46,"context_line":"   (using reset-state)::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_bde190d2","line":43,"range":{"start_line":40,"start_character":0,"end_line":43,"end_character":73},"updated":"2019-04-09 15:37:25.000000000","message":"nit: dedent this and switch to a directive,\n\n  #. success, the ... ::\n\n         POST /servers/{server_id}/action\n         {\n             ...\n         }\n\n     .. note:: The rebuild ...","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"78f960410348ea34b00ee278e0c467a11a61a9f1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        NOTE::"},{"line_number":41,"context_line":"        The rebuild api needs to be adapted to take care of instances that fail"},{"line_number":42,"context_line":"        while building and are mapped to cell0. This change is considered out"},{"line_number":43,"context_line":"        of scope for this spec and is being addressed by another spec [1]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"#. failure, the external service will set the state of the instance to ERROR"},{"line_number":46,"context_line":"   (using reset-state)::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fce034c_09d93e82","line":43,"range":{"start_line":43,"start_character":70,"end_line":43,"end_character":73},"in_reply_to":"5fc1f717_bdc0b051","updated":"2019-04-11 09:02:56.000000000","message":"Done","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"78f960410348ea34b00ee278e0c467a11a61a9f1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            }"},{"line_number":38,"context_line":"        }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        NOTE::"},{"line_number":41,"context_line":"        The rebuild api needs to be adapted to take care of instances that fail"},{"line_number":42,"context_line":"        while building and are mapped to cell0. This change is considered out"},{"line_number":43,"context_line":"        of scope for this spec and is being addressed by another spec [1]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"#. failure, the external service will set the state of the instance to ERROR"},{"line_number":46,"context_line":"   (using reset-state)::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fce034c_e9db927a","line":43,"range":{"start_line":40,"start_character":0,"end_line":43,"end_character":73},"in_reply_to":"5fc1f717_bde190d2","updated":"2019-04-11 09:02:56.000000000","message":"Done","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a60a43c0455afb65c0bdc1116a735a65027ea7eb","unresolved":false,"context_lines":[{"line_number":63,"context_line":"Proposed change"},{"line_number":64,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"#. Add the PENDING state in the InstanceState object."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"#. Add the PENDING state in compute vm_states."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_5d30ac55","line":66,"range":{"start_line":66,"start_character":32,"end_line":66,"end_character":45},"updated":"2019-04-09 15:37:25.000000000","message":"Format as a ``literal``. Ditto for the rest of the code-ish things below","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"78f960410348ea34b00ee278e0c467a11a61a9f1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"Proposed change"},{"line_number":64,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"#. Add the PENDING state in the InstanceState object."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"#. Add the PENDING state in compute vm_states."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fce034c_499d0658","line":66,"range":{"start_line":66,"start_character":32,"end_line":66,"end_character":45},"in_reply_to":"5fc1f717_5d30ac55","updated":"2019-04-11 09:02:56.000000000","message":"Tried to do that. I hope I didn\u0027t miss anything.","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a60a43c0455afb65c0bdc1116a735a65027ea7eb","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"#. Add the PENDING state in the server ViewBuilder as a new progress status."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"#. Add a configuration option that defaults to ``False`` in the DEFAULT group"},{"line_number":73,"context_line":"   to enable the use of PENDING vm_state on NoValidHost events::"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        CONF.use_pending_state"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"#. Add the following code in the conductor manager ``_bury_in_cell0`` method"},{"line_number":78,"context_line":"   to make sure that the a vm is set to PENDING only when the operator has"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_1d278414","line":75,"range":{"start_line":72,"start_character":0,"end_line":75,"end_character":30},"updated":"2019-04-09 15:37:25.000000000","message":"Doesn\u0027t this mean we\u0027ll end up with different behavior between different clouds?","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"11dcfd72b43991f12601acb56f706db85045ed02","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"#. Add the PENDING state in the server ViewBuilder as a new progress status."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"#. Add a configuration option that defaults to ``False`` in the DEFAULT group"},{"line_number":73,"context_line":"   to enable the use of PENDING vm_state on NoValidHost events::"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        CONF.use_pending_state"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"#. Add the following code in the conductor manager ``_bury_in_cell0`` method"},{"line_number":78,"context_line":"   to make sure that the a vm is set to PENDING only when the operator has"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fce034c_845ab327","line":75,"range":{"start_line":72,"start_character":0,"end_line":75,"end_character":30},"in_reply_to":"3fce034c_a9ab4a73","updated":"2019-04-15 16:46:49.000000000","message":"Will that be discoverable in some way by the end user?\n\nIf not, we\u0027re creating an incompatibility in the API which is generally something we\u0027d like to avoid.\n\nIt might be okay to argue that because the if True state is to place the workload \"soon\" it is okay, but what happens when it is not soon?","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"78f960410348ea34b00ee278e0c467a11a61a9f1","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"#. Add the PENDING state in the server ViewBuilder as a new progress status."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"#. Add a configuration option that defaults to ``False`` in the DEFAULT group"},{"line_number":73,"context_line":"   to enable the use of PENDING vm_state on NoValidHost events::"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        CONF.use_pending_state"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"#. Add the following code in the conductor manager ``_bury_in_cell0`` method"},{"line_number":78,"context_line":"   to make sure that the a vm is set to PENDING only when the operator has"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fce034c_a9ab4a73","line":75,"range":{"start_line":72,"start_character":0,"end_line":75,"end_character":30},"in_reply_to":"5fc1f717_1d278414","updated":"2019-04-11 09:02:56.000000000","message":"Yes. It\u0027s the deployer\u0027s option to use it or not","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c2edc8ea086c37aa3033b3df258ea3ddc7f963a5","unresolved":false,"context_lines":[{"line_number":158,"context_line":"requested resources have to be freed up."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"The transformation of the existing ``select_destinations`` notification from"},{"line_number":161,"context_line":"unversioned to a versioned one, is out of scope of this spec. There is an"},{"line_number":162,"context_line":"existing change that tries to address the transformation of the notification"},{"line_number":163,"context_line":"and can be picked up [2]."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Other end user impact"},{"line_number":166,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_5d7f4c16","line":163,"range":{"start_line":161,"start_character":61,"end_line":163,"end_character":25},"updated":"2019-04-09 15:31:34.000000000","message":"already merged.","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"78f960410348ea34b00ee278e0c467a11a61a9f1","unresolved":false,"context_lines":[{"line_number":158,"context_line":"requested resources have to be freed up."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"The transformation of the existing ``select_destinations`` notification from"},{"line_number":161,"context_line":"unversioned to a versioned one, is out of scope of this spec. There is an"},{"line_number":162,"context_line":"existing change that tries to address the transformation of the notification"},{"line_number":163,"context_line":"and can be picked up [2]."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Other end user impact"},{"line_number":166,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fce034c_29b19ae2","line":163,"range":{"start_line":161,"start_character":61,"end_line":163,"end_character":25},"in_reply_to":"5fc1f717_5d7f4c16","updated":"2019-04-11 09:02:56.000000000","message":"Yeap. Removed this part and added a reference to the code. Thanks","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c2edc8ea086c37aa3033b3df258ea3ddc7f963a5","unresolved":false,"context_lines":[{"line_number":240,"context_line":"References"},{"line_number":241,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"[1] Enable rebuild for instances in cell0"},{"line_number":244,"context_line":"    https://review.openstack.org/#/c/554218/"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"[2] WIP: Transform scheduler.select_destinations notification"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_bda510b7","line":243,"range":{"start_line":243,"start_character":0,"end_line":243,"end_character":3},"updated":"2019-04-09 15:31:34.000000000","message":".. [1]","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"78f960410348ea34b00ee278e0c467a11a61a9f1","unresolved":false,"context_lines":[{"line_number":240,"context_line":"References"},{"line_number":241,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"[1] Enable rebuild for instances in cell0"},{"line_number":244,"context_line":"    https://review.openstack.org/#/c/554218/"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"[2] WIP: Transform scheduler.select_destinations notification"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fce034c_49b666dc","line":243,"range":{"start_line":243,"start_character":0,"end_line":243,"end_character":3},"in_reply_to":"5fc1f717_bda510b7","updated":"2019-04-11 09:02:56.000000000","message":"Done","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c2edc8ea086c37aa3033b3df258ea3ddc7f963a5","unresolved":false,"context_lines":[{"line_number":241,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"[1] Enable rebuild for instances in cell0"},{"line_number":244,"context_line":"    https://review.openstack.org/#/c/554218/"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"[2] WIP: Transform scheduler.select_destinations notification"},{"line_number":247,"context_line":"    https://review.openstack.org/#/c/508506/"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_fde878df","line":244,"range":{"start_line":244,"start_character":4,"end_line":244,"end_character":44},"updated":"2019-04-09 15:31:34.000000000","message":"wrong link, you now need to use the Train change : \nhttps://review.openstack.org/#/c/648686/","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"78f960410348ea34b00ee278e0c467a11a61a9f1","unresolved":false,"context_lines":[{"line_number":241,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"[1] Enable rebuild for instances in cell0"},{"line_number":244,"context_line":"    https://review.openstack.org/#/c/554218/"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"[2] WIP: Transform scheduler.select_destinations notification"},{"line_number":247,"context_line":"    https://review.openstack.org/#/c/508506/"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fce034c_e9cab24d","line":244,"range":{"start_line":244,"start_character":4,"end_line":244,"end_character":44},"in_reply_to":"5fc1f717_fde878df","updated":"2019-04-11 09:02:56.000000000","message":"Done","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c2edc8ea086c37aa3033b3df258ea3ddc7f963a5","unresolved":false,"context_lines":[{"line_number":243,"context_line":"[1] Enable rebuild for instances in cell0"},{"line_number":244,"context_line":"    https://review.openstack.org/#/c/554218/"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"[2] WIP: Transform scheduler.select_destinations notification"},{"line_number":247,"context_line":"    https://review.openstack.org/#/c/508506/"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"As discussed in the Dublin PTG:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_7dab2887","line":246,"range":{"start_line":246,"start_character":0,"end_line":246,"end_character":3},"updated":"2019-04-09 15:31:34.000000000","message":"ditto as L243","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"78f960410348ea34b00ee278e0c467a11a61a9f1","unresolved":false,"context_lines":[{"line_number":243,"context_line":"[1] Enable rebuild for instances in cell0"},{"line_number":244,"context_line":"    https://review.openstack.org/#/c/554218/"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"[2] WIP: Transform scheduler.select_destinations notification"},{"line_number":247,"context_line":"    https://review.openstack.org/#/c/508506/"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"As discussed in the Dublin PTG:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fce034c_09c85e53","line":246,"range":{"start_line":246,"start_character":0,"end_line":246,"end_character":3},"in_reply_to":"5fc1f717_7dab2887","updated":"2019-04-11 09:02:56.000000000","message":"Removed and added a reference to the code","commit_id":"b07cc1664c21be86d6c68dd51b6a5c703441a3d7"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6a808b7531ab0f699688bb78c7d057208db94e14","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            }"},{"line_number":38,"context_line":"        }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. note:: The rebuild api needs to be adapted to take care of instances that"},{"line_number":41,"context_line":"          fail while building and are mapped to cell0. This change is"},{"line_number":42,"context_line":"          considered out of scope for this spec and is being addressed by"},{"line_number":43,"context_line":"          another spec [#]_."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"#. failure, the external service will set the state of the instance to"},{"line_number":46,"context_line":"   ``ERROR`` (using reset-state)::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fce034c_d26dbd04","line":43,"range":{"start_line":40,"start_character":0,"end_line":43,"end_character":28},"updated":"2019-04-16 22:26:47.000000000","message":"indent this note to preserve numbering in the surrounding list.","commit_id":"19f546042f028976af92f86148fcade161e46a1b"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"1335be366cf1eab589466e754362efb0222cdb04","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            }"},{"line_number":38,"context_line":"        }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. note:: The rebuild api needs to be adapted to take care of instances that"},{"line_number":41,"context_line":"          fail while building and are mapped to cell0. This change is"},{"line_number":42,"context_line":"          considered out of scope for this spec and is being addressed by"},{"line_number":43,"context_line":"          another spec [#]_."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"#. failure, the external service will set the state of the instance to"},{"line_number":46,"context_line":"   ``ERROR`` (using reset-state)::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_1b6d10cb","line":43,"range":{"start_line":40,"start_character":0,"end_line":43,"end_character":28},"in_reply_to":"3fce034c_d26dbd04","updated":"2019-07-02 13:40:13.000000000","message":"Done","commit_id":"19f546042f028976af92f86148fcade161e46a1b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"62e3a61310d7f18872f3696841dbedf7418a95d8","unresolved":false,"context_lines":[{"line_number":157,"context_line":"service about a server\u0027s build procedure outcome. The plan is to use this"},{"line_number":158,"context_line":"notification in order to enable the external Reaper service, to know where the"},{"line_number":159,"context_line":"requested resources have to be freed up. The existing ``select_destinations``"},{"line_number":160,"context_line":"versioned notification from can be used [#]_."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Other end user impact"},{"line_number":163,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_856443ba","line":160,"range":{"start_line":160,"start_character":23,"end_line":160,"end_character":27},"updated":"2019-07-02 11:54:46.000000000","message":"nit: nix","commit_id":"19f546042f028976af92f86148fcade161e46a1b"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"1335be366cf1eab589466e754362efb0222cdb04","unresolved":false,"context_lines":[{"line_number":157,"context_line":"service about a server\u0027s build procedure outcome. The plan is to use this"},{"line_number":158,"context_line":"notification in order to enable the external Reaper service, to know where the"},{"line_number":159,"context_line":"requested resources have to be freed up. The existing ``select_destinations``"},{"line_number":160,"context_line":"versioned notification from can be used [#]_."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Other end user impact"},{"line_number":163,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_3b7014a4","line":160,"range":{"start_line":160,"start_character":23,"end_line":160,"end_character":27},"in_reply_to":"9fb8cfa7_856443ba","updated":"2019-07-02 13:40:13.000000000","message":"Done","commit_id":"19f546042f028976af92f86148fcade161e46a1b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"11dcfd72b43991f12601acb56f706db85045ed02","unresolved":false,"context_lines":[{"line_number":163,"context_line":"---------------------"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"The end user will have servers in ``PENDING`` state if the operator chooses to"},{"line_number":166,"context_line":"enable the configuration option ``CONF.use_pending_state``."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Performance Impact"},{"line_number":169,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fce034c_6441c70b","line":166,"updated":"2019-04-15 16:46:49.000000000","message":"does this mean the end user needs to write code that does two differen things depending on how a particular cloud is configured?\n\nhow will they know?","commit_id":"19f546042f028976af92f86148fcade161e46a1b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"62e3a61310d7f18872f3696841dbedf7418a95d8","unresolved":false,"context_lines":[{"line_number":163,"context_line":"---------------------"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"The end user will have servers in ``PENDING`` state if the operator chooses to"},{"line_number":166,"context_line":"enable the configuration option ``CONF.use_pending_state``."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Performance Impact"},{"line_number":169,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_6506efd0","line":166,"in_reply_to":"3fce034c_5312410b","updated":"2019-07-02 11:54:46.000000000","message":"For me it is simple. If the cloud deployer configures the use of the PENDING state then such deployer also needs to add an external service that moves instances from PENDING to ACTIVE or ERROR automatically.","commit_id":"19f546042f028976af92f86148fcade161e46a1b"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"d0d38bb05b3e5a103d9156b052318616b82952a0","unresolved":false,"context_lines":[{"line_number":163,"context_line":"---------------------"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"The end user will have servers in ``PENDING`` state if the operator chooses to"},{"line_number":166,"context_line":"enable the configuration option ``CONF.use_pending_state``."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Performance Impact"},{"line_number":169,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fce034c_5312410b","line":166,"in_reply_to":"3fce034c_6441c70b","updated":"2019-04-16 09:34:15.000000000","message":"The end users are not expected to react to the PENDING state because it is not a \"final\" state. It\u0027s an intermediate state to inform that background actions are taking place and depending on the outcome the instance will be scheduled again or end up in ERROR. It\u0027s the deployer\u0027s \"duty\" to not leave instances in the PENDING state. Having this in mind and also that most scripts react only to final states (e.g. https://github.com/openstack/osc-lib/blob/master/osc_lib/utils/__init__.py#L663), I could rephrase this saying something like: \"after microversion x, instances might go through the PENDING state as well, depending on whether the operator chooses to enable this state or not\", if you agree with this.","commit_id":"19f546042f028976af92f86148fcade161e46a1b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"8cc202bfa72b4391bbc3f7092616ad65ce559044","unresolved":false,"context_lines":[{"line_number":163,"context_line":"---------------------"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"The end user will have servers in ``PENDING`` state if the operator chooses to"},{"line_number":166,"context_line":"enable the configuration option ``CONF.use_pending_state``."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Performance Impact"},{"line_number":169,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_45b2cbe6","line":166,"in_reply_to":"9fb8cfa7_6506efd0","updated":"2019-07-02 12:12:31.000000000","message":"That sounds fail or succeed slow (because that service has to wake up and create capacity which can take time), which is different from fail fast. What I\u0027m trying to discern is if that is an interoperability concern. It sounds like for most people it is not.","commit_id":"19f546042f028976af92f86148fcade161e46a1b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d6020de3974a6ff3a7b441717fa3a1b5028e9e2e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"#. Add the ``PENDING`` state in the server ViewBuilder as a new progress"},{"line_number":71,"context_line":"   status."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"#. Add a configuration option that defaults to ``False`` in the DEFAULT group"},{"line_number":74,"context_line":"   to enable the use of ``PENDING`` vm_state on ``NoValidHost`` events::"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        CONF.use_pending_state"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_b670960a","line":73,"range":{"start_line":73,"start_character":9,"end_line":73,"end_character":29},"updated":"2019-07-02 18:33:33.000000000","message":"Where should this be set? Conductor?\n\n[Later] Yes, implied by the next bullet.","commit_id":"d1fba0ea236cb2b158bdcd2557efea8d65e7f335"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d6020de3974a6ff3a7b441717fa3a1b5028e9e2e","unresolved":false,"context_lines":[{"line_number":162,"context_line":"Other end user impact"},{"line_number":163,"context_line":"---------------------"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"From the new microversion that introduces the new instace state and beyond, end"},{"line_number":166,"context_line":"users need to account for the possibility of instances going through the"},{"line_number":167,"context_line":"PENDING state (which may or may not happen, depending on the way the operator"},{"line_number":168,"context_line":"chooses to configure the cloud)."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_964552b7","line":165,"range":{"start_line":165,"start_character":50,"end_line":165,"end_character":57},"updated":"2019-07-02 18:33:33.000000000","message":"instance","commit_id":"d1fba0ea236cb2b158bdcd2557efea8d65e7f335"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"1335be366cf1eab589466e754362efb0222cdb04","unresolved":false,"context_lines":[{"line_number":236,"context_line":"   transferred to the external service as soon as the instance is set to the"},{"line_number":237,"context_line":"   ``PENDING`` state."},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"#. Document that after the new microversion instances might go through the"},{"line_number":240,"context_line":"   ``PENDING`` state as well, depending on whether the operator chooses to"},{"line_number":241,"context_line":"   enable this state or not."},{"line_number":242,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_9b47c04c","line":239,"updated":"2019-07-02 13:40:13.000000000","message":"@Chris, do you think this is enough? We could add something else if you prefer.","commit_id":"d1fba0ea236cb2b158bdcd2557efea8d65e7f335"}]}