)]}'
{"specs/train/approved/int-replace-default-value-of-the-flavor-swap.rst":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7fe94f4bbd38f9ee3b8905eff726f4add3e652c0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"As a user, I want to call the acquired data through the interface, as explained"},{"line_number":62,"context_line":"in the nova API documentation, to improve the robustness of the nova API."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"As a Developer, I would like to provide and maintain better and conssitant"},{"line_number":65,"context_line":"APIs."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fce034c_69ce302f","line":64,"range":{"start_line":64,"start_character":64,"end_line":64,"end_character":74},"updated":"2019-04-19 01:05:10.000000000","message":"consistant","commit_id":"8a69b8039e21eea7a395416a5f465d642d6ebc5f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f49861fd250bd3bfc4955d52b8d6790ede34ffc9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"As a user, I want to call the acquired data through the interface, as explained"},{"line_number":62,"context_line":"in the nova API documentation, to improve the robustness of the nova API."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"As a Developer, I would like to provide and maintain better and conssitant"},{"line_number":65,"context_line":"APIs."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fce034c_e43fa5b1","line":64,"range":{"start_line":64,"start_character":64,"end_line":64,"end_character":74},"in_reply_to":"3fce034c_69ce302f","updated":"2019-04-19 01:33:54.000000000","message":"I will fix it in next patch.","commit_id":"8a69b8039e21eea7a395416a5f465d642d6ebc5f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7fe94f4bbd38f9ee3b8905eff726f4add3e652c0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Add a new microversion to the show flavor details API to change the default"},{"line_number":70,"context_line":"return value of ``swap``, 0 instead of u\u0027\u0027."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Change the default return value of ``swap`` in the response body of the"},{"line_number":73,"context_line":"create flavor API and modify the ``swap`` description in the interface."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Alternatives"},{"line_number":76,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fce034c_29d4a8bc","line":73,"range":{"start_line":72,"start_character":45,"end_line":73,"end_character":17},"updated":"2019-04-19 01:05:10.000000000","message":"mentioned create but no API impact below in POST","commit_id":"8a69b8039e21eea7a395416a5f465d642d6ebc5f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f49861fd250bd3bfc4955d52b8d6790ede34ffc9","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Add a new microversion to the show flavor details API to change the default"},{"line_number":70,"context_line":"return value of ``swap``, 0 instead of u\u0027\u0027."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Change the default return value of ``swap`` in the response body of the"},{"line_number":73,"context_line":"create flavor API and modify the ``swap`` description in the interface."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Alternatives"},{"line_number":76,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fce034c_045511fa","line":73,"range":{"start_line":72,"start_character":45,"end_line":73,"end_character":17},"in_reply_to":"3fce034c_29d4a8bc","updated":"2019-04-19 01:33:54.000000000","message":"Yeah, this cannot impact the POST API.","commit_id":"8a69b8039e21eea7a395416a5f465d642d6ebc5f"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"15b2a9ac967d32c1640db3e9b222d221047f38fa","unresolved":false,"context_lines":[{"line_number":87,"context_line":"* URL:"},{"line_number":88,"context_line":"    * /flavors/{flavor_id}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"* Request method:"},{"line_number":91,"context_line":"    * GET"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"* Normal response codes:"},{"line_number":94,"context_line":"    * 200"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fce034c_fcf18e6c","line":91,"range":{"start_line":90,"start_character":0,"end_line":91,"end_character":9},"updated":"2019-04-18 08:17:31.000000000","message":"so, are we add a new microversion just for GET or do we add for both POST and GET?","commit_id":"8a69b8039e21eea7a395416a5f465d642d6ebc5f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f49861fd250bd3bfc4955d52b8d6790ede34ffc9","unresolved":false,"context_lines":[{"line_number":87,"context_line":"* URL:"},{"line_number":88,"context_line":"    * /flavors/{flavor_id}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"* Request method:"},{"line_number":91,"context_line":"    * GET"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"* Normal response codes:"},{"line_number":94,"context_line":"    * 200"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fce034c_e43a45ca","line":91,"range":{"start_line":90,"start_character":0,"end_line":91,"end_character":9},"in_reply_to":"3fce034c_fcf18e6c","updated":"2019-04-19 01:33:54.000000000","message":"Add the microversion to GET is ok, look at [1], when we create a flavor its checksum  is [\u0027integer\u0027, \u0027string\u0027]. In addition in novaclient it has the type change for int()[2] when create by CLI \u0027nova flavor-create ***\u0027.\nSo, I think change for GET is ok.\n[1] https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/flavor_manage.py#L38\n[2]https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/flavors.py#L220","commit_id":"8a69b8039e21eea7a395416a5f465d642d6ebc5f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b54198229940c6f763a0c28b86a029f87df81cf5","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":"Currently creating a flavor, if you don\u0027t set the ``swap`` property (Optional),"},{"line_number":19,"context_line":"the value of the ``swap`` property in the flavor will return u\u0027\u0027, as in the"},{"line_number":20,"context_line":"following example:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  CLI command is:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_db6f42c3","line":19,"range":{"start_line":18,"start_character":29,"end_line":19,"end_character":64},"updated":"2019-04-23 19:08:12.000000000","message":"Yeah this is weird because the API reference for GET /flavors/{flavor_id} says swap is an integer but then also says, \"The size of a dedicated swap disk that will be allocated, in MiB. If 0 (the default), no dedicated swap disk will be created. Currently, the empty string (\u0027\u0027) is used to represent 0.\"","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3ce30e31e78c37a910e43f95c7b494029d159a62","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":"Currently creating a flavor, if you don\u0027t set the ``swap`` property (Optional),"},{"line_number":19,"context_line":"the value of the ``swap`` property in the flavor will return u\u0027\u0027, as in the"},{"line_number":20,"context_line":"following example:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  CLI command is:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_9ac66e9a","line":19,"range":{"start_line":18,"start_character":29,"end_line":19,"end_character":64},"in_reply_to":"ffb9cba7_db6f42c3","updated":"2019-04-26 02:28:50.000000000","message":"Yup, it\u0027s the parameter\u0027s description in create flavor API.\nhttps://developer.openstack.org/api-ref/compute/?expanded\u003dcreate-flavor-detail#create-flavor","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b54198229940c6f763a0c28b86a029f87df81cf5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"the value of the ``swap`` property in the flavor will return u\u0027\u0027, as in the"},{"line_number":20,"context_line":"following example:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  CLI command is:"},{"line_number":23,"context_line":"    nova --debug flavor-create flavor_noset_swap auto 1024 1 2"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  The response body of above command is:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_5bbfd2fa","line":22,"updated":"2019-04-23 19:08:12.000000000","message":"nit: the formatting in this block is a bit wrong, you could drop the indent for the CLI command part.","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3ce30e31e78c37a910e43f95c7b494029d159a62","unresolved":false,"context_lines":[{"line_number":19,"context_line":"the value of the ``swap`` property in the flavor will return u\u0027\u0027, as in the"},{"line_number":20,"context_line":"following example:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  CLI command is:"},{"line_number":23,"context_line":"    nova --debug flavor-create flavor_noset_swap auto 1024 1 2"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  The response body of above command is:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_ba6572e3","line":22,"in_reply_to":"ffb9cba7_5bbfd2fa","updated":"2019-04-26 02:28:50.000000000","message":"Done","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b54198229940c6f763a0c28b86a029f87df81cf5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  CLI command is:"},{"line_number":23,"context_line":"    nova --debug flavor-create flavor_noset_swap auto 1024 1 2"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  The response body of above command is:"},{"line_number":26,"context_line":"      {"},{"line_number":27,"context_line":"          \"flavor\": {"},{"line_number":28,"context_line":"              \"description\": null,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_7bbc1605","line":25,"updated":"2019-04-23 19:08:12.000000000","message":"Drop the indent here and then use a json code-block, for example:\n\nThe response body of above command is:\n\n.. code-style: json\n\n  {\n    \"flavor\": {\n      ...\n    }\n  }","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3ce30e31e78c37a910e43f95c7b494029d159a62","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  CLI command is:"},{"line_number":23,"context_line":"    nova --debug flavor-create flavor_noset_swap auto 1024 1 2"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  The response body of above command is:"},{"line_number":26,"context_line":"      {"},{"line_number":27,"context_line":"          \"flavor\": {"},{"line_number":28,"context_line":"              \"description\": null,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_3a9f42b5","line":25,"in_reply_to":"ffb9cba7_5b54b2ca","updated":"2019-04-26 02:28:50.000000000","message":"Done","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9209fd8724e925211106e5b9e410a96c0e817a5c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  CLI command is:"},{"line_number":23,"context_line":"    nova --debug flavor-create flavor_noset_swap auto 1024 1 2"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  The response body of above command is:"},{"line_number":26,"context_line":"      {"},{"line_number":27,"context_line":"          \"flavor\": {"},{"line_number":28,"context_line":"              \"description\": null,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_5b54b2ca","line":25,"in_reply_to":"ffb9cba7_7bbc1605","updated":"2019-04-23 19:10:25.000000000","message":"That should have been:\n\n.. code-block:: json","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b54198229940c6f763a0c28b86a029f87df81cf5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"But if you execute this command and specifying the ``swap`` property with u\u0027\u0027,"},{"line_number":57,"context_line":"it will be raising an exception from the novaclient \"Swap must be an integer.\"."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Use Cases"},{"line_number":60,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_bb660eed","line":57,"updated":"2019-04-23 19:08:12.000000000","message":"Yup, and that\u0027s because of the schema:\n\n{\n    \u0027type\u0027: [\u0027integer\u0027, \u0027string\u0027],\n    \u0027pattern\u0027: \u0027^[0-9]+$\u0027,\n    \u0027minimum\u0027: 0,\n    # maximum\u0027s value is limited to db constant\u0027s MAX_INT\n    # (in nova/db/constants.py)\n    \u0027maximum\u0027: 0x7FFFFFFF\n}","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7360d9c86bce3d2f69602e3315226b8c4c0ede32","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"But if you execute this command and specifying the ``swap`` property with u\u0027\u0027,"},{"line_number":57,"context_line":"it will be raising an exception from the novaclient \"Swap must be an integer.\"."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Use Cases"},{"line_number":60,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_52f9afc5","line":57,"in_reply_to":"ffb9cba7_1a383e9e","updated":"2019-04-26 20:00:20.000000000","message":"this is due to int casting in novaclient\n\n- https://opendev.org/openstack/python-novaclient/src/commit/f7f5df9c1d7c6304f05fbabc42d57c071a51b5d5/novaclient/v2/flavors.py\n\n\nAPI return error like below:\n\nERROR (BadRequest): Invalid input for field/attribute swap. Value: . u\u0027\u0027 does not match \u0027^[0-9]+$\u0027 (HTTP 400) (Request-ID: req-70ee89c7-1d3d-4a94-a553-35fc43a9702d)","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"889ff2db7632f71f888b9990a8f5c4e7945d5b3e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"But if you execute this command and specifying the ``swap`` property with u\u0027\u0027,"},{"line_number":57,"context_line":"it will be raising an exception from the novaclient \"Swap must be an integer.\"."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Use Cases"},{"line_number":60,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_17a8fb8a","line":57,"in_reply_to":"ffb9cba7_52f9afc5","updated":"2019-04-28 01:48:14.000000000","message":"Yes, noavclient encapsulates the parameters.","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3ce30e31e78c37a910e43f95c7b494029d159a62","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"But if you execute this command and specifying the ``swap`` property with u\u0027\u0027,"},{"line_number":57,"context_line":"it will be raising an exception from the novaclient \"Swap must be an integer.\"."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Use Cases"},{"line_number":60,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_1a383e9e","line":57,"in_reply_to":"ffb9cba7_bb660eed","updated":"2019-04-26 02:28:50.000000000","message":"Yeah.","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b54198229940c6f763a0c28b86a029f87df81cf5","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Proposed change"},{"line_number":68,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":69,"context_line":"Add a new microversion to the show flavor details API to change the default"},{"line_number":70,"context_line":"return value of ``swap``, 0 instead of u\u0027\u0027."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Change the default return value of ``swap`` in the response body of the"},{"line_number":73,"context_line":"create flavor API and modify the ``swap`` description in the interface."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_1b84fa5d","line":70,"updated":"2019-04-23 19:08:12.000000000","message":"And this is because of the \"or \u0027\u0027\" logic in the view builder:\n\nhttps://github.com/openstack/nova/blob/fc3890667e4971e3f0f35ac921c2a6c25f72adec/nova/api/openstack/compute/views/flavors.py#L55\n\nSo in the new microversion we\u0027d just drop the \"or \u0027\u0027\".\n\nInterestingly, note that when we show the embedded flavor for a server the swap value is going to be 0 by default:\n\nhttps://github.com/openstack/nova/blob/fc3890667e4971e3f0f35ac921c2a6c25f72adec/nova/api/openstack/compute/views/servers.py#L486","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3ce30e31e78c37a910e43f95c7b494029d159a62","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Proposed change"},{"line_number":68,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":69,"context_line":"Add a new microversion to the show flavor details API to change the default"},{"line_number":70,"context_line":"return value of ``swap``, 0 instead of u\u0027\u0027."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Change the default return value of ``swap`` in the response body of the"},{"line_number":73,"context_line":"create flavor API and modify the ``swap`` description in the interface."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_3c1dff65","line":70,"in_reply_to":"ffb9cba7_1b84fa5d","updated":"2019-04-26 02:28:50.000000000","message":"Yup, Inconsistency.","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b54198229940c6f763a0c28b86a029f87df81cf5","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Alternatives"},{"line_number":76,"context_line":"------------"},{"line_number":77,"context_line":"None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Data model impact"},{"line_number":80,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_fb82464f","line":77,"updated":"2019-04-23 19:08:12.000000000","message":"Since it\u0027s come up twice during review, you could mention that an alternative here (not for the change itself, but in tracking the change) is to incorporate it into the bigger API inconsistency cleanup change https://review.openstack.org/#/c/603969/ but I agree that change is already quite large and it\u0027d be nice to avoid too much scope creep in a single microversion (which will be hard to review and test properly). This change is very small though, so this on its own might not be so bad to integrate with the other cleanup spec.\n\nI\u0027ll ask gmann for his thoughts.","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7360d9c86bce3d2f69602e3315226b8c4c0ede32","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Alternatives"},{"line_number":76,"context_line":"------------"},{"line_number":77,"context_line":"None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Data model impact"},{"line_number":80,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_cdd2e05c","line":77,"in_reply_to":"ffb9cba7_3a18a2d1","updated":"2019-04-26 20:00:20.000000000","message":"yeah this is not so big change and I feel good to fix. we also have an old bug (since v2) for this - https://bugs.launchpad.net/nova/+bug/1436683\n\nI quickly searched the API view builder and did not find any other API with a similar issue but let me do the detailed audit. and based on that we can fix this along with other cleanup listed in below etherpad (I have added this issue in etherpad).\n- https://etherpad.openstack.org/p/nova-api-cleanup","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"889ff2db7632f71f888b9990a8f5c4e7945d5b3e","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Alternatives"},{"line_number":76,"context_line":"------------"},{"line_number":77,"context_line":"None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Data model impact"},{"line_number":80,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_b7a80f8c","line":77,"in_reply_to":"ffb9cba7_cdd2e05c","updated":"2019-04-28 01:48:14.000000000","message":"Cool, thanks.","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3ce30e31e78c37a910e43f95c7b494029d159a62","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Alternatives"},{"line_number":76,"context_line":"------------"},{"line_number":77,"context_line":"None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Data model impact"},{"line_number":80,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_3a18a2d1","line":77,"in_reply_to":"ffb9cba7_fb82464f","updated":"2019-04-26 02:28:50.000000000","message":"Emm... I think, in order to avoid the nova API to add too much microversion, this spec can use the same microversion as ``API inconsistency cleanup``_.","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b54198229940c6f763a0c28b86a029f87df81cf5","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"REST API impact"},{"line_number":84,"context_line":"---------------"},{"line_number":85,"context_line":"Add a new microversion to the show flavor details API."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* URL:"},{"line_number":88,"context_line":"    * /flavors/{flavor_id}"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_dbf2e206","line":85,"updated":"2019-04-23 19:08:12.000000000","message":"Technically it would also be in the response for:\n\n- POST /flavors\n- GET /flavors/detail\n- PUT /flavors/{flavor_id}\n\nSo you can probably just list those (along with GET /flavors/{flavor_id}). I think it\u0027s enough to say the swap parameter would change in the response for all of them without having to document each individually along with the response codes and such.","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3ce30e31e78c37a910e43f95c7b494029d159a62","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"REST API impact"},{"line_number":84,"context_line":"---------------"},{"line_number":85,"context_line":"Add a new microversion to the show flavor details API."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* URL:"},{"line_number":88,"context_line":"    * /flavors/{flavor_id}"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_ba09f231","line":85,"in_reply_to":"ffb9cba7_dbf2e206","updated":"2019-04-26 02:28:50.000000000","message":"Indeed, these interfaces will be affected, investigate the API interface, and summarize the affected interfaces here.","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b54198229940c6f763a0c28b86a029f87df81cf5","unresolved":false,"context_lines":[{"line_number":149,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":150,"context_line":"* Add related unit test."},{"line_number":151,"context_line":"* Add related functional tests."},{"line_number":152,"context_line":"* Add tempest tests."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Documentation Impact"},{"line_number":155,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_dbcbc2a2","line":152,"updated":"2019-04-23 19:08:12.000000000","message":"I don\u0027t think tempest tests are necessary for this. If someone needs to modify a compute API response schema in tempest later as a result of this change that\u0027s fine, but I don\u0027t think we need to explicitly test this in tempest, functional tests in nova is sufficient.","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7360d9c86bce3d2f69602e3315226b8c4c0ede32","unresolved":false,"context_lines":[{"line_number":149,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":150,"context_line":"* Add related unit test."},{"line_number":151,"context_line":"* Add related functional tests."},{"line_number":152,"context_line":"* Add tempest tests."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Documentation Impact"},{"line_number":155,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_d2a11fab","line":152,"in_reply_to":"ffb9cba7_7ab4da35","updated":"2019-04-26 20:00:20.000000000","message":"+1. only schema gap is ok which we can usually cover at the end of cycle or if any higher microversion test need that","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3ce30e31e78c37a910e43f95c7b494029d159a62","unresolved":false,"context_lines":[{"line_number":149,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":150,"context_line":"* Add related unit test."},{"line_number":151,"context_line":"* Add related functional tests."},{"line_number":152,"context_line":"* Add tempest tests."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Documentation Impact"},{"line_number":155,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffb9cba7_7ab4da35","line":152,"in_reply_to":"ffb9cba7_dbcbc2a2","updated":"2019-04-26 02:28:50.000000000","message":"Yeah, it\u0027s redundant.","commit_id":"0bb124e604ca9e4b089365952b0396569f438948"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7360d9c86bce3d2f69602e3315226b8c4c0ede32","unresolved":false,"context_lines":[{"line_number":20,"context_line":"the value of the ``swap`` property in the flavor will return u\u0027\u0027, this problem"},{"line_number":21,"context_line":"is thrown on the lanchpad [1]_, as in the following example:"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"CLI command is:"},{"line_number":24,"context_line":"  nova --debug flavor-create flavor_noset_swap auto 1024 1 2"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The response body of above command is:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffb9cba7_f2d54344","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":15},"updated":"2019-04-26 20:00:20.000000000","message":"can you show the API calling example as CLI might have lot of wrappers and pre-error hanlding.","commit_id":"9988262e27145282d2c5daed8815dd4bef70ab7e"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"4d3c9476516c795a864703a760900e45ff45d217","unresolved":false,"context_lines":[{"line_number":91,"context_line":"REST API impact"},{"line_number":92,"context_line":"---------------"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Add a new microversion to the related flavor APIs."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  * POST /flavors"},{"line_number":97,"context_line":"  * GET /flavors/detail"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dfbec78f_1c1ab27c","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":50},"updated":"2019-05-07 01:06:01.000000000","message":"This will have the same microvervison as the ``API inconsistency cleanup``_:\n\n_API inconsistency cleanup: https://review.opendev.org/#/c/603969/","commit_id":"9988262e27145282d2c5daed8815dd4bef70ab7e"}]}