)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ee59b2ae65d20e9db43afdfd79d65c3649696ea5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This spec present numa information in server diagnostic API."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"APIImpact"},{"line_number":12,"context_line":"bp: show-server-numa-topology"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I60b16eee2f03a78382b735ccad588d0d619e7693"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_f87e6117","line":12,"updated":"2019-05-13 15:42:15.000000000","message":"Nit: we could add previously approved.","commit_id":"1516bc3dc57d5ebaed0f96d2b791395a3f4ecf5e"}],"specs/train/approved/show-server-numa-topology.rst":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c4e6795e97c6273446379972f0ee9418af47dc3b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"         # overall policy: TOPOLOGY % \u0027index"},{"line_number":98,"context_line":"         \"nodes\":["},{"line_number":99,"context_line":"                    {"},{"line_number":100,"context_line":"                      # Host Numa Node"},{"line_number":101,"context_line":"                      # control by policy TOPOLOGY % \u0027index:host_info\u0027"},{"line_number":102,"context_line":"                      \"host_numa_node\": 3,"},{"line_number":103,"context_line":"                      # 0:5 means vcpu 0 pinning to pcpu 5"},{"line_number":104,"context_line":"                      # control by policy TOPOLOGY % \u0027index:host_info\u0027"},{"line_number":105,"context_line":"                      \"cpu_pinning\": {0:5, 1:6},"},{"line_number":106,"context_line":"                      \"vcpu_set\": [0,1,2,3],"},{"line_number":107,"context_line":"                      \"siblings\": [[0,1],[2,3]],"},{"line_number":108,"context_line":"                      \"memory_mb\": 1024,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfbec78f_d8c35d56","line":105,"range":{"start_line":100,"start_character":0,"end_line":105,"end_character":48},"updated":"2019-05-13 15:40:22.000000000","message":"This means I am fine with what we merged last cycle, we only expose host details to admins.","commit_id":"1516bc3dc57d5ebaed0f96d2b791395a3f4ecf5e"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"2b125f5c07247baf0e6ed36b9d6d734c8461dde7","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                      \"siblings\": [[0,1],[2,3]],"},{"line_number":108,"context_line":"                      \"memory_mb\": 1024,"},{"line_number":109,"context_line":"                      \"pagesize_kb\": 4096,"},{"line_number":110,"context_line":"                      \"cores\": 2,"},{"line_number":111,"context_line":"                      # one core has at least one thread"},{"line_number":112,"context_line":"                      \"threads\": 2"},{"line_number":113,"context_line":"                    }"},{"line_number":114,"context_line":"                    ..."},{"line_number":115,"context_line":"                   ], # nodes"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb3d3c7_3046b023","line":112,"range":{"start_line":110,"start_character":22,"end_line":112,"end_character":34},"updated":"2019-05-21 13:09:14.000000000","message":"I guess this two should be removed also.\n\nSince we can\u0027t get those value for numa node. numa_cell_obj.cpu_topology is empty except cpu policy is dedicated.\n\nThis is major concern from Sean, I hope him to have look at.","commit_id":"1516bc3dc57d5ebaed0f96d2b791395a3f4ecf5e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"611a1d25651d1047db45ab1ae608417b6434e16d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  instances for the purpose of debugging, and admin need make sure the NUMA"},{"line_number":37,"context_line":"  topology is what it\u0027s supposed to be, and is correctly mapped onto Host."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* The end user could have all of above abilities if admin alows them by change"},{"line_number":40,"context_line":"  policy rule."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_65f15d6b","line":39,"range":{"start_line":39,"start_character":58,"end_line":39,"end_character":63},"updated":"2019-05-28 14:24:19.000000000","message":"allows","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"611a1d25651d1047db45ab1ae608417b6434e16d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  instances for the purpose of debugging, and admin need make sure the NUMA"},{"line_number":37,"context_line":"  topology is what it\u0027s supposed to be, and is correctly mapped onto Host."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* The end user could have all of above abilities if admin alows them by change"},{"line_number":40,"context_line":"  policy rule."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_85f6d162","line":39,"range":{"start_line":39,"start_character":72,"end_line":39,"end_character":78},"updated":"2019-05-28 14:24:19.000000000","message":"changing","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"198a9d6c8a94a52925d573e5b1dc82201f373a34","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  instances for the purpose of debugging, and admin need make sure the NUMA"},{"line_number":37,"context_line":"  topology is what it\u0027s supposed to be, and is correctly mapped onto Host."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* The end user could have all of above abilities if admin alows them by change"},{"line_number":40,"context_line":"  policy rule."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_bc0be0d3","line":39,"range":{"start_line":39,"start_character":58,"end_line":39,"end_character":63},"in_reply_to":"bfb3d3c7_65f15d6b","updated":"2019-05-29 07:25:21.000000000","message":"Done","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"198a9d6c8a94a52925d573e5b1dc82201f373a34","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  instances for the purpose of debugging, and admin need make sure the NUMA"},{"line_number":37,"context_line":"  topology is what it\u0027s supposed to be, and is correctly mapped onto Host."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* The end user could have all of above abilities if admin alows them by change"},{"line_number":40,"context_line":"  policy rule."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_dcffb4a8","line":39,"range":{"start_line":39,"start_character":72,"end_line":39,"end_character":78},"in_reply_to":"bfb3d3c7_85f6d162","updated":"2019-05-29 07:25:21.000000000","message":"Done","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"611a1d25651d1047db45ab1ae608417b6434e16d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  topology is what it\u0027s supposed to be, and is correctly mapped onto Host."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* The end user could have all of above abilities if admin alows them by change"},{"line_number":40,"context_line":"  policy rule."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_a5faf53f","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":13},"updated":"2019-05-28 14:24:19.000000000","message":"the default policy rules.","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"198a9d6c8a94a52925d573e5b1dc82201f373a34","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  topology is what it\u0027s supposed to be, and is correctly mapped onto Host."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* The end user could have all of above abilities if admin alows them by change"},{"line_number":40,"context_line":"  policy rule."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_5c25045b","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":13},"in_reply_to":"bfb3d3c7_a5faf53f","updated":"2019-05-29 07:25:21.000000000","message":"Done","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"611a1d25651d1047db45ab1ae608417b6434e16d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Proposed change"},{"line_number":44,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"In nova, NUMA topology contains group of related properties, like the amount"},{"line_number":47,"context_line":"of memory managed by a NUMA cell, the vCPU thread to logical host processor"},{"line_number":48,"context_line":"mapping. This spec proposes an API to present NUMA information, the cpu"},{"line_number":49,"context_line":"topology, page sizes."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_a57d15b3","line":46,"range":{"start_line":46,"start_character":32,"end_line":46,"end_character":37},"updated":"2019-05-28 14:24:19.000000000","message":"groups","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"611a1d25651d1047db45ab1ae608417b6434e16d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Proposed change"},{"line_number":44,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"In nova, NUMA topology contains group of related properties, like the amount"},{"line_number":47,"context_line":"of memory managed by a NUMA cell, the vCPU thread to logical host processor"},{"line_number":48,"context_line":"mapping. This spec proposes an API to present NUMA information, the cpu"},{"line_number":49,"context_line":"topology, page sizes."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_e5778dd3","line":46,"range":{"start_line":46,"start_character":9,"end_line":46,"end_character":22},"updated":"2019-05-28 14:24:19.000000000","message":"the InstanceNUMATopology object","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"198a9d6c8a94a52925d573e5b1dc82201f373a34","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Proposed change"},{"line_number":44,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"In nova, NUMA topology contains group of related properties, like the amount"},{"line_number":47,"context_line":"of memory managed by a NUMA cell, the vCPU thread to logical host processor"},{"line_number":48,"context_line":"mapping. This spec proposes an API to present NUMA information, the cpu"},{"line_number":49,"context_line":"topology, page sizes."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_1c230c58","line":46,"range":{"start_line":46,"start_character":32,"end_line":46,"end_character":37},"in_reply_to":"bfb3d3c7_a57d15b3","updated":"2019-05-29 07:25:21.000000000","message":"Done","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"198a9d6c8a94a52925d573e5b1dc82201f373a34","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Proposed change"},{"line_number":44,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"In nova, NUMA topology contains group of related properties, like the amount"},{"line_number":47,"context_line":"of memory managed by a NUMA cell, the vCPU thread to logical host processor"},{"line_number":48,"context_line":"mapping. This spec proposes an API to present NUMA information, the cpu"},{"line_number":49,"context_line":"topology, page sizes."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_9cd4dc21","line":46,"range":{"start_line":46,"start_character":9,"end_line":46,"end_character":22},"in_reply_to":"bfb3d3c7_e5778dd3","updated":"2019-05-29 07:25:21.000000000","message":"Done","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"611a1d25651d1047db45ab1ae608417b6434e16d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"In nova, NUMA topology contains group of related properties, like the amount"},{"line_number":47,"context_line":"of memory managed by a NUMA cell, the vCPU thread to logical host processor"},{"line_number":48,"context_line":"mapping. This spec proposes an API to present NUMA information, the cpu"},{"line_number":49,"context_line":"topology, page sizes."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_e560ed03","line":47,"range":{"start_line":47,"start_character":32,"end_line":47,"end_character":34},"updated":"2019-05-28 14:24:19.000000000","message":"and","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"198a9d6c8a94a52925d573e5b1dc82201f373a34","unresolved":false,"context_lines":[{"line_number":44,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"In nova, NUMA topology contains group of related properties, like the amount"},{"line_number":47,"context_line":"of memory managed by a NUMA cell, the vCPU thread to logical host processor"},{"line_number":48,"context_line":"mapping. This spec proposes an API to present NUMA information, the cpu"},{"line_number":49,"context_line":"topology, page sizes."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_5cdae44a","line":47,"range":{"start_line":47,"start_character":32,"end_line":47,"end_character":34},"in_reply_to":"bfb3d3c7_e560ed03","updated":"2019-05-29 07:25:21.000000000","message":"Done","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"611a1d25651d1047db45ab1ae608417b6434e16d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"In nova, NUMA topology contains group of related properties, like the amount"},{"line_number":47,"context_line":"of memory managed by a NUMA cell, the vCPU thread to logical host processor"},{"line_number":48,"context_line":"mapping. This spec proposes an API to present NUMA information, the cpu"},{"line_number":49,"context_line":"topology, page sizes."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"This spec proposes a new sub-resource \u0027topology\u0027 to servers API:"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_a52bd592","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":21},"updated":"2019-05-28 14:24:19.000000000","message":"and memory page size.","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"198a9d6c8a94a52925d573e5b1dc82201f373a34","unresolved":false,"context_lines":[{"line_number":46,"context_line":"In nova, NUMA topology contains group of related properties, like the amount"},{"line_number":47,"context_line":"of memory managed by a NUMA cell, the vCPU thread to logical host processor"},{"line_number":48,"context_line":"mapping. This spec proposes an API to present NUMA information, the cpu"},{"line_number":49,"context_line":"topology, page sizes."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"This spec proposes a new sub-resource \u0027topology\u0027 to servers API:"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_1ce8ecdf","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":21},"in_reply_to":"bfb3d3c7_a52bd592","updated":"2019-05-29 07:25:21.000000000","message":"Done","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"611a1d25651d1047db45ab1ae608417b6434e16d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"This API is admin only by default, it could be exposed to users/roles by"},{"line_number":56,"context_line":"changing the default policy rule."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"API returns each cell\u0027s information belonging to one server, including"},{"line_number":59,"context_line":"mem, cpuset, siblings, CPU pinning, host NUMA node number and cpu topology,"},{"line_number":60,"context_line":"page size."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_2006f31d","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":3},"updated":"2019-05-28 14:24:19.000000000","message":"The topology API","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"611a1d25651d1047db45ab1ae608417b6434e16d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"This API is admin only by default, it could be exposed to users/roles by"},{"line_number":56,"context_line":"changing the default policy rule."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"API returns each cell\u0027s information belonging to one server, including"},{"line_number":59,"context_line":"mem, cpuset, siblings, CPU pinning, host NUMA node number and cpu topology,"},{"line_number":60,"context_line":"page size."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_60294b88","line":58,"range":{"start_line":58,"start_character":12,"end_line":58,"end_character":52},"updated":"2019-05-28 14:24:19.000000000","message":"the numa cell infomation for a","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"198a9d6c8a94a52925d573e5b1dc82201f373a34","unresolved":false,"context_lines":[{"line_number":55,"context_line":"This API is admin only by default, it could be exposed to users/roles by"},{"line_number":56,"context_line":"changing the default policy rule."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"API returns each cell\u0027s information belonging to one server, including"},{"line_number":59,"context_line":"mem, cpuset, siblings, CPU pinning, host NUMA node number and cpu topology,"},{"line_number":60,"context_line":"page size."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_3ce5b009","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":3},"in_reply_to":"bfb3d3c7_2006f31d","updated":"2019-05-29 07:25:21.000000000","message":"Done","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"198a9d6c8a94a52925d573e5b1dc82201f373a34","unresolved":false,"context_lines":[{"line_number":55,"context_line":"This API is admin only by default, it could be exposed to users/roles by"},{"line_number":56,"context_line":"changing the default policy rule."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"API returns each cell\u0027s information belonging to one server, including"},{"line_number":59,"context_line":"mem, cpuset, siblings, CPU pinning, host NUMA node number and cpu topology,"},{"line_number":60,"context_line":"page size."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_dcc6d468","line":58,"range":{"start_line":58,"start_character":12,"end_line":58,"end_character":52},"in_reply_to":"bfb3d3c7_60294b88","updated":"2019-05-29 07:25:21.000000000","message":"Done","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"611a1d25651d1047db45ab1ae608417b6434e16d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"changing the default policy rule."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"API returns each cell\u0027s information belonging to one server, including"},{"line_number":59,"context_line":"mem, cpuset, siblings, CPU pinning, host NUMA node number and cpu topology,"},{"line_number":60,"context_line":"page size."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"If there is no NUMA information available, the corresponding key\u0027s value"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_604e2b70","line":59,"range":{"start_line":59,"start_character":58,"end_line":59,"end_character":61},"updated":"2019-05-28 14:24:19.000000000","message":",","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"611a1d25651d1047db45ab1ae608417b6434e16d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"changing the default policy rule."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"API returns each cell\u0027s information belonging to one server, including"},{"line_number":59,"context_line":"mem, cpuset, siblings, CPU pinning, host NUMA node number and cpu topology,"},{"line_number":60,"context_line":"page size."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"If there is no NUMA information available, the corresponding key\u0027s value"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_e041bb3a","line":59,"range":{"start_line":59,"start_character":74,"end_line":59,"end_character":75},"updated":"2019-05-28 14:24:19.000000000","message":"and the","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"611a1d25651d1047db45ab1ae608417b6434e16d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"changing the default policy rule."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"API returns each cell\u0027s information belonging to one server, including"},{"line_number":59,"context_line":"mem, cpuset, siblings, CPU pinning, host NUMA node number and cpu topology,"},{"line_number":60,"context_line":"page size."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"If there is no NUMA information available, the corresponding key\u0027s value"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_402447af","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":3},"updated":"2019-05-28 14:24:19.000000000","message":"the memory","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"198a9d6c8a94a52925d573e5b1dc82201f373a34","unresolved":false,"context_lines":[{"line_number":56,"context_line":"changing the default policy rule."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"API returns each cell\u0027s information belonging to one server, including"},{"line_number":59,"context_line":"mem, cpuset, siblings, CPU pinning, host NUMA node number and cpu topology,"},{"line_number":60,"context_line":"page size."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"If there is no NUMA information available, the corresponding key\u0027s value"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_fcc39855","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":3},"in_reply_to":"bfb3d3c7_402447af","updated":"2019-05-29 07:25:21.000000000","message":"Done","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"198a9d6c8a94a52925d573e5b1dc82201f373a34","unresolved":false,"context_lines":[{"line_number":56,"context_line":"changing the default policy rule."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"API returns each cell\u0027s information belonging to one server, including"},{"line_number":59,"context_line":"mem, cpuset, siblings, CPU pinning, host NUMA node number and cpu topology,"},{"line_number":60,"context_line":"page size."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"If there is no NUMA information available, the corresponding key\u0027s value"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_5ca8a48a","line":59,"range":{"start_line":59,"start_character":58,"end_line":59,"end_character":61},"in_reply_to":"bfb3d3c7_604e2b70","updated":"2019-05-29 07:25:21.000000000","message":"Done","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"198a9d6c8a94a52925d573e5b1dc82201f373a34","unresolved":false,"context_lines":[{"line_number":56,"context_line":"changing the default policy rule."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"API returns each cell\u0027s information belonging to one server, including"},{"line_number":59,"context_line":"mem, cpuset, siblings, CPU pinning, host NUMA node number and cpu topology,"},{"line_number":60,"context_line":"page size."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"If there is no NUMA information available, the corresponding key\u0027s value"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_7cad6899","line":59,"range":{"start_line":59,"start_character":74,"end_line":59,"end_character":75},"in_reply_to":"bfb3d3c7_e041bb3a","updated":"2019-05-29 07:25:21.000000000","message":"Done","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"9027ed3f42566322ab45f7ccbdfd1c96bc55e7dd","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"                      # control by policy TOPOLOGY % \u0027index:host_info\u0027"},{"line_number":105,"context_line":"                      # 0:5 means vcpu 0 pinning to pcpu 5"},{"line_number":106,"context_line":"                      \"cpu_pinning\": {0:5, 1:6},"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"                      \"vcpu_set\": [0,1,2,3],"},{"line_number":109,"context_line":"                      \"siblings\": [[0,1],[2,3]],"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_afdf1d67","line":106,"range":{"start_line":106,"start_character":22,"end_line":106,"end_character":48},"updated":"2019-05-29 14:57:00.000000000","message":"For this to be consistent with the vcpu_set below, the cpu_pinning would have all entries, eg, \"cpu_pinning\": {0:5, 1:6, 2:7, 3:8},","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"7d72f818733df154e06f4964aea50b01d999af9b","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"                      # control by policy TOPOLOGY % \u0027index:host_info\u0027"},{"line_number":105,"context_line":"                      # 0:5 means vcpu 0 pinning to pcpu 5"},{"line_number":106,"context_line":"                      \"cpu_pinning\": {0:5, 1:6},"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"                      \"vcpu_set\": [0,1,2,3],"},{"line_number":109,"context_line":"                      \"siblings\": [[0,1],[2,3]],"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_4622e7ba","line":106,"range":{"start_line":106,"start_character":22,"end_line":106,"end_character":48},"in_reply_to":"bfb3d3c7_afdf1d67","updated":"2019-05-31 02:50:17.000000000","message":"Done","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3b334464092b010253311748b95bef8668bb8da4","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                # control host numa node and cpu pin information"},{"line_number":153,"context_line":"                TOPOLOGY % \u0027index:host_info\u0027,"},{"line_number":154,"context_line":"                base.RULE_ADMIN_API,"},{"line_number":155,"context_line":"                \"List all servers with detailed information\","},{"line_number":156,"context_line":"                ["},{"line_number":157,"context_line":"                    {"},{"line_number":158,"context_line":"                        \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_801a3fc9","line":155,"range":{"start_line":155,"start_character":16,"end_line":155,"end_character":61},"updated":"2019-05-28 14:36:37.000000000","message":"nit: Show the host specific topology data for a server","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"198a9d6c8a94a52925d573e5b1dc82201f373a34","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                # control host numa node and cpu pin information"},{"line_number":153,"context_line":"                TOPOLOGY % \u0027index:host_info\u0027,"},{"line_number":154,"context_line":"                base.RULE_ADMIN_API,"},{"line_number":155,"context_line":"                \"List all servers with detailed information\","},{"line_number":156,"context_line":"                ["},{"line_number":157,"context_line":"                    {"},{"line_number":158,"context_line":"                        \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_bc90c04b","line":155,"range":{"start_line":155,"start_character":16,"end_line":155,"end_character":61},"in_reply_to":"bfb3d3c7_801a3fc9","updated":"2019-05-29 07:25:21.000000000","message":"Done","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"388b9c225a441e569ffb6a2a2044b6f6e5ffbcba","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                        \u0027path\u0027: \u0027/servers/{server_id}/topology\u0027"},{"line_number":149,"context_line":"                    }"},{"line_number":150,"context_line":"            ]),"},{"line_number":151,"context_line":"            policy.DocumentedRuleDefault("},{"line_number":152,"context_line":"                # control host numa node and cpu pin information"},{"line_number":153,"context_line":"                TOPOLOGY % \u0027index:host_info\u0027,"},{"line_number":154,"context_line":"                base.RULE_ADMIN_API,"},{"line_number":155,"context_line":"                \"List all servers with detailed information\","},{"line_number":156,"context_line":"                ["},{"line_number":157,"context_line":"                    {"},{"line_number":158,"context_line":"                        \u0027method\u0027: \u0027GET\u0027,"},{"line_number":159,"context_line":"                        \u0027path\u0027: \u0027/servers/{server_id}/topology\u0027"},{"line_number":160,"context_line":"                    }"},{"line_number":161,"context_line":"            ]),"},{"line_number":162,"context_line":"    ]"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_c0983776","line":161,"range":{"start_line":151,"start_character":12,"end_line":161,"end_character":15},"updated":"2019-05-28 14:32:01.000000000","message":"note the intent of this is to allow  you to expose the main info to non admins by changing the default toplogy rule above to admin_or_owner and override the host specific sections with an admin only rule.\n\nthis however has not been updated to reflect changes in the data model so you should update this state that it will apply to the siblings, vcpu_set and host_numa_node fields\n\nprovided those three feilds are admin only by default the rest could be admin_or_owner by default.\n\ngive that this should be updated and the other typos im goignt o chagne my review to a -1 but i think overall this spec is ok.","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4affe61cb510e4f706cb676471da1f90f4e52571","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                        \u0027path\u0027: \u0027/servers/{server_id}/topology\u0027"},{"line_number":149,"context_line":"                    }"},{"line_number":150,"context_line":"            ]),"},{"line_number":151,"context_line":"            policy.DocumentedRuleDefault("},{"line_number":152,"context_line":"                # control host numa node and cpu pin information"},{"line_number":153,"context_line":"                TOPOLOGY % \u0027index:host_info\u0027,"},{"line_number":154,"context_line":"                base.RULE_ADMIN_API,"},{"line_number":155,"context_line":"                \"List all servers with detailed information\","},{"line_number":156,"context_line":"                ["},{"line_number":157,"context_line":"                    {"},{"line_number":158,"context_line":"                        \u0027method\u0027: \u0027GET\u0027,"},{"line_number":159,"context_line":"                        \u0027path\u0027: \u0027/servers/{server_id}/topology\u0027"},{"line_number":160,"context_line":"                    }"},{"line_number":161,"context_line":"            ]),"},{"line_number":162,"context_line":"    ]"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fb8cfa7_761e750d","line":161,"range":{"start_line":151,"start_character":12,"end_line":161,"end_character":15},"in_reply_to":"bfb3d3c7_9cde1c0f","updated":"2019-06-04 13:11:45.000000000","message":"sorry vcpu_set should have been cpu_pinning.","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"198a9d6c8a94a52925d573e5b1dc82201f373a34","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                        \u0027path\u0027: \u0027/servers/{server_id}/topology\u0027"},{"line_number":149,"context_line":"                    }"},{"line_number":150,"context_line":"            ]),"},{"line_number":151,"context_line":"            policy.DocumentedRuleDefault("},{"line_number":152,"context_line":"                # control host numa node and cpu pin information"},{"line_number":153,"context_line":"                TOPOLOGY % \u0027index:host_info\u0027,"},{"line_number":154,"context_line":"                base.RULE_ADMIN_API,"},{"line_number":155,"context_line":"                \"List all servers with detailed information\","},{"line_number":156,"context_line":"                ["},{"line_number":157,"context_line":"                    {"},{"line_number":158,"context_line":"                        \u0027method\u0027: \u0027GET\u0027,"},{"line_number":159,"context_line":"                        \u0027path\u0027: \u0027/servers/{server_id}/topology\u0027"},{"line_number":160,"context_line":"                    }"},{"line_number":161,"context_line":"            ]),"},{"line_number":162,"context_line":"    ]"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_9cde1c0f","line":161,"range":{"start_line":151,"start_character":12,"end_line":161,"end_character":15},"in_reply_to":"bfb3d3c7_c0983776","updated":"2019-05-29 07:25:21.000000000","message":"vcpu_set is admin only? \nI think this is vcpu number inside a server fix me. (or is it a host pcpu number?)","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"611a1d25651d1047db45ab1ae608417b6434e16d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"Other end user impact"},{"line_number":171,"context_line":"---------------------"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"* python novaclient and python-openstackclient would display numa_topology"},{"line_number":174,"context_line":"  information."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_6085cb59","line":173,"range":{"start_line":173,"start_character":46,"end_line":173,"end_character":52},"updated":"2019-05-28 14:24:19.000000000","message":"should be extended to","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"198a9d6c8a94a52925d573e5b1dc82201f373a34","unresolved":false,"context_lines":[{"line_number":170,"context_line":"Other end user impact"},{"line_number":171,"context_line":"---------------------"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"* python novaclient and python-openstackclient would display numa_topology"},{"line_number":174,"context_line":"  information."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_7ce9e8b4","line":173,"range":{"start_line":173,"start_character":46,"end_line":173,"end_character":52},"in_reply_to":"bfb3d3c7_6085cb59","updated":"2019-05-29 07:25:21.000000000","message":"Done","commit_id":"ec665caf0d2c0ed5dc9f9df9b65b45454e555280"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"6b8b12a9e2b679dbfe67d809219573b8c40832e7","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                      # 0:5 means vcpu 0 pinning to pcpu 5"},{"line_number":107,"context_line":"                      \"cpu_pinning\": {0:5, 1:6, 2:3, 3:8},"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"                      # control by policy TOPOLOGY % \u0027index:host_info\u0027"},{"line_number":110,"context_line":"                      \"vcpu_set\": [0,1,2,3],"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"                      # control by policy TOPOLOGY % \u0027index:host_info\u0027"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fb8cfa7_d809a295","line":109,"range":{"start_line":109,"start_character":22,"end_line":109,"end_character":70},"updated":"2019-06-18 07:41:08.000000000","message":"this isn\u0027t controled by the host_info policy","commit_id":"c1b86fa62c3011330785599c387ad276f8df5235"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"65ce1ca9ef58b017ed272cd704128eeea87bf588","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                      # 0:5 means vcpu 0 pinning to pcpu 5"},{"line_number":107,"context_line":"                      \"cpu_pinning\": {0:5, 1:6, 2:3, 3:8},"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"                      # control by policy TOPOLOGY % \u0027index:host_info\u0027"},{"line_number":110,"context_line":"                      \"vcpu_set\": [0,1,2,3],"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"                      # control by policy TOPOLOGY % \u0027index:host_info\u0027"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fb8cfa7_9886cadb","line":109,"range":{"start_line":109,"start_character":22,"end_line":109,"end_character":70},"in_reply_to":"9fb8cfa7_d809a295","updated":"2019-06-18 07:46:13.000000000","message":"Done","commit_id":"c1b86fa62c3011330785599c387ad276f8df5235"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"6b8b12a9e2b679dbfe67d809219573b8c40832e7","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                      # control by policy TOPOLOGY % \u0027index:host_info\u0027"},{"line_number":110,"context_line":"                      \"vcpu_set\": [0,1,2,3],"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"                      # control by policy TOPOLOGY % \u0027index:host_info\u0027"},{"line_number":113,"context_line":"                      \"siblings\": [[0,1],[2,3]],"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"                      \"memory_mb\": 1024,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fb8cfa7_78fe766c","line":112,"range":{"start_line":112,"start_character":21,"end_line":112,"end_character":70},"updated":"2019-06-18 07:41:08.000000000","message":"this is also","commit_id":"c1b86fa62c3011330785599c387ad276f8df5235"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"65ce1ca9ef58b017ed272cd704128eeea87bf588","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                      # control by policy TOPOLOGY % \u0027index:host_info\u0027"},{"line_number":110,"context_line":"                      \"vcpu_set\": [0,1,2,3],"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"                      # control by policy TOPOLOGY % \u0027index:host_info\u0027"},{"line_number":113,"context_line":"                      \"siblings\": [[0,1],[2,3]],"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"                      \"memory_mb\": 1024,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fb8cfa7_58685220","line":112,"range":{"start_line":112,"start_character":21,"end_line":112,"end_character":70},"in_reply_to":"9fb8cfa7_78fe766c","updated":"2019-06-18 07:46:13.000000000","message":"Done","commit_id":"c1b86fa62c3011330785599c387ad276f8df5235"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7e71b94fbfde6c87c6f17354a47d586c46634835","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                            \"threads\":2"},{"line_number":126,"context_line":"                        }"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        \"pagesize_kb\": 4096,"},{"line_number":129,"context_line":"    }"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fb8cfa7_67ad4530","line":128,"range":{"start_line":128,"start_character":23,"end_line":128,"end_character":27},"updated":"2019-06-05 19:20:11.000000000","message":"nit this would be a 4MB page\n\ni think was was ment to be just 4 or 2048 for a 2m hugepage","commit_id":"c1b86fa62c3011330785599c387ad276f8df5235"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"6b8b12a9e2b679dbfe67d809219573b8c40832e7","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                            \"threads\":2"},{"line_number":126,"context_line":"                        }"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        \"pagesize_kb\": 4096,"},{"line_number":129,"context_line":"    }"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fb8cfa7_5879322d","line":128,"range":{"start_line":128,"start_character":23,"end_line":128,"end_character":27},"in_reply_to":"9fb8cfa7_67ad4530","updated":"2019-06-18 07:41:08.000000000","message":"the field name includes the unit. so that is why it is 4096","commit_id":"c1b86fa62c3011330785599c387ad276f8df5235"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d151bef1fd2aeaefffe77d37321c8488cc3209e3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  guest VM."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* The admin wants a unified way to get topology information, independent of"},{"line_number":33,"context_line":"  how the various gest OSes expose it."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* The admin wants to know the virtual-to-physical mapping for one or more"},{"line_number":36,"context_line":"  instances for the purpose of debugging, and admin need make sure the NUMA"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_ac98bdbf","line":33,"range":{"start_line":33,"start_character":18,"end_line":33,"end_character":22},"updated":"2019-06-25 13:58:30.000000000","message":"guest","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"3db430a9765758cd1eaf9457b3cf8aa6bc00e359","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  guest VM."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* The admin wants a unified way to get topology information, independent of"},{"line_number":33,"context_line":"  how the various gest OSes expose it."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* The admin wants to know the virtual-to-physical mapping for one or more"},{"line_number":36,"context_line":"  instances for the purpose of debugging, and admin need make sure the NUMA"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_2685c1cf","line":33,"range":{"start_line":33,"start_character":18,"end_line":33,"end_character":22},"in_reply_to":"9fb8cfa7_ac98bdbf","updated":"2019-06-26 01:55:12.000000000","message":"Done","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d151bef1fd2aeaefffe77d37321c8488cc3209e3","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  how the various gest OSes expose it."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* The admin wants to know the virtual-to-physical mapping for one or more"},{"line_number":36,"context_line":"  instances for the purpose of debugging, and admin need make sure the NUMA"},{"line_number":37,"context_line":"  topology is what it\u0027s supposed to be, and is correctly mapped onto Host."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* The end user could have all of above abilities if admin allows them by"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_cc95f188","line":36,"range":{"start_line":36,"start_character":52,"end_line":36,"end_character":56},"updated":"2019-06-25 13:58:30.000000000","message":"needs to","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"3db430a9765758cd1eaf9457b3cf8aa6bc00e359","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  how the various gest OSes expose it."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* The admin wants to know the virtual-to-physical mapping for one or more"},{"line_number":36,"context_line":"  instances for the purpose of debugging, and admin need make sure the NUMA"},{"line_number":37,"context_line":"  topology is what it\u0027s supposed to be, and is correctly mapped onto Host."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* The end user could have all of above abilities if admin allows them by"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_c66dc532","line":36,"range":{"start_line":36,"start_character":52,"end_line":36,"end_character":56},"in_reply_to":"9fb8cfa7_cc95f188","updated":"2019-06-26 01:55:12.000000000","message":"Done","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d151bef1fd2aeaefffe77d37321c8488cc3209e3","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* The admin wants to know the virtual-to-physical mapping for one or more"},{"line_number":36,"context_line":"  instances for the purpose of debugging, and admin need make sure the NUMA"},{"line_number":37,"context_line":"  topology is what it\u0027s supposed to be, and is correctly mapped onto Host."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* The end user could have all of above abilities if admin allows them by"},{"line_number":40,"context_line":"  changing the default policy rules."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_8c8b7966","line":37,"range":{"start_line":37,"start_character":64,"end_line":37,"end_character":73},"updated":"2019-06-25 13:58:30.000000000","message":"onto the host","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"3db430a9765758cd1eaf9457b3cf8aa6bc00e359","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* The admin wants to know the virtual-to-physical mapping for one or more"},{"line_number":36,"context_line":"  instances for the purpose of debugging, and admin need make sure the NUMA"},{"line_number":37,"context_line":"  topology is what it\u0027s supposed to be, and is correctly mapped onto Host."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* The end user could have all of above abilities if admin allows them by"},{"line_number":40,"context_line":"  changing the default policy rules."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_e66a4918","line":37,"range":{"start_line":37,"start_character":64,"end_line":37,"end_character":73},"in_reply_to":"9fb8cfa7_8c8b7966","updated":"2019-06-26 01:55:12.000000000","message":"Done","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d151bef1fd2aeaefffe77d37321c8488cc3209e3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  instances for the purpose of debugging, and admin need make sure the NUMA"},{"line_number":37,"context_line":"  topology is what it\u0027s supposed to be, and is correctly mapped onto Host."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* The end user could have all of above abilities if admin allows them by"},{"line_number":40,"context_line":"  changing the default policy rules."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_ccdad176","line":39,"range":{"start_line":39,"start_character":30,"end_line":39,"end_character":32},"updated":"2019-06-25 13:58:30.000000000","message":"of the","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"3db430a9765758cd1eaf9457b3cf8aa6bc00e359","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  instances for the purpose of debugging, and admin need make sure the NUMA"},{"line_number":37,"context_line":"  topology is what it\u0027s supposed to be, and is correctly mapped onto Host."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* The end user could have all of above abilities if admin allows them by"},{"line_number":40,"context_line":"  changing the default policy rules."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_0680bdbe","line":39,"range":{"start_line":39,"start_character":30,"end_line":39,"end_character":32},"in_reply_to":"9fb8cfa7_ccdad176","updated":"2019-06-26 01:55:12.000000000","message":"Done","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d151bef1fd2aeaefffe77d37321c8488cc3209e3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Proposed change"},{"line_number":44,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"In nova, the instanceNUMATopology object contains groups of related"},{"line_number":47,"context_line":"properties, like the amount of memory managed by a NUMA cell and the"},{"line_number":48,"context_line":"vCPU thread to logical host processor mapping. This spec proposes"},{"line_number":49,"context_line":"an API to present NUMA information, the cpu topology and memory page"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_8ce05928","line":46,"range":{"start_line":46,"start_character":13,"end_line":46,"end_character":33},"updated":"2019-06-25 13:58:30.000000000","message":"InstanceNUMATopology","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"3db430a9765758cd1eaf9457b3cf8aa6bc00e359","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Proposed change"},{"line_number":44,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"In nova, the instanceNUMATopology object contains groups of related"},{"line_number":47,"context_line":"properties, like the amount of memory managed by a NUMA cell and the"},{"line_number":48,"context_line":"vCPU thread to logical host processor mapping. This spec proposes"},{"line_number":49,"context_line":"an API to present NUMA information, the cpu topology and memory page"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_667f39e0","line":46,"range":{"start_line":46,"start_character":13,"end_line":46,"end_character":33},"in_reply_to":"9fb8cfa7_8ce05928","updated":"2019-06-26 01:55:12.000000000","message":"Done","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d151bef1fd2aeaefffe77d37321c8488cc3209e3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"This API is admin only by default, it could be exposed to users/roles by"},{"line_number":57,"context_line":"changing the default policy rule."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"The topology API returns the numa cell information for a server, including"},{"line_number":60,"context_line":"the memory, cpuset, siblings, CPU pinning, host NUMA node number, cpu"},{"line_number":61,"context_line":"topology and page size."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_2c384d9e","line":59,"range":{"start_line":59,"start_character":29,"end_line":59,"end_character":33},"updated":"2019-06-25 13:58:30.000000000","message":"NUMA","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"3db430a9765758cd1eaf9457b3cf8aa6bc00e359","unresolved":false,"context_lines":[{"line_number":56,"context_line":"This API is admin only by default, it could be exposed to users/roles by"},{"line_number":57,"context_line":"changing the default policy rule."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"The topology API returns the numa cell information for a server, including"},{"line_number":60,"context_line":"the memory, cpuset, siblings, CPU pinning, host NUMA node number, cpu"},{"line_number":61,"context_line":"topology and page size."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_86734d16","line":59,"range":{"start_line":59,"start_character":29,"end_line":59,"end_character":33},"in_reply_to":"9fb8cfa7_2c384d9e","updated":"2019-06-26 01:55:12.000000000","message":"Done","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d151bef1fd2aeaefffe77d37321c8488cc3209e3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Alternatives"},{"line_number":67,"context_line":"------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Instead of put these information into ``GET /servers/{server_id}/topology``,"},{"line_number":70,"context_line":"there are other 2 options:"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* add NUMA information into existed sub-resource ``diagnostics``:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_6c5165d9","line":69,"range":{"start_line":69,"start_character":11,"end_line":69,"end_character":14},"updated":"2019-06-25 13:58:30.000000000","message":"putting","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"3db430a9765758cd1eaf9457b3cf8aa6bc00e359","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Alternatives"},{"line_number":67,"context_line":"------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Instead of put these information into ``GET /servers/{server_id}/topology``,"},{"line_number":70,"context_line":"there are other 2 options:"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* add NUMA information into existed sub-resource ``diagnostics``:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_467a35f1","line":69,"range":{"start_line":69,"start_character":11,"end_line":69,"end_character":14},"in_reply_to":"9fb8cfa7_6c5165d9","updated":"2019-06-26 01:55:12.000000000","message":"Done","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d151bef1fd2aeaefffe77d37321c8488cc3209e3","unresolved":false,"context_lines":[{"line_number":67,"context_line":"------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Instead of put these information into ``GET /servers/{server_id}/topology``,"},{"line_number":70,"context_line":"there are other 2 options:"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* add NUMA information into existed sub-resource ``diagnostics``:"},{"line_number":73,"context_line":"  ``GET /servers/{server_id}/diagnostics``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_8c4e1936","line":70,"range":{"start_line":70,"start_character":10,"end_line":70,"end_character":17},"updated":"2019-06-25 13:58:30.000000000","message":"two other","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"3db430a9765758cd1eaf9457b3cf8aa6bc00e359","unresolved":false,"context_lines":[{"line_number":67,"context_line":"------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Instead of put these information into ``GET /servers/{server_id}/topology``,"},{"line_number":70,"context_line":"there are other 2 options:"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* add NUMA information into existed sub-resource ``diagnostics``:"},{"line_number":73,"context_line":"  ``GET /servers/{server_id}/diagnostics``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_a61bf1c7","line":70,"range":{"start_line":70,"start_character":10,"end_line":70,"end_character":17},"in_reply_to":"9fb8cfa7_8c4e1936","updated":"2019-06-26 01:55:12.000000000","message":"Done","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d151bef1fd2aeaefffe77d37321c8488cc3209e3","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Instead of put these information into ``GET /servers/{server_id}/topology``,"},{"line_number":70,"context_line":"there are other 2 options:"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* add NUMA information into existed sub-resource ``diagnostics``:"},{"line_number":73,"context_line":"  ``GET /servers/{server_id}/diagnostics``"},{"line_number":74,"context_line":"  returns the NUMA information for one server. As NUMA toplogy does not change"},{"line_number":75,"context_line":"  for given server, it\u0027s better put under new ``topology`` sub-resource."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_2c612daa","line":72,"range":{"start_line":72,"start_character":28,"end_line":72,"end_character":35},"updated":"2019-06-25 13:58:30.000000000","message":"the existing","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"3db430a9765758cd1eaf9457b3cf8aa6bc00e359","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Instead of put these information into ``GET /servers/{server_id}/topology``,"},{"line_number":70,"context_line":"there are other 2 options:"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* add NUMA information into existed sub-resource ``diagnostics``:"},{"line_number":73,"context_line":"  ``GET /servers/{server_id}/diagnostics``"},{"line_number":74,"context_line":"  returns the NUMA information for one server. As NUMA toplogy does not change"},{"line_number":75,"context_line":"  for given server, it\u0027s better put under new ``topology`` sub-resource."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_861eedb8","line":72,"range":{"start_line":72,"start_character":28,"end_line":72,"end_character":35},"in_reply_to":"9fb8cfa7_2c612daa","updated":"2019-06-26 01:55:12.000000000","message":"Done","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e4a08eb451a1d762e4d522625946e20d254ecaee","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                            \"threads\":2"},{"line_number":123,"context_line":"                        }"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        \"pagesize_kb\": 4096,"},{"line_number":126,"context_line":"    }"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_8cb29948","line":125,"range":{"start_line":125,"start_character":6,"end_line":125,"end_character":28},"updated":"2019-06-25 13:44:08.000000000","message":"nit this is still technically a 4MB pagesize but its only an example and as you said the unit is in the field name  so it fine.","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"3db430a9765758cd1eaf9457b3cf8aa6bc00e359","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                            \"threads\":2"},{"line_number":123,"context_line":"                        }"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        \"pagesize_kb\": 4096,"},{"line_number":126,"context_line":"    }"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_661ad9cc","line":125,"range":{"start_line":125,"start_character":6,"end_line":125,"end_character":28},"in_reply_to":"9fb8cfa7_8cb29948","updated":"2019-06-26 01:55:12.000000000","message":"Done","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d151bef1fd2aeaefffe77d37321c8488cc3209e3","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                            \"threads\":2"},{"line_number":123,"context_line":"                        }"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        \"pagesize_kb\": 4096,"},{"line_number":126,"context_line":"    }"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_ecd9d555","line":125,"range":{"start_line":125,"start_character":6,"end_line":125,"end_character":28},"in_reply_to":"9fb8cfa7_8cb29948","updated":"2019-06-25 13:58:30.000000000","message":"Since 4K is so common, I think it\u0027s worth fixing this in a followup so that people don\u0027t blindly copy this, thinking 4K.","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"3db430a9765758cd1eaf9457b3cf8aa6bc00e359","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                            \"threads\":2"},{"line_number":123,"context_line":"                        }"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        \"pagesize_kb\": 4096,"},{"line_number":126,"context_line":"    }"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_4615559b","line":125,"range":{"start_line":125,"start_character":6,"end_line":125,"end_character":28},"in_reply_to":"9fb8cfa7_ecd9d555","updated":"2019-06-26 01:55:12.000000000","message":"Done","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d151bef1fd2aeaefffe77d37321c8488cc3209e3","unresolved":false,"context_lines":[{"line_number":129,"context_line":"Security impact"},{"line_number":130,"context_line":"---------------"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* These information exposed by this API is admin only by default, and fine"},{"line_number":133,"context_line":"  control policy ``TOPOLOGY % \u0027index:host_info\u0027`` use to keep host only"},{"line_number":134,"context_line":"  information to admin while this API expose to end user."},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_ec0b15d2","line":132,"range":{"start_line":132,"start_character":2,"end_line":132,"end_character":7},"updated":"2019-06-25 13:58:30.000000000","message":"The","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d151bef1fd2aeaefffe77d37321c8488cc3209e3","unresolved":false,"context_lines":[{"line_number":129,"context_line":"Security impact"},{"line_number":130,"context_line":"---------------"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* These information exposed by this API is admin only by default, and fine"},{"line_number":133,"context_line":"  control policy ``TOPOLOGY % \u0027index:host_info\u0027`` use to keep host only"},{"line_number":134,"context_line":"  information to admin while this API expose to end user."},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_0c11c904","line":132,"range":{"start_line":132,"start_character":70,"end_line":132,"end_character":74},"updated":"2019-06-25 13:58:30.000000000","message":"a fine-grained","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"3db430a9765758cd1eaf9457b3cf8aa6bc00e359","unresolved":false,"context_lines":[{"line_number":129,"context_line":"Security impact"},{"line_number":130,"context_line":"---------------"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* These information exposed by this API is admin only by default, and fine"},{"line_number":133,"context_line":"  control policy ``TOPOLOGY % \u0027index:host_info\u0027`` use to keep host only"},{"line_number":134,"context_line":"  information to admin while this API expose to end user."},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_86458db6","line":132,"range":{"start_line":132,"start_character":70,"end_line":132,"end_character":74},"in_reply_to":"9fb8cfa7_0c11c904","updated":"2019-06-26 01:55:12.000000000","message":"Done","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"3db430a9765758cd1eaf9457b3cf8aa6bc00e359","unresolved":false,"context_lines":[{"line_number":129,"context_line":"Security impact"},{"line_number":130,"context_line":"---------------"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* These information exposed by this API is admin only by default, and fine"},{"line_number":133,"context_line":"  control policy ``TOPOLOGY % \u0027index:host_info\u0027`` use to keep host only"},{"line_number":134,"context_line":"  information to admin while this API expose to end user."},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_a64211aa","line":132,"range":{"start_line":132,"start_character":2,"end_line":132,"end_character":7},"in_reply_to":"9fb8cfa7_ec0b15d2","updated":"2019-06-26 01:55:12.000000000","message":"Done","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d151bef1fd2aeaefffe77d37321c8488cc3209e3","unresolved":false,"context_lines":[{"line_number":130,"context_line":"---------------"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* These information exposed by this API is admin only by default, and fine"},{"line_number":133,"context_line":"  control policy ``TOPOLOGY % \u0027index:host_info\u0027`` use to keep host only"},{"line_number":134,"context_line":"  information to admin while this API expose to end user."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* Add new ``topology`` policy, admin only by default:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_acf99dc8","line":133,"range":{"start_line":133,"start_character":50,"end_line":133,"end_character":53},"updated":"2019-06-25 13:58:30.000000000","message":"is used","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"3db430a9765758cd1eaf9457b3cf8aa6bc00e359","unresolved":false,"context_lines":[{"line_number":130,"context_line":"---------------"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* These information exposed by this API is admin only by default, and fine"},{"line_number":133,"context_line":"  control policy ``TOPOLOGY % \u0027index:host_info\u0027`` use to keep host only"},{"line_number":134,"context_line":"  information to admin while this API expose to end user."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* Add new ``topology`` policy, admin only by default:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_c62865e3","line":133,"range":{"start_line":133,"start_character":50,"end_line":133,"end_character":53},"in_reply_to":"9fb8cfa7_acf99dc8","updated":"2019-06-26 01:55:12.000000000","message":"Done","commit_id":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7"}]}