)]}'
{"id":"openstack%2Fnova-specs~658716","triplet_id":"openstack%2Fnova-specs~master~I60b16eee2f03a78382b735ccad588d0d619e7693","project":"openstack/nova-specs","branch":"master","topic":"bp/show-server-numa-topology","hashtags":[],"change_id":"I60b16eee2f03a78382b735ccad588d0d619e7693","subject":"add spec \"show-server-numa-topology\"","status":"MERGED","created":"2019-05-13 02:31:42.000000000","updated":"2019-06-26 01:55:12.000000000","submitted":"2019-06-25 14:18:20.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":70,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"658716-1561472300819-16d569af","meta_rev_id":"c62b1c81019e8e48193242752aabf006cd1a0d68","_number":658716,"virtual_id_number":658716,"owner":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-06-25 14:18:20.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":23157,"name":"sean mooney","email":"seanmooney8202@yahoo.ie","username":"seanmooney8202"},{"value":0,"date":"2019-06-24 20:06:30.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},{"value":0,"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},{"value":2,"date":"2019-06-25 13:58:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":2,"date":"2019-06-18 07:45:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},{"value":1,"date":"2019-06-25 13:44:08.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":23157,"name":"sean mooney","email":"seanmooney8202@yahoo.ie","username":"seanmooney8202"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},{"value":0,"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},{"value":1,"date":"2019-06-25 13:58:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":23157,"name":"sean mooney","email":"seanmooney8202@yahoo.ie","username":"seanmooney8202"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},{"value":0,"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":23157,"name":"sean mooney","email":"seanmooney8202@yahoo.ie","username":"seanmooney8202"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},{"value":0,"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23157,"name":"sean mooney","email":"seanmooney8202@yahoo.ie","username":"seanmooney8202"},{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-13 08:42:15.000000000","updated_by":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"reviewer":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"state":"REVIEWER"},{"updated":"2019-05-13 15:40:22.000000000","updated_by":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"reviewer":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"state":"REVIEWER"},{"updated":"2019-05-24 06:01:27.000000000","updated_by":{"_account_id":23157,"name":"sean mooney","email":"seanmooney8202@yahoo.ie","username":"seanmooney8202"},"reviewer":{"_account_id":23157,"name":"sean mooney","email":"seanmooney8202@yahoo.ie","username":"seanmooney8202"},"state":"REVIEWER"},{"updated":"2019-05-24 08:35:13.000000000","updated_by":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"reviewer":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"state":"REVIEWER"},{"updated":"2019-05-29 14:57:00.000000000","updated_by":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"reviewer":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"state":"REVIEWER"},{"updated":"2019-06-18 07:45:41.000000000","updated_by":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"reviewer":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"state":"REVIEWER"},{"updated":"2019-06-24 20:06:30.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-06-25 13:44:08.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2019-06-25 13:58:30.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2019-06-25 14:18:20.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f91624a952ca11ecf7fa84862ce784d7633d2328","author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"date":"2019-05-13 02:31:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"350f333154a10ccaf6c995a002a1f4f96ead795d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-13 02:40:52.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/16/658716/1/check/openstack-tox-docs/4e6f59c/html/ : SUCCESS in 6m 50s\n- openstack-tox-pep8 http://logs.openstack.org/16/658716/1/check/openstack-tox-pep8/12cf2d4/ : SUCCESS in 4m 09s","accounts_in_message":[],"_revision_number":1},{"id":"c4e6795e97c6273446379972f0ee9418af47dc3b","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2019-05-13 15:40:22.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nNormally we would fast track approve as this was previously approved, but given the discussion at the PTG, I will just +2.","accounts_in_message":[],"_revision_number":1},{"id":"ee59b2ae65d20e9db43afdfd79d65c3649696ea5","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2019-05-13 15:42:15.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2b125f5c07247baf0e6ed36b9d6d734c8461dde7","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2019-05-21 13:09:14.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nThanks, John. I think the cores and threads should be removed also. Hope Sean to have a look at.","accounts_in_message":[],"_revision_number":1},{"id":"e8d217e3126dc0b20ec6e0496bbbd9f141a1403d","author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"date":"2019-05-22 07:19:12.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"68b98ab694a00cfafc2017ac9437cec992e1c41b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-22 07:32:03.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/16/658716/2/check/openstack-tox-docs/61f99a1/html/ : SUCCESS in 7m 47s\n- openstack-tox-pep8 http://logs.openstack.org/16/658716/2/check/openstack-tox-pep8/c2decbe/ : SUCCESS in 4m 16s","accounts_in_message":[],"_revision_number":2},{"id":"7382a34cc98d45e2aa5b629de87a8e915a39fe1e","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2019-05-23 04:16:29.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"5199be0e173bb53c5e74b2f7cc5681e99ea52753","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2019-05-28 02:21:07.000000000","message":"Patch Set 2:\n\nFYI, I have talk with Sean on the IRC, here is the log http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-05-21.log.html#t2019-05-21T13:05:02\n\nWe agreed on move sockets, cores, hugepage stuff out of numa node structure, if they want those fields.","accounts_in_message":[],"_revision_number":2},{"id":"611a1d25651d1047db45ab1ae608417b6434e16d","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-05-28 14:24:19.000000000","message":"Patch Set 2: Code-Review+1\n\n(13 comments)\n\nso ignoring the spelling/grammar issues\ni think this simplified version is fine.\n\nthe vm wide aspects like the cpu topology have been extracted\nup one level in the data model and the information exposed has been reduced.\n\nas such this leaks less of the implementation details then the version form last cycle so i would hope this is at least somewhat portable to hypervisors other then libvirt in the future.\n\nso im +1 because you have addressed my main concerns but it would be good to fix up the typos.\n\nthe only other commet i would have is i am still not convince that this api is really that useful for debuging or as an enduser as the info outside of the gust to host pinnings is already  contained in the image+flavor but if you have a customer asking for this i think its still valid.","accounts_in_message":[],"_revision_number":2},{"id":"388b9c225a441e569ffb6a2a2044b6f6e5ffbcba","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-05-28 14:32:01.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3b334464092b010253311748b95bef8668bb8da4","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-05-28 14:36:37.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8ccca2502af4eb95987e132dfc9abd2a8f0e2ee1","author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"date":"2019-05-29 07:06:50.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"198a9d6c8a94a52925d573e5b1dc82201f373a34","author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"date":"2019-05-29 07:25:21.000000000","message":"Patch Set 3:\n\n(15 comments)","accounts_in_message":[],"_revision_number":3},{"id":"8ef11d24cd035f365530ece67470beb5fdd5e63f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-29 07:55:56.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/16/658716/3/check/openstack-tox-docs/15613f1/html/ : SUCCESS in 7m 26s\n- openstack-tox-pep8 http://logs.openstack.org/16/658716/3/check/openstack-tox-pep8/e7248c1/ : SUCCESS in 5m 33s","accounts_in_message":[],"_revision_number":3},{"id":"9027ed3f42566322ab45f7ccbdfd1c96bc55e7dd","author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"date":"2019-05-29 14:57:00.000000000","message":"Patch Set 2:\n\n(1 comment)\n\n@Sean. Rationale for exposing this and detailed info.\nCustomers end up having complex systems with multiple hosts and many servers, some with hyper-threading, PCI on specific NUMA nodes; Then ask \"why server did not schedule but they expect it to\", then the admin/end-user have trouble understanding numa, and how to add things up.\n\nEg, Say you have 10 hosts and 200 servers, using a variety of flavors of cpus, memory, hugepages and sizes, policies, with PCI devices associated with numa nodes, NUMA and HT constraints, etc. If you had the output more like the following, it becomes just more obvious how NUMA nodes were filling up.\n\nI am showing the following example (with one line of output per server per-NUMA Cell), including more related info than what we are ending up with in this spec, to show the original intent for wanting this spec, since we were getting this support question.  When you actually have 200 servers, you could see at a glance where things were going, but definitely this is an \u0027admin\u0027 view.\n\nnova list --all --host controller-0 --fields\u003dres:topology,res:pci_devices\n+--------------------------------------+-------------------------------------------------------------------------------------+---------------------------------------------------------------+\n| ID                                   | res: Topology                                                                       | res: Pci Devices                                              |\n+--------------------------------------+-------------------------------------------------------------------------------------+---------------------------------------------------------------+\n| f943c5cd-e821-4253-b16e-0b34674e2cee | node:0,  1024MB, pgsize:2M, 1s,4c,1t, vcpus:0-3, pcpus:8,10,12,14, pol:ded, thr:pre | node:0, addr:0000:06:00.0, type:PF, vendor:8086, product:10fb |\n+--------------------------------------+-------------------------------------------------------------------------------------+---------------------------------------------------------------+\n\nEg, This is abbreviated format: This says the server cell is on numa 0, using 1024MiB of 2M hugepages, has 1socket,4cores,1thread topology, has vcpus:0,1,2,3  (i.e., vcpu_set), these vcpus map to: 8,10,12,14 (i.e. cpu_pinning), flavor has \u0027hw:cpu_policy\u003ddedicated\u0027, \u0027hw:cpu_thread_policy\u003dprefer\u0027, has PCI on numa, with specific device attributes.","accounts_in_message":[],"_revision_number":2},{"id":"44f9d29520c3766c72bb5d6b2adc509b59c2cd3f","author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"date":"2019-05-31 01:19:23.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"64c406862ead701c49977410a8faefc06a01fd12","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-31 01:31:21.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/16/658716/4/check/openstack-tox-docs/70cc901/html/ : SUCCESS in 6m 51s\n- openstack-tox-pep8 http://logs.openstack.org/16/658716/4/check/openstack-tox-pep8/9de5ea5/ : SUCCESS in 4m 05s","accounts_in_message":[],"_revision_number":4},{"id":"7d72f818733df154e06f4964aea50b01d999af9b","author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"date":"2019-05-31 02:50:17.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4affe61cb510e4f706cb676471da1f90f4e52571","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-06-04 13:11:45.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7e71b94fbfde6c87c6f17354a47d586c46634835","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-06-05 19:20:11.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)\n\none nit inline but im happy with the current version.\nthanks for updating this.","accounts_in_message":[],"_revision_number":4},{"id":"6b8b12a9e2b679dbfe67d809219573b8c40832e7","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2019-06-18 07:41:08.000000000","message":"Patch Set 4: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":4},{"id":"727b2c06a54b1ce51af4b75c03297c0fc6961030","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2019-06-18 07:43:50.000000000","message":"Patch Set 4:\n\nOnly -1 for the wrong comment about vcpu_set and slibings are controlled by the host_info policy. Then LGTM.","accounts_in_message":[],"_revision_number":4},{"id":"b8fb56846d98d6d668a40b06390eb10eb13c680c","author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"date":"2019-06-18 07:45:09.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"b0f9252a00ed74779331f71ead13a3fa847b30a3","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2019-06-18 07:45:41.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"65ce1ca9ef58b017ed272cd704128eeea87bf588","author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"date":"2019-06-18 07:46:13.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"b5f07ca4aeb9b485e833a65b2896e33b91e7ff64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-18 08:03:28.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/16/658716/5/check/openstack-tox-docs/b493a3a/html/ : SUCCESS in 8m 06s\n- openstack-tox-pep8 http://logs.openstack.org/16/658716/5/check/openstack-tox-pep8/4e8c688/ : SUCCESS in 7m 49s","accounts_in_message":[],"_revision_number":5},{"id":"29669972bb07960606b08d3674795f4998698645","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-24 20:06:30.000000000","message":"Patch Set 5:\n\nIn case it\u0027s helpful to reviewers, here\u0027s a consolidated/abbreviated diff from the approved stein version [1] to PS5 of the train version (this patch): http://paste.openstack.org/raw/753325/\n\n[1] https://specs.openstack.org/openstack/nova-specs/specs/stein/approved/show-server-numa-topology.html","accounts_in_message":[],"_revision_number":5},{"id":"e4a08eb451a1d762e4d522625946e20d254ecaee","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-06-25 13:44:08.000000000","message":"Patch Set 5: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"d151bef1fd2aeaefffe77d37321c8488cc3209e3","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-06-25 13:58:30.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1\n\n(13 comments)\n\nI\u0027m not super jazzed about exposing the host hardware information, but it\u0027s protected by default from user view and it sounds like there\u0027s a lot of support for it. The exposure of the guest topology itself seems fine to me.\n\nI noted a lot of grammar changes which I think should be fixed in a followup.","accounts_in_message":[],"_revision_number":5},{"id":"1938b71b930f04981087b368085dd1f7fa0de0fa","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-25 14:04:09.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"9c9e997a622b4c90bae7e75dcee23ccc4629791f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-25 14:18:20.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5},{"id":"78b6b700e94f85ae23a0539dade9808461a7c66a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-25 14:18:20.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/16/658716/5/gate/openstack-tox-docs/a414eb3/html/ : SUCCESS in 6m 11s\n- openstack-tox-pep8 http://logs.openstack.org/16/658716/5/gate/openstack-tox-pep8/8ca0738/ : SUCCESS in 6m 27s","accounts_in_message":[],"_revision_number":5},{"id":"3db430a9765758cd1eaf9457b3cf8aa6bc00e359","author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"date":"2019-06-26 01:55:12.000000000","message":"Patch Set 5:\n\n(14 comments)\n\ngrammar and 4k fix composite to a little patch:\nhttps://review.opendev.org/#/c/667487/","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"1b0f39002cb9e35bd2d3e64def0ab806197de8a7","revisions":{"1516bc3dc57d5ebaed0f96d2b791395a3f4ecf5e":{"kind":"REWORK","_number":1,"created":"2019-05-13 02:31:42.000000000","uploader":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"ref":"refs/changes/16/658716/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/16/658716/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/1"}}},"commit":{"parents":[{"commit":"4c0d084993993eb51e25f3943de7f2915d424de8","subject":"Merge \"Support filtering of allocation_candidates by forbidden aggregates\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/4c0d084993993eb51e25f3943de7f2915d424de8"}]}],"author":{"name":"Yongli He","email":"yongli.he@intel.com","date":"2018-10-19 07:13:04.000000000","tz":480},"committer":{"name":"Yongli He","email":"yongli.he@intel.com","date":"2019-05-13 02:30:09.000000000","tz":480},"subject":"add spec \"show-server-numa-topology\"","message":"add spec \"show-server-numa-topology\"\n\nThis spec present numa information in server diagnostic API.\n\nAPIImpact\nbp: show-server-numa-topology\n\nChange-Id: I60b16eee2f03a78382b735ccad588d0d619e7693\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/1516bc3dc57d5ebaed0f96d2b791395a3f4ecf5e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/1516bc3dc57d5ebaed0f96d2b791395a3f4ecf5e"}]},"branch":"refs/heads/master"},"ec665caf0d2c0ed5dc9f9df9b65b45454e555280":{"kind":"REWORK","_number":2,"created":"2019-05-22 07:19:12.000000000","uploader":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"ref":"refs/changes/16/658716/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/16/658716/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/2"}}},"commit":{"parents":[{"commit":"4c0d084993993eb51e25f3943de7f2915d424de8","subject":"Merge \"Support filtering of allocation_candidates by forbidden aggregates\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/4c0d084993993eb51e25f3943de7f2915d424de8"}]}],"author":{"name":"Yongli He","email":"yongli.he@intel.com","date":"2018-10-19 07:13:04.000000000","tz":480},"committer":{"name":"Yongli He","email":"yongli.he@intel.com","date":"2019-05-22 07:19:06.000000000","tz":480},"subject":"add spec \"show-server-numa-topology\"","message":"add spec \"show-server-numa-topology\"\n\nThis spec present numa information in server diagnostic API.\n\nAPIImpact\nbp: show-server-numa-topology\n\nChange-Id: I60b16eee2f03a78382b735ccad588d0d619e7693\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/ec665caf0d2c0ed5dc9f9df9b65b45454e555280"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/ec665caf0d2c0ed5dc9f9df9b65b45454e555280"}]},"branch":"refs/heads/master"},"8323de3fe1e588eb6fceaef439ad4e652349a222":{"kind":"REWORK","_number":3,"created":"2019-05-29 07:06:50.000000000","uploader":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"ref":"refs/changes/16/658716/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/16/658716/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/3"}}},"commit":{"parents":[{"commit":"4c0d084993993eb51e25f3943de7f2915d424de8","subject":"Merge \"Support filtering of allocation_candidates by forbidden aggregates\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/4c0d084993993eb51e25f3943de7f2915d424de8"}]}],"author":{"name":"Yongli He","email":"yongli.he@intel.com","date":"2018-10-19 07:13:04.000000000","tz":480},"committer":{"name":"Yongli He","email":"yongli.he@intel.com","date":"2019-05-29 07:06:45.000000000","tz":480},"subject":"add spec \"show-server-numa-topology\"","message":"add spec \"show-server-numa-topology\"\n\nThis spec present numa information in server diagnostic API.\n\nAPIImpact\nbp: show-server-numa-topology\n\nChange-Id: I60b16eee2f03a78382b735ccad588d0d619e7693\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/8323de3fe1e588eb6fceaef439ad4e652349a222"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/8323de3fe1e588eb6fceaef439ad4e652349a222"}]},"branch":"refs/heads/master"},"c1b86fa62c3011330785599c387ad276f8df5235":{"kind":"REWORK","_number":4,"created":"2019-05-31 01:19:23.000000000","uploader":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"ref":"refs/changes/16/658716/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/16/658716/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/4"}}},"commit":{"parents":[{"commit":"4c0d084993993eb51e25f3943de7f2915d424de8","subject":"Merge \"Support filtering of allocation_candidates by forbidden aggregates\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/4c0d084993993eb51e25f3943de7f2915d424de8"}]}],"author":{"name":"Yongli He","email":"yongli.he@intel.com","date":"2018-10-19 07:13:04.000000000","tz":480},"committer":{"name":"Yongli He","email":"yongli.he@intel.com","date":"2019-05-31 01:19:09.000000000","tz":480},"subject":"add spec \"show-server-numa-topology\"","message":"add spec \"show-server-numa-topology\"\n\nThis spec present numa information in server diagnostic API.\n\nAPIImpact\nbp: show-server-numa-topology\n\nChange-Id: I60b16eee2f03a78382b735ccad588d0d619e7693\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/c1b86fa62c3011330785599c387ad276f8df5235"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/c1b86fa62c3011330785599c387ad276f8df5235"}]},"branch":"refs/heads/master"},"1b0f39002cb9e35bd2d3e64def0ab806197de8a7":{"kind":"REWORK","_number":5,"created":"2019-06-18 07:45:09.000000000","uploader":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"ref":"refs/changes/16/658716/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/16/658716/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/16/658716/5"}}},"commit":{"parents":[{"commit":"4c0d084993993eb51e25f3943de7f2915d424de8","subject":"Merge \"Support filtering of allocation_candidates by forbidden aggregates\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/4c0d084993993eb51e25f3943de7f2915d424de8"}]}],"author":{"name":"Yongli He","email":"yongli.he@intel.com","date":"2018-10-19 07:13:04.000000000","tz":480},"committer":{"name":"Yongli He","email":"yongli.he@intel.com","date":"2019-06-18 07:44:51.000000000","tz":480},"subject":"add spec \"show-server-numa-topology\"","message":"add spec \"show-server-numa-topology\"\n\nThis spec present numa information in server diagnostic API.\n\nAPIImpact\nbp: show-server-numa-topology\n\nChange-Id: I60b16eee2f03a78382b735ccad588d0d619e7693\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/1b0f39002cb9e35bd2d3e64def0ab806197de8a7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/1b0f39002cb9e35bd2d3e64def0ab806197de8a7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}