)]}'
{"id":"openstack%2Fnova-specs~667894","triplet_id":"openstack%2Fnova-specs~master~I8aa2b9be5b53ba13c8921dbb66b6b7d4c57e9f6c","project":"openstack/nova-specs","branch":"master","topic":"bp/add-user-id-field-to-the-migrations-table","hashtags":[],"change_id":"I8aa2b9be5b53ba13c8921dbb66b6b7d4c57e9f6c","subject":"Add user_id to the migrations","status":"MERGED","created":"2019-06-27 10:46:15.000000000","updated":"2019-07-26 13:18:05.000000000","submitted":"2019-07-26 04:25:41.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":56,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"667894-1564115141556-31ef7618","meta_rev_id":"8855b77f377f3396483df77a9038b4f1c2ce90d8","_number":667894,"virtual_id_number":667894,"owner":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"value":0,"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},{"value":2,"date":"2019-07-26 04:25:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"recommended":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":0,"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"value":0,"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},{"value":1,"date":"2019-07-25 21:11:29.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":2,"date":"2019-07-25 21:11:26.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":1,"date":"2019-07-25 21:19:45.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2019-07-26 01:19:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":2,"date":"2019-07-26 04:17:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"all":[{"value":0,"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"value":0,"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"date":"2019-07-25 21:18:59.000000000","_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":1,"date":"2019-07-26 04:17:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"value":0,"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-01 02:41:17.000000000","updated_by":{"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},"reviewer":{"_account_id":26490,"name":"Jason SUN","email":"sunjia@inspur.com","username":"sunjia"},"state":"REVIEWER"},{"updated":"2019-07-22 20:04:27.000000000","updated_by":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"reviewer":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"state":"REVIEWER"},{"updated":"2019-07-22 20:09:46.000000000","updated_by":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"reviewer":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"state":"REVIEWER"},{"updated":"2019-07-25 21:11:26.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-07-25 21:11:29.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2019-07-25 21:18:59.000000000","updated_by":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"reviewer":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"state":"REVIEWER"},{"updated":"2019-07-25 21:19:45.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-07-26 01:19:14.000000000","updated_by":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"reviewer":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"state":"REVIEWER"},{"updated":"2019-07-26 04:17:22.000000000","updated_by":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"reviewer":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"state":"REVIEWER"},{"updated":"2019-07-26 04:25:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c5310bbb9428b1454b4129ee56a1f673e0caa3c5","author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"date":"2019-06-27 10:46:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7a2a62997826b509f02b7e390e6f31bb08a8d93f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-27 11:01:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/94/667894/1/check/openstack-tox-docs/adacda4/html/ : SUCCESS in 5m 58s\n- openstack-tox-pep8 http://logs.openstack.org/94/667894/1/check/openstack-tox-pep8/1e9c1da/ : SUCCESS in 3m 34s","accounts_in_message":[],"_revision_number":1},{"id":"28ad0184556e683b17ac90e474a5948e6da5f033","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-01 21:24:11.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"97895795cd19a74a73b68b924016d848f6153aa8","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-01 21:25:37.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4b3434a9bdb478dd02ed7eaa864f54eb68d7020a","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-07-02 02:51:25.000000000","message":"Patch Set 1: Code-Review-1\n\n(8 comments)\n\nas i said inline i think the info is already in the instance action but we could also add it to the migration.\n\nwithout exposing this via the api however i dont think this is that useful.","accounts_in_message":[],"_revision_number":1},{"id":"985ba63fe207a3cf0841c007bdb008df63669696","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-02 13:51:09.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"e8474baad9ed20005facbab4867b76079d0dcee4","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-02 13:55:06.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2f7450d845445c1f870d923a0a98fa961138bf6f","author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"date":"2019-07-03 01:40:41.000000000","message":"Patch Set 1: Code-Review+1\n\n(13 comments)","accounts_in_message":[],"_revision_number":1},{"id":"68b2d523e7b2670a3fb7d3a6bb3939de4a47d29c","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-07-03 02:20:49.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0276c789b962f43fee55a344e698d8b0267aba19","author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"date":"2019-07-11 02:45:11.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"f8edb2d90a653b8df97a9c051ddc966aa980eefb","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-22 20:06:39.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nI\u0027m less -1 on this than before given the clunky nature of trying to correlate instance actions to migration records in the API, especially if multiple migrations have happened to the same server in the same day. I still don\u0027t really like duplicating the initiating user_id (and likely project_id) in the migration record though since it overlaps with server actions. A better way might be to store the request ID on the migration record so you can go from the migration record you care about directly to the associated instance action to get the user_id/project_id information, but would want input from others (like Dan Smith) on that directly. Obviously adding user_id/project_id to the migration records is trivial but it is overlap which smells like technical debt to me.","accounts_in_message":[],"_revision_number":1},{"id":"64c8c6427a7835e591ffb000c2ab696187aa9ec3","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-07-24 00:39:56.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nSome feedback from customers.","accounts_in_message":[],"_revision_number":1},{"id":"66d0bb11524e9d427386a9151cdbf3b35cf267dc","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 02:09:38.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"191e4e00e6ef4e5e1c6648861adba38087d4baba","author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"date":"2019-07-25 03:39:26.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1288fbc2c4f5b10f02f5ac6d43bb0961cf3dfd95","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 12:34:21.000000000","message":"Patch Set 1:\n\nAt this point the spec needs to be updated regardless of using instance actions as an alternative solution - there are several comments inline that would need to be addressed to clean this up before it can be approved. Also, as noted inline, if we add user_id to the migration record I think we also need to add project_id since they go together.","accounts_in_message":[],"_revision_number":1},{"id":"6bea1f3dbdc32e5c45576bfbfcc256317de854b4","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 20:24:20.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nI\u0027m updating this since today is Train spec freeze and it\u0027s mostly straight-forward, only a question inline about whether or not user_id and project_id should be filter parameters on the GET /os-migrations request.","accounts_in_message":[],"_revision_number":1},{"id":"8fcc4418263f9ddf17be05f405d9b4d9ab740321","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 20:28:47.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"393398e037b73e128383156a01c0a705d9661ca7","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 20:29:27.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ac569c8f74bb684a2b8f6296bd141efe616769c6","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 20:30:21.000000000","message":"Patch Set 3:\n\nPS2 addresses comments from PS1, and PS3 fixes the filename to match the blueprint in launchpad.","accounts_in_message":[],"_revision_number":3},{"id":"adb463238e76cfd3eb796ebe67d6dc53963b2b05","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 20:31:04.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"14866733c6dea2fe49147cedff4dbd0fa855ad5a","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-25 20:46:15.000000000","message":"Patch Set 3:\n\n(1 comment)\n\nStill reviewing, but wanted to post this rn.","accounts_in_message":[],"_revision_number":3},{"id":"6a5dba732580e42948a602c0ce7d482eb060953e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 20:46:17.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/94/667894/3/check/openstack-tox-docs/d5b46fb/html/ : SUCCESS in 6m 58s\n- openstack-tox-pep8 http://logs.openstack.org/94/667894/3/check/openstack-tox-pep8/feaf329/ : SUCCESS in 4m 31s","accounts_in_message":[],"_revision_number":3},{"id":"cc3afd9a66a6f93c32fe2c7ae22ed44414c23100","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-25 20:54:42.000000000","message":"Patch Set 3:\n\n(5 comments)\n\nYeah, let\u0027s add the GET /os-migrations filter field, then I\u0027m +2 on this.","accounts_in_message":[],"_revision_number":3},{"id":"a1c82f0ec6591aa99f5c380a368dc398554e803b","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 21:08:39.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"d3968407fe9ee423e0906ac60441b4991db74ffa","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 21:08:53.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"8ac65c0e98f71f759c5a55dff9f683dc2b2a17e1","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-07-25 21:09:07.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"d5c87037f4a3ed784e8ea918e3143b58ebe58e17","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-25 21:11:26.000000000","message":"Patch Set 4: Code-Review+2\n\nYup, lgtm, let\u0027s go.","accounts_in_message":[],"_revision_number":4},{"id":"7ec897d5bf53a6e3049ea0d2d8dbc16682b371f2","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-07-25 21:11:29.000000000","message":"Patch Set 4: Code-Review+1\n\nya this just cleans up the nits erric noted and i generally agreed with what was in v3 so i think v4 looks good to go.","accounts_in_message":[],"_revision_number":4},{"id":"9cf6957cb772351a9991ecc38541a7dee1262e8c","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 21:16:25.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"7fda4de74345d113f2629d17fa2c54945b349d23","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 21:17:06.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"a10ad232bddca7454db78afa5b1980ababe49bbd","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-25 21:19:45.000000000","message":"Patch Set 4: Code-Review+1\n\nI updated this quite a bit. I\u0027d be more comfortable with Alex and/or Ken\u0027ichi approving this but I might elevate to a +2 by EOD tomorrow if no one else gets it before then (realizing that\u0027s bending the spec freeze deadline a bit).","accounts_in_message":[],"_revision_number":4},{"id":"24a699258adbd96b013e1c9c011e30df4161e071","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 21:22:11.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/94/667894/4/check/openstack-tox-docs/9992964/html/ : SUCCESS in 7m 04s\n- openstack-tox-pep8 http://logs.openstack.org/94/667894/4/check/openstack-tox-pep8/b95f4f1/ : SUCCESS in 4m 25s","accounts_in_message":[],"_revision_number":4},{"id":"c4ce6eadd2cdfa47dcc3b9d39a90b64be3a39063","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-07-25 21:24:13.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"e7c61379f89ce0ae4fbad9c7c7238ae4364d3a50","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-07-26 01:19:14.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"e01c9e7559bf49da65e1b503bb1b3c15eb82a143","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2019-07-26 04:17:22.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\n(1 comment)\n\nI think the index can be addressed with a followup.","accounts_in_message":[],"_revision_number":4},{"id":"f9f0444ec5f8e3e0c3295fbcd0c35f88e2f6c70c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-26 04:17:33.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"b0c6b91821039905d7f9dff551f4212645306abb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-26 04:25:41.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"968e66ac37cf81f4ca1af93869f4825ee11fcfe1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-26 04:25:41.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/94/667894/4/gate/openstack-tox-docs/f1a20c2/html/ : SUCCESS in 6m 55s\n- openstack-tox-pep8 http://logs.openstack.org/94/667894/4/gate/openstack-tox-pep8/5fb77d8/ : SUCCESS in 4m 16s","accounts_in_message":[],"_revision_number":4},{"id":"4a9d4130783ead9d4d5b4f95f5db244785332aa1","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-07-26 10:34:45.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"6fd8cb1dfd6fe4c24d173c53b761a20bec5030d7","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-07-26 13:18:05.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"1a04191494db4f19e22e4486d5b0c7535f4234f3","revisions":{"dcce62cdd6c92146418c086afecd4ef2a3e7cd71":{"kind":"REWORK","_number":1,"created":"2019-06-27 10:46:15.000000000","uploader":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"ref":"refs/changes/94/667894/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/94/667894/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/94/667894/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/94/667894/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/94/667894/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/94/667894/1"}}},"commit":{"parents":[{"commit":"15da794b704f24e45fa0745243676e660cdee51f","subject":"grammar fix for show-server-numa-topology spec","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/15da794b704f24e45fa0745243676e660cdee51f"}]}],"author":{"name":"root","email":"root@localhost.localdomain","date":"2019-06-27 10:19:14.000000000","tz":-240},"committer":{"name":"Qiu","email":"qiujunting@inspur.com","date":"2019-06-27 10:46:11.000000000","tz":-240},"subject":"Add user_id to the migrations","message":"Add user_id to the migrations\n\nThe blueprint proposed to adding the ``user_id`` field to the migrations\ntable in nova DB.\nWhen the sever is host to host, displaying the operator in the server\nmigration history.\n\nCo-Authored-By:Jasson SUN (sunjia@inspur.com)\n\nChange-Id: I8aa2b9be5b53ba13c8921dbb66b6b7d4c57e9f6c\nBlueprint: add-user-id-to-the-migrations-table\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/dcce62cdd6c92146418c086afecd4ef2a3e7cd71"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/dcce62cdd6c92146418c086afecd4ef2a3e7cd71"}]},"branch":"refs/heads/master"},"056fc4d34390f39db87fa851000eca1bdf0aaab1":{"kind":"REWORK","_number":2,"created":"2019-07-25 20:28:47.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/94/667894/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/94/667894/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/94/667894/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/94/667894/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/94/667894/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/94/667894/2"}}},"commit":{"parents":[{"commit":"15da794b704f24e45fa0745243676e660cdee51f","subject":"grammar fix for show-server-numa-topology spec","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/15da794b704f24e45fa0745243676e660cdee51f"}]}],"author":{"name":"root","email":"root@localhost.localdomain","date":"2019-06-27 10:19:14.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-25 20:28:30.000000000","tz":-240},"subject":"Add user_id to the migrations","message":"Add user_id to the migrations\n\nThe blueprint proposes tracking the user_id and project_id of the user that\ninitiated a server migration and exposing those values in the API.\n\nCo-Authored-By:Jason SUN (sunjia@inspur.com)\n\nChange-Id: I8aa2b9be5b53ba13c8921dbb66b6b7d4c57e9f6c\nBlueprint: add-user-id-field-to-the-migrations-table\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/056fc4d34390f39db87fa851000eca1bdf0aaab1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/056fc4d34390f39db87fa851000eca1bdf0aaab1"}]},"branch":"refs/heads/master"},"e2f79efabc6b74583eedfdf8a0162b23eae0e121":{"kind":"REWORK","_number":3,"created":"2019-07-25 20:29:27.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/94/667894/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/94/667894/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/94/667894/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/94/667894/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/94/667894/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/94/667894/3"}}},"commit":{"parents":[{"commit":"15da794b704f24e45fa0745243676e660cdee51f","subject":"grammar fix for show-server-numa-topology spec","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/15da794b704f24e45fa0745243676e660cdee51f"}]}],"author":{"name":"root","email":"root@localhost.localdomain","date":"2019-06-27 10:19:14.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-25 20:29:12.000000000","tz":-240},"subject":"Add user_id to the migrations","message":"Add user_id to the migrations\n\nThe blueprint proposes tracking the user_id and project_id of the user that\ninitiated a server migration and exposing those values in the API.\n\nCo-Authored-By:Jason SUN (sunjia@inspur.com)\n\nChange-Id: I8aa2b9be5b53ba13c8921dbb66b6b7d4c57e9f6c\nBlueprint: add-user-id-field-to-the-migrations-table\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/e2f79efabc6b74583eedfdf8a0162b23eae0e121"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/e2f79efabc6b74583eedfdf8a0162b23eae0e121"}]},"branch":"refs/heads/master"},"1a04191494db4f19e22e4486d5b0c7535f4234f3":{"kind":"REWORK","_number":4,"created":"2019-07-25 21:08:39.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/94/667894/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/94/667894/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/94/667894/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/94/667894/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/94/667894/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/94/667894/4"}}},"commit":{"parents":[{"commit":"15da794b704f24e45fa0745243676e660cdee51f","subject":"grammar fix for show-server-numa-topology spec","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/15da794b704f24e45fa0745243676e660cdee51f"}]}],"author":{"name":"root","email":"root@localhost.localdomain","date":"2019-06-27 10:19:14.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-25 21:08:32.000000000","tz":-240},"subject":"Add user_id to the migrations","message":"Add user_id to the migrations\n\nThe blueprint proposes tracking the user_id and project_id of the user that\ninitiated a server migration and exposing those values in the API.\n\nCo-Authored-By:Jason SUN (sunjia@inspur.com)\n\nChange-Id: I8aa2b9be5b53ba13c8921dbb66b6b7d4c57e9f6c\nBlueprint: add-user-id-field-to-the-migrations-table\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/1a04191494db4f19e22e4486d5b0c7535f4234f3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/1a04191494db4f19e22e4486d5b0c7535f4234f3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}