)]}'
{"specs/train/approved/boot-with-vnic-type.rst":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"76e9f0e082f6733202047eb7feccb00f8a6bdfe5","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Only show new parameters\u0027 JSON schema definition for body data of ``server`` ::"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  \u0027vnic_type\u0027: parameter_types.vnic_type"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Depending on whether/how the ``vnic_type`` is set, the actions are as"},{"line_number":79,"context_line":"followed:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_a5f11104","line":76,"range":{"start_line":76,"start_character":31,"end_line":76,"end_character":40},"updated":"2019-07-24 06:21:28.000000000","message":"Is it string enum value?\nIf so, allowed values should be described.","commit_id":"66d8258bbfe20b0c13cc50d04aa8f153d3da767b"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"2d70fe33b8596219caa455ccb9326f8dee22636e","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Only show new parameters\u0027 JSON schema definition for body data of ``server`` ::"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  \u0027vnic_type\u0027: parameter_types.vnic_type"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Depending on whether/how the ``vnic_type`` is set, the actions are as"},{"line_number":79,"context_line":"followed:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_a5335162","line":76,"range":{"start_line":76,"start_character":31,"end_line":76,"end_character":40},"in_reply_to":"7faddb67_a5f11104","updated":"2019-07-24 07:03:32.000000000","message":"yes, it is string enum value. I wiil describe it in detail.","commit_id":"66d8258bbfe20b0c13cc50d04aa8f153d3da767b"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"76e9f0e082f6733202047eb7feccb00f8a6bdfe5","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Depending on whether/how the ``vnic_type`` is set, the actions are as"},{"line_number":79,"context_line":"followed:"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  - If ``vnic_type`` is supplied in the request body, at first Compute API"},{"line_number":82,"context_line":"    will check whether the value provided is within the valid values. If not,"},{"line_number":83,"context_line":"    a ``HTTP 400 Bad Request`` will be returned to users."},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_458dbd79","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":2},"updated":"2019-07-24 06:21:28.000000000","message":"Remove extra white spaces.","commit_id":"66d8258bbfe20b0c13cc50d04aa8f153d3da767b"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"2d70fe33b8596219caa455ccb9326f8dee22636e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Depending on whether/how the ``vnic_type`` is set, the actions are as"},{"line_number":79,"context_line":"followed:"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  - If ``vnic_type`` is supplied in the request body, at first Compute API"},{"line_number":82,"context_line":"    will check whether the value provided is within the valid values. If not,"},{"line_number":83,"context_line":"    a ``HTTP 400 Bad Request`` will be returned to users."},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_25d9a121","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":2},"in_reply_to":"7faddb67_458dbd79","updated":"2019-07-24 07:03:32.000000000","message":"thakns Takashi, I will update it.","commit_id":"66d8258bbfe20b0c13cc50d04aa8f153d3da767b"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"76e9f0e082f6733202047eb7feccb00f8a6bdfe5","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    will check whether the value provided is within the valid values. If not,"},{"line_number":83,"context_line":"    a ``HTTP 400 Bad Request`` will be returned to users."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  - If ``vnic_type`` is not supplied in the request body, Compute API will"},{"line_number":86,"context_line":"    pass it as ``None`` to Nova Compute. And Nova Compute will not pass"},{"line_number":87,"context_line":"    ``vnic_type`` to neutron API  when create port."},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_e5e70946","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":2},"updated":"2019-07-24 06:21:28.000000000","message":"ditto","commit_id":"66d8258bbfe20b0c13cc50d04aa8f153d3da767b"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"2d70fe33b8596219caa455ccb9326f8dee22636e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    will check whether the value provided is within the valid values. If not,"},{"line_number":83,"context_line":"    a ``HTTP 400 Bad Request`` will be returned to users."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  - If ``vnic_type`` is not supplied in the request body, Compute API will"},{"line_number":86,"context_line":"    pass it as ``None`` to Nova Compute. And Nova Compute will not pass"},{"line_number":87,"context_line":"    ``vnic_type`` to neutron API  when create port."},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_e504e980","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":2},"in_reply_to":"7faddb67_e5e70946","updated":"2019-07-24 07:03:32.000000000","message":"thakns Takashi, I will update it.","commit_id":"66d8258bbfe20b0c13cc50d04aa8f153d3da767b"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"41d691ca20cec2dd294240e537eb7e7e5cfb8da3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    a ``HTTP 400 Bad Request`` will be returned to users."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  - If ``vnic_type`` is not supplied in the request body, Compute API will"},{"line_number":86,"context_line":"    pass it as ``None`` to Nova Compute. And Nova Compute will not pass"},{"line_number":87,"context_line":"    ``vnic_type`` to neutron API  when create port."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_a597d13a","line":86,"range":{"start_line":86,"start_character":17,"end_line":86,"end_character":21},"updated":"2019-07-24 06:51:48.000000000","message":"How about default as \u0027Normal\u0027. I don\u0027t know whether it is better, Just bring it up.","commit_id":"66d8258bbfe20b0c13cc50d04aa8f153d3da767b"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"2d70fe33b8596219caa455ccb9326f8dee22636e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    a ``HTTP 400 Bad Request`` will be returned to users."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  - If ``vnic_type`` is not supplied in the request body, Compute API will"},{"line_number":86,"context_line":"    pass it as ``None`` to Nova Compute. And Nova Compute will not pass"},{"line_number":87,"context_line":"    ``vnic_type`` to neutron API  when create port."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_6526b919","line":86,"range":{"start_line":86,"start_character":17,"end_line":86,"end_character":21},"in_reply_to":"7faddb67_a597d13a","updated":"2019-07-24 07:03:32.000000000","message":"if vnic_type is None, Nova Compute will not pass it to Neutron, the type of port vnic will be determined by neutron. although vnic type default value is normal in neutron server. I think it\u0027s better to leave the decision to neutron if the user hasn\u0027t set it.","commit_id":"66d8258bbfe20b0c13cc50d04aa8f153d3da767b"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"76e9f0e082f6733202047eb7feccb00f8a6bdfe5","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"* Add ``vnic_type`` support in create server API."},{"line_number":143,"context_line":"* Add ``vnic-type`` support for \u0027openstack server create\u0027 in openstackclient."},{"line_number":144,"context_line":"* Add ``vnic-type`` support for \u0027nova boot\u0027 in novaclient."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Dependencies"},{"line_number":147,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_c581ad4c","line":144,"range":{"start_line":144,"start_character":0,"end_line":144,"end_character":58},"updated":"2019-07-24 06:21:28.000000000","message":"Add ``vnic-type`` support in ``--nic`` option?","commit_id":"66d8258bbfe20b0c13cc50d04aa8f153d3da767b"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"2d70fe33b8596219caa455ccb9326f8dee22636e","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"* Add ``vnic_type`` support in create server API."},{"line_number":143,"context_line":"* Add ``vnic-type`` support for \u0027openstack server create\u0027 in openstackclient."},{"line_number":144,"context_line":"* Add ``vnic-type`` support for \u0027nova boot\u0027 in novaclient."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Dependencies"},{"line_number":147,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_25f2019c","line":144,"range":{"start_line":144,"start_character":0,"end_line":144,"end_character":58},"in_reply_to":"7faddb67_c581ad4c","updated":"2019-07-24 07:03:32.000000000","message":"yes, I will git an example.","commit_id":"66d8258bbfe20b0c13cc50d04aa8f153d3da767b"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"76e9f0e082f6733202047eb7feccb00f8a6bdfe5","unresolved":false,"context_lines":[{"line_number":169,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":".. list-table:: Revisions"},{"line_number":172,"context_line":"      :header-rows: 1"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"   * - Release Name"},{"line_number":175,"context_line":"     - Description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_2590c195","line":172,"range":{"start_line":172,"start_character":3,"end_line":172,"end_character":6},"updated":"2019-07-24 06:21:28.000000000","message":"Remove extra white spaces.","commit_id":"66d8258bbfe20b0c13cc50d04aa8f153d3da767b"},{"author":{"_account_id":30380,"name":"ZhouHeng","email":"zhouhenglc@inspur.com","username":"zhouhenglc"},"change_message_id":"2d70fe33b8596219caa455ccb9326f8dee22636e","unresolved":false,"context_lines":[{"line_number":169,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":".. list-table:: Revisions"},{"line_number":172,"context_line":"      :header-rows: 1"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"   * - Release Name"},{"line_number":175,"context_line":"     - Description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_050a6589","line":172,"range":{"start_line":172,"start_character":3,"end_line":172,"end_character":6},"in_reply_to":"7faddb67_2590c195","updated":"2019-07-24 07:03:32.000000000","message":"thakns Takashi, I will update it.","commit_id":"66d8258bbfe20b0c13cc50d04aa8f153d3da767b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1bb8c301f5d696b41c9dc9cc7309e399bba7e95a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Alternatives"},{"line_number":41,"context_line":"------------"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Create it in two steps, first create a port of type ``direct``"},{"line_number":44,"context_line":"or ``macvtap``, then start the server with the created port."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_09191087","line":43,"updated":"2019-07-25 01:51:46.000000000","message":"Given https://docs.openstack.org/nova/latest/contributor/project-scope.html#no-more-orchestration I think this is sufficient.","commit_id":"e2fd017887132a125566c777019153683c95b6b1"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"b2da7878763f8f0507ca9e0957ba2e6c468f7dd5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Alternatives"},{"line_number":41,"context_line":"------------"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Create it in two steps, first create a port of type ``direct``"},{"line_number":44,"context_line":"or ``macvtap``, then start the server with the created port."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_e487f90e","line":43,"in_reply_to":"7faddb67_09191087","updated":"2019-07-25 03:48:07.000000000","message":"Matt, I like nova, and I hope it will develope better.\n\nInspur cloud deployment has many users in various industries, and the scale is considerable. At the same time, some functions that customers urgently need are collected, such as \"Support set port vnic type to create server\". More than one customer makes such a request. \n\nAfter the discussion, our team will feedback this feature to the community so that nova can get more users\u0027 attention and use.\n\nYeah, \"Nova is a low level infrastructure API.\", but I think we should consider whether to adopt good advice.","commit_id":"e2fd017887132a125566c777019153683c95b6b1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9e23c2a6ea8bd7aa0f6e0debd9bbcc27e2abadcd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Alternatives"},{"line_number":41,"context_line":"------------"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Create it in two steps, first create a port of type ``direct``"},{"line_number":44,"context_line":"or ``macvtap``, then start the server with the created port."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_794d3a70","line":43,"in_reply_to":"7faddb67_e487f90e","updated":"2019-11-04 22:03:23.000000000","message":"Huawei is the same way. Every customer request is basically accepted and implemented regardless of whether or not it\u0027s a good idea to shove it into the lower IaaS layer or nova like this. The alternative to create a port with the necessary advanced configuration and provide it to nova is sufficient IMO and you can provide your customer with a layer that handles that orchestration, be it CLI, UI, etc. The same argument was made for years about being able to specify volume_type when doing boot from volume and this request for vnic type has gotten nowhere near the same level of various user/vendor requests as the volume type thing.","commit_id":"e2fd017887132a125566c777019153683c95b6b1"}],"specs/ussuri/approved/boot-with-vnic-type.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd8ed770e86fb33de088f371d0e9c68163e4b911","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/boot-with-vnic-type"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"When users create server use network uuid to provision the server instance"},{"line_number":14,"context_line":"with a NIC. The type of vNIC default value is ``normal``, user can not set"},{"line_number":15,"context_line":"it. This blueprint proposed to set port ``vnic_type`` when create a server."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_d978d5c3","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":75},"updated":"2020-01-30 21:46:57.000000000","message":"so i proposed this in the past and it was rejected because nova should not provide proxy apis to other services.\nhowever if we support this we should be able to specify the vnic type per interface that nova creates","commit_id":"a12a664af839be19fd2b3741500c4499c045d8b8"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a7aac87db8107a1efea6ca6354c42e3414f44600","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/boot-with-vnic-type"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"When users create server use network uuid to provision the server instance"},{"line_number":14,"context_line":"with a NIC. The type of vNIC default value is ``normal``, user can not set"},{"line_number":15,"context_line":"it. This blueprint proposed to set port ``vnic_type`` when create a server."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_a6da0d73","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":75},"in_reply_to":"3fa7e38b_d978d5c3","updated":"2020-02-10 13:49:25.000000000","message":"yeah, there are some customers of us want to get this feature, this will be extremely convenient.","commit_id":"a12a664af839be19fd2b3741500c4499c045d8b8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd8ed770e86fb33de088f371d0e9c68163e4b911","unresolved":false,"context_lines":[{"line_number":20,"context_line":"When users want to use other type (not ``normal``, such as ``macvtap``,"},{"line_number":21,"context_line":"``direct`` etc.) of port in creating a server. At first, we should create"},{"line_number":22,"context_line":"a specified type\u0027s port, then specify the created port to boot a server."},{"line_number":23,"context_line":"In this way, we created a server in two steps. If we bulk create servers,"},{"line_number":24,"context_line":"this is impossible to achieve. In other words, if we need to create more"},{"line_number":25,"context_line":"than 10 servers, this will become very cumbersome make, it\u0027s very unfriendly"},{"line_number":26,"context_line":"to the user."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_1c397bcf","line":24,"range":{"start_line":23,"start_character":48,"end_line":24,"end_character":30},"updated":"2020-01-30 21:46:57.000000000","message":"not quite true you just can use novas multi create.\n\nbut that is  a feature that we dont want to continue to extend functionality of so its not a good argument to enable this feature.","commit_id":"a12a664af839be19fd2b3741500c4499c045d8b8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd8ed770e86fb33de088f371d0e9c68163e4b911","unresolved":false,"context_lines":[{"line_number":21,"context_line":"``direct`` etc.) of port in creating a server. At first, we should create"},{"line_number":22,"context_line":"a specified type\u0027s port, then specify the created port to boot a server."},{"line_number":23,"context_line":"In this way, we created a server in two steps. If we bulk create servers,"},{"line_number":24,"context_line":"this is impossible to achieve. In other words, if we need to create more"},{"line_number":25,"context_line":"than 10 servers, this will become very cumbersome make, it\u0027s very unfriendly"},{"line_number":26,"context_line":"to the user."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Use Cases"},{"line_number":29,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_bc81474f","line":26,"range":{"start_line":24,"start_character":47,"end_line":26,"end_character":12},"updated":"2020-01-30 21:46:57.000000000","message":"there are plenty of frameworks that can be used such as heat or just ansible to automate this. the cumbersomeness of this has not changed in the last 5+ years since we intoduced vnic types.\n\na better argument is the fact that when nova create ports on behalf of the tenant they get cleaned up automatically when the vm is deleted preventing the ports form leaking and consoming quota if you forget to do it manually.","commit_id":"a12a664af839be19fd2b3741500c4499c045d8b8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd8ed770e86fb33de088f371d0e9c68163e4b911","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Alternatives"},{"line_number":41,"context_line":"------------"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Create it in two steps, first create a port of type ``direct``"},{"line_number":44,"context_line":"or ``macvtap``, then start the server with the created port."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Data model impact"},{"line_number":47,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_9ce1eb34","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":60},"updated":"2020-01-30 21:46:57.000000000","message":"yes that is what we do today which was what we agreed on when we first added support for sriov \n\nhttps://github.com/openstack/nova-specs/blob/master/specs/juno/implemented/pci-passthrough-sriov.rst#problem-description\n\nwe discussed allowing the vnic_type as part of the nova boot request when we were debating that spec but at the time the decision was no partly becasue it could not be support by nova network and partly to avoid proxying adtional functionality form neutron","commit_id":"a12a664af839be19fd2b3741500c4499c045d8b8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b173fd0ab68739fcd367abd703564e59df21c496","unresolved":false,"context_lines":[{"line_number":74,"context_line":"Only show new parameters\u0027 JSON schema definition for body data of ``server`` ::"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  \u0027vnic_type\u0027: [\u0027normal\u0027, \u0027macvtap\u0027, \u0027direct\u0027, \u0027baremetal\u0027,"},{"line_number":77,"context_line":"                \u0027direct-physical\u0027, \u0027virtio-forwarder\u0027, \u0027smart-nic\u0027]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Depending on whether/how the ``vnic_type`` is set, the actions are as"},{"line_number":80,"context_line":"followed:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_59595efa","line":77,"range":{"start_line":77,"start_character":56,"end_line":77,"end_character":65},"updated":"2019-11-04 22:21:19.000000000","message":"Where does this come from? Inspur proprietary? Because it\u0027s not in nova/network/model.py.","commit_id":"a12a664af839be19fd2b3741500c4499c045d8b8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd8ed770e86fb33de088f371d0e9c68163e4b911","unresolved":false,"context_lines":[{"line_number":74,"context_line":"Only show new parameters\u0027 JSON schema definition for body data of ``server`` ::"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  \u0027vnic_type\u0027: [\u0027normal\u0027, \u0027macvtap\u0027, \u0027direct\u0027, \u0027baremetal\u0027,"},{"line_number":77,"context_line":"                \u0027direct-physical\u0027, \u0027virtio-forwarder\u0027, \u0027smart-nic\u0027]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Depending on whether/how the ``vnic_type`` is set, the actions are as"},{"line_number":80,"context_line":"followed:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_9cf7ab29","line":77,"range":{"start_line":77,"start_character":56,"end_line":77,"end_character":65},"in_reply_to":"3fa7e38b_590e3ee4","updated":"2020-01-30 21:46:57.000000000","message":"the support vnic types are defiend by \nhttps://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/portbindings.py#L111-L121\n\nits for smart-nics on ironic hosts.\nwe do not have nova integration for it currently.","commit_id":"a12a664af839be19fd2b3741500c4499c045d8b8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0d57b5c54fc632990638cd1ec02dd2968aef34c9","unresolved":false,"context_lines":[{"line_number":74,"context_line":"Only show new parameters\u0027 JSON schema definition for body data of ``server`` ::"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  \u0027vnic_type\u0027: [\u0027normal\u0027, \u0027macvtap\u0027, \u0027direct\u0027, \u0027baremetal\u0027,"},{"line_number":77,"context_line":"                \u0027direct-physical\u0027, \u0027virtio-forwarder\u0027, \u0027smart-nic\u0027]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Depending on whether/how the ``vnic_type`` is set, the actions are as"},{"line_number":80,"context_line":"followed:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_590e3ee4","line":77,"range":{"start_line":77,"start_character":56,"end_line":77,"end_character":65},"in_reply_to":"3fa7e38b_59595efa","updated":"2019-11-04 22:22:49.000000000","message":"Oh I guess it\u0027s in the neutron API reference even though nova doesn\u0027t use smart-nic:\n\nhttps://docs.openstack.org/api-ref/network/v2/index.html?expanded\u003dcreate-port-detail#create-port","commit_id":"a12a664af839be19fd2b3741500c4499c045d8b8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd8ed770e86fb33de088f371d0e9c68163e4b911","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* Add ``vnic_type`` support in create server API."},{"line_number":144,"context_line":"* Add ``vnic-type`` support for \u0027openstack server create"},{"line_number":145,"context_line":"  --nic vnic-type\u003d\u003cvnic-type\u003e\u0027 in openstackclient."},{"line_number":146,"context_line":"* Add ``vnic-type`` support for \u0027nova boot --nic"},{"line_number":147,"context_line":"  vnic-type\u003d\u003cvnic-type\u003e\u0027 in novaclient."},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_1c341be0","line":145,"range":{"start_line":145,"start_character":2,"end_line":145,"end_character":30},"updated":"2020-01-30 21:46:57.000000000","message":"ya so this is basicaly what i proposed in the past when the \"get me a network\" work was being done when i argured we shoudl support get me a port.\n\nthis would make sriov eaiser to use however this was seen as a slipery slope to then haveing to support qos, vlan transparncy or any of the other neutorn port paramaters.\n\nif it is just vnic_type i would ok with this change but i dont really think we should continue to extend the feature set we proxy via nova on behalf of neutron.","commit_id":"a12a664af839be19fd2b3741500c4499c045d8b8"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"368ac4c9973ee1b16177148cd9eb1509cdc9cc96","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Other contributors:"},{"line_number":139,"context_line":"  zhangbailin, qinhaizhong"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Work Items"},{"line_number":142,"context_line":"----------"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3fa7e38b_90ab5cd2","line":140,"updated":"2020-02-12 12:54:59.000000000","message":"Add below section:\n\nFeature Liaison\n---------------\n\nFeature liaison:\n  Liaison Needed","commit_id":"215a86a427d48a6e3ab2819b06529555e701f454"}]}