)]}'
{"specs/stein/implemented/conf-max-attach-volumes.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb6ace62cf33bb68b6e1617ee9dac18fd90ceeb4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"When a user attempts to attach more than 26 disk devices with the libvirt"},{"line_number":45,"context_line":"driver, the attach fails in the ``reserve_block_device_name`` method in"},{"line_number":46,"context_line":"nova-compute, which is eventually called by the ``attach_volume`` method in"},{"line_number":47,"context_line":"nova-api. The ``reserve_block_device_name`` method calls"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_253a6c98","line":44,"range":{"start_line":44,"start_character":43,"end_line":44,"end_character":44},"updated":"2019-09-26 15:53:21.000000000","message":"nit: technically it\u0027s non-ide disk devices:\n\nhttps://opendev.org/openstack/nova/src/tag/18.0.0/nova/virt/libvirt/blockinfo.py#L162\n\nI\u0027m not sure that you need to go into that level of detail though.","commit_id":"b2398becc3ecd8ce4738165ccd0cb9f1aea3bbd6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb6ace62cf33bb68b6e1617ee9dac18fd90ceeb4","unresolved":false,"context_lines":[{"line_number":64,"context_line":"the maximum has been exceeded, the server will go into the ``ERROR`` state and"},{"line_number":65,"context_line":"the server fault message will indicate the failure reason."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Note that the limit in the libvirt driver is actually on the total number of"},{"line_number":68,"context_line":"disk devices allowed to attach to a single instance including the root disk"},{"line_number":69,"context_line":"and any other disks. It does not differentiate between volumes and other disks."},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_453d288d","line":67,"updated":"2019-09-26 15:53:21.000000000","message":"You could link to this in the code as a reference:\n\nhttps://opendev.org/openstack/nova/src/tag/19.0.0/nova/virt/libvirt/blockinfo.py#L150","commit_id":"b2398becc3ecd8ce4738165ccd0cb9f1aea3bbd6"}]}