)]}'
{"id":"openstack%2Fnova-specs~686232","triplet_id":"openstack%2Fnova-specs~master~Ice4d23b1397e97d4f39a9d8c9f01ee2ac1534ce0","project":"openstack/nova-specs","branch":"master","topic":"bp/https","hashtags":[],"change_id":"Ice4d23b1397e97d4f39a9d8c9f01ee2ac1534ce0","subject":"Add image-precache-support spec","status":"MERGED","created":"2019-10-02 18:12:52.000000000","updated":"2019-10-04 14:03:10.000000000","submitted":"2019-10-04 14:00:45.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":99,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"686232-1570197645674-244dc94e","meta_rev_id":"53b49eb278ca2137242c2f38f1654bfe6347585c","_number":686232,"virtual_id_number":686232,"owner":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2019-10-04 13:45:02.000000000","_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-04 14:00:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"recommended":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":1,"date":"2019-10-03 13:55:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":1,"date":"2019-10-04 04:03:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":1,"date":"2019-10-03 19:08:01.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":2,"date":"2019-10-03 22:18:00.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":2,"date":"2019-10-02 20:51:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-10-04 10:54:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":1,"date":"2019-10-04 13:46:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-03 13:55:33.000000000","updated_by":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"reviewer":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"state":"REVIEWER"},{"updated":"2019-10-03 19:08:01.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2019-10-03 22:18:00.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-10-04 04:03:32.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-10-04 10:54:09.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2019-10-04 13:46:53.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-10-04 14:00:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"55bf3933e6b8f1ad7569e531b2c81985a057fae1","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-10-02 18:12:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cc6bae74769a932c396f292511c55b30c043d7c3","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-10-02 18:17:31.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"02822b3ff6efc426e51cee5204c7a0ece295e454","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 18:33:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1ff25d3ec3c54127a80a7f8be8b43ac4 : SUCCESS in 13m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b7bd703cf340411586ea99eb38240bce : SUCCESS in 3m 16s","accounts_in_message":[],"_revision_number":1},{"id":"8cc0df9e56a8d05873367dae74088b82a7c89d8e","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-10-02 18:39:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9ef4281fa1f9491def811aac7513ce2ffa640c3d","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2019-10-02 18:40:30.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"a06f8f21e035b7ec6a3f1e7505bf0066debc16f5","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2019-10-02 18:54:44.000000000","message":"Patch Set 2: Code-Review-1\n\nCouple of questions, -1 for visibility:\n\nWhile keeping in mind that this is an MVP, so we\u0027re keeping the scope deliberately small and basic, I do have a couple of questions that I think are worth answering in the spec:\n\n* What if a compute host is down? Presumably the answer is \"nothing - it just won\u0027t cache the image(s) - after all, we this is async, 202 accepted, not 200 OK.\"\n\n* What if the compute host is *already* pre-caching images when a second request to pre-cache the same image(s) arrives? I don\u0027t know the imagecache well enough, is it reentrant in this way?","accounts_in_message":[],"_revision_number":2},{"id":"1bb3eafe622ec22a0700d842051d47a755482e2e","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-02 18:55:59.000000000","message":"Patch Set 1:\n\n(26 comments)\n\nLots of comments and questions. I\u0027m not sure if PS2 already fixed the bullet list formatting issue I noted.","accounts_in_message":[],"_revision_number":1},{"id":"0116e4250070555fc65ec0a20abf92f48b5395c3","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-02 18:57:22.000000000","message":"Patch Set 2: Code-Review-1","accounts_in_message":[],"_revision_number":2},{"id":"1c2b51a6ef9954f703c3a942fd3935c792660939","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 18:57:38.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/88c2ebd4b7404c57b1e2acdbc6946ce1 : SUCCESS in 10m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d48bfff4404642628d91e7801eed1346 : SUCCESS in 5m 22s","accounts_in_message":[],"_revision_number":2},{"id":"feaa7fcc7b27244e00f27e01d83866dadfaaec7c","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-02 18:57:45.000000000","message":"Patch Set 2:\n\nOverall I\u0027m pretty good with this, just needs to answer some questions on the details, some of which are implementation.","accounts_in_message":[],"_revision_number":2},{"id":"0a69707ef8246a90c368e2702b837852174229b2","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2019-10-02 19:03:32.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"9a5f9eef58dfb6909bb68ba0ab8707365b29c4eb","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-10-02 19:09:58.000000000","message":"Patch Set 1:\n\n(12 comments)\n\nThanks guys!","accounts_in_message":[],"_revision_number":1},{"id":"2acd1c96d46de922ff75ff491d2745f761b73cd9","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-02 19:29:36.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e11fd49c0659a3265e9368e5bcc459bbbe5a55ec","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-10-02 19:30:59.000000000","message":"Patch Set 1:\n\n(5 comments)","accounts_in_message":[],"_revision_number":1},{"id":"0c69cc2c99ea7dc21448dd45df992ab3e91b1c31","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-10-02 19:31:09.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c24c450b35a62505f74502e3d1651e223c8f9632","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-10-02 19:39:08.000000000","message":"Patch Set 1:\n\n\u003e * What if a compute host is down? Presumably the answer is \"nothing\n \u003e - it just won\u0027t cache the image(s) - after all, we this is async,\n \u003e 202 accepted, not 200 OK.\"\n\nWell, I think that we should be synchronous in the initial case for throttling, so this is a good point. We don\u0027t want to block for a minute on all the downed computes, ideally. So, I dunno. We could check the service up-ness on each one before we call?\n\n \u003e * What if the compute host is *already* pre-caching images when a\n \u003e second request to pre-cache the same image(s) arrives? I don\u0027t know\n \u003e the imagecache well enough, is it reentrant in this way?\n\nAh, yeah, I should have put that in here. I\u0027m definitely assuming you basically chuck this into cron and run it periodically so that the expiry still runs for the images you don\u0027t care about.","accounts_in_message":[],"_revision_number":1},{"id":"da095f73f2d6e28f596efe15b713dc1a22c2f977","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-10-02 19:43:01.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"e7794014918461b7e6a76d1fd76f407c8ef44d82","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2019-10-02 20:00:32.000000000","message":"Patch Set 4:\n\n(2 comments)\n\n\u003e \u003e * What if the compute host is *already* pre-caching images when a\n \u003e \u003e second request to pre-cache the same image(s) arrives? I don\u0027t\n \u003e know\n \u003e \u003e the imagecache well enough, is it reentrant in this way?\n \u003e \n \u003e Ah, yeah, I should have put that in here. I\u0027m definitely assuming\n \u003e you basically chuck this into cron and run it periodically so that\n \u003e the expiry still runs for the images you don\u0027t care about.\n\nI actually meant: what if a request to download an image comes in while it\u0027s already being downloaded, because in my cast/async understanding of this, it was possible. But if we\u0027re doing the sync/call, then it\u0027s a non-issue.","accounts_in_message":[],"_revision_number":4},{"id":"c703cf7444ceb6bd243d2930e854589507df31ba","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-10-02 20:03:22.000000000","message":"Patch Set 4:\n\n\u003e I actually meant: what if a request to download an image comes in\n \u003e while it\u0027s already being downloaded, because in my cast/async\n \u003e understanding of this, it was possible. But if we\u0027re doing the\n \u003e sync/call, then it\u0027s a non-issue.\n\nAh, well, that\u0027s another case, and being synchronous in our RPC activities wouldn\u0027t prevent another API call from coming in. I think there\u0027s an image cache lock which would prevent the double-download (which would happen during boot if not) but I\u0027ll check.","accounts_in_message":[],"_revision_number":4},{"id":"829651e100f733bfa1adfdbdcfe72c6f00ca6848","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 20:06:36.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/07c27c11f82148af8ef3e2f9b8141e07 : SUCCESS in 12m 15s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0a673dfa8bde4163b1dff9c33e1415ab : SUCCESS in 4m 49s","accounts_in_message":[],"_revision_number":4},{"id":"1978e04fe66ba3d204805536b51f144a8e55e85d","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-02 20:14:01.000000000","message":"Patch Set 4: Code-Review-1\n\n(10 comments)","accounts_in_message":[],"_revision_number":4},{"id":"42d403d7e383698892e8ebb564d4938e2f5ddc4a","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-10-02 20:23:22.000000000","message":"Patch Set 4:\n\n(5 comments)","accounts_in_message":[],"_revision_number":4},{"id":"240554759bc10550f01988f8af540528ec5aa31b","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-02 20:28:30.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"7ad26dbd819b408c0133cfc5c29427a0a7b9e139","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-10-02 20:29:01.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"af03dfb8beafee235c8b49a8f15661964481d68c","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-10-02 20:35:06.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"de798916d7e88b7b2b8f7d9178ba9d0588888736","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-02 20:51:29.000000000","message":"Patch Set 5: Code-Review+2\n\n(3 comments)\n\nMy comments have been addressed. I think this looks good enough to get started and hash out the implementation details in code review. Clearly this is a long-requested feature and Rackspace public cloud did their own thing for this in years past and at least Workday is doing something with a custom API extension for this today, plus the other stuff people are doing with pre-caching using ansible and loading computes with a throwaway VM etc - all workarounds with varying levels of nastiness. This is a nice MVP solution which gives us a start on which we could build more complexity later if necessary and should have a high probability of actually landing in Ussuri.","accounts_in_message":[],"_revision_number":5},{"id":"0b459b1567a4b7688addd1ca6b6d49ffd0285d42","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-10-02 20:53:26.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"e8dfba7319fc7053ac162fae67a210f4b615d1dc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 20:54:14.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b2548d345aff46399330616cfa729229 : SUCCESS in 12m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e5c085deb5234bd6b4efb21daaa546f4 : SUCCESS in 5m 32s","accounts_in_message":[],"_revision_number":5},{"id":"0f38fb2acec9e57fab382e85c3665ce1e62bb75a","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2019-10-03 13:55:33.000000000","message":"Patch Set 5: Code-Review+1\n\nThe words about checking for a down compute before making the call have been disappeared, and the double-download niggle needs to be resolved, but than can be hashed out in implementation.","accounts_in_message":[],"_revision_number":5},{"id":"137947e6ae95973a8abf31a85ac305b2a8a91460","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2019-10-03 17:18:26.000000000","message":"Patch Set 5:\n\n\u003e and the double-download niggle needs to be\n \u003e resolved, but than can be hashed out in implementation.\n\nFrom IRC:\n\n\u003cdansmith\u003e artom: ack, then it\u0027s already handled by a lock.. I looked it up but didn\u0027t call it out in the spec because it\u0027s existing","accounts_in_message":[],"_revision_number":5},{"id":"3ca4a7141b0a654fd10d63fc894e6d54d93016a6","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-03 17:21:23.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"936b1a3091b32a5fb2456d2f1a42d62cabb0c322","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-10-03 18:54:01.000000000","message":"Patch Set 5:\n\n(11 comments)","accounts_in_message":[],"_revision_number":5},{"id":"2a09c68fbfa3a2cbc95e940bc2e9601a67ac0670","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-10-03 19:08:01.000000000","message":"Patch Set 5: Code-Review+1\n\ngive our irc conversation im happy to chagne form +0.5 to +1\nnone of the comment i mentioned inline could not be addressed in a futrue release so this makes sense to me as an mvp provide we document the edgecases.","accounts_in_message":[],"_revision_number":5},{"id":"aab0b9773794b93febb93abb488846595c3e1e13","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-10-03 19:09:53.000000000","message":"Patch Set 5:\n\n(6 comments)","accounts_in_message":[],"_revision_number":5},{"id":"0634689ac6c7c232bda393e055ed87b79fff5639","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-10-03 22:18:00.000000000","message":"Patch Set 5: Code-Review+2\n\n(4 comments)\n\nI approve the Definition (\"If we\u0027re going to do this, let\u0027s do it this way\")\n\nLeaving open to give other reviewers a shot.","accounts_in_message":[],"_revision_number":5},{"id":"2fd11a4844dd7e3e0ed391cd7efc657990fd0dc6","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-10-04 04:03:32.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"ddf1d5f2ceefecac81f2c675f130ae4fc4917188","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-10-04 10:54:09.000000000","message":"Patch Set 5: Code-Review+2\n\nMake sense to me.","accounts_in_message":[],"_revision_number":5},{"id":"a38cf12d2d9ff3b7040c539605fc26702b1ed175","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-10-04 13:45:02.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"b56881765ff02f6f02097b05d6493b1babf632fa","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-04 13:46:53.000000000","message":"Patch Set 5: Workflow+1\n\n(1 comment)\n\nLooks like we have enough to merge this and get going.","accounts_in_message":[],"_revision_number":5},{"id":"38983c0b9d413bc367e2d6cb2ec5ca0964ded82a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-04 13:47:05.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"93d74bfd03ef88983cdd6a7050a15a74feed62a8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-04 14:00:45.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5},{"id":"9d64facd6c20ae8b6877b061b98e1fc467e9a9a9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-04 14:00:45.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e03271a0602f406880a47bd085b3c38f : SUCCESS in 8m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/98158c86e83e4127907dae60ee1e1344 : SUCCESS in 3m 29s","accounts_in_message":[],"_revision_number":5},{"id":"935106df7b16442b240da17678741a68e30e108b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-04 14:03:10.000000000","message":"Patch Set 5:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-specs https://zuul.opendev.org/t/openstack/build/ffd3bc8a19bb45939df6719684d4098b : SUCCESS in 1m 48s","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"fbfb289679267e72903fedb97614b586ac0d79bc","revisions":{"743861292b8155ee3f184876f9b71d4b72f2c881":{"kind":"REWORK","_number":1,"created":"2019-10-02 18:12:52.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/32/686232/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/32/686232/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/1"}}},"commit":{"parents":[{"commit":"5f16a02137f8fadd4891ff539ff100fa9f358add","subject":"Fix invalid link index","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/5f16a02137f8fadd4891ff539ff100fa9f358add"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2019-10-02 18:12:09.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2019-10-02 18:12:39.000000000","tz":-420},"subject":"Add image-precache-support spec","message":"Add image-precache-support spec\n\nNova supports caching images on demand at the compute node level for\nperformance reasons, but provides no ability to schedule that activity\nbefore a rollout or maintenance window. This long-requested feature\nbecomes even more important when considering Edge Computing\nenvironments, limited bandwidth, as well as high-scale rapid\napplication deployment.\n\nChange-Id: Ice4d23b1397e97d4f39a9d8c9f01ee2ac1534ce0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/743861292b8155ee3f184876f9b71d4b72f2c881"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/743861292b8155ee3f184876f9b71d4b72f2c881"}]},"branch":"refs/heads/master"},"792059b3b466edfc2e4712fa605bd76b2c550632":{"kind":"REWORK","_number":2,"created":"2019-10-02 18:39:59.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/32/686232/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/32/686232/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/2"}}},"commit":{"parents":[{"commit":"5f16a02137f8fadd4891ff539ff100fa9f358add","subject":"Fix invalid link index","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/5f16a02137f8fadd4891ff539ff100fa9f358add"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2019-10-02 18:12:09.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2019-10-02 18:39:56.000000000","tz":-420},"subject":"Add image-precache-support spec","message":"Add image-precache-support spec\n\nNova supports caching images on demand at the compute node level for\nperformance reasons, but provides no ability to schedule that activity\nbefore a rollout or maintenance window. This long-requested feature\nbecomes even more important when considering Edge Computing\nenvironments, limited bandwidth, as well as high-scale rapid\napplication deployment.\n\nChange-Id: Ice4d23b1397e97d4f39a9d8c9f01ee2ac1534ce0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/792059b3b466edfc2e4712fa605bd76b2c550632"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/792059b3b466edfc2e4712fa605bd76b2c550632"}]},"branch":"refs/heads/master"},"cb2ca4424696c3acd053913df9d84612a6ed27d3":{"kind":"REWORK","_number":3,"created":"2019-10-02 19:31:09.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/32/686232/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/32/686232/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/3"}}},"commit":{"parents":[{"commit":"5f16a02137f8fadd4891ff539ff100fa9f358add","subject":"Fix invalid link index","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/5f16a02137f8fadd4891ff539ff100fa9f358add"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2019-10-02 18:12:09.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2019-10-02 19:31:05.000000000","tz":-420},"subject":"Add image-precache-support spec","message":"Add image-precache-support spec\n\nNova supports caching images on demand at the compute node level for\nperformance reasons, but provides no ability to schedule that activity\nbefore a rollout or maintenance window. This long-requested feature\nbecomes even more important when considering Edge Computing\nenvironments, limited bandwidth, as well as high-scale rapid\napplication deployment.\n\nChange-Id: Ice4d23b1397e97d4f39a9d8c9f01ee2ac1534ce0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/cb2ca4424696c3acd053913df9d84612a6ed27d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/cb2ca4424696c3acd053913df9d84612a6ed27d3"}]},"branch":"refs/heads/master"},"ad82f9ed954307efae535f3a07a06191de9a4f36":{"kind":"REWORK","_number":4,"created":"2019-10-02 19:43:01.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/32/686232/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/32/686232/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/4"}}},"commit":{"parents":[{"commit":"5f16a02137f8fadd4891ff539ff100fa9f358add","subject":"Fix invalid link index","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/5f16a02137f8fadd4891ff539ff100fa9f358add"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2019-10-02 18:12:09.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2019-10-02 19:42:57.000000000","tz":-420},"subject":"Add image-precache-support spec","message":"Add image-precache-support spec\n\nNova supports caching images on demand at the compute node level for\nperformance reasons, but provides no ability to schedule that activity\nbefore a rollout or maintenance window. This long-requested feature\nbecomes even more important when considering Edge Computing\nenvironments, limited bandwidth, as well as high-scale rapid\napplication deployment.\n\nChange-Id: Ice4d23b1397e97d4f39a9d8c9f01ee2ac1534ce0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/ad82f9ed954307efae535f3a07a06191de9a4f36"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/ad82f9ed954307efae535f3a07a06191de9a4f36"}]},"branch":"refs/heads/master"},"fbfb289679267e72903fedb97614b586ac0d79bc":{"kind":"REWORK","_number":5,"created":"2019-10-02 20:35:06.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/32/686232/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/32/686232/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/32/686232/5"}}},"commit":{"parents":[{"commit":"5f16a02137f8fadd4891ff539ff100fa9f358add","subject":"Fix invalid link index","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/5f16a02137f8fadd4891ff539ff100fa9f358add"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2019-10-02 18:12:09.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2019-10-02 20:34:48.000000000","tz":-420},"subject":"Add image-precache-support spec","message":"Add image-precache-support spec\n\nNova supports caching images on demand at the compute node level for\nperformance reasons, but provides no ability to schedule that activity\nbefore a rollout or maintenance window. This long-requested feature\nbecomes even more important when considering Edge Computing\nenvironments, limited bandwidth, as well as high-scale rapid\napplication deployment.\n\nAPIImpact\n\nRelated to blueprint https://blueprints.launchpad.net/nova/+spec/image-precache-support\n\nChange-Id: Ice4d23b1397e97d4f39a9d8c9f01ee2ac1534ce0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/fbfb289679267e72903fedb97614b586ac0d79bc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/fbfb289679267e72903fedb97614b586ac0d79bc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}