)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ya.wang \u003cwang.ya@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-11 15:35:43 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add spec for live migration no performance impact."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I474826eadde4ac47aa4b89e1b7fbffdfe39a4e11"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_49437e12","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":50},"updated":"2019-11-12 16:19:00.000000000","message":"Suggest to write a small summary of the spec in the commit:\n\n  Add \"live migration without performance impact\" spec.\n\n  This spec proposes a way to selectively disable live\n  migration-related features, post-copy and auto-converge. \n  It is useful for guest workloads that cannot tolerate any \n  potential performance impact.","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"de35c96b91f38821fae893e8aadeda1d2e1050ec","unresolved":false,"context_lines":[{"line_number":10,"context_line":"features which will slow down guest performance."},{"line_number":11,"context_line":"It is useful for guest workloads that can\u0027t tolerate any potential"},{"line_number":12,"context_line":"performance impact."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I474826eadde4ac47aa4b89e1b7fbffdfe39a4e11"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_6602030f","line":13,"updated":"2020-01-20 03:15:24.000000000","message":"Lack of the \"APIImpact\" tag.","commit_id":"2f99f5edff11f1ba06e81ed443ae9d7940e5edfd"}],"specs/ussuri/approved/live-migration-no-performance-impact.rst":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Live migration no performance impact"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/live-migration-no-performance-impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_49905e97","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":36},"updated":"2019-11-12 16:19:00.000000000","message":"Suggest: \"Live migration without performance impact\"","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Live migration no performance impact"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/live-migration-no-performance-impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_e17a7a23","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":36},"in_reply_to":"3fa7e38b_49905e97","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Auto converge and post copy are features from QEMU, for living migration can be"},{"line_number":17,"context_line":"completed. Auto converge will slow down the CPU speed and memory I/O speed to"},{"line_number":18,"context_line":"ensure memory can be copied to destination node. Post copy will boot an"},{"line_number":19,"context_line":"instance at destination node and access the memory from source node remotely."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_5681d99f","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":27},"updated":"2019-11-12 16:19:00.000000000","message":"Consistency nit: \"Auto-converge and \"post-copy\".\n\n(All occurrences.)","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Auto converge and post copy are features from QEMU, for living migration can be"},{"line_number":17,"context_line":"completed. Auto converge will slow down the CPU speed and memory I/O speed to"},{"line_number":18,"context_line":"ensure memory can be copied to destination node. Post copy will boot an"},{"line_number":19,"context_line":"instance at destination node and access the memory from source node remotely."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_0176b640","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":27},"in_reply_to":"3fa7e38b_5681d99f","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Auto converge and post copy are features from QEMU, for living migration can be"},{"line_number":17,"context_line":"completed. Auto converge will slow down the CPU speed and memory I/O speed to"},{"line_number":18,"context_line":"ensure memory can be copied to destination node. Post copy will boot an"},{"line_number":19,"context_line":"instance at destination node and access the memory from source node remotely."},{"line_number":20,"context_line":"Currently auto converge and post copy can only be enabled/disabled via"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_960e718a","line":17,"range":{"start_line":16,"start_character":50,"end_line":17,"end_character":9},"updated":"2019-11-12 16:19:00.000000000","message":"\" that allow long-running live migration jobs to complete successfully.\"","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Auto converge and post copy are features from QEMU, for living migration can be"},{"line_number":17,"context_line":"completed. Auto converge will slow down the CPU speed and memory I/O speed to"},{"line_number":18,"context_line":"ensure memory can be copied to destination node. Post copy will boot an"},{"line_number":19,"context_line":"instance at destination node and access the memory from source node remotely."},{"line_number":20,"context_line":"Currently auto converge and post copy can only be enabled/disabled via"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_21965240","line":17,"range":{"start_line":16,"start_character":50,"end_line":17,"end_character":9},"in_reply_to":"3fa7e38b_960e718a","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Auto converge and post copy are features from QEMU, for living migration can be"},{"line_number":17,"context_line":"completed. Auto converge will slow down the CPU speed and memory I/O speed to"},{"line_number":18,"context_line":"ensure memory can be copied to destination node. Post copy will boot an"},{"line_number":19,"context_line":"instance at destination node and access the memory from source node remotely."},{"line_number":20,"context_line":"Currently auto converge and post copy can only be enabled/disabled via"},{"line_number":21,"context_line":"configuration, which means the configurations will effect all instance on the"},{"line_number":22,"context_line":"host during live migration."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_76b5f57d","line":19,"range":{"start_line":19,"start_character":9,"end_line":19,"end_character":76},"updated":"2019-11-12 16:19:00.000000000","message":"\"on the destination node and access the guest memory from the source node on-demand\"","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Auto converge and post copy are features from QEMU, for living migration can be"},{"line_number":17,"context_line":"completed. Auto converge will slow down the CPU speed and memory I/O speed to"},{"line_number":18,"context_line":"ensure memory can be copied to destination node. Post copy will boot an"},{"line_number":19,"context_line":"instance at destination node and access the memory from source node remotely."},{"line_number":20,"context_line":"Currently auto converge and post copy can only be enabled/disabled via"},{"line_number":21,"context_line":"configuration, which means the configurations will effect all instance on the"},{"line_number":22,"context_line":"host during live migration."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_61da0a1e","line":19,"range":{"start_line":19,"start_character":9,"end_line":19,"end_character":76},"in_reply_to":"3fa7e38b_76b5f57d","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"ensure memory can be copied to destination node. Post copy will boot an"},{"line_number":19,"context_line":"instance at destination node and access the memory from source node remotely."},{"line_number":20,"context_line":"Currently auto converge and post copy can only be enabled/disabled via"},{"line_number":21,"context_line":"configuration, which means the configurations will effect all instance on the"},{"line_number":22,"context_line":"host during live migration."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"If an application which sensitive to reduced performance (some scientific"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_b65fed73","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":13},"updated":"2019-11-12 16:19:00.000000000","message":"\"configuration\" --\u003e \"configuration attribute on compute nodes\"","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"ensure memory can be copied to destination node. Post copy will boot an"},{"line_number":19,"context_line":"instance at destination node and access the memory from source node remotely."},{"line_number":20,"context_line":"Currently auto converge and post copy can only be enabled/disabled via"},{"line_number":21,"context_line":"configuration, which means the configurations will effect all instance on the"},{"line_number":22,"context_line":"host during live migration."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"If an application which sensitive to reduced performance (some scientific"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_9683d1cb","line":21,"range":{"start_line":21,"start_character":62,"end_line":21,"end_character":70},"updated":"2019-11-12 16:19:00.000000000","message":"s/instance/instances/","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":18,"context_line":"ensure memory can be copied to destination node. Post copy will boot an"},{"line_number":19,"context_line":"instance at destination node and access the memory from source node remotely."},{"line_number":20,"context_line":"Currently auto converge and post copy can only be enabled/disabled via"},{"line_number":21,"context_line":"configuration, which means the configurations will effect all instance on the"},{"line_number":22,"context_line":"host during live migration."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"If an application which sensitive to reduced performance (some scientific"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_81ddc614","line":21,"range":{"start_line":21,"start_character":62,"end_line":21,"end_character":70},"in_reply_to":"3fa7e38b_9683d1cb","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":18,"context_line":"ensure memory can be copied to destination node. Post copy will boot an"},{"line_number":19,"context_line":"instance at destination node and access the memory from source node remotely."},{"line_number":20,"context_line":"Currently auto converge and post copy can only be enabled/disabled via"},{"line_number":21,"context_line":"configuration, which means the configurations will effect all instance on the"},{"line_number":22,"context_line":"host during live migration."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"If an application which sensitive to reduced performance (some scientific"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_21e412e0","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":13},"in_reply_to":"3fa7e38b_b65fed73","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"configuration, which means the configurations will effect all instance on the"},{"line_number":22,"context_line":"host during live migration."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"If an application which sensitive to reduced performance (some scientific"},{"line_number":25,"context_line":"computing applications may be more sensitive to memory access latency), and"},{"line_number":26,"context_line":"the instance is on a host with these options enabled, live migration may cause"},{"line_number":27,"context_line":"the application to raise an error. Therefore, the user wants to control whether"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_d6f06969","line":24,"range":{"start_line":24,"start_character":18,"end_line":24,"end_character":23},"updated":"2019-11-12 16:19:00.000000000","message":"s/which/is/","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":21,"context_line":"configuration, which means the configurations will effect all instance on the"},{"line_number":22,"context_line":"host during live migration."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"If an application which sensitive to reduced performance (some scientific"},{"line_number":25,"context_line":"computing applications may be more sensitive to memory access latency), and"},{"line_number":26,"context_line":"the instance is on a host with these options enabled, live migration may cause"},{"line_number":27,"context_line":"the application to raise an error. Therefore, the user wants to control whether"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_e1cd9a5e","line":24,"range":{"start_line":24,"start_character":18,"end_line":24,"end_character":23},"in_reply_to":"3fa7e38b_d6f06969","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"If an application which sensitive to reduced performance (some scientific"},{"line_number":25,"context_line":"computing applications may be more sensitive to memory access latency), and"},{"line_number":26,"context_line":"the instance is on a host with these options enabled, live migration may cause"},{"line_number":27,"context_line":"the application to raise an error. Therefore, the user wants to control whether"},{"line_number":28,"context_line":"to enable/disable auto converge or post copy during live migration."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_f6fa4541","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":12},"updated":"2019-11-12 16:19:00.000000000","message":"\"the instance\" --\u003e \"the instance running the application\"","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"If an application which sensitive to reduced performance (some scientific"},{"line_number":25,"context_line":"computing applications may be more sensitive to memory access latency), and"},{"line_number":26,"context_line":"the instance is on a host with these options enabled, live migration may cause"},{"line_number":27,"context_line":"the application to raise an error. Therefore, the user wants to control whether"},{"line_number":28,"context_line":"to enable/disable auto converge or post copy during live migration."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_01c9d64f","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":12},"in_reply_to":"3fa7e38b_f6fa4541","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"---------"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* As an administrator, I want the user can tag the instance request no"},{"line_number":34,"context_line":"  performance impact themselves."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* As an operator, I want the live migrate success and not take too long time."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_16a4c14a","line":34,"range":{"start_line":33,"start_character":23,"end_line":34,"end_character":31},"updated":"2019-11-12 16:19:00.000000000","message":"\"I want the user to be able to tag an instance to not have performance impact due to live migration options\".","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"---------"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* As an administrator, I want the user can tag the instance request no"},{"line_number":34,"context_line":"  performance impact themselves."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* As an operator, I want the live migrate success and not take too long time."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_e1691a26","line":34,"range":{"start_line":33,"start_character":23,"end_line":34,"end_character":31},"in_reply_to":"3fa7e38b_16a4c14a","updated":"2019-11-13 05:08:09.000000000","message":"\u003e \"I want the user to be able to tag an instance to not have\n \u003e performance impact due to live migration options\".\n\nThe usage of the tag is telling operator \"please use no-performance-impact parameter\" during live migrate to avoid performance impact, it\u0027s not means use the parameter mandatory and not affect any nova service internal. Operator may ignore it for higher priority operations.\n\nSo I think \u0027request\u0027 is a good word here.","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"* As an administrator, I want the user can tag the instance request no"},{"line_number":34,"context_line":"  performance impact themselves."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* As an operator, I want the live migrate success and not take too long time."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* As a user, I want the live migrate do not impact the performance for some"},{"line_number":39,"context_line":"  performance sensitive applications."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_d631490c","line":36,"range":{"start_line":36,"start_character":18,"end_line":36,"end_character":76},"updated":"2019-11-12 16:19:00.000000000","message":"This needs rephrasing.  The proposed \u0027no_performance_impact\u0027 is not guaranteeing \"success\" of live migration; it\u0027s removing potential performance due to auto-converge / post-copy.\n\nMaybe rephrase it to:\n\n\"As an operator, when possible, I want the live migration to succeed without incurring much performance penalty or taking too much time.\"","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":33,"context_line":"* As an administrator, I want the user can tag the instance request no"},{"line_number":34,"context_line":"  performance impact themselves."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* As an operator, I want the live migrate success and not take too long time."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* As a user, I want the live migrate do not impact the performance for some"},{"line_number":39,"context_line":"  performance sensitive applications."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_01d316d5","line":36,"range":{"start_line":36,"start_character":18,"end_line":36,"end_character":76},"in_reply_to":"3fa7e38b_d631490c","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* As an operator, I want the live migrate success and not take too long time."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* As a user, I want the live migrate do not impact the performance for some"},{"line_number":39,"context_line":"  performance sensitive applications."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_763895ed","line":39,"range":{"start_line":38,"start_character":13,"end_line":39,"end_character":36},"updated":"2019-11-12 16:19:00.000000000","message":"\"I want the live migration to not impact performance-sensitive guest workloads.\"","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* As an operator, I want the live migrate success and not take too long time."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* As a user, I want the live migrate do not impact the performance for some"},{"line_number":39,"context_line":"  performance sensitive applications."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_41d10ecc","line":39,"range":{"start_line":38,"start_character":13,"end_line":39,"end_character":36},"in_reply_to":"3fa7e38b_763895ed","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"This spec proposes to add no performance impact parameter to live migrate API"},{"line_number":45,"context_line":"call."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The request for ``POST /servers/{server_id}/action`` where action is"},{"line_number":48,"context_line":"\"os-migrateLive\" will get a new optional parameter called"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_d61aa97a","line":45,"range":{"start_line":44,"start_character":22,"end_line":45,"end_character":5},"updated":"2019-11-12 16:19:00.000000000","message":"\"add a parameter to avoid performance impact to live migration API call.\"","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"This spec proposes to add no performance impact parameter to live migrate API"},{"line_number":45,"context_line":"call."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The request for ``POST /servers/{server_id}/action`` where action is"},{"line_number":48,"context_line":"\"os-migrateLive\" will get a new optional parameter called"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_c1dc1ee3","line":45,"range":{"start_line":44,"start_character":22,"end_line":45,"end_character":5},"in_reply_to":"3fa7e38b_d61aa97a","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":".. note::"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    User can tag their instances as **no performance impact** via instance"},{"line_number":61,"context_line":"    metadata or somewhere else, then operator can check the tag to decide"},{"line_number":62,"context_line":"    whether add the new parameter before live migrate to avoid performance"},{"line_number":63,"context_line":"    impact during the live migration."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_c9ff6efe","line":60,"range":{"start_line":60,"start_character":36,"end_line":60,"end_character":62},"updated":"2019-11-12 16:19:00.000000000","message":"Please spell out the actual parameter: ``no_performance_impact``","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":".. note::"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    User can tag their instances as **no performance impact** via instance"},{"line_number":61,"context_line":"    metadata or somewhere else, then operator can check the tag to decide"},{"line_number":62,"context_line":"    whether add the new parameter before live migrate to avoid performance"},{"line_number":63,"context_line":"    impact during the live migration."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_a18fa2cb","line":60,"range":{"start_line":60,"start_character":36,"end_line":60,"end_character":62},"in_reply_to":"3fa7e38b_c9ff6efe","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":58,"context_line":".. note::"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    User can tag their instances as **no performance impact** via instance"},{"line_number":61,"context_line":"    metadata or somewhere else, then operator can check the tag to decide"},{"line_number":62,"context_line":"    whether add the new parameter before live migrate to avoid performance"},{"line_number":63,"context_line":"    impact during the live migration."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_69067a1f","line":61,"range":{"start_line":61,"start_character":16,"end_line":61,"end_character":30},"updated":"2019-11-12 16:19:00.000000000","message":"\"somewhere else\" is not helpful; please state where.","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":58,"context_line":".. note::"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    User can tag their instances as **no performance impact** via instance"},{"line_number":61,"context_line":"    metadata or somewhere else, then operator can check the tag to decide"},{"line_number":62,"context_line":"    whether add the new parameter before live migrate to avoid performance"},{"line_number":63,"context_line":"    impact during the live migration."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_24f0a0fd","line":61,"range":{"start_line":61,"start_character":16,"end_line":61,"end_character":30},"in_reply_to":"3fa7e38b_69067a1f","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    User can tag their instances as **no performance impact** via instance"},{"line_number":61,"context_line":"    metadata or somewhere else, then operator can check the tag to decide"},{"line_number":62,"context_line":"    whether add the new parameter before live migrate to avoid performance"},{"line_number":63,"context_line":"    impact during the live migration."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    The form of the tag will not be specified in this spec, which should be"},{"line_number":66,"context_line":"    negotiated by the administrator and operator, and inform the user how to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_8909762c","line":63,"range":{"start_line":62,"start_character":4,"end_line":63,"end_character":37},"updated":"2019-11-12 16:19:00.000000000","message":"\"[...] whether to add the new parameter before live migration starts, to avoid performance impact\"","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    User can tag their instances as **no performance impact** via instance"},{"line_number":61,"context_line":"    metadata or somewhere else, then operator can check the tag to decide"},{"line_number":62,"context_line":"    whether add the new parameter before live migrate to avoid performance"},{"line_number":63,"context_line":"    impact during the live migration."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    The form of the tag will not be specified in this spec, which should be"},{"line_number":66,"context_line":"    negotiated by the administrator and operator, and inform the user how to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_c18adeba","line":63,"range":{"start_line":62,"start_character":4,"end_line":63,"end_character":37},"in_reply_to":"3fa7e38b_8909762c","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    whether add the new parameter before live migrate to avoid performance"},{"line_number":63,"context_line":"    impact during the live migration."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    The form of the tag will not be specified in this spec, which should be"},{"line_number":66,"context_line":"    negotiated by the administrator and operator, and inform the user how to"},{"line_number":67,"context_line":"    use it."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_c94d2e72","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":58},"updated":"2019-11-12 16:19:00.000000000","message":"Maybe you can state an _example_ \"form\"?","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    whether add the new parameter before live migrate to avoid performance"},{"line_number":63,"context_line":"    impact during the live migration."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    The form of the tag will not be specified in this spec, which should be"},{"line_number":66,"context_line":"    negotiated by the administrator and operator, and inform the user how to"},{"line_number":67,"context_line":"    use it."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_64cf78b3","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":58},"in_reply_to":"3fa7e38b_c94d2e72","updated":"2019-11-13 05:08:09.000000000","message":"\u003e Maybe you can state an _example_ \"form\"?\n\nI think place this in document is better :)","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* Another method is to expose \"auto-converge\" and \"post-copy\" in API. [1]_"},{"line_number":73,"context_line":"  This can be worked, but it expose the features of hypervisor directly."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* We can expose \"auto-converge\" and \"post-copy\" in flavor extra specs and"},{"line_number":76,"context_line":"  image properties. [2]_ But it have same issues as above, even expose the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_e9190a7a","line":73,"range":{"start_line":73,"start_character":2,"end_line":73,"end_character":39},"updated":"2019-11-12 16:19:00.000000000","message":"\"This can work, but it exposes the\"","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":70,"context_line":"------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* Another method is to expose \"auto-converge\" and \"post-copy\" in API. [1]_"},{"line_number":73,"context_line":"  This can be worked, but it expose the features of hypervisor directly."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* We can expose \"auto-converge\" and \"post-copy\" in flavor extra specs and"},{"line_number":76,"context_line":"  image properties. [2]_ But it have same issues as above, even expose the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_01fc763d","line":73,"range":{"start_line":73,"start_character":2,"end_line":73,"end_character":39},"in_reply_to":"3fa7e38b_e9190a7a","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  This can be worked, but it expose the features of hypervisor directly."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* We can expose \"auto-converge\" and \"post-copy\" in flavor extra specs and"},{"line_number":76,"context_line":"  image properties. [2]_ But it have same issues as above, even expose the"},{"line_number":77,"context_line":"  features to end users. It increases administrator management costs as well"},{"line_number":78,"context_line":"  as operation and maintenance costs."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_c928ce86","line":77,"range":{"start_line":76,"start_character":25,"end_line":77,"end_character":22},"updated":"2019-11-12 16:19:00.000000000","message":"\"But it has the problem as above - exposing hypervisor features to end users.\"","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  This can be worked, but it expose the features of hypervisor directly."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* We can expose \"auto-converge\" and \"post-copy\" in flavor extra specs and"},{"line_number":76,"context_line":"  image properties. [2]_ But it have same issues as above, even expose the"},{"line_number":77,"context_line":"  features to end users. It increases administrator management costs as well"},{"line_number":78,"context_line":"  as operation and maintenance costs."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_01aa3619","line":77,"range":{"start_line":76,"start_character":25,"end_line":77,"end_character":22},"in_reply_to":"3fa7e38b_89289633","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  This can be worked, but it expose the features of hypervisor directly."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* We can expose \"auto-converge\" and \"post-copy\" in flavor extra specs and"},{"line_number":76,"context_line":"  image properties. [2]_ But it have same issues as above, even expose the"},{"line_number":77,"context_line":"  features to end users. It increases administrator management costs as well"},{"line_number":78,"context_line":"  as operation and maintenance costs."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_e1aefa2d","line":77,"range":{"start_line":76,"start_character":25,"end_line":77,"end_character":22},"in_reply_to":"3fa7e38b_c928ce86","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"07f739d1764ecbdca7b5696536bb158f74b5c50b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  This can be worked, but it expose the features of hypervisor directly."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* We can expose \"auto-converge\" and \"post-copy\" in flavor extra specs and"},{"line_number":76,"context_line":"  image properties. [2]_ But it have same issues as above, even expose the"},{"line_number":77,"context_line":"  features to end users. It increases administrator management costs as well"},{"line_number":78,"context_line":"  as operation and maintenance costs."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_89289633","line":77,"range":{"start_line":76,"start_character":25,"end_line":77,"end_character":22},"in_reply_to":"3fa7e38b_c928ce86","updated":"2019-11-12 16:22:54.000000000","message":"Missing word in my correction: \"the problem\" --\u003e the same problem\"","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"\"os-migrateLive\" will get a new optional parameter called"},{"line_number":91,"context_line":"``no_performance_impact``."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"A sample JSON request with ``no_performance_impact`` for living migrate a"},{"line_number":94,"context_line":"server would like this::"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_49393ecd","line":93,"range":{"start_line":93,"start_character":57,"end_line":93,"end_character":72},"updated":"2019-11-12 16:19:00.000000000","message":"live-migrating","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":90,"context_line":"\"os-migrateLive\" will get a new optional parameter called"},{"line_number":91,"context_line":"``no_performance_impact``."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"A sample JSON request with ``no_performance_impact`` for living migrate a"},{"line_number":94,"context_line":"server would like this::"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_c1f5fe52","line":93,"range":{"start_line":93,"start_character":57,"end_line":93,"end_character":72},"in_reply_to":"3fa7e38b_49393ecd","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":142,"context_line":"---------------------"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"User need tag their instance as **requested no performance impact** so that"},{"line_number":145,"context_line":"operator can filter these instance."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Operator need filter instances which **request no performance impact**"},{"line_number":148,"context_line":"before live migrate to ensure that the instance\u0027s performance will not get a"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_c9768ea4","line":145,"range":{"start_line":145,"start_character":26,"end_line":145,"end_character":34},"updated":"2019-11-12 16:19:00.000000000","message":"instances","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":142,"context_line":"---------------------"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"User need tag their instance as **requested no performance impact** so that"},{"line_number":145,"context_line":"operator can filter these instance."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Operator need filter instances which **request no performance impact**"},{"line_number":148,"context_line":"before live migrate to ensure that the instance\u0027s performance will not get a"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_219c120d","line":145,"range":{"start_line":145,"start_character":26,"end_line":145,"end_character":34},"in_reply_to":"3fa7e38b_c9768ea4","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":144,"context_line":"User need tag their instance as **requested no performance impact** so that"},{"line_number":145,"context_line":"operator can filter these instance."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Operator need filter instances which **request no performance impact**"},{"line_number":148,"context_line":"before live migrate to ensure that the instance\u0027s performance will not get a"},{"line_number":149,"context_line":"huge impact."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Performance Impact"},{"line_number":152,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_e9602ad2","line":149,"range":{"start_line":147,"start_character":1,"end_line":149,"end_character":12},"updated":"2019-11-12 16:19:00.000000000","message":"\"Operator needs to filter out instances with **requested no  performance impact\" before live-migrating an instance.\"\n\n(The goal of avoiding performance impact is implicit with the tag.)","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":144,"context_line":"User need tag their instance as **requested no performance impact** so that"},{"line_number":145,"context_line":"operator can filter these instance."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Operator need filter instances which **request no performance impact**"},{"line_number":148,"context_line":"before live migrate to ensure that the instance\u0027s performance will not get a"},{"line_number":149,"context_line":"huge impact."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Performance Impact"},{"line_number":152,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_81638619","line":149,"range":{"start_line":147,"start_character":1,"end_line":149,"end_character":12},"in_reply_to":"3fa7e38b_e9602ad2","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"afa2dcbbf15b2561587a37f0af049892e4a95e8b","unresolved":false,"context_lines":[{"line_number":188,"context_line":"----------"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"* Handle ``POST /servers/{server_id}/action`` on receiving an optional"},{"line_number":191,"context_line":"  ``no_performance_impact`` parameter for living migrate action on the client"},{"line_number":192,"context_line":"  side."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"* Expose the ``no_performance_impact`` through ``GET /os-migrations``,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_29ac02ed","line":191,"range":{"start_line":191,"start_character":42,"end_line":191,"end_character":56},"updated":"2019-11-12 16:19:00.000000000","message":"live migration","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"146f90c2ad570917c8481a4b5e5a906c5d580946","unresolved":false,"context_lines":[{"line_number":188,"context_line":"----------"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"* Handle ``POST /servers/{server_id}/action`` on receiving an optional"},{"line_number":191,"context_line":"  ``no_performance_impact`` parameter for living migrate action on the client"},{"line_number":192,"context_line":"  side."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"* Expose the ``no_performance_impact`` through ``GET /os-migrations``,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_8195c6e5","line":191,"range":{"start_line":191,"start_character":42,"end_line":191,"end_character":56},"in_reply_to":"3fa7e38b_29ac02ed","updated":"2019-11-13 05:08:09.000000000","message":"Done","commit_id":"e57f6a6040cbafd1f1071ed75d64556b59db2e78"}],"specs/ussuri/approved/live-migration-without-performance-impact.rst":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"6930d5da94cbbc8e8dc8720df22c015b97239714","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The request for ``POST /servers/{server_id}/action`` where action is"},{"line_number":51,"context_line":"\"os-migrateLive\" will get a new optional parameter called"},{"line_number":52,"context_line":"``no_performance_impact``. If the parameter is specified, it will disable"},{"line_number":53,"context_line":"auto-converge and post-copy during the live migration even if they are enabled"},{"line_number":54,"context_line":"in the configuration."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":".. note::"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_4cecbeba","line":54,"range":{"start_line":52,"start_character":58,"end_line":54,"end_character":21},"updated":"2019-11-15 04:13:24.000000000","message":"that means the user wants to give a try, if the live-migration can\u0027t finish, the user still have the chance to cancel. This is the workflow what we expected, right?","commit_id":"a9165b73240bc688d60e44ab556ee77dddc6e180"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"d95149f6c773c9ca0e6f9f565c5bfd6431ae3db5","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":".. note::"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    The new parameter would only affect the live migrate API call, it will not"},{"line_number":59,"context_line":"    affect the force complete migration API call."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":".. note::"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_ea7d386d","line":59,"range":{"start_line":58,"start_character":67,"end_line":59,"end_character":49},"updated":"2019-11-18 02:54:43.000000000","message":"Can I call the force complete migration API if I set this new parameter as true? I guess we can, that is choice for the operator.","commit_id":"a9165b73240bc688d60e44ab556ee77dddc6e180"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"d81db2b89e35ba7de58939934a94b2a9334a9e96","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":".. note::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    User can tag their instances as **no_performance_impact** via instance"},{"line_number":64,"context_line":"    metadata or somewhere else(such as the server tag), then operator can"},{"line_number":65,"context_line":"    check the tag to decide whether to add the new parameter before live"},{"line_number":66,"context_line":"    migration starts, to avoid performance impact."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    The form of the tag will not be specified in this spec, which should be"},{"line_number":69,"context_line":"    negotiated by the administrator and operator, and inform the user how to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_49a2059c","line":66,"range":{"start_line":63,"start_character":4,"end_line":66,"end_character":50},"updated":"2019-11-22 19:43:31.000000000","message":"I guess it\u0027s for each operator to decide how this user -\u003e operator communication will happen, and we don\u0027t want to be prescriptive?\n\nThinking out loud here, but what if instead of the new API param, we add an image prop, say \"performance_sensitive\", and then any live migration we do, if the instance has that image property, we disable post-copy and/or auto-converge? We could then give the operator a way to *override* that image property with a new API param to force post-copy and/or auto-converge.\n\nI guess the problem with that idea is that once an instance is booted, if we want to tag it as performance-sensitive, we need to set the new image property and rebuild...","commit_id":"a9165b73240bc688d60e44ab556ee77dddc6e180"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"877cc227d74030056547691166dec0c5d6d97d35","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":".. note::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    User can tag their instances as **no_performance_impact** via instance"},{"line_number":64,"context_line":"    metadata or somewhere else(such as the server tag), then operator can"},{"line_number":65,"context_line":"    check the tag to decide whether to add the new parameter before live"},{"line_number":66,"context_line":"    migration starts, to avoid performance impact."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    The form of the tag will not be specified in this spec, which should be"},{"line_number":69,"context_line":"    negotiated by the administrator and operator, and inform the user how to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_8ab468f2","line":66,"range":{"start_line":63,"start_character":4,"end_line":66,"end_character":50},"in_reply_to":"3fa7e38b_49a2059c","updated":"2019-11-23 21:08:52.000000000","message":"Thinking about this some more, image properties or flavor extra specs would be a bad solution for this, because we need something that can be changed during a server\u0027s life without affecting the server itself. Maybe server metadata? Though to my knowledge we never use server metadata for any semantics.","commit_id":"a9165b73240bc688d60e44ab556ee77dddc6e180"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b63340eea8410811cd11f342917f745e01fedc21","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    }"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Filtering/Sorting: The ``no_performance_impact`` key will be added to the"},{"line_number":131,"context_line":"existing list of valid sorting/filtering keys so that migrations can be"},{"line_number":132,"context_line":"filtered/sorted based on this field."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_2a88306f","line":131,"range":{"start_line":131,"start_character":23,"end_line":131,"end_character":30},"updated":"2019-11-18 02:52:58.000000000","message":"nit, those APIs have not sorting query parameter.","commit_id":"a9165b73240bc688d60e44ab556ee77dddc6e180"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"4ca4b1cf116923b4891303c07a47b6bd3c8879cb","unresolved":false,"context_lines":[{"line_number":168,"context_line":"Upgrade impact"},{"line_number":169,"context_line":"--------------"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"None"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_cc350e47","line":171,"range":{"start_line":171,"start_character":0,"end_line":171,"end_character":4},"updated":"2019-11-15 04:16:15.000000000","message":"How do you pass the \u0027no_performance_impact\u0027 down to the compute node? I guess that is pass by rpc call parameter?","commit_id":"a9165b73240bc688d60e44ab556ee77dddc6e180"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"d50e78c98e5f09243021af2a9d754070af78cef9","unresolved":false,"context_lines":[{"line_number":168,"context_line":"Upgrade impact"},{"line_number":169,"context_line":"--------------"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"None"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_0a9a14c4","line":171,"range":{"start_line":171,"start_character":0,"end_line":171,"end_character":4},"in_reply_to":"3fa7e38b_cc350e47","updated":"2019-11-18 02:49:02.000000000","message":"Oops, sorry, I saw you change the DB schema for pass the parameter down.","commit_id":"a9165b73240bc688d60e44ab556ee77dddc6e180"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"d81db2b89e35ba7de58939934a94b2a9334a9e96","unresolved":false,"context_lines":[{"line_number":169,"context_line":"--------------"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"None"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Implementation"},{"line_number":175,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_29c0e949","line":172,"updated":"2019-11-22 19:43:31.000000000","message":"Alex sort of raises the valid point of what happens when the source and/or destination is an old compute in a rolling upgrade situation and doesn\u0027t understand the new DB field. The answer is obviously \"nothing, we do an old-style live-migration with all the performance impact that this implies\", but maybe we want a way to communicate that to the operator and/or user?","commit_id":"a9165b73240bc688d60e44ab556ee77dddc6e180"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"de35c96b91f38821fae893e8aadeda1d2e1050ec","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The request for ``POST /servers/{server_id}/action`` where action is"},{"line_number":51,"context_line":"\"os-migrateLive\" will get a new optional parameter called"},{"line_number":52,"context_line":"``no_live_migration_perf_impact``. If the parameter is specified, it will"},{"line_number":53,"context_line":"disable auto-converge and post-copy during the live migration even if they are"},{"line_number":54,"context_line":"enabled in the configuration."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_a65a3b4e","line":52,"range":{"start_line":52,"start_character":2,"end_line":52,"end_character":31},"updated":"2020-01-20 03:15:24.000000000","message":"It\u0027s fuzzy (contains sentence L25-L30), it corresponds to which configuration when it\u0027s set True/False? `live_migration_permit_post_copy`_ or `live_migration_permit_auto_converge`_?\nPlease note this lcear in this spec.\n\n_`live_migration_permit_post_copy`:https://docs.openstack.org/nova/train/configuration/config.html#libvirt.live_migration_permit_post_copy\n_`live_migration_permit_auto_converge`:https://docs.openstack.org/nova/train/configuration/config.html#libvirt.live_migration_permit_auto_converge","commit_id":"2f99f5edff11f1ba06e81ed443ae9d7940e5edfd"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"de35c96b91f38821fae893e8aadeda1d2e1050ec","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":".. note::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    User can tag their instances as **no_live_migration_perf_impact** via"},{"line_number":64,"context_line":"    instance metadata or somewhere else(such as the server tag), then operator"},{"line_number":65,"context_line":"    can check the tag to decide whether to add the new parameter before live"},{"line_number":66,"context_line":"    migration starts, to avoid performance impact."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_e63593f7","line":63,"range":{"start_line":63,"start_character":13,"end_line":63,"end_character":32},"updated":"2020-01-20 03:15:24.000000000","message":"Alternative, I think we can add this *tag* to the instance\u0027s metadata, which we get detailes of the server.","commit_id":"2f99f5edff11f1ba06e81ed443ae9d7940e5edfd"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"9fe9f0bf394ca45b0dfae485b62e25ffc33f22f2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    can check the tag to decide whether to add the new parameter before live"},{"line_number":66,"context_line":"    migration starts, to avoid performance impact."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    The form of the tag will not be specified in this spec, which should be"},{"line_number":69,"context_line":"    negotiated by the administrator and operator, and inform the user how to"},{"line_number":70,"context_line":"    use it."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_41fd7105","line":69,"range":{"start_line":68,"start_character":60,"end_line":69,"end_character":49},"updated":"2020-01-20 03:20:28.000000000","message":"live-migration is the administrative role action, should we expose this parameter to the owner/operator? mainly in GET API list in `REST API impact`","commit_id":"2f99f5edff11f1ba06e81ed443ae9d7940e5edfd"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"de35c96b91f38821fae893e8aadeda1d2e1050ec","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"REST API impact"},{"line_number":90,"context_line":"---------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"The request for ``POST /servers/{server_id}/action`` where action is"},{"line_number":93,"context_line":"\"os-migrateLive\" will get a new optional parameter called"},{"line_number":94,"context_line":"``no_live_migration_perf_impact``."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_46610710","line":91,"updated":"2020-01-20 03:15:24.000000000","message":"You will change the exist live-migrate action api, so need to add a new microversion for this.","commit_id":"2f99f5edff11f1ba06e81ed443ae9d7940e5edfd"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"de35c96b91f38821fae893e8aadeda1d2e1050ec","unresolved":false,"context_lines":[{"line_number":202,"context_line":"* Recalculate ``_live_migration_flags`` before live migration start in"},{"line_number":203,"context_line":"  the libvirt driver."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"* Support filtering servers on the ``no_live_migration_perf_impact`` parameter."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"* Add tests code."},{"line_number":208,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_06122f62","line":205,"range":{"start_line":205,"start_character":2,"end_line":205,"end_character":79},"updated":"2020-01-20 03:15:24.000000000","message":"This filter depends on the server\u0027s tag, right?","commit_id":"2f99f5edff11f1ba06e81ed443ae9d7940e5edfd"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"de35c96b91f38821fae893e8aadeda1d2e1050ec","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"* Support filtering servers on the ``no_live_migration_perf_impact`` parameter."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"* Add tests code."},{"line_number":208,"context_line":""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_c603b710","line":207,"range":{"start_line":207,"start_character":2,"end_line":207,"end_character":17},"updated":"2020-01-20 03:15:24.000000000","message":"I think you should add the unit tests, and functional tests.","commit_id":"2f99f5edff11f1ba06e81ed443ae9d7940e5edfd"}]}