)]}'
{"specs/ussuri/approved/destroy-instance-with-datavolume.rst":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8bc4525841a199a5983ee1e55be39bad0cecae1b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint proposes to allow changing the ``deleted_on_termination``"},{"line_number":14,"context_line":"attribute of a volume after an instance is booted, or set the new volume\u0027s"},{"line_number":15,"context_line":"``deleted_on_termination`` during swap volume."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_52f13dcd","line":15,"range":{"start_line":15,"start_character":2,"end_line":15,"end_character":9},"updated":"2020-04-23 13:56:13.000000000","message":"delete","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1b7fb384515ceb33836f2c5425111462fcaf0675","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint proposes to allow changing the ``deleted_on_termination``"},{"line_number":14,"context_line":"attribute of a volume after an instance is booted, or set the new volume\u0027s"},{"line_number":15,"context_line":"``deleted_on_termination`` during swap volume."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_e4aeb9e5","line":15,"range":{"start_line":15,"start_character":2,"end_line":15,"end_character":9},"in_reply_to":"1f493fa4_52f13dcd","updated":"2020-04-24 01:45:25.000000000","message":"Done","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8bc4525841a199a5983ee1e55be39bad0cecae1b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"preserve important data while freeing compute resources or freeing"},{"line_number":36,"context_line":"storage space and cleaning up sensitive data."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"As an admin user, I expect that I can set ``deleted_on_termination``"},{"line_number":39,"context_line":"during swap volume."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The end user expects to be able to decide the policy by which the volumes"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_32ec71f2","line":38,"range":{"start_line":38,"start_character":44,"end_line":38,"end_character":51},"updated":"2020-04-23 13:56:13.000000000","message":"delete","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1b7fb384515ceb33836f2c5425111462fcaf0675","unresolved":false,"context_lines":[{"line_number":35,"context_line":"preserve important data while freeing compute resources or freeing"},{"line_number":36,"context_line":"storage space and cleaning up sensitive data."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"As an admin user, I expect that I can set ``deleted_on_termination``"},{"line_number":39,"context_line":"during swap volume."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The end user expects to be able to decide the policy by which the volumes"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_6484695f","line":38,"range":{"start_line":38,"start_character":44,"end_line":38,"end_character":51},"in_reply_to":"1f493fa4_32ec71f2","updated":"2020-04-24 01:45:25.000000000","message":"Done","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8bc4525841a199a5983ee1e55be39bad0cecae1b","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"As an admin user, I expect that I can set ``deleted_on_termination``"},{"line_number":39,"context_line":"during swap volume."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The end user expects to be able to decide the policy by which the volumes"},{"line_number":42,"context_line":"are preserved or destoryed at any point in the vms lifecyle."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_b2b9a1ea","line":40,"updated":"2020-04-23 13:56:13.000000000","message":"I don\u0027t really think that this needs to be another use case. The one above covers it.","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8bc4525841a199a5983ee1e55be39bad0cecae1b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"Change swap volume policy\u0027s rule name to"},{"line_number":54,"context_line":"``os_compute_api:os-volumes-attachments:swap``, and make the original"},{"line_number":55,"context_line":"policy\u0027s rule name (``os_compute_api:os-volumes-attachments:update``)"},{"line_number":56,"context_line":"to adapt the update a volume atachment API."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Add \u0027rule:system_admin_or_owner\u0027 policy to the update volume API."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_d2ab8d86","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":8},"updated":"2020-04-23 13:56:13.000000000","message":"allow","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1b7fb384515ceb33836f2c5425111462fcaf0675","unresolved":false,"context_lines":[{"line_number":53,"context_line":"Change swap volume policy\u0027s rule name to"},{"line_number":54,"context_line":"``os_compute_api:os-volumes-attachments:swap``, and make the original"},{"line_number":55,"context_line":"policy\u0027s rule name (``os_compute_api:os-volumes-attachments:update``)"},{"line_number":56,"context_line":"to adapt the update a volume atachment API."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Add \u0027rule:system_admin_or_owner\u0027 policy to the update volume API."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_8481b54d","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":8},"in_reply_to":"1f493fa4_d2ab8d86","updated":"2020-04-24 01:45:25.000000000","message":"Done","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8bc4525841a199a5983ee1e55be39bad0cecae1b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Add \u0027rule:system_admin_or_owner\u0027 policy to the update volume API."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"At this time, the update a volume attachment API will have"},{"line_number":61,"context_line":"``\u003cswap policy\u003e`` and ``\u003cudpate poicy\u003e`` two policies."},{"line_number":62,"context_line":"The new \u0027update\u0027 policy about \u0027swap + update\u0027 request (which is possible"},{"line_number":63,"context_line":"only \u003e new microversion) only ``\u003cswap policy\u003e`` is checked. We expect"},{"line_number":64,"context_line":"``\u003cswap policy\u003e`` to be always superset of this policy permission."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_b29c015e","line":61,"range":{"start_line":61,"start_character":41,"end_line":61,"end_character":44},"updated":"2020-04-23 13:56:13.000000000","message":"(remove)","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8bc4525841a199a5983ee1e55be39bad0cecae1b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Add \u0027rule:system_admin_or_owner\u0027 policy to the update volume API."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"At this time, the update a volume attachment API will have"},{"line_number":61,"context_line":"``\u003cswap policy\u003e`` and ``\u003cudpate poicy\u003e`` two policies."},{"line_number":62,"context_line":"The new \u0027update\u0027 policy about \u0027swap + update\u0027 request (which is possible"},{"line_number":63,"context_line":"only \u003e new microversion) only ``\u003cswap policy\u003e`` is checked. We expect"},{"line_number":64,"context_line":"``\u003cswap policy\u003e`` to be always superset of this policy permission."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_32a8f175","line":61,"range":{"start_line":61,"start_character":32,"end_line":61,"end_character":37},"updated":"2020-04-23 13:56:13.000000000","message":"policy","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8bc4525841a199a5983ee1e55be39bad0cecae1b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Add \u0027rule:system_admin_or_owner\u0027 policy to the update volume API."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"At this time, the update a volume attachment API will have"},{"line_number":61,"context_line":"``\u003cswap policy\u003e`` and ``\u003cudpate poicy\u003e`` two policies."},{"line_number":62,"context_line":"The new \u0027update\u0027 policy about \u0027swap + update\u0027 request (which is possible"},{"line_number":63,"context_line":"only \u003e new microversion) only ``\u003cswap policy\u003e`` is checked. We expect"},{"line_number":64,"context_line":"``\u003cswap policy\u003e`` to be always superset of this policy permission."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_7292794d","line":61,"range":{"start_line":61,"start_character":25,"end_line":61,"end_character":31},"updated":"2020-04-23 13:56:13.000000000","message":"update","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1b7fb384515ceb33836f2c5425111462fcaf0675","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Add \u0027rule:system_admin_or_owner\u0027 policy to the update volume API."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"At this time, the update a volume attachment API will have"},{"line_number":61,"context_line":"``\u003cswap policy\u003e`` and ``\u003cudpate poicy\u003e`` two policies."},{"line_number":62,"context_line":"The new \u0027update\u0027 policy about \u0027swap + update\u0027 request (which is possible"},{"line_number":63,"context_line":"only \u003e new microversion) only ``\u003cswap policy\u003e`` is checked. We expect"},{"line_number":64,"context_line":"``\u003cswap policy\u003e`` to be always superset of this policy permission."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_44eccd28","line":61,"range":{"start_line":61,"start_character":32,"end_line":61,"end_character":37},"in_reply_to":"1f493fa4_32a8f175","updated":"2020-04-24 01:45:25.000000000","message":"Done","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1b7fb384515ceb33836f2c5425111462fcaf0675","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Add \u0027rule:system_admin_or_owner\u0027 policy to the update volume API."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"At this time, the update a volume attachment API will have"},{"line_number":61,"context_line":"``\u003cswap policy\u003e`` and ``\u003cudpate poicy\u003e`` two policies."},{"line_number":62,"context_line":"The new \u0027update\u0027 policy about \u0027swap + update\u0027 request (which is possible"},{"line_number":63,"context_line":"only \u003e new microversion) only ``\u003cswap policy\u003e`` is checked. We expect"},{"line_number":64,"context_line":"``\u003cswap policy\u003e`` to be always superset of this policy permission."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_a4f3110a","line":61,"range":{"start_line":61,"start_character":25,"end_line":61,"end_character":31},"in_reply_to":"1f493fa4_7292794d","updated":"2020-04-24 01:45:25.000000000","message":"Done","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1b7fb384515ceb33836f2c5425111462fcaf0675","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Add \u0027rule:system_admin_or_owner\u0027 policy to the update volume API."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"At this time, the update a volume attachment API will have"},{"line_number":61,"context_line":"``\u003cswap policy\u003e`` and ``\u003cudpate poicy\u003e`` two policies."},{"line_number":62,"context_line":"The new \u0027update\u0027 policy about \u0027swap + update\u0027 request (which is possible"},{"line_number":63,"context_line":"only \u003e new microversion) only ``\u003cswap policy\u003e`` is checked. We expect"},{"line_number":64,"context_line":"``\u003cswap policy\u003e`` to be always superset of this policy permission."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_84f6d5f8","line":61,"range":{"start_line":61,"start_character":41,"end_line":61,"end_character":44},"in_reply_to":"1f493fa4_b29c015e","updated":"2020-04-24 01:45:25.000000000","message":"Done","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8bc4525841a199a5983ee1e55be39bad0cecae1b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"At this time, the update a volume attachment API will have"},{"line_number":61,"context_line":"``\u003cswap policy\u003e`` and ``\u003cudpate poicy\u003e`` two policies."},{"line_number":62,"context_line":"The new \u0027update\u0027 policy about \u0027swap + update\u0027 request (which is possible"},{"line_number":63,"context_line":"only \u003e new microversion) only ``\u003cswap policy\u003e`` is checked. We expect"},{"line_number":64,"context_line":"``\u003cswap policy\u003e`` to be always superset of this policy permission."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_12a335a0","line":63,"range":{"start_line":63,"start_character":5,"end_line":63,"end_character":6},"updated":"2020-04-23 13:56:13.000000000","message":"with the","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1b7fb384515ceb33836f2c5425111462fcaf0675","unresolved":false,"context_lines":[{"line_number":60,"context_line":"At this time, the update a volume attachment API will have"},{"line_number":61,"context_line":"``\u003cswap policy\u003e`` and ``\u003cudpate poicy\u003e`` two policies."},{"line_number":62,"context_line":"The new \u0027update\u0027 policy about \u0027swap + update\u0027 request (which is possible"},{"line_number":63,"context_line":"only \u003e new microversion) only ``\u003cswap policy\u003e`` is checked. We expect"},{"line_number":64,"context_line":"``\u003cswap policy\u003e`` to be always superset of this policy permission."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_e4dcf975","line":63,"range":{"start_line":63,"start_character":5,"end_line":63,"end_character":6},"in_reply_to":"1f493fa4_12a335a0","updated":"2020-04-24 01:45:25.000000000","message":"Done","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8bc4525841a199a5983ee1e55be39bad0cecae1b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"``\u003cswap policy\u003e`` and ``\u003cudpate poicy\u003e`` two policies."},{"line_number":62,"context_line":"The new \u0027update\u0027 policy about \u0027swap + update\u0027 request (which is possible"},{"line_number":63,"context_line":"only \u003e new microversion) only ``\u003cswap policy\u003e`` is checked. We expect"},{"line_number":64,"context_line":"``\u003cswap policy\u003e`` to be always superset of this policy permission."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Alternatives"},{"line_number":67,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_52adbd86","line":64,"updated":"2020-04-23 13:56:13.000000000","message":"This whole paragraph is confusing. Did you intend to fill in the \u003cswap policy\u003e and \u003cupdate policy\u003e bits with the actual names? Either way, I\u0027d suggest the following wording:\n\n After this change, the update volume attachment API will have two policies,\n one for general updates (currently only ``delete_on_termination``) and one\n for admins which allows changing the volume id (i.e. swap volume) as well\n as other attributes. In other words, the swap policy is a superset of the\n update policy.","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1b7fb384515ceb33836f2c5425111462fcaf0675","unresolved":false,"context_lines":[{"line_number":61,"context_line":"``\u003cswap policy\u003e`` and ``\u003cudpate poicy\u003e`` two policies."},{"line_number":62,"context_line":"The new \u0027update\u0027 policy about \u0027swap + update\u0027 request (which is possible"},{"line_number":63,"context_line":"only \u003e new microversion) only ``\u003cswap policy\u003e`` is checked. We expect"},{"line_number":64,"context_line":"``\u003cswap policy\u003e`` to be always superset of this policy permission."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Alternatives"},{"line_number":67,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_e473597f","line":64,"in_reply_to":"1f493fa4_52adbd86","updated":"2020-04-24 01:45:25.000000000","message":"Done","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8bc4525841a199a5983ee1e55be39bad0cecae1b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"to preserve the root volume after the server is deleted, you can create a"},{"line_number":76,"context_line":"snapshot of the server."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Another option is add PATCH a volume attachment API, add"},{"line_number":79,"context_line":"``delete_on_termination`` property to the request body to support updating"},{"line_number":80,"context_line":"the attached volume, but that will break the nova API and introduce a new"},{"line_number":81,"context_line":"PATCH method."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_12d175fc","line":78,"range":{"start_line":78,"start_character":53,"end_line":78,"end_character":56},"updated":"2020-04-23 13:56:13.000000000","message":"allowing a","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1b7fb384515ceb33836f2c5425111462fcaf0675","unresolved":false,"context_lines":[{"line_number":75,"context_line":"to preserve the root volume after the server is deleted, you can create a"},{"line_number":76,"context_line":"snapshot of the server."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Another option is add PATCH a volume attachment API, add"},{"line_number":79,"context_line":"``delete_on_termination`` property to the request body to support updating"},{"line_number":80,"context_line":"the attached volume, but that will break the nova API and introduce a new"},{"line_number":81,"context_line":"PATCH method."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_44d5ed42","line":78,"range":{"start_line":78,"start_character":53,"end_line":78,"end_character":56},"in_reply_to":"1f493fa4_12d175fc","updated":"2020-04-24 01:45:25.000000000","message":"Done","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8bc4525841a199a5983ee1e55be39bad0cecae1b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"snapshot of the server."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Another option is add PATCH a volume attachment API, add"},{"line_number":79,"context_line":"``delete_on_termination`` property to the request body to support updating"},{"line_number":80,"context_line":"the attached volume, but that will break the nova API and introduce a new"},{"line_number":81,"context_line":"PATCH method."},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_f2cb2947","line":79,"range":{"start_line":79,"start_character":35,"end_line":79,"end_character":37},"updated":"2020-04-23 13:56:13.000000000","message":"in","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1b7fb384515ceb33836f2c5425111462fcaf0675","unresolved":false,"context_lines":[{"line_number":76,"context_line":"snapshot of the server."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Another option is add PATCH a volume attachment API, add"},{"line_number":79,"context_line":"``delete_on_termination`` property to the request body to support updating"},{"line_number":80,"context_line":"the attached volume, but that will break the nova API and introduce a new"},{"line_number":81,"context_line":"PATCH method."},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_a4ccb1bc","line":79,"range":{"start_line":79,"start_character":35,"end_line":79,"end_character":37},"in_reply_to":"1f493fa4_f2cb2947","updated":"2020-04-24 01:45:25.000000000","message":"Done","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8bc4525841a199a5983ee1e55be39bad0cecae1b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"Other end user impact"},{"line_number":128,"context_line":"---------------------"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"python-novaclient will be support for these changes."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Performance Impact"},{"line_number":133,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_f2f4c989","line":130,"range":{"start_line":130,"start_character":26,"end_line":130,"end_character":51},"updated":"2020-04-23 13:56:13.000000000","message":"updated to support changing the ``delete_on_termination`` flag","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1b7fb384515ceb33836f2c5425111462fcaf0675","unresolved":false,"context_lines":[{"line_number":127,"context_line":"Other end user impact"},{"line_number":128,"context_line":"---------------------"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"python-novaclient will be support for these changes."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Performance Impact"},{"line_number":133,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_24c0a17b","line":130,"range":{"start_line":130,"start_character":26,"end_line":130,"end_character":51},"in_reply_to":"1f493fa4_f2f4c989","updated":"2020-04-24 01:45:25.000000000","message":"Done","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8bc4525841a199a5983ee1e55be39bad0cecae1b","unresolved":false,"context_lines":[{"line_number":167,"context_line":"Work Items"},{"line_number":168,"context_line":"----------"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"* Add microversion support in nova API."},{"line_number":171,"context_line":"* Change the original policy role name for update a volume attachment API."},{"line_number":172,"context_line":"* Add new policy to the update a volume attachment API."},{"line_number":173,"context_line":"* Change python-novaclient to support this microversion."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_922bc5e9","line":170,"range":{"start_line":170,"start_character":2,"end_line":170,"end_character":38},"updated":"2020-04-23 13:56:13.000000000","message":"This doesn\u0027t make sense, as nova API already supports microversions. I assume this is what you meant:\n\n Add a new microversion which enables code that allows updating\n ``delete_on_termination`` during a PUT request.","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1b7fb384515ceb33836f2c5425111462fcaf0675","unresolved":false,"context_lines":[{"line_number":167,"context_line":"Work Items"},{"line_number":168,"context_line":"----------"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"* Add microversion support in nova API."},{"line_number":171,"context_line":"* Change the original policy role name for update a volume attachment API."},{"line_number":172,"context_line":"* Add new policy to the update a volume attachment API."},{"line_number":173,"context_line":"* Change python-novaclient to support this microversion."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_e44a3925","line":170,"range":{"start_line":170,"start_character":2,"end_line":170,"end_character":38},"in_reply_to":"1f493fa4_922bc5e9","updated":"2020-04-24 01:45:25.000000000","message":"Done","commit_id":"ce33cc9c925d24f083a613f181df40de467cd338"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"becd231f35980405ddb0ff9ffeb956f29fc3ad5f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently, nova support configuring ``delete_on_termination`` for the root"},{"line_number":21,"context_line":"disk and data volume (refrerence to the volume attach API [1]_.) when the"},{"line_number":22,"context_line":"instance is created, but does not allow it to be updated after the instance"},{"line_number":23,"context_line":"is created."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f493fa4_71853c08","line":20,"range":{"start_line":20,"start_character":16,"end_line":20,"end_character":23},"updated":"2020-04-24 14:33:10.000000000","message":"supports","commit_id":"3f83e2be2c8d1683332a49d7e59b58ab6d50b584"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"becd231f35980405ddb0ff9ffeb956f29fc3ad5f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"to preserve the root volume after the server is deleted, you can create a"},{"line_number":76,"context_line":"snapshot of the server."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Another option is add PATCH a volume attachment API, allowing a"},{"line_number":79,"context_line":"``delete_on_termination`` property in the request body to support updating"},{"line_number":80,"context_line":"the attached volume, but that will break the nova API and introduce a new"},{"line_number":81,"context_line":"PATCH method."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f493fa4_9179e830","line":78,"range":{"start_line":78,"start_character":18,"end_line":78,"end_character":21},"updated":"2020-04-24 14:33:10.000000000","message":"to add a","commit_id":"3f83e2be2c8d1683332a49d7e59b58ab6d50b584"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"becd231f35980405ddb0ff9ffeb956f29fc3ad5f","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        }"},{"line_number":108,"context_line":"    }"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"  Other than ``volumeId``, as of new microversion only"},{"line_number":111,"context_line":"  ``delete_on_termination`` may be changed from the current value. Otherwise,"},{"line_number":112,"context_line":"  that will be return 400."},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f493fa4_719a5c63","line":110,"range":{"start_line":110,"start_character":33,"end_line":110,"end_character":36},"updated":"2020-04-24 14:33:10.000000000","message":"the new","commit_id":"3f83e2be2c8d1683332a49d7e59b58ab6d50b584"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"566f5ed319b24d36764d5da5a31a504ab10028ce","unresolved":false,"context_lines":[{"line_number":110,"context_line":"  Other than ``volumeId``, as of the new microversion only"},{"line_number":111,"context_line":"  ``delete_on_termination`` may be changed from the current value. Otherwise,"},{"line_number":112,"context_line":"  that will be return 400."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Add \u0027rule:system_admin_or_owner\u0027 policy role to the"},{"line_number":115,"context_line":"update a volume attachment API."},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f493fa4_11503832","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":0},"updated":"2020-04-24 14:43:52.000000000","message":"may be good to mention that from this microverison, PUT will accept all the field return by GET not the 400 as in previous microversion. Those are not updateable though.","commit_id":"2084981c641de8442561ea1d95f1437e24c123a3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"87e20e4812f5bf4e4121ca1d9719e55325e6878f","unresolved":false,"context_lines":[{"line_number":110,"context_line":"  Other than ``volumeId``, as of the new microversion only"},{"line_number":111,"context_line":"  ``delete_on_termination`` may be changed from the current value. Otherwise,"},{"line_number":112,"context_line":"  that will be return 400."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Add \u0027rule:system_admin_or_owner\u0027 policy role to the"},{"line_number":115,"context_line":"update a volume attachment API."},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f493fa4_16f789f7","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":0},"in_reply_to":"1f493fa4_11503832","updated":"2020-04-24 16:14:49.000000000","message":"as discussed on IRC. this is ok as other doc like api-ref etc document the detailed changes. \n\nlgtm.","commit_id":"2084981c641de8442561ea1d95f1437e24c123a3"}]}