)]}'
{"id":"openstack%2Fnova-specs~741601","triplet_id":"openstack%2Fnova-specs~master~I659a3ee6a561c2cbd9f218746304c788d0750ad7","project":"openstack/nova-specs","branch":"master","topic":"bp/sriov-interface-attach-detach","hashtags":[],"change_id":"I659a3ee6a561c2cbd9f218746304c788d0750ad7","subject":"Support SRIOV interface attach and detach","status":"MERGED","created":"2020-07-17 08:37:05.000000000","updated":"2020-07-21 15:23:20.000000000","submitted":"2020-07-21 15:20:40.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":26,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"741601-1595344840787-6361157a","meta_rev_id":"2b4f2686a978f8b0be30cef9f56a9f4375191f05","_number":741601,"virtual_id_number":741601,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-07-21 15:20:40.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-07-21 14:48:20.000000000","_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":2,"date":"2020-07-21 14:49:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":1,"date":"2020-07-21 14:49:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-17 15:36:41.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2020-07-17 15:41:22.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2020-07-21 14:49:48.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"},{"updated":"2020-07-21 15:20:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2c13b7c57133ee4268a1d19b03746b699bcbb251","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2020-07-17 08:37:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7d1e1e0ecaa737b884e1692d0a4321553aee6334","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-17 08:50:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f3910cf5837d4cb091908e05c5d59fcc : SUCCESS in 7m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/76634f3285214c839bc3ad2533ef8102 : SUCCESS in 4m 16s","accounts_in_message":[],"_revision_number":1},{"id":"561dbf002b3221d3a00f2048b10d69f41b4ec01f","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-07-17 10:51:16.000000000","message":"Patch Set 1: Code-Review-1\n\n(8 comments)\n\nLots of nits so -1 because it\u0027s docs, but this is otherwise a slam dunk IMO","accounts_in_message":[],"_revision_number":1},{"id":"f8721a20eedbf11dc73d3c95c00b6763c07de82f","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-07-17 12:13:56.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nim also largely ok with this as proposed but -1 is because i think we shoudl consider blocking detach on older release like we did for numa migration with a workaound config option.\nonce stephen nits are resolved im happy to track my other issue as bugs if people want to keep this small or we could expand the scope to include the related bugs.","accounts_in_message":[],"_revision_number":1},{"id":"54a91231f9a08e2fff24e633d76bd6327aca10d3","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2020-07-17 15:29:24.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c47c5d6c218326f2bfe217237f48a0f93e47ed1c","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2020-07-17 15:29:39.000000000","message":"Patch Set 2:\n\n(10 comments)","accounts_in_message":[],"_revision_number":2},{"id":"1e31bcd8099c6f98e4f516329933ef2b999f79b3","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-07-17 15:36:41.000000000","message":"Patch Set 2: Code-Review+2\n\nWe\u0027ll see what Sean thinks but I\u0027m quite happy with this","accounts_in_message":[],"_revision_number":2},{"id":"6478928f75ce0ad62777597e5c37fcca4e4d453d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-17 15:39:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/95c25a91932048eca1428f295ab872e8 : SUCCESS in 6m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4ac95fa9e2d1430eb7db4599bf86bea2 : SUCCESS in 4m 18s","accounts_in_message":[],"_revision_number":2},{"id":"5adba03280949e02fb98baa2219f9efa7e26b6a9","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-07-17 15:41:22.000000000","message":"Patch Set 2: Code-Review+1\n\nyep im fine with this i will propose bugfix for both the issue noted inline.","accounts_in_message":[],"_revision_number":2},{"id":"7632c95a42f99c840924f0c5453b9d7eec1b1f20","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2020-07-21 09:06:21.000000000","message":"Patch Set 2: Code-Review+1\n\n(4 comments)\n\nJust a nit about claims, but you can provide a FUP if you want. Just tell me and I\u0027ll +W the spec.","accounts_in_message":[],"_revision_number":2},{"id":"ea6acc2a6d13015971b54fcd2155651644b7b44b","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2020-07-21 14:47:31.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"0b32d589606e0be6645aac66afbaebf6d832f442","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2020-07-21 14:48:20.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"73658bf0434313716e589900c0be336c5e5f627a","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2020-07-21 14:49:48.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nStephenfin already +2d in the previous PS2, and the change between PS2 and PS3 is just about a nit I provided.\n\nThanks !","accounts_in_message":[],"_revision_number":3},{"id":"9beaf0e200fb2e0b4332bf9f489614d1ff7a0d86","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-21 15:05:39.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/14ee4a7e0ea74f9ba57aa86d3afe3486 : SUCCESS in 9m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/aa97179b2cbd4ad787805a4ee84ddc54 : SUCCESS in 4m 28s","accounts_in_message":[],"_revision_number":3},{"id":"f6aa8f76d0362d5544da8b5535cd19e6dfac8408","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-21 15:05:51.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"6ca850eac19526646c986b9d55e2864bf145f5af","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-21 15:20:40.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9f27d5a9e4264874b123d284feb26d76 : SUCCESS in 8m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/375d1fa27ac8402680a0a3e111f1ecf2 : SUCCESS in 7m 00s","accounts_in_message":[],"_revision_number":3},{"id":"fe934d8889256019d7a9d2e766b35c9e2390f5bc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-21 15:20:40.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"1ab92d8c9aa9eaadcfb7bf81412d8706c3f6988a","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-21 15:23:20.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-specs https://zuul.opendev.org/t/openstack/build/75fb05c9e6744121978fdcaffb029638 : SUCCESS in 1m 58s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"dd5319deffb8eae4fa4ebcf7e47e75c66df9f021","revisions":{"239ef6b92efa7c5fc54b9f53588ced8c39f9817c":{"kind":"REWORK","_number":1,"created":"2020-07-17 08:37:05.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/01/741601/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/01/741601/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/01/741601/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/01/741601/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/01/741601/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/01/741601/1"}}},"commit":{"parents":[{"commit":"619854e6dedeca362b4a15bb8d9efad866f70da6","subject":"Merge \"Update the testing section of the rbd-glance-multistore spec\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/619854e6dedeca362b4a15bb8d9efad866f70da6"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2020-07-17 08:34:55.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2020-07-17 08:34:55.000000000","tz":120},"subject":"Support SRIOV interface attach and detach","message":"Support SRIOV interface attach and detach\n\nNova supports booting servers with SRIOV interfaces however attaching\nand detaching an SRIOV interfaces to an existing server is not\nsupported as the PCI device management is missing from the attach\nand detach code path.\n\nPart of blueprint sriov-interface-attach-detach\n\nChange-Id: I659a3ee6a561c2cbd9f218746304c788d0750ad7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/239ef6b92efa7c5fc54b9f53588ced8c39f9817c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/239ef6b92efa7c5fc54b9f53588ced8c39f9817c"}]},"branch":"refs/heads/master"},"428d3e7e72adf7b5b2530e7058d3093253d4b2ec":{"kind":"REWORK","_number":2,"created":"2020-07-17 15:29:24.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/01/741601/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/01/741601/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/01/741601/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/01/741601/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/01/741601/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/01/741601/2"}}},"commit":{"parents":[{"commit":"619854e6dedeca362b4a15bb8d9efad866f70da6","subject":"Merge \"Update the testing section of the rbd-glance-multistore spec\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/619854e6dedeca362b4a15bb8d9efad866f70da6"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2020-07-17 08:34:55.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2020-07-17 15:28:39.000000000","tz":120},"subject":"Support SRIOV interface attach and detach","message":"Support SRIOV interface attach and detach\n\nNova supports booting servers with SRIOV interfaces. However,\nattaching and detaching an SRIOV interface to an existing server\nis not supported as the PCI device management is missing from the\nattach and detach code path.\n\nPart of blueprint sriov-interface-attach-detach\n\nChange-Id: I659a3ee6a561c2cbd9f218746304c788d0750ad7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/428d3e7e72adf7b5b2530e7058d3093253d4b2ec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/428d3e7e72adf7b5b2530e7058d3093253d4b2ec"}]},"branch":"refs/heads/master"},"dd5319deffb8eae4fa4ebcf7e47e75c66df9f021":{"kind":"REWORK","_number":3,"created":"2020-07-21 14:47:31.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/01/741601/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/01/741601/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/01/741601/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/01/741601/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/01/741601/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/01/741601/3"}}},"commit":{"parents":[{"commit":"619854e6dedeca362b4a15bb8d9efad866f70da6","subject":"Merge \"Update the testing section of the rbd-glance-multistore spec\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/619854e6dedeca362b4a15bb8d9efad866f70da6"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2020-07-17 08:34:55.000000000","tz":120},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2020-07-21 14:47:05.000000000","tz":120},"subject":"Support SRIOV interface attach and detach","message":"Support SRIOV interface attach and detach\n\nNova supports booting servers with SRIOV interfaces. However,\nattaching and detaching an SRIOV interface to an existing server\nis not supported as the PCI device management is missing from the\nattach and detach code path.\n\nPart of blueprint sriov-interface-attach-detach\n\nChange-Id: I659a3ee6a561c2cbd9f218746304c788d0750ad7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/dd5319deffb8eae4fa4ebcf7e47e75c66df9f021"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/dd5319deffb8eae4fa4ebcf7e47e75c66df9f021"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}