)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":7,"context_line":"add port scoped numa affinity spec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a spec to detail the extension"},{"line_number":10,"context_line":"of the existing vm scoped pci numa affinity"},{"line_number":11,"context_line":"feature and numa aware vswitch feature to support"},{"line_number":12,"context_line":"port scoped numa affinity policies."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8b281b04_310d401c","line":10,"range":{"start_line":10,"start_character":16,"end_line":10,"end_character":34},"updated":"2021-01-07 16:33:38.000000000","message":"VM-scoped PCI NUMA","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f66e6099cf83ede8dd23020bcad956767fa9ff2d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"add port scoped numa affinity spec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a spec to detail the extension"},{"line_number":10,"context_line":"of the existing vm scoped pci numa affinity"},{"line_number":11,"context_line":"feature and numa aware vswitch feature to support"},{"line_number":12,"context_line":"port scoped numa affinity policies."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5e9dc7f0_84306a41","line":10,"range":{"start_line":10,"start_character":16,"end_line":10,"end_character":34},"in_reply_to":"8b281b04_310d401c","updated":"2021-01-08 18:41:17.000000000","message":"Ack","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"}],"specs/wallaby/approved/port-scoped-sriov-numa-affinity.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In the Ussuri release [1]_ support was added to allow PCI NUMA affinity"},{"line_number":14,"context_line":"policies to be specified via flavor or image. This work builds on a previous"},{"line_number":15,"context_line":"feature introduced in the Ussuri release and extend the granularity to allow"},{"line_number":16,"context_line":"per neutron port numa affinity policies."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b2f18d0c_459065a8","line":15,"range":{"start_line":15,"start_character":45,"end_line":15,"end_character":51},"updated":"2021-01-07 16:33:38.000000000","message":"extends","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2585b552de52297430fce2b13780378b03ffb8a6","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In the Ussuri release [1]_ support was added to allow PCI NUMA affinity"},{"line_number":14,"context_line":"policies to be specified via flavor or image. This work builds on a previous"},{"line_number":15,"context_line":"feature introduced in the Ussuri release and extend the granularity to allow"},{"line_number":16,"context_line":"per neutron port numa affinity policies."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8e7b21f7_30ab6837","line":15,"range":{"start_line":15,"start_character":45,"end_line":15,"end_character":51},"in_reply_to":"b2f18d0c_459065a8","updated":"2021-01-18 11:17:13.000000000","message":"Done","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":13,"context_line":"In the Ussuri release [1]_ support was added to allow PCI NUMA affinity"},{"line_number":14,"context_line":"policies to be specified via flavor or image. This work builds on a previous"},{"line_number":15,"context_line":"feature introduced in the Ussuri release and extend the granularity to allow"},{"line_number":16,"context_line":"per neutron port numa affinity policies."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"33900606_4ee204da","line":16,"range":{"start_line":16,"start_character":17,"end_line":16,"end_character":21},"updated":"2021-01-07 16:33:38.000000000","message":"NUMA (here and elsewhere)","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2585b552de52297430fce2b13780378b03ffb8a6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"In the Ussuri release [1]_ support was added to allow PCI NUMA affinity"},{"line_number":14,"context_line":"policies to be specified via flavor or image. This work builds on a previous"},{"line_number":15,"context_line":"feature introduced in the Ussuri release and extend the granularity to allow"},{"line_number":16,"context_line":"per neutron port numa affinity policies."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fd5d8cca_324394eb","line":16,"range":{"start_line":16,"start_character":17,"end_line":16,"end_character":21},"in_reply_to":"33900606_4ee204da","updated":"2021-01-18 11:17:13.000000000","message":"Done","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":21,"context_line":"In some environments the server form factor is restricted, preventing PCI"},{"line_number":22,"context_line":"devices from being physically installed across all NUMA nodes on a server,"},{"line_number":23,"context_line":"e.g. high density blade/multi server systems or non standard form factor"},{"line_number":24,"context_line":"equipment. In the Ussuri release operators gained the flexibility to specify"},{"line_number":25,"context_line":"a vm wide numa affinity policy via the flavor or image however in many cases"},{"line_number":26,"context_line":"different nic have different constraint. "},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"370e62be_67fb68a9","line":24,"range":{"start_line":24,"start_character":9,"end_line":24,"end_character":10},"updated":"2021-01-07 16:33:38.000000000","message":"nit: Probably worth stating that it\u0027s more than that. As you know, with Intel\u0027s CoD or the new AMD EPYC processors, there can be a huge number of NUMA nodes, some of which won\u0027t even have a physical PCI slot associated with them. This makes it impractical/impossible to associate one or more NICs with each node.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"797935ab3bdcd3c2ca6bc9f67dc2da9979571ce1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"In some environments the server form factor is restricted, preventing PCI"},{"line_number":22,"context_line":"devices from being physically installed across all NUMA nodes on a server,"},{"line_number":23,"context_line":"e.g. high density blade/multi server systems or non standard form factor"},{"line_number":24,"context_line":"equipment. In the Ussuri release operators gained the flexibility to specify"},{"line_number":25,"context_line":"a vm wide numa affinity policy via the flavor or image however in many cases"},{"line_number":26,"context_line":"different nic have different constraint. "},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7b9218d2_947707a7","line":24,"range":{"start_line":24,"start_character":9,"end_line":24,"end_character":10},"in_reply_to":"1eb054b7_57ae60b8","updated":"2021-01-20 13:14:24.000000000","message":"OK. thanks","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f66e6099cf83ede8dd23020bcad956767fa9ff2d","unresolved":true,"context_lines":[{"line_number":21,"context_line":"In some environments the server form factor is restricted, preventing PCI"},{"line_number":22,"context_line":"devices from being physically installed across all NUMA nodes on a server,"},{"line_number":23,"context_line":"e.g. high density blade/multi server systems or non standard form factor"},{"line_number":24,"context_line":"equipment. In the Ussuri release operators gained the flexibility to specify"},{"line_number":25,"context_line":"a vm wide numa affinity policy via the flavor or image however in many cases"},{"line_number":26,"context_line":"different nic have different constraint. "},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ae70bf00_1fba14fa","line":24,"range":{"start_line":24,"start_character":9,"end_line":24,"end_character":10},"in_reply_to":"370e62be_67fb68a9","updated":"2021-01-08 18:41:17.000000000","message":"yes that is correct although im trying to avoid a direct depency on the pci socket affinity policy spec or numa distance. but you are correct in what you say i can add a sentence to that affect.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a07b97c82401c8f02f5a87e9e9426693dcf9e6e4","unresolved":true,"context_lines":[{"line_number":21,"context_line":"In some environments the server form factor is restricted, preventing PCI"},{"line_number":22,"context_line":"devices from being physically installed across all NUMA nodes on a server,"},{"line_number":23,"context_line":"e.g. high density blade/multi server systems or non standard form factor"},{"line_number":24,"context_line":"equipment. In the Ussuri release operators gained the flexibility to specify"},{"line_number":25,"context_line":"a vm wide numa affinity policy via the flavor or image however in many cases"},{"line_number":26,"context_line":"different nic have different constraint. "},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dd687850_41be9a91","line":24,"range":{"start_line":24,"start_character":9,"end_line":24,"end_character":10},"in_reply_to":"ae70bf00_1fba14fa","updated":"2021-01-15 11:39:03.000000000","message":"About the dependency. So either the implementation of this spec needs to handle the new \u0027socket\u0027 value or the implementation of the other spec needs to handle the new source of the value, the port. \n\nI support to have these two specs discussed separately. But lets try to avoid forgetting that the implementations need to be integrated. Especially if the two implementation will be written by two different developer in parallel.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2585b552de52297430fce2b13780378b03ffb8a6","unresolved":true,"context_lines":[{"line_number":21,"context_line":"In some environments the server form factor is restricted, preventing PCI"},{"line_number":22,"context_line":"devices from being physically installed across all NUMA nodes on a server,"},{"line_number":23,"context_line":"e.g. high density blade/multi server systems or non standard form factor"},{"line_number":24,"context_line":"equipment. In the Ussuri release operators gained the flexibility to specify"},{"line_number":25,"context_line":"a vm wide numa affinity policy via the flavor or image however in many cases"},{"line_number":26,"context_line":"different nic have different constraint. "},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1eb054b7_57ae60b8","line":24,"range":{"start_line":24,"start_character":9,"end_line":24,"end_character":10},"in_reply_to":"dd687850_41be9a91","updated":"2021-01-18 11:17:13.000000000","message":"ill submit a second patch to extend this one for socket.\ni think that make most sense as i will have to update the neutron-lib definiton to add the new socket value so.\n\nmechanically i dont think there will be a need for a large amount of cross colablartion outside of testing. the reason for that is this spec basically just provide a way to pass the policy name and artoms spec will be just adding a new policy so there should not need to be be  much interaction in that regard as i just need to ensure i extend neutron to support the socket polciy string after we add support in nova.\n\nworst case we woudl do that next cycle but ya ill make sure that i sync with artom and try testing with his code too. depending on which is code complte first i might base my code on top of his series but we will see how that goes.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":22,"context_line":"devices from being physically installed across all NUMA nodes on a server,"},{"line_number":23,"context_line":"e.g. high density blade/multi server systems or non standard form factor"},{"line_number":24,"context_line":"equipment. In the Ussuri release operators gained the flexibility to specify"},{"line_number":25,"context_line":"a vm wide numa affinity policy via the flavor or image however in many cases"},{"line_number":26,"context_line":"different nic have different constraint. "},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"f47bced7_1ccc153a","line":25,"range":{"start_line":25,"start_character":2,"end_line":25,"end_character":9},"updated":"2021-01-07 16:33:38.000000000","message":"nit: VM-wide","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2585b552de52297430fce2b13780378b03ffb8a6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"devices from being physically installed across all NUMA nodes on a server,"},{"line_number":23,"context_line":"e.g. high density blade/multi server systems or non standard form factor"},{"line_number":24,"context_line":"equipment. In the Ussuri release operators gained the flexibility to specify"},{"line_number":25,"context_line":"a vm wide numa affinity policy via the flavor or image however in many cases"},{"line_number":26,"context_line":"different nic have different constraint. "},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"88819abf_26feecc0","line":25,"range":{"start_line":25,"start_character":2,"end_line":25,"end_character":9},"in_reply_to":"f47bced7_1ccc153a","updated":"2021-01-18 11:17:13.000000000","message":"Done","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"29ab552c764b8fd657a013301fe4e9a9536b824d","unresolved":true,"context_lines":[{"line_number":23,"context_line":"e.g. high density blade/multi server systems or non standard form factor"},{"line_number":24,"context_line":"equipment. In the Ussuri release operators gained the flexibility to specify"},{"line_number":25,"context_line":"a vm wide numa affinity policy via the flavor or image however in many cases"},{"line_number":26,"context_line":"different nic have different constraint. "},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Use Cases"},{"line_number":29,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d6238c39_1fac0107","line":26,"range":{"start_line":26,"start_character":39,"end_line":26,"end_character":41},"updated":"2021-01-07 14:54:29.000000000","message":"Extra whitespace.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":23,"context_line":"e.g. high density blade/multi server systems or non standard form factor"},{"line_number":24,"context_line":"equipment. In the Ussuri release operators gained the flexibility to specify"},{"line_number":25,"context_line":"a vm wide numa affinity policy via the flavor or image however in many cases"},{"line_number":26,"context_line":"different nic have different constraint. "},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Use Cases"},{"line_number":29,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e8d0870d_72618dc2","line":26,"range":{"start_line":26,"start_character":10,"end_line":26,"end_character":13},"updated":"2021-01-07 16:33:38.000000000","message":"nit: NICs","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2585b552de52297430fce2b13780378b03ffb8a6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"e.g. high density blade/multi server systems or non standard form factor"},{"line_number":24,"context_line":"equipment. In the Ussuri release operators gained the flexibility to specify"},{"line_number":25,"context_line":"a vm wide numa affinity policy via the flavor or image however in many cases"},{"line_number":26,"context_line":"different nic have different constraint. "},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Use Cases"},{"line_number":29,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"17bd4a82_edc3d132","line":26,"range":{"start_line":26,"start_character":39,"end_line":26,"end_character":41},"in_reply_to":"d6238c39_1fac0107","updated":"2021-01-18 11:17:13.000000000","message":"Done","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2585b552de52297430fce2b13780378b03ffb8a6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"e.g. high density blade/multi server systems or non standard form factor"},{"line_number":24,"context_line":"equipment. In the Ussuri release operators gained the flexibility to specify"},{"line_number":25,"context_line":"a vm wide numa affinity policy via the flavor or image however in many cases"},{"line_number":26,"context_line":"different nic have different constraint. "},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Use Cases"},{"line_number":29,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fe4e3a07_3c9c59b2","line":26,"range":{"start_line":26,"start_character":10,"end_line":26,"end_character":13},"in_reply_to":"e8d0870d_72618dc2","updated":"2021-01-18 11:17:13.000000000","message":"Done","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":33,"context_line":"that differs form the vm wide pci numa affinity policy."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"As a tenant or VNF vendor, I want to be able to customize the affinity of network"},{"line_number":36,"context_line":"interfaces, based on there usage. i.e. strict affinity for for dataplane interfaces"},{"line_number":37,"context_line":"and no affinity for management interfaces."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"As an operator i wish to utilize numa aware vswitch but still be able to disable"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1c0888a4_e3c825f2","line":36,"range":{"start_line":36,"start_character":21,"end_line":36,"end_character":26},"updated":"2021-01-07 16:33:38.000000000","message":"nit: their","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":33,"context_line":"that differs form the vm wide pci numa affinity policy."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"As a tenant or VNF vendor, I want to be able to customize the affinity of network"},{"line_number":36,"context_line":"interfaces, based on there usage. i.e. strict affinity for for dataplane interfaces"},{"line_number":37,"context_line":"and no affinity for management interfaces."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"As an operator i wish to utilize numa aware vswitch but still be able to disable"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ac6b2b4e_a1f408fa","line":36,"range":{"start_line":36,"start_character":59,"end_line":36,"end_character":62},"updated":"2021-01-07 16:33:38.000000000","message":"strike","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":36,"context_line":"interfaces, based on there usage. i.e. strict affinity for for dataplane interfaces"},{"line_number":37,"context_line":"and no affinity for management interfaces."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"As an operator i wish to utilize numa aware vswitch but still be able to disable"},{"line_number":40,"context_line":"it for individual vm interfaces."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5518887f_625dc265","line":39,"range":{"start_line":39,"start_character":15,"end_line":39,"end_character":17},"updated":"2021-01-07 16:33:38.000000000","message":"nit: I","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":36,"context_line":"interfaces, based on there usage. i.e. strict affinity for for dataplane interfaces"},{"line_number":37,"context_line":"and no affinity for management interfaces."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"As an operator i wish to utilize numa aware vswitch but still be able to disable"},{"line_number":40,"context_line":"it for individual vm interfaces."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"66a52e9f_32c39632","line":39,"range":{"start_line":39,"start_character":33,"end_line":39,"end_character":51},"updated":"2021-01-07 16:33:38.000000000","message":"nit: NUMA-aware vSwitches","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2585b552de52297430fce2b13780378b03ffb8a6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"interfaces, based on there usage. i.e. strict affinity for for dataplane interfaces"},{"line_number":37,"context_line":"and no affinity for management interfaces."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"As an operator i wish to utilize numa aware vswitch but still be able to disable"},{"line_number":40,"context_line":"it for individual vm interfaces."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a14fcbe_2d98f1fe","line":39,"range":{"start_line":39,"start_character":15,"end_line":39,"end_character":17},"in_reply_to":"5518887f_625dc265","updated":"2021-01-18 11:17:13.000000000","message":"Done","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2585b552de52297430fce2b13780378b03ffb8a6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"interfaces, based on there usage. i.e. strict affinity for for dataplane interfaces"},{"line_number":37,"context_line":"and no affinity for management interfaces."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"As an operator i wish to utilize numa aware vswitch but still be able to disable"},{"line_number":40,"context_line":"it for individual vm interfaces."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a64d4422_dad7abab","line":39,"range":{"start_line":39,"start_character":33,"end_line":39,"end_character":51},"in_reply_to":"66a52e9f_32c39632","updated":"2021-01-18 11:17:13.000000000","message":"Done","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":37,"context_line":"and no affinity for management interfaces."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"As an operator i wish to utilize numa aware vswitch but still be able to disable"},{"line_number":40,"context_line":"it for individual vm interfaces."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Proposed change"},{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b2dbbf6c_b433131e","line":40,"range":{"start_line":40,"start_character":18,"end_line":40,"end_character":20},"updated":"2021-01-07 16:33:38.000000000","message":"nit: VM","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2585b552de52297430fce2b13780378b03ffb8a6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"and no affinity for management interfaces."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"As an operator i wish to utilize numa aware vswitch but still be able to disable"},{"line_number":40,"context_line":"it for individual vm interfaces."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Proposed change"},{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"07567f9b_d46479cd","line":40,"range":{"start_line":40,"start_character":18,"end_line":40,"end_character":20},"in_reply_to":"b2dbbf6c_b433131e","updated":"2021-01-18 11:17:13.000000000","message":"Done","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"29ab552c764b8fd657a013301fe4e9a9536b824d","unresolved":true,"context_lines":[{"line_number":42,"context_line":"Proposed change"},{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Per interface NUMA affinity polices will be introduced via a neutron API extension."},{"line_number":46,"context_line":"The neutron API extension introduces a new port attribute which holds the requested"},{"line_number":47,"context_line":"affinity policy. Port numa affinity policies will have a higher precedence than"},{"line_number":48,"context_line":"flavor,image or config based policy specifcations. As a result the precedence"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf936cb4_e85e249b","line":45,"range":{"start_line":45,"start_character":36,"end_line":45,"end_character":82},"updated":"2021-01-07 14:54:29.000000000","message":"Has been introduced already:\n\nhttps://specs.openstack.org/openstack/neutron-specs/specs/victoria/port-numa-affinity-policy.html\n\nhttps://docs.openstack.org/api-ref/network/v2/index.html?expanded\u003dshow-port-details-detail#show-port-details (scroll down to numa_affinity_policy)","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"797935ab3bdcd3c2ca6bc9f67dc2da9979571ce1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Proposed change"},{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Per interface NUMA affinity polices will be introduced via a neutron API extension."},{"line_number":46,"context_line":"The neutron API extension introduces a new port attribute which holds the requested"},{"line_number":47,"context_line":"affinity policy. Port numa affinity policies will have a higher precedence than"},{"line_number":48,"context_line":"flavor,image or config based policy specifcations. As a result the precedence"}],"source_content_type":"text/x-rst","patch_set":1,"id":"77bd4ca4_751e021f","line":45,"range":{"start_line":45,"start_character":36,"end_line":45,"end_character":82},"in_reply_to":"12ab839c_d36e8319","updated":"2021-01-20 13:14:24.000000000","message":"OK","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2585b552de52297430fce2b13780378b03ffb8a6","unresolved":true,"context_lines":[{"line_number":42,"context_line":"Proposed change"},{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Per interface NUMA affinity polices will be introduced via a neutron API extension."},{"line_number":46,"context_line":"The neutron API extension introduces a new port attribute which holds the requested"},{"line_number":47,"context_line":"affinity policy. Port numa affinity policies will have a higher precedence than"},{"line_number":48,"context_line":"flavor,image or config based policy specifcations. As a result the precedence"}],"source_content_type":"text/x-rst","patch_set":1,"id":"12ab839c_d36e8319","line":45,"range":{"start_line":45,"start_character":36,"end_line":45,"end_character":82},"in_reply_to":"2957c175_e33a2dec","updated":"2021-01-18 11:17:13.000000000","message":"it will be part of this spec as a follow up patch assumeing artoms spec is appoved. ill write that follow up when i submut the next version.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a07b97c82401c8f02f5a87e9e9426693dcf9e6e4","unresolved":true,"context_lines":[{"line_number":42,"context_line":"Proposed change"},{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Per interface NUMA affinity polices will be introduced via a neutron API extension."},{"line_number":46,"context_line":"The neutron API extension introduces a new port attribute which holds the requested"},{"line_number":47,"context_line":"affinity policy. Port numa affinity policies will have a higher precedence than"},{"line_number":48,"context_line":"flavor,image or config based policy specifcations. As a result the precedence"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2957c175_e33a2dec","line":45,"range":{"start_line":45,"start_character":36,"end_line":45,"end_character":82},"in_reply_to":"9ef86139_b1621f23","updated":"2021-01-15 11:39:03.000000000","message":"addig a \u0027socket\u0027 to the possible value of port.numa_affinity_policy is part of this spec or part of the other spec? Or will there be a 3rd spec (I hope not)?","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f66e6099cf83ede8dd23020bcad956767fa9ff2d","unresolved":true,"context_lines":[{"line_number":42,"context_line":"Proposed change"},{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Per interface NUMA affinity polices will be introduced via a neutron API extension."},{"line_number":46,"context_line":"The neutron API extension introduces a new port attribute which holds the requested"},{"line_number":47,"context_line":"affinity policy. Port numa affinity policies will have a higher precedence than"},{"line_number":48,"context_line":"flavor,image or config based policy specifcations. As a result the precedence"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ef86139_b1621f23","line":45,"range":{"start_line":45,"start_character":36,"end_line":45,"end_character":82},"in_reply_to":"bf936cb4_e85e249b","updated":"2021-01-08 18:41:17.000000000","message":"yep i can add a reference to it and link.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a07b97c82401c8f02f5a87e9e9426693dcf9e6e4","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Per interface NUMA affinity polices will be introduced via a neutron API extension."},{"line_number":46,"context_line":"The neutron API extension introduces a new port attribute which holds the requested"},{"line_number":47,"context_line":"affinity policy. Port numa affinity policies will have a higher precedence than"},{"line_number":48,"context_line":"flavor,image or config based policy specifcations. As a result the precedence"},{"line_number":49,"context_line":"relationship will by port \u003e image/flavor \u003e pci alias."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"14452ebb_678d1cf3","line":47,"range":{"start_line":47,"start_character":16,"end_line":47,"end_character":74},"updated":"2021-01-15 11:39:03.000000000","message":"Does the port.numa_affinity_policy is settable by admin only by default? If not then I think the admin only flavor extra_spec needs to have the higher precedence. So that the value controlled by the admin has the highest precedence","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2585b552de52297430fce2b13780378b03ffb8a6","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Per interface NUMA affinity polices will be introduced via a neutron API extension."},{"line_number":46,"context_line":"The neutron API extension introduces a new port attribute which holds the requested"},{"line_number":47,"context_line":"affinity policy. Port numa affinity policies will have a higher precedence than"},{"line_number":48,"context_line":"flavor,image or config based policy specifcations. As a result the precedence"},{"line_number":49,"context_line":"relationship will by port \u003e image/flavor \u003e pci alias."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"342e5d47_d7e01980","line":47,"range":{"start_line":47,"start_character":16,"end_line":47,"end_character":74},"in_reply_to":"14452ebb_678d1cf3","updated":"2021-01-18 11:17:13.000000000","message":"no its setable by the user and that is intentional.\nmakeign the flavour have percipience will break the primary usecase here.\n\nthe port needs to have the highest precicde as teh flavor, image and config are provide the default and the port is provideing the actual request.\n\nmakeing the flavor have precidence would break\n\n\"As an operator i wish to utilize numa aware vswitch but still be able to disable for individual vm interfaces.\"","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a58e0490372f7b83ef73568e45a55d6d2024c96f","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Per interface NUMA affinity polices will be introduced via a neutron API extension."},{"line_number":46,"context_line":"The neutron API extension introduces a new port attribute which holds the requested"},{"line_number":47,"context_line":"affinity policy. Port numa affinity policies will have a higher precedence than"},{"line_number":48,"context_line":"flavor,image or config based policy specifcations. As a result the precedence"},{"line_number":49,"context_line":"relationship will by port \u003e image/flavor \u003e pci alias."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"c0e9ec7e_543291a3","line":47,"range":{"start_line":47,"start_character":16,"end_line":47,"end_character":74},"in_reply_to":"14a5fd30_399fc433","updated":"2021-01-21 16:48:33.000000000","message":"We talked about this on the nova meeting today[1]. And I was convinced that this is less of a problem. Nova always prefer affinity regardless of the policy. Nova just not fail the boot if the policy allows suboptimal placement. So what the end user can do with the port base policy is to explicitly request / accept worse then optimal performance. \n\n[1] http://eavesdrop.openstack.org/meetings/nova/2021/nova.2021-01-21-16.00.log.html","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"797935ab3bdcd3c2ca6bc9f67dc2da9979571ce1","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Per interface NUMA affinity polices will be introduced via a neutron API extension."},{"line_number":46,"context_line":"The neutron API extension introduces a new port attribute which holds the requested"},{"line_number":47,"context_line":"affinity policy. Port numa affinity policies will have a higher precedence than"},{"line_number":48,"context_line":"flavor,image or config based policy specifcations. As a result the precedence"},{"line_number":49,"context_line":"relationship will by port \u003e image/flavor \u003e pci alias."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9bb3bcdc_494be6e7","line":47,"range":{"start_line":47,"start_character":16,"end_line":47,"end_character":74},"in_reply_to":"342e5d47_d7e01980","updated":"2021-01-20 13:14:24.000000000","message":"hm, so the user can go against the admin\u0027s decision made in the flavor by creating a new port with specific numa_affinity_policy value. In telco space there is not much admin / tenant separation so meh. If others has no problem with this then I accept.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a05dbe52779d9d5d50c94870e4656d7791fb036f","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Per interface NUMA affinity polices will be introduced via a neutron API extension."},{"line_number":46,"context_line":"The neutron API extension introduces a new port attribute which holds the requested"},{"line_number":47,"context_line":"affinity policy. Port numa affinity policies will have a higher precedence than"},{"line_number":48,"context_line":"flavor,image or config based policy specifcations. As a result the precedence"},{"line_number":49,"context_line":"relationship will by port \u003e image/flavor \u003e pci alias."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"14a5fd30_399fc433","line":47,"range":{"start_line":47,"start_character":16,"end_line":47,"end_character":74},"in_reply_to":"9bb3bcdc_494be6e7","updated":"2021-01-20 23:38:26.000000000","message":"FWIW I agree it doesn\u0027t seem to sound right for a user to be able to override policy set by admin. If the port.numa_affinity_policy was an admin API by default, then that seems OK but if not, I have the same concern as gibi.\n\nAnd it doesn\u0027t sound like giving precedence to the end user\u0027s choice is fulfilling the use case: \"As an operator i wish to utilize numa aware vswitch but still be able to disable for individual vm interfaces.\" The operator has no ability to disable numa aware vswitch for individual interfaces in this model, right? How can the operator disable numa aware vswitch for an individual interface if the user can enable it on any port?","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"379a6cb1a91a45d0a1c7ea0b76c64e84b21174d7","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Per interface NUMA affinity polices will be introduced via a neutron API extension."},{"line_number":46,"context_line":"The neutron API extension introduces a new port attribute which holds the requested"},{"line_number":47,"context_line":"affinity policy. Port numa affinity policies will have a higher precedence than"},{"line_number":48,"context_line":"flavor,image or config based policy specifcations. As a result the precedence"},{"line_number":49,"context_line":"relationship will by port \u003e image/flavor \u003e pci alias."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"b7f1fab4_c3854de1","line":47,"range":{"start_line":47,"start_character":16,"end_line":47,"end_character":74},"in_reply_to":"c0e9ec7e_543291a3","updated":"2021-01-21 21:08:24.000000000","message":"\u003e And it doesn\u0027t sound like giving precedence to the end user\u0027s choice is fulfilling the use case: \"As an operator i wish to utilize numa aware vswitch but still be able to disable for individual vm interfaces.\" The operator has no ability to disable numa aware vswitch for individual interfaces in this model, right? How can the operator disable numa aware vswitch for an individual interface if the user can enable it on any port?\n\nSean answered my questions regarding \"disabling\" affinity in #openstack-nova today and explained that the meaning of disable here is no affinity, not a prevention of affinity [1]. And that this should say \"allow a tenant to disable it for individual VM interfaces.\"\n\nI\u0027m also OK after reading the discussion from the nova meeting that strict affinity is the default behavior and this feature would allow users to opt-in to accepting preferred/best effort affinity or no affinity. So there is no notion of a user being able to override and take resources that an admin has reserved, and that is why it is not problematic to allow users policy to take precendence.\n\n[1] http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2021-01-21.log.html#t2021-01-21T20:40:01","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":46,"context_line":"The neutron API extension introduces a new port attribute which holds the requested"},{"line_number":47,"context_line":"affinity policy. Port numa affinity policies will have a higher precedence than"},{"line_number":48,"context_line":"flavor,image or config based policy specifcations. As a result the precedence"},{"line_number":49,"context_line":"relationship will by port \u003e image/flavor \u003e pci alias."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"This will enable operators to specify a default affinity policy per pci alias,"},{"line_number":52,"context_line":"this in turn can be overriden per vm via the flavor and image and finally the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"f5becb8b_382504ab","line":49,"range":{"start_line":49,"start_character":43,"end_line":49,"end_character":46},"updated":"2021-01-07 16:33:38.000000000","message":"nit: PCI (here and elsewhere)","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2585b552de52297430fce2b13780378b03ffb8a6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"The neutron API extension introduces a new port attribute which holds the requested"},{"line_number":47,"context_line":"affinity policy. Port numa affinity policies will have a higher precedence than"},{"line_number":48,"context_line":"flavor,image or config based policy specifcations. As a result the precedence"},{"line_number":49,"context_line":"relationship will by port \u003e image/flavor \u003e pci alias."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"This will enable operators to specify a default affinity policy per pci alias,"},{"line_number":52,"context_line":"this in turn can be overriden per vm via the flavor and image and finally the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a4646412_f46baa05","line":49,"range":{"start_line":49,"start_character":43,"end_line":49,"end_character":46},"in_reply_to":"f5becb8b_382504ab","updated":"2021-01-18 11:17:13.000000000","message":"Done","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":51,"context_line":"This will enable operators to specify a default affinity policy per pci alias,"},{"line_number":52,"context_line":"this in turn can be overriden per vm via the flavor and image and finally the"},{"line_number":53,"context_line":"nic affinity can be refined via the per port policy."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"The flavor- and image-based approach covers 80% of the use cases"},{"line_number":57,"context_line":"enabled by per-interface NUMA affinity polices without requiring neutron api"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8bf02685_9c10b1f7","line":54,"updated":"2021-01-07 16:33:38.000000000","message":"nit: extra newline","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":58,"context_line":"changes. Now that the neutron API has been enhanced to support port numa affinity"},{"line_number":59,"context_line":"policies this spec address the final 20% of usecases."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":".. Note ::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  This spec will address numa affinity for numa instance only. If a vm would"},{"line_number":64,"context_line":"  not otherwise have a numa topology, a per port numa affinity policy will"}],"source_content_type":"text/x-rst","patch_set":1,"id":"219667c0_2bddf037","line":61,"range":{"start_line":61,"start_character":1,"end_line":61,"end_character":10},"updated":"2021-01-07 16:33:38.000000000","message":"This should be:\n\n  .. note::\n\ni.e. lower case and no space after \u0027note\u0027. It won\u0027t render otherwise.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f66e6099cf83ede8dd23020bcad956767fa9ff2d","unresolved":true,"context_lines":[{"line_number":58,"context_line":"changes. Now that the neutron API has been enhanced to support port numa affinity"},{"line_number":59,"context_line":"policies this spec address the final 20% of usecases."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":".. Note ::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  This spec will address numa affinity for numa instance only. If a vm would"},{"line_number":64,"context_line":"  not otherwise have a numa topology, a per port numa affinity policy will"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9dfd663b_f679e5a6","line":61,"range":{"start_line":61,"start_character":1,"end_line":61,"end_character":10},"in_reply_to":"219667c0_2bddf037","updated":"2021-01-08 18:41:17.000000000","message":"ah thanks will do","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"29ab552c764b8fd657a013301fe4e9a9536b824d","unresolved":true,"context_lines":[{"line_number":61,"context_line":".. Note ::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  This spec will address numa affinity for numa instance only. If a vm would"},{"line_number":64,"context_line":"  not otherwise have a numa topology, a per port numa affinity policy will"},{"line_number":65,"context_line":"  not make the instance a numa instance. This feature will support both sriov"},{"line_number":66,"context_line":"  numa affinity and numa aware vswitches but will not apply to cyborg managed"},{"line_number":67,"context_line":"  interfaces."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"6bbaf9f9_dcd8de61","line":65,"range":{"start_line":64,"start_character":38,"end_line":65,"end_character":39},"updated":"2021-01-07 14:54:29.000000000","message":"This may be out of scope here, but should the scheduler be smart enough to prefer ports with either no `numa_affinity_policy`, or one set to either `legacy` or `None` in order to leave ports with `prefered` or `required` to instances that actually have a NUMA topology?","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"336edaaafac94443c8043d16234fee16d0f41b5c","unresolved":true,"context_lines":[{"line_number":61,"context_line":".. Note ::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  This spec will address numa affinity for numa instance only. If a vm would"},{"line_number":64,"context_line":"  not otherwise have a numa topology, a per port numa affinity policy will"},{"line_number":65,"context_line":"  not make the instance a numa instance. This feature will support both sriov"},{"line_number":66,"context_line":"  numa affinity and numa aware vswitches but will not apply to cyborg managed"},{"line_number":67,"context_line":"  interfaces."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"f0c2c494_21a26a80","line":65,"range":{"start_line":64,"start_character":38,"end_line":65,"end_character":39},"in_reply_to":"6bbaf9f9_dcd8de61","updated":"2021-01-07 15:01:03.000000000","message":"This question doesn\u0027t actually make, does it? The ports and their affinity policy come with the instance boot request; the policy is on the port(s), not on the hosts that the scheduler chooses.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f66e6099cf83ede8dd23020bcad956767fa9ff2d","unresolved":false,"context_lines":[{"line_number":61,"context_line":".. Note ::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  This spec will address numa affinity for numa instance only. If a vm would"},{"line_number":64,"context_line":"  not otherwise have a numa topology, a per port numa affinity policy will"},{"line_number":65,"context_line":"  not make the instance a numa instance. This feature will support both sriov"},{"line_number":66,"context_line":"  numa affinity and numa aware vswitches but will not apply to cyborg managed"},{"line_number":67,"context_line":"  interfaces."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"764c4741_bde30332","line":65,"range":{"start_line":64,"start_character":38,"end_line":65,"end_character":39},"in_reply_to":"bf5afea7_efa3d44b","updated":"2021-01-08 18:41:17.000000000","message":"yep also it wont make it a numa instace befaut doway even if you have a numa afinity policy in a pci alaise or on the flavor or image. they just set the affinity polciy that would be used if the vm had a numa toplogy.\n\nso to be consistent adding a policy to the port also wont make a vm a numa vm.\n\nthis is also impoartnt for thigns like attching interface to vms.\nwe dont want that to have the implication that the vms changes its numaness.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":false,"context_lines":[{"line_number":61,"context_line":".. Note ::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  This spec will address numa affinity for numa instance only. If a vm would"},{"line_number":64,"context_line":"  not otherwise have a numa topology, a per port numa affinity policy will"},{"line_number":65,"context_line":"  not make the instance a numa instance. This feature will support both sriov"},{"line_number":66,"context_line":"  numa affinity and numa aware vswitches but will not apply to cyborg managed"},{"line_number":67,"context_line":"  interfaces."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf5afea7_efa3d44b","line":65,"range":{"start_line":64,"start_character":38,"end_line":65,"end_character":39},"in_reply_to":"f0c2c494_21a26a80","updated":"2021-01-07 16:33:38.000000000","message":"\u003e This question doesn\u0027t actually make, does it? The ports and their affinity policy come with the instance boot request; the policy is on the port(s), not on the hosts that the scheduler chooses.\n\nThis ^","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a07b97c82401c8f02f5a87e9e9426693dcf9e6e4","unresolved":true,"context_lines":[{"line_number":64,"context_line":"  not otherwise have a numa topology, a per port numa affinity policy will"},{"line_number":65,"context_line":"  not make the instance a numa instance. This feature will support both sriov"},{"line_number":66,"context_line":"  numa affinity and numa aware vswitches but will not apply to cyborg managed"},{"line_number":67,"context_line":"  interfaces."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To assist with scheduling a new compute capability trait COMPUTE_NET_NUMA_AFFINITY"},{"line_number":70,"context_line":"will be added. The libvirt driver will be modified to report this trait if"}],"source_content_type":"text/x-rst","patch_set":1,"id":"eda020e3_095210a4","line":67,"updated":"2021-01-15 11:39:03.000000000","message":"Would be nice to have a matrix of supported combinations in our documentation as the situation getting pretty complex.\n\nWill nova reject a boot with a port that has numa_affinity_policy as well as device_profile set? Or is it the responsibility of neutron to reject such setup in the first place? I would prefer if neutron would enforce this.\n\nWould nova reject a boot request that has a port with numa_affinity_policy while flavor does not make the instance numa aware?","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"797935ab3bdcd3c2ca6bc9f67dc2da9979571ce1","unresolved":true,"context_lines":[{"line_number":64,"context_line":"  not otherwise have a numa topology, a per port numa affinity policy will"},{"line_number":65,"context_line":"  not make the instance a numa instance. This feature will support both sriov"},{"line_number":66,"context_line":"  numa affinity and numa aware vswitches but will not apply to cyborg managed"},{"line_number":67,"context_line":"  interfaces."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To assist with scheduling a new compute capability trait COMPUTE_NET_NUMA_AFFINITY"},{"line_number":70,"context_line":"will be added. The libvirt driver will be modified to report this trait if"}],"source_content_type":"text/x-rst","patch_set":1,"id":"379686fc_34e37fc6","line":67,"in_reply_to":"9de7f358_9c92d1b3","updated":"2021-01-20 13:14:24.000000000","message":"OK, then we need a fat warning in the neutron API doc that the value of numa_affinity_policy is ignored if device_profile is set.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2585b552de52297430fce2b13780378b03ffb8a6","unresolved":true,"context_lines":[{"line_number":64,"context_line":"  not otherwise have a numa topology, a per port numa affinity policy will"},{"line_number":65,"context_line":"  not make the instance a numa instance. This feature will support both sriov"},{"line_number":66,"context_line":"  numa affinity and numa aware vswitches but will not apply to cyborg managed"},{"line_number":67,"context_line":"  interfaces."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To assist with scheduling a new compute capability trait COMPUTE_NET_NUMA_AFFINITY"},{"line_number":70,"context_line":"will be added. The libvirt driver will be modified to report this trait if"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9de7f358_9c92d1b3","line":67,"in_reply_to":"eda020e3_095210a4","updated":"2021-01-18 11:17:13.000000000","message":"we dont support numa affintiy with cyborg at all\nwe allow all device to be used regradless of the numa toplogy of the vm.\n\nso no i was not planning to reject a both based on either a cybrog device_profile or a port with a policy request but a non numa instnace.\n\nthis is just keep things consitnt.\n\nif you use the flavor extra spec for numa affinity but dont have numa enable in the flavor or image it also does nothing. e.g we just boot and the vm wide policy has no effect.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":65,"context_line":"  not make the instance a numa instance. This feature will support both sriov"},{"line_number":66,"context_line":"  numa affinity and numa aware vswitches but will not apply to cyborg managed"},{"line_number":67,"context_line":"  interfaces."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To assist with scheduling a new compute capability trait COMPUTE_NET_NUMA_AFFINITY"},{"line_number":70,"context_line":"will be added. The libvirt driver will be modified to report this trait if"},{"line_number":71,"context_line":"it is configured with either sriov network interfaces via the pci passthough"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6aae1b33_f32f2ce6","line":68,"updated":"2021-01-07 16:33:38.000000000","message":"What happens if you try to attach an interface with this policy to an existing VM? Is that considered out-of-scope also? Will it be blocked, like we currently block ports with QoS policies (until gibi fixes that this cycle)","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a07b97c82401c8f02f5a87e9e9426693dcf9e6e4","unresolved":true,"context_lines":[{"line_number":65,"context_line":"  not make the instance a numa instance. This feature will support both sriov"},{"line_number":66,"context_line":"  numa affinity and numa aware vswitches but will not apply to cyborg managed"},{"line_number":67,"context_line":"  interfaces."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To assist with scheduling a new compute capability trait COMPUTE_NET_NUMA_AFFINITY"},{"line_number":70,"context_line":"will be added. The libvirt driver will be modified to report this trait if"},{"line_number":71,"context_line":"it is configured with either sriov network interfaces via the pci passthough"}],"source_content_type":"text/x-rst","patch_set":1,"id":"aecc729c_936c17c1","line":68,"in_reply_to":"109167ad_9686550c","updated":"2021-01-15 11:39:03.000000000","message":"what happens when you try to attach such port to an instance that is not numa aware?","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f66e6099cf83ede8dd23020bcad956767fa9ff2d","unresolved":true,"context_lines":[{"line_number":65,"context_line":"  not make the instance a numa instance. This feature will support both sriov"},{"line_number":66,"context_line":"  numa affinity and numa aware vswitches but will not apply to cyborg managed"},{"line_number":67,"context_line":"  interfaces."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To assist with scheduling a new compute capability trait COMPUTE_NET_NUMA_AFFINITY"},{"line_number":70,"context_line":"will be added. The libvirt driver will be modified to report this trait if"},{"line_number":71,"context_line":"it is configured with either sriov network interfaces via the pci passthough"}],"source_content_type":"text/x-rst","patch_set":1,"id":"109167ad_9686550c","line":68,"in_reply_to":"6aae1b33_f32f2ce6","updated":"2021-01-08 18:41:17.000000000","message":"gibi added sriov attach/detach suport last cycle which already support the affintiy policy form the flavor/image https://specs.openstack.org/openstack/nova-specs/specs/victoria/implemented/sriov-interface-attach-detach.html\n\nso i plan to just reuse that and pass the polciy form the port as part of the pci_request object.\n\nfor numa aware vswitchs i still dont know exactly how to validate that the affinity can be achived so if i was to declare it out of scope that would be the reason.\n\nwe currenlty allow attach with numa aware vswitch i belive without checking?\nhttps://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/numa-aware-vswitches.html\ndoes not  explcitly adress attach/detach form a quick skim \nthe InstanceNUMANetworks might have some info we could use for validation but you know that code better then i do.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2585b552de52297430fce2b13780378b03ffb8a6","unresolved":true,"context_lines":[{"line_number":65,"context_line":"  not make the instance a numa instance. This feature will support both sriov"},{"line_number":66,"context_line":"  numa affinity and numa aware vswitches but will not apply to cyborg managed"},{"line_number":67,"context_line":"  interfaces."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To assist with scheduling a new compute capability trait COMPUTE_NET_NUMA_AFFINITY"},{"line_number":70,"context_line":"will be added. The libvirt driver will be modified to report this trait if"},{"line_number":71,"context_line":"it is configured with either sriov network interfaces via the pci passthough"}],"source_content_type":"text/x-rst","patch_set":1,"id":"605ea0a3_4b7b6956","line":68,"in_reply_to":"aecc729c_936c17c1","updated":"2021-01-18 11:17:13.000000000","message":"we ignore the policy since its a non numa instance.\nthe same is true for attaching an sriov port today with the flaovr or image property set.\n\nstephen also confirmed that when we attach interface in conjunction with numa aware vswitchs we ignore numa for attach entirely even for that case.\n\ni had not planned to fix that when i started but it will be a streach goal.\n\nif i can ill ensure that we check numa affinity for attachment when its a numa instance and ignore it for non numa instance to be consistent. if its a non numa instance then its floating over all cores so we ignore all numa affinity policy request in that case since there is nothing to affinitize \ntoo.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":66,"context_line":"  numa affinity and numa aware vswitches but will not apply to cyborg managed"},{"line_number":67,"context_line":"  interfaces."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To assist with scheduling a new compute capability trait COMPUTE_NET_NUMA_AFFINITY"},{"line_number":70,"context_line":"will be added. The libvirt driver will be modified to report this trait if"},{"line_number":71,"context_line":"it is configured with either sriov network interfaces via the pci passthough"},{"line_number":72,"context_line":"whitelist or numa aware vswitches."}],"source_content_type":"text/x-rst","patch_set":1,"id":"817656d7_5bf46c6f","line":69,"range":{"start_line":69,"start_character":57,"end_line":69,"end_character":82},"updated":"2021-01-07 16:33:38.000000000","message":"nit: ``COMPUTE_NET_NUMA_AFFINITY``","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To assist with scheduling a new compute capability trait COMPUTE_NET_NUMA_AFFINITY"},{"line_number":70,"context_line":"will be added. The libvirt driver will be modified to report this trait if"},{"line_number":71,"context_line":"it is configured with either sriov network interfaces via the pci passthough"},{"line_number":72,"context_line":"whitelist or numa aware vswitches."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"A prefilter will be added to append a required traits request to the unnamed"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a43db294_7da44df1","line":71,"range":{"start_line":71,"start_character":29,"end_line":71,"end_character":34},"updated":"2021-01-07 16:33:38.000000000","message":"nit: SR-IOV","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0eb77246832b213d3936a11f4ad4f7854d28aa37","unresolved":true,"context_lines":[{"line_number":71,"context_line":"it is configured with either sriov network interfaces via the pci passthough"},{"line_number":72,"context_line":"whitelist or numa aware vswitches."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"A prefilter will be added to append a required traits request to the unnamed"},{"line_number":75,"context_line":"traits group when a port numa affinity policy is present. This is required"},{"line_number":76,"context_line":"to the required the strict affinity policy ``require`` for numa deployments"},{"line_number":77,"context_line":"that use numa aware vswitches."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"6d0cf96e_1529f591","line":75,"range":{"start_line":74,"start_character":1,"end_line":75,"end_character":58},"updated":"2020-12-08 03:31:53.000000000","message":"actully no the request spec does not have acess to the network_request via the request_spec object so  we will\nretrunt the trait request as part of create_resource_requests\n\nhttps://github.com/openstack/nova/blob/eff1af46857dfe146c3cdb7736f71953c5e9413e/nova/network/neutron.py#L2049-L2152","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f66e6099cf83ede8dd23020bcad956767fa9ff2d","unresolved":true,"context_lines":[{"line_number":71,"context_line":"it is configured with either sriov network interfaces via the pci passthough"},{"line_number":72,"context_line":"whitelist or numa aware vswitches."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"A prefilter will be added to append a required traits request to the unnamed"},{"line_number":75,"context_line":"traits group when a port numa affinity policy is present. This is required"},{"line_number":76,"context_line":"to the required the strict affinity policy ``require`` for numa deployments"},{"line_number":77,"context_line":"that use numa aware vswitches."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"93f0d017_8e5fbb50","line":75,"range":{"start_line":74,"start_character":1,"end_line":75,"end_character":58},"in_reply_to":"6d0cf96e_1529f591","updated":"2021-01-08 18:41:17.000000000","message":"actully it wil sylvain is adding it in the routed network spec.\nhttps://review.opendev.org/c/openstack/nova/+/749977/4\nso i just need to depend on that.\nill added in the depency section when i respin","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a07b97c82401c8f02f5a87e9e9426693dcf9e6e4","unresolved":true,"context_lines":[{"line_number":75,"context_line":"traits group when a port numa affinity policy is present. This is required"},{"line_number":76,"context_line":"to the required the strict affinity policy ``require`` for numa deployments"},{"line_number":77,"context_line":"that use numa aware vswitches."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Alternatives"},{"line_number":80,"context_line":"------------"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"92892b16_959a9e46","line":78,"updated":"2021-01-15 11:39:03.000000000","message":"Does the numa_affinity_policy settable on a bound port in neutron?","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2585b552de52297430fce2b13780378b03ffb8a6","unresolved":true,"context_lines":[{"line_number":75,"context_line":"traits group when a port numa affinity policy is present. This is required"},{"line_number":76,"context_line":"to the required the strict affinity policy ``require`` for numa deployments"},{"line_number":77,"context_line":"that use numa aware vswitches."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Alternatives"},{"line_number":80,"context_line":"------------"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"e2fcd558_53fbb7c0","line":78,"in_reply_to":"92892b16_959a9e46","updated":"2021-01-18 11:17:13.000000000","message":"yes it proably will be but only becasuse neutron in general does not look at the port status when attribute are set on a port.\n\nideally it would be blocked but i dont know if that was implemented.\nits perhaps something that could be hardened at a later date.\nim planning to more or less ignore that. it might be reasonably to pick it up for move operations but it wont affect the running instance on its current host.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"797935ab3bdcd3c2ca6bc9f67dc2da9979571ce1","unresolved":true,"context_lines":[{"line_number":75,"context_line":"traits group when a port numa affinity policy is present. This is required"},{"line_number":76,"context_line":"to the required the strict affinity policy ``require`` for numa deployments"},{"line_number":77,"context_line":"that use numa aware vswitches."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Alternatives"},{"line_number":80,"context_line":"------------"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"13d022b8_e9cbb65c","line":78,"in_reply_to":"e2fcd558_53fbb7c0","updated":"2021-01-20 13:14:24.000000000","message":"Then again we need a warning in the neutron API doc that changing that value on a bound port has no effect on the VM the port is currently bound to.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":80,"context_line":"------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"None"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c4346709_5e741bd5","line":83,"updated":"2021-01-07 16:33:38.000000000","message":"nit: extra newline","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2585b552de52297430fce2b13780378b03ffb8a6","unresolved":false,"context_lines":[{"line_number":80,"context_line":"------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"None"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7bcacf57_6fd1332c","line":83,"in_reply_to":"c4346709_5e741bd5","updated":"2021-01-18 11:17:13.000000000","message":"Done","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":86,"context_line":"Data model impact"},{"line_number":87,"context_line":"-----------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The nova.network.model.VIF object will be extended with a numa affinity policy."},{"line_number":90,"context_line":"while this is stored in the database, it is stored as a json blob"},{"line_number":91,"context_line":"so it will not alter the schema or rpc objects."},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"45f10b04_36ff1996","line":89,"range":{"start_line":89,"start_character":4,"end_line":89,"end_character":26},"updated":"2021-01-07 16:33:38.000000000","message":"``nova.network.model.VIF``","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":87,"context_line":"-----------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The nova.network.model.VIF object will be extended with a numa affinity policy."},{"line_number":90,"context_line":"while this is stored in the database, it is stored as a json blob"},{"line_number":91,"context_line":"so it will not alter the schema or rpc objects."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"90af223f_415d74b8","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":1},"updated":"2021-01-07 16:33:38.000000000","message":"nit: While (capitalise)","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":94,"context_line":"---------------"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"There will be no direct changes to any existing API in Nova. However,"},{"line_number":97,"context_line":"a new api extension has been added to neutron to store the port numa affinity"},{"line_number":98,"context_line":"policy."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a48fde73_aad28480","line":97,"range":{"start_line":97,"start_character":6,"end_line":97,"end_character":9},"updated":"2021-01-07 16:33:38.000000000","message":"nit: API","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"There will be no direct changes to any existing API in Nova. However,"},{"line_number":97,"context_line":"a new api extension has been added to neutron to store the port numa affinity"},{"line_number":98,"context_line":"policy."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Security impact"},{"line_number":101,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"83346f07_2c43f060","line":98,"updated":"2021-01-07 16:33:38.000000000","message":"Link?","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f66e6099cf83ede8dd23020bcad956767fa9ff2d","unresolved":true,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"There will be no direct changes to any existing API in Nova. However,"},{"line_number":97,"context_line":"a new api extension has been added to neutron to store the port numa affinity"},{"line_number":98,"context_line":"policy."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Security impact"},{"line_number":101,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dd0e82b0_51f665a2","line":98,"in_reply_to":"83346f07_2c43f060","updated":"2021-01-08 18:41:17.000000000","message":"https://specs.openstack.org/openstack/neutron-specs/specs/victoria/port-numa-affinity-policy.html\n\nartom copied it above but ill adde it to the refrences section and refer to it in both places.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8eab6c61d8e5201a6a141379f89eec25e0050ec1","unresolved":true,"context_lines":[{"line_number":168,"context_line":"As this feature relates to SR-IOV it cannot be tested in the upstream gate"},{"line_number":169,"context_line":"via tempest. Unit tests will be provided to assert that the policy"},{"line_number":170,"context_line":"is correctly conveyed to the existing PCI assignment code and the existing"},{"line_number":171,"context_line":"functional test can be extended as required."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"As this feature simply provides another way to specify the PCI affinity policy"},{"line_number":174,"context_line":"the code change is minimal and can leverage much of the existing test coverage."}],"source_content_type":"text/x-rst","patch_set":1,"id":"2123d64a_eea4698a","line":171,"updated":"2021-01-07 16:33:38.000000000","message":"Yes, we should be able to functionally test this with careful modifications to the \u0027NeutronFixture\u0027","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f66e6099cf83ede8dd23020bcad956767fa9ff2d","unresolved":true,"context_lines":[{"line_number":168,"context_line":"As this feature relates to SR-IOV it cannot be tested in the upstream gate"},{"line_number":169,"context_line":"via tempest. Unit tests will be provided to assert that the policy"},{"line_number":170,"context_line":"is correctly conveyed to the existing PCI assignment code and the existing"},{"line_number":171,"context_line":"functional test can be extended as required."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"As this feature simply provides another way to specify the PCI affinity policy"},{"line_number":174,"context_line":"the code change is minimal and can leverage much of the existing test coverage."}],"source_content_type":"text/x-rst","patch_set":1,"id":"b6388c7b_0aa19245","line":171,"in_reply_to":"2123d64a_eea4698a","updated":"2021-01-08 18:41:17.000000000","message":"yep we have been building out our numa/pci funcitonal test infrastucture over the last few cycles. it thinke we are at or close too the point were there is enough of the infrastucure there to more or less fully test this that way.","commit_id":"8cd698a70842196d1d864ba35155bebcf5d1bc29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e29bb355b10f71854c39f60ecc9e3e6863d65cb7","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Port Scoped SR-IOV NUMA Affinity Policies"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/port-scoped-sriov-numa-affinity"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"a7afcc41_dfb0158d","line":9,"range":{"start_line":9,"start_character":37,"end_line":9,"end_character":39},"updated":"2021-01-18 14:24:30.000000000","message":"This line isn\u0027t long enough","commit_id":"7483b91327bdbd854829fedcd95f253c70b1c905"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e29bb355b10f71854c39f60ecc9e3e6863d65cb7","unresolved":true,"context_lines":[{"line_number":32,"context_line":"hardware, I wish to specify a per-port NUMA affinity policy for SR-IOV devices"},{"line_number":33,"context_line":"that differs form the VM-wide pci NUMA affinity policy."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"As a tenant or VNF vendor, I want to be able to customize the affinity of network"},{"line_number":36,"context_line":"interfaces, based on their usage. i.e. strict affinity for dataplane interfaces"},{"line_number":37,"context_line":"and no affinity for management interfaces."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"690c37d8_afbcb6e0","line":35,"range":{"start_line":35,"start_character":79,"end_line":35,"end_character":81},"updated":"2021-01-18 14:24:30.000000000","message":"This line is too long. Others below too (you need to wrap at \u003c\u003d 79 chars)","commit_id":"7483b91327bdbd854829fedcd95f253c70b1c905"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"08b6940cc9f6d02217a749e6600583f0697be224","unresolved":false,"context_lines":[{"line_number":32,"context_line":"hardware, I wish to specify a per-port NUMA affinity policy for SR-IOV devices"},{"line_number":33,"context_line":"that differs form the VM-wide pci NUMA affinity policy."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"As a tenant or VNF vendor, I want to be able to customize the affinity of network"},{"line_number":36,"context_line":"interfaces, based on their usage. i.e. strict affinity for dataplane interfaces"},{"line_number":37,"context_line":"and no affinity for management interfaces."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5be7dcd7_28d84f75","line":35,"range":{"start_line":35,"start_character":79,"end_line":35,"end_character":81},"in_reply_to":"690c37d8_afbcb6e0","updated":"2021-01-18 14:35:38.000000000","message":"Done","commit_id":"7483b91327bdbd854829fedcd95f253c70b1c905"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e29bb355b10f71854c39f60ecc9e3e6863d65cb7","unresolved":true,"context_lines":[{"line_number":46,"context_line":"API extension [2]. The neutron API extension introduces a new port attribute"},{"line_number":47,"context_line":"which holds the requested affinity policy. Port NUMA affinity policies will"},{"line_number":48,"context_line":"have a higher precedence than flavor,image or config based policy specifications."},{"line_number":49,"context_line":"As a result the precedence relationship will by port \u003e image/flavor \u003e PCI alias."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"This will enable operators to specify a default affinity policy per PCI alias,"},{"line_number":52,"context_line":"this in turn can be overriden per VM via the flavor and image and finally the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa4e9344_edc65e7f","line":49,"range":{"start_line":49,"start_character":45,"end_line":49,"end_character":47},"updated":"2021-01-18 14:24:30.000000000","message":"be","commit_id":"7483b91327bdbd854829fedcd95f253c70b1c905"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"08b6940cc9f6d02217a749e6600583f0697be224","unresolved":false,"context_lines":[{"line_number":46,"context_line":"API extension [2]. The neutron API extension introduces a new port attribute"},{"line_number":47,"context_line":"which holds the requested affinity policy. Port NUMA affinity policies will"},{"line_number":48,"context_line":"have a higher precedence than flavor,image or config based policy specifications."},{"line_number":49,"context_line":"As a result the precedence relationship will by port \u003e image/flavor \u003e PCI alias."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"This will enable operators to specify a default affinity policy per PCI alias,"},{"line_number":52,"context_line":"this in turn can be overriden per VM via the flavor and image and finally the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"018ddaaf_62a1f01b","line":49,"range":{"start_line":49,"start_character":45,"end_line":49,"end_character":47},"in_reply_to":"fa4e9344_edc65e7f","updated":"2021-01-18 14:35:38.000000000","message":"Done","commit_id":"7483b91327bdbd854829fedcd95f253c70b1c905"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e29bb355b10f71854c39f60ecc9e3e6863d65cb7","unresolved":true,"context_lines":[{"line_number":53,"context_line":"NIC affinity can be refined via the per port policy."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"The flavor- and image-based approach covers 80% of the use cases"},{"line_number":56,"context_line":"enabled by per-interface NUMA affinity polices without requiring neutron api"},{"line_number":57,"context_line":"changes. Now that the neutron API has been enhanced to support port NUMA affinity"},{"line_number":58,"context_line":"policies this spec address the final 20% of usecases."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"b466910a_e2846f2c","line":56,"range":{"start_line":56,"start_character":73,"end_line":56,"end_character":76},"updated":"2021-01-18 14:24:30.000000000","message":"API","commit_id":"7483b91327bdbd854829fedcd95f253c70b1c905"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e29bb355b10f71854c39f60ecc9e3e6863d65cb7","unresolved":true,"context_lines":[{"line_number":55,"context_line":"The flavor- and image-based approach covers 80% of the use cases"},{"line_number":56,"context_line":"enabled by per-interface NUMA affinity polices without requiring neutron api"},{"line_number":57,"context_line":"changes. Now that the neutron API has been enhanced to support port NUMA affinity"},{"line_number":58,"context_line":"policies this spec address the final 20% of usecases."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":".. note::"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"6c3ef9c7_6ca4464b","line":58,"range":{"start_line":58,"start_character":19,"end_line":58,"end_character":26},"updated":"2021-01-18 14:24:30.000000000","message":"can address","commit_id":"7483b91327bdbd854829fedcd95f253c70b1c905"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e29bb355b10f71854c39f60ecc9e3e6863d65cb7","unresolved":true,"context_lines":[{"line_number":75,"context_line":"to the required the strict affinity policy ``require`` for NUMA deployments"},{"line_number":76,"context_line":"that use NUMA aware vswitches."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"The neutron api extension [2] will be update to support the newly added"},{"line_number":79,"context_line":"socket pci affinity policy [3]."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"87bee9f4_92894535","line":78,"range":{"start_line":78,"start_character":26,"end_line":78,"end_character":29},"updated":"2021-01-18 14:24:30.000000000","message":"missing trailing underscore, here and for the rest of the references (the first one is okay)","commit_id":"7483b91327bdbd854829fedcd95f253c70b1c905"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"08b6940cc9f6d02217a749e6600583f0697be224","unresolved":false,"context_lines":[{"line_number":75,"context_line":"to the required the strict affinity policy ``require`` for NUMA deployments"},{"line_number":76,"context_line":"that use NUMA aware vswitches."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"The neutron api extension [2] will be update to support the newly added"},{"line_number":79,"context_line":"socket pci affinity policy [3]."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3cff6e8d_c0aa8c91","line":78,"range":{"start_line":78,"start_character":26,"end_line":78,"end_character":29},"in_reply_to":"87bee9f4_92894535","updated":"2021-01-18 14:35:38.000000000","message":"Done","commit_id":"7483b91327bdbd854829fedcd95f253c70b1c905"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e29bb355b10f71854c39f60ecc9e3e6863d65cb7","unresolved":true,"context_lines":[{"line_number":160,"context_line":"Dependencies"},{"line_number":161,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"The socket numa affinity policy depends on [3]."},{"line_number":164,"context_line":"The only other dependency is on extending the request spec"},{"line_number":165,"context_line":"object to store the requested networks. This is part"},{"line_number":166,"context_line":"of the routed networks spec [4] implemented by [5]."}],"source_content_type":"text/x-rst","patch_set":2,"id":"2e862b5f_01e28053","line":163,"range":{"start_line":163,"start_character":11,"end_line":163,"end_character":15},"updated":"2021-01-18 14:24:30.000000000","message":"NUMA","commit_id":"7483b91327bdbd854829fedcd95f253c70b1c905"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e29bb355b10f71854c39f60ecc9e3e6863d65cb7","unresolved":true,"context_lines":[{"line_number":191,"context_line":".. [3] https://specs.openstack.org/openstack/nova-specs/specs/wallaby/approved/pci-socket-policy.html"},{"line_number":192,"context_line":".. [4] https://specs.openstack.org/openstack/nova-specs/specs/wallaby/approved/routed-networks-scheduling.html"},{"line_number":193,"context_line":".. [5] https://review.opendev.org/c/openstack/nova/+/749977"},{"line_number":194,"context_line":"History"},{"line_number":195,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":".. list-table:: Revisions"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a816069_ace61764","line":194,"updated":"2021-01-18 14:24:30.000000000","message":"newline before this","commit_id":"7483b91327bdbd854829fedcd95f253c70b1c905"}]}