)]}'
{"specs/wallaby/approved/support-fuzzy-querying-instances-by-tag.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"87fc33f1136a7b38fa0913f9fb06fcaaeb4e19d1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9f9c547e_5a2c7f99","updated":"2021-04-14 12:19:38.000000000","message":"please propose this in the specs/xena/approved directory","commit_id":"f0b48be9269bbe5d29f0ea03975fef26a9cc2ef5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b5ff1a2b6db94ade3dc6e0bda2ab06160e1e3d7a","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":"Currently, only supportting for accurate querying instances by the instance\u0027s"},{"line_number":19,"context_line":"tag. It can\u0027t fuzzy query instance by tag, this is not frinendly for the"},{"line_number":20,"context_line":"enduser."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8383ba33_3c546acb","line":19,"range":{"start_line":19,"start_character":55,"end_line":19,"end_character":64},"updated":"2021-01-20 11:40:47.000000000","message":"friendly","commit_id":"f0b48be9269bbe5d29f0ea03975fef26a9cc2ef5"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"2498477412835381e2053b1726da44aad1b30558","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":"Currently, only supportting for accurate querying instances by the instance\u0027s"},{"line_number":19,"context_line":"tag. It can\u0027t fuzzy query instance by tag, this is not frinendly for the"},{"line_number":20,"context_line":"enduser."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2a05d353_7282b35c","line":19,"range":{"start_line":19,"start_character":55,"end_line":19,"end_character":64},"in_reply_to":"8383ba33_3c546acb","updated":"2021-03-04 02:00:52.000000000","message":"haha! I\u0027m sorry.","commit_id":"f0b48be9269bbe5d29f0ea03975fef26a9cc2ef5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b5ff1a2b6db94ade3dc6e0bda2ab06160e1e3d7a","unresolved":true,"context_lines":[{"line_number":41,"context_line":"---------------"},{"line_number":42,"context_line":"Add a new microversion to the ``list servers`` and ``list servers detailed``"},{"line_number":43,"context_line":"APIs."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Security impact"},{"line_number":46,"context_line":"---------------"},{"line_number":47,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2d67340b_36d12bf4","line":44,"updated":"2021-01-20 11:40:47.000000000","message":"How will this look to the user? Will there be a new parameter or will you reuse existing ones? If the latter, how does someone revert to a strict match lookup? What about the tag endpoints (\u0027/server/{server}/tags\u0027 and \u0027/server/{server}/tags/{tag}\u0027)","commit_id":"f0b48be9269bbe5d29f0ea03975fef26a9cc2ef5"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"2498477412835381e2053b1726da44aad1b30558","unresolved":true,"context_lines":[{"line_number":41,"context_line":"---------------"},{"line_number":42,"context_line":"Add a new microversion to the ``list servers`` and ``list servers detailed``"},{"line_number":43,"context_line":"APIs."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Security impact"},{"line_number":46,"context_line":"---------------"},{"line_number":47,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1dda6514_6b955446","line":44,"in_reply_to":"2d67340b_36d12bf4","updated":"2021-03-04 02:00:52.000000000","message":"Histephenfin:\nThe API is /servers/detail?tags\u003dXXX. This API supports strict match and fuzzy match. When the \"XXX\"\u003d\u003dinstance\u0027s tag is the strict match, the \"XXX\" in instance\u0027s tag is the fuzzy match.","commit_id":"f0b48be9269bbe5d29f0ea03975fef26a9cc2ef5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b5ff1a2b6db94ade3dc6e0bda2ab06160e1e3d7a","unresolved":true,"context_lines":[{"line_number":91,"context_line":"----------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"* \"models.Tag.tag \u003d\u003d first_tag\" is changed to"},{"line_number":94,"context_line":"* \"models.Tag.tag.like(first_tag)\"."},{"line_number":95,"context_line":"* Add unit and functional tests"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"88bb52b7_791af48c","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":35},"updated":"2021-01-20 11:40:47.000000000","message":"There\u0027s a significant performance impact to this that should be noted above [1]. Also, does this have an impact on pagination? Previous uses of \u0027like\u0027 haven\u0027t supported pagination [2]\n\n[1] https://stackoverflow.com/questions/6142235/sql-like-vs-performance\n[2] https://review.opendev.org/c/openstack/nova/+/471899/22/nova/api/openstack/compute/hypervisors.py#136","commit_id":"f0b48be9269bbe5d29f0ea03975fef26a9cc2ef5"},{"author":{"_account_id":30077,"name":"Qiu Fossen","display_name":"fossnqiu","email":"qiujunting@inspur.com","username":"qiufossen"},"change_message_id":"2498477412835381e2053b1726da44aad1b30558","unresolved":true,"context_lines":[{"line_number":91,"context_line":"----------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"* \"models.Tag.tag \u003d\u003d first_tag\" is changed to"},{"line_number":94,"context_line":"* \"models.Tag.tag.like(first_tag)\"."},{"line_number":95,"context_line":"* Add unit and functional tests"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"f1815eda_192b8328","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":35},"in_reply_to":"88bb52b7_791af48c","updated":"2021-03-04 02:00:52.000000000","message":"[1] \"like\" can match more instances. But the user, only using the partial character of the intsance\u0027s tag to get the instances. This increases the user\u0027s query speed and make the match tag operation simpler.\n\n[2]According [2], i cen\u0027t find some impact for pagination.","commit_id":"f0b48be9269bbe5d29f0ea03975fef26a9cc2ef5"}],"specs/xena/approved/support-fuzzy-querying-instances-by-tag.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b3bacf9172b3490da274ded69ad05f79c0815da2","unresolved":true,"context_lines":[{"line_number":18,"context_line":"Currently, only supportting for accurate querying instances by the instance\u0027s"},{"line_number":19,"context_line":"tag. It can\u0027t fuzzy query instance by tag, this is not frinendly for the"},{"line_number":20,"context_line":"enduser."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Use Cases"},{"line_number":23,"context_line":"---------"},{"line_number":24,"context_line":"As a user, we want to get the instances by the partial character of the tag"}],"source_content_type":"text/x-rst","patch_set":2,"id":"c4d0a59a_0b3e955f","line":21,"updated":"2021-04-15 18:54:55.000000000","message":"so our current fuzzy regex support for querying instance by name with a regex relys on the end user knowing which db the cloud is using (mysql vs postgress) and then formating the api request in the dbs native regex format.\n\nif we want to support any kind of regex/wildcard base querying in the api going forward \ni think we shoudl require the query to be in python regex format and use sqlalchems support for\ntranslating those quies into the dbms native format.\n\nhttps://docs.sqlalchemy.org/en/14/core/sqlelement.html?highlight\u003dregexp_match#sqlalchemy.sql.expression.ColumnElement.regexp_match\n\n\nit was added in sqlalchemy 1.4\n\nhttps://docs.sqlalchemy.org/en/14/changelog/migration_14.html?highlight\u003dregexp_match#support-for-sql-regular-expression-operators\n\n\ni dont think we shoudl do any filtering in the nova python code.","commit_id":"bde4c540dd42c68502f8688b7214f1845f4661ba"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"90795544b43cb117881c4aef32829918c4485932","unresolved":true,"context_lines":[{"line_number":27,"context_line":"Proposed change"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":"Add a new microversion to the ``list servers`` and ``list servers detailed``"},{"line_number":30,"context_line":"APIs."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Alternatives"},{"line_number":33,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5215f7d0_43117543","line":30,"updated":"2021-07-06 09:52:55.000000000","message":"Please explain more what would be the change for the microversion.","commit_id":"bde4c540dd42c68502f8688b7214f1845f4661ba"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"90795544b43cb117881c4aef32829918c4485932","unresolved":true,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Performance Impact"},{"line_number":58,"context_line":"------------------"},{"line_number":59,"context_line":"None"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Other deployer impact"},{"line_number":62,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba97424a_0fad5ac1","line":59,"updated":"2021-07-06 09:52:55.000000000","message":"Hum, really ? Even for, say, 10000 instances ?","commit_id":"bde4c540dd42c68502f8688b7214f1845f4661ba"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b3bacf9172b3490da274ded69ad05f79c0815da2","unresolved":true,"context_lines":[{"line_number":91,"context_line":"----------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"* \"models.Tag.tag \u003d\u003d first_tag\" is changed to"},{"line_number":94,"context_line":"* \"models.Tag.tag.like(first_tag)\"."},{"line_number":95,"context_line":"* Add unit and functional tests"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9b408196_a0522c5c","line":94,"range":{"start_line":94,"start_character":1,"end_line":94,"end_character":35},"updated":"2021-04-15 18:54:55.000000000","message":"if we do this we should supprot regexes not a partial sub string match\nand we should do this in a dbms independent way using the abstraction layer provided by sqlalcahmy.","commit_id":"bde4c540dd42c68502f8688b7214f1845f4661ba"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"90795544b43cb117881c4aef32829918c4485932","unresolved":true,"context_lines":[{"line_number":91,"context_line":"----------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"* \"models.Tag.tag \u003d\u003d first_tag\" is changed to"},{"line_number":94,"context_line":"* \"models.Tag.tag.like(first_tag)\"."},{"line_number":95,"context_line":"* Add unit and functional tests"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"23c13c1e_4c0024f6","line":94,"range":{"start_line":94,"start_character":1,"end_line":94,"end_character":35},"in_reply_to":"9b408196_a0522c5c","updated":"2021-07-06 09:52:55.000000000","message":"totally agreed, we shouldn\u0027t just have a API call that would directly call the DB by the regex.","commit_id":"bde4c540dd42c68502f8688b7214f1845f4661ba"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"abdf01856c77cad9ca8877559da301bf3d9af20d","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"   * - Release Name"},{"line_number":120,"context_line":"     - Description"},{"line_number":121,"context_line":"   * - Ussuri"},{"line_number":122,"context_line":"     - Introduced"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5ff185ee_a88f9c88","line":121,"range":{"start_line":121,"start_character":7,"end_line":121,"end_character":13},"updated":"2021-07-06 13:45:17.000000000","message":"Xena","commit_id":"bde4c540dd42c68502f8688b7214f1845f4661ba"}]}