)]}'
{"specs/wallaby/approved/configurable-instance-hostnames.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dfb3e1b5f1bdf8e6b1a65985399bfa4bfed505cb","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Where multiple instances are requested, hostnames will be suffixed with"},{"line_number":57,"context_line":"``-{idx}``, where ``{idx}`` is a 1-based index. If necessary, the provided"},{"line_number":58,"context_line":"hostname will be truncated to keep under the 63 character limit."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8158e9cc_14f6fc9e","line":58,"range":{"start_line":58,"start_character":9,"end_line":58,"end_character":27},"updated":"2021-01-20 13:26:22.000000000","message":"I assume that we need to truncate from the front of the hostname to avoid truncating off the running index itself. The result sounds to be bad either way. I think it would be better to simply reject the multicreate if the hostname for the last instance cannot be generated without truncation.","commit_id":"c443f666acc221d5e09210e9e769acaf77a61ab8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5aa1139f6628865ad8c62ca57c216136e33dbc0c","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Where multiple instances are requested, hostnames will be suffixed with"},{"line_number":57,"context_line":"``-{idx}``, where ``{idx}`` is a 1-based index. If necessary, the provided"},{"line_number":58,"context_line":"hostname will be truncated to keep under the 63 character limit."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d555795f_915aa5cc","line":58,"range":{"start_line":58,"start_character":9,"end_line":58,"end_character":27},"in_reply_to":"8158e9cc_14f6fc9e","updated":"2021-01-22 15:20:59.000000000","message":"Good point. We can do this simple validation in the API layer, so let\u0027s reject it there.","commit_id":"c443f666acc221d5e09210e9e769acaf77a61ab8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dfb3e1b5f1bdf8e6b1a65985399bfa4bfed505cb","unresolved":true,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"A new microversion will be introduced. When this microversion is used,"},{"line_number":88,"context_line":"users will be able to pass an additional ``hostname`` field when creating new"},{"line_number":89,"context_line":"server(s) (``POST /servers``) and when updating an existing server"},{"line_number":90,"context_line":"(``PUT /servers/{id}``). This ``hostname`` attribute will have the following"},{"line_number":91,"context_line":"constraints:"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"077a8a15_5ccaa878","line":89,"range":{"start_line":89,"start_character":39,"end_line":89,"end_character":47},"updated":"2021-01-20 13:26:22.000000000","message":"does such update will be reflected in the metadata service? (I guess it won\u0027t be reflected in the config driver). Does nova will tell neutron that the hostname is changed?","commit_id":"c443f666acc221d5e09210e9e769acaf77a61ab8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5aa1139f6628865ad8c62ca57c216136e33dbc0c","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"A new microversion will be introduced. When this microversion is used,"},{"line_number":88,"context_line":"users will be able to pass an additional ``hostname`` field when creating new"},{"line_number":89,"context_line":"server(s) (``POST /servers``) and when updating an existing server"},{"line_number":90,"context_line":"(``PUT /servers/{id}``). This ``hostname`` attribute will have the following"},{"line_number":91,"context_line":"constraints:"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7259c6a2_4019d8b2","line":89,"range":{"start_line":89,"start_character":39,"end_line":89,"end_character":47},"in_reply_to":"077a8a15_5ccaa878","updated":"2021-01-22 15:20:59.000000000","message":"Yes (not for config drive) and yes","commit_id":"c443f666acc221d5e09210e9e769acaf77a61ab8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dfb3e1b5f1bdf8e6b1a65985399bfa4bfed505cb","unresolved":true,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Where multiple instances are requested, hostnames will be suffixed with"},{"line_number":99,"context_line":"``-{idx}``, where ``{idx}`` is a 1-based index. If necessary, the provided"},{"line_number":100,"context_line":"hostname will be truncated to keep under the 63 character limit."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Security impact"},{"line_number":103,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"49ad1763_b71e54a4","line":100,"range":{"start_line":100,"start_character":17,"end_line":100,"end_character":26},"updated":"2021-01-20 13:26:22.000000000","message":"same as above","commit_id":"c443f666acc221d5e09210e9e769acaf77a61ab8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5aa1139f6628865ad8c62ca57c216136e33dbc0c","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Where multiple instances are requested, hostnames will be suffixed with"},{"line_number":99,"context_line":"``-{idx}``, where ``{idx}`` is a 1-based index. If necessary, the provided"},{"line_number":100,"context_line":"hostname will be truncated to keep under the 63 character limit."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Security impact"},{"line_number":103,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"16fdc958_db6d90a4","line":100,"range":{"start_line":100,"start_character":17,"end_line":100,"end_character":26},"in_reply_to":"49ad1763_b71e54a4","updated":"2021-01-22 15:20:59.000000000","message":"Done","commit_id":"c443f666acc221d5e09210e9e769acaf77a61ab8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dfb3e1b5f1bdf8e6b1a65985399bfa4bfed505cb","unresolved":true,"context_lines":[{"line_number":140,"context_line":"Upgrade impact"},{"line_number":141,"context_line":"--------------"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"None."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"90332911_31a67b68","line":143,"updated":"2021-01-20 13:26:22.000000000","message":"Yes, all the current VMs has a hostname value it just generated by nova based on the display name. So all the old VMs are valid in this new feature perspective.","commit_id":"c443f666acc221d5e09210e9e769acaf77a61ab8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5aa1139f6628865ad8c62ca57c216136e33dbc0c","unresolved":false,"context_lines":[{"line_number":140,"context_line":"Upgrade impact"},{"line_number":141,"context_line":"--------------"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"None."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2f21fb90_b4ead501","line":143,"in_reply_to":"90332911_31a67b68","updated":"2021-01-22 15:20:59.000000000","message":"Ack","commit_id":"c443f666acc221d5e09210e9e769acaf77a61ab8"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"a77d8ccacde0e35bf2d341f1a48970697e8e1f96","unresolved":true,"context_lines":[{"line_number":21,"context_line":"name combined with the domain value specified in ``[api] dhcp_domain``. As part"},{"line_number":22,"context_line":"of the discussion around `bug 1581977`__, it was noted that there is currently"},{"line_number":23,"context_line":"no way to explicitly specify a hostname and decouple it from the display name."},{"line_number":24,"context_line":"We use the instance\u0027s hostname when `DNS integration is enabled in neutron`__,"},{"line_number":25,"context_line":"and this can result in a lack of control over hostnames, preventing users doing"},{"line_number":26,"context_line":"reasonable things like naming their instances based on the fully-qualified"},{"line_number":27,"context_line":"domain name that the instance will eventually be available at."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3b4b1f4e_04f1b15e","line":24,"range":{"start_line":24,"start_character":22,"end_line":24,"end_character":30},"updated":"2021-01-22 16:12:43.000000000","message":"Do you mean display name? IOW, you mean \"we derive the instance hostname from the display name\"?","commit_id":"a218e65dc0ff22d5fa481d6cabcfea2d0b264cf3"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"a77d8ccacde0e35bf2d341f1a48970697e8e1f96","unresolved":true,"context_lines":[{"line_number":23,"context_line":"no way to explicitly specify a hostname and decouple it from the display name."},{"line_number":24,"context_line":"We use the instance\u0027s hostname when `DNS integration is enabled in neutron`__,"},{"line_number":25,"context_line":"and this can result in a lack of control over hostnames, preventing users doing"},{"line_number":26,"context_line":"reasonable things like naming their instances based on the fully-qualified"},{"line_number":27,"context_line":"domain name that the instance will eventually be available at."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Correct this gap by allowing users to specify an explicit hostname when"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dd43930e_6bc3fbcc","line":26,"range":{"start_line":26,"start_character":23,"end_line":26,"end_character":29},"updated":"2021-01-22 16:12:43.000000000","message":"You\u0027re going to have to be excruciatingly specific when talking about names here :) In this case, it looks like you\u0027re talking about the display name?","commit_id":"a218e65dc0ff22d5fa481d6cabcfea2d0b264cf3"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"a77d8ccacde0e35bf2d341f1a48970697e8e1f96","unresolved":true,"context_lines":[{"line_number":183,"context_line":"Testing"},{"line_number":184,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"This can be tested via Tempest tests, though this will likely require the"},{"line_number":187,"context_line":"`designate-tempest-plugin`__ package. The bulk of the lifting will be done"},{"line_number":188,"context_line":"with functional and unit tests."},{"line_number":189,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"60de4fc8_ee7f6adb","line":186,"updated":"2021-01-22 16:12:43.000000000","message":"Not really - we can test everything else (API, metadata) with just Tempest itself.","commit_id":"a218e65dc0ff22d5fa481d6cabcfea2d0b264cf3"}]}