)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"30cc4a1f4bf41ab8d84ed54e1950d8e7d5189e9c","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-01-19 17:59:38 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: Add support for flavor and image defined ephemeral encryption"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib73f88be0fbc18fcbb100111989399faf8cbfb2b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"140f275c_2cce2b92","line":8,"updated":"2021-01-20 10:16:45.000000000","message":"please refer to https://blueprints.launchpad.net/nova/+spec/ephemeral-storage-encryption here","commit_id":"a2bcfac1ad998036d14f317097538166012b0429"}],"specs/wallaby/approved/ephemeral-encryption-libvirt.rst":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"2a59603833cfa97fba5c6b770dbe32a6d5d64ba8","unresolved":true,"context_lines":[{"line_number":45,"context_line":"Proposed change"},{"line_number":46,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"It is recommend that readers review the `virt block layer primer`_ before"},{"line_number":49,"context_line":"reading further."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Deprecate the legacy implementation within the libvirt driver"},{"line_number":52,"context_line":"-------------------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"491f1a2d_6a7a6e57","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":16},"updated":"2021-01-19 17:41:02.000000000","message":"FWIW I\u0027m writing this up in a formal reference doc, almost 5 years after Matt posted it to the mailing list.","commit_id":"0f6903a6325bc2149a69d999b51aa5bd6784bb17"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ba495e5da0261706de83a785a789c546db07908e","unresolved":true,"context_lines":[{"line_number":62,"context_line":"Limited support for ``dm-crypt`` will be introduced using the new framework"},{"line_number":63,"context_line":"before this original implementation is removed."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Introduce DriverImageBlockDevice and add it to block_device_info"},{"line_number":66,"context_line":"----------------------------------------------------------------"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"In order to provide access from the virt layer to the various ephemeral"},{"line_number":69,"context_line":"encryption attributes added to the ``BlockDeviceMapping`` object in the parent"},{"line_number":70,"context_line":"spec we first need to introduce a ``DriverBlockDevice`` class specific to disks"},{"line_number":71,"context_line":"backed by an image."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"This has long been a TODO within the virt block device layer and allows us to"},{"line_number":74,"context_line":"provide direct access to the underlying ``BlockDeviceMapping`` object and"},{"line_number":75,"context_line":"database records for image based disks from within virt drivers."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"To provide access we also need to modify the ``block_device_info`` dict"},{"line_number":78,"context_line":"provided to the virt layer. This currently contains the following:"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"``root_device_name``"},{"line_number":81,"context_line":"    device name of the root disk"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"``ephemerals``"},{"line_number":84,"context_line":"    A (potentially empty) list of ``DriverEphemeralBlockDevice`` instances"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"``swap``"},{"line_number":87,"context_line":"    An instance of ``DriverSwapBlockDevice`` or none"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"``block_device_mapping``"},{"line_number":90,"context_line":"    A (potentially empty) list of ``DriverVolumeBlockDevice`` or any of it\u0027s"},{"line_number":91,"context_line":"    more specialized subclasses."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"The following will now be added to this dict for any image based disk:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"``image``"},{"line_number":96,"context_line":"    Contains a single ``DriverImageBlockDevice`` instance"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Populate disk_info with encryption properties"},{"line_number":99,"context_line":"---------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"009d831d_a9ec92ed","line":96,"range":{"start_line":65,"start_character":0,"end_line":96,"end_character":57},"updated":"2021-01-19 17:43:14.000000000","message":"https://specs.openstack.org/openstack/nova-specs/specs/wallaby/approved/ephemeral-encryption.html#expose-ephemeral-encryption-attributes-via-block-device-info This is already in the parent spec, not sure why I included it again.","commit_id":"0f6903a6325bc2149a69d999b51aa5bd6784bb17"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"2a59603833cfa97fba5c6b770dbe32a6d5d64ba8","unresolved":true,"context_lines":[{"line_number":297,"context_line":".. _`Flavour and Image defined ephemeral storage encryption`: https://specs.openstack.org/openstack/nova-specs/specs/wallaby/approved/ephemeral-encryption.html"},{"line_number":298,"context_line":".. _`workarounds`: https://docs.openstack.org/nova/victoria/configuration/config.html#workarounds.disable_native_luksv1"},{"line_number":299,"context_line":".. _`virt block layer primer`: http://lists.openstack.org/pipermail/openstack-dev/2016-June/097529.html"},{"line_number":300,"context_line":".. _`feature support matrix`: https://docs.openstack.org/nova/latest/user/support-matrix.html"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"History"},{"line_number":303,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfe0a0c5_4e464d25","line":300,"range":{"start_line":300,"start_character":0,"end_line":300,"end_character":93},"updated":"2021-01-19 17:41:02.000000000","message":"I didn\u0027t reference this in the end, I\u0027ll remove in a respin.","commit_id":"0f6903a6325bc2149a69d999b51aa5bd6784bb17"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"30cc4a1f4bf41ab8d84ed54e1950d8e7d5189e9c","unresolved":true,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The libvirt driver has an additional ``disk_info`` dict built from the contents"},{"line_number":73,"context_line":"of the previously mentioned ``block_device_info`` and image metadata associated"},{"line_number":74,"context_line":"with an instance. With the introduction of the ``DriverImageBlockDevice`` above"},{"line_number":75,"context_line":"we can now avoid the need to look again at image metadata while also adding"},{"line_number":76,"context_line":"some ephemeral encryption related metadata to the dict."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"17f57e75_cc99759b","line":74,"range":{"start_line":74,"start_character":74,"end_line":74,"end_character":79},"updated":"2021-01-20 10:16:45.000000000","message":"I guess it refers to https://review.opendev.org/c/openstack/nova-specs/+/752284","commit_id":"a2bcfac1ad998036d14f317097538166012b0429"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"15ccd1ec566c82f3c36e1167b989583de4edebad","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The libvirt driver has an additional ``disk_info`` dict built from the contents"},{"line_number":73,"context_line":"of the previously mentioned ``block_device_info`` and image metadata associated"},{"line_number":74,"context_line":"with an instance. With the introduction of the ``DriverImageBlockDevice`` above"},{"line_number":75,"context_line":"we can now avoid the need to look again at image metadata while also adding"},{"line_number":76,"context_line":"some ephemeral encryption related metadata to the dict."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1c61cbbc_4d590cd1","line":74,"range":{"start_line":74,"start_character":74,"end_line":74,"end_character":79},"in_reply_to":"17f57e75_cc99759b","updated":"2021-01-20 10:38:22.000000000","message":"Done","commit_id":"a2bcfac1ad998036d14f317097538166012b0429"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a0fad519ae6053f4fb8731ba77197ece451c9b8c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"libvirt driver support for flavor and image defined ephemeral encryption"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/ephemeral-storage-encryption"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec outlines the specific libvirt virt driver implementation to support"},{"line_number":14,"context_line":"the `Flavor and Image defined ephemeral storage encryption`_ spec."}],"source_content_type":"text/x-rst","patch_set":3,"id":"4b88def3_e945c4c5","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":72},"updated":"2021-01-20 11:47:14.000000000","message":"Exists (Y)","commit_id":"c25cf64a652dfbfeb4618909b73aa48ef756c7c4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a0fad519ae6053f4fb8731ba77197ece451c9b8c","unresolved":true,"context_lines":[{"line_number":29,"context_line":"encryption`_ spec we can now implement support for encrypting ephemeral disks"},{"line_number":30,"context_line":"via images and flavors, allowing support for newer encryption formats such as"},{"line_number":31,"context_line":"`LUKSv1`. This also has the benefit of being natively supported by `QEMU`, as"},{"line_number":32,"context_line":"already used by the libvirt driver when attaching  `LUKSv1` encrypted volumes"},{"line_number":33,"context_line":"provided by Cinder."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d8146db1_e1b62105","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":15},"updated":"2021-01-20 11:47:14.000000000","message":"seen in ?","commit_id":"c25cf64a652dfbfeb4618909b73aa48ef756c7c4"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"11ca2244bbceee990a31f589a044bda88851f92b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"encryption`_ spec we can now implement support for encrypting ephemeral disks"},{"line_number":30,"context_line":"via images and flavors, allowing support for newer encryption formats such as"},{"line_number":31,"context_line":"`LUKSv1`. This also has the benefit of being natively supported by `QEMU`, as"},{"line_number":32,"context_line":"already used by the libvirt driver when attaching  `LUKSv1` encrypted volumes"},{"line_number":33,"context_line":"provided by Cinder."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":3,"id":"82dbf4d4_788a61e2","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":15},"in_reply_to":"d8146db1_e1b62105","updated":"2021-01-20 12:03:10.000000000","message":"Done","commit_id":"c25cf64a652dfbfeb4618909b73aa48ef756c7c4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a0fad519ae6053f4fb8731ba77197ece451c9b8c","unresolved":true,"context_lines":[{"line_number":36,"context_line":"---------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* As a user of a cloud with libvirt based computes I want to request that all"},{"line_number":39,"context_line":"  of my ephemeral storage is encrypted at rest through the selection of a"},{"line_number":40,"context_line":"  specific flavor or image."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* As a user of a cloud with libvirt based computes I want to be able to pick"}],"source_content_type":"text/x-rst","patch_set":3,"id":"4bcc66ff_71157019","line":39,"range":{"start_line":39,"start_character":26,"end_line":39,"end_character":28},"updated":"2021-01-20 11:47:14.000000000","message":"be ?","commit_id":"c25cf64a652dfbfeb4618909b73aa48ef756c7c4"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"11ca2244bbceee990a31f589a044bda88851f92b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"---------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* As a user of a cloud with libvirt based computes I want to request that all"},{"line_number":39,"context_line":"  of my ephemeral storage is encrypted at rest through the selection of a"},{"line_number":40,"context_line":"  specific flavor or image."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* As a user of a cloud with libvirt based computes I want to be able to pick"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9608881b_6fabd6c2","line":39,"range":{"start_line":39,"start_character":26,"end_line":39,"end_character":28},"in_reply_to":"4bcc66ff_71157019","updated":"2021-01-20 12:03:10.000000000","message":"Done","commit_id":"c25cf64a652dfbfeb4618909b73aa48ef756c7c4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a0fad519ae6053f4fb8731ba77197ece451c9b8c","unresolved":true,"context_lines":[{"line_number":39,"context_line":"  of my ephemeral storage is encrypted at rest through the selection of a"},{"line_number":40,"context_line":"  specific flavor or image."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* As a user of a cloud with libvirt based computes I want to be able to pick"},{"line_number":43,"context_line":"  how my ephemeral storage is encrypted at rest through the selection of a"},{"line_number":44,"context_line":"  specific flavor or image."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7c796b0c_54167610","line":42,"range":{"start_line":42,"start_character":35,"end_line":42,"end_character":36},"updated":"2021-01-20 11:47:14.000000000","message":"-","commit_id":"c25cf64a652dfbfeb4618909b73aa48ef756c7c4"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"11ca2244bbceee990a31f589a044bda88851f92b","unresolved":true,"context_lines":[{"line_number":39,"context_line":"  of my ephemeral storage is encrypted at rest through the selection of a"},{"line_number":40,"context_line":"  specific flavor or image."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* As a user of a cloud with libvirt based computes I want to be able to pick"},{"line_number":43,"context_line":"  how my ephemeral storage is encrypted at rest through the selection of a"},{"line_number":44,"context_line":"  specific flavor or image."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"8d2cb115_4637446b","line":42,"range":{"start_line":42,"start_character":35,"end_line":42,"end_character":36},"in_reply_to":"7c796b0c_54167610","updated":"2021-01-20 12:03:10.000000000","message":"Not sure what you\u0027re asking for here.","commit_id":"c25cf64a652dfbfeb4618909b73aa48ef756c7c4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7b08c3ebdb68014bb659dff1ca70bc2bbcacd99b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  of my ephemeral storage is encrypted at rest through the selection of a"},{"line_number":40,"context_line":"  specific flavor or image."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* As a user of a cloud with libvirt based computes I want to be able to pick"},{"line_number":43,"context_line":"  how my ephemeral storage is encrypted at rest through the selection of a"},{"line_number":44,"context_line":"  specific flavor or image."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"019d118f_821a7ba9","line":42,"range":{"start_line":42,"start_character":35,"end_line":42,"end_character":36},"in_reply_to":"8d2cb115_4637446b","updated":"2021-01-20 18:25:16.000000000","message":"Oh, sorry. I meant \"libvirt-based\" (with hyphen)","commit_id":"c25cf64a652dfbfeb4618909b73aa48ef756c7c4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a0fad519ae6053f4fb8731ba77197ece451c9b8c","unresolved":true,"context_lines":[{"line_number":145,"context_line":"``nova.virt.libvirt.imagebackend.Image.create_image`` using the provided"},{"line_number":146,"context_line":"format, options and secret."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Enable the COMPUTE_EPHEMERAL_ENCRYPTION_LUKS trait"},{"line_number":149,"context_line":"--------------------------------------------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Finally, with the above support in place the ``COMPUTE_EPHEMERAL_ENCRYPTION``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"0b4b0d05_a64f26d4","line":148,"range":{"start_line":148,"start_character":11,"end_line":148,"end_character":45},"updated":"2021-01-20 11:47:14.000000000","message":"``code``","commit_id":"c25cf64a652dfbfeb4618909b73aa48ef756c7c4"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"11ca2244bbceee990a31f589a044bda88851f92b","unresolved":false,"context_lines":[{"line_number":145,"context_line":"``nova.virt.libvirt.imagebackend.Image.create_image`` using the provided"},{"line_number":146,"context_line":"format, options and secret."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Enable the COMPUTE_EPHEMERAL_ENCRYPTION_LUKS trait"},{"line_number":149,"context_line":"--------------------------------------------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Finally, with the above support in place the ``COMPUTE_EPHEMERAL_ENCRYPTION``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"36f03d06_56eefbd3","line":148,"range":{"start_line":148,"start_character":11,"end_line":148,"end_character":45},"in_reply_to":"0b4b0d05_a64f26d4","updated":"2021-01-20 12:03:10.000000000","message":"Done","commit_id":"c25cf64a652dfbfeb4618909b73aa48ef756c7c4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a0fad519ae6053f4fb8731ba77197ece451c9b8c","unresolved":true,"context_lines":[{"line_number":260,"context_line":"Documentation Impact"},{"line_number":261,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"* New user documentation around the specific ``LUKSv1`` support for epehemeral"},{"line_number":264,"context_line":"  encryption within the libvirt driver."},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"* Reference documentation around the changes to the virt block device layer."}],"source_content_type":"text/x-rst","patch_set":3,"id":"c07ecfce_7b2def3f","line":263,"range":{"start_line":263,"start_character":68,"end_line":263,"end_character":78},"updated":"2021-01-20 11:47:14.000000000","message":"ephemeral","commit_id":"c25cf64a652dfbfeb4618909b73aa48ef756c7c4"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"63b8a42f7f59e8136c0b0bde796774b65ee141ee","unresolved":false,"context_lines":[{"line_number":260,"context_line":"Documentation Impact"},{"line_number":261,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"* New user documentation around the specific ``LUKSv1`` support for epehemeral"},{"line_number":264,"context_line":"  encryption within the libvirt driver."},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"* Reference documentation around the changes to the virt block device layer."}],"source_content_type":"text/x-rst","patch_set":3,"id":"dfdac42d_24386aa5","line":263,"range":{"start_line":263,"start_character":68,"end_line":263,"end_character":78},"in_reply_to":"c07ecfce_7b2def3f","updated":"2021-01-20 12:02:34.000000000","message":"Done","commit_id":"c25cf64a652dfbfeb4618909b73aa48ef756c7c4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a0fad519ae6053f4fb8731ba77197ece451c9b8c","unresolved":true,"context_lines":[{"line_number":268,"context_line":"References"},{"line_number":269,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":".. _`Flavor and Image defined ephemeral storage encryption`: https://specs.openstack.org/openstack/nova-specs/specs/wallaby/approved/ephemeral-encryption.html"},{"line_number":272,"context_line":".. _`workarounds`: https://docs.openstack.org/nova/victoria/configuration/config.html#workarounds.disable_native_luksv1"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"History"}],"source_content_type":"text/x-rst","patch_set":3,"id":"4b67547a_f9fbcb96","line":271,"updated":"2021-01-20 11:47:14.000000000","message":"This really only makes sense if you use reference-style links\n\n  Hello, world [1]_.\n\n  .. [1] https://example.com\n\nAs this is, nothing will render here.","commit_id":"c25cf64a652dfbfeb4618909b73aa48ef756c7c4"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"63b8a42f7f59e8136c0b0bde796774b65ee141ee","unresolved":false,"context_lines":[{"line_number":268,"context_line":"References"},{"line_number":269,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":".. _`Flavor and Image defined ephemeral storage encryption`: https://specs.openstack.org/openstack/nova-specs/specs/wallaby/approved/ephemeral-encryption.html"},{"line_number":272,"context_line":".. _`workarounds`: https://docs.openstack.org/nova/victoria/configuration/config.html#workarounds.disable_native_luksv1"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"History"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7cfb6835_7669d9cb","line":271,"in_reply_to":"4b67547a_f9fbcb96","updated":"2021-01-20 12:02:34.000000000","message":"Done","commit_id":"c25cf64a652dfbfeb4618909b73aa48ef756c7c4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a0fad519ae6053f4fb8731ba77197ece451c9b8c","unresolved":true,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"Optional section intended to be used each time the spec is updated to describe"},{"line_number":278,"context_line":"new design, API or any database schema updated. Useful to let reader understand"},{"line_number":279,"context_line":"what\u0027s happened along the time."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":".. list-table:: Revisions"},{"line_number":282,"context_line":"   :header-rows: 1"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ccde85f2_9153e0f1","line":279,"updated":"2021-01-20 11:47:14.000000000","message":"Drop","commit_id":"c25cf64a652dfbfeb4618909b73aa48ef756c7c4"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"11ca2244bbceee990a31f589a044bda88851f92b","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"Optional section intended to be used each time the spec is updated to describe"},{"line_number":278,"context_line":"new design, API or any database schema updated. Useful to let reader understand"},{"line_number":279,"context_line":"what\u0027s happened along the time."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":".. list-table:: Revisions"},{"line_number":282,"context_line":"   :header-rows: 1"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9168eb0f_fe1a4643","line":279,"in_reply_to":"ccde85f2_9153e0f1","updated":"2021-01-20 12:03:10.000000000","message":"Done","commit_id":"c25cf64a652dfbfeb4618909b73aa48ef756c7c4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fb4334af094997c13e319a9975bd821f01c9ef8a","unresolved":true,"context_lines":[{"line_number":26,"context_line":"encryption via Cinder."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"With the introduction of the Flavor and Image defined ephemeral storage"},{"line_number":29,"context_line":"encryption [1]_ spec we can now implement support for encrypting ephemeral disks"},{"line_number":30,"context_line":"via images and flavors, allowing support for newer encryption formats such as"},{"line_number":31,"context_line":"`LUKSv1`. This also has the benefit of being natively supported by `QEMU`, as"},{"line_number":32,"context_line":"already seen in the libvirt driver when attaching  `LUKSv1` encrypted volumes"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5c46a992_0d0f5117","line":29,"range":{"start_line":29,"start_character":75,"end_line":29,"end_character":80},"updated":"2021-01-20 13:37:59.000000000","message":"you need to wrap this line","commit_id":"563b1f9438a7d7285cf32e6fc030151db2d37a68"}]}