)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2f35dec18376bac3b4bb17fa3a5cbc38fad75b7c","unresolved":true,"context_lines":[{"line_number":12,"context_line":"this code for unsupported operations with cyborg accelerators. However,"},{"line_number":13,"context_line":"HTTP 403 (Forbidden) isn\u0027t a great choice for this, as it suggests"},{"line_number":14,"context_line":"issues with authorization as opposed to a request the server simply"},{"line_number":15,"context_line":"can\u0027t support. HTTP 409 (Conflict) isn\u0027t much better, but it does avoid"},{"line_number":16,"context_line":"confusion with policy issues and aligns us with two other existing"},{"line_number":17,"context_line":"examples: unsupported operations on instances with vTPM devices and"},{"line_number":18,"context_line":"instances with SEV enabled."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cd37e4fe_c3ee3e59","line":15,"range":{"start_line":15,"start_character":14,"end_line":15,"end_character":53},"updated":"2021-03-21 18:02:44.000000000","message":"i would argue its much worse then a 403.\na 409 is ment to be used when a clinet can potentially correct the issue and retry\nthe request where as a 403 was orgininally chosen for cyborg and for vdpa \nbecause you are not allowed to retry the same request wehn you recive a 403\nautomatically with the same token. i.e. a http complent cleint may not retry\na request with the same credentails and payload if it recived a 403 where as\nit may retry the request if it recives a 409 either with the same payload or a different\none. we have lost that distinciton by using a 409 which is why a 403 was originally chosen.\n\nif we were to change the respocne code we shoudl have gone to a 400.\nthe code is merged now so im not going to push for the errocode to be reverted to a 403\nin this cycle but i think it was incorrecct to change ti to a 409.\nwe can disucss this at the PTG however at this point and should just update teh spec\nto reflect the fact that we deviated from it.","commit_id":"149c4fa48932e790d3783d47455eef24a6eca55f"}]}
