)]}'
{"specs/wallaby/approved/server-join-remove-server-group.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5853030137c31e352a477f3ca4c1c5eeb61793f7","unresolved":true,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"13061516_d9e622f6","line":1,"updated":"2021-03-23 03:38:51.000000000","message":"one thing i will note is that this should be in the xena specs directory not wallaby","commit_id":"8255104afbfa774050d00d2e7fa566ad18429060"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bbdd5232e2253766748b106fa5d1d6f77ace5a36","unresolved":true,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"f841cce0_e2f652c5","line":1,"in_reply_to":"13061516_d9e622f6","updated":"2021-04-14 12:37:28.000000000","message":"+1","commit_id":"8255104afbfa774050d00d2e7fa566ad18429060"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"451a4479cb0e0359860566d896f8517f319ab244","unresolved":true,"context_lines":[{"line_number":50,"context_line":"* (api) update instance_group in ``request_spec`` and scheduler_hint. we also"},{"line_number":51,"context_line":"  add the instance uuid to the members of ``InstanceGroup``."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* (conductor) call ``resize_instance`` to perform cold migration of the"},{"line_number":54,"context_line":"  instance. Cold migration make the instance to follow the policy of server"},{"line_number":55,"context_line":"  group."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"c5e82913_2a7961f5","line":53,"updated":"2021-03-23 13:26:10.000000000","message":"-1 to this.\ni dont think we shoudl automatically cold migrate,\n\nfirstly if we were to have the action trigger a migration we should\nallow the user to specify if the migration shoudl be a live migratrion or\ncold migrateion as part of the actuion request.\n\nsecondly migrations are normally admin only so im not sure we should allow\nnormal user to do this.\nthe only non admin move way to do a cold migration is the resize api.\nim not sure we shoudl be extending this capablity in this case.\n\nperhaps it could use the project_admin role?\nbut i dont think admin_or_owner would be correct in this case form a policy perspective.\n\n\nif the instance does not already fullfile the policy we shoudl instead retrun a 409 or 400\nerror to the user.","commit_id":"8255104afbfa774050d00d2e7fa566ad18429060"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f24a7b0d1c6a88fa604043b1c78e435c7c878f73","unresolved":true,"context_lines":[{"line_number":50,"context_line":"* (api) update instance_group in ``request_spec`` and scheduler_hint. we also"},{"line_number":51,"context_line":"  add the instance uuid to the members of ``InstanceGroup``."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* (conductor) call ``resize_instance`` to perform cold migration of the"},{"line_number":54,"context_line":"  instance. Cold migration make the instance to follow the policy of server"},{"line_number":55,"context_line":"  group."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ca4fa356_77d65fd3","line":53,"in_reply_to":"317f8cf9_5f380ca1","updated":"2021-04-26 14:30:16.000000000","message":"we actually have a third option i guess which is we could allow a \"force\" option\n\nif force was passed we could either bypass the affinity check and add it to the group\nallowing a future move operation to fix it or we could have force do the migration.\n\ni do also agree that if we did the migration  the existing migration api could be extended.  i would almost prefer however to just allow you to violate the policy when adding a new server group and then just say migrate them after but adding this to resize or other move operation could work but it feel like they shoudl be separate things.","commit_id":"8255104afbfa774050d00d2e7fa566ad18429060"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4c1a76867f018de0735e2ceea81508d69982ba2c","unresolved":true,"context_lines":[{"line_number":50,"context_line":"* (api) update instance_group in ``request_spec`` and scheduler_hint. we also"},{"line_number":51,"context_line":"  add the instance uuid to the members of ``InstanceGroup``."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* (conductor) call ``resize_instance`` to perform cold migration of the"},{"line_number":54,"context_line":"  instance. Cold migration make the instance to follow the policy of server"},{"line_number":55,"context_line":"  group."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"317f8cf9_5f380ca1","line":53,"in_reply_to":"c5e82913_2a7961f5","updated":"2021-04-14 12:09:57.000000000","message":"This is a complicated topic. And both directions have issues. \n\nAutomatically triggering migration is confusing for the user. So if we go that direction then I would suggest to extend the migration / resize / live migration API to specify the new group instead. This would allow moving servers between groups as well. Also this way the heavy operation is more explicitly visible to the user and the API policy is applied from the more expensive operation perspective.\n\nIf we go with the check-the-policy-at-group-change-and-reject-if-it-is-not-already -fulfilled direction, then we have a problem of pre-creating a situation where the VM is already in a good place so that it can be added to the group. \n\nAlso please note that special care needs to be taken as a server can only be part of 0 or 1 server group at a time.","commit_id":"8255104afbfa774050d00d2e7fa566ad18429060"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"63ad0a63f450e17b6ac0e97e20f243ccdc526996","unresolved":true,"context_lines":[{"line_number":50,"context_line":"* (api) update instance_group in ``request_spec`` and scheduler_hint. we also"},{"line_number":51,"context_line":"  add the instance uuid to the members of ``InstanceGroup``."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* (conductor) call ``resize_instance`` to perform cold migration of the"},{"line_number":54,"context_line":"  instance. Cold migration make the instance to follow the policy of server"},{"line_number":55,"context_line":"  group."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"54ab0848_861fbca0","line":53,"in_reply_to":"ca4fa356_77d65fd3","updated":"2021-04-27 10:05:57.000000000","message":"the \u0027force\u0027 option will become confuse after the action. the user doesn\u0027t know whether the instance match the affinity. and no way to correct that.\n\nmore prefer to extending the migration API.","commit_id":"8255104afbfa774050d00d2e7fa566ad18429060"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"451a4479cb0e0359860566d896f8517f319ab244","unresolved":true,"context_lines":[{"line_number":64,"context_line":"  ``instance.host`` to ``ignore_host``."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* (conductor) call ``resize_instance`` to perform cold migration of the"},{"line_number":67,"context_line":"  instance."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"In addition, we need to change the ``ServerGroupAntiAffinityFilter`` in"},{"line_number":70,"context_line":"scheduler. Because this filter always return true for the host of instance,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"655c7675_30e0e093","line":67,"updated":"2021-03-23 13:26:10.000000000","message":"removing a server form a group should never resolt in moving the vm regardless of what we do on adding a server to a group.\n\nso you shoudl remove this","commit_id":"8255104afbfa774050d00d2e7fa566ad18429060"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"451a4479cb0e0359860566d896f8517f319ab244","unresolved":true,"context_lines":[{"line_number":103,"context_line":"        }"},{"line_number":104,"context_line":"    leaveServerGroup"},{"line_number":105,"context_line":"        {"},{"line_number":106,"context_line":"            \"leaveServerGroup\": {"},{"line_number":107,"context_line":"            }"},{"line_number":108,"context_line":"        }"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"2df066bb_1af182f8","line":106,"range":{"start_line":106,"start_character":32,"end_line":106,"end_character":33},"updated":"2021-03-23 13:26:10.000000000","message":"this shoudl support {} and null","commit_id":"8255104afbfa774050d00d2e7fa566ad18429060"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"451a4479cb0e0359860566d896f8517f319ab244","unresolved":true,"context_lines":[{"line_number":108,"context_line":"        }"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"If join/remove server group is not applicable because of the restrictions defined above,"},{"line_number":111,"context_line":"an exception will be raised and a HTTP response with status code 400"},{"line_number":112,"context_line":"(Bad Request) will be returned. Otherwise, a HTTP response with status code"},{"line_number":113,"context_line":"202 (Accepted) will be returned."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"4fc82d3d_c7ca956d","line":111,"range":{"start_line":111,"start_character":65,"end_line":111,"end_character":68},"updated":"2021-03-23 13:26:10.000000000","message":"yes 400 or 409 are both ok in this case.","commit_id":"8255104afbfa774050d00d2e7fa566ad18429060"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"451a4479cb0e0359860566d896f8517f319ab244","unresolved":true,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"The ``os_compute_api:servers:join_server_group`` and"},{"line_number":119,"context_line":"``os_compute_api:servers:leave_server_group`` policy rule will by default"},{"line_number":120,"context_line":"be admin or owner."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Notifications impact"},{"line_number":123,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7b6c52e5_ae86b62b","line":120,"range":{"start_line":120,"start_character":3,"end_line":120,"end_character":18},"updated":"2021-03-23 13:26:10.000000000","message":"if we were to implement this and have the implict move operation i think it should be project_admin\nnot admin or owner","commit_id":"8255104afbfa774050d00d2e7fa566ad18429060"}]}