)]}'
{"id":"openstack%2Fnova-specs~782353","triplet_id":"openstack%2Fnova-specs~master~I7858c50302067b795db0b10e326489d669ea7c7d","project":"openstack/nova-specs","branch":"master","topic":"join-remove-sg","hashtags":[],"change_id":"I7858c50302067b795db0b10e326489d669ea7c7d","subject":"add instance join/leave server group","status":"ABANDONED","created":"2021-03-23 02:30:35.000000000","updated":"2021-05-25 14:40:56.000000000","total_comment_count":10,"unresolved_comment_count":6,"has_review_started":true,"meta_rev_id":"b0046119e35e162b2e66cfb696db5fa9b8313ecf","_number":782353,"virtual_id_number":782353,"owner":{"_account_id":32269,"name":"xinyu wang","email":"wangxinyu@inspur.com","username":"xyuwang"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-03-23 02:42:17.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":-1,"date":"2021-03-23 03:38:51.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":-1,"date":"2021-04-27 10:05:57.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":-1,"date":"2021-04-14 12:09:57.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-23 02:42:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-23 03:37:11.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"CC"},{"updated":"2021-03-23 03:38:51.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2021-04-14 12:09:57.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2021-04-27 10:05:57.000000000","updated_by":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"reviewer":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"state":"REVIEWER"}],"messages":[{"id":"c228166ff1570192e1dc52b1c5bbca8944db7eba","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32269,"name":"xinyu wang","email":"wangxinyu@inspur.com","username":"xyuwang"},"date":"2021-03-23 02:30:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"375b41b954f174cd0785e49611d73a1d9e164d78","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-23 02:42:17.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0af11c2574ff4d86bcea45b0e97c4383 : SUCCESS in 10m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8a253ef7beb94a0986d569e433a2f23e : FAILURE in 5m 55s","accounts_in_message":[],"_revision_number":1},{"id":"5a33f33d4bc4a8ee6647ee6e11b91f6cf72928df","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2021-03-23 03:37:11.000000000","message":"Patch Set 1:\n\nits far to late my time to review this properly now(3:30 am).\ni just saw this comming in on irc but skiming it quickly i think the idea\nof adding action to join and leave server groups has merrit and deserves consideration.\nill try and find time to review this this week and have started it locally to follow up on it.\nso this is not a review, more a \"yes im surpised we dont support that alredy\" but i have not tough about why we might not supprot it today or read what you have propsoed.","accounts_in_message":[],"_revision_number":1},{"id":"5853030137c31e352a477f3ca4c1c5eeb61793f7","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2021-03-23 03:38:51.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\n-1 is just because this is in the wrong directory and there are pep8 issues you have to fix\nstill have not reviewed it but hopfully you will see this while im asleep 😊","accounts_in_message":[],"_revision_number":1},{"id":"451a4479cb0e0359860566d896f8517f319ab244","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2021-03-23 13:26:10.000000000","message":"Patch Set 1:\n\n(5 comments)\n\nok finished my review.\n\ni dont think the move operation on join/leave are a good design choice.\nif we were to support them then we would not want to use admin_or_owner in this\ncase and i think we would want to supprot spcifying both the type of migration cold/live\nand optionally a host.\n\nso this is not a -1 for the content also not just the fact its in the incorrect folder","accounts_in_message":[],"_revision_number":1},{"id":"4c1a76867f018de0735e2ceea81508d69982ba2c","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-04-14 12:09:57.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"bbdd5232e2253766748b106fa5d1d6f77ace5a36","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-04-14 12:37:28.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f24a7b0d1c6a88fa604043b1c78e435c7c878f73","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2021-04-26 14:30:16.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"63ad0a63f450e17b6ac0e97e20f243ccdc526996","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2021-04-27 10:05:57.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b0046119e35e162b2e66cfb696db5fa9b8313ecf","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-05-25 14:40:56.000000000","message":"Abandoned\n\nThis is still proposed against wallaby. Feel free to reopen it and proposing it against xena.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8255104afbfa774050d00d2e7fa566ad18429060","revisions":{"8255104afbfa774050d00d2e7fa566ad18429060":{"kind":"REWORK","_number":1,"created":"2021-03-23 02:30:35.000000000","uploader":{"_account_id":32269,"name":"xinyu wang","email":"wangxinyu@inspur.com","username":"xyuwang"},"ref":"refs/changes/53/782353/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/53/782353/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/53/782353/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/53/782353/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/53/782353/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/53/782353/1"}}},"commit":{"parents":[{"commit":"95e7b32e7bac391d76524f74b90fd149007a4d36","subject":"Update spec for configurable-instance-hostnames","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/95e7b32e7bac391d76524f74b90fd149007a4d36"}]}],"author":{"name":"wangxinyu","email":"wangxinyu@inspur.com","date":"2021-03-23 02:26:13.000000000","tz":480},"committer":{"name":"wangxinyu","email":"wangxinyu@inspur.com","date":"2021-03-23 02:26:13.000000000","tz":480},"subject":"add instance join/leave server group","message":"add instance join/leave server group\n\nhttps://blueprints.launchpad.net/nova/+spec/join-leave-server-group\n\nadd instance join/leave server group\n\nChange-Id: I7858c50302067b795db0b10e326489d669ea7c7d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/8255104afbfa774050d00d2e7fa566ad18429060"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/8255104afbfa774050d00d2e7fa566ad18429060"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}