)]}'
{"id":"openstack%2Fnova-specs~783806","triplet_id":"openstack%2Fnova-specs~master~Ib3fdda81c1a4dc1406d4245329dab0331e14aba0","project":"openstack/nova-specs","branch":"master","hashtags":[],"change_id":"Ib3fdda81c1a4dc1406d4245329dab0331e14aba0","subject":"Repropose flavour and image defined ephemeral storage encryption","status":"MERGED","created":"2021-03-30 08:29:49.000000000","updated":"2021-05-26 17:07:20.000000000","submitted":"2021-05-26 17:04:49.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":46,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"783806","meta_rev_id":"549bb5d93afca6813467f48d4ffa77c2fa94b1cd","_number":783806,"virtual_id_number":783806,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-05-26 17:04:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":2,"date":"2021-05-26 16:24:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":2,"date":"2021-05-26 14:51:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-05-26 08:05:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":1,"date":"2021-05-26 16:25:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-30 08:49:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-30 19:13:21.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2021-04-14 11:56:31.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2021-05-26 14:51:38.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"}],"messages":[{"id":"160bb77f28f11aab33593837e5455bfadab69eee","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-30 08:29:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3fbcdfa05fd1e24c21f8497caeece8c9ec6949e8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-30 08:49:55.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9eeda8cb59694b61b38d44b976e2ff88 : FAILURE in 4m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8e2da078694b4e1cad8432069df91399 : SUCCESS in 4m 17s","accounts_in_message":[],"_revision_number":1},{"id":"dd19da51a65aabe482dfc2aa8a324a54c59f9bed","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-30 09:11:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ecae434be87b7cbb6728014537fa1709d65aee5a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-30 09:27:33.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8fbbc067944b422a87f311f5d539307e : SUCCESS in 9m 18s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2740aa5fcfa24c5396393d2bfba61d84 : SUCCESS in 4m 11s","accounts_in_message":[],"_revision_number":2},{"id":"6bd37a221514f5f80f7f1c4f93bb1944bef57798","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2021-03-30 19:13:21.000000000","message":"Patch Set 2: Code-Review-1\n\n(14 comments)\n\ni dont think i reviewed this last cycle.\nmy appogies if some of the question are answered later in the spec\nbut i still have some outstanding ones i think hence -1.","accounts_in_message":[],"_revision_number":2},{"id":"c543c16c9358d422abb0edfdceb561f087e59fbe","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-30 20:17:24.000000000","message":"Patch Set 2:\n\n(14 comments)\n\n\u003e Patch Set 2: Code-Review-1\n\u003e \n\u003e (14 comments)\n\u003e \n\u003e i dont think i reviewed this last cycle.\n\u003e my appogies if some of the question are answered later in the spec\n\u003e but i still have some outstanding ones i think hence -1.\n\nNo issues and thanks for the review, I\u0027ll get the libvirt implementation spec reproposed tomorrow as well so they are both up at least. Cheers!","accounts_in_message":[],"_revision_number":2},{"id":"58e548c8246b2c4ae978de8e4bf2cbac0d01a75e","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-04-14 11:56:31.000000000","message":"Patch Set 2: Code-Review+1\n\n(3 comments)\n\noverall looks good. There are some ongoing discussion inline that need to be settled, then I will upgrade to +2","accounts_in_message":[],"_revision_number":2},{"id":"fb40bfc183e04f22865a7140659a8ceb9dcf249a","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-05-25 10:14:31.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"ae886ce5bc1df79bcc02b65c32dab9cb48a70815","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2021-05-25 11:01:15.000000000","message":"Patch Set 2: -Code-Review\n\n(11 comments)","accounts_in_message":[],"_revision_number":2},{"id":"245bf5ba0b75756747eb51c4af4ee8dadf5d6995","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-05-26 08:05:51.000000000","message":"Patch Set 2: Code-Review+2\n\nSean removed the -1 so I upgrade my vote to +2. This looks good to me.","accounts_in_message":[],"_revision_number":2},{"id":"20ffcd7d3247e1daff0f166787f3f0d0cdce5a3d","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-05-26 14:51:38.000000000","message":"Patch Set 2: Code-Review+2\n\nNo significant changes from the Wallaby spec that I can see, so this still LGTM. Will hold off +W until next week to give Sean a chance to spin back arond","accounts_in_message":[],"_revision_number":2},{"id":"0701e4095a45f08330c15328511100d8d5daf0cc","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2021-05-26 16:21:10.000000000","message":"Patch Set 2: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"a5cd4d35735128b172f8a29a63cd0240850e4362","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2021-05-26 16:24:51.000000000","message":"Patch Set 2: Code-Review+2\n\nlee pointed out the traits alrady exist form last cycle so lets just use the exitsing ones","accounts_in_message":[],"_revision_number":2},{"id":"187793d55611e61494ec8608da16eb80d6cfe7e5","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-05-26 16:25:52.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"3b29c17afd8d21811386af48ba5829978df67a10","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 16:26:07.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"098690700ca2f0d07d1ad8238e0e1f58e4290199","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 17:04:39.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9947312eb6f644aba104f1caef4d93d6 : SUCCESS in 9m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5d786285af3249e8a44f44abe97ff6f4 : SUCCESS in 4m 35s","accounts_in_message":[],"_revision_number":2},{"id":"60826cc421bab200c3f6f0c3e1ecc67821a8d072","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 17:04:49.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"549bb5d93afca6813467f48d4ffa77c2fa94b1cd","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 17:07:20.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-specs https://zuul.opendev.org/t/openstack/build/326544b57b7148d2b7616af257bf3732 : SUCCESS in 2m 02s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ecc68ee5655b428a0b70756dd08bddc6ad7e303d","revisions":{"b70cbdcab50571310ac07009814b4b0edbd16e5e":{"kind":"REWORK","_number":1,"created":"2021-03-30 08:29:49.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/06/783806/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/06/783806/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/06/783806/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/06/783806/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/06/783806/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/06/783806/1"}}},"commit":{"parents":[{"commit":"e25ad7219f57accfc7938fb0e2732ee81b840c12","subject":"Create specs directory for Xena","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/e25ad7219f57accfc7938fb0e2732ee81b840c12"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-30 08:19:43.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-30 08:25:49.000000000","tz":60},"subject":"Repropose flavour and image defined ephemeral storage encryption","message":"Repropose flavour and image defined ephemeral storage encryption\n\nThis missed Wallaby due to unforeseen technical debt in the libvirt\nimplementation, reproposing the initial high level UX and scheduling\nspec ahead of rewriting the libvirt implementation spec shortly.\n\nChange-Id: Ib3fdda81c1a4dc1406d4245329dab0331e14aba0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/b70cbdcab50571310ac07009814b4b0edbd16e5e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/b70cbdcab50571310ac07009814b4b0edbd16e5e"}]},"branch":"refs/heads/master"},"ecc68ee5655b428a0b70756dd08bddc6ad7e303d":{"kind":"REWORK","_number":2,"created":"2021-03-30 09:11:59.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/06/783806/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/06/783806/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/06/783806/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/06/783806/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/06/783806/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/06/783806/2"}}},"commit":{"parents":[{"commit":"e25ad7219f57accfc7938fb0e2732ee81b840c12","subject":"Create specs directory for Xena","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/e25ad7219f57accfc7938fb0e2732ee81b840c12"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-30 08:19:43.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-30 09:08:24.000000000","tz":60},"subject":"Repropose flavour and image defined ephemeral storage encryption","message":"Repropose flavour and image defined ephemeral storage encryption\n\nThis missed Wallaby due to unforeseen technical debt in the libvirt\nimplementation, reproposing the initial high level UX and scheduling\nspec ahead of rewriting the libvirt implementation spec shortly.\n\nChange-Id: Ib3fdda81c1a4dc1406d4245329dab0331e14aba0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/ecc68ee5655b428a0b70756dd08bddc6ad7e303d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/ecc68ee5655b428a0b70756dd08bddc6ad7e303d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}
