)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c27802ae1e8c3e015d86010323ad3f41ffa60277","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-03-30 10:51:58 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Repropose configurable-instance-hostnames"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I69ad31ff03695cdaeb42e69289b3fb176190e9ae"},{"line_number":10,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e62d2d60_55d8d232","line":8,"updated":"2021-04-24 11:32:03.000000000","message":"nit: Add \"Previously-approved: wallaby\"","commit_id":"f82a4a43b870eb7c7e9822eae89e66a8bb400f49"}],"specs/xena/approved/configurable-instance-hostnames.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"632d1c5b6956d11f25d81ad06137508badbadac3","unresolved":true,"context_lines":[{"line_number":54,"context_line":"- It cannot end in a dash"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Where multiple instances are requested, hostnames will be suffixed with"},{"line_number":57,"context_line":"``-{idx}``, where ``{idx}`` is a 1-based index. If the combined name and suffix"},{"line_number":58,"context_line":"would exceed the 63 character limit, the name will be rejected."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The ``OS-EXT-SRV-ATTR:hostname`` instance attribute, which is currently"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2484d060_cb834e5d","line":57,"range":{"start_line":57,"start_character":32,"end_line":57,"end_character":40},"updated":"2021-03-30 18:11:37.000000000","message":"this took me a second as i intially readn thsi as base 1 e.g. base 16 but you ment it will start from 1.\n\nmaybe consider \n where ``{idx}`` is a decimal index starting at 1.","commit_id":"f82a4a43b870eb7c7e9822eae89e66a8bb400f49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"632d1c5b6956d11f25d81ad06137508badbadac3","unresolved":true,"context_lines":[{"line_number":60,"context_line":"The ``OS-EXT-SRV-ATTR:hostname`` instance attribute, which is currently"},{"line_number":61,"context_line":"admin-only, will now be shown for non-admin users, since it doesn\u0027t make sense"},{"line_number":62,"context_line":"to allow users to configure the value but not see it."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"},{"line_number":65,"context_line":"------------"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1c243937_c58db7cd","line":63,"updated":"2021-03-30 18:11:37.000000000","message":"a slightly larger change would be to deprecate ``OS-EXT-SRV-ATTR:hostname``\nand add a new hostname value instead which would displayed to admin_or_owner.\nbut ya this makes sense as written too.\n\nthis could be done in a client to make it nice to work with like os but the ux would be nice if it was just hostname. we dont support api extensions anymore so the OS-EXT-SRV-ATTR prefix is kind of redundant.\n\nthat said keeping it for client to not need to be updated is valid too.","commit_id":"f82a4a43b870eb7c7e9822eae89e66a8bb400f49"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5c688bd44bba27e653b82966593b834c25834e00","unresolved":true,"context_lines":[{"line_number":60,"context_line":"The ``OS-EXT-SRV-ATTR:hostname`` instance attribute, which is currently"},{"line_number":61,"context_line":"admin-only, will now be shown for non-admin users, since it doesn\u0027t make sense"},{"line_number":62,"context_line":"to allow users to configure the value but not see it."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"},{"line_number":65,"context_line":"------------"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"983ee65f_52338fc3","line":63,"in_reply_to":"063ce18a_5145c10d","updated":"2021-05-25 14:44:41.000000000","message":"I agree. just to give background on OS-EXT-SRV-ATTR or other extensions fields, they were added in time of extensions time and we discussed to rename them to remove these extra prefix \u0027OS-EXT*\u0027 in single microversion but then abandon the idea as this will impact lot of users without much benefits.\n\nand one we keep touching those API/field in any new microversion then we can keep improving them one by one\n\nso +1 on changin \"OS-EXT-SRV-ATTR:hostname\" \u003e \"hostname\" everyhwree","commit_id":"f82a4a43b870eb7c7e9822eae89e66a8bb400f49"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f5c871c0b709afd658a39cd2a1f1d910c01638c6","unresolved":true,"context_lines":[{"line_number":60,"context_line":"The ``OS-EXT-SRV-ATTR:hostname`` instance attribute, which is currently"},{"line_number":61,"context_line":"admin-only, will now be shown for non-admin users, since it doesn\u0027t make sense"},{"line_number":62,"context_line":"to allow users to configure the value but not see it."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"},{"line_number":65,"context_line":"------------"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"d5c6a45f_17df56bf","line":63,"in_reply_to":"1c243937_c58db7cd","updated":"2021-04-27 10:21:37.000000000","message":"also think the `OS-EXT-SRV-ATTR:hostname` is useless anymore. using for the new \u0027hostname\u0027 for write and read.","commit_id":"f82a4a43b870eb7c7e9822eae89e66a8bb400f49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fcda93b03eb5c4cbfec093272296ce64af56a249","unresolved":true,"context_lines":[{"line_number":60,"context_line":"The ``OS-EXT-SRV-ATTR:hostname`` instance attribute, which is currently"},{"line_number":61,"context_line":"admin-only, will now be shown for non-admin users, since it doesn\u0027t make sense"},{"line_number":62,"context_line":"to allow users to configure the value but not see it."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"},{"line_number":65,"context_line":"------------"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"063ce18a_5145c10d","line":63,"in_reply_to":"d5c6a45f_17df56bf","updated":"2021-04-28 23:39:11.000000000","message":"the current proposal is to keep OS-EXT-SRV-ATTR:hostname in the  server details responce but\nadd a new hostname filed in the post body.\n\nso currently stephen is not proposing adding a hostname field to the server responce.\n\ni was suggesting removing \"OS-EXT-SRV-ATTR:hostname\" and adding a \"hostname\" to both the post and to the server details responces.","commit_id":"f82a4a43b870eb7c7e9822eae89e66a8bb400f49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"632d1c5b6956d11f25d81ad06137508badbadac3","unresolved":true,"context_lines":[{"line_number":96,"context_line":"- It must be 63 characters or less"},{"line_number":97,"context_line":"- It must consist of alphanumeric characters and dashes (``-``). Periods,"},{"line_number":98,"context_line":"  underscores, and other characters outside this set will be rejected"},{"line_number":99,"context_line":"- It cannot end in a dash"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Where multiple instances are requested, hostnames will be suffixed with"},{"line_number":102,"context_line":"``-{idx}``, where ``{idx}`` is a 1-based index. If the combined name and suffix"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dc6ff1aa_989b0c5d","line":99,"range":{"start_line":99,"start_character":12,"end_line":99,"end_character":15},"updated":"2021-03-30 18:11:37.000000000","message":"end or start with a dash?\n\nim not sure we want to allow -my-vm or my-vm- or -my-vm-\n\nsome of those might be technically legal host names but my-vm is the only one out of the 4 i would suggest we shoudl treat as valid for your api.","commit_id":"f82a4a43b870eb7c7e9822eae89e66a8bb400f49"}]}